Re: [Qemu-devel] [PATCH 6/8] Clean up ill-advised or unusual header guards

2019-03-15 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 3/15/19 3:51 PM, Markus Armbruster wrote: >> Leading underscores are ill-advised because such identifiers are >> reserved. Trailing underscores are merely ugly. Strip both. >> >> Our header guards commonly end in _H. Normalize the exceptions. >> >> Done wi

Re: [Qemu-devel] [PATCH 2/2] filemon: ensure watch IDs are unique to QFileMonitor scope

2019-03-15 Thread Bandan Das
Daniel P. Berrangé writes: ... >> Thanks, this fixes it! I had a related question about the way >> qemu_file_monitor_add_watch works. >> >> Am I correct in understanding that if there is already a watch on a dir, >> we return back mon->nextid++ i.e the next free id. Why don't we return >> back th

Re: [Qemu-devel] [PATCH] authz: Use OBJECT_CHECK() on objects

2019-03-15 Thread Daniel P . Berrangé
On Fri, Mar 15, 2019 at 06:12:18PM +0100, Philippe Mathieu-Daudé wrote: > TYPE_QAUTHZ is an abstract object of type TYPE_OBJECT. All other > are children of TYPE_QAUTHZ, thus also objects. > > Keep INTERFACE_CHECK() for interfaces, and use OBJECT_CHECK() on > objects. Hmm #define OBJECT_CHECK(

Re: [Qemu-devel] [PATCH] target/riscv: Fix manually parsed 16 bit insn

2019-03-15 Thread Alistair Francis
On Fri, Mar 15, 2019 at 7:15 AM Bastian Koppelmann wrote: > > during the refactor to decodetree we removed the manual decoding that is > necessary for c.jal/c.addiw and removed the translation of c.flw/c.ld > and c.fsw/c.sd. This reintroduces the manual parsing and the > omited implementation. > >

Re: [Qemu-devel] [PATCH 2/2] filemon: ensure watch IDs are unique to QFileMonitor scope

2019-03-15 Thread Daniel P . Berrangé
On Fri, Mar 15, 2019 at 01:24:42PM -0400, Bandan Das wrote: > Daniel P. Berrangé writes: > ... > >> Thanks, this fixes it! I had a related question about the way > >> qemu_file_monitor_add_watch works. > >> > >> Am I correct in understanding that if there is already a watch on a dir, > >> we retu

Re: [Qemu-devel] State of QEMU CI as we enter 4.0

2019-03-15 Thread Alex Bennée
Ed Vielmetti writes: > We have been trying to merge the Gitlab runner patches for arm64 > for over a year now; see > > https://gitlab.com/gitlab-org/gitlab-runner/merge_requests/725 Yes I found that one. I'm trying to work out exactly how there build system works. It seems to build all archite

[Qemu-devel] [PATCH] docs: reST-ify vhost-user documentation

2019-03-15 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau --- MAINTAINERS |2 +- docs/interop/index.rst |2 +- docs/interop/vhost-user.rst | 1351 +++ docs/interop/vhost-user.txt | 1219 --- 4 files changed, 1353 insertions(+), 1221

Re: [Qemu-devel] [PATCH] xen-mapcache: use MAP_FIXED flag so the mmap address hint is always honored

2019-03-15 Thread Anthony PERARD
On Fri, Mar 15, 2019 at 09:58:47AM +0100, Roger Pau Monne wrote: > Or if it's not possible to honor the hinted address an error is returned > instead. This makes it easier to spot the actual failure, instead of > failing later on when the caller of xen_remap_bucket realizes the > mapping has not be

Re: [Qemu-devel] State of QEMU CI as we enter 4.0

2019-03-15 Thread Ed Vielmetti
There are a couple of options hosted at Packet - Shippable, Codefresh, and Drone. I perhaps know more about Drone than the others. Each of them have a supported/sponsored version which can be used to produce arm64 binaries natively. I'll admit to dropping into this conversation in mid-stream thoug

[Qemu-devel] [PATCH] configure: disallow spaces and colons in source path

2019-03-15 Thread Antonio Ospite
From: Antonio Ospite The configure script breaks when the qemu source directory is in a path containing white spaces, in particular the list of targets is not correctly generated when calling "./configure --help". To avoid this issue, refuse to run the configure script if there are spaces or col

Re: [Qemu-devel] [PATCH] xen-mapcache: use MAP_FIXED flag so the mmap address hint is always honored

2019-03-15 Thread Anthony PERARD
On Fri, Mar 15, 2019 at 09:54:42AM +, Paul Durrant wrote: > AFAICT xen_remap_bucket() is always called with a NULL vaddr argument > if entry->vaddr_base == NULL, and called with vaddr == > entry->vaddr_base in the other case, so I'd say the vaddr argument is > superfluous. I don't think that's

Re: [Qemu-devel] [PATCH v5 1/5] RISC-V: Add 32-bit gdb xml files.

2019-03-15 Thread Alistair Francis
On Fri, Mar 15, 2019 at 7:42 AM Chih-Min Chao wrote: > > From: Jim Wilson > > Signed-off-by: Jim Wilson > Signed-off-by: Chih-Min Chao This looks good, I didn't dig into every register here, but I'm assuming it's correct. Reviewed-by: Alistair Francis Alistair > --- > configure

Re: [Qemu-devel] [PATCH v5 2/5] RISC-V: Add 64-bit gdb xml files.

2019-03-15 Thread Alistair Francis
On Fri, Mar 15, 2019 at 7:09 AM Chih-Min Chao wrote: > > From: Jim Wilson > > Signed-off-by: Jim Wilson > Signed-off-by: Chih-Min Chao Reviewed-by: Alistair Francis Alistair > --- > configure | 1 + > gdb-xml/riscv-32bit-fpu.xml | 6 +- > gdb-xml/riscv-64bit-cpu.xml |

Re: [Qemu-devel] [PATCH] authz: Use OBJECT_CHECK() on objects

2019-03-15 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Fri, Mar 15, 2019 at 06:12:18PM +0100, Philippe Mathieu-Daudé wrote: >> TYPE_QAUTHZ is an abstract object of type TYPE_OBJECT. All other >> are children of TYPE_QAUTHZ, thus also objects. >> >> Keep INTERFACE_CHECK() for interfaces, and use OBJECT_CHECK() on >> ob

Re: [Qemu-devel] Maintainers, please tell us how to boot your machines!

2019-03-15 Thread Thomas Huth
Am Wed, 13 Mar 2019 02:06:39 +0100 schrieb Philippe Mathieu-Daudé : > On Tue, Mar 12, 2019 at 6:44 PM Markus Armbruster > wrote: [...] > > I gathered the machine types, mapped them to source files, which I > > fed to get_maintainer.pl. Results are appended. If you're cc'ed, > > MAINTAINERS fing

Re: [Qemu-devel] [PATCH v5 0/5] RISC-V: Add gdb xml files and gdbstub support

2019-03-15 Thread Alistair Francis
On Fri, Mar 15, 2019 at 6:45 AM Chih-Min Chao wrote: > > This is the 5th version of the patch set, based on the Jim's previous work, > http://lists.nongnu.org/archive/html/qemu-riscv/2019-02/msg00059.html > > v4 -> v5: >- rebase 7074ab1 >- update the register xml files to

Re: [Qemu-devel] [PATCH v8 3/6] ui: add keycodemapdb repository as a GIT submodule

2019-03-15 Thread Peter Maydell
On Fri, 29 Sep 2017 at 11:12, Daniel P. Berrange wrote: > > The https://gitlab.com/keycodemap/keycodemapdb/ repo contains a > data file mapping between all the different scancode/keycode/keysym > sets that are known, and a tool to auto-generate lookup tables for > different combinations Hi Dan; a

Re: [Qemu-devel] [PATCH v5 5/5] RISC-V: Add hooks to use the gdb xml files.

2019-03-15 Thread Alistair Francis
On Fri, Mar 15, 2019 at 7:01 AM Chih-Min Chao wrote: > > From: Jim Wilson > > The gdb CSR xml file has registers in documentation order, not numerical > order, so we need a table to map the register numbers. This also adds > fairly standard gdb hooks to access xml specified registers. > > notice

Re: [Qemu-devel] [PATCH] xen-mapcache: use MAP_FIXED flag so the mmap address hint is always honored

2019-03-15 Thread Anthony PERARD
On Fri, Mar 15, 2019 at 06:14:09PM +, Anthony PERARD wrote: > On Fri, Mar 15, 2019 at 09:58:47AM +0100, Roger Pau Monne wrote: > > Or if it's not possible to honor the hinted address an error is returned > > instead. This makes it easier to spot the actual failure, instead of > > failing later

Re: [Qemu-devel] [PATCH] configure: disallow spaces and colons in source path

2019-03-15 Thread Peter Maydell
On Fri, 15 Mar 2019 at 18:26, Antonio Ospite wrote: > > From: Antonio Ospite > > The configure script breaks when the qemu source directory is in a path > containing white spaces, in particular the list of targets is not > correctly generated when calling "./configure --help". > > To avoid this i

Re: [Qemu-devel] [PATCH] configure: disallow spaces and colons in source path

2019-03-15 Thread Eric Blake
On 3/15/19 12:50 PM, Antonio Ospite wrote: > From: Antonio Ospite > > The configure script breaks when the qemu source directory is in a path > containing white spaces, in particular the list of targets is not > correctly generated when calling "./configure --help". > > To avoid this issue, refu

Re: [Qemu-devel] [PATCH] configure: disallow spaces and colons in source path

2019-03-15 Thread Eric Blake
On 3/15/19 1:40 PM, Peter Maydell wrote: > If you do this after the point where we make the source path absolute, you > can skip the realpath (which avoids the problem that 'realpath' doesn't exist > on OSX by default). It will also then be after the handling of the > --source-path option argument

Re: [Qemu-devel] Maintainers, please tell us how to boot your machines!

2019-03-15 Thread Aleksandar Markovic
> From: Thomas Huth > Subject: Re: Maintainers, please tell us how to boot your machines! > > > On Tue, Mar 12, 2019 at 6:44 PM Markus Armbruster > > wrote: > [...] > > > I gathered the machine types, mapped them to source files, which I > > > fed to get_maintainer.pl. Results are appended. If

Re: [Qemu-devel] [PATCH v2 00/12] bundle edk2 platform firmware with QEMU

2019-03-15 Thread Eric Blake
On 3/15/19 11:42 AM, Philippe Mathieu-Daudé wrote: > Hi, > >>From my previous experience with the tests/ patches, I understood we > could still send PR that improve testing after soft freeze. > This series doesn't modify the QEMU binaries, it add EDK2 firmware blobs > in roms/ and rules to rebuild

Re: [Qemu-devel] State of QEMU CI as we enter 4.0

2019-03-15 Thread Alex Bennée
Ed Vielmetti writes: > There are a couple of options hosted at Packet - Shippable, Codefresh, and > Drone. I perhaps know more about Drone than the others. Each of them have a > supported/sponsored version which can be used to produce arm64 binaries > natively. > > I'll admit to dropping into t

Re: [Qemu-devel] [PATCH for-4.0?] arm: Allow system registers for KVM guests to be changed by QEMU code

2019-03-15 Thread Richard Henderson
On 3/15/19 7:30 AM, Peter Maydell wrote: > This commit is the same as commit 823e1b3818f9b10b824ddc which we > had to revert in commit 942f99c825fc94c8b1a4, except that the bug > which was preventing EDK2 guest firmware running has been fixed: > kvm_arm_reset_vcpu() now calls write_list_to_cpustate

Re: [Qemu-devel] [PATCH for-4.0?] arm: Allow system registers for KVM guests to be changed by QEMU code

2019-03-15 Thread Philippe Mathieu-Daudé
On 3/15/19 3:30 PM, Peter Maydell wrote: > At the moment the Arm implementations of kvm_arch_{get,put}_registers() > don't support having QEMU change the values of system registers > (aka coprocessor registers for AArch32). This is because although > kvm_arch_get_registers() calls write_list_to_cpu

[Qemu-devel] [PATCH v1 1/1] riscv: plic: Set msi_nonbroken as true

2019-03-15 Thread Alistair Francis
Set msi_nonbroken as true for the PLIC. According to the comment located here: https://git.qemu.org/?p=qemu.git;a=blob;f=hw/pci/msi.c;h=47d2b0f33c664533b8dbd5cb17faa8e6a01afe1f;hb=HEAD#l38 the msi_nonbroken variable should be set to true even if they don't support MSI. In this case that is what we

Re: [Qemu-devel] [PATCH] xen-mapcache: use MAP_FIXED flag so the mmap address hint is always honored

2019-03-15 Thread Igor Druzhinin
On 15/03/2019 18:38, Anthony PERARD wrote: > On Fri, Mar 15, 2019 at 06:14:09PM +, Anthony PERARD wrote: >> On Fri, Mar 15, 2019 at 09:58:47AM +0100, Roger Pau Monne wrote: >>> Or if it's not possible to honor the hinted address an error is returned >>> instead. This makes it easier to spot the

Re: [Qemu-devel] [PATCH v2 0/2] ati-vga: Implement DDC and EDID info from monitor

2019-03-15 Thread no-reply
Patchew URL: https://patchew.org/QEMU/cover.1552659955.git.bala...@eik.bme.hu/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash time ma

[Qemu-devel] [PATCH v3 2/2] ati-vga: Implement DDC and EDID info from monitor

2019-03-15 Thread BALATON Zoltan
This adds DDC support to ati-vga and connects i2c-ddc to provide EDID info that is read by guests to find available screen modes. Not sure if this is 100% correct yet but at least MorphOS is happy with it and starts in a high resolution mode instead of 640x480 (although its splash screen is still n

[Qemu-devel] [PATCH v3 1/2] i2c: Move bitbang_i2c.h to include/hw/i2c/

2019-03-15 Thread BALATON Zoltan
The bitbang i2c implementation is also useful for other device models such as DDC in display controllers. Move the header to include/hw/i2c/ to allow it to be used from other device models and adjust users of this include. This also reverts commit 2b4c1125ac which is no longer needed. Signed-off-b

[Qemu-devel] [PATCH v3 0/2] ati-vga: Implement DDC and EDID info from monitor

2019-03-15 Thread BALATON Zoltan
Version 3 keeps bitbang_i2c.h and moves it to include/hw/i2c/ otherwise same as version 2. BALATON Zoltan (2): i2c: Move bitbang_i2c.h to include/hw/i2c/ ati-vga: Implement DDC and EDID info from monitor hw/display/Kconfig | 2 ++ hw/display/ati.c | 43

Re: [Qemu-devel] [PATCH v3 0/2] ati-vga: Implement DDC and EDID info from monitor

2019-03-15 Thread no-reply
Patchew URL: https://patchew.org/QEMU/cover.1552689690.git.bala...@eik.bme.hu/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash time ma

Re: [Qemu-devel] [PATCH v1 00/12] Upstream RISC-V fork patches, part 4

2019-03-15 Thread Alistair Francis
On Fri, Mar 15, 2019 at 6:19 PM Alistair Francis wrote: > > v3: > - Add a patch to remove some dead code > - Rebase on master > v2: > - Add a patch for SiFive U SMP support > - Rebase on master > > Alistair Francis (3): > riscv: pmp: Log pmp access errors as guest errors > riscv: sifive_u:

[Qemu-devel] [PATCH v1 11/12] riscv: sifive_u: Allow up to 4 CPUs to be created

2019-03-15 Thread Alistair Francis
Signed-off-by: Alistair Francis --- hw/riscv/sifive_u.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/riscv/sifive_u.c b/hw/riscv/sifive_u.c index 7bc25820fe..3199238ba0 100644 --- a/hw/riscv/sifive_u.c +++ b/hw/riscv/sifive_u.c @@ -398,7 +398,10 @@ static void riscv_

[Qemu-devel] [PATCH v1 10/12] RISC-V: Update load reservation comment in do_interrupt

2019-03-15 Thread Alistair Francis
From: Michael Clark Cc: Palmer Dabbelt Cc: Alistair Francis Signed-off-by: Michael Clark Signed-off-by: Alistair Francis --- target/riscv/cpu_helper.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/target/riscv/cpu_helper.c b/target/riscv/cpu_helper.c index 6d3fbc

[Qemu-devel] [PATCH v1 05/12] elf: Add RISC-V PSABI ELF header defines

2019-03-15 Thread Alistair Francis
From: Michael Clark Refer to the RISC-V PSABI specification for details: - https://github.com/riscv/riscv-elf-psabi-doc/blob/master/riscv-elf.md Cc: Michael Tokarev Cc: Richard Henderson Cc: Alistair Francis Reviewed-by: Laurent Vivier Signed-off-by: Michael Clark Signed-off-by: Alistair F

[Qemu-devel] [PATCH v1 12/12] target/riscv: Remove unused struct

2019-03-15 Thread Alistair Francis
Signed-off-by: Alistair Francis --- target/riscv/cpu.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index cc3ddc0ae4..568c4cd637 100644 --- a/target/riscv/cpu.c +++ b/target/riscv/cpu.c @@ -80,12 +80,6 @@ const char * const riscv_intr_names[] =

[Qemu-devel] [PATCH v1 08/12] RISC-V: Add support for vectored interrupts

2019-03-15 Thread Alistair Francis
From: Michael Clark If vectored interrupts are enabled (bits[1:0] of mtvec/stvec == 1) then use the following logic for trap entry address calculation: pc = mtvec + cause * 4 In addition to adding support for vectored interrupts this patch simplifies the interrupt delivery logic by making sync

[Qemu-devel] [PATCH v1 07/12] RISC-V: Change local interrupts from edge to level

2019-03-15 Thread Alistair Francis
From: Michael Clark This effectively changes riscv_cpu_update_mip from edge to level. i.e. cpu_interrupt or cpu_reset_interrupt are called regardless of the current interrupt level. Fixes WFI doesn't return when a IPI is issued: - https://github.com/riscv/riscv-qemu/issues/132 To test: 1) App

[Qemu-devel] [PATCH v1 03/12] RISC-V: Allow interrupt controllers to claim interrupts

2019-03-15 Thread Alistair Francis
From: Michael Clark We can't allow the supervisor to control SEIP as this would allow the supervisor to clear a pending external interrupt which will result in lost a interrupt in the case a PLIC is attached. The SEIP bit must be hardware controlled when a PLIC is attached. This logic was previo

[Qemu-devel] [PATCH v1 06/12] RISC-V: linux-user support for RVE ABI

2019-03-15 Thread Alistair Francis
From: Kito Cheng This change checks elf_flags for EF_RISCV_RVE and if present uses the RVE linux syscall ABI which uses t0 for the syscall number instead of a7. Warn and exit if a non-RVE ABI binary is run on a cpu with the RVE extension as it is incompatible. Cc: Palmer Dabbelt Cc: Sagar Kara

[Qemu-devel] [PATCH v1 04/12] RISC-V: Remove unnecessary disassembler constraints

2019-03-15 Thread Alistair Francis
From: Michael Clark Remove machine generated constraints that are not referenced by the pseudo-instruction constraints. Cc: Palmer Dabbelt Cc: Sagar Karandikar Cc: Bastian Koppelmann Cc: Alistair Francis Signed-off-by: Michael Clark Signed-off-by: Alistair Francis --- disas/riscv.c | 138

[Qemu-devel] [PATCH v1 09/12] RISC-V: Convert trap debugging to trace events

2019-03-15 Thread Alistair Francis
From: Michael Clark Cc: Palmer Dabbelt Cc: Alistair Francis Signed-off-by: Michael Clark Signed-off-by: Alistair Francis --- Makefile.objs | 1 + target/riscv/cpu_helper.c | 12 +++- target/riscv/trace-events | 2 ++ 3 files changed, 6 insertions(+), 9 deletions(-) cre

[Qemu-devel] [PATCH v1 02/12] RISC-V: Replace __builtin_popcount with ctpop8 in PLIC

2019-03-15 Thread Alistair Francis
From: Michael Clark The mode variable only uses the lower 4-bits (M,H,S,U) so replace the GCC specific __builtin_popcount with ctpop8. Cc: Palmer Dabbelt Cc: Sagar Karandikar Cc: Bastian Koppelmann Cc: Alistair Francis Signed-off-by: Michael Clark Signed-off-by: Alistair Francis --- hw/ri

[Qemu-devel] [PATCH v1 01/12] riscv: pmp: Log pmp access errors as guest errors

2019-03-15 Thread Alistair Francis
Signed-off-by: Alistair Francis --- target/riscv/pmp.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/target/riscv/pmp.c b/target/riscv/pmp.c index 15a5366616..b11c4ae22f 100644 --- a/target/riscv/pmp.c +++ b/target/riscv/pmp.c @@ -113,10 +113,11 @@ stat

[Qemu-devel] [PATCH v1 00/12] Upstream RISC-V fork patches, part 4

2019-03-15 Thread Alistair Francis
v3: - Add a patch to remove some dead code - Rebase on master v2: - Add a patch for SiFive U SMP support - Rebase on master Alistair Francis (3): riscv: pmp: Log pmp access errors as guest errors riscv: sifive_u: Allow up to 4 CPUs to be created target/riscv: Remove unused struct Kito C

[Qemu-devel] Set up github repo for pmon sources

2019-03-15 Thread Andrew Randrianasulu
https://github.com/Randrianasulu/pmon/commits/2014 hopefully it will stay this way. Anyone know what license I must pick for this? 3-clause BSD? 4-clause BSD? (from Copyright file it lists 4 terms) * $Id: Copyright,v 1.1.1.1 2006/09/14 01:59:06 root Exp $ */ /* *

[Qemu-devel] [Bug 1817865] Re: sorecvfrom freezes guest

2019-03-15 Thread Vic
Fix committed in slirp/src/socket.c ** Changed in: qemu Status: New => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1817865 Title: sorecvfrom freezes guest Status in QEMU:

Re: [Qemu-devel] [PATCH] scripts/make-release: Stop shipping u-boot source as a tarball

2019-03-15 Thread Michael Roth
Quoting Peter Maydell (2019-03-14 10:56:28) > In commit d0dead3b6df7f6cd970e we changed to shipping the u-boot > sources as a tarball, to work around a problem where they > contained a file and directory that had the same name except > for case, which was preventing QEMU's source tarball being > un

<    1   2   3