On 3/15/19 1:40 PM, Peter Maydell wrote: > If you do this after the point where we make the source path absolute, you > can skip the realpath (which avoids the problem that 'realpath' doesn't exist > on OSX by default). It will also then be after the handling of the > --source-path option argument. > > Do we also need to check for spaces in the path of the build directory > (which is always the current working directory of the script) ?
I wasn't thinking about VPATH builds, but yes, in general, we should ensure that both srcdir and builddir are sane names, while still allowing symlinks to work around otherwise problematic canonical names. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
