[Qemu-devel] [PATCH] hw/acpi: extract acpi_add_rom_blob()

2019-03-14 Thread Wei Yang
arm and i386 has almost the same function acpi_add_rom_blob(), except giving different FWCfgCallback function. This patch extract acpi_add_rom_blob() to aml-build.c by passing FWCfgCallback to it. Signed-off-by: Wei Yang --- hw/acpi/aml-build.c | 8 hw/arm/virt-acpi-build.c

Re: [Qemu-devel] [PULL] target/riscv: Convert to decodetree

2019-03-14 Thread Peter Maydell
On Wed, 13 Mar 2019 at 14:37, Palmer Dabbelt wrote: > > merged tag 'pull-request-2019-03-12' > Primary key fingerprint: 27B8 8847 EEE0 2501 18F3 EAB9 2ED9 D774 FE70 2DB5 > The following changes since commit 3f3bbfc7cef4490c5ed5550766a81e7d18f08db1: > > Merge remote-tracking branch > 'remotes/h

[Qemu-devel] [PATCH v2] hw/acpi: extract acpi_add_rom_blob()

2019-03-14 Thread Wei Yang
arm and i386 has almost the same function acpi_add_rom_blob(), except giving different FWCfgCallback function. This patch extract acpi_add_rom_blob() to aml-build.c by passing FWCfgCallback to it. Signed-off-by: Wei Yang --- v2: * remove unused header in original source file --- hw/acpi/aml-

Re: [Qemu-devel] [PATCH v2 07/14] ui/vnc: Use qcrypto_random_bytes for make_challenge

2019-03-14 Thread Gerd Hoffmann
On Wed, Mar 13, 2019 at 09:55:19PM -0700, Richard Henderson wrote: > Use a better interface for random numbers than rand, > plus some useless floating point arithmetic. > > Cc: Gerd Hoffmann > Signed-off-by: Richard Henderson Reviewed-by: Gerd Hoffmann

Re: [Qemu-devel] [PATCH v2 04/13] spapr/xive: add state synchronization with KVM

2019-03-14 Thread Cédric Le Goater
On 3/14/19 3:10 AM, David Gibson wrote: > On Mon, Mar 11, 2019 at 09:41:12PM +0100, Cédric Le Goater wrote: >> On 2/26/19 1:01 AM, David Gibson wrote: >>> On Fri, Feb 22, 2019 at 02:13:13PM +0100, Cédric Le Goater wrote: This extends the KVM XIVE device backend with 'synchronize_state' me

Re: [Qemu-devel] [Qemu-ppc] [PATCH v5 1/2] spapr: helper functions to get valid host fields

2019-03-14 Thread Greg Kurz
On Wed, 13 Mar 2019 18:16:18 -0300 "Maxiwell S. Garcia" wrote: > On Tue, Mar 12, 2019 at 11:52:24AM +0100, Greg Kurz wrote: > > Hi Greg, > Hi Maxiwell, > > On Mon, 11 Mar 2019 19:57:08 -0300 > > "Maxiwell S. Garcia" wrote: > > > > > The pseries options 'host-serial' and 'host-model' accep

[Qemu-devel] [PATCH 1/5] aspeed/timer: Fix behaviour running Linux

2019-03-14 Thread Cédric Le Goater
From: Joel Stanley The Linux kernel driver was updated in commit 4451d3f59f2a ("clocksource/drivers/fttmr010: Fix set_next_event handler) to fix an issue observed on hardware: > RELOAD register is loaded into COUNT register when the aspeed timer > is enabled, which means the next event may be

[Qemu-devel] [PATCH 0/5] aspeed/timer: Fix slowdowns in recent Linux

2019-03-14 Thread Cédric Le Goater
Hello, This series was initially sent by Andrew on the OpenBMC list : https://lists.ozlabs.org/pipermail/openbmc/2019-January/014640.html We had an issue with the introduction of 4451d3f59f2a ("clocksource/drivers/fttmr010: Fix set_next_event handler") in Linux where our QEMU Aspeed machine we

[Qemu-devel] [PATCH 2/5] aspeed/timer: Status register contains reload for stopped timer

2019-03-14 Thread Cédric Le Goater
From: Andrew Jeffery >From the datasheet: This register stores the current status of counter #N. When timer enable bit TMC30[N * b] is disabled, the reload register will be loaded into this counter. When timer bit TMC30[N * b] is set, the counter will start to decrement. CPU can update t

[Qemu-devel] [PATCH 3/5] aspeed/timer: Fix match calculations

2019-03-14 Thread Cédric Le Goater
From: Andrew Jeffery If the match value exceeds reload then we don't want to include it in calculations for the next event. Signed-off-by: Andrew Jeffery Signed-off-by: Cédric Le Goater --- hw/timer/aspeed_timer.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --gi

[Qemu-devel] [PATCH 4/5] aspeed/timer: Provide back-pressure information for short periods

2019-03-14 Thread Cédric Le Goater
From: Andrew Jeffery First up: This is not the way the hardware behaves. However, it helps resolve real-world problems with short periods being used under Linux. Commit 4451d3f59f2a ("clocksource/drivers/fttmr010: Fix set_next_event handler") in Linux fixed the timer driver to correctly schedule

[Qemu-devel] [PATCH 5/5] aspeed/timer: Use signed muldiv for timer resets

2019-03-14 Thread Cédric Le Goater
From: Christian Svensson If the host decrements the counter register that results in a negative delta. This is then passed to muldiv64 which only handles unsigned numbers resulting in bogus results. This fix ensures the data being operated on is signed before it is ultimately casted to the final

Re: [Qemu-devel] [PATCH 0/5] aspeed/timer: Fix slowdowns in recent Linux

2019-03-14 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190314084235.9887-1-...@kaod.org/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/b

[Qemu-devel] [PATCH] qapi: fix block-latency-histogram-set description and examples

2019-03-14 Thread Vladimir Sementsov-Ogievskiy
There no @device parameter, only the @id one. Signed-off-by: Vladimir Sementsov-Ogievskiy --- qapi/block-core.json | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/qapi/block-core.json b/qapi/block-core.json index ca684a8a04..7c1d47365d 100644 --- a/qapi/block-core.

Re: [Qemu-devel] [PULL 03/28] qapi: move to QOM path for x-block-latency-histogram-set

2019-03-14 Thread Vladimir Sementsov-Ogievskiy
12.03.2019 20:30, Kevin Wolf wrote: > From: Vladimir Sementsov-Ogievskiy > > Signed-off-by: Vladimir Sementsov-Ogievskiy > Signed-off-by: Kevin Wolf Not critical, but it is v4, when in v5 description and examples were fixed to be s/device/id. I'll send a follow-up. > --- > qapi/block-core.

[Qemu-devel] [PATCH] ati-vga: i2c fix

2019-03-14 Thread Gerd Hoffmann
gets radeonfb going for me, on top of your i2c patches. --- hw/display/ati_int.h | 1 + hw/display/ati_regs.h | 1 + hw/display/ati.c | 35 +++ 3 files changed, 29 insertions(+), 8 deletions(-) diff --git a/hw/display/ati_int.h b/hw/display/ati_int.h index

Re: [Qemu-devel] [PATCH 5/5] aspeed/timer: Use signed muldiv for timer resets

2019-03-14 Thread Cédric Le Goater
Christian, Could you please provide a fix for this patch ? patchew complains, see attached log. Thanks, C. On 3/14/19 9:42 AM, Cédric Le Goater wrote: > From: Christian Svensson > > If the host decrements the counter register that results in a negative > delta. This is then passed to muldiv6

Re: [Qemu-devel] [PATCH] ui/cocoa: Adding cursor support

2019-03-14 Thread Chen Zhang via Qemu-devel
> On Mar 14, 2019, at 1:35 AM, BALATON Zoltan wrote: > > On Wed, 13 Mar 2019, Chen Zhang wrote: >> I sympathize with your situation, but the things on macOS seems a little >> different. >> >> The QEMU Cocoa UI starts in the `main` thread and detach a `qemu_main` >> thread which runs stuff i

Re: [Qemu-devel] [PATCH 0/5] aspeed/timer: Fix slowdowns in recent Linux

2019-03-14 Thread Cédric Le Goater
Hello, For the time being, we can drop patch 5 from this series. Thanks, C. On 3/14/19 9:59 AM, no-re...@patchew.org wrote: > Patchew URL: https://patchew.org/QEMU/20190314084235.9887-1-...@kaod.org/ > > > > Hi, > > This series failed the docker-mingw@fedora build test. Please find the >

Re: [Qemu-devel] [PATCH v2] hw/acpi: extract acpi_add_rom_blob()

2019-03-14 Thread Igor Mammedov
On Thu, 14 Mar 2019 15:38:36 +0800 Wei Yang wrote: > arm and i386 has almost the same function acpi_add_rom_blob(), except > giving different FWCfgCallback function. > > This patch extract acpi_add_rom_blob() to aml-build.c by passing > FWCfgCallback to it. > > Signed-off-by: Wei Yang > > ---

Re: [Qemu-devel] [PATCH v6 05/11] {hmp, hw/pvrdma}: Expose device internals via monitor interface

2019-03-14 Thread Marcel Apfelbaum
On 3/11/19 12:29 PM, Yuval Shaia wrote: Allow interrogating device internals through HMP interface. The exposed indicators can be used for troubleshooting by developers or sysadmin. There is no need to expose these attributes to a management system (e.x. libvirt) because (1) most of them are n

Re: [Qemu-devel] [PATCH for-4.0] maint: Ignore built elf2dmp

2019-03-14 Thread Stefano Garzarella
On Wed, Mar 13, 2019 at 09:45:57AM -0500, Eric Blake wrote: > Commit 3fa2d384 added a binary 'elf2dmp' but did not ignore it > during an in-tree build. > > Signed-off-by: Eric Blake > --- > > Yes, I know we want to get rid of in-tree builds for 4.1; but > for 4.0, this patch may still make sense

Re: [Qemu-devel] [PATCH v6 11/11] hw/pvrdma: Provide correct value to object_get_typename

2019-03-14 Thread Marcel Apfelbaum
On 3/11/19 12:29 PM, Yuval Shaia wrote: Use base object of PCIDevice in call to object_get_typename(). Signed-off-by: Yuval Shaia --- hw/rdma/vmw/pvrdma_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/rdma/vmw/pvrdma_main.c b/hw/rdma/vmw/pvrdma_main.c index 4

Re: [Qemu-devel] [RFC PATCH 3/3] hw/acpi: Extract build_mcfg

2019-03-14 Thread Igor Mammedov
On Wed, 13 Mar 2019 21:31:37 + Wei Yang wrote: > On Wed, Mar 13, 2019 at 05:09:43PM +0100, Igor Mammedov wrote: > >On Wed, 13 Mar 2019 13:33:59 + > >Wei Yang wrote: > > > >> On Wed, Mar 13, 2019 at 01:23:00PM +0100, Igor Mammedov wrote: > >> >On Wed, 13 Mar 2019 12:42:53 +0800 > >> >

Re: [Qemu-devel] [PATCH 2/4] hw/rdma: Remove unused parameter from rdma_poll_cq()

2019-03-14 Thread Marcel Apfelbaum
On 3/13/19 10:46 AM, Kamal Heib wrote: The 'rdma_dev_res' parameter is not used in rdma_poll_cq(), so remove it. Signed-off-by: Kamal Heib --- hw/rdma/rdma_backend.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/hw/rdma/rdma_backend.c b/hw/rdma/rdma_backend.c

Re: [Qemu-devel] [PATCH v6 01/11] hw/rdma: Switch to generic error reporting way

2019-03-14 Thread Marcel Apfelbaum
On 3/12/19 4:23 PM, Yuval Shaia wrote: On Tue, Mar 12, 2019 at 02:23:22PM +0200, Kamal Heib wrote: On 3/11/19 12:29 PM, Yuval Shaia wrote: Utilize error_report for all pr_err calls and some pr_dbg that are considered as errors. For the remaining pr_dbg calls, the important ones were replace

Re: [Qemu-devel] [PATCH] qcow2: Fix data file error condition in qcow2_co_create()

2019-03-14 Thread Stefano Garzarella
On Wed, Mar 13, 2019 at 03:25:19PM +0100, Kevin Wolf wrote: > We were trying to check whether bdrv_open_blockdev_ref() returned > success, but accidentally checked the wrong variable. Spotted by > Coverity (CID 1399703). > > Signed-off-by: Kevin Wolf > --- > block/qcow2.c | 2 +- > 1 file change

Re: [Qemu-devel] [PATCH] xen-block: Replace qdict_put_obj() by qdict_put() where appropriate

2019-03-14 Thread Paul Durrant
> -Original Message- > From: Markus Armbruster [mailto:arm...@redhat.com] > Sent: 13 March 2019 17:45 > To: qemu-devel@nongnu.org > Cc: sstabell...@kernel.org; Anthony Perard ; Paul > Durrant > ; xen-de...@lists.xenproject.org; > qemu-bl...@nongnu.org > Subject: [PATCH] xen-block: Replace

Re: [Qemu-devel] [PATCH 3/4] hw/rdma: Use {} instead of {0}

2019-03-14 Thread Marcel Apfelbaum
On 3/13/19 10:46 AM, Kamal Heib wrote: Signed-off-by: Kamal Heib --- hw/rdma/rdma_backend.c | 18 +- hw/rdma/vmw/pvrdma_cmd.c| 2 +- hw/rdma/vmw/pvrdma_qp_ops.c | 2 +- 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/hw/rdma/rdma_backend.c b/hw

Re: [Qemu-devel] [PATCH] Re-evaluate SVE vector length everytime ADDVL is executed

2019-03-14 Thread Amir CHARIF
Hello, Thanks for your answer. The wrong size was definitely being stored in the TB, and, it only affected ADDVL/RDVL/ADDPL (i.e. not all instructions are wrong). Here is what I think was happening: - The kernel disables SVE in EL0 (ZEN= 01). - When the user space application is entered, the TB

Re: [Qemu-devel] [PULL 04/14] audio: -audiodev command line option basic implementation

2019-03-14 Thread Peter Maydell
On Tue, 12 Mar 2019 at 07:13, Gerd Hoffmann wrote: > > From: Kővágó, Zoltán > > Audio drivers now get an Audiodev * as config paramters, instead of the > global audio_option structs. There is some code in audio/audio_legacy.c > that converts the old environment variables to audiodev options (thi

Re: [Qemu-devel] [PATCH] ppc/xics/spapr: Fix H_IPOLL implementation

2019-03-14 Thread David Gibson
On Thu, Mar 14, 2019 at 07:53:15AM +0100, Greg Kurz wrote: > On Thu, 14 Mar 2019 07:38:55 +0100 > Cédric Le Goater wrote: > > > From: Benjamin Herrenschmidt > > > > H_IPOLL takes the CPU# of the processor to poll as an argument, > > it doesn't operate on self. > > > > True. Applied to ppc-fo

Re: [Qemu-devel] [PULL 0/2] Slirp updates

2019-03-14 Thread Peter Maydell
On Wed, 13 Mar 2019 at 21:18, Samuel Thibault wrote: > > The following changes since commit cd82b1e170019c4b722ed53116ee9346315d7791: > > slirp: remove empty state.h (2019-03-13 22:12:23 +0100) > > are available in the Git repository at: > > https://people.debian.org/~sthibault/qemu.git tags/s

Re: [Qemu-devel] [PATCH] configure: remove slirp submodule support that doesn't exist yet

2019-03-14 Thread Stefano Garzarella
On Wed, Mar 13, 2019 at 05:31:57PM +, Daniel P. Berrangé wrote: > The slirp code is not yet split off into a separate repository, so > configuring QEMU to use slirp as a submodule is premature. This > causes the non-existant "slirp" to be requested from git when syncing > submodules. This in tu

Re: [Qemu-devel] [PATCH for-4.1 0/7] Add qemu_getrandom and ARMv8.5-RNG

2019-03-14 Thread Daniel P . Berrangé
On Wed, Mar 13, 2019 at 11:35:33AM -0700, Richard Henderson wrote: > On 3/13/19 10:57 AM, Daniel P. Berrangé wrote: > > We already have an internal API for providing strong random bytes in > > QEMU qcrypto_random_bytes. It is preferentially backed by gnutls or > > gcrypt, but if those aren't built-

Re: [Qemu-devel] Seccomp profile for swtpm as default

2019-03-14 Thread Daniel P . Berrangé
On Wed, Mar 13, 2019 at 03:43:13PM -0400, Stefan Berger wrote: > Hello! > >  If you have some feedback regarding a seccomp profile extension for swtpm > for v0.2, please let me know. I created this github issue here: > > > https://github.com/stefanberger/swtpm/issues/115 > > > Basically the ch

Re: [Qemu-devel] [PULL 4/5] hw/display: Add basic ATI VGA emulation

2019-03-14 Thread Peter Maydell
On Mon, 11 Mar 2019 at 08:54, Gerd Hoffmann wrote: > > From: BALATON Zoltan > > At least two machines, the PPC mac99 and MIPS fulong2e, have an ATI > gfx chip by default (Rage 128 Pro and M6/RV100 respectively) and > guests running on these and the PMON2000 firmware of the fulong2e > expect this

[Qemu-devel] [PATCH] block/io: fix bdrv_co_do_copy_on_readv error handling

2019-03-14 Thread Vladimir Sementsov-Ogievskiy
It's not safe to treat bdrv_is_allocated error as unallocated: if we mistake we may rewrite guest data. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/io.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/block/io.c b/block/io.c index 2ba603c7bc..dccad64d46

Re: [Qemu-devel] [PATCH] intel-iommu: optimize nodmar memory regions

2019-03-14 Thread Sergio Lopez
Paolo Bonzini writes: > On 13/03/19 12:45, Sergio Lopez wrote: >> >> Peter Xu writes: >> >>> Previously we have per-device system memory aliases when DMAR is >>> disabled by the system. It will slow the system down if there are >>> lots of devices especially when DMAR is disabled, because eac

Re: [Qemu-devel] [PATCH 6/7] linux-user: add IBT support to x86 safe-syscall.S

2019-03-14 Thread Paolo Bonzini
On 14/03/19 00:52, Richard Henderson wrote: > On 3/13/19 5:40 AM, Paolo Bonzini wrote: >> Because safe-syscall.S does not go through the C compiler, the >> .note.gnu.property note has to be added manually. Safe syscalls do not >> involve any indirect branch or stack unwinding, so they are triviall

[Qemu-devel] [PATCH for-4.0 2/2] tests/.gitignore: ignore test-qapi-emit-events.[ch] for in-tree builds

2019-03-14 Thread Stefano Garzarella
Commit 5d75648b56e generates 'tests/test-qapi-emit-events.[ch]' but did not ignore them for in-tree builds. Signed-off-by: Stefano Garzarella --- tests/.gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/.gitignore b/tests/.gitignore index c88f8f2537..f9c0170881 100644 --- a/tes

Re: [Qemu-devel] [PULL for-4.0 0/1] Block patches

2019-03-14 Thread Peter Maydell
On Wed, 13 Mar 2019 at 11:08, Stefan Hajnoczi wrote: > > The following changes since commit 3f3bbfc7cef4490c5ed5550766a81e7d18f08db1: > > Merge remote-tracking branch > 'remotes/huth-gitlab/tags/pull-request-2019-03-12' into staging (2019-03-12 > 21:06:26 +) > > are available in the Git re

[Qemu-devel] [PATCH for-4.0 0/2] Update .gitignore and tests/.gitignore for in-tree builds

2019-03-14 Thread Stefano Garzarella
This series could be useless when we will no longer support in-tree builds, but for 4.0 I think it's useful to ignore these files. Stefano Garzarella (2): .gitignore: ignore docs/built created for in-tree builds tests/.gitignore: ignore test-qapi-emit-events.[ch] for in-tree builds .gitignor

[Qemu-devel] [PATCH for-4.0 1/2] .gitignore: ignore docs/built created for in-tree builds

2019-03-14 Thread Stefano Garzarella
Commit 1290e6711 creates 'docs/built' for in-tree builds of Sphinx manuals but did not ignore it. Signed-off-by: Stefano Garzarella --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 77522561b8..0adb17347f 100644 --- a/.gitignore +++ b/.gitignore @@

Re: [Qemu-devel] [PATCH 3/7] configure: add CET support

2019-03-14 Thread Paolo Bonzini
On 14/03/19 01:56, Richard Henderson wrote: > Hmm. The gcc for aarch64 names the similar feature -mbranch-protection. I'm > rather annoyed that the i386 gcc folk appropriated a generic -f name without > actually making the feature generic at the same time. Wouldn't -fcf-protection=branch also ap

Re: [Qemu-devel] [PATCH 5/7] tcg/i386: add support for IBT

2019-03-14 Thread Paolo Bonzini
On 14/03/19 02:05, Richard Henderson wrote: > On 3/13/19 5:40 AM, Paolo Bonzini wrote: >> +static void tcg_out_endbr(TCGContext *s) >> +{ >> +#if defined __CET__ && (__CET__ & 1) >> +#ifdef __x86_64__ >> +tcg_out32(s, 0xfa1e0ff3); >> +#else >> +tcg_out32(s, 0xfb1e0ff3); >> +#endif >> +#endi

Re: [Qemu-devel] [PATCH] Re-evaluate SVE vector length everytime ADDVL is executed

2019-03-14 Thread Alex Bennée
Amir CHARIF writes: > Hello, > Thanks for your answer. > > The wrong size was definitely being stored in the TB, and, it only affected > ADDVL/RDVL/ADDPL (i.e. not all instructions are wrong). Here is what I think > was happening: > > - The kernel disables SVE in EL0 (ZEN= 01). > - When the u

[Qemu-devel] why does our coverity-model.c g_strdup() say it is a size-sink?

2019-03-14 Thread Peter Maydell
Our coverity model of g_strdup() includes: __coverity_string_size_sink__(s); This seems to be causing Coverity to report false positives like CID1399705 and 1399699 where we take a string from getenv() and pass it to g_strdup() The getenv() string is untrusted data of unknown length, and g_strdu

Re: [Qemu-devel] [PATCH 7/7] coroutine-x86: add CET shadow stack support

2019-03-14 Thread Paolo Bonzini
On 14/03/19 01:04, Richard Henderson wrote: > On 3/13/19 5:40 AM, Paolo Bonzini wrote: >> +static bool have_cet(void) >> +{ >> +#if defined CONFIG_CET >> +uint64_t ssp; >> +asm ("xor %0, %0; rdsspq %0\n" : "=rm" (ssp)); > > The xor is incompatible with a memory output. > I don't think you

Re: [Qemu-devel] [PATCH 5/5] aspeed/timer: Use signed muldiv for timer resets

2019-03-14 Thread Cédric Le Goater
On 3/14/19 11:47 AM, Christian Svensson wrote: > Hi all, > > I have a new patch but I'm not sure how you want me to post it. > Should I do a "PATCH v2" with a single patch and this thread as the thread ID? I would wait for feedback from Peter first. Thanks, C. > Thanks, > - Chris > > > On

Re: [Qemu-devel] [PATCH 5/5] aspeed/timer: Use signed muldiv for timer resets

2019-03-14 Thread Peter Maydell
On Thu, 14 Mar 2019 at 08:43, Cédric Le Goater wrote: > > From: Christian Svensson > > If the host decrements the counter register that results in a negative > delta. This is then passed to muldiv64 which only handles unsigned > numbers resulting in bogus results. > > This fix ensures the data be

Re: [Qemu-devel] Seccomp profile for swtpm as default

2019-03-14 Thread Stefan Berger
On 3/14/19 5:59 AM, Daniel P. Berrangé wrote: On Wed, Mar 13, 2019 at 03:43:13PM -0400, Stefan Berger wrote: Hello!  If you have some feedback regarding a seccomp profile extension for swtpm for v0.2, please let me know. I created this github issue here: https://github.com/stefanberger/swtpm

Re: [Qemu-devel] [PATCH v7 6/7] vhost-user-blk: Add support to reconnect backend

2019-03-14 Thread Michael S. Tsirkin
On Wed, Mar 13, 2019 at 10:05:51AM +0800, Yongji Xie wrote: > On Wed, 13 Mar 2019 at 00:49, Michael S. Tsirkin wrote: > > > > On Thu, Feb 28, 2019 at 04:53:54PM +0800, elohi...@gmail.com wrote: > > > From: Xie Yongji > > > > > > Since we now support the message VHOST_USER_GET_INFLIGHT_FD > > > an

[Qemu-devel] [RFC PATCH] QEMU may write to system_memory before guest starts

2019-03-14 Thread Yury Kotov
This patch isn't intended to merge. Just to reproduce a problem. The test for x-ignore-shread capability fails on aarch64 + tcg: Memory content inconsistency at 44c0 first_byte = 2 last_byte = 1 current = d1 hit_edge = 1 Memory content inconsistency at 44c01000 first_byte = 2 last_byte = 1 cu

Re: [Qemu-devel] [PATCH 2/2] virtio-gpu: clear command queue on reset

2019-03-14 Thread Marc-André Lureau
Hi On Thu, Mar 14, 2019 at 7:17 AM Gerd Hoffmann wrote: > > It was never correct to not clear them. Due to commit "3912e66a3feb > virtio-vga: fix reset." this became more obvious though. The virtio > rings get properly reset now, and trying to process the stale commands > will trigger an assert

Re: [Qemu-devel] [PATCH v7 6/7] vhost-user-blk: Add support to reconnect backend

2019-03-14 Thread Michael S. Tsirkin
On Wed, Mar 13, 2019 at 10:47:08AM +0800, Yongji Xie wrote: > On Wed, 13 Mar 2019 at 09:16, Michael S. Tsirkin wrote: > > > > On Thu, Feb 28, 2019 at 04:53:54PM +0800, elohi...@gmail.com wrote: > > > From: Xie Yongji > > > > > > Since we now support the message VHOST_USER_GET_INFLIGHT_FD > > > an

Re: [Qemu-devel] [PATCH v3 0/5] Add ignore-external migration capability

2019-03-14 Thread Юрий Котов
Hi, I've sent a mail about this problem: [RFC PATCH] QEMU may write to system_memory before guest starts Regards, Yury 06.03.2019, 13:47, "Yury Kotov" : > 05.03.2019, 21:06, "Dr. David Alan Gilbert" : >>  * Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: >>>   * Yury Kotov (yury-ko...@yandex

Re: [Qemu-devel] why does our coverity-model.c g_strdup() say it is a size-sink?

2019-03-14 Thread Paolo Bonzini
On 14/03/19 11:51, Peter Maydell wrote: > Our coverity model of g_strdup() includes: > __coverity_string_size_sink__(s); > > This seems to be causing Coverity to report false positives like > CID1399705 and 1399699 where we take a string from getenv() and > pass it to g_strdup() The getenv() str

Re: [Qemu-devel] [PATCH v7 6/7] vhost-user-blk: Add support to reconnect backend

2019-03-14 Thread Daniel P . Berrangé
On Tue, Mar 12, 2019 at 12:49:35PM -0400, Michael S. Tsirkin wrote: > On Thu, Feb 28, 2019 at 04:53:54PM +0800, elohi...@gmail.com wrote: > > From: Xie Yongji > > > > Since we now support the message VHOST_USER_GET_INFLIGHT_FD > > and VHOST_USER_SET_INFLIGHT_FD. The backend is able to restart > >

Re: [Qemu-devel] [PATCH v6 08/12] vhost-user: add vhost_user_input_get_config()

2019-03-14 Thread Michael S. Tsirkin
On Wed, Mar 13, 2019 at 03:27:27PM +0100, Marc-André Lureau wrote: > Hi > > On Wed, Mar 13, 2019 at 3:16 PM Michael S. Tsirkin wrote: > > > > On Tue, Mar 12, 2019 at 09:19:01PM +0100, Marc-André Lureau wrote: > > > Hi > > > > > > On Tue, Mar 12, 2019 at 4:49 PM Michael S. Tsirkin > > > wrote: >

[Qemu-devel] About Revert this patch: arm: Allow system registers for KVM guests to be changed by QEMU code

2019-03-14 Thread gengdongjiu
Hi Peter/Eric, I think we should fix the regression issue instead of revert this patch, I think the reason of this issue is that QEMU modified some unexpected resisters, we should find out. Revert "arm: Allow system registers for KVM guests to be changed by QEMU code" This r

Re: [Qemu-devel] [PATCH v2 09/11] hw/acpi: Add ACPI Generic Event Device Support

2019-03-14 Thread Shameerali Kolothum Thodi
Hi Eric, > -Original Message- > From: Auger Eric [mailto:eric.au...@redhat.com] > Sent: 11 March 2019 20:24 > To: Shameerali Kolothum Thodi ; > qemu-devel@nongnu.org; qemu-...@nongnu.org; imamm...@redhat.com; > peter.mayd...@linaro.org; shannon.zha...@gmail.com; > sa...@linux.intel.com; se

Re: [Qemu-devel] [PATCH v7 6/7] vhost-user-blk: Add support to reconnect backend

2019-03-14 Thread Michael S. Tsirkin
On Thu, Mar 14, 2019 at 11:24:22AM +, Daniel P. Berrangé wrote: > On Tue, Mar 12, 2019 at 12:49:35PM -0400, Michael S. Tsirkin wrote: > > On Thu, Feb 28, 2019 at 04:53:54PM +0800, elohi...@gmail.com wrote: > > > From: Xie Yongji > > > > > > Since we now support the message VHOST_USER_GET_INFL

Re: [Qemu-devel] [PATCH v7 6/7] vhost-user-blk: Add support to reconnect backend

2019-03-14 Thread Daniel P . Berrangé
On Thu, Mar 14, 2019 at 07:34:03AM -0400, Michael S. Tsirkin wrote: > On Thu, Mar 14, 2019 at 11:24:22AM +, Daniel P. Berrangé wrote: > > On Tue, Mar 12, 2019 at 12:49:35PM -0400, Michael S. Tsirkin wrote: > > > On Thu, Feb 28, 2019 at 04:53:54PM +0800, elohi...@gmail.com wrote: > > > > From: X

Re: [Qemu-devel] [PULL 00/10] Migration patches

2019-03-14 Thread Peter Maydell
On Wed, 13 Mar 2019 at 12:14, Juan Quintela wrote: > > The following changes since commit 3f3bbfc7cef4490c5ed5550766a81e7d18f08db1: > > Merge remote-tracking branch > 'remotes/huth-gitlab/tags/pull-request-2019-03-12' into staging (2019-03-12 > 21:06:26 +) > > are available in the Git repo

Re: [Qemu-devel] About Revert this patch: arm: Allow system registers for KVM guests to be changed by QEMU code

2019-03-14 Thread Peter Maydell
On Thu, 14 Mar 2019 at 11:31, gengdongjiu wrote: > > Hi Peter/Eric, >I think we should fix the regression issue instead of revert this patch, > I think the reason of >this issue is that QEMU modified some unexpected resisters, we should find > out. Yes, I agree that we need to actua

[Qemu-devel] [PATCH v2 1/2] virtio-gpu: delay virglrenderer reset when blocked.

2019-03-14 Thread Gerd Hoffmann
If renderer_blocked is set do not call virtio_gpu_virgl_reset(). Instead set a flag indicating that virglrenderer needs a reset. When renderer_blocked gets cleared do the actual reset call. Without this we can trigger an assert in spice due to calling spice_qxl_gl_scanout() while another operation

[Qemu-devel] [PATCH v2 2/2] virtio-gpu: clear command and fence queues on reset

2019-03-14 Thread Gerd Hoffmann
It was never correct to not clear them. Due to commit "3912e66a3feb virtio-vga: fix reset." this became more obvious though. The virtio rings get properly reset now, and trying to process the stale commands will trigger an assert in the virtio core. Signed-off-by: Gerd Hoffmann --- hw/display/

[Qemu-devel] [PATCH v2 0/2] virtio-gpu: more reset fixes.

2019-03-14 Thread Gerd Hoffmann
Gerd Hoffmann (2): virtio-gpu: delay virglrenderer reset when blocked. virtio-gpu: clear command and fence queues on reset include/hw/virtio/virtio-gpu.h | 1 + hw/display/virtio-gpu.c| 26 +- 2 files changed, 26 insertions(+), 1 deletion(-) -- 2.18.1

Re: [Qemu-devel] [RFC PATCH 3/3] hw/acpi: Extract build_mcfg

2019-03-14 Thread Wei Yang
On Thu, Mar 14, 2019 at 10:18:30AM +0100, Igor Mammedov wrote: >On Wed, 13 Mar 2019 21:31:37 + >Wei Yang wrote: > >> On Wed, Mar 13, 2019 at 05:09:43PM +0100, Igor Mammedov wrote: >> >On Wed, 13 Mar 2019 13:33:59 + >> >Wei Yang wrote: >> > >> >> On Wed, Mar 13, 2019 at 01:23:00PM +0100,

Re: [Qemu-devel] [PATCH 2/2] virtio-gpu: clear command queue on reset

2019-03-14 Thread Gerd Hoffmann
On Thu, Mar 14, 2019 at 12:01:27PM +0100, Marc-André Lureau wrote: > Hi > > On Thu, Mar 14, 2019 at 7:17 AM Gerd Hoffmann wrote: > > > > It was never correct to not clear them. Due to commit "3912e66a3feb > > virtio-vga: fix reset." this became more obvious though. The virtio > > rings get prop

Re: [Qemu-devel] [PATCH v2] hw/acpi: extract acpi_add_rom_blob()

2019-03-14 Thread Wei Yang
On Thu, Mar 14, 2019 at 10:25:14AM +0100, Igor Mammedov wrote: >On Thu, 14 Mar 2019 15:38:36 +0800 >Wei Yang wrote: > >> arm and i386 has almost the same function acpi_add_rom_blob(), except >> giving different FWCfgCallback function. >> >> This patch extract acpi_add_rom_blob() to aml-build.c by

Re: [Qemu-devel] [PULL 00/10] Migration patches

2019-03-14 Thread Peter Maydell
On Thu, 14 Mar 2019 at 11:48, Peter Maydell wrote: > > On Wed, 13 Mar 2019 at 12:14, Juan Quintela wrote: > > > > The following changes since commit 3f3bbfc7cef4490c5ed5550766a81e7d18f08db1: > > > > Merge remote-tracking branch > > 'remotes/huth-gitlab/tags/pull-request-2019-03-12' into stagin

Re: [Qemu-devel] [build-error] possible build error at the tip of the trunk? (dtc-related?)

2019-03-14 Thread Peter Maydell
On Mon, 11 Mar 2019 at 16:59, Aleksandar Markovic wrote: > > Hello, all > > All of the sudden, the latest code doesn't build on my host: (the code from > several days ago builds fine) > > Do you know what would be the culprit? Is it my environment, or a genuine > build error? Hi -- we've now co

Re: [Qemu-devel] [PATCH v2 2/2] virtio-gpu: clear command and fence queues on reset

2019-03-14 Thread Marc-André Lureau
Hi On Thu, Mar 14, 2019 at 12:54 PM Gerd Hoffmann wrote: > > It was never correct to not clear them. Due to commit "3912e66a3feb > virtio-vga: fix reset." this became more obvious though. The virtio > rings get properly reset now, and trying to process the stale commands > will trigger an asser

Re: [Qemu-devel] [PATCH v7 6/7] vhost-user-blk: Add support to reconnect backend

2019-03-14 Thread Michael S. Tsirkin
On Thu, Mar 14, 2019 at 11:43:26AM +, Daniel P. Berrangé wrote: > On Thu, Mar 14, 2019 at 07:34:03AM -0400, Michael S. Tsirkin wrote: > > On Thu, Mar 14, 2019 at 11:24:22AM +, Daniel P. Berrangé wrote: > > > On Tue, Mar 12, 2019 at 12:49:35PM -0400, Michael S. Tsirkin wrote: > > > > On Thu,

Re: [Qemu-devel] why does our coverity-model.c g_strdup() say it is a size-sink?

2019-03-14 Thread Peter Maydell
On Thu, 14 Mar 2019 at 11:23, Paolo Bonzini wrote: > > On 14/03/19 11:51, Peter Maydell wrote: > > Our coverity model of g_strdup() includes: > > __coverity_string_size_sink__(s); > > > > This seems to be causing Coverity to report false positives like > > CID1399705 and 1399699 where we take a

Re: [Qemu-devel] [PATCH for-4.0] qapi: fix block-latency-histogram-set description and examples

2019-03-14 Thread Eric Blake
On 3/14/19 3:52 AM, Vladimir Sementsov-Ogievskiy wrote: > There no @device parameter, only the @id one. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > qapi/block-core.json | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) Documentation fixes are appropriate during free

Re: [Qemu-devel] [PATCH] qapi: fix block-latency-histogram-set description and examples

2019-03-14 Thread Kevin Wolf
Am 14.03.2019 um 09:52 hat Vladimir Sementsov-Ogievskiy geschrieben: > There no @device parameter, only the @id one. > > Signed-off-by: Vladimir Sementsov-Ogievskiy Thanks, applied to the block branch. Kevin

Re: [Qemu-devel] About Revert this patch: arm: Allow system registers for KVM guests to be changed by QEMU code

2019-03-14 Thread gengdongjiu
If you think this patch will introduce some issue, we can add one function write_part_cpustate_to_list()[2] to change the specified register instead of all the registers[1]. Below function that you added will modified all the register if new value is different with old value. [1]: bool write_cpu

Re: [Qemu-devel] [PULL 03/28] qapi: move to QOM path for x-block-latency-histogram-set

2019-03-14 Thread Kevin Wolf
Am 14.03.2019 um 09:47 hat Vladimir Sementsov-Ogievskiy geschrieben: > 12.03.2019 20:30, Kevin Wolf wrote: > > From: Vladimir Sementsov-Ogievskiy > > > > Signed-off-by: Vladimir Sementsov-Ogievskiy > > Signed-off-by: Kevin Wolf > > Not critical, but it is v4, when in v5 description and example

Re: [Qemu-devel] why does our coverity-model.c g_strdup() say it is a size-sink?

2019-03-14 Thread Paolo Bonzini
On 14/03/19 13:16, Peter Maydell wrote: > Mmm, that makes sense. So in this particular case, do we > want to try to avoid doing an unbounded allocation based > on whatever rubbish the user passed us in the environment, > or do we say "this particular case is OK" and mark it > as a false-positive ?

Re: [Qemu-devel] [PATCH for-4.0 0/2] Update .gitignore and tests/.gitignore for in-tree builds

2019-03-14 Thread Eric Blake
On 3/14/19 5:46 AM, Stefano Garzarella wrote: > This series could be useless when we will no longer support in-tree builds, > but for 4.0 I think it's useful to ignore these files. series: Reviewed-by: Eric Blake > > Stefano Garzarella (2): > .gitignore: ignore docs/built created for in-tree

Re: [Qemu-devel] [PATCH v7 6/7] vhost-user-blk: Add support to reconnect backend

2019-03-14 Thread Yury Kotov
Hi, 14.03.2019, 14:44, "Daniel P. Berrangé" : > On Thu, Mar 14, 2019 at 07:34:03AM -0400, Michael S. Tsirkin wrote: >>  On Thu, Mar 14, 2019 at 11:24:22AM +, Daniel P. Berrangé wrote: >>  > On Tue, Mar 12, 2019 at 12:49:35PM -0400, Michael S. Tsirkin wrote: >>  > > On Thu, Feb 28, 2019 at 04:5

Re: [Qemu-devel] [PATCH] block/io: fix bdrv_co_do_copy_on_readv error handling

2019-03-14 Thread Vladimir Sementsov-Ogievskiy
14.03.2019 13:14, Vladimir Sementsov-Ogievskiy wrote: > It's not safe to treat bdrv_is_allocated error as unallocated: if we > mistake we may rewrite guest data. ... with same data, which is not so bad. So, it's ok, I'm wrong, drop it. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- >

Re: [Qemu-devel] why does our coverity-model.c g_strdup() say it is a size-sink?

2019-03-14 Thread Daniel P . Berrangé
On Thu, Mar 14, 2019 at 12:16:06PM +, Peter Maydell wrote: > On Thu, 14 Mar 2019 at 11:23, Paolo Bonzini wrote: > > > > On 14/03/19 11:51, Peter Maydell wrote: > > > Our coverity model of g_strdup() includes: > > > __coverity_string_size_sink__(s); > > > > > > This seems to be causing Coveri

Re: [Qemu-devel] About Revert this patch: arm: Allow system registers for KVM guests to be changed by QEMU code

2019-03-14 Thread Peter Maydell
On Thu, 14 Mar 2019 at 12:24, gengdongjiu wrote: > > If you think this patch will introduce some issue, we can add one function > write_part_cpustate_to_list()[2] to change the specified > register instead of all the registers[1]. It definitely does introduce an issue, but we need to address it

Re: [Qemu-devel] About Revert this patch: arm: Allow system registers for KVM guests to be changed by QEMU code

2019-03-14 Thread gengdongjiu
On 2019/3/14 20:43, Peter Maydell wrote: >> If you think this patch will introduce some issue, we can add one function >> write_part_cpustate_to_list()[2] to change the specified >> register instead of all the registers[1]. > It definitely does introduce an issue, but we need to address > it by wo

Re: [Qemu-devel] [PATCH RFC] seccomp: don't kill process for resource control syscalls

2019-03-14 Thread Mathias Fröhlich
Hi, Thanks for not just killing processes anymore! See the mesa thread https://www.mail-archive.com/mesa-dev@lists.freedesktop.org/msg214474.html for some background. Thanks a lot and best Mathias On Wednesday, 13 March 2019 10:49:03 CET Daniel P. Berrangé wrote: > The Mesa library tries to set

Re: [Qemu-devel] [PATCH 5/5] aspeed/timer: Use signed muldiv for timer resets

2019-03-14 Thread Christian Svensson via Qemu-devel
Thanks for the feedback, On Thu, Mar 14, 2019, 11:57 Peter Maydell wrote: > But overall I'm a little sceptical that the aspeed timer is > really a special case that needs a signed version of this > when no other timer in the system does... I agree, and the v2 of the patch doesn't require it. H

Re: [Qemu-devel] [PATCH 0/5] aspeed/timer: Fix slowdowns in recent Linux

2019-03-14 Thread Christian Svensson via Qemu-devel
Hi, My apologies, I don't know how I missed those warnings. I'll create a new patch. - Chris On Thu, Mar 14, 2019 at 10:06 AM Cédric Le Goater wrote: > Hello, > > For the time being, we can drop patch 5 from this series. > > Thanks, > > C. > > On 3/14/19 9:59 AM, no-re...@patchew.org wrote: >

Re: [Qemu-devel] [PATCH 5/5] aspeed/timer: Use signed muldiv for timer resets

2019-03-14 Thread Christian Svensson via Qemu-devel
Hi all, I have a new patch but I'm not sure how you want me to post it. Should I do a "PATCH v2" with a single patch and this thread as the thread ID? Thanks, - Chris On Thu, Mar 14, 2019 at 10:05 AM Cédric Le Goater wrote: > Christian, > > Could you please provide a fix for this patch ? patc

Re: [Qemu-devel] Several questions about " [PATCH v3 0/5] virtio-9p: hotplug and migration support"

2019-03-14 Thread wangyan
On 2019/3/11 17:33, Greg Kurz wrote: > On Tue, 5 Mar 2019 19:28:37 +0800 > wangyan wrote: > >> I am very happy for your reply. >> >> I am very interested in your old WIP and want to take a look. >> >> Our project still use 9pfs, and it needs to live migrate the >> device while it is being used

Re: [Qemu-devel] [PULL 15/54] build: convert pci.mak to Kconfig

2019-03-14 Thread Andrea Bolognani
On Mon, 2019-03-04 at 19:19 +0100, Paolo Bonzini wrote: > Instead of including the same list of devices for each target, > set CONFIG_PCI to true, and make the devices default to present > whenever PCI is available. However, s390x does not want all the > PCI devices, so there is a separate symbol

Re: [Qemu-devel] [PULL 15/54] build: convert pci.mak to Kconfig

2019-03-14 Thread Paolo Bonzini
On 14/03/19 13:53, Andrea Bolognani wrote: > > $ ./riscv64-softmmu/qemu-system-riscv64 \ > -M virt \ > -device pcie-root-port > qemu-system-riscv64: -device pcie-root-port: MSI-X is not >supported by interrupt controller > > This is a limitation we have been aw

Re: [Qemu-devel] [PATCH v3 0/8] slirp: clarify license of slirp as BSD-3

2019-03-14 Thread Samuel Thibault
Hello, Should this go through my tree, or perhaps it can be directly pushed to master by Peter since it's no-code-only-copyright changes? Samuel Marc-André Lureau, le jeu. 14 mars 2019 14:10:41 +0100, a ecrit: > In order to make slirp a standalone project, the project must have a > clear license

Re: [Qemu-devel] [PATCH] hw/arm/virt-acpi-build: Fix SMMUv3 GSIV values

2019-03-14 Thread Peter Maydell
On Tue, 12 Mar 2019 at 09:10, Eric Auger wrote: > > The GSIV numbers of the SPI based interrupts is not correct as > ARM_SPI_BASE was not added to the irqmap[VIRT_SMMU] value. So > this may collide with VIRTIO_MMIO irq window. > > Signed-off-by: Eric Auger > --- > hw/arm/virt-acpi-build.c | 2 +-

[Qemu-devel] [PATCH v3 7/8] slirp: remove reference to COPYRIGHT file

2019-03-14 Thread Marc-André Lureau
The slirp COPYRIGHT file is a BSD-3 license. Instead of referring to another project file, the SPDX license notice present in all source files states that unequivocally. Signed-off-by: Marc-André Lureau --- slirp/src/debug.h | 3 --- slirp/src/if.h | 3 --- slirp/src/main.h |

[Qemu-devel] [PATCH v3 8/8] slirp: is not maintained by Kelly Price for a long time

2019-03-14 Thread Marc-André Lureau
slirp has been maintained by the QEMU maintainers and will be maintained under an independent project soon. Reviewed-by: Eric Blake Signed-off-by: Kelly Price Signed-off-by: Marc-André Lureau --- slirp/COPYRIGHT | 2 -- 1 file changed, 2 deletions(-) diff --git a/slirp/COPYRIGHT b/slirp/COPYR

[Qemu-devel] [PATCH v3 6/8] slirp: clarify license of slirp files using SPDX

2019-03-14 Thread Marc-André Lureau
Add SPDX license identifier to clarify the license of files without explicit license header. Signed-off-by: Marc-André Lureau --- slirp/src/bootp.h | 1 + slirp/src/ip6.h| 1 + slirp/src/ip6_icmp.h | 1 + slirp/src/libslirp.h | 1 + slirp/src/slirp.h | 1 + slirp/src/stream

  1   2   3   4   >