Re: [Qemu-devel] [PATCH 1/4] iothread: wait until the glib context is acquired

2019-02-21 Thread Peter Xu
On Wed, Feb 20, 2019 at 05:06:25PM +0100, Marc-André Lureau wrote: > Another thread may acquire the glib context (temporarily) before > g_main_context_push_thread_default(). > > This can happen with the following qemu_chr_fe_set_handlers() > modifications. > > Unfortunately, g_main_context_wait()

Re: [Qemu-devel] [PATCH v6 0/9] discard blockstats

2019-02-21 Thread Anton Nefedov
On 14/1/2019 4:16 PM, Anton Nefedov wrote: > On 30/11/2018 5:47 PM, Anton Nefedov wrote: >> qmp query-blockstats provides stats info for write/read/flush ops. >> >> Patches 1-7 implement the similar for discard (unmap) command for scsi >> and ide disks. >> Discard stat "unmap_ops / unmap_bytes" is

Re: [Qemu-devel] [PATCH 2/4] chardev: make qemu_chr_fe_set_handlers() context switching safer

2019-02-21 Thread Peter Xu
On Wed, Feb 20, 2019 at 05:06:26PM +0100, Marc-André Lureau wrote: > qemu_chr_fe_set_handlers() may switch the context of various > sources. In order to prevent dispatch races from different threads, > let's acquire or freeze the context, do all the source switches, and > then release/resume the co

Re: [Qemu-devel] [PATCH v12 00/10] qcow2: cluster space preallocation

2019-02-21 Thread Anton Nefedov
On 14/1/2019 2:18 PM, Anton Nefedov wrote: > This pull request is to start to improve a few performance points of > qcow2 format: > >1. non cluster-aligned write requests (to unallocated clusters) explicitly > pad data with zeroes if there is no backing data. > Resulting increase i

[Qemu-devel] [PATCH] display/virtio: add edid support.

2019-02-21 Thread Gerd Hoffmann
This patch adds EDID support to the family of virtio-gpu devices. It is turned off by default, use the new edid property to enable it. Signed-off-by: Gerd Hoffmann --- include/hw/virtio/virtio-gpu.h | 5 + hw/display/virtio-gpu-3d.c | 3 +++ hw/display/virtio-gpu.c| 43 +++

Re: [Qemu-devel] [PATCH] virtio-net: do not start queues that are not enabled by the guest

2019-02-21 Thread Yuri Benditovich
On Thu, Feb 21, 2019 at 8:49 AM Jason Wang wrote: > > > On 2019/2/21 下午2:00, Yuri Benditovich wrote: > > On Tue, Feb 19, 2019 at 8:27 AM Jason Wang wrote: > >> > >> On 2019/2/19 上午7:34, Michael S. Tsirkin wrote: > >>> On Mon, Feb 18, 2019 at 10:49:08PM +0200, Yuri Benditovich wrote: > On Mon

Re: [Qemu-devel] [PATCH 05/19] ppc/pnv: add XIVE support

2019-02-21 Thread Cédric Le Goater
On 2/21/19 4:13 AM, David Gibson wrote: > On Tue, Feb 19, 2019 at 08:31:25AM +0100, Cédric Le Goater wrote: >> On 2/12/19 6:40 AM, David Gibson wrote: >>> On Mon, Jan 28, 2019 at 10:46:11AM +0100, Cédric Le Goater wrote: > [snip] #endif /* _PPC_PNV_H */ diff --git a/include/hw/ppc/pnv_co

Re: [Qemu-devel] [PATCH v1 0/8] testing/next

2019-02-21 Thread Thomas Huth
On 20/02/2019 21.52, Alex Bennée wrote: > > Alex Bennée writes: > >> Hi, >> >> tests/boot-sector.c:161:boot_sector_test: >> assertion failed (signature == SIGNATURE): (0xface == 0xdead) >> >> I have seen this locally and got a core dump but it doesn't show much. >> I'm going to see

Re: [Qemu-devel] [PATCH v2 05/13] io: Remove redundant read/write_coroutine assignments

2019-02-21 Thread Kevin Wolf
Am 20.02.2019 um 19:22 hat Paolo Bonzini geschrieben: > On 20/02/19 19:07, Kevin Wolf wrote: > > Am 20.02.2019 um 19:01 hat Paolo Bonzini geschrieben: > >> aio_co_wake was also acquiring/releasing the AioContext, so > >> that needs to stay for now. > > > > True. Maybe I should leave the aio_co_wak

Re: [Qemu-devel] [PATCH] shippable: fix build

2019-02-21 Thread Stefano Garzarella
CCing Vincenzo, one of the maintainer of Netmap. On Wed, Feb 20, 2019 at 07:00:19PM +0100, Philippe Mathieu-Daudé wrote: > On 2/20/19 6:45 PM, Alex Bennée wrote: > > > > Philippe Mathieu-Daudé writes: > > > >> On 2/20/19 5:37 PM, Alex Bennée wrote: > >>> Paolo Bonzini writes: > >>> > It l

Re: [Qemu-devel] [PATCH 0/5] QEMU VFIO live migration

2019-02-21 Thread Dr. David Alan Gilbert
* Zhao Yan (yan.y.z...@intel.com) wrote: > On Wed, Feb 20, 2019 at 11:01:43AM +, Dr. David Alan Gilbert wrote: > > * Zhao Yan (yan.y.z...@intel.com) wrote: > > > On Tue, Feb 19, 2019 at 11:32:13AM +, Dr. David Alan Gilbert wrote: > > > > * Yan Zhao (yan.y.z...@intel.com) wrote: > > > > > Th

Re: [Qemu-devel] [PATCH] hw/display: Add basic ATI VGA emulation

2019-02-21 Thread Peter Maydell
On Thu, 21 Feb 2019 at 00:51, BALATON Zoltan wrote: > > On Thu, 21 Feb 2019, BALATON Zoltan wrote: > > On Tue, 19 Feb 2019, Peter Maydell wrote: > >> On Tue, 12 Feb 2019 at 23:59, BALATON Zoltan wrote: > >>> On Tue, 12 Feb 2019, Philippe Mathieu-Daudé wrote: > I'd have use a pair of extract3

Re: [Qemu-devel] [PATCH 01/10] pflash: Rename pflash_t to PFlashCFI01, PFlashCFI02

2019-02-21 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 2/19/19 2:41 PM, Markus Armbruster wrote: >> Philippe Mathieu-Daudé writes: >> >>> On 2/18/19 1:56 PM, Markus Armbruster wrote: flash.h's incomplete struct pflash_t is completed both in pflash_cfi01.c and in pflash_cfi02.c. The complete types are >

Re: [Qemu-devel] [PATCH v5] spice: set device address and device display ID in QXL interface

2019-02-21 Thread Gerd Hoffmann
On Fri, Feb 15, 2019 at 04:09:19PM +0100, Lukáš Hrázký wrote: > Calls the new SPICE QXL interface function spice_qxl_set_device_info to > set the hardware address of the graphics device represented by the QXL > interface (e.g. a PCI path) and the device display IDs (the IDs of the > device's monito

Re: [Qemu-devel] [PATCH 02/10] pflash: Macro PFLASH_BUG() is used just once, expand

2019-02-21 Thread Markus Armbruster
Markus Armbruster writes: > Peter Maydell writes: > >> On Tue, 19 Feb 2019 at 12:41, Philippe Mathieu-Daudé >> wrote: >>> >>> On 2/18/19 1:56 PM, Markus Armbruster wrote: >>> > PFLASH_BUG()'s lone use has a suspicious smell: it prints "Possible >>> > BUG", which sounds like a warning, then cal

Re: [Qemu-devel] [PATCH v3 11/13] Add vhost-user-input-pci

2019-02-21 Thread Gerd Hoffmann
On Fri, Feb 08, 2019 at 10:28:38AM -0500, Michael S. Tsirkin wrote: > On Fri, Feb 08, 2019 at 12:23:55PM +0100, Marc-André Lureau wrote: > > Add a new virtio-input device, which connects to a vhost-user > > backend. > > > > vhost-user-input is similar to virtio-input-host, it is wrapped by > > vho

Re: [Qemu-devel] [PATCH v4] ppc: add host-serial and host-model machine attributes

2019-02-21 Thread Daniel P . Berrangé
On Tue, Feb 19, 2019 at 01:55:01PM +1100, David Gibson wrote: > On Mon, Feb 18, 2019 at 11:43:49PM +0530, P J P wrote: > > From: Prasad J Pandit > > > > On ppc hosts, hypervisor shares following system attributes > > > > - /proc/device-tree/system-id > > - /proc/device-tree/model > > > > wi

Re: [Qemu-devel] [PATCH] shippable: fix build

2019-02-21 Thread Vincenzo Maffione
Hi, Yes, we added a static library that to ease application development (libnetmap.a). It looks like a configure/Makefile issue. Can you reproduce that? (I'm CC-ing Giuseppe, who actually added libnetmap). Cheers, Vincenzo Il giorno gio 21 feb 2019 alle ore 10:14 Stefano Garzarella < sgarz..

[Qemu-devel] [Bug 1685242] Re: ovmf hangs at efi with virtio-net memory hotplug

2019-02-21 Thread Laszlo Ersek (Red Hat)
Last night I remembered another tidbit: In OVMF, you can entirely disable the 64-bit MMIO aperture. -fw_cfg name=opt/ovmf/X-PciMmio64Mb,string=0 If you use the above switch, the firmware log should contain the following message: > GetFirstNonAddress: disabling 64-bit PCI host aperture This w

Re: [Qemu-devel] [PATCH v6 12/18] hw/arm/boot: Expose the PC-DIMM nodes in the DT

2019-02-21 Thread Igor Mammedov
On Wed, 20 Feb 2019 16:30:13 +0100 Auger Eric wrote: > Hi Igor, > > On 2/18/19 9:58 AM, Igor Mammedov wrote: > > On Tue, 5 Feb 2019 18:33:00 +0100 > > Eric Auger wrote: > > > >> From: Shameer Kolothum > >> > >> This patch add memory nodes corresponding to PC-DIMM regions. > > s/add/adds/

Re: [Qemu-devel] [PATCH] io: fix handling of EOF / error conditions in websock GSource

2019-02-21 Thread Daniel P . Berrangé
On Wed, Feb 20, 2019 at 08:52:34PM +0100, Philippe Mathieu-Daudé wrote: > Hi Daniel, > > On 2/20/19 7:25 PM, Daniel P. Berrangé wrote: > > We were never reporting the G_IO_HUP event when an end of file was hit > > on the websocket channel. > > > > We also ddn't report G_IO_ERR when we hit a fatal

Re: [Qemu-devel] [PATCH v3 11/25] xen: Let xencons_send() take a 'size' argument

2019-02-21 Thread Paul Durrant
> -Original Message- > From: Philippe Mathieu-Daudé [mailto:phi...@redhat.com] > Sent: 20 February 2019 01:02 > To: qemu-devel@nongnu.org; Prasad J Pandit ; Marc- > André Lureau ; Paolo Bonzini > > Cc: Jason Wang ; Anthony Perard > ; qemu-...@nongnu.org; Stefan Berger > ; David Gibson ; Ge

[Qemu-devel] [PATCH v1] include/exec/helper-head.h: support "const void *" in helper calls

2019-02-21 Thread David Hildenbrand
Especially when dealing with out-of-line gvec helpers, it is often helpful to specify some vector pointers as constant. E.g. when we have two inputs and one output, marking the two inputs as consts pointers helps to avoid bugs. Const pointers can be specified via "cptr", however behave in TCG just

Re: [Qemu-devel] [PATCH v2] ui/gtk: Fix the license information

2019-02-21 Thread Daniel P . Berrangé
On Thu, Feb 21, 2019 at 07:51:42AM +0100, Thomas Huth wrote: > The license information in this file is very messy. A short note at > the beginning says GPL first, but the long boilerplate code then > talks about "GNU Lesser General Public License version 2.0". First, > there is no such version of t

Re: [Qemu-devel] [PATCH v3 12/13] contrib: add vhost-user-input

2019-02-21 Thread Gerd Hoffmann
On Fri, Feb 08, 2019 at 12:23:56PM +0100, Marc-André Lureau wrote: > Add a vhost-user input backend example, based on virtio-input-host > device. It takes an evdev path as argument, and can be associated with > a vhost-user-input device via a UNIX socket: > > $ vhost-user-input -p /dev/input/event

Re: [Qemu-devel] [PATCH] virtio-net: do not start queues that are not enabled by the guest

2019-02-21 Thread Jason Wang
On 2019/2/21 下午4:18, Yuri Benditovich wrote: For 1.0 device, we can fix the queue_enable, but for 0.9x device how do you enable one specific queue in this case? (setting status?) Do I understand correctly that for 0.9 device in some cases the device will receive feature _MQ set, but will not

Re: [Qemu-devel] [PATCH v6 14/18] hw/arm/virt: Allocate device_memory

2019-02-21 Thread Igor Mammedov
On Tue, 19 Feb 2019 16:53:22 +0100 Auger Eric wrote: > Hi Igor, > > On 2/18/19 10:31 AM, Igor Mammedov wrote: > > On Tue, 5 Feb 2019 18:33:02 +0100 > > Eric Auger wrote: > > > >> The device memory region is located after the initial RAM. > >> its start/size are 1GB aligned. > >> > >> Signed

Re: [Qemu-devel] [PATCH v3 13/13] RFC: add explicit can_migrate to vhost_user_backend_dev_init()

2019-02-21 Thread Gerd Hoffmann
> Since this is not well specified, add a common blocker for the > VhostUserBackend users (vhost-user-input and upcoming gpu will use > it). > > RFC since I am not sure that's what Michael had in mind when > requesting such blocker. vmstate_vhost_input blocks migration too (via .unmigratable = 1)

Re: [Qemu-devel] [PATCH 02/10] pflash: Macro PFLASH_BUG() is used just once, expand

2019-02-21 Thread Peter Maydell
On Thu, 21 Feb 2019 at 09:22, Markus Armbruster wrote: > Double-checking... you want me to keep goto reset_flash, like this: > > @@ -623,8 +617,8 @@ static void pflash_write(PFlashCFI01 *pfl, hwaddr offset, > pfl->wcycle = 0; > pfl->status |= 0x80; >

Re: [Qemu-devel] [RFC PATCH v3 13/25] xen: Let buffer_append() return a size_t

2019-02-21 Thread Paul Durrant
> -Original Message- > From: Philippe Mathieu-Daudé [mailto:phi...@redhat.com] > Sent: 20 February 2019 01:02 > To: qemu-devel@nongnu.org; Prasad J Pandit ; Marc- > André Lureau ; Paolo Bonzini > > Cc: Jason Wang ; Anthony Perard > ; qemu-...@nongnu.org; Stefan Berger > ; David Gibson ;

Re: [Qemu-devel] [PATCH v4] ppc: add host-serial and host-model machine attributes

2019-02-21 Thread Greg Kurz
On Thu, 21 Feb 2019 09:25:46 + Daniel P. Berrangé wrote: > On Tue, Feb 19, 2019 at 01:55:01PM +1100, David Gibson wrote: > > On Mon, Feb 18, 2019 at 11:43:49PM +0530, P J P wrote: > > > From: Prasad J Pandit > > > > > > On ppc hosts, hypervisor shares following system attributes > > > >

[Qemu-devel] [PATCH v2] iotests: drop unnecessary accel=kvm in 238

2019-02-21 Thread Stefan Hajnoczi
Test 238 does not require the kvm accelerator. TCG works fine. Use the default accelerator instead of requiring kvm. Suggested-by: Thomas Huth Signed-off-by: Stefan Hajnoczi --- Vladimir, I have dropped the 235 change because I don't have time to figure out the kvm/tcg vs qtest differences or

Re: [Qemu-devel] [PATCH v11 7/7] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2019-02-21 Thread Dr. David Alan Gilbert
* Wei Wang (wei.w.w...@intel.com) wrote: > On 02/20/2019 09:12 PM, Dr. David Alan Gilbert wrote: > > * Wang, Wei W (wei.w.w...@intel.com) wrote: > > > On Friday, December 14, 2018 7:17 PM, Dr. David Alan Gilbert wrote: > > > > > On 12/14/2018 05:56 PM, Dr. David Alan Gilbert wrote: > > > > > > * We

Re: [Qemu-devel] [PATCH v2] iotests: drop unnecessary accel=kvm in 238

2019-02-21 Thread Thomas Huth
On 21/02/2019 11.11, Stefan Hajnoczi wrote: > Test 238 does not require the kvm accelerator. TCG works fine. > > Use the default accelerator instead of requiring kvm. > > Suggested-by: Thomas Huth > Signed-off-by: Stefan Hajnoczi > --- > Vladimir, I have dropped the 235 change because I don't

Re: [Qemu-devel] [PATCH v3 12/13] contrib: add vhost-user-input

2019-02-21 Thread Marc-André Lureau
Hi On Thu, Feb 21, 2019 at 10:53 AM Gerd Hoffmann wrote: > > On Fri, Feb 08, 2019 at 12:23:56PM +0100, Marc-André Lureau wrote: > > Add a vhost-user input backend example, based on virtio-input-host > > device. It takes an evdev path as argument, and can be associated with > > a vhost-user-input

[Qemu-devel] [PATCH v6 01/10] virtio-blk: add acct_failed param to virtio_blk_handle_rw_error()

2019-02-21 Thread Stefano Garzarella
We add acct_failed param in order to use virtio_blk_handle_rw_error() also when is not required to call block_acct_failed(). (eg. a discard operation is failed) Reviewed-by: Michael S. Tsirkin Reviewed-by: Stefan Hajnoczi Signed-off-by: Stefano Garzarella --- hw/block/virtio-blk.c | 10 ++-

[Qemu-devel] [PATCH v6 02/10] virtio-blk: add host_features field in VirtIOBlock

2019-02-21 Thread Stefano Garzarella
Since configurable features for virtio-blk are growing, this patch adds host_features field in the struct VirtIOBlock. (as in virtio-net) In this way, we can avoid to add new fields for new properties and we can directly set VIRTIO_BLK_F* flags in the host_features. We update "config-wce" and "scs

[Qemu-devel] [PATCH v6 05/10] virtio-blk: set config size depending on the features enabled

2019-02-21 Thread Stefano Garzarella
Starting from DISABLE and WRITE_ZEROES features, we use an array of VirtIOFeature (as virtio-net) to properly set the config size depending on the features enabled. Reviewed-by: Stefan Hajnoczi Signed-off-by: Stefano Garzarella --- hw/block/virtio-blk.c | 31 +--

[Qemu-devel] [PATCH v6 03/10] virtio-blk: add "discard" and "write-zeroes" properties

2019-02-21 Thread Stefano Garzarella
In order to avoid migration issues, we enable DISCARD and WRITE_ZEROES features only for machine type >= 4.0 As discussed with Michael S. Tsirkin and Stefan Hajnoczi on the list [1], DISCARD operation should not have security implications (eg. page cache attacks), so we can enable it by default.

[Qemu-devel] [PATCH v6 00/10] virtio-blk: add DISCARD and WRITE_ZEROES features

2019-02-21 Thread Stefano Garzarella
This series adds the support of DISCARD and WRITE_ZEROES commands and extends the virtio-blk-test to test these new commands. v6: - fixed patchew failure on patch 8 (do not initialise globals to 0 or NULL) - added R-b tags by Stefan v5: - rebased on master - handled the config size for DISCARD an

[Qemu-devel] [PATCH v6 10/10] tests/virtio-blk: add test for DISCARD command

2019-02-21 Thread Stefano Garzarella
If the DISCARD feature is enabled, we try this command in the test_basic(), checking only the status returned by the request. Reviewed-by: Stefan Hajnoczi Signed-off-by: Stefano Garzarella --- tests/virtio-blk-test.c | 27 +++ 1 file changed, 27 insertions(+) diff --git

[Qemu-devel] [PATCH v6 04/10] virtio-net: make VirtIOFeature usable for other virtio devices

2019-02-21 Thread Stefano Garzarella
In order to use VirtIOFeature also in other virtio devices, we move its declaration and the endof() macro (renamed in virtio_endof()) in virtio.h. We add virtio_feature_get_config_size() function to iterate the array of VirtIOFeature and to return the config size depending on the features enabled.

Re: [Qemu-devel] [PATCH 1/4] iothread: wait until the glib context is acquired

2019-02-21 Thread Marc-André Lureau
Hi On Thu, Feb 21, 2019 at 9:00 AM Peter Xu wrote: > > On Wed, Feb 20, 2019 at 05:06:25PM +0100, Marc-André Lureau wrote: > > Another thread may acquire the glib context (temporarily) before > > g_main_context_push_thread_default(). > > > > This can happen with the following qemu_chr_fe_set_handl

[Qemu-devel] [PATCH v6 07/10] tests/virtio-blk: change assert on data_size in virtio_blk_request()

2019-02-21 Thread Stefano Garzarella
The size of data in the virtio_blk_request must be a multiple of 512 bytes for IN and OUT requests, or a multiple of the size of struct virtio_blk_discard_write_zeroes for DISCARD and WRITE_ZEROES requests. Reviewed-by: Michael S. Tsirkin Reviewed-by: Stefan Hajnoczi Reviewed-by: Thomas Huth Si

[Qemu-devel] [PATCH v6 06/10] virtio-blk: add DISCARD and WRITE_ZEROES features

2019-02-21 Thread Stefano Garzarella
This patch adds the support of DISCARD and WRITE_ZEROES commands, that have been introduced in the virtio-blk protocol to have better performance when using SSD backend. We support only one segment per request since multiple segments are not widely used and there are no userspace APIs that allow a

[Qemu-devel] [PATCH v6 08/10] tests/virtio-blk: add virtio_blk_fix_dwz_hdr() function

2019-02-21 Thread Stefano Garzarella
This function is useful to fix the endianness of struct virtio_blk_discard_write_zeroes headers. Reviewed-by: Stefan Hajnoczi Signed-off-by: Stefano Garzarella --- tests/virtio-blk-test.c | 23 +-- 1 file changed, 17 insertions(+), 6 deletions(-) diff --git a/tests/virtio-b

[Qemu-devel] [PATCH v6 09/10] tests/virtio-blk: add test for WRITE_ZEROES command

2019-02-21 Thread Stefano Garzarella
If the WRITE_ZEROES feature is enabled, we check this command in the test_basic(). Reviewed-by: Michael S. Tsirkin Reviewed-by: Stefan Hajnoczi Acked-by: Thomas Huth Signed-off-by: Stefano Garzarella --- tests/virtio-blk-test.c | 62 + 1 file changed, 6

Re: [Qemu-devel] [PATCH v2] ui/gtk: Fix the license information

2019-02-21 Thread Gerd Hoffmann
> > + * Portions from gtk-vnc (originally licensed under the LGPL v2): > > s/v2/v2+/ > > With that fixed Fixed and queued up. thanks, Gerd

Re: [Qemu-devel] [PATCH 0/4] RFC: make chardev context switching safer

2019-02-21 Thread Marc-André Lureau
Hi On Thu, Feb 21, 2019 at 8:58 AM Peter Xu wrote: > > On Wed, Feb 20, 2019 at 05:06:24PM +0100, Marc-André Lureau wrote: > > Hi, > > Hi, > > > > > The chardev context switching code is a bit fragile, as it works as if > > the current context is properly synchronized with the new context. It > >

Re: [Qemu-devel] [PATCH v5 01/14] qapi: qapi for audio backends

2019-02-21 Thread Gerd Hoffmann
On Wed, Feb 20, 2019 at 10:37:30PM +0100, Kővágó, Zoltán wrote: > This patch adds structures into qapi to replace the existing > configuration structures used by audio backends currently. This qapi > will be the base of the -audiodev command line parameter (that replaces > the old environment varia

Re: [Qemu-devel] [Qemu-block] [RFC PATCH v2] coroutines: generate wrapper code

2019-02-21 Thread Stefan Hajnoczi
On Wed, Feb 20, 2019 at 01:03:58PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Hi all! > > We have a very frequent pattern of creating coroutine from function > with several arguments: > > - create structure to pack parameters > - create _entry function to call original function taking param

[Qemu-devel] [Bug 1816819] Re: Chardev websocket stops listening after first connection disconnects

2019-02-21 Thread Daniel Berrange
Patch proposed https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg05556.html -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1816819 Title: Chardev websocket stops listening after first connec

Re: [Qemu-devel] [PATCH 2/5] vfio/migration: support device of device config capability

2019-02-21 Thread Cornelia Huck
On Wed, 20 Feb 2019 17:54:00 -0500 Zhao Yan wrote: > On Tue, Feb 19, 2019 at 03:37:24PM +0100, Cornelia Huck wrote: > > On Tue, 19 Feb 2019 16:52:27 +0800 > > Yan Zhao wrote: > > > > > Device config is the default data that every device should have. so > > > device config capability is by def

[Qemu-devel] [PATCH v13 01/25] replay: add missing fix for internal function

2019-02-21 Thread Pavel Dovgalyuk
From: pbonz...@redhat.com This is a fix which was missed by patch 74c0b816adfc6aa1b01b4426fdf385e32e35cbac, which added current_step parameter to the replay_advance_current_step function. Signed-off-by: Pavel Dovgalyuk --- replay/replay-internal.c |2 +- 1 file changed, 1 insertion(+), 1 d

[Qemu-devel] [PATCH v13 00/25] Fixing record/replay and adding reverse debugging

2019-02-21 Thread Pavel Dovgalyuk
GDB remote protocol supports reverse debugging of the targets. It includes 'reverse step' and 'reverse continue' operations. The first one finds the previous step of the execution, and the second one is intended to stop at the last breakpoint that would happen when the program is executed normally.

[Qemu-devel] [PATCH v13 03/25] replay: disable default snapshot for record/replay

2019-02-21 Thread Pavel Dovgalyuk
From: Pavel Dovgalyuk This patch disables setting '-snapshot' option on by default in record/replay mode. This is needed for creating vmstates in record and replay modes. Signed-off-by: Pavel Dovgalyuk --- vl.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/vl

Re: [Qemu-devel] [PATCH v2 2/9] ccid-card-passthru: Replace never trigger if statement by an assertion

2019-02-21 Thread P J P
+-- On Mon, 18 Feb 2019, Philippe Mathieu-Daudé wrote --+ | On 2/15/19 11:59 AM, Marc-André Lureau wrote: | Arash or Prasad can you help us here? Do you have a reproducer? No, we don't have a reproducer handy I'm afraid. Thank you. -- Prasad J Pandit / Red Hat Product Security Team 47AF CE69 3A90

[Qemu-devel] [PATCH v13 05/25] replay: don't drain/flush bdrv queue while RR is working

2019-02-21 Thread Pavel Dovgalyuk
In record/replay mode bdrv queue is controlled by replay mechanism. It does not allow saving or loading the snapshots when bdrv queue is not empty. Stopping the VM is not blocked by nonempty queue, but flushing the queue is still impossible there, because it may cause deadlocks in replay mode. This

[Qemu-devel] [PATCH v13 13/25] replay: implement replay-seek command

2019-02-21 Thread Pavel Dovgalyuk
This patch adds hmp/qmp commands replay_seek/replay-seek that proceed the execution to the specified instruction count. The command automatically loads nearest snapshot and replays the execution to find the desired instruction count. Signed-off-by: Pavel Dovgalyuk Acked-by: Markus Armbruster --

[Qemu-devel] [PATCH v13 02/25] block: implement bdrv_snapshot_goto for blkreplay

2019-02-21 Thread Pavel Dovgalyuk
From: Pavel Dovgalyuk This patch enables making snapshots with blkreplay used in block devices. This function is required to make bdrv_snapshot_goto without calling .bdrv_open which is not implemented. Signed-off-by: Pavel Dovgalyuk --- block/blkreplay.c |8 1 file changed, 8 inse

[Qemu-devel] [PATCH v13 08/25] migration: introduce icount field for snapshots

2019-02-21 Thread Pavel Dovgalyuk
Saving icount as a parameters of the snapshot allows navigation between them in the execution replay scenario. This information can be used for finding a specific snapshot for proceeding the recorded execution to the specific moment of the time. E.g., 'reverse step' action (introduced in one of the

[Qemu-devel] [PATCH v13 14/25] replay: refine replay-time module

2019-02-21 Thread Pavel Dovgalyuk
This patch removes refactoring artifacts from the replay/replay-time.c Signed-off-by: Pavel Dovgalyuk --- replay/replay-time.c | 36 1 file changed, 16 insertions(+), 20 deletions(-) diff --git a/replay/replay-time.c b/replay/replay-time.c index 0df1693337

[Qemu-devel] [PATCH v13 10/25] qapi: introduce replay.json for record/replay-related stuff

2019-02-21 Thread Pavel Dovgalyuk
This patch adds replay.json file. It will be used for adding record/replay-related data structures and commands. Signed-off-by: Pavel Dovgalyuk Reviewed-by: Markus Armbruster -- v10: - minor changes v13: - rebased to the new QAPI files --- MAINTAINERS |1 + include/sysemu/re

[Qemu-devel] [PATCH v13 04/25] replay: update docs for record/replay with block devices

2019-02-21 Thread Pavel Dovgalyuk
This patch updates the description of the command lines for using record/replay with attached block devices. Signed-off-by: Pavel Dovgalyuk --- docs/replay.txt | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/docs/replay.txt b/docs/replay.txt index 3497585f5a..2

[Qemu-devel] [PATCH v13 16/25] gdbstub: add reverse step support in replay mode

2019-02-21 Thread Pavel Dovgalyuk
GDB remote protocol supports two reverse debugging commands: reverse step and reverse continue. This patch adds support of the first one to the gdbstub. Reverse step is intended to step one instruction in the backwards direction. This is not possible in regular execution. But replayed execution is

[Qemu-devel] [PATCH v13 12/25] replay: introduce breakpoint at the specified step

2019-02-21 Thread Pavel Dovgalyuk
This patch introduces replay_break, replay_delete_break qmp and hmp commands. These commands allow stopping at the specified instruction. It may be useful for debugging when there are some known events that should be investigated. replay_break command has one argument - number of instructions execu

[Qemu-devel] [PATCH v13 23/25] replay: fix replay shutdown

2019-02-21 Thread Pavel Dovgalyuk
This patch fixes shutdown of the replay process, which is terminated with the assert when shutdown event is read from the log. replay_finish_event reads new data_kind and therefore the value of data_kind should be preserved to be valid at qemu_system_shutdown_request call. Signed-off-by: Pavel Dov

[Qemu-devel] [PATCH v13 06/25] replay: finish record/replay before closing the disks

2019-02-21 Thread Pavel Dovgalyuk
After recent updates block devices cannot be closed on qemu exit. This happens due to the block request polling when replay is not finished. Therefore now we stop execution recording before closing the block devices. Signed-off-by: Pavel Dovgalyuk --- replay/replay.c |2 ++ vl.c|

[Qemu-devel] [PATCH v13 17/25] gdbstub: add reverse continue support in replay mode

2019-02-21 Thread Pavel Dovgalyuk
This patch adds support of the reverse continue operation for gdbstub. Reverse continue finds the last breakpoint that would happen in normal execution from the beginning to the current moment. Implementation of the reverse continue replays the execution twice: to find the breakpoints that were hit

[Qemu-devel] [PATCH v13 09/25] replay: provide an accessor for rr filename

2019-02-21 Thread Pavel Dovgalyuk
This patch adds an accessor function for the name of the record/replay log file. Adding an accessor instead of making variable global, prevents accidental modification of this variable by other modules. Signed-off-by: Pavel Dovgalyuk --- include/sysemu/replay.h |2 ++ replay/replay.c

[Qemu-devel] [PATCH v13 15/25] replay: flush rr queue before loading the vmstate

2019-02-21 Thread Pavel Dovgalyuk
Non-empty record/replay queue prevents saving and loading the VM state, because it includes pending bottom halves and block coroutines. But when the new VM state is loaded, we don't have to preserve the consistency of the current state anymore. Therefore this patch just flushes the queue allowing t

[Qemu-devel] [PATCH v13 24/25] replay: rename step-related variables and functions

2019-02-21 Thread Pavel Dovgalyuk
This patch renames replay_get_current_step() and related variables to make these names consistent with hmp/qmp commands. Signed-off-by: Pavel Dovgalyuk --- blockdev.c|2 +- include/sysemu/replay.h |2 +- migration/savevm.c|2 +- replay/replay-debugging.c |

[Qemu-devel] [PATCH v13 07/25] qcow2: introduce icount field for snapshots

2019-02-21 Thread Pavel Dovgalyuk
This patch introduces the icount field for saving within the snapshot. It is required for navigation between the snapshots in record/replay mode. Signed-off-by: Pavel Dovgalyuk Acked-by: Kevin Wolf -- v2: - documented format changes in docs/interop/qcow2.txt (suggested by Eric Blake) v10:

[Qemu-devel] [PATCH v13 19/25] replay: add BH oneshot event for block layer

2019-02-21 Thread Pavel Dovgalyuk
Replay is capable of recording normal BH events, but sometimes there are single use callbacks scheduled with aio_bh_schedule_oneshot function. This patch enables recording and replaying such callbacks. Block layer uses these events for calling the completion function. Replaying these calls makes th

[Qemu-devel] [PATCH v13 25/25] icount: clean up cpu_can_io before jumping to the next block

2019-02-21 Thread Pavel Dovgalyuk
Most of IO instructions can be executed only at the end of the block in icount mode. Therefore translator can set cpu_can_io flag when translating the last instruction. But when the blocks are chained, then this flag is not reset and may remain set at the beginning of the next block. This patch res

[Qemu-devel] [PATCH v13 20/25] replay: init rtc after enabling the replay

2019-02-21 Thread Pavel Dovgalyuk
This patch postpones the call of 'configure_rtc' function. This call uses host clock to configure the rtc, but host clock access should be recorded when using icount record/replay mode. Therefore now rtc is configured after switching record/replay mode on. Signed-off-by: Pavel Dovgalyuk --- vl.c

[Qemu-devel] [PATCH v3 02/11] char/spice: discard write() if backend is disconnected

2019-02-21 Thread Marc-André Lureau
Most chardev backend handle write() as discarded data if underlying system is disconnected. For unknown historical reasons, the Spice backend has "reliable" write: it will wait until the client end is reconnected to do further successful write(). To decide whether it make sense to wait until the c

[Qemu-devel] [PATCH v3 03/11] spice: avoid spice runtime assert

2019-02-21 Thread Marc-André Lureau
The Spice server doesn't like to be started or stopped twice . It aborts with: (process:6191): Spice-ERROR **: 19:29:35.912: red-worker.c:623:handle_dev_start: assertion `!worker->running' failed It's easy to avoid that situation since qemu spice_display_is_running tracks the server state. Afte

[Qemu-devel] [PATCH v13 11/25] replay: introduce info hmp/qmp command

2019-02-21 Thread Pavel Dovgalyuk
This patch introduces 'info replay' monitor command and corresponding qmp request. These commands request the current record/replay mode, replay log file name, and the instruction count (number of recorded/replayed instructions). The instruction count can be used with the replay_seek/replay_break

[Qemu-devel] [PATCH v13 22/25] util/qemu-timer: refactor deadline calculation for external timers

2019-02-21 Thread Pavel Dovgalyuk
icount-based record/replay uses qemu_clock_deadline_ns_all to measure the period until vCPU may be interrupted. This function takes in account the virtual timers, because they belong to the virtual devices that may generate interrupt request or affect the virtual machine state. However, there are a

[Qemu-devel] [PATCH v3 04/11] spice: merge options lists

2019-02-21 Thread Marc-André Lureau
Passing several -spice options to qemu command line, or calling several time qemu_opts_set() will ignore all but the first option list. Since the spice server is a singleton, it makes sense to merge all the options, the last value being the one taken into account. This changes the behaviour from,

[Qemu-devel] [PATCH v13 18/25] replay: describe reverse debugging in docs/replay.txt

2019-02-21 Thread Pavel Dovgalyuk
This patch updates the documentation and describes usage of the reverse debugging in QEMU+GDB. Signed-off-by: Pavel Dovgalyuk --- docs/replay.txt | 33 + 1 file changed, 33 insertions(+) diff --git a/docs/replay.txt b/docs/replay.txt index 2c2c5f6118..8447fdd35

[Qemu-devel] [PATCH v3 06/11] char: move SpiceChardev and open_spice_port() to spice.h header

2019-02-21 Thread Marc-André Lureau
This will allow easier subclassing of SpiceChardev, in upcoming "display: add -display spice-app launching external application" patch. Signed-off-by: Marc-André Lureau Tested-by: Victor Toso --- include/chardev/spice.h | 27 +++ chardev/spice.c | 28 +---

[Qemu-devel] [PATCH v3 05/11] spice: do not stop spice if VM is paused

2019-02-21 Thread Marc-André Lureau
spice_server_vm_start/stop() was added to help migration state (commit f5bb039c6d97ef3e664094eab3c9a4dc1824ed73). However, a paused VM could keep running the spice server. This will allow a Spice client to keep sending commands to a spice chardev. This allows to stop/cont a VM from a Spice monitor

[Qemu-devel] [PATCH v3 00/11] spice: add -display spice-app, setup and launch a Spice client

2019-02-21 Thread Marc-André Lureau
Hi, The QEMU GTK UI is quite featurful. Yet, it doesn't provide many of the functionalities one can expect from a VM desktop application (USB redirection, shared folders, drag and drop, better multimonitor support etc.). Spice is able to export many of the VM controls to a client, including QMP m

[Qemu-devel] [PATCH v13 21/25] replay: document development rules

2019-02-21 Thread Pavel Dovgalyuk
This patch introduces docs/devel/replay.txt which describes the rules that should be followed to make virtual devices usable in record/replay mode. Signed-off-by: Pavel Dovgalyuk -- v9: fixed external virtual clock description (reported by Artem Pisarenko) --- docs/devel/replay.txt | 46

[Qemu-devel] [PATCH v3 07/11] char: register spice ports after spice started

2019-02-21 Thread Marc-André Lureau
Spice port registration is delayed until the server is started. But ports created after are not being registered. If the server is already started, do vmc_register_interface() to register it from qemu_chr_open_spice_port(). Signed-off-by: Marc-André Lureau Tested-by: Victor Toso --- chardev/spi

[Qemu-devel] [PATCH] vmdk: false positive of compat6 with hwversion not set

2019-02-21 Thread yuchenlin--- via Qemu-devel
From: yuchenlin In vmdk_co_create_opts, when it finds hw_version is undefined, it will set it to 4, which misleading the compat6 and hwversion in vmdk_co_do_create. Simply set hw_version to NULL after free, let the logic in vmdk_co_do_create to decide the value of hw_version. This bug can be rep

[Qemu-devel] [PATCH v3 08/11] build-sys: add gio-2.0 check

2019-02-21 Thread Marc-André Lureau
GIO is required for the "-display spice-app" backend. Signed-off-by: Marc-André Lureau Tested-by: Victor Toso --- configure | 13 + 1 file changed, 13 insertions(+) diff --git a/configure b/configure index a61682c3c7..05d72f1c56 100755 --- a/configure +++ b/configure @@ -3503,6 +35

[Qemu-devel] [PATCH v3 01/11] char/spice: trigger HUP event

2019-02-21 Thread Marc-André Lureau
Inform the front-end of disconnected state (spice client disconnected). This will wakeup the source handler immediately, so it can detect the disconnection asap. Signed-off-by: Marc-André Lureau Tested-by: Victor Toso --- chardev/spice.c | 15 ++- 1 file changed, 14 insertions(+),

[Qemu-devel] [PATCH v3 11/11] display: add -display spice-app launching a Spice client

2019-02-21 Thread Marc-André Lureau
Add a new display backend that will configure Spice to allow a remote client to control QEMU in a similar fashion as other QEMU display backend/UI like GTK. For this to work, it will set up Spice server with a unix socket, and register a VC chardev that will be exposed as Spice ports. A QMP monito

Re: [Qemu-devel] [PATCH v2 2/9] ccid-card-passthru: Replace never trigger if statement by an assertion

2019-02-21 Thread Marc-André Lureau
Hi On Thu, Feb 21, 2019 at 12:06 PM P J P wrote: > > +-- On Mon, 18 Feb 2019, Philippe Mathieu-Daudé wrote --+ > | On 2/15/19 11:59 AM, Marc-André Lureau wrote: > | Arash or Prasad can you help us here? Do you have a reproducer? > > No, we don't have a reproducer handy I'm afraid. Without a repr

[Qemu-devel] [PATCH v3 09/11] qapi: document DisplayType enum

2019-02-21 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau Tested-by: Victor Toso --- qapi/ui.json | 25 + 1 file changed, 25 insertions(+) diff --git a/qapi/ui.json b/qapi/ui.json index 7d9c4bddaf..7702ddf583 100644 --- a/qapi/ui.json +++ b/qapi/ui.json @@ -1085,6 +1085,31 @@ # # Display (user

[Qemu-devel] [PATCH] hw/ppc: Use object_initialize_child for correct reference counting

2019-02-21 Thread Thomas Huth
Both functions, object_initialize() and object_property_add_child() increase the reference counter of the new object, so one of the references has to be dropped afterwards to get the reference counting right. Otherwise the child object will not be properly cleaned up when the parent gets destroyed.

[Qemu-devel] [PATCH v3 10/11] spice: use a default name for the server

2019-02-21 Thread Marc-André Lureau
If no -name is given, let's use a friendly "QEMU version" server name. This is sometime exposed on spice client side, for example on remote-viewer title. Signed-off-by: Marc-André Lureau Tested-by: Victor Toso --- ui/spice-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Qemu-devel] [Qemu-block] Guest unresponsive after Virtqueue size exceeded error

2019-02-21 Thread Stefan Hajnoczi
On Wed, Feb 20, 2019 at 06:56:04PM +, Fernando Casas Schössow wrote: > Regarding the dumps I have three of them including guest memory, 2 for > virtio-scsi, 1 for virtio-blk, in case a comparison may help to confirm which > is the proble.) I can upload them to a server you indicate me or I ca

Re: [Qemu-devel] [v4 PATCH] hw/arm/bcm2835_peripherals: add bcm283x arm timer

2019-02-21 Thread Peter Maydell
On Fri, 15 Feb 2019 at 15:59, Mark wrote: > > Signed-off-by: Mark > --- Hi Mark; thanks for this patch. > --- /dev/null > +++ b/hw/timer/bcm283x_timer.c > @@ -0,0 +1,271 @@ > +/* > + * Broadcom BCM283x ARM timer variant based on ARM SP804 > + * Copyright (c) 2019, Mark Could we have your ful

Re: [Qemu-devel] [Qemu-block] Guest unresponsive after Virtqueue size exceeded error

2019-02-21 Thread Fernando Casas Schössow
Hi Stefan, I can confirm that the symbols are included in the binary using gdb. I will send you and Paolo an email with the link and credentials (if needed) so you can download everything. Thanks! On jue, feb 21, 2019 at 12:11 PM, Stefan Hajnoczi wrote: On Wed, Feb 20, 2019 at 06:56:04PM +000

[Qemu-devel] [PATCH 1/4] virtio-gpu: remove unused qdev

2019-02-21 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau --- include/hw/virtio/virtio-gpu.h | 1 - hw/display/virtio-gpu.c| 1 - 2 files changed, 2 deletions(-) diff --git a/include/hw/virtio/virtio-gpu.h b/include/hw/virtio/virtio-gpu.h index c8c599f1b9..c7cb821ae3 100644 --- a/include/hw/virtio/virtio-gpu.h +

[Qemu-devel] [PATCH 0/4] virtio-gpu fixes (resend)

2019-02-21 Thread Marc-André Lureau
Hi, Here are a few patches that were in the vhost-user-gpu series, but are worth to consider separately. In particular, "virtio-gpu: block both 2d and 3d rendering" fixes a bug reported on RH bugzilla recently. Marc-André Lureau (4): virtio-gpu: remove unused qdev virtio-gpu: remove unused co

  1   2   3   4   >