CCing Vincenzo, one of the maintainer of Netmap. On Wed, Feb 20, 2019 at 07:00:19PM +0100, Philippe Mathieu-Daudé wrote: > On 2/20/19 6:45 PM, Alex Bennée wrote: > > > > Philippe Mathieu-Daudé <phi...@redhat.com> writes: > > > >> On 2/20/19 5:37 PM, Alex Bennée wrote: > >>> Paolo Bonzini <pbonz...@redhat.com> writes: > >>> > >>>> It looks like something in netmap has changed and compilation fails: > >>>> > >>>> install -D libnetmap.a //usr/local/lib/libnetmap.a > >>>> install: cannot stat libnetmap.a: No such file or directory > >>>> > >>>> Add an explicit "make" step to fix it. > >>> > >>> I took an alternate approach as tracking another projects master seems > >>> like a bad idea: > >>> > >>> tests/docker: peg netmap code to a specific version > >>> > >>> Tracking head is always going to be at the whims of the upstream. > >>> Let's use a defined release so things don't magically change under us. > >> > >> Oh now I see your reply... > >> > >>> Signed-off-by: Alex Bennée <alex.ben...@linaro.org> > >>> > >>> 1 file changed, 1 insertion(+) > >>> tests/docker/dockerfiles/debian-amd64.docker | 1 + > >>> > >>> modified tests/docker/dockerfiles/debian-amd64.docker > >>> @@ -33,6 +33,7 @@ RUN DEBIAN_FRONTEND=noninteractive eatmydata \ > >>> apt-get install -y --no-install-recommends \ > >>> linux-headers-amd64 > >>> RUN git clone https://github.com/luigirizzo/netmap.git /usr/src/netmap > >>> +RUN cd /usr/src/netmap && git checkout v11.3 > >> > >> ... and I notice I forgot to change directory in my previous suggestion. > >> > >> Why do you take v11.3 and not v11.4? > >> I agree v11.3 was closer to what I tested when I introduced this > >> dependency, but I'd rather use the latest release. > > > > Hmm github hid the newer releases by default and has a Latest Release > > button by v11.3. > > I don't understand (this GitHub feature)... > > I'm talking about this release: > https://github.com/luigirizzo/netmap/releases/tag/v11.4 > > The date is more recent that the v11.3. This looks like the latest > release to me. > > Anyway I'm fine if you prefer v11.3. > Please send a formal patch because I don't want to confuse scripts > adding my R-b in Paolo's patch. > > Regards, > > Phil. >
-- Stefano Garzarella Software Engineer @ Red Hat
