Re: [Qemu-devel] [qemu-s390x] [PATCH v2 1/2] target/s390x: Split out s390-tod.h

2019-02-10 Thread David Hildenbrand
On 09.02.19 07:31, Richard Henderson wrote: > We will need these from CONFIG_USER_ONLY as well, > which cannot access include/hw/. > > Signed-off-by: Richard Henderson > --- > include/hw/s390x/tod.h | 16 +--- > target/s390x/s390-tod.h | 29 + > 2 files c

[Qemu-devel] [PATCH v1 0/9] Misc fixes to pvrdma device

2019-02-10 Thread Yuval Shaia
Hi, Please review the following patch-set which consist of cosmetics fixes to device's user interface (traces, error_report and monitor) and some bug fixes. Thanks Markus, Eric, Marcel and David for reviewing v0. Appreciate your review to this v1. v0 -> v1: * Explain why device attributes are

[Qemu-devel] [PATCH v1 5/9] hw/rdma: Free all MAD receive buffers when device is closed

2019-02-10 Thread Yuval Shaia
When device is going down free all saved MAD buffers. Signed-off-by: Yuval Shaia Reviewed-by: Marcel Apfelbaum --- hw/rdma/rdma_backend.c| 33 - hw/rdma/vmw/pvrdma_main.c | 2 ++ 2 files changed, 34 insertions(+), 1 deletion(-) diff --git a/hw/rdma/rdma_back

[Qemu-devel] [PATCH v1 2/9] hw/rdma: Introduce locked qlist

2019-02-10 Thread Yuval Shaia
To make code more readable move handling of locked list to a generic functions. Signed-off-by: Yuval Shaia --- hw/rdma/rdma_backend.c | 20 +-- hw/rdma/rdma_backend_defs.h | 8 ++-- hw/rdma/rdma_utils.c| 39 + hw/rdma/rdma_uti

[Qemu-devel] [PATCH v1 6/9] hw/rdma: Free all receive buffers when QP is destroyed

2019-02-10 Thread Yuval Shaia
When QP is destroyed the backend QP is destroyed as well. This ensures we clean all received buffer we posted to it. However, a contexts of these buffers are still remain in the device. Fix it by maintaining a list of buffer's context and free them when QP is destroyed. Signed-off-by: Yuval Shaia

[Qemu-devel] [PATCH v1 4/9] {monitor, hw/pvrdma}: Expose device internals via monitor interface

2019-02-10 Thread Yuval Shaia
Allow interrogating device internals through HMP interface. The exposed indicators can be used for troubleshooting by developers or sysadmin. There is no need to expose these attributes to a management system (e.x. libvirt) because (1) most of them are not "device-management' related info and (2) t

[Qemu-devel] [PATCH v1 7/9] hw/pvrdma: Delete unneeded function argument

2019-02-10 Thread Yuval Shaia
The function argument rdma_dev_res is not needed as it is stored in the backend_dev object at init. Signed-off-by: Yuval Shaia Reviewed-by: Marcel Apfelbaum --- hw/rdma/rdma_backend.c | 13 ++--- hw/rdma/rdma_backend.h | 1 - hw/rdma/vmw/pvrdma_qp_ops.c | 3 +-- 3 files chang

[Qemu-devel] [PATCH v1 3/9] hw/rdma: Protect against concurrent execution of poll_cq

2019-02-10 Thread Yuval Shaia
The function rdma_poll_cq is called from two contexts - completion handler thread which sense new completion on backend channel and explicitly as result of guest issuing poll_cq command. Add lock to protect against concurrent executions. Signed-off-by: Yuval Shaia Reviewed-by: Marcel Apfelbaum -

[Qemu-devel] [PATCH v1 1/9] hw/rdma: Switch to generic error reporting way

2019-02-10 Thread Yuval Shaia
Utilize error_report for all pr_err calls and some pr_dbg that are considered as errors. For the remaining pr_dbg calls, the important ones were replaced by trace points while other deleted. Signed-off-by: Yuval Shaia --- hw/rdma/rdma_backend.c| 336 ++ hw

[Qemu-devel] [PATCH v1 9/9] hw/pvrdma: Unregister from shutdown notifier when device goes down

2019-02-10 Thread Yuval Shaia
This hook was installed to close the device when VM is going down. After the device is closed there is no need to be informed on VM shutdown. Signed-off-by: Yuval Shaia --- hw/rdma/vmw/pvrdma_main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/rdma/vmw/pvrdma_main.c b/hw/rdma/vmw/pvr

Re: [Qemu-devel] [qemu-s390x] [PATCH v2 2/2] This is a non-privileged instruction that was only implemented for system mode. However, the stck instruction is used by glibc, so this was causing SIGILL

2019-02-10 Thread David Hildenbrand
On 09.02.19 07:31, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/s390x/helper.h | 2 +- > target/s390x/misc_helper.c | 34 ++ > target/s390x/translate.c | 2 ++ > target/s390x/insn-data.def | 11 ++- > 4 files changed,

[Qemu-devel] [PATCH v1 8/9] hw/pvrdma: Delete pvrdma_exit function

2019-02-10 Thread Yuval Shaia
This hook is not called and was implemented by mistake. Signed-off-by: Yuval Shaia --- hw/rdma/vmw/pvrdma_main.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/hw/rdma/vmw/pvrdma_main.c b/hw/rdma/vmw/pvrdma_main.c index 90dc9b191b..8b379c6435 100644 --- a/hw/rdma/vmw/pvrdma_main.c +++

[Qemu-devel] [Bug 1813398] Re: qemu user calls malloc after fork in multi-threaded process

2019-02-10 Thread Szabolcs Nagy
note that the bug affects qemu-user on a glibc system too in case malloc is interposed: glibc can only take the internal locks of its own malloc implementation, any other malloc has the same issue as musl's after fork. -- You received this bug notification because you are a member of qemu- devel-

Re: [Qemu-devel] [PATCH v13 00/31] Fix some filename generation issues

2019-02-10 Thread Max Reitz
On 01.02.19 20:29, Max Reitz wrote: > Once more, I’ll spare both me and you another iteration of the cover > letter, so I direct you to the previous version’s cover letter (which > will direct you further): > > http://lists.nongnu.org/archive/html/qemu-block/2018-10/msg00229.html > > There are mo

[Qemu-devel] [PATCH v3 00/10] iotests: Fix some issues

2019-02-10 Thread Max Reitz
No fundamental changes from v2, so if you’re new to this series, the cover letter is here: http://lists.nongnu.org/archive/html/qemu-block/2019-01/msg01123.html Otherwise, these are the changes: v3: - Patch 10: Rebased onto 039be85c410bfb4b53cdee2083b4245e0d4e4181 git-backport-diff against v2

[Qemu-devel] [PATCH v3 05/10] iotests: Fix 207 to use QMP filters for qmp_log

2019-02-10 Thread Max Reitz
Fixes: 08fcd6111e1949f456e1b232ebeeb0cc17019a92 Signed-off-by: Max Reitz Reviewed-by: John Snow --- tests/qemu-iotests/207 | 10 +++--- tests/qemu-iotests/207.out | 4 ++-- 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/tests/qemu-iotests/207 b/tests/qemu-iotests/207 ind

[Qemu-devel] [PATCH v3 01/10] iotests: Re-add filename filters

2019-02-10 Thread Max Reitz
A previous commit removed the default filters for qmp_log with the intention to make them explicit; but this happened only for test 206. There are more tests (for more exotic image formats than qcow2) which require the filename filter, though. Note that 237 is still broken for Python 2.x, which is

[Qemu-devel] [PATCH v3 02/10] iotests: Fix 237 for Python 2.x

2019-02-10 Thread Max Reitz
math.ceil() returns an integer on Python 3.x, but a float on Python 2.x. range() always needs integers, so we need an explicit conversion on 2.x (which does not hurt on 3.x). It is not quite clear whether we want to support Python 2.x for any prolonged time, but this may as well be fixed along wit

[Qemu-devel] [PATCH v3 04/10] iotests: Fix 232 for LUKS

2019-02-10 Thread Max Reitz
With IMGOPTSSYNTAX, $TEST_IMG is useless for this test (it only tests the file-posix protocol driver). Therefore, if $TEST_IMG_FILE is set, use that instead. Because this test requires the file protocol, $TEST_IMG_FILE will always be set if $IMGOPTSSYNTAX is true. Signed-off-by: Max Reitz Revie

[Qemu-devel] [PATCH v3 03/10] iotests: Remove superfluous rm from 232

2019-02-10 Thread Max Reitz
This test creates no such file. Signed-off-by: Max Reitz Reviewed-by: Eric Blake Reviewed-by: John Snow --- tests/qemu-iotests/232 | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/qemu-iotests/232 b/tests/qemu-iotests/232 index 0708b8b155..93e5d641a3 100755 --- a/tests/qemu-iotests/232

[Qemu-devel] [PATCH v3 09/10] iotests: Let 045 be run concurrently

2019-02-10 Thread Max Reitz
Adding a telnet monitor for no real purpose on a fixed port is not so great. Just use a null monitor instead. Signed-off-by: Max Reitz Reviewed-by: John Snow --- scripts/qemu.py| 5 ++--- tests/qemu-iotests/045 | 2 +- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/scri

[Qemu-devel] [PATCH v3 06/10] iotests.py: Add is_str()

2019-02-10 Thread Max Reitz
On Python 2.x, strings are not always unicode strings. This function checks whether a given value is a plain string, or a unicode string (if there is a difference). Signed-off-by: Max Reitz Reviewed-by: John Snow --- tests/qemu-iotests/iotests.py | 6 ++ 1 file changed, 6 insertions(+) di

[Qemu-devel] [PATCH v3 10/10] iotests.py: s/_/-/g on keys in qmp_log()

2019-02-10 Thread Max Reitz
This follows what qmp() does, so the output will correspond to the actual QMP command. Signed-off-by: Max Reitz Reviewed-by: John Snow --- tests/qemu-iotests/206.out| 56 +-- tests/qemu-iotests/207.out| 18 +-- tests/qemu-iotests/210.out| 28 +

Re: [Qemu-devel] [PATCH v3 10/10] iotests.py: s/_/-/g on keys in qmp_log()

2019-02-10 Thread Max Reitz
On 10.02.19 15:57, Max Reitz wrote: > This follows what qmp() does, so the output will correspond to the > actual QMP command. > > Signed-off-by: Max Reitz > Reviewed-by: John Snow Dang it, sorry, I forgot to drop this R-b tag while rebasing. It shouldn't be here. :-/ Max > --- > tests/qemu

[Qemu-devel] [PATCH v3 07/10] iotests.py: Filter filename in any string value

2019-02-10 Thread Max Reitz
filter_qmp_testfiles() currently filters the filename only for specific keys. However, there are more keys that take filenames (such as block-commit's @top and @base, or ssh's @path), and it does not make sense to list them all here. "$TEST_DIR/$PID-" should have enough entropy not to appear anyw

[Qemu-devel] [PATCH v3 08/10] iotests: Filter SSH paths

2019-02-10 Thread Max Reitz
8908b253c4ad5f8874c8d13abec169c696a5cd32 has implemented filtering of remote paths for NFS, but forgot SSH. This patch takes care of that. Signed-off-by: Max Reitz Reviewed-by: John Snow --- tests/qemu-iotests/common.rc | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/qemu-iotests/com

Re: [Qemu-devel] [v2 PATCH] hw/arm/bcm2835_peripherals: add bcm283x sp804-alike timer

2019-02-10 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190209144918.GA14036@nyan/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash tim

[Qemu-devel] [v3 PATCH] hw/arm/bcm2835_peripherals: add bcm283x sp804-alike timer

2019-02-10 Thread Mark
Signed-off-by: Mark --- hw/arm/bcm2835_peripherals.c | 20 ++ hw/timer/Makefile.objs | 2 + hw/timer/bcm283x_timer.c | 299 +++ include/hw/arm/bcm2835_peripherals.h | 2 + include/hw/timer/bcm283x_timer.h | 38 5 files chang

[Qemu-devel] [PATCH] cuda: decrease time delay before raising VIA SR interrupt

2019-02-10 Thread Mark Cave-Ayland
In order to handle a race condition in MacOS 9, a delay was introduced when raising the VIA SR interrupt inspired by similar code in MacOnLinux. During original testing of the MacOS 9 patches it was found that the 30us delay used in MacOnLinux did not work reliably within QEMU, and a value of 300u

[Qemu-devel] [Bug 1815371] [NEW] SPICE session's connection_id's are not unique

2019-02-10 Thread Laurent Bigonville
Public bug reported: From: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=920897 = When creating a virtual machine with qemu (e.g. via libvirt) including a SPICE server, the client_id of the SPICE session is not unique. For example, starting multiple virtual machines on the same libvirtd,

Re: [Qemu-devel] [PATCH slirp 0/5] Make it a standalone project

2019-02-10 Thread Peter Maydell
On Fri, 8 Feb 2019 at 20:58, wrote: > As discussed earlier in "[PATCH for-3.2 00/41] RFC: slirp: make it > again a standalone project" and other threads, it would be useful to > make slirp a separate project (the submodule approach was discarded) > for various projects to share. > The following p

Re: [Qemu-devel] [PATCH 1/1] RFC: net/slirp: link with libslirp

2019-02-10 Thread Peter Maydell
On Fri, 8 Feb 2019 at 20:44, Marc-André Lureau wrote: > > Once libslirp has received its first release, we can link with the > external libslirp library. > > The migration data should be compatible with current and older qemu > versions (same compatibility as today). See "slirp: add state > saving

Re: [Qemu-devel] [PATCH slirp 0/5] Make it a standalone project

2019-02-10 Thread Samuel Thibault
Hello, Peter Maydell, le dim. 10 févr. 2019 21:35:37 +, a ecrit: > On Fri, 8 Feb 2019 at 20:58, wrote: > > As discussed earlier in "[PATCH for-3.2 00/41] RFC: slirp: make it > > again a standalone project" and other threads, it would be useful to > > make slirp a separate project (the submodu

Re: [Qemu-devel] [PATCH 03/17] target/arm: Add MTE system registers

2019-02-10 Thread Peter Maydell
On Sun, 10 Feb 2019 at 01:23, Richard Henderson wrote: > > On 2/5/19 11:27 AM, Peter Maydell wrote: > >> +++ b/target/arm/translate-a64.c > >> @@ -1668,6 +1668,17 @@ static void handle_msr_i(DisasContext *s, uint32_t > >> insn, > >> s->base.is_jmp = DISAS_UPDATE; > >> break; > >

Re: [Qemu-devel] [PATCH slirp 0/5] Make it a standalone project

2019-02-10 Thread Peter Maydell
On Sun, 10 Feb 2019 at 21:38, Samuel Thibault wrote: > > Hello, > > Peter Maydell, le dim. 10 févr. 2019 21:35:37 +, a ecrit: > > On Fri, 8 Feb 2019 at 20:58, wrote: > > > As discussed earlier in "[PATCH for-3.2 00/41] RFC: slirp: make it > > > again a standalone project" and other threads, i

Re: [Qemu-devel] [PATCH slirp 0/5] Make it a standalone project

2019-02-10 Thread Marc-André Lureau
Hi On Sun, Feb 10, 2019 at 10:42 PM Peter Maydell wrote: > > On Sun, 10 Feb 2019 at 21:38, Samuel Thibault wrote: > > > > Hello, > > > > Peter Maydell, le dim. 10 févr. 2019 21:35:37 +, a ecrit: > > > On Fri, 8 Feb 2019 at 20:58, wrote: > > > > As discussed earlier in "[PATCH for-3.2 00/41]

Re: [Qemu-devel] [PATCH slirp 0/5] Make it a standalone project

2019-02-10 Thread Peter Maydell
On Sun, 10 Feb 2019 at 22:03, Marc-André Lureau wrote: > Why do you think it should be a submodule? That's the approach I > proposed first, but Daniel suggested to make it immediately a shared > library if possible. It needs to be a submodule because you don't have a time machine to arrange for i

[Qemu-devel] [PATCH] hw/riscv/virt: re-add machine-specific compatible string to /soc/ node

2019-02-10 Thread Lukas Auer
Re-add the previous compatible string "riscv-virtio-soc" to the soc device tree node to allow U-Boot and Linux to bind machine-specific drivers to it. The current compatible string "simple-bus" is retained. This is required by U-Boot to bind devices early, as part of the pre-relocation driver mode

[Qemu-devel] Bug: Lost slirp functionality on qemu-system-ppc build for windows.

2019-02-10 Thread Howard Spoelstra
Hi, I just cross compiled Qemu-system-ppc for Windows on Fedora 29 and discovered slirp does not work anymore. Tap networking works fine. Bisecting got me here: a9d8b3ec4385793815d7121785730422fa3dfb68 is the first bad commit commit a9d8b3ec4385793815d7121785730422fa3dfb68 Author: Marc-André Lure

Re: [Qemu-devel] [PATCH 03/17] target/arm: Add MTE system registers

2019-02-10 Thread Richard Henderson
On 2/10/19 1:40 PM, Peter Maydell wrote: >> Actually, we already break the TB here by default. > > Do we? I didn't see any code (apart from the handling > in the DAIFSet/Clear codepaths, which aren't used for TCO). At the start of the function: /* End the TB by default, chaining is ok. */

[Qemu-devel] [Bug 1815371] Re: SPICE session's connection_id's are not unique

2019-02-10 Thread Bug Watch Updater
** Changed in: qemu (Debian) Status: Unknown => Confirmed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1815371 Title: SPICE session's connection_id's are not unique Status in QEMU: New

Re: [Qemu-devel] [PATCH] cuda: decrease time delay before raising VIA SR interrupt

2019-02-10 Thread David Gibson
On Sun, Feb 10, 2019 at 05:44:21PM +, Mark Cave-Ayland wrote: > In order to handle a race condition in MacOS 9, a delay was introduced when > raising the VIA SR interrupt inspired by similar code in MacOnLinux. > > During original testing of the MacOS 9 patches it was found that the 30us > del

Re: [Qemu-devel] [PATCH] mac_newworld: change default NIC to sungem for mac99 machine

2019-02-10 Thread David Gibson
On Fri, Feb 08, 2019 at 05:22:01PM +, Mark Cave-Ayland wrote: > This model brings out-of-the-box networking for all of Linux, MacOS 9 and OS X > without requiring the installation of additional drivers. > > Signed-off-by: Mark Cave-Ayland Applied, thanks. > --- > hw/ppc/mac_newworld.c | 2

Re: [Qemu-devel] [PATCH] spapr: Disallow unsupported kernel-irqchip settings

2019-02-10 Thread David Gibson
On Fri, Feb 08, 2019 at 07:17:47PM +0100, Greg Kurz wrote: > Split mode doesn't make sense on pseries, neither with XICS nor XIVE. But > passing kernel-irqchip=split silently behaves like kernel-irqchip=on. > Other architectures that support kernel-irqchip do terminate QEMU when > split mode is req

[Qemu-devel] [PATCH] target/xtensa: don't specify windowed registers manually

2019-02-10 Thread Max Filippov
Use libisa to extract whether opcode uses windowed registers and construct mask based on that. This only leaves special case for the 'entry' opcode, as it needs to probe a register dynamically. Signed-off-by: Max Filippov --- target/xtensa/cpu.h | 2 +- target/xtensa/helper.c| 1 +

[Qemu-devel] [PATCH v2 00/26] target/arm: Implement ARMv8.5-MemTag

2019-02-10 Thread Richard Henderson
Based-on: <20190204131228.25949-1-richard.hender...@linaro.org> aka "[PATCH v3 0/4] target/arm: Implement ARMv8.5-BTI". The full tree is available at https://github.org/rth7680/qemu.git tgt-arm-mte Changes since v1: * Updates to a newer revision of the spec. I know there is still work to d

[Qemu-devel] [PATCH v2 02/26] target/arm: Split helper_msr_i_pstate into 3

2019-02-10 Thread Richard Henderson
The EL0+UMA check is unique to DAIF. While SPSel had avoided the check by nature of already checking EL >= 1, the other post v8.0 extensions to MSR (imm) allow EL0 and do not require UMA. Avoid the unconditional write to pc and use raise_exception_ra to unwind. Signed-off-by: Richard Henderson

[Qemu-devel] [PATCH v2 07/26] target/arm: Assert no manual change to CACHED_PSTATE_BITS

2019-02-10 Thread Richard Henderson
These bits are stored elsewhere; changing env->pstate has no effect. Suggested-by: Peter Maydell Signed-off-by: Richard Henderson --- target/arm/translate.h | 4 1 file changed, 4 insertions(+) diff --git a/target/arm/translate.h b/target/arm/translate.h index a24757d3d7..296d1ac72c 10064

[Qemu-devel] [PATCH v2 06/26] target/arm: Add MTE system registers

2019-02-10 Thread Richard Henderson
This is TFSRE0_EL1, TFSR_EL1, TFSR_EL2, TFSR_EL3, RGSR_EL1, GCR_EL1, and PSTATE.TCO. Signed-off-by: Richard Henderson --- target/arm/cpu.h | 5 + target/arm/translate.h | 11 ++ target/arm/helper.c| 45 ++ target/arm/translat

[Qemu-devel] [PATCH v2 14/26] target/arm: Define arm_cpu_do_unaligned_access for CONFIG_USER_ONLY

2019-02-10 Thread Richard Henderson
We will need this to raise unaligned exceptions from user mode. Signed-off-by: Richard Henderson --- target/arm/op_helper.c | 33 - 1 file changed, 16 insertions(+), 17 deletions(-) diff --git a/target/arm/op_helper.c b/target/arm/op_helper.c index 8698b4dc83..d3

[Qemu-devel] [PATCH v2 01/26] target/arm: Split out arm_sctlr

2019-02-10 Thread Richard Henderson
Minimize the number of places that will need updating when the virtual host extensions are added. Signed-off-by: Richard Henderson --- target/arm/cpu.h| 26 -- target/arm/helper.c | 8 ++-- 2 files changed, 18 insertions(+), 16 deletions(-) diff --git a/target/a

[Qemu-devel] [PATCH v2 26/26] tests/tcg/aarch64: Add mte smoke tests

2019-02-10 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tests/tcg/aarch64/mte-1.c | 27 + tests/tcg/aarch64/mte-2.c | 39 +++ tests/tcg/aarch64/Makefile.target | 4 3 files changed, 70 insertions(+) create mode 100644 tests/tcg/aarch64/mte-1.c

[Qemu-devel] [PATCH v2 09/26] target/arm: Suppress tag check for sp+offset

2019-02-10 Thread Richard Henderson
R0078 specifies that base register, or base register plus immediate offset, is unchecked when the base register is SP. Signed-off-by: Richard Henderson --- v2: Include writeback addresses as checked. --- target/arm/translate-a64.c | 37 ++--- 1 file changed, 18 in

[Qemu-devel] [PATCH v2 03/26] target/arm: Add clear_pstate_bits, share gen_ss_advance

2019-02-10 Thread Richard Henderson
We do not need an out-of-line helper for clearing bits in pstate. While changing things, share the implementation of gen_ss_advance. Signed-off-by: Richard Henderson --- target/arm/helper.h| 2 -- target/arm/translate.h | 19 +++ target/arm/op_helper.c | 5 -

[Qemu-devel] [PATCH v2 04/26] target/arm: Add MTE_ACTIVE to tb_flags

2019-02-10 Thread Richard Henderson
When MTE is fully enabled, i.e. access to tags are enabled and tag checks affect the PE, then arrange to perform the check while stripping the TBI. The check is not yet implemented, just the plumbing to that point. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- v2: Clean TBI bi

[Qemu-devel] [PATCH v2 24/26] target/arm: Add allocation tag storage for system mode

2019-02-10 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/mte_helper.c | 96 + 1 file changed, 87 insertions(+), 9 deletions(-) diff --git a/target/arm/mte_helper.c b/target/arm/mte_helper.c index ad2902472d..3abed62018 100644 --- a/target/arm/mte_helper.c +++ b/tar

[Qemu-devel] [PATCH v2 05/26] target/arm: Extract TCMA with ARMVAParameters

2019-02-10 Thread Richard Henderson
Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target/arm/internals.h | 1 + target/arm/helper.c| 8 ++-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/target/arm/internals.h b/target/arm/internals.h index 6c018e773c..2922324f63 100644 --- a/target/arm/i

[Qemu-devel] [PATCH v2 13/26] target/arm: Implement the SUBP instruction

2019-02-10 Thread Richard Henderson
Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- v2: Fix extraction length. --- target/arm/translate-a64.c | 24 ++-- 1 file changed, 22 insertions(+), 2 deletions(-) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index 2e0d797294..3e46ee

[Qemu-devel] [PATCH v2 08/26] target/arm: Fill in helper_mte_check

2019-02-10 Thread Richard Henderson
Implements the rules of "PE generation of Checked and Unchecked accesses" which aren't already implied by TB_FLAGS_MTE_ACTIVE. Implements the rules of "PE handling of Tag Check Failure". Does not implement tag physical address space, so all operations reduce to unchecked so far. Signed-off-by: Ri

[Qemu-devel] [PATCH v2 21/26] target/arm: Cache the Tagged bit for a page in MemTxAttrs

2019-02-10 Thread Richard Henderson
This "bit" is a particular value of the page's MemAttr. Signed-off-by: Richard Henderson --- target/arm/helper.c | 25 +++-- 1 file changed, 15 insertions(+), 10 deletions(-) diff --git a/target/arm/helper.c b/target/arm/helper.c index a3ad5bc54e..3d7a51f8a2 100644 --- a/tar

[Qemu-devel] [PATCH v2 25/26] target/arm: Enable MTE

2019-02-10 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/cpu.c | 10 ++ target/arm/cpu64.c | 1 + 2 files changed, 11 insertions(+) diff --git a/target/arm/cpu.c b/target/arm/cpu.c index decf95de3e..a5599ae19f 100644 --- a/target/arm/cpu.c +++ b/target/arm/cpu.c @@ -206,6 +206,16 @@ static voi

[Qemu-devel] [PATCH v2 10/26] target/arm: Implement the IRG instruction

2019-02-10 Thread Richard Henderson
Signed-off-by: Richard Henderson --- v2: Update to 00eac5. Merge choose_random_nonexcluded_tag into helper_irg since that pseudo function no longer exists separately. --- target/arm/helper-a64.h| 1 + target/arm/mte_helper.c| 57 ++ target/arm/

[Qemu-devel] [PATCH v2 20/26] tcg: Introduce target-specific page data for user-only

2019-02-10 Thread Richard Henderson
At the same time, remember MAP_SHARED as PAGE_SHARED. When mapping new pages, make sure that old target-specific page data is removed. Signed-off-by: Richard Henderson --- include/exec/cpu-all.h| 10 -- accel/tcg/translate-all.c | 28 linux-user/mmap.c

[Qemu-devel] [PATCH v2 17/26] target/arm: Implement the access tag cache flushes

2019-02-10 Thread Richard Henderson
Like the regular data cache flushes, these are nops within qemu. Signed-off-by: Richard Henderson --- target/arm/helper.c | 48 + 1 file changed, 48 insertions(+) diff --git a/target/arm/helper.c b/target/arm/helper.c index 2d9c070bb3..74bace81e4 1006

[Qemu-devel] [PATCH v2 11/26] target/arm: Implement ADDG, SUBG instructions

2019-02-10 Thread Richard Henderson
Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- v2: Shift offset in translate; use extract32. --- target/arm/helper-a64.h| 2 ++ target/arm/internals.h | 3 ++ target/arm/mte_helper.c| 32 + target/arm/translate-a64.c | 71 ++-

[Qemu-devel] [PATCH v2 22/26] target/arm: Create tagged ram when MTE is enabled

2019-02-10 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/cpu.h | 4 hw/arm/virt.c| 33 + target/arm/cpu.c | 21 ++--- 3 files changed, 55 insertions(+), 3 deletions(-) diff --git a/target/arm/cpu.h b/target/arm/cpu.h index ca32939483..2626af4a9c 1

[Qemu-devel] [PATCH v2 12/26] target/arm: Implement the GMI instruction

2019-02-10 Thread Richard Henderson
Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target/arm/helper-a64.h| 1 + target/arm/mte_helper.c| 6 ++ target/arm/translate-a64.c | 6 ++ 3 files changed, 13 insertions(+) diff --git a/target/arm/helper-a64.h b/target/arm/helper-a64.h index 47577207b2..ef34

[Qemu-devel] [PATCH v2 19/26] target/arm: Set PSTATE.TCO on exception entry

2019-02-10 Thread Richard Henderson
R0085 specifies that exception handlers begin with tag checks overridden. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- v2: Only set if MTE feature present. --- target/arm/helper.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/target/arm/helper.c b/

[Qemu-devel] [PATCH v2 15/26] target/arm: Implement LDG, STG, ST2G instructions

2019-02-10 Thread Richard Henderson
Signed-off-by: Richard Henderson --- v2: Split out allocation_tag_mem. Handle atomicity of stores. --- target/arm/helper-a64.h| 5 ++ target/arm/mte_helper.c| 152 - target/arm/translate-a64.c | 114 3 files changed, 268

[Qemu-devel] [PATCH v2 16/26] target/arm: Implement the STGP instruction

2019-02-10 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate-a64.c | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index 539c25a80b..9bd68d522c 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/tra

[Qemu-devel] [PATCH v2 23/26] target/arm: Add allocation tag storage for user mode

2019-02-10 Thread Richard Henderson
Control this with x-tagged-pages, which is off by default. The limitation to non-shared pages is not part of a future kernel API, but a limitation of linux-user not being able to map virtual pages back to physical pages. Signed-off-by: Richard Henderson --- v2: Add the x-tagged-pages cpu propert

[Qemu-devel] [PATCH v2 18/26] target/arm: Implement data cache set allocation tags

2019-02-10 Thread Richard Henderson
This is DC GVA and DC GZVA. Signed-off-by: Richard Henderson --- v2: Use allocation_tag_mem + memset. --- target/arm/cpu.h | 4 +++- target/arm/helper-a64.h| 1 + target/arm/helper.c| 16 target/arm/mte_helper.c| 26 ++ target/

Re: [Qemu-devel] [Qemu-block] [PATCH 1/1] Introduce a Python module structure

2019-02-10 Thread Stefan Hajnoczi
On Wed, Feb 06, 2019 at 11:29:01AM -0500, Cleber Rosa wrote: > This is a simple move of Python code that wraps common QEMU > functionality, and are used by a number of different tests > and scripts. > > By treating that code as a real Python module, we can more easily: > * reuse code > * have a

Re: [Qemu-devel] [Qemu-block] Guest unresponsive after Virtqueue size exceeded error

2019-02-10 Thread Stefan Hajnoczi
On Wed, Feb 06, 2019 at 04:47:19PM +, Fernando Casas Schössow wrote: > I could also repro the same with virtio-scsi on the same guest a couple of > hours later: > > 2019-02-06 07:10:37.672+: starting up libvirt version: 4.10.0, qemu > version: 3.1.0, kernel: 4.19.18-0-vanilla, hostname:

Re: [Qemu-devel] should we try to stop using variable length arrays?

2019-02-10 Thread Stefan Hajnoczi
On Thu, Feb 07, 2019 at 07:30:59PM +, Peter Maydell wrote: > Should we be looking to get rid of these and turn on the -Wvla > warning? I know the Linux kernel has recently decided to do this > (some rationale at the start of https://lwn.net/Articles/749064/). I'm in favor of avoiding variable-

Re: [Qemu-devel] [Qemu-block] [RFC PATCH] coroutines: generate wrapper code

2019-02-10 Thread Stefan Hajnoczi
On Fri, Feb 08, 2019 at 05:11:22PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Hi all! > > We have a very frequent pattern of wrapping a coroutine_fn function > to be called from non-coroutine context: > > - create structure to pack parameters > - create function to call original function ta

Re: [Qemu-devel] [PATCH qemu 0/3] spapr_pci, vfio: NVIDIA V100 + P9 passthrough

2019-02-10 Thread Alexey Kardashevskiy
On 08/02/2019 16:28, David Gibson wrote: > On Thu, Feb 07, 2019 at 08:26:20PM -0700, Alex Williamson wrote: >> On Fri, 8 Feb 2019 13:29:37 +1100 >> Alexey Kardashevskiy wrote: >> >>> On 08/02/2019 02:18, Alex Williamson wrote: On Thu, 7 Feb 2019 15:43:18 +1100 Alexey Kardashevskiy wr

Re: [Qemu-devel] [Qemu-block] [PATCH] virtio-blk: cleanup using VirtIOBlock *s and VirtIODevice *vdev

2019-02-10 Thread Stefan Hajnoczi
On Fri, Feb 08, 2019 at 03:23:47PM +0100, Stefano Garzarella wrote: > In several part we still using req->dev or VIRTIO_DEVICE(req->dev) > when we have already defined s and vdev pointers: > VirtIOBlock *s = req->dev; > VirtIODevice *vdev = VIRTIO_DEVICE(s); > > Signed-off-by: Stefano Garz

Re: [Qemu-devel] [PATCH] memory: Do not update coalesced IO range in the case of NOP

2019-02-10 Thread Jag Raman
ping > On Feb 5, 2019, at 5:50 PM, Jagannathan Raman wrote: > > Do not add/del coalesced IO ranges in the case where the > same FlatRanges are present in both old and new FlatViews > > Fixes: 3ac7d43a6fbb ("memory: update coalesced_range on transaction_commit") > Signed-off-by: Jagannathan Rama

[Qemu-devel] [PATCH] hw/display: Add basic ATI VGA emulation

2019-02-10 Thread BALATON Zoltan
At least two machines, the PPC mac99 and MIPS fulong2e, have an ATI gfx chip by default (Rage 128 Pro and M6/RV100 respectively) and guests running on these and the PMON2000 firmware of the fulong2e expect this to be available. Fortunately these are very similar chips so they can be mostly emulated

Re: [Qemu-devel] [v3 PATCH] hw/arm/bcm2835_peripherals: add bcm283x sp804-alike timer

2019-02-10 Thread Andrew Baumann via Qemu-devel
Hi Mark, > From: Mark > Sent: Sunday, 10 February 2019 08:58 > Subject: [v3 PATCH] hw/arm/bcm2835_peripherals: add bcm283x sp804-alike > timer Thanks for the patch. The integration with bcm2835_peripherals looks good, but hopefully one of the QEMU maintainers can give you a review of the timer

Re: [Qemu-devel] [Qemu-block] [PATCH v4 0/6] virtio-blk: add DISCARD and WRITE_ZEROES features

2019-02-10 Thread Stefan Hajnoczi
On Fri, Feb 08, 2019 at 02:49:44PM +0100, Stefano Garzarella wrote: > This series adds the support of DISCARD and WRITE_ZEROES commands > and extends the virtio-blk-test to test WRITE_ZEROES command when > the feature is enabled. > > v4: > - fixed error with mingw compiler in patch 4 > gcc and c

[Qemu-devel] [Bug 1528214] Re: qemu 1.7.0 vhost_net crash

2019-02-10 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1528214 Title: qemu 1.7.0

[Qemu-devel] [PATCH 3/4] mips_fulong2e: Dynamically generate SPD EEPROM data

2019-02-10 Thread BALATON Zoltan
The machine comes with 256M memory module by default but it's upgradable so it could have different memory size. There was a TODO comment to replace static SPD EEPROM data with dynamically generated one to support this. Now that we have a function for that, it's easy to do. Although this would allo

[Qemu-devel] [PATCH 1/4] hw/pci-host/bonito.c: Add PCI mem region mapped at the correct address

2019-02-10 Thread BALATON Zoltan
Stop using system memory as PCI memory otherwise devices such as VGA that have regions mapped to PCI memory clash with RAM. Use a separate memory region for PCI memory and map it to the correct address in system memory which allows PCI mem regions to show at the correct address where clients expect

[Qemu-devel] [PATCH 4/4] mips_fulong2e: Add on-board graphics chip

2019-02-10 Thread BALATON Zoltan
Add (partial) emulation of the on-board GPU of the machine. This allows the PMON2000 firmware to run and should also work with Linux console but probably not with X yet. Signed-off-by: BALATON Zoltan --- Depends on hw/display: Add basic ATI VGA emulation hw/mips/mips_fulong2e.c | 6 ++ 1 fi

[Qemu-devel] [PATCH 0/4] Misc MIPS fulong2e improvements

2019-02-10 Thread BALATON Zoltan
Hello, These are some misc patches to get the fulong2e emulation in a better shape. With my recent via-ide changes and the separately submitted hw/display: Add basic ATI VGA emulation patch and after this series the pmon_2e.bin firmware from https://mirrors.cloud.tencent.com/loongson/pmon/ can act

[Qemu-devel] [PATCH 2/4] mips_fulong2e: Fix bios flash size

2019-02-10 Thread BALATON Zoltan
According to both the specifications on linux-mips.org referenced in a comment at the beginning of the file and the flash chip part number the bios size should be 512k not 1M. Signed-off-by: BALATON Zoltan --- hw/mips/mips_fulong2e.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-)

Re: [Qemu-devel] [PATCH qemu v2] hmp: Print if memory section is registered with an accelerator

2019-02-10 Thread Alexey Kardashevskiy
On 09/02/2019 04:26, Paolo Bonzini wrote: > On 07/02/19 12:49, Dr. David Alan Gilbert wrote: >> //#define DEBUG_UNASSIGNED >> @@ -2924,6 +2926,8 @@ struct FlatViewInfo { >> int counter; >> bool dispatch_tree; >> bool owner; >> +AccelClass *ac; >> +const char *ac_name; >>

Re: [Qemu-devel] [PATCH] mips: implement qmp query-cpu-definitions command

2019-02-10 Thread Pavel Dovgalyuk
Ping. Pavel Dovgalyuk > -Original Message- > From: Pavel Dovgalyuk [mailto:pavel.dovga...@ispras.ru] > Sent: Tuesday, February 05, 2019 4:08 PM > To: qemu-devel@nongnu.org > Cc: pavel.dovga...@ispras.ru; arik...@wavecomp.com; mdr...@linux.vnet.ibm.com; > arm...@redhat.com; dovga...@ispra

[Qemu-devel] [PULL 4/9] virtio-blk: add acct_failed param to virtio_blk_handle_rw_error()

2019-02-10 Thread Stefan Hajnoczi
From: Stefano Garzarella We add acct_failed param in order to use virtio_blk_handle_rw_error() also when is not required to call block_acct_failed(). (eg. a discard operation is failed) Reviewed-by: Michael S. Tsirkin Reviewed-by: Stefan Hajnoczi Signed-off-by: Stefano Garzarella Acked-by: Pa

[Qemu-devel] [PULL 3/9] virtio-blk: cleanup using VirtIOBlock *s and VirtIODevice *vdev

2019-02-10 Thread Stefan Hajnoczi
From: Stefano Garzarella In several part we still using req->dev or VIRTIO_DEVICE(req->dev) when we have already defined s and vdev pointers: VirtIOBlock *s = req->dev; VirtIODevice *vdev = VIRTIO_DEVICE(s); Signed-off-by: Stefano Garzarella Reviewed-by: Liam Merwick Message-id: 201902

[Qemu-devel] [PULL 2/9] qemugdb/coroutine: fix arch_prctl has unknown return type

2019-02-10 Thread Stefan Hajnoczi
From: Vladimir Sementsov-Ogievskiy qemu coroutine command results in following error output: Python Exception 'arch_prctl' has unknown return type; cast the call to its declared return type: Error occurred in Python command: 'arch_prctl' has unknown return type; cast the call to its declared re

[Qemu-devel] [PULL 7/9] virtio-blk: add DISCARD and WRITE_ZEROES features

2019-02-10 Thread Stefan Hajnoczi
From: Stefano Garzarella This patch adds the support of DISCARD and WRITE_ZEROES commands, that have been introduced in the virtio-blk protocol to have better performance when using SSD backend. We support only one segment per request since multiple segments are not widely used and there are no

[Qemu-devel] [PULL 8/9] tests/virtio-blk: change assert on data_size in virtio_blk_request()

2019-02-10 Thread Stefan Hajnoczi
From: Stefano Garzarella The size of data in the virtio_blk_request must be a multiple of 512 bytes for IN and OUT requests, or a multiple of the size of struct virtio_blk_discard_write_zeroes for DISCARD and WRITE_ZEROES requests. Reviewed-by: Michael S. Tsirkin Reviewed-by: Stefan Hajnoczi R

[Qemu-devel] [PULL 5/9] virtio-blk: add host_features field in VirtIOBlock

2019-02-10 Thread Stefan Hajnoczi
From: Stefano Garzarella Since configurable features for virtio-blk are growing, this patch adds host_features field in the struct VirtIOBlock. (as in virtio-net) In this way, we can avoid to add new fields for new properties and we can directly set VIRTIO_BLK_F* flags in the host_features. We u

[Qemu-devel] [PULL 6/9] virtio-blk: add "discard" and "write-zeroes" properties

2019-02-10 Thread Stefan Hajnoczi
From: Stefano Garzarella In order to avoid migration issues, we enable DISCARD and WRITE_ZEROES features only for machine type >= 4.0 As discussed with Michael S. Tsirkin and Stefan Hajnoczi on the list [1], DISCARD operation should not have security implications (eg. page cache attacks), so we

[Qemu-devel] [PULL 9/9] tests/virtio-blk: add test for WRITE_ZEROES command

2019-02-10 Thread Stefan Hajnoczi
From: Stefano Garzarella If the WRITE_ZEROES feature is enabled, we check this command in the test_basic(). Reviewed-by: Michael S. Tsirkin Reviewed-by: Stefan Hajnoczi Acked-by: Thomas Huth Signed-off-by: Stefano Garzarella Acked-by: Pankaj Gupta Message-id: 20190208134950.187665-7-sgarz..

[Qemu-devel] [PULL 0/9] Block patches

2019-02-10 Thread Stefan Hajnoczi
The following changes since commit e47f81b617684c4546af286d307b69014a83538a: Merge remote-tracking branch 'remotes/thibault/tags/samuel-thibault' into staging (2019-02-07 18:53:25 +) are available in the Git repository at: git://github.com/stefanha/qemu.git tags/block-pull-request for

[Qemu-devel] [PULL 1/9] iothread: fix iothread hang when stop too soon

2019-02-10 Thread Stefan Hajnoczi
From: Peter Xu Lukas reported an hard to reproduce QMP iothread hang on s390 that QEMU might hang at pthread_join() of the QMP monitor iothread before quitting: Thread 1 #0 0x03ffad10932c in pthread_join #1 0x000109e95750 in qemu_thread_join at /home/thuth/devel/qemu/util/q

  1   2   >