Re: [Qemu-devel] [PATCH v6 31/73] cpu: convert to cpu_halted

2019-02-07 Thread Alex Bennée
Emilio G. Cota writes: > This finishes the conversion to cpu_halted. > > Signed-off-by: Emilio G. Cota Reviewed-by: Alex Bennée > --- > cpus.c| 8 > qom/cpu.c | 2 +- > 2 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/cpus.c b/cpus.c > index c4fa3cc876..aee129

Re: [Qemu-devel] [PATCH v6 38/73] arm: convert to cpu_interrupt_request

2019-02-07 Thread Alex Bennée
Emilio G. Cota writes: > Cc: Peter Maydell > Cc: qemu-...@nongnu.org > Reviewed-by: Richard Henderson > Signed-off-by: Emilio G. Cota > > -/* Hooks may change global state so BQL should be held, also the > - * BQL needs to be held for any modification of > - * cs->interrupt_requ

Re: [Qemu-devel] [PATCH 1/4] configure: remove handling of "wav" audio driver

2019-02-07 Thread Philippe Mathieu-Daudé
On 2/7/19 8:36 PM, Cleber Rosa wrote: > This looks like a leftover that was never implemented. > > Signed-off-by: Cleber Rosa > --- > configure | 4 > 1 file changed, 4 deletions(-) > > diff --git a/configure b/configure > index fbd0825488..ff55e2273e 100755 > --- a/configure > +++ b/confi

Re: [Qemu-devel] [PATCH 2/4] configure: fix qemu-img name

2019-02-07 Thread Philippe Mathieu-Daudé
On 2/7/19 9:11 PM, Laurent Vivier wrote: > On 07/02/2019 20:36, Cleber Rosa wrote: >> Signed-off-by: Cleber Rosa >> --- >> configure | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/configure b/configure >> index ff55e2273e..c8fc1647fe 100755 >> --- a/configure >> +++ b

Re: [Qemu-devel] should we try to stop using variable length arrays?

2019-02-07 Thread Philippe Mathieu-Daudé
On 2/7/19 8:30 PM, Peter Maydell wrote: > Currently QEMU has 9 uses of variable length arrays > (found using -Wvla): > > hw/block/dataplane/virtio-blk.c:62:25: warning: variable length array > used [-Wvla] > unsigned long bitmap[BITS_TO_LONGS(nvqs)]; > ^ > hw/i386/multi

Re: [Qemu-devel] [PATCH v2 00/16] current testing/next queue (with build fixes)

2019-02-07 Thread Philippe Mathieu-Daudé
Cc'ing Michael. On 2/7/19 7:37 PM, Alex Bennée wrote: > > Hi, > > There are a few more additions from the last iteration including some > more fixes to try and get Travis green again. It's nice to see our ARM > features are now catching up we need a newer toolchain to build > things. I did try u

Re: [Qemu-devel] [PATCH] MAINTAINERS: Remove Peter Crosthwaite from various entries

2019-02-07 Thread Philippe Mathieu-Daudé
On 2/7/19 7:14 PM, Peter Maydell wrote: > Peter Crosthwaite hasn't had the bandwidth to do code review or > other QEMU work for some time now -- remove his email address > from MAINTAINERS file entries so we don't bombard him with > patch emails. > > Signed-off-by: Peter Maydell > --- > Peter C a

Re: [Qemu-devel] [PATCH v2 01/18] tests/vm: Be verbose while extracting compressed images

2019-02-07 Thread Philippe Mathieu-Daudé
Hi Alex, Can you queue this patch? On 1/29/19 6:53 PM, Philippe Mathieu-Daudé wrote: > Depending of the host hardware, copying and extracting VM images can > take up to few minutes. Add verbosity to avoid the user to worry about > VMs hanging. > > Signed-off-by: Philippe Mathieu-Daudé > --- >

[Qemu-devel] [Bug 1815143] [NEW] qemu-system-s390x fails when running without kvm: fatal: EXECUTE on instruction prefix 0x7f4 not implemented

2019-02-07 Thread liang yan
Public bug reported: just wondering if TCG implements instruction prefix 0x7f4 server3:~ # zcat /boot/vmlinux-4.4.162-94.72-default.gz > /tmp/kernel --> starting qemu with kvm enabled works fine server3:~ # qemu-system-s390x -nographic -kernel /tmp/kernel -initrd /boot/initrd -enable-kvm Initia

Re: [Qemu-devel] [PATCH v2 00/10] tcg vector improvements

2019-02-07 Thread Mark Cave-Ayland
On 05/02/2019 21:29, Mark Cave-Ayland wrote: > Now that this and the other pre-requisite patches have been merged into > master, I've > rebased the outstanding PPC parts of your "tcg, target/ppc vector > improvements" on > master including the above fix and pushed the result to > https://github.

[Qemu-devel] [PATCH] tcg/i386: fix unsigned vector saturating arithmetic

2019-02-07 Thread Mark Cave-Ayland
Due to a cut/paste error in the original implementation, the unsigned vector saturating arithmetic was erroneously being calculated as signed vector saturating arithmetic. Fixes: 8ffafbcec2 ("tcg/i386: Implement vector saturating arithmetic") Signed-off-by: Mark Cave-Ayland --- tcg/i386/tcg-tar

[Qemu-devel] [regression] Clock jump on VM migration

2019-02-07 Thread Neil Skrypuch
We (ab)use migration + block mirroring to perform transparent zero downtime VM backups. Basically: 1) do a block mirror of the source VM's disk 2) migrate the source VM to a destination VM using the disk copy 3) cancel the block mirroring 4) resume the source VM 5) shut down the destination VM gr

Re: [Qemu-devel] [PATCH] spapr_pci: Fix interrupt leak in rtas_ibm_change_msi() error path

2019-02-07 Thread David Gibson
On Thu, Feb 07, 2019 at 06:28:37PM +0100, Greg Kurz wrote: > Now that IRQ allocation has been split in two (first allocate IRQ numbers, > then claim them), if the claiming fails, we must release the IRQs. > > Fixes: 4fe75a8ccd80 "spapr: split the IRQ allocation sequence" > Signed-off-by: Greg Kurz

Re: [Qemu-devel] [PATCH 33/51] ppc: Express dependencies of the Sam460EX machines with kconfig

2019-02-07 Thread BALATON Zoltan
On Thu, 7 Feb 2019, Paolo Bonzini wrote: From: Thomas Huth Most of the dependencies are now directly selected by the SAM460EX switch. We can drop CONFIG_VGA_CIRRUS since this device is already selected automatically when CONFIG_PCI_DEVICES is set. Reviewed-by: BALATON Zoltan Reviewed-by: Paol

[Qemu-devel] [PATCH] configure: Add HAX support in NetBSD

2019-02-07 Thread Kamil Rytarowski
The NetBSD support in Intel HAXM has beem merged upstream and is functional. Signed-off-by: Kamil Rytarowski --- configure | 1 + 1 file changed, 1 insertion(+) diff --git a/configure b/configure index b18281c61f..89b889072d 100755 --- a/configure +++ b/configure @@ -819,6 +819,7 @@ DragonFly)

Re: [Qemu-devel] [PATCH v3 0/6] virtio-blk: add DISCARD and WRITE_ZEROES features

2019-02-07 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190206112729.37761-1-sgarz...@redhat.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

Re: [Qemu-devel] [PATCH v6 00/51] Support Kconfig in QEMU

2019-02-07 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1549562254-41157-1-git-send-email-pbonz...@redhat.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIP

Re: [Qemu-devel] [Bug 1815078] [NEW] Qemu 3.1.0 risc-v mie.MEIE

2019-02-07 Thread Alistair Francis
On Thu, Feb 7, 2019 at 8:19 AM RTOS Pharos <1815...@bugs.launchpad.net> wrote: > > Public bug reported: > > Hello all, > > There is a bug in qemu for Risc-v, related to the mie register: when we > try to set the MEIE bit (11) nothing is done, even when we are running > at machine mode. > > Li a0

Re: [Qemu-devel] [PATCH v3 0/6] virtio-blk: add DISCARD and WRITE_ZEROES features

2019-02-07 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190206112729.37761-1-sgarz...@redhat.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

Re: [Qemu-devel] [PATCH V12 5/5] docs: Added MAP_SYNC documentation

2019-02-07 Thread Yi Zhang
On 2019-02-07 at 09:30:12 -0500, Michael S. Tsirkin wrote: > On Thu, Feb 07, 2019 at 11:16:05PM +0800, Yi Zhang wrote: > > On 2019-02-06 at 13:29:37 -0500, Michael S. Tsirkin wrote: > > > On Thu, Feb 07, 2019 at 01:27:29AM +0800, Zhang, Yi wrote: > > > > From: Zhang Yi > > > > > > > > Signed-off-

[Qemu-devel] [PATCH V13 0/5] support MAP_SYNC for memory-backend-file

2019-02-07 Thread Zhang, Yi
Linux 4.15 introduces a new mmap flag MAP_SYNC, which can be used to guarantee the write persistence to mmap'ed files supporting DAX (e.g., files on ext4/xfs file system mounted with '-o dax'). A description of MAP_SYNC and MAP_SHARED_VALIDATE can be found at https://patchwork.kernel.org/patch

[Qemu-devel] [PATCH V13 1/5] util/mmap-alloc: Add a 'is_pmem' parameter to qemu_ram_mmap

2019-02-07 Thread Zhang, Yi
From: Zhang Yi besides the existing 'shared' flags, we are going to add 'is_pmem' to qemu_ram_mmap(), which indicated the memory backend file is a persist memory. Signed-off-by: Haozhong Zhang Signed-off-by: Zhang Yi Reviewed-by: Pankaj Gupta --- exec.c| 2 +- include/qe

[Qemu-devel] [PATCH V13 3/5] linux-headers: add linux/mman.h.

2019-02-07 Thread Zhang, Yi
From: Zhang Yi Update it to 4.20-rc1 Signed-off-by: Zhang Yi --- linux-headers/asm-arm/mman.h | 4 ++ linux-headers/asm-arm64/mman.h | 1 + linux-headers/asm-generic/hugetlb_encode.h | 36 ++ linux-headers/asm-generic/mman-common.h| 77 ++

[Qemu-devel] [PATCH V13 2/5] scripts/update-linux-headers: add linux/mman.h

2019-02-07 Thread Zhang, Yi
From: Zhang Yi Add linux/mman.h,asm/mman.h,asm/mman-common.h to linux-headers, So we can use more mmap2 flags. Signed-off-by: Zhang Yi --- scripts/update-linux-headers.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/scripts/update-linux-headers.sh b/scripts/update-

[Qemu-devel] [PATCH V13 4/5] util/mmap-alloc: support MAP_SYNC in qemu_ram_mmap()

2019-02-07 Thread Zhang, Yi
From: Zhang Yi When a file supporting DAX is used as vNVDIMM backend, mmap it with MAP_SYNC flag in addition which can ensure file system metadata synced in each guest writes to the backend file, without other QEMU actions (e.g., periodic fsync() by QEMU). Current, We have below different possib

[Qemu-devel] [PATCH V13 5/5] docs: Added MAP_SYNC documentation

2019-02-07 Thread Zhang, Yi
From: Zhang Yi Signed-off-by: Zhang Yi --- docs/nvdimm.txt | 25 ++--- qemu-options.hx | 5 + 2 files changed, 27 insertions(+), 3 deletions(-) diff --git a/docs/nvdimm.txt b/docs/nvdimm.txt index 5f158a6..a168429 100644 --- a/docs/nvdimm.txt +++ b/docs/nvdimm.txt @@ -

Re: [Qemu-devel] Querying the size of devdax devices from userspace

2019-02-07 Thread Stefan Hajnoczi
On Mon, Feb 04, 2019 at 12:06:32AM -0800, Dan Williams wrote: > On Sun, Feb 3, 2019 at 11:56 PM Stefan Hajnoczi wrote: > > > > How can userspace applications query the size of devdax character > > devices? > > > > stat(1) doesn't know how large the device is: > > > > # stat /dev/dax0.0 > > F

Re: [Qemu-devel] [PATCH v3 0/6] virtio-blk: add DISCARD and WRITE_ZEROES features

2019-02-07 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190206112729.37761-1-sgarz...@redhat.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

Re: [Qemu-devel] [PATCH qemu 0/3] spapr_pci, vfio: NVIDIA V100 + P9 passthrough

2019-02-07 Thread Alexey Kardashevskiy
On 08/02/2019 02:18, Alex Williamson wrote: > On Thu, 7 Feb 2019 15:43:18 +1100 > Alexey Kardashevskiy wrote: > >> On 07/02/2019 04:22, Daniel Henrique Barboza wrote: >>> Based on this series, I've sent a Libvirt patch to allow a QEMU process >>> to inherit IPC_LOCK when using VFIO passthrough

Re: [Qemu-devel] [PATCH V13 5/5] docs: Added MAP_SYNC documentation

2019-02-07 Thread Michael S. Tsirkin
On Fri, Feb 08, 2019 at 06:11:23PM +0800, Zhang, Yi wrote: > From: Zhang Yi > > Signed-off-by: Zhang Yi > --- > docs/nvdimm.txt | 25 ++--- > qemu-options.hx | 5 + > 2 files changed, 27 insertions(+), 3 deletions(-) > > diff --git a/docs/nvdimm.txt b/docs/nvdimm.txt >

Re: [Qemu-devel] [PATCH V13 0/5] support MAP_SYNC for memory-backend-file

2019-02-07 Thread Michael S. Tsirkin
On Fri, Feb 08, 2019 at 06:10:23PM +0800, Zhang, Yi wrote: > Linux 4.15 introduces a new mmap flag MAP_SYNC, which can be used to > guarantee the write persistence to mmap'ed files supporting DAX (e.g., > files on ext4/xfs file system mounted with '-o dax'). > > A description of MAP_SYNC and MAP_S

Re: [Qemu-devel] [PATCH qemu 0/3] spapr_pci, vfio: NVIDIA V100 + P9 passthrough

2019-02-07 Thread Alex Williamson
On Fri, 8 Feb 2019 13:29:37 +1100 Alexey Kardashevskiy wrote: > On 08/02/2019 02:18, Alex Williamson wrote: > > On Thu, 7 Feb 2019 15:43:18 +1100 > > Alexey Kardashevskiy wrote: > > > >> On 07/02/2019 04:22, Daniel Henrique Barboza wrote: > >>> Based on this series, I've sent a Libvirt patc

[Qemu-devel] [PATCH] tcg: Diagnose referenced labels that have not been emitted

2019-02-07 Thread Richard Henderson
Currently, a jump to a label that is not defined anywhere will be emitted not be relocated. This results in a jump to a random jump target. With tcg debugging, print a diagnostic to the -d op file and abort. This could help debug or detect errors like c2d9644e6d ("target/arm: Fix crash on condit

Re: [Qemu-devel] [PATCH] tcg: Diagnose referenced labels that have not been emitted

2019-02-07 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190208035551.3036-1-richard.hender...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH] tcg: Diagnose referenced labels that have not been emitted Type: series Mes

Re: [Qemu-devel] [PATCH] tcg: Diagnose referenced labels that have not been emitted

2019-02-07 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190208035551.3036-1-richard.hender...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH] tcg: Diagnose referenced labels that have not been emitted Mes

Re: [Qemu-devel] [PATCH] tcg: Diagnose referenced labels that have not been emitted

2019-02-07 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190208035551.3036-1-richard.hender...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH] tcg: Diagnose referenced labels that have not been emitted Message-id: 2019

Re: [Qemu-devel] [PATCH 33/51] ppc: Express dependencies of the Sam460EX machines with kconfig

2019-02-07 Thread Thomas Huth
On 2019-02-08 00:16, BALATON Zoltan wrote: > On Thu, 7 Feb 2019, Paolo Bonzini wrote: >> From: Thomas Huth >> >> Most of the dependencies are now directly selected by the SAM460EX >> switch. We can drop CONFIG_VGA_CIRRUS since this device is already >> selected automatically when CONFIG_PCI_DEVICE

Re: [Qemu-devel] [PATCH V13 5/5] docs: Added MAP_SYNC documentation

2019-02-07 Thread Yi Zhang
On 2019-02-07 at 22:00:46 -0500, Michael S. Tsirkin wrote: > On Fri, Feb 08, 2019 at 06:11:23PM +0800, Zhang, Yi wrote: > > From: Zhang Yi > > > > Signed-off-by: Zhang Yi > > --- > > docs/nvdimm.txt | 25 ++--- > > qemu-options.hx | 5 + > > 2 files changed, 27 insertio

[Qemu-devel] [PATCH V13 5/5] docs: Added MAP_SYNC documentation

2019-02-07 Thread Zhang, Yi
From: Zhang Yi Signed-off-by: Zhang Yi --- docs/nvdimm.txt | 22 +++--- qemu-options.hx | 5 + 2 files changed, 24 insertions(+), 3 deletions(-) diff --git a/docs/nvdimm.txt b/docs/nvdimm.txt index 5f158a6..e70f28b 100644 --- a/docs/nvdimm.txt +++ b/docs/nvdimm.txt @@ -143

[Qemu-devel] [Bug 1815143] Re: qemu-system-s390x fails when running without kvm: fatal: EXECUTE on instruction prefix 0x7f4 not implemented

2019-02-07 Thread Thomas Huth
Which version of QEMU are you using here? I think this should be working fine with the latest version of QEMU (>= v2.10). ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bu

Re: [Qemu-devel] [PATCH V13 0/5] support MAP_SYNC for memory-backend-file

2019-02-07 Thread Pankaj Gupta
> > Linux 4.15 introduces a new mmap flag MAP_SYNC, which can be used to > guarantee the write persistence to mmap'ed files supporting DAX (e.g., > files on ext4/xfs file system mounted with '-o dax'). > > A description of MAP_SYNC and MAP_SHARED_VALIDATE can be found at > https://patchwor

Re: [Qemu-devel] [PATCH v3 0/6] virtio-blk: add DISCARD and WRITE_ZEROES features

2019-02-07 Thread Stefan Hajnoczi
On Wed, Feb 06, 2019 at 12:27:23PM +0100, Stefano Garzarella wrote: > This series adds the support of DISCARD and WRITE_ZEROES commands > and extends the virtio-blk-test to test WRITE_ZEROES command when > the feature is enabled. > > v3: > - rebased on master (I removed Based-on tag since the new

Re: [Qemu-devel] [PATCH] target/ppc: Fix msync to do what hardware does

2019-02-07 Thread David Gibson
On Sat, Jan 26, 2019 at 03:50:28PM +0100, BALATON Zoltan wrote: > According to BookE docs, invalid bits (while undefined behaviour) should > not raise exception but be ignored. This seems to be implementation > dependent though and QEMU currently does what e500 CPUs do and raise > exception for inv

Re: [Qemu-devel] [PATCH 06/13] spapr/xive: fix migration of the XiveTCTX under TCG

2019-02-07 Thread David Gibson
On Mon, Jan 07, 2019 at 07:39:39PM +0100, Cédric Le Goater wrote: > When the thread interrupt management state is retrieved from the KVM > VCPU, word2 is saved under the QEMU XIVE thread context to print out > the OS CAM line under the QEMU monitor. > > This breaks the migration of a TCG guest (an

Re: [Qemu-devel] [PATCH 01/19] ppc/xive: hardwire the Physical CAM line of the thread context

2019-02-07 Thread David Gibson
On Mon, Jan 28, 2019 at 10:46:07AM +0100, Cédric Le Goater wrote: > By default on P9, the HW CAM line (23bits) is hardwired to : > > 0x000||0b1||4Bit chip number||7Bit Thread number. > > When the block group mode is enabled at the controller level (PowerNV), > the CAM line is changed for CA

Re: [Qemu-devel] [PATCH v5 1/1] target/ppc: Enable reporting of SPRs to GDB

2019-02-07 Thread David Gibson
On Wed, Feb 06, 2019 at 02:51:33PM -0200, Fabiano Rosas wrote: > This allows reading and writing of SPRs via GDB: > > (gdb) p/x $srr1 > $1 = 0x82803033 > > (gdb) p/x $pvr > $2 = 0x4b0201 > (gdb) set $pvr=0x4b > (gdb) p/x $pvr > $3 = 0x4b > > The `info` command can also be used: >

Re: [Qemu-devel] [PATCH qemu 0/3] spapr_pci, vfio: NVIDIA V100 + P9 passthrough

2019-02-07 Thread David Gibson
On Thu, Feb 07, 2019 at 08:26:20PM -0700, Alex Williamson wrote: > On Fri, 8 Feb 2019 13:29:37 +1100 > Alexey Kardashevskiy wrote: > > > On 08/02/2019 02:18, Alex Williamson wrote: > > > On Thu, 7 Feb 2019 15:43:18 +1100 > > > Alexey Kardashevskiy wrote: > > > > > >> On 07/02/2019 04:22, Dani

Re: [Qemu-devel] [regression] Clock jump on VM migration

2019-02-07 Thread Stefan Hajnoczi
On Thu, Feb 07, 2019 at 05:33:25PM -0500, Neil Skrypuch wrote: Thanks for your email! Please post your QEMU command-line. > The clock jump numbers above are from NTP, but you can see that they are > quite > close to the amount of time spent in raw_co_invalidate_cache. So, it looks > like flus

Re: [Qemu-devel] [PATCH 06/13] spapr/xive: fix migration of the XiveTCTX under TCG

2019-02-07 Thread Cédric Le Goater
On 2/8/19 6:36 AM, David Gibson wrote: > On Mon, Jan 07, 2019 at 07:39:39PM +0100, Cédric Le Goater wrote: >> When the thread interrupt management state is retrieved from the KVM >> VCPU, word2 is saved under the QEMU XIVE thread context to print out >> the OS CAM line under the QEMU monitor. >> >>

Re: [Qemu-devel] [PULL 15/25] contrib: compile vhost-user-blk tool by default

2019-02-07 Thread Stefan Hajnoczi
On Mon, Feb 04, 2019 at 08:48:14PM -0500, Michael S. Tsirkin wrote: > On Mon, Feb 04, 2019 at 03:29:21PM +, Daniel P. Berrangé wrote: > > On Mon, Feb 04, 2019 at 10:19:42AM -0500, Michael S. Tsirkin wrote: > > > Hmm I do think we want to build the contrib tools, > > > otherwise they bitrot too

[Qemu-devel] [PATCH] sdl2: drop qemu_input_event_send_key_qcode call

2019-02-07 Thread Gerd Hoffmann
qkbd_state_key_event() does that for us. Fixes: 07333e1ca3 kbd-state: use state tracker for sdl2 Reported-by: BALATON Zoltan Signed-off-by: Gerd Hoffmann --- ui/sdl2-input.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/ui/sdl2-input.c b/ui/sdl2-input.c index 664364a5e5..fb345f45fb 1006

Re: [Qemu-devel] [PATCH 01/19] ppc/xive: hardwire the Physical CAM line of the thread context

2019-02-07 Thread Cédric Le Goater
On 2/8/19 6:44 AM, David Gibson wrote: > On Mon, Jan 28, 2019 at 10:46:07AM +0100, Cédric Le Goater wrote: >> By default on P9, the HW CAM line (23bits) is hardwired to : >> >> 0x000||0b1||4Bit chip number||7Bit Thread number. >> >> When the block group mode is enabled at the controller level

[Qemu-devel] Maintainers, please git-am -m

2019-02-07 Thread Markus Armbruster
Short story: please add [am] messageid = true to your .gitconfig. Long story. git-am can add a Message-id: tag. Looks like this: commit 335dbb5de1e98c4dc73590349f17bb2a4d72596c Author: Thomas Huth Date: Mon Feb 4 09:25:43 2019 +0100 Commit: Peter Maydell

Re: [Qemu-devel] [PATCH] qemugdb/coroutine: fix arch_prctl has unknown return type

2019-02-07 Thread Stefan Hajnoczi
On Wed, Feb 06, 2019 at 06:14:25PM +0300, Vladimir Sementsov-Ogievskiy wrote: > qemu coroutine command results in following error output: > > Python Exception 'arch_prctl' has unknown return > type; cast the call to its declared return type: Error occurred in > Python command: 'arch_prctl' has un

Re: [Qemu-devel] Maintainers, please git-am -m

2019-02-07 Thread Thomas Huth
On 2019-02-08 08:30, Markus Armbruster wrote: > Short story: please add > > [am] > messageid = true > > to your .gitconfig. > > Long story. git-am can add a Message-id: tag. Looks like this: > > commit 335dbb5de1e98c4dc73590349f17bb2a4d72596c > Author: Thomas Huth >

Re: [Qemu-devel] [PATCH v2 09/18] tests/vm/openbsd: Install Bash from the ports

2019-02-07 Thread Alex Bennée
Brad Smith writes: > On 2/6/2019 3:25 PM, Alex Bennée wrote: > >> Brad Smith writes: >> >>> On 2/5/2019 8:57 AM, Brad Smith wrote: >>> If someone could point me in the right direction as to how the image is created I could look at coming up with something newer. I would prefer t

Re: [Qemu-devel] SeaBIOS regression

2019-02-07 Thread Thomas Huth
On 2019-02-06 18:29, John Snow wrote: > > > On 2/5/19 4:47 AM, Thomas Huth wrote: >> On 2019-02-05 10:42, Gerd Hoffmann wrote: >>> On Tue, Feb 05, 2019 at 10:31:24AM +0100, Thomas Huth wrote: On 2019-02-05 08:52, Gerd Hoffmann wrote: > On Mon, Feb 04, 2019 at 04:10:37PM +0100, Thomas Hut

Re: [Qemu-devel] [PATCH 02/10] hw/rdma: Introduce locked qlist

2019-02-07 Thread Marcel Apfelbaum
Hi Yuval, On 1/31/19 3:08 PM, Yuval Shaia wrote: To make code more readable move handling of locked list to a generic functions. Signed-off-by: Yuval Shaia --- hw/rdma/rdma_backend.c | 20 +-- hw/rdma/rdma_backend_defs.h | 8 ++-- hw/rdma/rdma_utils.c| 39

Re: [Qemu-devel] [PATCH v2] chardev: Avoid adding duplicate chardev

2019-02-07 Thread Marc-André Lureau
Hi On Thu, Feb 7, 2019 at 8:21 AM Pankaj Gupta wrote: > > > Hi Daniel, Marc-Andre, > > Thanks for your reply. Please find my reply inline. > > > > > Hotplugging existing char chardev with qmp, dereferences(removes) > > > > existing chardev. This patch avoids adding a chardev if a chardev > > > >

Re: [Qemu-devel] Configuring pflash devices for OVMF firmware

2019-02-07 Thread Markus Armbruster
The thread got long, let me try to summarize, and elaborate a few points. * The problem at hand is configuring firmware residing in flash memory (OVMF requires this) without legacy -drive. * The wider problem is configuring onboard devices. Our general device configuration interface doesn't

Re: [Qemu-devel] [PATCH v2] chardev: Avoid adding duplicate chardev

2019-02-07 Thread Daniel P . Berrangé
On Thu, Feb 07, 2019 at 10:11:29AM +0100, Marc-André Lureau wrote: > Hi > > On Thu, Feb 7, 2019 at 8:21 AM Pankaj Gupta wrote: > > > > > > Hi Daniel, Marc-Andre, > > > > Thanks for your reply. Please find my reply inline. > > > > > > > Hotplugging existing char chardev with qmp, dereferences(remo

[Qemu-devel] [Bug 1815024] Re: SIGILL on instruction "stck" under qemu-s390x in user mode

2019-02-07 Thread Giovanni Mascellani
I am also attaching the compiled program, in case it is helpful. ** Attachment added: "test" https://bugs.launchpad.net/qemu/+bug/1815024/+attachment/5236690/+files/test -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs

[Qemu-devel] [Bug 1815024] Re: SIGILL on instruction "stck" under qemu-s390x in user mode

2019-02-07 Thread Giovanni Mascellani
** Attachment added: "log.txt" https://bugs.launchpad.net/qemu/+bug/1815024/+attachment/5236689/+files/log.txt -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1815024 Title: SIGILL on instruction

[Qemu-devel] [Bug 1815024] Re: SIGILL on instruction "stck" under qemu-s390x in user mode

2019-02-07 Thread Giovanni Mascellani
** Attachment added: "rdtsc.S" https://bugs.launchpad.net/qemu/+bug/1815024/+attachment/5236688/+files/rdtsc.S -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1815024 Title: SIGILL on instruction

[Qemu-devel] [Bug 1815024] [NEW] SIGILL on instruction "stck" under qemu-s390x in user mode

2019-02-07 Thread Giovanni Mascellani
Public bug reported: qemu-s390x in user mode crashes with SIGILL (under host architecture x86_64, running Debian unstable) when executing target instruction "stck" ("STORE CLOCK", see https://www-01.ibm.com/support/docview.wss?uid=isg26480faec85f44e2385256d5200627dee&aid=1), which is basically a k

Re: [Qemu-devel] [PATCH] hw/riscv/sifive_clint.c: avoid integer overflow in timecmp write

2019-02-07 Thread Fabien Chouteau
Hello Alistair, On 07/02/2019 01:42, Alistair Francis wrote:> > Can you describe what this fixes? > I encountered this problem when I tried to write 0x in timecmp. With the integer overflow in QEMU, writing this value means that the QEMU timer will be set in the past. > Won't

Re: [Qemu-devel] [PATCH v2] chardev: Avoid adding duplicate chardev

2019-02-07 Thread Pankaj Gupta
> > > Thanks for your reply. Please find my reply inline. > > > > > > > > > Hotplugging existing char chardev with qmp, dereferences(removes) > > > > > > existing chardev. This patch avoids adding a chardev if a chardev > > > > > > with same id exists. > > > > > > > > > > As you pointed out, if y

Re: [Qemu-devel] [PATCH v2] chardev: Avoid adding duplicate chardev

2019-02-07 Thread Marc-André Lureau
Hi On Thu, Feb 7, 2019 at 11:13 AM Pankaj Gupta wrote: > > > > > > Thanks for your reply. Please find my reply inline. > > > > > > > > > > > Hotplugging existing char chardev with qmp, dereferences(removes) > > > > > > > existing chardev. This patch avoids adding a chardev if a chardev > > > > >

[Qemu-devel] [PATCH v3 06/17] block/stream: use QEMU_IOVEC_INIT_BUF

2019-02-07 Thread Vladimir Sementsov-Ogievskiy
Use new QEMU_IOVEC_INIT_BUF() instead of qemu_iovec_init_external( ... , 1), which simplifies the code. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/stream.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/block/stream.c b/block/stream.c index 7a49ac0992..e1457

[Qemu-devel] [PATCH v3 11/17] block/vmdk: use qemu_iovec_init_buf

2019-02-07 Thread Vladimir Sementsov-Ogievskiy
Use new qemu_iovec_init_buf() instead of qemu_iovec_init_external( ... , 1), which simplifies the code. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/vmdk.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index 682ad93aa1..4e331832df

[Qemu-devel] [PATCH v3 15/17] hw/ide: drop iov field from IDEState

2019-02-07 Thread Vladimir Sementsov-Ogievskiy
@iov is used only to initialize @qiov. Let's use new qemu_iovec_init_buf() instead, which simplifies the code. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/hw/ide/internal.h | 1 - hw/ide/atapi.c| 9 - hw/ide/core.c | 8 ++-- 3 files changed, 6 inse

[Qemu-devel] [PATCH v3 16/17] hw/ide: drop iov field from IDEBufferedRequest

2019-02-07 Thread Vladimir Sementsov-Ogievskiy
@iov is used only to initialize @qiov. Let's use new qemu_iovec_init_buf() instead, which simplifies the code. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/hw/ide/internal.h | 1 - hw/ide/core.c | 11 ++- 2 files changed, 6 insertions(+), 6 deletions(-) diff --gi

[Qemu-devel] [PATCH v3 17/17] hw/ide: drop iov field from IDEDMA

2019-02-07 Thread Vladimir Sementsov-Ogievskiy
@iov is used only to initialize @qiov. Let's use new qemu_iovec_init_buf() instead, which simplifies the code. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/hw/ide/internal.h | 1 - hw/ide/atapi.c| 5 ++--- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/incl

[Qemu-devel] [PATCH v3 00/17] block: local qiov helper

2019-02-07 Thread Vladimir Sementsov-Ogievskiy
Hi all! Here is a new simple helper for a very often patter around qemu_iovec_init_external, when we need simple qiov with only one iov, initialized from external buffer. v3: 01-02: tiny improvements, described in patch-emails 03-17: new patches Note: only hw/scsi/scsi-disk.c not updated,

Re: [Qemu-devel] [PATCH v2] chardev: Avoid adding duplicate chardev

2019-02-07 Thread Pankaj Gupta
> > Hi > > On Thu, Feb 7, 2019 at 11:13 AM Pankaj Gupta wrote: > > > > > > > > > Thanks for your reply. Please find my reply inline. > > > > > > > > > > > > > Hotplugging existing char chardev with qmp, > > > > > > > > dereferences(removes) > > > > > > > > existing chardev. This patch avoids a

[Qemu-devel] [PATCH v3 05/17] block/commit: use QEMU_IOVEC_INIT_BUF

2019-02-07 Thread Vladimir Sementsov-Ogievskiy
Use new QEMU_IOVEC_INIT_BUF() instead of qemu_iovec_init_external( ... , 1), which simplifies the code. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/commit.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/block/commit.c b/block/commit.c index 53148e610b..d500a

[Qemu-devel] [PATCH v3 13/17] migration/block: use qemu_iovec_init_buf

2019-02-07 Thread Vladimir Sementsov-Ogievskiy
Use new qemu_iovec_init_buf() instead of qemu_iovec_init_external( ... , 1), which simplifies the code. Signed-off-by: Vladimir Sementsov-Ogievskiy --- migration/block.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/migration/block.c b/migration/block.c index 0e2

[Qemu-devel] [PATCH v3 03/17] block/block-backend: use QEMU_IOVEC_INIT_BUF

2019-02-07 Thread Vladimir Sementsov-Ogievskiy
Use new QEMU_IOVEC_INIT_BUF() instead of qemu_iovec_init_external( ... , 1), which simplifies the code. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/block-backend.c | 13 ++--- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/block/block-backend.c b/block/block-bac

[Qemu-devel] [PATCH v3 12/17] qemu-img: use qemu_iovec_init_buf

2019-02-07 Thread Vladimir Sementsov-Ogievskiy
Use new qemu_iovec_init_buf() instead of qemu_iovec_init_external( ... , 1), which simplifies the code. Signed-off-by: Vladimir Sementsov-Ogievskiy --- qemu-img.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 25288c4d18..7853935049 1

[Qemu-devel] [PATCH v3 01/17] block: enhance QEMUIOVector structure

2019-02-07 Thread Vladimir Sementsov-Ogievskiy
Add a possibility of embedded iovec, for cases when we need only one local iov. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/qemu/iov.h | 64 -- 1 file changed, 62 insertions(+), 2 deletions(-) diff --git a/include/qemu/iov.h b/include/qemu

[Qemu-devel] [PATCH v3 08/17] block/qcow: use qemu_iovec_init_buf

2019-02-07 Thread Vladimir Sementsov-Ogievskiy
Use new qemu_iovec_init_buf() instead of qemu_iovec_init_external( ... , 1), which simplifies the code. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow.c | 21 - 1 file changed, 4 insertions(+), 17 deletions(-) diff --git a/block/qcow.c b/block/qcow.c index 0a235b

[Qemu-devel] [PATCH v3 07/17] block/parallels: use QEMU_IOVEC_INIT_BUF

2019-02-07 Thread Vladimir Sementsov-Ogievskiy
Use new QEMU_IOVEC_INIT_BUF() instead of qemu_iovec_init_external( ... , 1), which simplifies the code. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/parallels.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/block/parallels.c b/block/parallels.c index

Re: [Qemu-devel] [PATCH 02/10] hw/rdma: Introduce locked qlist

2019-02-07 Thread Yuval Shaia
On Thu, Feb 07, 2019 at 11:05:23AM +0200, Marcel Apfelbaum wrote: > Hi Yuval, > > On 1/31/19 3:08 PM, Yuval Shaia wrote: > > To make code more readable move handling of locked list to a generic > > functions. > > > > Signed-off-by: Yuval Shaia > > --- > > hw/rdma/rdma_backend.c | 20 +

[Qemu-devel] [PATCH v3 02/17] block/io: use qemu_iovec_init_buf

2019-02-07 Thread Vladimir Sementsov-Ogievskiy
Use new qemu_iovec_init_buf() instead of qemu_iovec_init_external( ... , 1), which simplifies the code. While being here, use qemu_try_blockalign0 as well. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/io.c | 89 -- 1 file changed, 20

[Qemu-devel] [PATCH v3 04/17] block/backup: use qemu_iovec_init_buf

2019-02-07 Thread Vladimir Sementsov-Ogievskiy
Use new qemu_iovec_init_buf() instead of qemu_iovec_init_external( ... , 1), which simplifies the code. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/backup.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/block/backup.c b/block/backup.c index 435414e964..9988753

[Qemu-devel] [PATCH v3 14/17] tests/test-bdrv-drain: use QEMU_IOVEC_INIT_BUF

2019-02-07 Thread Vladimir Sementsov-Ogievskiy
Use new QEMU_IOVEC_INIT_BUF() instead of qemu_iovec_init_external( ... , 1), which simplifies the code. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/test-bdrv-drain.c | 29 - 1 file changed, 4 insertions(+), 25 deletions(-) diff --git a/tests/test-bdrv-drain

Re: [Qemu-devel] [PATCH v2 02/20] Acceptance tests: show avocado test execution by default

2019-02-07 Thread Cornelia Huck
On Wed, 6 Feb 2019 12:36:23 -0500 Cleber Rosa wrote: > On 2/6/19 12:20 PM, Cornelia Huck wrote: > > So, to summarize: > > - add 'make check-acceptance-quick' that excludes tests marked as 'slow' > > Yes... with one caveat: since the default is to have functional tests > that are not necessaril

[Qemu-devel] [PATCH v3 10/17] block/qed: use qemu_iovec_init_buf

2019-02-07 Thread Vladimir Sementsov-Ogievskiy
Use new qemu_iovec_init_buf() instead of qemu_iovec_init_external( ... , 1), which simplifies the code. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qed-table.c | 16 +++- block/qed.c | 31 +-- 2 files changed, 12 insertions(+), 35 deletions

Re: [Qemu-devel] [PULL v2 00/76] misc patches for 2019-02-04

2019-02-07 Thread Peter Maydell
On Tue, 5 Feb 2019 at 18:18, Paolo Bonzini wrote: > > The following changes since commit 1c3d45df5e94042d5fb2bb31416072563ab30e49: > > Merge remote-tracking branch 'remotes/ericb/tags/pull-nbd-2019-02-04' into > staging (2019-02-05 12:46:18 +) > > are available in the git repository at: > >

[Qemu-devel] [PATCH v3 09/17] block/qcow2: use qemu_iovec_init_buf

2019-02-07 Thread Vladimir Sementsov-Ogievskiy
Use new qemu_iovec_init_buf() instead of qemu_iovec_init_external( ... , 1), which simplifies the code. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2.c | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index 8c91b92865..

Re: [Qemu-devel] [Bug 1815024] [NEW] SIGILL on instruction "stck" under qemu-s390x in user mode

2019-02-07 Thread Cornelia Huck
On Thu, 07 Feb 2019 09:46:07 - Giovanni Mascellani wrote: > Public bug reported: > > qemu-s390x in user mode crashes with SIGILL (under host architecture > x86_64, running Debian unstable) when executing target instruction > "stck" ("STORE CLOCK", see > https://www-01.ibm.com/support/docview

[Qemu-devel] [PULL 2/3] linux-user: Check sscanf return value in open_net_route()

2019-02-07 Thread Laurent Vivier
From: Peter Maydell Coverity warns (CID 1390634) that open_net_route() is not checking the return value from sscanf(), which means that it might then use values that aren't initialized. Errors here should in general not happen since we're passing an assumed-good /proc/net/route from the host ker

[Qemu-devel] [PULL 3/3] linux-user: add new netlink types

2019-02-07 Thread Laurent Vivier
Add QEMU_IFLA_MIN_MTU, QEMU_IFLA_MAX_MTU (from linux v4.19) QEMU_IFLA_BRPORT_ISOLATED (from linux v4.18) and QEMU_IFLA_BRPORT_BACKUP_PORT (from linux v4.19). These new types fix this error flow with sudo: ... Unknown host QEMU_IFLA type: 50 Unknown host QEMU_IFLA type: 51 Unknown QEMU_IFLA

[Qemu-devel] [PULL 0/3] Linux user for 4.0 patches

2019-02-07 Thread Laurent Vivier
The following changes since commit 47994e16b1d66411953623e7c0bf0cdcd50bd507: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20190205' into staging (2019-02-05 18:25:07 +) are available in the Git repository at: git://github.com/vivier/qemu.git tags/linux-user-for-4.

[Qemu-devel] [PULL 1/3] Fix linux-user crashes in ioctl(SIOCGIFCONF) when ifc_buf is NULL.

2019-02-07 Thread Laurent Vivier
From: Kan Li Summary: This is to fix bug https://bugs.launchpad.net/qemu/+bug/1796754. It is valid for ifc_buf to be NULL according to http://man7.org/linux/man-pages/man7/netdevice.7.html. Signed-off-by: Kan Li Reviewed-by: Laurent Vivier Message-Id: <20181024201303.114-1-likan_999.stud...@si

Re: [Qemu-devel] [PATCH] pc-dimm: use same mechanism for [get|set]_addr

2019-02-07 Thread Igor Mammedov
On Wed, 6 Feb 2019 23:55:15 + Wei Yang wrote: > On Wed, Feb 06, 2019 at 12:59:49PM +0100, Igor Mammedov wrote: > >On Fri, 1 Feb 2019 09:08:37 +0800 > >Wei Yang wrote: > > > >> [get|set]_addr are two counterpart to access PCDIMMDevice.addr. > >> > >> Since we have already set up a property

Re: [Qemu-devel] [Bug 1815024] [NEW] SIGILL on instruction "stck" under qemu-s390x in user mode

2019-02-07 Thread Giovanni Mascellani
Hi, thanks for answering! Il 07/02/19 11:49, Cornelia Huck ha scritto: > Did that work before commit 7de3b1cdc67 ("s390x/tcg: properly implement > the TOD")? It does not seem so: $ /qemu-s390x-new -version qemu-s390x version 2.12.50 (v2.12.0-1983-g7de3b1cdc6-dirty) Copyright (c) 2003-2017 Fabric

Re: [Qemu-devel] [PATCH v3 05/17] qapi: Generate QAPIEvent stuff into separate files

2019-02-07 Thread Marc-André Lureau
On Wed, Feb 6, 2019 at 7:17 PM Markus Armbruster wrote: > > Having to include qapi-events.h just for QAPIEvent is suboptimal, but > quite tolerable now. It'll become problematic when we have events > conditional on the target, because then qapi-events.h won't be usable > from target-independent c

Re: [Qemu-devel] [PATCH v3 03/17] qapi: Clean up modular built-in code generation a bit

2019-02-07 Thread Marc-André Lureau
Hi On Wed, Feb 6, 2019 at 7:17 PM Markus Armbruster wrote: > > We neglect to call .visit_module() for the special module we use for > built-ins. Harmless, but clean it up anyway. The > tests/qapi-schema/*.out now show the built-in module as 'module None'. > > Subclasses of QAPISchemaModularCVis

Re: [Qemu-devel] [PATCH v3 07/17] qapi: New module target.json

2019-02-07 Thread Marc-André Lureau
On Wed, Feb 6, 2019 at 7:17 PM Markus Armbruster wrote: > > We can't add appropriate target-specific conditionals to misc.json, > because that would make all of misc.json unusable in > target-independent code. To keep misc.json target-independent, we > need to split off target-dependent target.js

  1   2   3   4   5   >