On 2019-02-08 08:30, Markus Armbruster wrote: > Short story: please add > > [am] > messageid = true > > to your .gitconfig. > > Long story. git-am can add a Message-id: tag. Looks like this: > > commit 335dbb5de1e98c4dc73590349f17bb2a4d72596c > Author: Thomas Huth <th...@redhat.com> > Date: Mon Feb 4 09:25:43 2019 +0100 > Commit: Peter Maydell <peter.mayd...@linaro.org> > CommitDate: Mon Feb 4 15:25:21 2019 +0000 > > tests/docker/test-mingw and docs: Remove --with-sdlabi=2.0 > > Patchew currently reports failures with the mingw docker test - this > is due to --with-sdlabi=2.0 configure flag which does not exist > anymore. > Remove this remainder from the docker test and the docs now. > > Signed-off-by: Thomas Huth <th...@redhat.com> > Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> > Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com> > Tested-by: Philippe Mathieu-Daudé <phi...@redhat.com> > Acked-by: Alex Bennée <alex.ben...@linaro.org> > ---> Message-id: 1549268743-18502-1-git-send-email-th...@redhat.com > Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> > > The Message-id identifies the patch e-mail. It makes finding the review > thread easier and more reliable. It's also a valid key on Patchew[*]. > > Sadly, not all of our commits don't carry it. Here's how top committers > have been doing recently[**]: > > with without > 264 21 Peter Maydell <peter.mayd...@linaro.org> > 65 2 Gerd Hoffmann <kra...@redhat.com> > 64 0 Laurent Vivier <laur...@vivier.eu> > 64 0 Eric Blake <ebl...@redhat.com> > 62 1 Eduardo Habkost <ehabk...@redhat.com> > 56 0 Markus Armbruster <arm...@redhat.com> > 29 72 Richard Henderson <richard.hender...@linaro.org> > 24 24 Paolo Bonzini <pbonz...@redhat.com> > 10 31 Marcel Apfelbaum <marcel.apfelb...@gmail.com> > 0 107 Kevin Wolf <kw...@redhat.com> > 0 106 David Gibson <da...@gibson.dropbear.id.au> > 0 93 Michael S. Tsirkin <m...@redhat.com> > 0 81 Aleksandar Markovic <amarko...@wavecomp.com> > 0 69 Samuel Thibault <samuel.thiba...@ens-lyon.org> > 0 54 Alex Bennée <alex.ben...@linaro.org> > 0 50 Thomas Huth <th...@redhat.com> > 0 29 Anthony PERARD <anthony.per...@citrix.com> > 0 28 Marc-André Lureau <marcandre.lur...@redhat.com> > > Not bad, but there's room for improvement.
I'd like to, but I can't. I'm still using git 1.8 and the -m parameter is not supported there yet. Thomas
