Re: [Qemu-devel] [PULL 0/5] Ui 20190201 patches

2019-02-01 Thread Peter Maydell
> > are available in the git repository at: > > git://git.kraxel.org/qemu tags/ui-20190201-pull-request > > for you to fetch changes up to 0015ca5cbabe0b31d31610ddfaafd90a9e5911a4: > > ui: remove support for

Re: [Qemu-devel] [PATCH v2 2/5] virtio-blk: add "discard-wzeroes" boolean property

2019-02-01 Thread Stefano Garzarella
On Fri, Feb 1, 2019 at 4:17 PM Michael S. Tsirkin wrote: > > On Thu, Jan 31, 2019 at 04:19:11PM +0100, Stefano Garzarella wrote: > > In order to avoid migration issues, we enable DISCARD and > > WRITE ZEROES features only for machine type >= 4.0 > > > > Suggested-by: Dr. David Alan Gilbert > > Si

Re: [Qemu-devel] [PATCH] m25p80: add basic support for the SFPD command

2019-02-01 Thread Cédric Le Goater
Hello Francisco, On 2/1/19 8:55 AM, Francisco Iglesias wrote: > Hi Cedric, > > On [2019 Jan 21] Mon 17:00:02, Cédric Le Goater wrote: >> JEDEC STANDARD JESD216 for Serial Flash Discovery Parameters (SFDP) >> provides a mean to describe the features of a serial flash device >> using a set of inter

Re: [Qemu-devel] [PATCH 03/11] docs: Commit initial files from sphinx-quickstart

2019-02-01 Thread Alex Bennée
Peter Maydell writes: > Commit the initial Sphinx conf.py and skeleton index.rst as > generated with sphinx-quickstart > --- > docs/conf.py | 168 + > docs/index.rst | 20 ++ > 2 files changed, 188 insertions(+) > create mode 100644 docs/

Re: [Qemu-devel] [PATCH 05/11] docs/conf.py: Configure the 'alabaster' theme

2019-02-01 Thread Alex Bennée
Peter Maydell writes: > Add the 'navigation' bar to the sidebar, which for some > reason is not enabled by default. Remove 'relations', which > is effectively disabled anyway and isn't useful for us. I'm not sure what the title means... is the theme a reference to a layout? I thought themes we

Re: [Qemu-devel] [PATCH 09/11] Makefile, configure: Support building rST documentation

2019-02-01 Thread Alex Bennée
Alex Bennée writes: > Peter Maydell writes: > >> Add support to our configure and makefile machinery for building >> our rST docs into HTML files. >> >> Building the documentation now requires that sphinx-build is >> available; this seems better than allowing half the docs to >> be built if it

Re: [Qemu-devel] [PATCH 00/11] Enable build and install of our rST docs

2019-02-01 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190201145035.22739-1-peter.mayd...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH 00/11] Enable build and install of our rST docs Type: series Message-id: 2019020

Re: [Qemu-devel] [PATCH 00/11] Enable build and install of our rST docs

2019-02-01 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190201145035.22739-1-peter.mayd...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20190201145035.22739-1-peter.mayd...@linaro.org Subject: [Qemu-devel] [PATCH 00/11]

Re: [Qemu-devel] [PATCH 00/11] Enable build and install of our rST docs

2019-02-01 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190201145035.22739-1-peter.mayd...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH 00/11] Enable build and install of our rST docs Message-id: 20190201145035.22739

Re: [Qemu-devel] [PATCH v11 3/3] qemu-img info: bitmaps extension new test 239

2019-02-01 Thread Kevin Wolf
Am 31.01.2019 um 14:46 hat Andrey Shinkevich geschrieben: > A new test file 239 added to the qemu-iotests set. It checks > the output format of 'qemu-img info' for bitmaps extension of > qcow2 specific information. > > Signed-off-by: Andrey Shinkevich 239 is already taken, so please rename this

[Qemu-devel] [PATCH] qemu-common.h: Update copyright string for 2019

2019-02-01 Thread Peter Maydell
Update the copyright string we use in version/help output, since we're well into the new year now. Signed-off-by: Peter Maydell --- Better than last year, where we didn't get round to doing the year bump until September :-) --- include/qemu-common.h | 2 +- 1 file changed, 1 insertion(+), 1 dele

Re: [Qemu-devel] [RFC PATCH 0/3] lm32: convert to new common tcg infrastructure

2019-02-01 Thread Alex Bennée
Michael Walle writes: > The main problem here is, that there is no prebuilt compiler packages. Thus > I have to build the toolchain from scratch. I don't know if this is OK in > the docker image. Well you only have to do it the once - certainly I can't imagine a TCG developer that hasn't built

Re: [Qemu-devel] [PATCH v11 2/3] qemu-img info lists bitmap directory entries

2019-02-01 Thread Eric Blake
On 1/31/19 7:46 AM, Andrey Shinkevich wrote: > In the 'Format specific information' section of the 'qemu-img info' > command output, the supplemental information about existing QCOW2 > bitmaps will be shown, such as a bitmap name, flags and granularity: > > + > +static Qcow2BitmapInfoFlagsList *g

Re: [Qemu-devel] [PULL 00/27] Block layer patches

2019-02-01 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190201163518.31157-1-kw...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20190201163518.31157-1-kw...@redhat.com Subject: [Qemu-devel] [PULL 00/27] Block layer patche

Re: [Qemu-devel] [PATCH 10/11] Makefile: Abstract out "identify the pkgversion" code

2019-02-01 Thread Alex Bennée
Peter Maydell writes: > Abstract out the "identify the pkgversion" code from the > rule for creating qemu-version.h, so it sets makefile > variables for QEMU_PKGVERSION and QEMU_FULL_VERSION. > (We will want to use these when building the Sphinx docs.) > > Signed-off-by: Peter Maydell Reviewe

Re: [Qemu-devel] [PATCH 00/11] Enable build and install of our rST docs

2019-02-01 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190201145035.22739-1-peter.mayd...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20190201145035.22739-1-peter.mayd...@linaro.org Subject: [Qemu-devel] [PATCH 00/11]

Re: [Qemu-devel] [RFC PATCH 1/3] tests/docker: add debian-lm32-cross image

2019-02-01 Thread Alex Bennée
Michael Walle writes: > Unfortunately, there is no debian package for the lm32 toolchain. To > keep the build times short, only build the binutils from scratch. > > Signed-off-by: Michael Walle > --- > tests/docker/Makefile.include | 5 ++-- > tests/docker/dockerfiles/deb

Re: [Qemu-devel] [PULL 00/27] Block layer patches

2019-02-01 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190201163518.31157-1-kw...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PULL 00/27] Block layer patches Message-id: 20190201163518.31157-1-kw...@redhat.com Type: serie

Re: [Qemu-devel] [PATCH 00/11] Enable build and install of our rST docs

2019-02-01 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190201145035.22739-1-peter.mayd...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20190201145035.22739-1-peter.mayd...@linaro.org Subject: [Qemu-devel] [PATCH 00/11]

Re: [Qemu-devel] [PATCH v11 2/3] qemu-img info lists bitmap directory entries

2019-02-01 Thread Kevin Wolf
Am 31.01.2019 um 14:46 hat Andrey Shinkevich geschrieben: > In the 'Format specific information' section of the 'qemu-img info' > command output, the supplemental information about existing QCOW2 > bitmaps will be shown, such as a bitmap name, flags and granularity: > > image: /vz/vmprivate/VM1/ha

Re: [Qemu-devel] [PATCH v11 3/3] qemu-img info: bitmaps extension new test 239

2019-02-01 Thread Eric Blake
On 1/31/19 7:46 AM, Andrey Shinkevich wrote: > A new test file 239 added to the qemu-iotests set. It checks > the output format of 'qemu-img info' for bitmaps extension of > qcow2 specific information. > > Signed-off-by: Andrey Shinkevich > --- > tests/qemu-iotests/239 | 74

[Qemu-devel] [PATCH] .travis.yml: separate tools and docs into another entry

2019-02-01 Thread Alex Bennée
Re-building the tools and documents by default is a little wasteful as they are not really affected by the main build options. Split tools and documents into their own task with a minimal softmmu and linux-user target list just to check they don't interact badly. Signed-off-by: Alex Bennée --- .

Re: [Qemu-devel] [RFC PATCH 2/3] tests/tcg: also pass AS and LD variables

2019-02-01 Thread Alex Bennée
Michael Walle writes: > The lm32 architecture doesn't need the complete compiler. In fact, only > the building of GCC is skipped to make building the docker image faster. > > Signed-off-by: Michael Walle > --- > tests/tcg/Makefile.include | 13 +++-- > 1 file changed, 11 insertions(+)

Re: [Qemu-devel] [PATCH 00/11] Enable build and install of our rST docs

2019-02-01 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190201145035.22739-1-peter.mayd...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20190201145035.22739-1-peter.mayd...@linaro.org Subject: [Qemu-devel] [PATCH 00/11]

Re: [Qemu-devel] [PATCH] s390x/pci: mark zpci devices as unmigratable

2019-02-01 Thread Cornelia Huck
On Fri, 1 Feb 2019 17:06:26 +0100 David Hildenbrand wrote: > On 01.02.19 16:41, Collin Walling wrote: > > On 2/1/19 7:45 AM, Cornelia Huck wrote: > >> We currently don't migrate any state for zpci devices, which are > >> coupled with standard pci devices. This means funny things happen > >> whe

Re: [Qemu-devel] [PATCH 00/11] Enable build and install of our rST docs

2019-02-01 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190201145035.22739-1-peter.mayd...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH 00/11] Enable build and install of our rST docs Type: series Message-id: 2019020

Re: [Qemu-devel] [PATCH 00/11] Enable build and install of our rST docs

2019-02-01 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190201145035.22739-1-peter.mayd...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH 00/11] Enable build and install of our rST docs Type: series Message-id: 2019020

Re: [Qemu-devel] [PATCH 09/11] Makefile, configure: Support building rST documentation

2019-02-01 Thread Peter Maydell
On Fri, 1 Feb 2019 at 17:11, Alex Bennée wrote: > I did the following: > > modified Makefile > @@ -322,6 +322,7 @@ endif > ifdef CONFIG_TRACE_SYSTEMTAP > DOCS+=scripts/qemu-trace-stap.1 > endif > +DOCS+=sphinxdocs > else > DOCS= > endif This kind of works, but it's a bit odd, because DOCS

Re: [Qemu-devel] [PATCH 00/11] Enable build and install of our rST docs

2019-02-01 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190201145035.22739-1-peter.mayd...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH 00/11] Enable build and install of our rST docs Message-id: 20190201145035.22739

Re: [Qemu-devel] [PATCH 03/11] docs: Commit initial files from sphinx-quickstart

2019-02-01 Thread Peter Maydell
On Fri, 1 Feb 2019 at 14:50, Peter Maydell wrote: > > Commit the initial Sphinx conf.py and skeleton index.rst as > generated with sphinx-quickstart Oops, patchew points out that I forgot Signed-off-by: Peter Maydell thanks -- PMM

Re: [Qemu-devel] [PATCH v11 3/3] qemu-img info: bitmaps extension new test 239

2019-02-01 Thread Kevin Wolf
Am 01.02.2019 um 18:23 hat Eric Blake geschrieben: > On 1/31/19 7:46 AM, Andrey Shinkevich wrote: > > A new test file 239 added to the qemu-iotests set. It checks > > the output format of 'qemu-img info' for bitmaps extension of > > qcow2 specific information. > > > > Signed-off-by: Andrey Shinkev

Re: [Qemu-devel] [PATCH 00/11] Enable build and install of our rST docs

2019-02-01 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190201145035.22739-1-peter.mayd...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH 00/11] Enable build and install of our rST docs Type: series Message-id: 2019020

Re: [Qemu-devel] [PATCH 00/11] Enable build and install of our rST docs

2019-02-01 Thread Peter Maydell
On Fri, 1 Feb 2019 at 15:06, wrote: > > Patchew URL: > https://patchew.org/QEMU/20190201145035.22739-1-peter.mayd...@linaro.org/ > > > > Hi, > > This series seems to have some coding style problems. See output below for > more information: > > Subject: [Qemu-devel] [PATCH 00/11] Enable build and

Re: [Qemu-devel] [RFC PATCH 2/3] tests/tcg: also pass AS and LD variables

2019-02-01 Thread Michael Walle
Am 1. Februar 2019 18:31:46 MEZ schrieb "Alex Bennée" : > >Michael Walle writes: > >> The lm32 architecture doesn't need the complete compiler. In fact, >only >> the building of GCC is skipped to make building the docker image >faster. >> >> Signed-off-by: Michael Walle >> --- >> tests/tcg/Makef

Re: [Qemu-devel] [PATCH 00/11] Enable build and install of our rST docs

2019-02-01 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190201145035.22739-1-peter.mayd...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20190201145035.22739-1-peter.mayd...@linaro.org Subject: [Qemu-devel] [PATCH 00/11]

Re: [Qemu-devel] Crash when booting KDE Neon using qxl-vga

2019-02-01 Thread Leonardo Soares Müller
Mageia 7 guest is crashing too. The command line: qemu-system-x86_64 \ -name "Mageia 7" -k pt-br -nodefaults -accel kvm -cpu host -smp cores=2,threads=1 -m 1G \ -device qxl-vga,xres=1366,yres=768 \ -device qemu-xhci,id=xhcihub -device usb-audio,id=usbaudio,buffer=6144 \ -device usb-tablet,id=usbt

Re: [Qemu-devel] [PATCH] qemu-common.h: Update copyright string for 2019

2019-02-01 Thread Eric Blake
On 2/1/19 11:36 AM, Peter Maydell wrote: > Update the copyright string we use in version/help output, > since we're well into the new year now. > > Signed-off-by: Peter Maydell > --- > Better than last year, where we didn't get round to doing > the year bump until September :-) And at least this

Re: [Qemu-devel] [PATCH 0/9] Network announce changes

2019-02-01 Thread Markus Armbruster
git-am gripes: Applying: net: Introduce announce timer .git/rebase-apply/patch:159: new blank line at EOF. + warning: 1 line adds whitespace errors. Applying: migration: Add announce parameters Applying: virtio-net: Switch to using announce timer .git/rebase-apply/patch:20: new blank line at EOF.

Re: [Qemu-devel] [PULL 00/47] target-arm queue

2019-02-01 Thread Peter Maydell
g branch 'remotes/xanclic/tags/pull-block-2019-01-31' > into staging (2019-01-31 19:26:09 +) > > are available in the Git repository at: > > https://git.linaro.org/people/pmaydell/qemu-arm.git > tags/pull-target-arm-20190201 > > for you to fetch changes up t

Re: [Qemu-devel] [PATCH 4/6] linux-user: Initialize aarch64 pac keys

2019-02-01 Thread Richard Henderson
On 2/1/19 7:11 AM, Peter Maydell wrote: > On Fri, 25 Jan 2019 at 22:57, Richard Henderson > wrote: >> >> Initialize the keys to a non-zero value on process start. >> >> Signed-off-by: Richard Henderson > >> +static uint64_t arm_rand64(void) >> +{ >> +int shift = 64 - clz64(RAND_MAX); >> +

Re: [Qemu-devel] [PATCH 2/9] migration: Add announce parameters

2019-02-01 Thread Markus Armbruster
"Dr. David Alan Gilbert (git)" writes: > From: "Dr. David Alan Gilbert" > > Add migration parameters that control RARP/GARP announcement timeouts. > > Based on earlier patches by myself and > Vladislav Yasevich > > Signed-off-by: Dr. David Alan Gilbert > --- [...] > diff --git a/qapi/migrati

Re: [Qemu-devel] [PATCH v2] qemu-nbd: Deprecate qemu-nbd --partition

2019-02-01 Thread Eric Blake
On 1/25/19 5:48 PM, Eric Blake wrote: > The existing qemu-nbd --partition code claims to handle logical > partitions up to 8, since its introduction in 2008 (commit 7a5ca86). > However, the implementation is bogus (actual MBR logical partitions > form a sort of linked list, with one partition per e

Re: [Qemu-devel] [PATCH] nbd: generalize usage of nbd_read

2019-02-01 Thread Eric Blake
On 1/28/19 10:58 AM, Vladimir Sementsov-Ogievskiy wrote: > We generally do very similar things around nbd_read: error_prepend, > specifying, what we have tried to read and be_to_cpu conversion of > integers. > > So, it seems reasonable to move common things to helper functions, > which: > 1. simpl

Re: [Qemu-devel] [PATCH] nbd: generalize usage of nbd_read

2019-02-01 Thread Eric Blake
On 2/1/19 12:27 PM, Eric Blake wrote: > > >> + >> +#define DEF_NBD_READ(bits) \ >> +static inline int nbd_read ## bits(QIOChannel *ioc, uint ## bits ## _t * >> val, \ > > checkpatch didn't flag it, but I think our style is '*val', not '* val'. But it DOES flag '*val' as a false positive. Oh

Re: [Qemu-devel] [PULL v2 00/11] check-softfloat, fp-bench and clang compile fixes

2019-02-01 Thread Eric Blake
On 1/23/19 5:42 AM, Alex Bennée wrote: > The following changes since commit 952bc8b3c2cbba78261923a1e8ca55cda261dee9: > > Merge remote-tracking branch 'remotes/ericb/tags/pull-nbd-2019-01-21' into > staging (2019-01-22 17:56:21 +) > > are available in the Git repository at: > > https://

Re: [Qemu-devel] [PATCH v11 2/3] qemu-img info lists bitmap directory entries

2019-02-01 Thread Markus Armbruster
Andrey Shinkevich writes: > In the 'Format specific information' section of the 'qemu-img info' > command output, the supplemental information about existing QCOW2 > bitmaps will be shown, such as a bitmap name, flags and granularity: > > image: /vz/vmprivate/VM1/harddisk.hdd > file format: qcow2

Re: [Qemu-devel] [PATCH v11 2/3] qemu-img info lists bitmap directory entries

2019-02-01 Thread Eric Blake
On 2/1/19 12:39 PM, Markus Armbruster wrote: > Andrey Shinkevich writes: > >> >> ## >> +# @Qcow2BitmapInfoFlags: >> +# >> +# An enumeration of flags that a bitmap can report to the user. >> +# >> +# @in-use: The bitmap was not saved correctly and may be inconsistent. > > I doubt the casual r

Re: [Qemu-devel] [PULL 00/27] Block layer patches

2019-02-01 Thread Peter Maydell
On Fri, 1 Feb 2019 at 16:35, Kevin Wolf wrote: > > The following changes since commit cfe6c547690b06fbce54a6d0f7b05dd7f18e36ea: > > Merge remote-tracking branch 'remotes/xanclic/tags/pull-block-2019-01-31' > into staging (2019-01-31 19:26:09 +) > > are available in the Git repository at: >

[Qemu-devel] [PATCH] ppc: add host-serial and host-model machine attributes

2019-02-01 Thread P J P
From: Prasad J Pandit On ppc hosts, hypervisor shares following system attributes - /proc/device-tree/system-id - /proc/device-tree/model with a guest. This could lead to information leakage and misuse.[*] Add machine attributes to control such system information exposure to a guest. [*] h

Re: [Qemu-devel] [PATCH] iotests/236: fix transaction kwarg order

2019-02-01 Thread John Snow
On 1/31/19 5:17 AM, Vladimir Sementsov-Ogievskiy wrote: > 31.01.2019 5:26, John Snow wrote: >> It's not enough to order the kwargs for consistent QMP log output, >> we must also sort any sub-dictionaries in lists that appear as values. >> >> Reported-by: Kevin Wolf >> Signed-off-by: John Snow

Re: [Qemu-devel] [PATCH v11 2/3] qemu-img info lists bitmap directory entries

2019-02-01 Thread Markus Armbruster
Eric Blake writes: > On 2/1/19 12:39 PM, Markus Armbruster wrote: >> Andrey Shinkevich writes: >> > >>> >>> ## >>> +# @Qcow2BitmapInfoFlags: >>> +# >>> +# An enumeration of flags that a bitmap can report to the user. >>> +# >>> +# @in-use: The bitmap was not saved correctly and may be incons

Re: [Qemu-devel] [PATCH v11 2/3] qemu-img info lists bitmap directory entries

2019-02-01 Thread Eric Blake
On 2/1/19 1:23 PM, Markus Armbruster wrote: +# @unknown-flags: any remaining flags not recognized by the current qemu version >>> >>> Intended use cases for @unknown-flags? >> >> The qcow2 spec defines bit 2 extra_data_compatible; and also leaves the >> door open for future extensions t

[Qemu-devel] [PATCH v13 01/31] block: Use bdrv_refresh_filename() to pull

2019-02-01 Thread Max Reitz
Before this patch, bdrv_refresh_filename() is used in a pushing manner: Whenever the BDS graph is modified, the parents of the modified edges are supposed to be updated (recursively upwards). However, that is nonviable, considering that we want child changes not to concern parents. Also, in the l

[Qemu-devel] [PATCH v13 06/31] iotests.py: Add filter_imgfmt()

2019-02-01 Thread Max Reitz
Signed-off-by: Max Reitz --- tests/qemu-iotests/iotests.py | 10 ++ 1 file changed, 10 insertions(+) diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py index c323c62d20..8c5dd40f83 100644 --- a/tests/qemu-iotests/iotests.py +++ b/tests/qemu-iotests/iotests.py @@ -

[Qemu-devel] [PATCH v13 00/31] Fix some filename generation issues

2019-02-01 Thread Max Reitz
Once more, I’ll spare both me and you another iteration of the cover letter, so I direct you to the previous version’s cover letter (which will direct you further): http://lists.nongnu.org/archive/html/qemu-block/2018-10/msg00229.html There are mostly rebase fixes in this version. Provided no ma

[Qemu-devel] [PATCH v13 03/31] block: Skip implicit nodes for filename info

2019-02-01 Thread Max Reitz
bdrv_refresh_filename() should simply skip all implicit nodes. They are supposed to be invisible to the user, so they should not appear in filename information. Signed-off-by: Max Reitz Reviewed-by: Eric Blake Reviewed-by: Alberto Garcia --- block.c | 14 ++ 1 file changed, 14 ins

[Qemu-devel] [PATCH v13 02/31] block: Use children list in bdrv_refresh_filename

2019-02-01 Thread Max Reitz
bdrv_refresh_filename() should invoke itself recursively on all children, not just on file. With that change, we can remove the manual invocations in blkverify, quorum, commit, mirror, and blklogwrites. Signed-off-by: Max Reitz Reviewed-by: Eric Blake Reviewed-by: Alberto Garcia --- block.c

[Qemu-devel] [PATCH v13 07/31] iotests.py: Add node_info()

2019-02-01 Thread Max Reitz
This function queries a node; since we cannot do that right now, it executes query-named-block-nodes and returns the matching node's object. Signed-off-by: Max Reitz Reviewed-by: John Snow Reviewed-by: Alberto Garcia Reviewed-by: Eric Blake --- tests/qemu-iotests/iotests.py | 7 +++ 1 fil

[Qemu-devel] [PATCH v13 05/31] block: Respect backing bs in bdrv_refresh_filename

2019-02-01 Thread Max Reitz
Basically, bdrv_refresh_filename() should respect all children of a BlockDriverState. However, generally those children are driver-specific, so this function cannot handle the general case. On the other hand, there are only few drivers which use other children than @file and @backing (that being vm

[Qemu-devel] [PATCH v13 08/31] iotests: Add test for backing file overrides

2019-02-01 Thread Max Reitz
Signed-off-by: Max Reitz --- tests/qemu-iotests/228 | 242 + tests/qemu-iotests/228.out | 84 + tests/qemu-iotests/group | 1 + 3 files changed, 327 insertions(+) create mode 100755 tests/qemu-iotests/228 create mode 100644 tests/qemu-iot

[Qemu-devel] [PATCH v13 04/31] block: Add BDS.auto_backing_file

2019-02-01 Thread Max Reitz
If the backing file is overridden, this most probably does change the guest-visible data of a BDS. Therefore, we will need to consider this in bdrv_refresh_filename(). To see whether it has been overridden, we might want to compare bs->backing_file and bs->backing->bs->filename. However, bs->bac

[Qemu-devel] [PATCH v13 09/31] block: Make path_combine() return the path

2019-02-01 Thread Max Reitz
Besides being safe for arbitrary path lengths, after some follow-up patches all callers will want a freshly allocated buffer anyway. In the meantime, path_combine_deprecated() is added which has the same interface as path_combine() had before this patch. All callers to that function will be conver

[Qemu-devel] [PATCH v13 14/31] block: Add bdrv_dirname()

2019-02-01 Thread Max Reitz
This function may be implemented by block drivers to derive a directory name from a BDS. Concatenating this g_free()-able string with a relative filename must result in a valid (not necessarily existing) filename, so this is a function that should generally be not implemented by format drivers, bec

[Qemu-devel] [PATCH v13 12/31] block: Add bdrv_make_absolute_filename()

2019-02-01 Thread Max Reitz
This is a general function for making a filename that is relative to a certain BDS absolute. It calls bdrv_get_full_backing_filename_from_filename() for now, but that will be changed in a follow-up patch. Signed-off-by: Max Reitz Reviewed-by: Alberto Garcia --- block.c | 27 +++

[Qemu-devel] [PATCH v13 10/31] block: bdrv_get_full_backing_filename_from_...'s ret. val.

2019-02-01 Thread Max Reitz
Make bdrv_get_full_backing_filename_from_filename() return an allocated string instead of placing the result in a caller-provided buffer. Signed-off-by: Max Reitz --- include/block/block.h | 7 +++--- block.c | 53 ++- block/vmdk.c

[Qemu-devel] [PATCH v13 19/31] block: Use bdrv_dirname() for relative filenames

2019-02-01 Thread Max Reitz
bdrv_get_full_backing_filename_from_filename() breaks down when it comes to JSON filenames. Using bdrv_dirname() as the basis is better because since we have BDS, we can descend through the BDS tree to the protocol layer, which gives us a greater probability of finding a non-JSON name; also, bdrv_d

[Qemu-devel] [PATCH v13 20/31] iotests: Add quorum case to test 110

2019-02-01 Thread Max Reitz
Test 110 tests relative backing filenames for complex BDS trees. Now that the originally supposedly failing test passes, let us add a new failing test: Quorum can never work automatically (without detecting whether all child nodes have the same base directory, but that would be rather inconsistent

[Qemu-devel] [PATCH v13 18/31] block/nfs: Implement bdrv_dirname()

2019-02-01 Thread Max Reitz
While the basic idea is obvious and could be handled by the default bdrv_dirname() implementation, we cannot generate a directory name if the gid or uid are set, so we have to explicitly return NULL in those cases. Signed-off-by: Max Reitz Reviewed-by: Alberto Garcia --- block/nfs.c | 15 ++

[Qemu-devel] [PATCH v13 11/31] block: bdrv_get_full_backing_filename's ret. val.

2019-02-01 Thread Max Reitz
Make bdrv_get_full_backing_filename() return an allocated string instead of placing the result in a caller-provided buffer. Signed-off-by: Max Reitz Reviewed-by: Alberto Garcia --- include/block/block.h | 3 +-- block.c | 48 +++ block/qapi

[Qemu-devel] [PATCH v13 29/31] block/null: Generate filename even with latency-ns

2019-02-01 Thread Max Reitz
While we cannot represent the latency-ns option in a filename, it is not a strong option so not being able to should not stop us from generating a filename nonetheless. Signed-off-by: Max Reitz Reviewed-by: Alberto Garcia --- block/null.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

[Qemu-devel] [PATCH v13 22/31] block: Add BlockDriver.bdrv_gather_child_options

2019-02-01 Thread Max Reitz
Some follow-up patches will rework the way bs->full_open_options is refreshed in bdrv_refresh_filename(). The new implementation will remove the need for the block drivers' bdrv_refresh_filename() implementations to set bs->full_open_options; instead, it will be generic and use static information f

[Qemu-devel] [PATCH v13 26/31] block/nvme: Fix bdrv_refresh_filename()

2019-02-01 Thread Max Reitz
Currently, nvme's bdrv_refresh_filename() is an exact copy of null's implementation. However, for null, "null-co://" and "null-aio://" are indeed valid filenames -- for nvme, they are not, as a device address is still required. The correct implementation should generate a filename of the form "nv

[Qemu-devel] [PATCH v13 13/31] block: Fix bdrv_find_backing_image()

2019-02-01 Thread Max Reitz
bdrv_find_backing_image() should use bdrv_get_full_backing_filename() or bdrv_make_absolute_filename() instead of trying to do what those functions do by itself. path_combine_deprecated() can now be dropped, so let's do that. Signed-off-by: Max Reitz Reviewed-by: Alberto Garcia --- block.c | 3

[Qemu-devel] [PATCH v13 31/31] iotests: Test json:{} filenames of internal BDSs

2019-02-01 Thread Max Reitz
Signed-off-by: Max Reitz --- tests/qemu-iotests/224 | 139 + tests/qemu-iotests/224.out | 18 + tests/qemu-iotests/group | 1 + 3 files changed, 158 insertions(+) create mode 100755 tests/qemu-iotests/224 create mode 100644 tests/qemu-iotests/224

[Qemu-devel] [PATCH v13 21/31] block: Add strong_runtime_opts to BlockDriver

2019-02-01 Thread Max Reitz
This new field can be set by block drivers to list the runtime options they accept that may influence the contents of the respective BDS. As of a follow-up patch, this list will be used by the common bdrv_refresh_filename() implementation to decide which options to put into BDS.full_open_options (a

[Qemu-devel] [PATCH v13 25/31] block: Do not copy exact_filename from format file

2019-02-01 Thread Max Reitz
If a format BDS's file BDS is in turn a format BDS, we cannot simply use the same filename, because when opening a BDS tree based on a filename alone, qemu will create only one format node on top of one protocol node (disregarding a potential backing file). Signed-off-by: Max Reitz Reviewed-by: A

[Qemu-devel] [PATCH v13 16/31] quorum: Make bdrv_dirname() return NULL

2019-02-01 Thread Max Reitz
While the common implementation for bdrv_dirname() should return NULL for quorum BDSs already (because they do not have a file node and their exact_filename field should be empty), there is no reason not to make that explicit. Signed-off-by: Max Reitz Reviewed-by: Eric Blake Reviewed-by: Alberto

[Qemu-devel] [PATCH v13 30/31] block: BDS options may lack the "driver" option

2019-02-01 Thread Max Reitz
When BDSs are created by qemu itself (e.g. as filters in block jobs), they may not have a "driver" option in their options QDict. When generating a json:{} filename, however, it must always be present. Signed-off-by: Max Reitz Reviewed-by: Alberto Garcia --- block.c | 6 ++ 1 file changed,

[Qemu-devel] [PATCH v13 15/31] blkverify: Make bdrv_dirname() return NULL

2019-02-01 Thread Max Reitz
blkverify's BDSs have a file BDS, but we do not want this to be preferred over the raw node. There is no way to decide between the two (and not really a reason to, either), so just return NULL in blkverify's implementation of bdrv_dirname(). Signed-off-by: Max Reitz Reviewed-by: Eric Blake Revie

[Qemu-devel] [PATCH v13 24/31] block: Purify .bdrv_refresh_filename()

2019-02-01 Thread Max Reitz
Currently, BlockDriver.bdrv_refresh_filename() is supposed to both refresh the filename (BDS.exact_filename) and set BDS.full_open_options. Now that we have generic code in the central bdrv_refresh_filename() for creating BDS.full_open_options, we can drop the latter part from all BlockDriver.bdrv_

[Qemu-devel] [PATCH v13 17/31] block/nbd: Make bdrv_dirname() return NULL

2019-02-01 Thread Max Reitz
The generic bdrv_dirname() implementation would be able to generate some form of directory name for many NBD nodes, but it would be always wrong. Therefore, we have to explicitly make it an error (until NBD has some form of specification for export paths, if it ever will). Signed-off-by: Max Reitz

[Qemu-devel] [PATCH v2 1/2] linux-user: Implement PR_PAC_RESET_KEYS

2019-02-01 Thread Richard Henderson
Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- v2: Check arg3-5 are zero. --- linux-user/aarch64/target_syscall.h | 7 ++ linux-user/syscall.c| 36 + 2 files changed, 43 insertions(+) diff --git a/linux-user/aarch64/target_syscal

[Qemu-devel] [PATCH v2 2/2] tests/tcg/aarch64: Add pauth smoke test

2019-02-01 Thread Richard Henderson
Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- v2: Pass all 5 arguments to prctl; remove -O1. --- tests/tcg/aarch64/pauth-1.c | 23 +++ tests/tcg/aarch64/Makefile.target | 6 +- 2 files changed, 28 insertions(+), 1 deletion(-) create mode 100644 tes

[Qemu-devel] [PATCH v13 28/31] block/curl: Implement bdrv_refresh_filename()

2019-02-01 Thread Max Reitz
Signed-off-by: Max Reitz Reviewed-by: Alberto Garcia --- block/curl.c | 21 + 1 file changed, 21 insertions(+) diff --git a/block/curl.c b/block/curl.c index 2c07a694d8..606709fea4 100644 --- a/block/curl.c +++ b/block/curl.c @@ -950,6 +950,23 @@ static int64_t curl_getlengt

[Qemu-devel] [PATCH v13 23/31] block: Generically refresh runtime options

2019-02-01 Thread Max Reitz
Instead of having every block driver which implements bdrv_refresh_filename() copy all of the strong runtime options over to bs->full_open_options, implement this process generically in bdrv_refresh_filename(). This patch only adds this new generic implementation, it does not remove the old functi

[Qemu-devel] [PATCH v13 27/31] block/curl: Harmonize option defaults

2019-02-01 Thread Max Reitz
Both of the defaults we currently have in the curl driver are named based on a slightly different schema, let's unify that and call both CURL_BLOCK_OPT_${NAME}_DEFAULT. While at it, we can add a macro for the third option for which a default exists, namely "sslverify". Signed-off-by: Max Reitz R

[Qemu-devel] [PATCH] tests: Ignore fp test outputs

2019-02-01 Thread Eric Blake
Commit 2cade3d wired up new tests, but did not exclude the new *.out files produced by running the tests. Signed-off-by: Eric Blake --- tests/.gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/.gitignore b/tests/.gitignore index 72c18aaab04..f2bf85c8c4c 100644 --- a/tests/.giti

Re: [Qemu-devel] [PATCH v13 06/31] iotests.py: Add filter_imgfmt()

2019-02-01 Thread Eric Blake
On 2/1/19 1:29 PM, Max Reitz wrote: > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/iotests.py | 10 ++ > 1 file changed, 10 insertions(+) Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvi

Re: [Qemu-devel] [PATCH v13 01/31] block: Use bdrv_refresh_filename() to pull

2019-02-01 Thread Eric Blake
On 2/1/19 1:29 PM, Max Reitz wrote: > Before this patch, bdrv_refresh_filename() is used in a pushing manner: > Whenever the BDS graph is modified, the parents of the modified edges > are supposed to be updated (recursively upwards). However, that is > nonviable, considering that we want child cha

[Qemu-devel] [PATCH v2 0/2] target/arm: Complete ARMv8.3-PAuth linux-user

2019-02-01 Thread Richard Henderson
Most of the v1 patch set has been merged. Changes since v1: * I've added the missing check against arg3 through arg5. * I've removed the -O1 I had cribed from the MTE patch set. r~ Richard Henderson (2): linux-user: Implement PR_PAC_RESET_KEYS tests/tcg/aarch64: Add pauth smoke test li

Re: [Qemu-devel] [PATCH 6/6] tests/tcg/aarch64: Add pauth smoke tests

2019-02-01 Thread Richard Henderson
On 1/28/19 3:06 AM, Alex Bennée wrote: > We build all tests with: > > CFLAGS+=-Wall -O0 -g -fno-strict-aliasing > > mainly because the first thing you want to do when they fail is run them > through gdb to see what went wrong. Do you actually need optimisation on > for the build to work? Everyt

Re: [Qemu-devel] [PATCH v3] chardev: Allow for pty path passing.

2019-02-01 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1548509635-15776-1-git-send-email-ptsne...@gmail.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT

Re: [Qemu-devel] [PATCH] tests: Ignore fp test outputs

2019-02-01 Thread Emilio G. Cota
On Fri, Feb 01, 2019 at 13:32:34 -0600, Eric Blake wrote: > Commit 2cade3d wired up new tests, but did not exclude the > new *.out files produced by running the tests. > > Signed-off-by: Eric Blake Reviewed-by: Emilio G. Cota E.

Re: [Qemu-devel] [PULL 11/20] iotests: add iotest 236 for testing bitmap merge

2019-02-01 Thread John Snow
On 1/31/19 3:55 AM, Kevin Wolf wrote: > Am 31.01.2019 um 03:03 hat John Snow geschrieben: >> On 1/30/19 12:27 PM, Kevin Wolf wrote: >>> Am 14.01.2019 um 17:25 hat Eric Blake geschrieben: From: John Snow New interface, new smoke test. Signed-off-by: John Snow Revie

Re: [Qemu-devel] Crash when booting KDE Neon using qxl-vga

2019-02-01 Thread Dr. David Alan Gilbert
* Leonardo Soares Müller (leozinho29...@hotmail.com) wrote: > I can confirm this, KDE Neon using the command line similar to yours > crashes QEMU to me too. I will test with Mageia 7 later to see if it > behaves differently. > > But this is a completely different crash. This crash is happening > e

Re: [Qemu-devel] [PATCH] m25p80: add basic support for the SFPD command

2019-02-01 Thread Philippe Mathieu-Daudé
Hi Cédric, On 1/21/19 5:00 PM, Cédric Le Goater wrote: > JEDEC STANDARD JESD216 for Serial Flash Discovery Parameters (SFDP) > provides a mean to describe the features of a serial flash device > using a set of internal parameter tables. > > This is the initial framework for the RDSFPD command whi

Re: [Qemu-devel] [PATCH 42/52] i386: express dependencies with Kconfig

2019-02-01 Thread Paolo Bonzini
On 01/02/19 16:05, Philippe Mathieu-Daudé wrote: > This lacks a DISPLAY dependency? > > $ i386-softmmu/qemu-system-i386 -M q35 > qemu-system-i386: Unknown device 'VGA' for bus 'PCIE' > Aborted (core dumped) If you build --without-default-devices, you pretty much have to do one of two things: 1) e

Re: [Qemu-devel] [PATCH v5 6/6] block/nbd-client: rename read_reply_co to connection_co

2019-02-01 Thread Eric Blake
On 2/1/19 7:01 AM, Vladimir Sementsov-Ogievskiy wrote: > This coroutine will serve nbd reconnects, so, rename it to be something > more generic. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > Reviewed-by: Eric Blake > --- > block/nbd-client.h | 4 ++-- > block/nbd-client.c | 24

Re: [Qemu-devel] [PATCH v5 2/6] block/nbd: move connection code from block/nbd to block/nbd-client

2019-02-01 Thread Eric Blake
On 2/1/19 7:01 AM, Vladimir Sementsov-Ogievskiy wrote: > Keep all connection code in one file, to be able to implement reconnect > in further patches. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > > +static QIOChannelSocket *nbd_establish_connection(SocketAddress *saddr, > +

Re: [Qemu-devel] [PATCH v5 0/6] NBD reconnect: prep. refactoring

2019-02-01 Thread Eric Blake
On 2/1/19 7:01 AM, Vladimir Sementsov-Ogievskiy wrote: > Hi all. > > Here is most of preparatory refactoring for NBD reconnect, rebased > on master. Let's push it. Thanks; queued for my next NBD pull request. > > Sorry for a long delay in answering on v4 review and for v4 which > I pinged a lot

<    1   2   3   4   >