[Qemu-devel] [PATCH 03/15] s390-bios: decouple common boot logic from virtio

2019-01-29 Thread Jason J. Herne
Create a boot_setup function to handle getting boot information from the machine/hypervisor. This decouples common boot logic from the virtio code path and allows us to make use of it for the real dasd boot scenario. Signed-off-by: Jason J. Herne Acked-by: Halil Pasic Reviewed-by: Collin Walling

[Qemu-devel] [PATCH 00/15] s390: vfio-ccw dasd ipl support

2019-01-29 Thread Jason J. Herne
This is to support booting from vfio-ccw dasd devices. We basically implement the real hardware ipl procedure. This allows for booting Linux guests on vfio-ccw devices. vfio-ccw's channel program prefetch algorithm complicates ipl because most ipl channel programs dynamically modify themselves. De

[Qemu-devel] [PATCH 04/15] s390-bios: Extend find_dev() for non-virtio devices

2019-01-29 Thread Jason J. Herne
We need a method for finding the subchannel of a dasd device. Let's modify find_dev to handle this since it mostly does what we need. Up to this point find_dev has been specific to only virtio devices. Signed-off-by: Jason J. Herne Acked-by: Halil Pasic --- pc-bios/s390-ccw/main.c | 16

[Qemu-devel] [PATCH 06/15] s390-bios: Clean up cio.h

2019-01-29 Thread Jason J. Herne
Add proper typedefs to all structs and modify all bit fields to use consistent formatting. Signed-off-by: Jason J. Herne Reviewed-by: Collin Walling --- pc-bios/s390-ccw/cio.h | 86 ++--- pc-bios/s390-ccw/s390-ccw.h | 8 - 2 files changed, 43 in

Re: [Qemu-devel] [PATCH v3 1/2] s390x/pci: Introduce unplug requests and split unplug handler

2019-01-29 Thread Pierre Morel
On 21/01/2019 14:42, David Hildenbrand wrote: PCI on s390x is really weird and how it was modeled in QEMU might not have been the right choice. Anyhow, right now it is the case that: - Hotplugging a PCI device will silently create a zPCI device (if none is provided) - Hotunplugging a zPCI devi

[Qemu-devel] [PATCH 09/15] s390-bios: ptr2u32 and u32toptr

2019-01-29 Thread Jason J. Herne
Introduce inline functions to convert between pointers and unsigned 32-bit ints. These are used to hide the ugliness required to avoid compiler warnings. Signed-off-by: Jason J. Herne --- pc-bios/s390-ccw/libc.h | 12 1 file changed, 12 insertions(+) diff --git a/pc-bios/s390-ccw/

Re: [Qemu-devel] [PATCH v4 01/14] qapi: qapi for audio backends

2019-01-29 Thread Markus Armbruster
"Kővágó, Zoltán" writes: > This patch adds structures into qapi to replace the existing > configuration structures used by audio backends currently. This qapi > will be the base of the -audiodev command line parameter (that replaces > the old environment variables based config). > > This is not a

[Qemu-devel] [PATCH 14/15] s390-bios: Add channel command codes/structs needed for dasd-ipl

2019-01-29 Thread Jason J. Herne
The dasd IPL procedure needs to execute a few previously unused channel commands. Let's define them and their associated data structures. Signed-off-by: Jason J. Herne --- pc-bios/s390-ccw/cio.h | 23 +++ 1 file changed, 23 insertions(+) diff --git a/pc-bios/s390-ccw/cio.h b

[Qemu-devel] [PATCH] target/s390x: Fix LGPL version in the file header comments

2019-01-29 Thread Thomas Huth
It's either "GNU *Library* General Public License version 2" or "GNU Lesser General Public License version *2.1*", but there was no "version 2.0" of the "Lesser" license. So assume that version 2.1 is meant here. Signed-off-by: Thomas Huth --- target/s390x/cc_helper.c | 2 +- target/s390x/excp

[Qemu-devel] [PATCH v2] target/m68k: Fix LGPL information in the file headers

2019-01-29 Thread Thomas Huth
It's either "GNU *Library* General Public License version 2" or "GNU Lesser General Public License version *2.1*", but there was no "version 2.0" of the "Lesser" license. So assume that version 2.1 is meant here. Also some files mention the GPL instead of the LGPL after declaring that the files are

Re: [Qemu-devel] [qemu-s390x] [PATCH v3 2/2] s390x/pci: Unplug remaining devices on pcihost reset

2019-01-29 Thread Pierre Morel
On 29/01/2019 11:24, David Hildenbrand wrote: I'm wondering what the architecture says regarding those events -- can someone with access to the documentation comment? Ping. Any comments from the IBM folks? Hi, Sorry to have wait so long. At least Collin was faster. So the idea here is

Re: [Qemu-devel] [PATCH v11 2/3] util/mmap-alloc: support MAP_SYNC in qemu_ram_mmap()

2019-01-29 Thread Michael S. Tsirkin
On Tue, Jan 29, 2019 at 10:49:09PM +0800, Zhang, Yi wrote: > From: Zhang Yi > > When a file supporting DAX is used as vNVDIMM backend, mmap it with > MAP_SYNC flag in addition which can ensure file system metadata > synced in each guest writes to the backend file, without other QEMU > actions (e.

Re: [Qemu-devel] [PATCH] target/s390x: Fix LGPL version in the file header comments

2019-01-29 Thread Cornelia Huck
On Tue, 29 Jan 2019 14:37:47 +0100 Thomas Huth wrote: > It's either "GNU *Library* General Public License version 2" or > "GNU Lesser General Public License version *2.1*", but there was > no "version 2.0" of the "Lesser" license. So assume that version > 2.1 is meant here. I think we can assume

[Qemu-devel] [PATCH 0/2] target/arm: Fix FCMLA decoding errors

2019-01-29 Thread Peter Maydell
This patchset fixes the two bugs in our decode of FCMLA (by element) reported by Laurent. Based-on: 20190125182626.9221-1-peter.mayd...@linaro.org ("target/arm: Fix various underdecodings") thanks -- PMM Peter Maydell (2): target/arm/translate-a64: Fix FCMLA decoding error target/arm/transla

[Qemu-devel] [PATCH 2/2] target/arm/translate-a64: Fix mishandling of size in FCMLA decode

2019-01-29 Thread Peter Maydell
In disas_simd_indexed(), for the case of "complex fp", each indexable element is a complex pair, so the total size is twice that indicated in the 'size' field in the encoding. We were trying to do this "double the size" operation with a left shift by 1, but this is incorrect because the 'size' fiel

[Qemu-devel] [PATCH 1/2] target/arm/translate-a64: Fix FCMLA decoding error

2019-01-29 Thread Peter Maydell
The FCMLA (by element) instruction exists in the "vector x indexed element" encoding group, but not in the "scalar x indexed element" group. Correctly UNDEF the unallocated encodings. Reported-by: Laurent Desnogues Signed-off-by: Peter Maydell --- target/arm/translate-a64.c | 2 +- 1 file chang

Re: [Qemu-devel] [PATCH 06/11] target/arm: Reset btype for direct branches and syscalls

2019-01-29 Thread Peter Maydell
On Tue, 29 Jan 2019 at 14:05, Richard Henderson wrote: > > On 1/29/19 1:57 AM, Peter Maydell wrote: > >>> The advantage of picking the other choice (SPSR_ELx.BTYPE == > >>> PSTATE.BTYPE) is that it means that the behaviour is identical > >>> for all exceptions (async or sync of any type) and we do

Re: [Qemu-devel] [PATCH v9 1/2] qemu-img info lists bitmap directory entries

2019-01-29 Thread Vladimir Sementsov-Ogievskiy
29.01.2019 16:17, Kevin Wolf wrote: > Am 29.01.2019 um 13:50 hat Vladimir Sementsov-Ogievskiy geschrieben: >> 29.01.2019 15:38, Kevin Wolf wrote: >>> Am 29.01.2019 um 13:04 hat Andrey Shinkevich geschrieben: >> >> diff --git a/block/qapi.c b/block/qapi.c >> index c66f949..0fde98c 100644

Re: [Qemu-devel] [PATCH 06/11] target/arm: Reset btype for direct branches and syscalls

2019-01-29 Thread Richard Henderson
On 1/29/19 1:57 AM, Peter Maydell wrote: >>> The advantage of picking the other choice (SPSR_ELx.BTYPE == >>> PSTATE.BTYPE) is that it means that the behaviour is identical >>> for all exceptions (async or sync of any type) and we don't >>> do the work of clearing the BTYPE field (which will happen

Re: [Qemu-devel] [PULL v2 00/23] target-arm queue

2019-01-29 Thread Peter Maydell
t; Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20190128' into > staging (2019-01-28 16:26:47 +) > > are available in the Git repository at: > > https://git.linaro.org/people/pmaydell/qemu-arm.git > tags/pull-target-arm-20190129 > > for

Re: [Qemu-devel] [PATCH v11 3/3] docs: Added MAP_SYNC documentation

2019-01-29 Thread Michael S. Tsirkin
On Tue, Jan 29, 2019 at 10:49:18PM +0800, Zhang, Yi wrote: > From: Zhang Yi > > Signed-off-by: Zhang Yi > --- > docs/nvdimm.txt | 29 - > qemu-options.hx | 4 > 2 files changed, 32 insertions(+), 1 deletion(-) > > diff --git a/docs/nvdimm.txt b/docs/nvdimm.txt

[Qemu-devel] [PATCH 1/2] block: enhance QEMUIOVector structure

2019-01-29 Thread Vladimir Sementsov-Ogievskiy
Add a possibility of embedded iovec, for cases when we need only one local iov. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/qemu/iov.h | 41 - 1 file changed, 40 insertions(+), 1 deletion(-) diff --git a/include/qemu/iov.h b/include/qemu/iov.h

[Qemu-devel] [PATCH v3 5/5] hw/display/milkymist-tmu2: Move inlined code from header to source

2019-01-29 Thread Philippe Mathieu-Daudé
Move the complexity of milkymist_tmu2_create() into the source file. Doing so we avoid to include the X11/OpenGL headers in all LM32 devices, and we also avoid the duplicate declaration of glx_fbconfig_attr[] (it is already declared in hw/display/milkymist-tmu2.c). Since TYPE_MILKYMIST_TMU2 is now

Re: [Qemu-devel] [PATCH] hw/arm/nrf51_soc: set object owner in memory_region_init_ram

2019-01-29 Thread Peter Maydell
On Fri, 25 Jan 2019 at 15:56, kumar sourav wrote: > > set object owner in memory_region_init_ram() instead > of NULL. > > Signed-off-by: kumar sourav > --- > hw/arm/nrf51_soc.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/hw/arm/nrf51_soc.c b/hw/arm/nrf51_soc.c > in

Re: [Qemu-devel] building rst docs with sphinx

2019-01-29 Thread Cole Robinson
On 1/28/19 9:18 PM, Stefan Hajnoczi wrote: On Thu, Jan 24, 2019 at 06:56:09PM +, Peter Maydell wrote: (1) configure: My thought is that we should just make sphinx-build a requirement for the existing --enable-docs switch (as texinfo and pod2man are currently). The disadvantage is that we won

Re: [Qemu-devel] [PATCH v3 1/2] s390x/pci: Introduce unplug requests and split unplug handler

2019-01-29 Thread David Hildenbrand
On 29.01.19 14:31, Pierre Morel wrote: > On 21/01/2019 14:42, David Hildenbrand wrote: >> PCI on s390x is really weird and how it was modeled in QEMU might not have >> been the right choice. Anyhow, right now it is the case that: >> - Hotplugging a PCI device will silently create a zPCI device >>

[Qemu-devel] [PATCH v3 0/5] sdl: Let it be optional (in particular, on OpenBSD)

2019-01-29 Thread Philippe Mathieu-Daudé
since v2: - move LM32 specific hardware out of common-obj to bypass make rules limitations - use "WARNING" string in configure v1 was too simple to work, so here we go again. I hit a problem with the Milkymist TMU device when disabling SDL, so I fixed it and added another patch in this series whic

[Qemu-devel] [PATCH v3 3/5] hw/display/milkymist-tmu2: Explicit the dependency to both X11 / OpenGL

2019-01-29 Thread Philippe Mathieu-Daudé
The TMU device requires both X11 and OpenGL. Signed-off-by: Philippe Mathieu-Daudé --- default-configs/lm32-softmmu.mak | 2 +- hw/display/Makefile.objs | 4 ++-- hw/lm32/milkymist-hw.h | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/default-configs/lm3

Re: [Qemu-devel] [PATCH RFC 4/8] i386/kvm: Implement 'hv-all' pass-through mode

2019-01-29 Thread Vitaly Kuznetsov
Eduardo Habkost writes: > > If libvirt is involved, it's much simpler and safer to use > something like , which generates a > migration-safe CPU configuration based on the current host. Live > migration support with "-cpu host" is only useful for experiments > and carefully controlled environmen

[Qemu-devel] [PATCH v3 1/5] hw/lm32: Move LM32 specific hardware out of common-obj list

2019-01-29 Thread Philippe Mathieu-Daudé
The LM32 specific hardware is only used by the LM32 target, it is pointless to compile those objects in other targets. Signed-off-by: Philippe Mathieu-Daudé --- hw/audio/Makefile.objs | 2 +- hw/char/Makefile.objs| 6 +++--- hw/display/Makefile.objs | 4 ++-- hw/intc/Makefile.objs| 2 +

[Qemu-devel] [PATCH v3 4/5] configure: Let SDL support be optional on OpenBSD

2019-01-29 Thread Philippe Mathieu-Daudé
Currently if we try to build QEMU on OpenBSD with SDL disabled, we get: $ ./configure --cc=x86_64-unknown-openbsd6.1-gcc-4.9.4 --python=python2.7 --disable-sdl ERROR: sdl not found or disabled, can not use sdl audio driver Since SDL is not a requirement for OpenBSD, let it be optional. If i

Re: [Qemu-devel] [PATCH v5 2/2] hw/arm: add Arm SBSA reference machine, devices part

2019-01-29 Thread Peter Maydell
On Mon, 28 Jan 2019 at 09:46, Hongbo Zhang wrote: > > On Tue, 22 Jan 2019 at 19:49, Peter Maydell wrote: > > > > On Fri, 7 Dec 2018 at 09:08, Hongbo Zhang wrote: > > > +static void sbsa_ref_machine_done(Notifier *notifier, void *data) > > > +{ > > > +VirtMachineState *vms = container_of(noti

[Qemu-devel] [PATCH 0/2] block: local qiov helper: part I

2019-01-29 Thread Vladimir Sementsov-Ogievskiy
Hi all! Here is a proposal for a new simple helper for a very often patter around qemu_iovec_init_external, when we need simple qiov with only one iov, initialized from external buffer. Here only block/io.c updated to use new helper, I'll update other things on top of this separately. Vladimir S

Re: [Qemu-devel] [PATCH v9 1/2] qemu-img info lists bitmap directory entries

2019-01-29 Thread Kevin Wolf
Am 29.01.2019 um 16:29 hat Vladimir Sementsov-Ogievskiy geschrieben: > 29.01.2019 17:35, Vladimir Sementsov-Ogievskiy wrote: > > 29.01.2019 17:23, Kevin Wolf wrote: > >> Am 29.01.2019 um 15:06 hat Vladimir Sementsov-Ogievskiy geschrieben: > >>> 29.01.2019 16:17, Kevin Wolf wrote: > Am 29.01.20

Re: [Qemu-devel] [PATCH] iothread: fix iothread hang when stop too soon

2019-01-29 Thread Thomas Huth
On 2019-01-29 06:14, Peter Xu wrote: > Lukas reported an hard to reproduce QMP iothread hang on s390 that > QEMU might hang at pthread_join() of the QMP monitor iothread before > quitting: > > Thread 1 > #0 0x03ffad10932c in pthread_join > #1 0x000109e95750 in qemu_thread_join >

Re: [Qemu-devel] [PATCH v9 1/2] qemu-img info lists bitmap directory entries

2019-01-29 Thread Vladimir Sementsov-Ogievskiy
29.01.2019 17:35, Vladimir Sementsov-Ogievskiy wrote: > 29.01.2019 17:23, Kevin Wolf wrote: >> Am 29.01.2019 um 15:06 hat Vladimir Sementsov-Ogievskiy geschrieben: >>> 29.01.2019 16:17, Kevin Wolf wrote: Am 29.01.2019 um 13:50 hat Vladimir Sementsov-Ogievskiy geschrieben: > 29.01.2019 15:3

Re: [Qemu-devel] [PATCH RFC 4/8] i386/kvm: Implement 'hv-all' pass-through mode

2019-01-29 Thread Daniel P . Berrangé
On Mon, Jan 28, 2019 at 06:22:30PM +, Dr. David Alan Gilbert wrote: > * Vitaly Kuznetsov (vkuzn...@redhat.com) wrote: > > Roman Kagan writes: > > > > > On Fri, Jan 25, 2019 at 02:46:42PM +0100, Vitaly Kuznetsov wrote: > > >> Roman Kagan writes: > > >> > > >> > On Fri, Jan 25, 2019 at 12:41:

Re: [Qemu-devel] [PATCH] exec.c: Don't reallocate IOMMUNotifiers that are in use

2019-01-29 Thread Richard Henderson
On 1/28/19 9:42 AM, Peter Maydell wrote: > The tcg_register_iommu_notifier() code has a GArray of > TCGIOMMUNotifier structs which it has registered by passing > memory_region_register_iommu_notifier() a pointer to the embedded > IOMMUNotifier field. Unfortunately, if we need to enlarge the > array

Re: [Qemu-devel] [PATCH] target/s390x: Fix LGPL version in the file header comments

2019-01-29 Thread Philippe Mathieu-Daudé
On 1/29/19 2:51 PM, Cornelia Huck wrote: > On Tue, 29 Jan 2019 14:37:47 +0100 > Thomas Huth wrote: > >> It's either "GNU *Library* General Public License version 2" or >> "GNU Lesser General Public License version *2.1*", but there was >> no "version 2.0" of the "Lesser" license. So assume that v

Re: [Qemu-devel] [PATCH v4 01/14] qapi: qapi for audio backends

2019-01-29 Thread Markus Armbruster
"Kővágó, Zoltán" writes: > This patch adds structures into qapi to replace the existing > configuration structures used by audio backends currently. This qapi > will be the base of the -audiodev command line parameter (that replaces > the old environment variables based config). > > This is not a

Re: [Qemu-devel] [PATCH v9 1/2] qemu-img info lists bitmap directory entries

2019-01-29 Thread Vladimir Sementsov-Ogievskiy
29.01.2019 17:23, Kevin Wolf wrote: > Am 29.01.2019 um 15:06 hat Vladimir Sementsov-Ogievskiy geschrieben: >> 29.01.2019 16:17, Kevin Wolf wrote: >>> Am 29.01.2019 um 13:50 hat Vladimir Sementsov-Ogievskiy geschrieben: 29.01.2019 15:38, Kevin Wolf wrote: > Am 29.01.2019 um 13:04 hat Andrey

Re: [Qemu-devel] [PATCH 3/3] scsi-disk: Deprecate device_id fallback to BlockBackend name

2019-01-29 Thread Daniel P . Berrangé
On Fri, Jan 25, 2019 at 06:46:53PM +0100, Kevin Wolf wrote: > We should never have exposed BlockBackend names to the guest, it's a > host detail. Deprecate this behaviour. Users who need to maintain the > guest ABI can explicitly set the value with the device_id property. I don't think we've depre

Re: [Qemu-devel] [PATCH 2/2] target/arm/translate-a64: Fix mishandling of size in FCMLA decode

2019-01-29 Thread Laurent Desnogues
On Tue, Jan 29, 2019 at 3:04 PM Peter Maydell wrote: > > In disas_simd_indexed(), for the case of "complex fp", each indexable > element is a complex pair, so the total size is twice that indicated > in the 'size' field in the encoding. We were trying to do this > "double the size" operation with

Re: [Qemu-devel] [PATCH v4 04/14] audio: -audiodev command line option basic implementation

2019-01-29 Thread Markus Armbruster
"Kővágó, Zoltán" writes: > Audio drivers now get an Audiodev * as config paramters, instead of the > global audio_option structs. There is some code in audio/audio_legacy.c > that converts the old environment variables to audiodev options (this > way backends do not have to worry about legacy op

Re: [Qemu-devel] [PATCH v9 1/2] qemu-img info lists bitmap directory entries

2019-01-29 Thread Kevin Wolf
Am 29.01.2019 um 15:06 hat Vladimir Sementsov-Ogievskiy geschrieben: > 29.01.2019 16:17, Kevin Wolf wrote: > > Am 29.01.2019 um 13:50 hat Vladimir Sementsov-Ogievskiy geschrieben: > >> 29.01.2019 15:38, Kevin Wolf wrote: > >>> Am 29.01.2019 um 13:04 hat Andrey Shinkevich geschrieben: > >> > >>>

Re: [Qemu-devel] [PATCH 0/2] target/arm: Fix FCMLA decoding errors

2019-01-29 Thread Richard Henderson
On 1/29/19 6:04 AM, Peter Maydell wrote: > Peter Maydell (2): > target/arm/translate-a64: Fix FCMLA decoding error > target/arm/translate-a64: Fix mishandling of size in FCMLA decode > > target/arm/translate-a64.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Richa

Re: [Qemu-devel] [PATCH v2 0/3] Trivial cleanup in hw/acpi

2019-01-29 Thread Michael S. Tsirkin
On Tue, Jan 29, 2019 at 03:32:54PM +, Wei Yang wrote: > On Tue, Jan 29, 2019 at 09:43:20AM +0100, Laurent Vivier wrote: > >On 29/01/2019 09:23, Philippe Mathieu-Daudé wrote: > >> On 1/29/19 9:04 AM, Wei Yang wrote: > >>> On Tue, Jan 29, 2019 at 07:56:54AM +0100, Philippe Mathieu-Daudé wrote: >

[Qemu-devel] [PATCH v3 2/5] configure: LM32 Milkymist Texture Mapping Unit (tmu2) also depends of X11

2019-01-29 Thread Philippe Mathieu-Daudé
Commit 5f9b1e35060b8 remove the dependency between OpenGL and X11. However the milkymist-tmu2 device do require X11. When using SDL, the configure script sets need_x11=yes, so the X11 flags are populated to the makefiles. When building without SDL, X11 is not pulled and populated, leading to a link

Re: [Qemu-devel] [PATCH RFC 4/8] i386/kvm: Implement 'hv-all' pass-through mode

2019-01-29 Thread Dr. David Alan Gilbert
* Vitaly Kuznetsov (vkuzn...@redhat.com) wrote: > "Dr. David Alan Gilbert" writes: > > > I'm not sure what the equivalent bear traps are in the Hyper-V world, > > but I'd be surprised if there weren't any; for example what happens > > when someone upgrades one of their hosts to some minor version

Re: [Qemu-devel] [PATCH v2 0/3] Trivial cleanup in hw/acpi

2019-01-29 Thread Wei Yang
On Tue, Jan 29, 2019 at 09:43:20AM +0100, Laurent Vivier wrote: >On 29/01/2019 09:23, Philippe Mathieu-Daudé wrote: >> On 1/29/19 9:04 AM, Wei Yang wrote: >>> On Tue, Jan 29, 2019 at 07:56:54AM +0100, Philippe Mathieu-Daudé wrote: Hi Wei, On 1/29/19 1:08 AM, Wei Yang wrote: > The

[Qemu-devel] [PATCH] target/arm: Enable API, APK bits in SCR, HCR

2019-01-29 Thread Richard Henderson
These bits become writable with the ARMv8.3-PAuth extension. Signed-off-by: Richard Henderson --- target/arm/helper.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/target/arm/helper.c b/target/arm/helper.c index 70277222da..a1a2ac7d06 100644 --- a/target/arm/helper.c +++ b/target/arm

Re: [Qemu-devel] [PATCH v5 1/6] vhost-user: Support transferring inflight buffer between qemu and backend

2019-01-29 Thread Michael S. Tsirkin
On Tue, Jan 29, 2019 at 02:15:35PM +0800, Yongji Xie wrote: > On Tue, 29 Jan 2019 at 12:26, Michael S. Tsirkin wrote: > > > > On Tue, Jan 29, 2019 at 12:11:55PM +0800, Stefan Hajnoczi wrote: > > > On Tue, Jan 22, 2019 at 04:31:47PM +0800, elohi...@gmail.com wrote: > > > > +typedef struct DescState

Re: [Qemu-devel] [PATCH v3] s390x: remove direct reference to mem_path global form s390x code

2019-01-29 Thread Igor Mammedov
On Tue, 29 Jan 2019 13:39:31 +0100 Cornelia Huck wrote: > On Mon, 28 Jan 2019 16:32:38 +0100 > Igor Mammedov wrote: > > In the subject: s/form/from/ > > > I plan to deprecate -mem-path option and replace it with memory-backend, > > for that it's necessary to get rid of mem_path global variable

Re: [Qemu-devel] [qemu-s390x] [PATCH v3 2/2] s390x/pci: Unplug remaining devices on pcihost reset

2019-01-29 Thread David Hildenbrand
On 29.01.19 14:50, Pierre Morel wrote: > On 29/01/2019 11:24, David Hildenbrand wrote: > I'm wondering what the architecture says regarding those events -- can > someone with access to the documentation comment? Ping. Any comments from the IBM folks? > > Hi, > > Sorry to have wa

Re: [Qemu-devel] [PATCH v2 2/5] vfio-ccw: concurrent I/O handling

2019-01-29 Thread Eric Farman
On 01/29/2019 05:20 AM, Cornelia Huck wrote: On Mon, 28 Jan 2019 16:48:10 -0500 Eric Farman wrote: On 01/28/2019 02:15 PM, Halil Pasic wrote: On Mon, 28 Jan 2019 18:09:48 +0100 Cornelia Huck wrote: I guess if the ssch() returns with non cc == 0 the CP_PENDING ---IRQ---> IDLE transitio

Re: [Qemu-devel] [PATCH 04/11] target/arm: Record the GP bit for a page in MemTxAttrs

2019-01-29 Thread Richard Henderson
On 1/29/19 1:55 AM, Peter Maydell wrote: >> As written above, this will execute more than once. > > I don't see how -- all the code paths forward from > "guarded |= extract64(descriptor, 50, 1);" reach a > "break" statement that terminates the loop, don't they? You're right. I've misread the sur

Re: [Qemu-devel] [PATCH] iothread: fix iothread hang when stop too soon

2019-01-29 Thread Markus Armbruster
Marc-André (cc'ed) recently fixed a deadlock (commit 34f1f3e06d8 "monitor: avoid potential dead-lock when cleaning up"). Looks like we got more. Peter Xu writes: > Lukas reported an hard to reproduce QMP iothread hang on s390 that > QEMU might hang at pthread_join() of the QMP monitor iothread

Re: [Qemu-devel] [PATCH RFC 4/8] i386/kvm: Implement 'hv-all' pass-through mode

2019-01-29 Thread Vitaly Kuznetsov
"Dr. David Alan Gilbert" writes: > I'm not sure what the equivalent bear traps are in the Hyper-V world, > but I'd be surprised if there weren't any; for example what happens > when someone upgrades one of their hosts to some minor version that > adds/removes a feature? Here we're talking about

Re: [Qemu-devel] [PATCH 1/2] target/arm/translate-a64: Fix FCMLA decoding error

2019-01-29 Thread Laurent Desnogues
On Tue, Jan 29, 2019 at 3:04 PM Peter Maydell wrote: > > The FCMLA (by element) instruction exists in the > "vector x indexed element" encoding group, but not in > the "scalar x indexed element" group. Correctly UNDEF > the unallocated encodings. > > Reported-by: Laurent Desnogues > Signed-off-by

[Qemu-devel] [PATCH 2/2] block/io: use qemu_iovec_init_buf

2019-01-29 Thread Vladimir Sementsov-Ogievskiy
Use new qemu_iovec_init_buf() instead of qemu_iovec_init_external( ... , 1), which simplifies the code. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/io.c | 89 -- 1 file changed, 20 insertions(+), 69 deletions(-) diff --git a/block/io

Re: [Qemu-devel] AMD SEV's /dev/sev permissions and probing QEMU for capabilities

2019-01-29 Thread Erik Skultety
On Wed, Jan 23, 2019 at 03:02:28PM +, Singh, Brijesh wrote: > > > On 1/23/19 7:36 AM, Daniel P. Berrangé wrote: > > On Wed, Jan 23, 2019 at 02:33:01PM +0100, Erik Skultety wrote: > >> On Wed, Jan 23, 2019 at 01:24:13PM +, Daniel P. Berrangé wrote: > >>> On Wed, Jan 23, 2019 at 02:22:12PM +0

Re: [Qemu-devel] [PATCH v5 07/18] kvm: add kvm_arm_get_max_vm_phys_shift

2019-01-29 Thread Jia He
Hi Eric On 2019/1/23 18:14, Eric Auger wrote: Add the kvm_arm_get_max_vm_phys_shift() helper that returns the log of the maximum IPA size supported by KVM. This capability needs to be known to create the VM with a specific IPA max size (kvm_type passed along KVM_CREATE_VM ioctl. Signed-off-by:

Re: [Qemu-devel] [PATCH 1/3] scsi-disk: Don't use empty string as device id

2019-01-29 Thread Markus Armbruster
Kevin Wolf writes: > scsi-disk includes in the Device Identification VPD page, depending on > configuration amongst others, a vendor specific designator that consists > either of the serial number if given or the BlockBackend name (which is > a host detail that better shouldn't have been leaked t

Re: [Qemu-devel] [qemu-s390x] [PATCH 00/15] s390: vfio-ccw dasd ipl support

2019-01-29 Thread Jason J. Herne
On 1/29/19 8:29 AM, Jason J. Herne wrote: This is to support booting from vfio-ccw dasd devices. We basically implement the real hardware ipl procedure. This allows for booting Linux guests on vfio-ccw devices. vfio-ccw's channel program prefetch algorithm complicates ipl because most ipl channe

Re: [Qemu-devel] [qemu-s390x] [PATCH v3 2/2] s390x/pci: Unplug remaining devices on pcihost reset

2019-01-29 Thread Pierre Morel
On 29/01/2019 16:11, David Hildenbrand wrote: On 29.01.19 14:50, Pierre Morel wrote: On 29/01/2019 11:24, David Hildenbrand wrote: I'm wondering what the architecture says regarding those events -- can someone with access to the documentation comment? Ping. Any comments from the IBM folks?

Re: [Qemu-devel] [PATCH v3 1/2] s390x/pci: Introduce unplug requests and split unplug handler

2019-01-29 Thread Pierre Morel
On 29/01/2019 16:14, David Hildenbrand wrote: On 29.01.19 14:31, Pierre Morel wrote: On 21/01/2019 14:42, David Hildenbrand wrote: PCI on s390x is really weird and how it was modeled in QEMU might not have been the right choice. Anyhow, right now it is the case that: - Hotplugging a PCI device

Re: [Qemu-devel] [PATCH v2 1/2] tests.acceptance: adds multi vm capability for acceptance tests

2019-01-29 Thread Wainer dos Santos Moschetta
On 01/29/2019 09:30 AM, Caio Carrara wrote: Hi, Wainer. On Mon, Jan 28, 2019 at 05:42:24PM -0200, Wainer dos Santos Moschetta wrote: On 01/28/2019 03:47 PM, Caio Carrara wrote: This change adds the possibility to write acceptance tests with multi virtual machine support. It's done keeping th

[Qemu-devel] [PATCH v2 00/18] OpenBSD: Enable qtesting

2019-01-29 Thread Philippe Mathieu-Daudé
Various fixes I encountered while trying to run QEMU test suite on OpenBSD. Now than various tests are disabled, we can run the qtests again. (Conversely, if we can not test a feature, we should deprecate/remove it.) Since v1: - various qemu-block fixes and notes. Some patches care be applied by

[Qemu-devel] [PATCH v2 01/18] tests/vm: Be verbose while extracting compressed images

2019-01-29 Thread Philippe Mathieu-Daudé
Depending of the host hardware, copying and extracting VM images can take up to few minutes. Add verbosity to avoid the user to worry about VMs hanging. Signed-off-by: Philippe Mathieu-Daudé --- tests/vm/centos | 3 ++- tests/vm/freebsd | 3 ++- tests/vm/netbsd | 3 ++- tests/vm/openbsd | 3 ++

[Qemu-devel] [PATCH v2 04/18] ahci-test: Add dependency to qemu-img tool

2019-01-29 Thread Philippe Mathieu-Daudé
Since the ahci-test uses qemu-img, add a dependency to build it before using it. This fixes: $ gmake check-qtest V=1 QTEST_QEMU_BINARY=x86_64-softmmu/qemu-system-x86_64 QTEST_QEMU_IMG=qemu-img tests/ahci-test Failed to execute child process "/tmp/qemu-test.19tMRF/qemu-img" (No such file or

[Qemu-devel] [PATCH v2 02/18] configure: Disable W^X on OpenBSD

2019-01-29 Thread Philippe Mathieu-Daudé
Since OpenBSD 6.0 [1], W^X is enforced by default [2]. TCG requires WX access. Disable W^X if it is available. This fixes: # lm32-softmmu/qemu-system-lm32 Could not allocate dynamic translator buffer # sysctl kern.wxabort=1 kern.wxabort: 0 -> 1 # lm32-softmmu/qemu-system-lm32 mmap: No

[Qemu-devel] [PATCH v2 05/18] qemu-iotests: Add dependency to qemu-nbd tool

2019-01-29 Thread Philippe Mathieu-Daudé
Since a9660664fde, some iotests use qemu-nbd. Add a dependency to build it before using it. This fixes: $ gmake check-block CHK version_gen.h GEN qemu-img-cmds.h CC qemu-img.o LINKqemu-img CC qemu-io.o LINKqemu-io tests/qemu-iotests-quick.sh

[Qemu-devel] [PATCH v2 08/18] tests/bios-tables: Improve portability by searching bash in the $PATH

2019-01-29 Thread Philippe Mathieu-Daudé
Bash is not always installed as /bin/bash. In particular on OpenBSD, the package installs it in /usr/local/bin. Use the 'env' shebang to search bash in the $PATH. Signed-off-by: Philippe Mathieu-Daudé --- tests/data/acpi/rebuild-expected-aml.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(

[Qemu-devel] [RFC PATCH v2 10/18] qemu-iotests: Ensure GNU sed is used

2019-01-29 Thread Philippe Mathieu-Daudé
Various sed regexp from common.filter use sed GNU extensions. Instead of spending time to write these regex to be POSIX compliant, verify the GNU sed is available and use it. Signed-off-by: Philippe Mathieu-Daudé --- I think the test isn't well placed in common.filter and should be in common.rc,

[Qemu-devel] [PATCH v2 09/18] tests/vm/openbsd: Install Bash from the ports

2019-01-29 Thread Philippe Mathieu-Daudé
Various iotests scripts (run via 'make check-block') use bash specific extentions. OpenBSD comes with the Korn shell as default. Install bash to be able to run those tests. Signed-off-by: Philippe Mathieu-Daudé --- tests/vm/openbsd | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/vm

[Qemu-devel] [PATCH v2 03/18] tests/vm/openbsd: Disable the W^X protection on the build partition

2019-01-29 Thread Philippe Mathieu-Daudé
Since OpenBSD 6.0 [1], W^X is enforced by default [2]. TCG requires WX access, and QEMU binaries are now built with the WX flag to disable the protection. However, WX allowed binaries need to be run on a WX allowed partition. To be able to run the QEMU test suite on the VM, mount the partition wher

[Qemu-devel] [RFC PATCH v2 18/18] iotests: Disable 236 and 238 on OpenBSD

2019-01-29 Thread Philippe Mathieu-Daudé
These tests explode on OpenBSD: $ gmake check-block [...] 238[17:16:09] [17:16:09] [failed, exit status 1] - output mismatch (see 238.out.bad) --- /tmp/qemu-test.VKNS07/tests/qemu-iotests/238.outTue Jan 29 17:09:03 2019 +++ /tmp/qemu-test.VKNS07/tests/qemu-iotests/2

[Qemu-devel] [RFC PATCH v2 13/18] oslib-posix: Ignore fcntl("/dev/null", F_SETFL, O_NONBLOCK) failure

2019-01-29 Thread Philippe Mathieu-Daudé
Previous to OpenBSD 6.3 [1], fcntl(F_SETFL) is not permitted on memory devices. Trying this call sets errno to ENODEV ("not a memory device"): 19 ENODEV Operation not supported by device. An attempt was made to apply an inappropriate function to a device, for example, trying to read a wr

[Qemu-devel] [PATCH v2 07/18] tests/multiboot: Improve portability by searching bash in the $PATH

2019-01-29 Thread Philippe Mathieu-Daudé
Bash is not always installed as /bin/bash. In particular on OpenBSD, the package installs it in /usr/local/bin. Use the 'env' shebang to search bash in the $PATH. Signed-off-by: Philippe Mathieu-Daudé --- tests/multiboot/run_test.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --g

Re: [Qemu-devel] [PATCH v2 02/18] configure: Disable W^X on OpenBSD

2019-01-29 Thread Philippe Mathieu-Daudé
On 1/29/19 6:53 PM, Philippe Mathieu-Daudé wrote: > Since OpenBSD 6.0 [1], W^X is enforced by default [2]. > TCG requires WX access. Disable W^X if it is available. > This fixes: > > # lm32-softmmu/qemu-system-lm32 > Could not allocate dynamic translator buffer > > # sysctl kern.wxabort=1 >

[Qemu-devel] [RFC PATCH v2 16/18] iotests: Disable 208 on OpenBSD

2019-01-29 Thread Philippe Mathieu-Daudé
This test explodes on OpenBSD: $ gmake check-block [...] 208[14:46:03] [14:46:03] [failed, exit status 1] - output mismatch (see 208.out.bad) --- /tmp/qemu-test.9cUFe0/tests/qemu-iotests/208.outTue Jan 29 13:33:43 2019 +++ /tmp/qemu-test.9cUFe0/tests/qemu-iotests/20

[Qemu-devel] [PATCH v2 06/18] qemu-iotests: Improve portability by searching bash in the $PATH

2019-01-29 Thread Philippe Mathieu-Daudé
Bash is not always installed as /bin/bash. In particular on OpenBSD, the package installs it in /usr/local/bin. Use the 'env' shebang to search bash in the $PATH. Patch created mechanically by running: $ git grep -lE '#! ?/bin/bash' -- tests/qemu-iotests | \ while read f; do \ sed -i

[Qemu-devel] [RFC PATCH v2 15/18] iotests: Let verify_platform() check for unsupported platforms

2019-01-29 Thread Philippe Mathieu-Daudé
Instead of checking for a supported platforms, it might be useful to test for the opposite. Signed-off-by: Philippe Mathieu-Daudé --- tests/qemu-iotests/iotests.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py

[Qemu-devel] [PATCH v2 11/18] tests/vm/openbsd: Install GNU sed from the ports

2019-01-29 Thread Philippe Mathieu-Daudé
Various iotests scripts (run via 'make check-block') require a GNU sed to use the (non-POSIX) GNU extensions. Install GNU sed from the ports to be able to run those tests. Signed-off-by: Philippe Mathieu-Daudé --- tests/vm/openbsd | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/vm/op

[Qemu-devel] [RFC PATCH v2 17/18] iotests: Disable 209 on OpenBSD

2019-01-29 Thread Philippe Mathieu-Daudé
This test simply hangs with no information on OpenBSD. Signed-off-by: Philippe Mathieu-Daudé --- tests/qemu-iotests/209 | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/qemu-iotests/209 b/tests/qemu-iotests/209 index 259e991ec6..7eb41e4363 100755 --- a/tests/qemu-iotests/209 +++ b/tests

Re: [Qemu-devel] [PATCH v2 07/18] tests/multiboot: Improve portability by searching bash in the $PATH

2019-01-29 Thread Kamil Rytarowski
On 29.01.2019 18:53, Philippe Mathieu-Daudé wrote: > Bash is not always installed as /bin/bash. In particular on OpenBSD, > the package installs it in /usr/local/bin. > Use the 'env' shebang to search bash in the $PATH. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Kamil Rytarowski >

[Qemu-devel] [RFC PATCH v2 12/18] test-iov: Disable iov/io test on OpenBSD

2019-01-29 Thread Philippe Mathieu-Daudé
The iov/io test hangs on OpenBSD. Disable it. Signed-off-by: Philippe Mathieu-Daudé --- tests/test-iov.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/tests/test-iov.c b/tests/test-iov.c index 458ca25099..9288b7b862 100644 --- a/tests/test-iov.c +++ b/tests/test-iov

Re: [Qemu-devel] [PATCH v2 08/18] tests/bios-tables: Improve portability by searching bash in the $PATH

2019-01-29 Thread Kamil Rytarowski
On 29.01.2019 18:53, Philippe Mathieu-Daudé wrote: > Bash is not always installed as /bin/bash. In particular on OpenBSD, > the package installs it in /usr/local/bin. > Use the 'env' shebang to search bash in the $PATH. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Kamil Rytarowski >

[Qemu-devel] [PATCH v2 14/18] tests/vm: Run tests on OpenBSD

2019-01-29 Thread Philippe Mathieu-Daudé
Now than failing tests are commented out, let's reenable the testing of this OS. Signed-off-by: Philippe Mathieu-Daudé --- tests/vm/openbsd | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/tests/vm/openbsd b/tests/vm/openbsd index 7c456e9706..ff6d5fa549 100755 --- a/tests/v

Re: [Qemu-devel] macOS build error after ddac19f534 (virtio: split virtio 9p bits from virtio-pci)

2019-01-29 Thread Philippe Mathieu-Daudé
On 1/29/19 11:58 AM, BALATON Zoltan wrote: > On Tue, 29 Jan 2019, BALATON Zoltan wrote: >> On Tue, 29 Jan 2019, Philippe Mathieu-Daudé wrote: >>> On 1/29/19 2:20 AM, BALATON Zoltan wrote: Hello, I'm getting error building on macOS after commit ddac19f534: ? CC? aarch64-

Re: [Qemu-devel] [PATCH v6 2/2] log: Make glib logging go through QEMU

2019-01-29 Thread Markus Armbruster
Christophe Fergeau writes: > This commit adds a qemu_init_logging() helper which calls > g_log_set_default_handler() so that glib logs (g_log, g_warning, ...) > are handled similarly to other QEMU logs. This means they will get a > timestamp if timestamps are enabled, and they will go through the

Re: [Qemu-devel] [qemu-s390x] [PATCH v3 2/2] s390x/pci: Unplug remaining devices on pcihost reset

2019-01-29 Thread David Hildenbrand
On 29.01.19 17:50, Pierre Morel wrote: > On 29/01/2019 16:11, David Hildenbrand wrote: >> On 29.01.19 14:50, Pierre Morel wrote: >>> On 29/01/2019 11:24, David Hildenbrand wrote: >>> I'm wondering what the architecture says regarding those events -- can >>> someone with access to the docume

Re: [Qemu-devel] [qemu-s390x] [PATCH v3 2/2] s390x/pci: Unplug remaining devices on pcihost reset

2019-01-29 Thread Cornelia Huck
On Tue, 29 Jan 2019 19:20:55 +0100 David Hildenbrand wrote: > Conny could pick up patch #1 once you get an ACK. I would send more > patches to drop the timer and rework this patch. Sure, will do.

Re: [Qemu-devel] AMD SEV's /dev/sev permissions and probing QEMU for capabilities

2019-01-29 Thread Daniel P . Berrangé
On Tue, Jan 29, 2019 at 05:15:42PM +0100, Erik Skultety wrote: > On Wed, Jan 23, 2019 at 03:02:28PM +, Singh, Brijesh wrote: > > > > > > On 1/23/19 7:36 AM, Daniel P. Berrangé wrote: > > > On Wed, Jan 23, 2019 at 02:33:01PM +0100, Erik Skultety wrote: > > >> On Wed, Jan 23, 2019 at 01:24:13PM +

Re: [Qemu-devel] [qemu-s390x] [PATCH v3 2/2] s390x/pci: Unplug remaining devices on pcihost reset

2019-01-29 Thread Collin Walling
On 1/29/19 1:20 PM, David Hildenbrand wrote: > On 29.01.19 17:50, Pierre Morel wrote: >> On 29/01/2019 16:11, David Hildenbrand wrote: >>> On 29.01.19 14:50, Pierre Morel wrote: On 29/01/2019 11:24, David Hildenbrand wrote: I'm wondering what the architecture says regarding those even

Re: [Qemu-devel] [PATCH] tests/tcg/multiarch/linux-test: Fix error check for shmat

2019-01-29 Thread Richard Henderson
Ping. On 7/8/18 6:49 PM, Richard Henderson wrote: > The error indicator for this syscall is -1, not 0. > > Signed-off-by: Richard Henderson > --- > tests/tcg/multiarch/linux-test.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tests/tcg/multiarch/linux-test.c > b/

Re: [Qemu-devel] [PATCH v2 2/2] Acceptance tests: add simple migration test

2019-01-29 Thread Wainer dos Santos Moschetta
On 01/28/2019 03:47 PM, Caio Carrara wrote: From: Cleber Rosa This is the simplest possible migration test, exercising the multi VM capabilities of the test class. Signed-off-by: Cleber Rosa --- tests/acceptance/migration.py | 45 +++ 1 file changed, 45 in

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 2/8] target/ppc: rework vmrg{l, h}{b, h, w} instructions to use Vsr* macros

2019-01-29 Thread Mark Cave-Ayland
On 27/01/2019 18:07, Richard Henderson wrote: > On 1/27/19 9:45 AM, Mark Cave-Ayland wrote: >>> I would expect the i < n/2 loop to be faster, because the assignments are >>> unconditional. FWIW. >> >> Do you have any idea as to how much faster? Is it something that would show >> up as significant

Re: [Qemu-devel] [PATCH v2 2/5] vfio-ccw: concurrent I/O handling

2019-01-29 Thread Cornelia Huck
On Tue, 29 Jan 2019 09:14:40 -0500 Eric Farman wrote: > On 01/29/2019 05:20 AM, Cornelia Huck wrote: > > On Mon, 28 Jan 2019 16:48:10 -0500 > > Eric Farman wrote: > > > >> On 01/28/2019 02:15 PM, Halil Pasic wrote: > >>> On Mon, 28 Jan 2019 18:09:48 +0100 > >>> Cornelia Huck wrote: > >

[Qemu-devel] [PATCH] target/hppa: fix PSW Q bit behaviour to match hardware

2019-01-29 Thread Sven Schnelle
PA-RISC specification says: "Setting the PSW Q-bit, PSW{28}, to 1 with this instruction, if it was not already 1, is an undefined operation." However, at least HP-UX 10.20 sets the Q bit from 0 to 1 with the SSM instruction. Tested this both on HP9000/712 and HP9000/785/C3750, both machines set the

<    1   2   3   4   >