[Qemu-devel] [PATCH v10 23/24] replay: fix replay shutdown

This patch fixes shutdown of the replay process, which is terminated with the assert when shutdown event is read from the log. replay_finish_event reads new data_kind and therefore the value of data_kind should be preserved to be valid at qemu_system_shutdown_request call. Signed-off-by: Pavel Dov

Re: [Qemu-devel] [Qemu-ppc] [PATCH v5 2/3] ppc: Fix duplicated typedefs to be able to compile with Clang in gnu99 mode

On 1/17/19 8:01 AM, Thomas Huth wrote: > On 2019-01-16 14:29, Cédric Le Goater wrote: >> On 1/16/19 12:47 PM, Thomas Huth wrote: >>> On 2019-01-16 12:43, Cédric Le Goater wrote: On 1/11/19 9:17 AM, Thomas Huth wrote: > When compiling the ppc code with clang and -std=gnu99, there are a

[Qemu-devel] [PATCH v10 24/24] replay: rename step-related variables and functions

This patch renames replay_get_current_step() and related variables to make these names consistent with hmp/qmp commands. Signed-off-by: Pavel Dovgalyuk --- blockdev.c|2 +- include/sysemu/replay.h |2 +- migration/savevm.c|2 +- replay/replay-debugging.c |

Re: [Qemu-devel] [PATCH v2 4/7] softfloat: fallback to __int128 maths for s390x and others

Richard Henderson writes: > On 1/17/19 7:23 AM, Alex Bennée wrote: >> Apparently some versions of clang can't handle inline assembly with >> __int128 parameters, especially on s390. Instead of hand-coding the >> s390 divide provide a generic fallback for anything that provides >> __int128 capab

Re: [Qemu-devel] [PATCH v3 18/19] nbd/client: Work around 3.0 bug for listing meta contexts

17.01.2019 6:21, Eric Blake wrote: > On 1/16/19 9:43 AM, Vladimir Sementsov-Ogievskiy wrote: > >>> @@ -839,9 +842,25 @@ static int nbd_list_meta_contexts(QIOChannel *ioc, >>> >>>ret = nbd_receive_one_meta_context(ioc, >>> NBD_OPT_LIST_META_CONTEXT, >>>

Re: [Qemu-devel] [PATCH v3 0/5] pvh: add new PVH option rom

Hi Paolo, On Wed, Jan 16, 2019 at 10:17:15PM +0100, Paolo Bonzini wrote: > On 16/01/19 19:31, Paolo Bonzini wrote: > > > > I get this: > > > > CC optionrom/pvh_main.o > > /tmp/ccoel69H.s: Assembler messages: > > /tmp/ccoel69H.s:171: Error: attempt to move .org backwards > > > > when appl

[Qemu-devel] [PATCH 2/4] ppc/pnv: introduce a CPU machine_data

Include the interrupt presenter under the machine_data as we plan to remove it from under PowerPCCPU Signed-off-by: Cédric Le Goater --- include/hw/ppc/pnv_core.h | 9 + hw/ppc/pnv.c | 7 --- hw/ppc/pnv_core.c | 12 +++- 3 files changed, 24 insertions(+

Re: [Qemu-devel] [PATCH 1/4] xive: add a get_tctx() method to the XiveRouter

On Thu, 17 Jan 2019 08:53:24 +0100 Cédric Le Goater wrote: > It provides a mean to retrieve the XiveTCTX of a CPU. This will become > necessary with future changes which move the interrupt presenter > object pointers under the PowerPCCPU machine_data. > > The PowerNV machine has an extra require

Re: [Qemu-devel] [PATCH 2/4] ppc/pnv: introduce a CPU machine_data

On Thu, 17 Jan 2019 08:53:25 +0100 Cédric Le Goater wrote: > Include the interrupt presenter under the machine_data as we plan to > remove it from under PowerPCCPU > > Signed-off-by: Cédric Le Goater > --- Reviewed-by: Greg Kurz > include/hw/ppc/pnv_core.h | 9 + > hw/ppc/pnv.c

Re: [Qemu-devel] [PATCH 3/4] spapr: move the interrupt presenters under machine_data

On Thu, 17 Jan 2019 08:53:26 +0100 Cédric Le Goater wrote: > Next step is to remove them from under the PowerPCCPU > > Signed-off-by: Cédric Le Goater > --- Reviewed-by: Greg Kurz > include/hw/ppc/spapr_cpu_core.h | 2 ++ > hw/intc/spapr_xive.c| 3 ++- > hw/intc/xics_spapr.c

Re: [Qemu-devel] [PATCH 4/4] ppc: remove the interrupt presenters from under PowerPCCPU

On Thu, 17 Jan 2019 08:53:27 +0100 Cédric Le Goater wrote: > Signed-off-by: Cédric Le Goater > --- The patch looks good, but I think it would be even better to apply this before Thomas's -std=c99 patchset. This would allow to get rid of the controversial "ppc: Fix duplicated typedefs to be able

Re: [Qemu-devel] [Xen-devel] [PATCH] hw/block/xen: use proper format string for printing sectors

Andrew Cooper writes: > On 16/01/2019 12:13, Alex Bennée wrote: >> The %lu format string is different depending on the host architecture >> which causes builds like the debian-armhf-cross build to fail. Use the >> correct PRi64 format string. >> >> Signed-off-by: Alex Bennée >> --- >> hw/bloc

Re: [Qemu-devel] [PATCH 4/4] ppc: remove the interrupt presenters from under PowerPCCPU

On 2019-01-17 09:20, Greg Kurz wrote: > On Thu, 17 Jan 2019 08:53:27 +0100 > Cédric Le Goater wrote: > >> Signed-off-by: Cédric Le Goater >> --- > > The patch looks good, but I think it would be even better to apply this before > Thomas's -std=c99 patchset. This would allow to get rid of the co

Re: [Qemu-devel] [PATCH 4/4] ppc: remove the interrupt presenters from under PowerPCCPU

On 1/17/19 9:23 AM, Thomas Huth wrote: > On 2019-01-17 09:20, Greg Kurz wrote: >> On Thu, 17 Jan 2019 08:53:27 +0100 >> Cédric Le Goater wrote: >> >>> Signed-off-by: Cédric Le Goater >>> --- >> >> The patch looks good, but I think it would be even better to apply this >> before >> Thomas's -std=

Re: [Qemu-devel] [PATCH] include/fpu/softfloat: Fix compilation with Clang on s390x

On Mon, 14 Jan 2019 13:12:35 +0100 Thomas Huth wrote: > Clang v7.0.1 does not like the __int128 variable type for inline > assembly on s390x: > > In file included from fpu/softfloat.c:97: > include/fpu/softfloat-macros.h:647:9: error: inline asm error: > This value type register class is not na

Re: [Qemu-devel] [PATCH v3 01/50] qapi: qapi for audio backends

Hi, > +## > +# @AudiodevAlsaPerDirectionOptions: > +# > +# Options of the alsa backend that are used for both playback and recording. > +# > +# @dev: the name of the alsa device to use (default 'default') > +# > +# @try-poll: attempt to use poll mode, falling back to non polling access on > +#

Re: [Qemu-devel] [PATCH 1/2] vfio-pci: Introduce vfio_register_event_notifier helper

On Thu, 17 Jan 2019 14:46:42 +1100 Alexey Kardashevskiy wrote: > On 12/01/2019 03:58, Eric Auger wrote: > > The code used to attach the eventfd handler for the ERR and > > REQ irq indices can be factorized into a helper. In subsequent > > patches we will extend this helper to support other irq in

[Qemu-devel] [PATCH v6] ppc: Fix duplicated typedefs to be able to compile with Clang in gnu99 mode

When compiling the ppc code with clang and -std=gnu99, there are a couple of warnings/errors like this one: CC ppc64-softmmu/hw/intc/xics.o In file included from hw/intc/xics.c:35: include/hw/ppc/xics.h:43:25: error: redefinition of typedef 'ICPState' is a C11 feature [-Werror,-Wtype

Re: [Qemu-devel] [PATCH 03/15] hw/ssi: Remove SSIBus from "qemu/typedefs.h"

"Michael S. Tsirkin" writes: > On Wed, Jan 16, 2019 at 12:49:07PM +0100, Paolo Bonzini wrote: >> On 16/01/19 12:34, Gerd Hoffmann wrote: >> > Hi, >> > >> >> typedefs.h is useful to avoid rebuilding the world too often if a type >> >> is used many times as a pointer, but rarely as a struct and

[Qemu-devel] [PATCH v6] ppc: Fix duplicated typedefs to be able to compile with Clang in gnu99 mode

When compiling the ppc code with clang and -std=gnu99, there are a couple of warnings/errors like this one: CC ppc64-softmmu/hw/intc/xics.o In file included from hw/intc/xics.c:35: include/hw/ppc/xics.h:43:25: error: redefinition of typedef 'ICPState' is a C11 feature [-Werror,-Wtype

Re: [Qemu-devel] [PATCH 11/14] tests: acpi: add AVMF firmware blobs

Hello Michael, On 01/16/19 17:01, Michael S. Tsirkin wrote: > On Wed, Jan 16, 2019 at 01:29:53PM +0100, Igor Mammedov wrote: >> On Tue, 15 Jan 2019 21:47:49 +0100 >> Laszlo Ersek wrote: >> >>> On 01/15/19 16:41, Igor Mammedov wrote: Add firmware blobs built with PcdAcpiTestSupport=TRUE,

Re: [Qemu-devel] [Xen-devel] [PATCH] hw/block/xen: use proper format string for printing sectors

> -Original Message- > From: Alex Bennée [mailto:alex.ben...@linaro.org] > Sent: 17 January 2019 08:21 > To: Andrew Cooper > Cc: peter.mayd...@linaro.org; Kevin Wolf ; Stefano > Stabellini ; open list:Block layer core bl...@nongnu.org>; qemu-devel@nongnu.org; Max Reitz ; > Paul Durrant ;

Re: [Qemu-devel] [PATCH 03/15] hw/ssi: Remove SSIBus from "qemu/typedefs.h"

Paolo Bonzini writes: > On 16/01/19 09:33, Markus Armbruster wrote: >> What problem exactly are we trying to solve here? >> To the best of my knowledge, typedefs.h has been working just fine for >> us, and I can't see why it shouldn't continue to work just fine. > > Patches don't have to solve pr

[Qemu-devel] [PATCH v4 1/5] linuxboot_dma: remove duplicate definitions of FW_CFG

FW_CFG_DMA_CTL_* bits and struct fw_cfg_dma_access are defined in the qemu_fw_cfg.h header file already included in linuxboot_dma.c, so we can remove the definition of BIOS_CFG_DMA_CTL_* and struct FWCfgDmaAccess. Signed-off-by: Stefano Garzarella Reviewed-by: Stefan Hajnoczi Reviewed-by: Liam M

[Qemu-devel] [PATCH v4 0/5] pvh: add new PVH option rom

This patch series is based on "[PATCH v3 0/4] QEMU changes to do PVH boot" and provides a PVH option rom that can be used with SeaBIOS to boot uncompressed kernel using the x86/HVM direct boot ABI. Patches 1 and 2 are to prepare the PVH option rom, moving common functions in the new headers. Patc

[Qemu-devel] [PATCH v4 4/5] hw/i386/pc: use PVH option rom

Use pvh.bin option rom when we are booting an uncompressed kernel using the x86/HVM direct boot ABI. Signed-off-by: Stefano Garzarella Reviewed-by: Stefan Hajnoczi Reviewed-by: Liam Merwick --- hw/i386/pc.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/i386/pc.c b/hw/i386/pc.c in

Re: [Qemu-devel] [PATCH 11/14] tests: acpi: add AVMF firmware blobs

On 01/17/19 09:53, Laszlo Ersek wrote: > Hello Michael, > > On 01/16/19 17:01, Michael S. Tsirkin wrote: >> On Wed, Jan 16, 2019 at 01:29:53PM +0100, Igor Mammedov wrote: >>> On Tue, 15 Jan 2019 21:47:49 +0100 >>> Laszlo Ersek wrote: >>> On 01/15/19 16:41, Igor Mammedov wrote: > Add firm

[Qemu-devel] [PATCH v4 2/5] linuxboot_dma: move common functions in a new header

In order to allow other option roms to use these common useful functions and definitions, this patch put them in two new C header files called optrom.h and optrom_fw_cfg.h. We also add useful out*() in*() functions for different size, and new fw_cfg functions to use when DMA feature is not availabl

[Qemu-devel] [PATCH v4 3/5] optionrom: add new PVH option rom

The new pvh.bin option rom can be used with SeaBIOS to boot uncompressed kernel using the x86/HVM direct boot ABI. pvh.S contains the entry point of the option rom. It runs in real mode, loads the e820 table querying the BIOS, and then it switches to 32bit protected mode and jumps to the pvh_load_

[Qemu-devel] [PATCH v4 5/5] optionrom/pvh: load initrd from fw_cfg

If we found initrd through fw_cfg, we can load it and use the first module of hvm_start_info to pass initrd address and size to the kernel. Signed-off-by: Stefano Garzarella --- pc-bios/optionrom/pvh_main.c | 21 +++-- pc-bios/pvh.bin | Bin 1536 -> 1536 bytes 2 fil

Re: [Qemu-devel] [PATCH 1/2] vfio-pci: Introduce vfio_register_event_notifier helper

Hi Alexey, Cornelia, On 1/17/19 4:46 AM, Alexey Kardashevskiy wrote: > > > On 12/01/2019 03:58, Eric Auger wrote: >> The code used to attach the eventfd handler for the ERR and >> REQ irq indices can be factorized into a helper. In subsequent >> patches we will extend this helper to support othe

Re: [Qemu-devel] [RFC PATCH v2 19/37] kconfig: introduce kconfig files

On 2019-01-15 15:10, Yang Zhong wrote: > From: Paolo Bonzini > > The Kconfig files were generated mostly with this script: > > for i in `grep -ho CONFIG_[A-Z0-9_]* default-configs/* | sort -u`; do > set fnord `git grep -lw $i -- 'hw/*/Makefile.objs' ` > shift > if test $# = 1; then

Re: [Qemu-devel] [PATCH 01/12] chardev: fix validation of options for QMP created chardevs

Eric, there's a QAPI code generation idea at the end. Daniel P. Berrangé writes: > On Wed, Jan 16, 2019 at 06:07:41AM +0100, Thomas Huth wrote: >> On 2019-01-15 15:52, Daniel P. Berrangé wrote: >> > The TLS creds option is not valid with certain address types. The user >> > config was only check

Re: [Qemu-devel] [PATCH v6] ppc: Fix duplicated typedefs to be able to compile with Clang in gnu99 mode

On Thu, 17 Jan 2019 10:00:49 +0100 Thomas Huth wrote: > When compiling the ppc code with clang and -std=gnu99, there are a > couple of warnings/errors like this one: > > CC ppc64-softmmu/hw/intc/xics.o > In file included from hw/intc/xics.c:35: > include/hw/ppc/xics.h:43:25: error: redefi

Re: [Qemu-devel] [PATCH v3 15/50] audio: reduce glob_audio_state usage

On Thu, Jan 17, 2019 at 12:36:48AM +0100, Kővágó, Zoltán wrote: > Remove glob_audio_state from functions, where possible without breaking > the API. This means that most static functions in audio.c now take an > AudioState pointer instead of implicitly using glob_audio_state. Also > included a po

Re: [Qemu-devel] Meaning of "-smp threads" on mips_malta

On Wed, Jan 16, 2019 at 01:30:11PM -0200, Eduardo Habkost wrote: > On Tue, Jan 15, 2019 at 03:28:50AM +0100, Aleksandar Markovic wrote: > > On Monday, January 14, 2019, Eduardo Habkost wrote: > > > > > Hi, > > > > > > I'm trying to refactor the SMP topology code in QEMU > > > > > > > > > Eduard

Re: [Qemu-devel] AVX support for TCG

On Wed, Dec 26, 2018 at 1:29 AM Nick Renieris wrote: > Do you think this could work as a GSoC project? I'm potentially > interested in working on it this summer. Richard and Nick, You are welcome to create a GSoC project idea and post it here: https://wiki.qemu.org/Google_Summer_of_Code_2019 Goo

Re: [Qemu-devel] [PATCH] ARM: GIC: error out early when creating VGICv2 failed

On Thu, Jan 17, 2019 at 11:09:17AM +0800, Shannon Zhao wrote: > Currently if creating a gicv2 VM on the platform without > VGICv2 support, it failed in kvm_arm_pmu_set_irq while > trying to set the interrupt number for PMU with below > error message. > KVM_SET_DEVICE_ATTR failed: Invalid argument >

Re: [Qemu-devel] [PATCH v3 26/50] audio: api for mixeng code free backends

On Thu, Jan 17, 2019 at 12:36:59AM +0100, Kővágó, Zoltán wrote: > Signed-off-by: Kővágó, Zoltán The mixeng patches could go to a separate series too. cheers, Gerd

Re: [Qemu-devel] [PATCH v1 2/5] vl.c: add -smp, dies=* command line support

On Thu, Jan 17, 2019 at 09:18:29AM +0800, Like Xu wrote: > On 2019/1/17 2:26, Daniel P. Berrangé wrote: > > On Mon, Jan 14, 2019 at 06:51:34PM -0200, Eduardo Habkost wrote: > > > On Mon, Jan 14, 2019 at 08:24:56PM +0800, Like Xu wrote: > > > > This patch updates the check rules on legeacy -smp pars

Re: [Qemu-devel] [PATCH v3 18/50] audio: audiodev= parameters no longer optional when -audiodev present

On Thu, Jan 17, 2019 at 12:36:51AM +0100, Kővágó, Zoltán wrote: > This means you should probably stop using -soundhw (as it doesn't allow > you to specify any options) and add the device manually with -device. > The exception is pcspk, it's currently not possible to manually add it. > To use it wit

Re: [Qemu-devel] [PATCH v3 18/50] audio: audiodev= parameters no longer optional when -audiodev present

On Thu, Jan 17, 2019 at 12:36:51AM +0100, Kővágó, Zoltán wrote: > This means you should probably stop using -soundhw (as it doesn't allow > you to specify any options) and add the device manually with -device. > The exception is pcspk, it's currently not possible to manually add it. > To use it wit

Re: [Qemu-devel] test-filter-mirror hangs

On 2019/1/15 上午12:33, Zhang Chen wrote: On Sat, Jan 12, 2019 at 12:15 AM Dr. David Alan Gilbert mailto:dgilb...@redhat.com>> wrote: * Peter Maydell (peter.mayd...@linaro.org ) wrote: > Recently I've noticed that test-filter-mirror has been hangi

Re: [Qemu-devel] [PATCH v4 for-4.0 4/7] libvhost-user: Support tracking inflight I/O in shared memory

On 2019/1/15 下午10:51, Yongji Xie wrote: Well, this may work but here're my points: 1) The code want to recover from backed crash by introducing extra space to store inflight data, but it still depends on the backend to set/get the inflight state 2) Since the backend could be killed at any tim

Re: [Qemu-devel] [PATCH 3/5] tests: remove rule for nonexisting qdev-monitor-test

On 15/01/2019 19:19, Paolo Bonzini wrote: > This test was merged into drive_del-test in 2014. > > Signed-off-by: Paolo Bonzini > --- > tests/Makefile.include | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/tests/Makefile.include b/tests/Makefile.include > index 195af1f..8b88cd5 100644 >

[Qemu-devel] [Bug 1811916] Re: SDL2 interface didn't follow the current X11 keyboard layout for hotkeys

Also affects SDL 1.2 UI in QEMU 2.12.1 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1811916 Title: SDL2 interface didn't follow the current X11 keyboard layout for hotkeys Status in QEMU: New

Re: [Qemu-devel] [PATCH v4 for-4.0 4/7] libvhost-user: Support tracking inflight I/O in shared memory

On 2019/1/15 下午11:58, Michael S. Tsirkin wrote: On Tue, Jan 15, 2019 at 03:52:21PM +0800, Jason Wang wrote: Well, this may work but here're my points: 1) The code want to recover from backed crash by introducing extra space to store inflight data, but it still depends on the backend to set/ge

Re: [Qemu-devel] [PATCH v3 47/50] paaudio: channel-map option

On Thu, Jan 17, 2019 at 12:37:20AM +0100, Kővágó, Zoltán wrote: > Add an option to change the channel map used by pulseaudio. If not > specified, falls back to an OSS compatible channel map. > > Signed-off-by: Kővágó, Zoltán > --- > qapi/audio.json | 5 - > audio/paaudio.c | 18 +++

Re: [Qemu-devel] [PATCH v3 17/19] qemu-nbd: Add --list option

12.01.2019 20:58, Eric Blake wrote: > We want to be able to detect whether a given qemu NBD server is > exposing the right export(s) and dirty bitmaps, at least for > regression testing. We could use 'nbd-client -l' from the upstream > NBD project to list exports, but it's annoying to rely on > ou

Re: [Qemu-devel] [PATCH] hw/core/generic-loader: Fix PC overwriting

On Wed, Jan 16, 2019 at 10:05:58PM +0300, Julia Suvorova via Qemu-devel wrote: > On 16.01.2019 0:51, Alistair Francis wrote: > > On Tue, Jan 15, 2019 at 7:04 AM Julia Suvorova via Qemu-devel > > wrote: > > > > > > If the memory is set using a file, and PC is specified on the command > > > line, i

Re: [Qemu-devel] [PATCH v3] vhost-user-blk: add discard/write zeroes features support

On Thu, Jan 17, 2019 at 10:24:16AM +0800, Changpeng Liu wrote: > Linux commit 1f23816b8 "virtio_blk: add discard and write zeroes support" > added the support in the Guest kernel, while here also enable the features > support with vhost-user-blk driver. Also enable the test example utility > with D

Re: [Qemu-devel] [PATCH v4 5/5] optionrom/pvh: load initrd from fw_cfg

On Thu, Jan 17, 2019 at 10:02:59AM +0100, Stefano Garzarella wrote: > If we found initrd through fw_cfg, we can load it and use the > first module of hvm_start_info to pass initrd address and size > to the kernel. > > Signed-off-by: Stefano Garzarella > --- > pc-bios/optionrom/pvh_main.c | 21 +

Re: [Qemu-devel] [RFC PATCH v2 27/37] bluetooth: express dependencies with Kconfig

On 2019-01-15 15:10, Yang Zhong wrote: > From: Paolo Bonzini > > Signed-off-by: Paolo Bonzini > Signed-off-by: Yang Zhong > Reviewed-by: Thomas Huth > --- > hw/Makefile.objs | 2 +- > hw/usb/Kconfig | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/hw/Makefile.objs

Re: [Qemu-devel] [PATCH 11/14] tests: acpi: add AVMF firmware blobs

Hi, > create mode 100644 pc-bios/avmf.img > create mode 100644 pc-bios/avmf_vars.img > >>> > >>> "AVMF" is not a great name. "AAVMF" is a downstream name alright, but > >>> many dislike it in upstream use. "edk2-aarch64" or "edk2-ArmVirtQemu" > >>> would be more precise, but those

Re: [Qemu-devel] [Qemu-block] Crash when deleting an iothread that is being used

On Tue, Jan 15, 2019 at 03:29:42PM +0200, Alberto Garcia wrote: > Here's how to reproduce the crash: > > { "execute": "qmp_capabilities" } > { "execute": "blockdev-add", "arguments": {"driver": "null-co", "node-name": > "hd0"}} > { "execute": "object-add", "arguments": {"qom-type": "iothread", "i

Re: [Qemu-devel] [RFC PATCH v2 28/37] isa: express dependencies with kconfig

On 2019-01-15 15:10, Yang Zhong wrote: > From: Paolo Bonzini > > Signed-off-by: Paolo Bonzini > Signed-off-by: Yang Zhong > --- > default-configs/i386-softmmu.mak | 10 -- > hw/audio/Kconfig | 2 ++ > hw/block/Kconfig | 2 ++ > hw/char/Kconfig

Re: [Qemu-devel] [Qemu-block] Crash when deleting an iothread that is being used

On Thu 17 Jan 2019 11:23:31 AM CET, Stefan Hajnoczi wrote: > I'm asking because x-blockdev-set-iothread is a low-level testing > command and it can create IOThread configurations that real-world > users never reach. I see, I suppose I had the wrong assumption about that command then! Berto

Re: [Qemu-devel] [RFC PATCH v2 34/37] virtio: make virtio dependencies with Kconfig

On 2019-01-15 15:11, Yang Zhong wrote: > Signed-off-by: Yang Zhong > --- > default-configs/i386-softmmu.mak | 1 - > default-configs/s390x-softmmu.mak | 1 - > default-configs/virtio.mak| 14 -- > hw/9pfs/Kconfig | 2 ++ > hw/block/Kconfig

Re: [Qemu-devel] [PATCH qemu 0/2] linux-headers: Update to v5.0-rc2

On 17/01/19 01:04, Alexey Kardashevskiy wrote: > > > On 16/01/2019 22:49, Paolo Bonzini wrote: >> On 16/01/19 12:47, Cornelia Huck wrote: >>> On Wed, 16 Jan 2019 15:17:10 +1100 >>> Alexey Kardashevskiy wrote: >>> Here is the update script update and what it did to the v5.0-rc2 kernel.

Re: [Qemu-devel] [RFC PATCH v2 30/37] i2c: express dependencies with Kconfig

On 2019-01-15 15:11, Yang Zhong wrote: > From: Paolo Bonzini > > Signed-off-by: Paolo Bonzini > Signed-off-by: Yang Zhong > --- > default-configs/i386-softmmu.mak | 1 - > hw/Makefile.objs | 2 +- > hw/audio/Kconfig | 1 + > hw/display/Kconfig | 3

Re: [Qemu-devel] [PATCH 4/5] tests/libqos: embed allocators instead of malloc-ing them separately

On 15/01/2019 19:19, Paolo Bonzini wrote: > qgraph will embed these objects instead of allocating them in a separate > object. Expose a new API "generic_alloc_init" and "generic_alloc_destroy" > for that, and rename the existing API with s/init/new/ and s/uninit/free/. I'm not the "s/init/new/ an

Re: [Qemu-devel] [PATCH v3 0/5] pvh: add new PVH option rom

On 17/01/19 08:50, Stefano Garzarella wrote: >> Also, the $? in the new rule should be $^. I wouldn't use a pattern >> rule for that, writing it explicitly as "pvh.img: pvh.S pvh_main.c" > I'll fix the Makefile. (of course it's "pvh.img: pvh.o pvh_main.o"). I can fix up as well if it's okay for

Re: [Qemu-devel] [RFC PATCH v2 31/37] ptimer: express dependencies with Kconfig

On 2019-01-15 15:11, Yang Zhong wrote: > From: Paolo Bonzini > > Signed-off-by: Paolo Bonzini > Signed-off-by: Yang Zhong > --- > hw/Kconfig | 2 ++ > hw/net/Kconfig | 2 ++ > hw/timer/Kconfig | 6 ++ > 3 files changed, 10 insertions(+) > > diff --git a/hw/Kconfig b/hw/Kconfig > i

Re: [Qemu-devel] [PATCH v3 0/5] pvh: add new PVH option rom

On Thu, Jan 17, 2019 at 11:31:27AM +0100, Paolo Bonzini wrote: > On 17/01/19 08:50, Stefano Garzarella wrote: > >> Also, the $? in the new rule should be $^. I wouldn't use a pattern > >> rule for that, writing it explicitly as "pvh.img: pvh.S pvh_main.c" > > I'll fix the Makefile. > > (of course

Re: [Qemu-devel] [PATCH] accel: Allow to build QEMU without TCG or KVM support

On Thu, Jan 17, 2019 at 07:02:24AM +0100, Thomas Huth wrote: > On 2019-01-16 18:35, Anthony PERARD wrote: > > Instead of deny build of QEMU without a default accelerator, simply > > report an error when the user haven't passed -accel or -machine accel= > > and TCG and KVM isn't builtin. > > > > ./

Re: [Qemu-devel] [PATCH] hw/core/generic-loader: Fix PC overwriting

On 17.01.2019 13:13, Stefan Hajnoczi wrote: On Wed, Jan 16, 2019 at 10:05:58PM +0300, Julia Suvorova via Qemu-devel wrote: On 16.01.2019 0:51, Alistair Francis wrote: On Tue, Jan 15, 2019 at 7:04 AM Julia Suvorova via Qemu-devel wrote: If the memory is set using a file, and PC is specified o

Re: [Qemu-devel] [RFC PATCH v2 35/37] i386-softmmu.mak: remove all CONFIG_* except boards definitions

On 2019-01-15 15:11, Yang Zhong wrote: > %-softmmu.mak only keep boards definitions in Kconfig mode. > > Signed-off-by: Yang Zhong > --- > default-configs/i386-softmmu.mak | 22 -- > hw/acpi/Kconfig | 4 > hw/i386/Kconfig | 5 + >

Re: [Qemu-devel] [PATCH] accel: Allow to build QEMU without TCG or KVM support

On 2019-01-17 11:55, Anthony PERARD wrote: > On Thu, Jan 17, 2019 at 07:02:24AM +0100, Thomas Huth wrote: >> On 2019-01-16 18:35, Anthony PERARD wrote: >>> Instead of deny build of QEMU without a default accelerator, simply >>> report an error when the user haven't passed -accel or -machine accel=

[Qemu-devel] [PATCH] spapr: Forbid setting ic-mode for old machine types

Machine types 3.0 and older only know about the legacy XICS backend. Make it clear by erroring out if the user tries to set ic-mode on such machines. Signed-off-by: Greg Kurz --- Motivation for this comes from a failing backward migration test, caused by ic-mode=xics I forgot to drop from the co

[Qemu-devel] [Bug 1811916] Re: SDL2 interface didn't follow the current X11 keyboard layout for hotkeys

I'm currently reverted the commit f8d2c9369b8302f65f4f43f14ed3987c2268a02a to use only CTRL-ALT. https://gist.github.com/Low-power/822eace3f37c893bc6aad3af647b4c7d -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpa

[Qemu-devel] [Bug 1812091] Re: ARMv8-M boots in wrong security mode

This is not an issue with the CPU emulation, it is a bug in the gdb memory read/write path, which currently effectively always does its accesses as nonsecure. The CPU itself is correctly coming out of reset in secure mode and will be able to read the correct value of the register. I suspect that t

Re: [Qemu-devel] [RFC PATCH v2 03/37] hw/arm/Makefile.objs: CONFIG_VIRT created for virt board

On Wed, Jan 16, 2019 at 01:01:07PM +0100, Thomas Huth wrote: > On 2019-01-15 15:10, Yang Zhong wrote: > > make virt code configurable and the new CONFIG_VIRT definitions > > added to the default-configs/arm-softmmu.mak to replace CONFIG_ACPI > > in arm board. > > > > Signed-off-by: Yang Zhong > >

Re: [Qemu-devel] [PATCH] accel: Allow to build QEMU without TCG or KVM support

On Thu, Jan 17, 2019 at 12:06:09PM +0100, Thomas Huth wrote: > On 2019-01-17 11:55, Anthony PERARD wrote: > > On Thu, Jan 17, 2019 at 07:02:24AM +0100, Thomas Huth wrote: > >> On 2019-01-16 18:35, Anthony PERARD wrote: > >>> Instead of deny build of QEMU without a default accelerator, simply > >>>

Re: [Qemu-devel] [PULLv3 00/65] slirp updates

On Mon, 14 Jan 2019 at 23:01, Samuel Thibault wrote: > > The following changes since commit 27df21ca3886fff4dd3d70e515517667963a52f1: > > Merge remote-tracking branch > 'remotes/kraxel/tags/misc-20190111-pull-request' into staging (2019-01-11 > 16:45:59 +) > > are available in the Git repo

Re: [Qemu-devel] [RFC PATCH v2 04/37] hw/m68k/Makefile.objs: Conditionally build boards

On Wed, Jan 16, 2019 at 08:15:23AM +0100, Thomas Huth wrote: > On 2019-01-15 15:10, Yang Zhong wrote: [...] > The naming of the files is a little bit unfortunate, but > there are only two Coldfire boards: an5206 and mcf5208evb. > mcf5206.c belongs to the an5206 board. > So may I suggest to only us

Re: [Qemu-devel] [PATCH v3 00/19] nbd: add qemu-nbd --list

12.01.2019 20:57, Eric Blake wrote: > I got tired of debugging whether a server was advertising the > correct things during negotiation by inspecting the trace > logs of qemu-io as client - not to mention that without SOME > sort of client tracing particular commands, we can't easily > regression t

[Qemu-devel] [PATCH 00/27] slirp: make it again a standalone project (part 2)

Hi, The goal is to allow building libslirp as an independent library. After this series is applied, it is possible to build an independent libslirp. However, QEMU still requires internals of libslirp to handle migration. I will be posting the remaining part to handle migration and link with the

[Qemu-devel] [PATCH 01/27] slirp: generalize guestfwd with a callback based approach

Instead of calling into QEMU chardev directly, and mixing it with slirp_add_exec() handling, add a new function slirp_add_guestfwd() which takes a write callback. Signed-off-by: Marc-André Lureau --- slirp/libslirp.h | 6 +- slirp/misc.h | 15 +-- slirp/socket.h | 4 +++-

[Qemu-devel] [PATCH 04/27] net/slirp: fix leaks on forwaring rule registration error

Signed-off-by: Marc-André Lureau --- net/slirp.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/slirp.c b/net/slirp.c index 750105a466e..0b15f427f5c 100644 --- a/net/slirp.c +++ b/net/slirp.c @@ -807,6 +807,7 @@ static int slirp_guestfwd(SlirpState *s, const char *config_str, Error **

[Qemu-devel] [PATCH 10/27] slirp: add unregister_poll_fd() callback

Add a counter-part to register_poll_fd() for completeness. (so far, register_poll_fd() is called only on struct socket fd) Suggested-by: Paolo Bonzini Signed-off-by: Marc-André Lureau --- slirp/libslirp.h | 2 ++ net/slirp.c | 6 ++ slirp/ip_icmp.c | 1 + slirp/slirp.c| 3 ++- sl

[Qemu-devel] [PATCH 03/27] net/slirp: free forwarding rules on cleanup

Signed-off-by: Marc-André Lureau --- net/slirp.c | 25 ++--- 1 file changed, 18 insertions(+), 7 deletions(-) diff --git a/net/slirp.c b/net/slirp.c index b91741b8fc1..750105a466e 100644 --- a/net/slirp.c +++ b/net/slirp.c @@ -75,6 +75,13 @@ struct slirp_config_str { cha

[Qemu-devel] [PATCH 02/27] net/slirp: simplify checking for cmd: prefix

Signed-off-by: Marc-André Lureau --- net/slirp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/slirp.c b/net/slirp.c index ec07f662c00..b91741b8fc1 100644 --- a/net/slirp.c +++ b/net/slirp.c @@ -773,7 +773,7 @@ static int slirp_guestfwd(SlirpState *s, const char *config

[Qemu-devel] [PATCH 07/27] slirp: replace QEMU_PACKED with SLIRP_PACKED

Signed-off-by: Marc-André Lureau --- slirp/ip.h | 14 +++--- slirp/ip6.h | 4 ++-- slirp/ip6_icmp.h | 16 slirp/slirp.h| 5 +++-- slirp/util.h | 32 5 files changed, 52 insertions(+), 19 deletions(-) create mode 10064

[Qemu-devel] [PATCH 11/27] slirp: replace qemu_notify_event() with a callback

Introduce a SlirpCb callback to kick the main io-thread. Add an intermediary sodrop() function that will call SlirpCb.notify callback when sbdrop() returns true. Signed-off-by: Marc-André Lureau --- slirp/libslirp.h | 2 ++ slirp/sbuf.h | 2 +- slirp/socket.h| 1 + net/slirp.c |

[Qemu-devel] [PATCH 05/27] slirp: add callbacks for timer

Signed-off-by: Marc-André Lureau --- slirp/libslirp.h | 14 +++--- slirp/slirp.h| 2 +- net/slirp.c | 21 + slirp/ip6_icmp.c | 16 +++- 4 files changed, 40 insertions(+), 13 deletions(-) diff --git a/slirp/libslirp.h b/slirp/libslirp.h index ea01

[Qemu-devel] [PATCH 18/27] slirp: replace net/eth.h inclusion with own defines

Signed-off-by: Marc-André Lureau --- slirp/ip6.h | 1 - slirp/slirp.h | 1 - slirp/util.h | 10 ++ 3 files changed, 10 insertions(+), 2 deletions(-) diff --git a/slirp/ip6.h b/slirp/ip6.h index b6ba0a63927..e0a13dec1cc 100644 --- a/slirp/ip6.h +++ b/slirp/ip6.h @@ -7,7 +7,6 @@ #def

[Qemu-devel] [PATCH 06/27] slirp: replace trace functions with DEBUG calls

Remove a dependency on QEMU. Use the existing logging facilities. Set SLIRP_DEBUG=tftp to get tftp log. Signed-off-by: Marc-André Lureau --- slirp/debug.h | 13 ++--- slirp/slirp.c | 1 + slirp/tftp.c | 7 --- Makefile.objs | 1 - slirp/trace-events | 5 -

[Qemu-devel] [PATCH 13/27] slirp: do not include qemu headers in libslirp.h public API header

Signed-off-by: Marc-André Lureau --- slirp/libslirp.h | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/slirp/libslirp.h b/slirp/libslirp.h index 679a25422b9..02cbec9f8be 100644 --- a/slirp/libslirp.h +++ b/slirp/libslirp.h @@ -1,7 +1,17 @@ #ifndef LIBSLIRP_H #def

[Qemu-devel] [PATCH 08/27] slirp: replace most qemu socket utilities with slirp own version

qemu_set_nonblock() is slightly more problematic and will be dealt with in a separate patch. Signed-off-by: Marc-André Lureau --- slirp/util.h| 59 +++ slirp/ip_icmp.c | 6 +- slirp/misc.c| 20 ++--- slirp/socket.c | 18 ++--- slirp/tcp_subr.c| 18 +

[Qemu-devel] [PATCH 12/27] slirp: move QEMU state saving to a separate unit

Make state saving optional: this will allow to build SLIRP without QEMU. (eventually, the vmstate helpers will be extracted, so an external project & process could save its state) Signed-off-by: Marc-André Lureau --- slirp/slirp.h | 3 + slirp/state.h | 9 + slirp/slirp.c |

[Qemu-devel] [PATCH 19/27] slirp: replace qemu qtailq with slirp own copy

Signed-off-by: Marc-André Lureau --- slirp/qtailq.h | 193 + slirp/slirp.h | 3 +- 2 files changed, 194 insertions(+), 2 deletions(-) create mode 100644 slirp/qtailq.h diff --git a/slirp/qtailq.h b/slirp/qtailq.h new file mode 100644 index

[Qemu-devel] [PATCH 14/27] slirp: improve windows headers inclusion

Our API usage requires Vista, set WIN32_LEAN_AND_MEAN to fix a number of issues (winsock2.h include order for ex, which is better to include first for legacy reasons). While at it, group redundants #ifndef _WIN32 blocks. Signed-off-by: Marc-André Lureau --- slirp/slirp.h | 22 +++---

[Qemu-devel] [PATCH 09/27] slirp: replace qemu_set_nonblock()

Replace qemu_set_nonblock() with slirp_set_nonblock() qemu_set_nonblock() does some event registration with the main loop. Add a new callback register_poll_fd() for that reason. Always build the fd-register stub, to avoid #if WIN32. Signed-off-by: Marc-André Lureau --- slirp/libslirp.h| 2

[Qemu-devel] [PATCH 15/27] slirp: add slirp own version of pstrcpy

Remove a dependency on qemu util. Signed-off-by: Marc-André Lureau --- slirp/util.h | 2 ++ slirp/slirp.c | 4 ++-- slirp/tftp.c | 2 +- slirp/util.c | 17 + 4 files changed, 22 insertions(+), 3 deletions(-) diff --git a/slirp/util.h b/slirp/util.h index 782ae8ef0ee..e3332

[Qemu-devel] [PATCH 21/27] slirp: prefer c99 types over BSD kind

Replace: - u_char -> uint8_t - u_short -> uint16_t - u_long -> uint32_t - u_int -> unsigned - caddr_t -> char * (indentation mess is hopefully going to be fixed when slirp is made a separate project and clang-format is applied over the history) Signed-off-by: Marc-André Lureau --- slirp/ip_icmp

[Qemu-devel] [PATCH 16/27] slirp: remove qemu timer.h dependency

Signed-off-by: Marc-André Lureau --- slirp/util.h | 2 ++ slirp/if.c | 1 - slirp/ip6_icmp.c | 1 - slirp/slirp.c| 1 - 4 files changed, 2 insertions(+), 3 deletions(-) diff --git a/slirp/util.h b/slirp/util.h index e3332cdcd60..4664e8159ba 100644 --- a/slirp/util.h +++ b/slirp/uti

Re: [Qemu-devel] [PATCH v2 2/3] contrib/vhost-user-blk: fix the compilation issue

Note: I removed my wrong e-mail address in CC. On Wed, Jan 16, 2019 at 01:19:29PM +0800, Changpeng Liu wrote: > Signed-off-by: Changpeng Liu > --- > contrib/vhost-user-blk/vhost-user-blk.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > Reviewed-by: Stefano Garzarella

Re: [Qemu-devel] [PATCH qemu 0/2] linux-headers: Update to v5.0-rc2

On Wed, 16 Jan 2019 at 11:54, Paolo Bonzini wrote: > > On 16/01/19 12:47, Cornelia Huck wrote: > > On Wed, 16 Jan 2019 15:17:10 +1100 > > Alexey Kardashevskiy wrote: > > > >> Here is the update script update and what it did to the v5.0-rc2 kernel. > >> > >> This is based on sha1 > >> a0a8bff Greg

[Qemu-devel] [PATCH 24/27] slirp: remove slirp_instances list

Now that polling is done per-instance, we don't need a global list of slirp instances. Signed-off-by: Marc-André Lureau --- slirp/slirp.c | 5 - 1 file changed, 5 deletions(-) diff --git a/slirp/slirp.c b/slirp/slirp.c index 35630efe5db..98ff23723d9 100644 --- a/slirp/slirp.c +++ b/slirp/sl

[Qemu-devel] [PATCH 17/27] slirp: remove now useless QEMU headers inclusions

Some of those could have been squashed earlier, but it is easier to do it all here. Signed-off-by: Marc-André Lureau --- slirp/slirp.h| 1 - slirp/dhcpv6.c | 1 - slirp/ip6_icmp.c | 2 -- slirp/misc.c | 2 -- slirp/sbuf.c | 1 - slirp/slirp.c| 4 slirp/tftp.c | 1 - 7

  1   2   3   4   5   >