On 2019-01-15 15:10, Yang Zhong wrote: > From: Paolo Bonzini <pbonz...@redhat.com> > > Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> > Signed-off-by: Yang Zhong <yang.zh...@intel.com> > --- > default-configs/i386-softmmu.mak | 10 ---------- > hw/audio/Kconfig | 2 ++ > hw/block/Kconfig | 2 ++ > hw/char/Kconfig | 6 ++++++ > hw/display/Kconfig | 6 ++++++ > hw/i386/Kconfig | 1 + > hw/ide/Kconfig | 1 + > hw/input/Kconfig | 2 ++ > hw/isa/Kconfig | 5 +++++ > hw/misc/Kconfig | 4 ++++ > hw/net/Kconfig | 3 +++ > hw/watchdog/Kconfig | 2 ++ > 12 files changed, 34 insertions(+), 10 deletions(-) [...] > diff --git a/hw/display/Kconfig b/hw/display/Kconfig > index 5e73277cc2..a53ca4601a 100644 > --- a/hw/display/Kconfig > +++ b/hw/display/Kconfig > @@ -9,6 +9,9 @@ config ADS7846 > > config VGA_CIRRUS > bool > + default y > + depends on PCI > + select VGA
This hunk should likely rather be part of the pci.mak patch? Apart from that, the patch here looks fine to me. Thomas