[Qemu-devel] [PATCH V9 0/6] support MAP_SYNC for memory-backend-file

2019-01-16 Thread Zhang Yi
Linux 4.15 introduces a new mmap flag MAP_SYNC, which can be used to guarantee the write persistence to mmap'ed files supporting DAX (e.g., files on ext4/xfs file system mounted with '-o dax'). A description of MAP_SYNC and MAP_SHARED_VALIDATE can be found at https://patchwork.kernel.org/patch

[Qemu-devel] [PATCH V9 1/6] numa: Fixed the memory leak of numa error message

2019-01-16 Thread Zhang Yi
object_get_canonical_path_component() returns a string which must be freed using g_free(). Signed-off-by: Zhang Yi Reviewed-by: Pankaj gupta Reviewed-by: Igor Mammedov Reviewed-by: Eduardo Habkost --- numa.c | 1 + 1 file changed, 1 insertion(+) diff --git a/numa.c b/numa.c index 50ec016..38

[Qemu-devel] [PATCH V9 2/6] memory: use sparse feature define RAM_FLAG.

2019-01-16 Thread Zhang Yi
Signed-off-by: Zhang Yi Signed-off-by: Michael S. Tsirkin --- include/exec/memory.h | 12 ++-- include/qemu/osdep.h | 9 + 2 files changed, 15 insertions(+), 6 deletions(-) diff --git a/include/exec/memory.h b/include/exec/memory.h index 667466b..03824d9 100644 --- a/include/e

[Qemu-devel] [PATCH V9 6/6] docs: Added MAP_SYNC documentation

2019-01-16 Thread Zhang Yi
Signed-off-by: Zhang Yi --- docs/nvdimm.txt | 21 - qemu-options.hx | 4 2 files changed, 24 insertions(+), 1 deletion(-) diff --git a/docs/nvdimm.txt b/docs/nvdimm.txt index 5f158a6..565ba73 100644 --- a/docs/nvdimm.txt +++ b/docs/nvdimm.txt @@ -142,11 +142,30 @@ backe

[Qemu-devel] [PATCH V9 4/6] util/mmap-alloc: support MAP_SYNC in qemu_ram_mmap()

2019-01-16 Thread Zhang Yi
When a file supporting DAX is used as vNVDIMM backend, mmap it with MAP_SYNC flag in addition which can ensure file system metadata synced in each guest writes to the backend file, without other QEMU actions (e.g., periodic fsync() by QEMU). Signed-off-by: Haozhong Zhang Signed-off-by: Zhang Yi

[Qemu-devel] [PATCH V9 3/6] util/mmap-alloc: switch 'shared' to 'flags' parameter

2019-01-16 Thread Zhang Yi
As more flag parameters besides the existing 'shared' are going to be added to qemu_ram_mmap() and qemu_ram_alloc_from_{file,fd}(), let's switch 'shared' to a 'flags' parameter in advance, so as to ease the further additions. Signed-off-by: Haozhong Zhang Signed-off-by: Zhang Yi --- exec.c

[Qemu-devel] [PATCH V9 5/6] hostmem: add more information in error messages

2019-01-16 Thread Zhang Yi
When there are multiple memory backends in use, including the object type name and the property name in the error message can help users to locate the error. Signed-off-by: Haozhong Zhang Signed-off-by: Zhang Yi Reviewed-by: Eduardo Habkost --- backends/hostmem-file.c | 6 -- backends/host

Re: [Qemu-devel] [PATCH v2 4/4] hw/i386/pc: use PVH option rom

2019-01-16 Thread Stefano Garzarella
Hi Michael, On Tue, Jan 15, 2019 at 03:05:27PM -0500, Michael S. Tsirkin wrote: > On Tue, Jan 15, 2019 at 01:12:21PM -0600, Eric Blake wrote: > > On 1/15/19 12:57 PM, Michael S. Tsirkin wrote: > > > On Tue, Jan 15, 2019 at 11:00:58AM +0100, Stefano Garzarella wrote: > > >> Use pvh.bin option rom w

Re: [Qemu-devel] [PATCH v2 4/4] hw/i386/pc: use PVH option rom

2019-01-16 Thread Stefano Garzarella
Hi Eric, On Tue, Jan 15, 2019 at 01:12:21PM -0600, Eric Blake wrote: > On 1/15/19 12:57 PM, Michael S. Tsirkin wrote: > > On Tue, Jan 15, 2019 at 11:00:58AM +0100, Stefano Garzarella wrote: > >> Use pvh.bin option rom when we are booting an uncompressed > >> kernel using the x86/HVM direct boot AB

Re: [Qemu-devel] [PATCH v3 05/19] nbd/server: Favor [u]int64_t over off_t

2019-01-16 Thread Vladimir Sementsov-Ogievskiy
15.01.2019 18:33, Eric Blake wrote: > On 1/15/19 4:19 AM, Vladimir Sementsov-Ogievskiy wrote: >> 12.01.2019 20:57, Eric Blake wrote: >>> Although our compile-time environment is set up so that we always >>> support long files with 64-bit off_t, we have no guarantee whether >>> off_t is the same typ

Re: [Qemu-devel] [RFC PATCH v2 05/37] hw/microblaze/Makefile.objs: Create configs for petalogix and xilinx boards

2019-01-16 Thread Thomas Huth
On 2019-01-15 15:10, Yang Zhong wrote: > From: Ákos Kovács > > CONFIG_PETALOGIX_* and CONFIG_XLNX_* configs added to > default-configs/microblaze-softmmu.mak and > default-configs/microblazeel-softmmu.mak. > > Signed-off-by: Ákos Kovács > Signed-off-by: Paolo Bonzini > --- > default-configs/

Re: [Qemu-devel] [PATCH 03/15] hw/ssi: Remove SSIBus from "qemu/typedefs.h"

2019-01-16 Thread Markus Armbruster
Paolo Bonzini writes: > On 15/01/19 13:56, Thomas Huth wrote: >> Yes, agreed, removing things from typedefs.h just to add lots of >> #includes in other files is not really the best idea. I also dropped >> this patch in v2 of my current PULL request because of this reason. >> Phil, I suggest to si

Re: [Qemu-devel] [PATCH 03/15] hw/ssi: Remove SSIBus from "qemu/typedefs.h"

2019-01-16 Thread Markus Armbruster
Paolo Bonzini writes: > On 15/01/19 13:28, Markus Armbruster wrote: >>> Signed-off-by: Philippe Mathieu-Daudé >>> --- >>> hw/arm/strongarm.h | 1 + >>> include/hw/arm/pxa.h| 1 + >>> include/hw/ssi/pl022.h | 1 + >>> include/hw/ssi/ssi.h| 1 + >>> include/qemu/typedefs.h | 1 - >>>

Re: [Qemu-devel] [PATCH v3 0/4] Introduce attributes for timers subsystem and remove QEMU_CLOCK_VIRTUAL_EXT clock type

2019-01-16 Thread Artem Pisarenko
ср, 16 янв. 2019 г. в 12:15, Pavel Dovgalyuk : > > > From: Artem Pisarenko [mailto:artem.k.pisare...@gmail.com] > > > It seems, that this approach is not always correct. > > > Now timerlist_deadline_ns uses all virtual timers for deadline > > > calculation (including > > external > > > ones). > >

Re: [Qemu-devel] [RFC PATCH v2 06/37] hw/mips/Makefile.objs: Create CONFIG_* for r4k, malta, mipssim boards

2019-01-16 Thread Thomas Huth
On 2019-01-15 15:10, Yang Zhong wrote: > From: Ákos Kovács > > Add the new configs to default-configs/mips*-sofmmu.mak. > > Signed-off-by: Ákos Kovács > Signed-off-by: Paolo Bonzini > Signed-off-by: Yang Zhong > --- > default-configs/mips-softmmu-common.mak | 4 > default-configs/mips64

Re: [Qemu-devel] [RFC PATCH v2 07/37] hw/ppc/Makefile.objs: Build all boards conditinally with CONFIG_*

2019-01-16 Thread Thomas Huth
On 2019-01-15 15:10, Yang Zhong wrote: > From: Ákos Kovács > > CONFIG_PPC405, CONFIG_PPC440, CONFIG_MAC_OLDWORLD, CONFIG_MAX_NEWWORLD > and CONFIG_VIRTEX configuration options created for > default-configs/ppc*-softmmu.mak. > > Signed-off-by: Ákos Kovács > Signed-off-by: Paolo Bonzini > Signed

Re: [Qemu-devel] [RFC PATCH v2 08/37] hw/sh4/Makefile.objs: New CONFIG_* varibales created for sh4 boards and device

2019-01-16 Thread Thomas Huth
On 2019-01-15 15:10, Yang Zhong wrote: > From: Ákos Kovács > > Make hw/sh4 configurable and add new CONFIG_* to the > default-configs/sh4*-softmmu.mak. > > Signed-off-by: Ákos Kovács > Signed-off-by: Paolo Bonzini > --- > default-configs/sh4-softmmu.mak | 3 +++ > default-configs/sh4eb-sof

Re: [Qemu-devel] [RFC PATCH v2 09/37] hw/sparc/Makefile.objs: CONFIG_* for sun4m and leon3 created

2019-01-16 Thread Thomas Huth
On 2019-01-15 15:10, Yang Zhong wrote: > From: Ákos Kovács > > CONFIG_LEON3 added to default-configs/sparc-softmmu.mak. > > Signed-off-by: Ákos Kovács > Signed-off-by: Paolo Bonzini > --- > default-configs/sparc-softmmu.mak | 2 ++ > hw/sparc/Makefile.objs| 4 +++- > 2 files chang

Re: [Qemu-devel] [RFC PATCH v2 10/37] hw/lm32/Makefile.objs: Conditionally build lm32 and milkmyst

2019-01-16 Thread Thomas Huth
On 2019-01-15 15:10, Yang Zhong wrote: > From: Ákos Kovács > > CONFIG_LM32 and CONFIG_MILKYMIST added for lm32 and milkmyst build. > > Signed-off-by: Ákos Kovács > Signed-off-by: Paolo Bonzini > --- > hw/lm32/Makefile.objs | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff

Re: [Qemu-devel] [PATCH v2 1/6] s390x/pci: Use hotplug_dev instead of looking up the host bridge

2019-01-16 Thread Cornelia Huck
On Tue, 15 Jan 2019 15:57:38 -0500 Collin Walling wrote: > On 1/14/19 5:31 AM, David Hildenbrand wrote: > > We directly have it in our hands. > > > > Signed-off-by: David Hildenbrand > > --- > > hw/s390x/s390-pci-bus.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > di

[Qemu-devel] [Bug 1811244] Re: qemu 3.1/i386 crashes when MTTCG is enabled

2019-01-16 Thread Jakub Jermar
** Attachment added: "Debug binary with symbols" https://bugs.launchpad.net/qemu/+bug/1811244/+attachment/5229552/+files/qemu-system-i386.xz ** Description changed: When MTTCG is enabled, QEMU 3.1.0 sometimes crashes when running the following command line: qemu-system-i386 -kernel

[Qemu-devel] [Bug 1811244] Re: qemu 3.1/i386 crashes when MTTCG is enabled

2019-01-16 Thread Jakub Jermar
** Attachment added: "coredump" https://bugs.launchpad.net/qemu/+bug/1811244/+attachment/5229551/+files/qemu-system-i386.core.xz -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1811244 Title: qem

Re: [Qemu-devel] [PATCH 01/12] chardev: fix validation of options for QMP created chardevs

2019-01-16 Thread Daniel P . Berrangé
On Wed, Jan 16, 2019 at 06:07:41AM +0100, Thomas Huth wrote: > On 2019-01-15 15:52, Daniel P. Berrangé wrote: > > The TLS creds option is not valid with certain address types. The user > > config was only checked for errors when parsing legacy QemuOpts, thus > > the user could pass unsupported valu

Re: [Qemu-devel] [RFC PATCH v2 11/37] hw/xtensa/Makefile.objs: Build xtensa_sim and xtensa_fpga conditionally

2019-01-16 Thread Thomas Huth
On 2019-01-15 15:10, Yang Zhong wrote: > From: Ákos Kovács > > Add the new CONFIG_* values to default-config/xtensa*-softmmu.mak. > > Signed-off-by: Ákos Kovács > Signed-off-by: Paolo Bonzini > --- > default-configs/xtensa-softmmu.mak | 3 +++ > default-configs/xtensaeb-softmmu.mak | 3 +++

Re: [Qemu-devel] [PATCH v12 09/10] qcow2: skip writing zero buffers to empty COW areas

2019-01-16 Thread Anton Nefedov
On 15/1/2019 6:27 PM, Alberto Garcia wrote: > On Mon 14 Jan 2019 12:18:30 PM CET, Anton Nefedov wrote: >> If COW areas of the newly allocated clusters are zeroes on the backing image, >> efficient bdrv_write_zeroes(flags=BDRV_REQ_ALLOCATE) can be used on the whole >> cluster instead of writing expl

Re: [Qemu-devel] [PATCH 04/12] chardev: remove many local variables in qemu_chr_parse_socket

2019-01-16 Thread Daniel P . Berrangé
On Tue, Jan 15, 2019 at 01:33:25PM -0600, Eric Blake wrote: > [adding Markus in relation to a QemuOpts observation] > > On 1/15/19 8:52 AM, Daniel P. Berrangé wrote: > > Now that all validation is separated off into a separate method, > > we can directly populate the ChardevSocket struct from the

Re: [Qemu-devel] [PATCH 04/12] chardev: remove many local variables in qemu_chr_parse_socket

2019-01-16 Thread Daniel P . Berrangé
On Tue, Jan 15, 2019 at 11:18:21PM +0400, Marc-André Lureau wrote: > Hi > > On Tue, Jan 15, 2019 at 6:53 PM Daniel P. Berrangé > wrote: > > > > Now that all validation is separated off into a separate method, > > we can directly populate the ChardevSocket struct from the > > QemuOpts values, avo

[Qemu-devel] [Bug 1811244] Re: qemu 3.1/i386 crashes/guest hangs when MTTCG is enabled

2019-01-16 Thread Jakub Jermar
As for the other outcome, when the guest hangs (instead of QEMU crashing), the guest CPUs that block forward progress are halted in an idle loop, have interrupts enabled and have a queued timer IRQ 248 and a pending software IPI IRQ 250. It appears another timer IRQ is currently being serviced (but

Re: [Qemu-devel] [PATCH 07/12] chardev: split tcp_chr_wait_connected into two methods

2019-01-16 Thread Daniel P . Berrangé
On Tue, Jan 15, 2019 at 11:44:37PM +0400, Marc-André Lureau wrote: > Hi > > On Tue, Jan 15, 2019 at 6:53 PM Daniel P. Berrangé > wrote: > > > > The tcp_chr_wait_connected method can deal with either server or client > > chardevs, but some callers only care about one of these possibilities. > > T

Re: [Qemu-devel] [PATCH 06/12] chardev: remove unused 'sioc' variable & cleanup paths

2019-01-16 Thread Daniel P . Berrangé
On Wed, Jan 16, 2019 at 06:24:49AM +0100, Thomas Huth wrote: > On 2019-01-15 15:52, Daniel P. Berrangé wrote: > > The 'sioc' variable in qmp_chardev_open_socket was unused since > > > > commit 3e7d4d20d3a528b1ed10b1dc3d83119bfb0c5f24 > > Author: Peter Xu > > Date: Tue Mar 6 13:33:17 2018

Re: [Qemu-devel] [PATCH v12 09/10] qcow2: skip writing zero buffers to empty COW areas

2019-01-16 Thread Alberto Garcia
On Wed 16 Jan 2019 10:32:33 AM CET, Anton Nefedov wrote: >>> +ret = handle_alloc_space(bs, l2meta); >> >> I insist that it would be nice to have a short comment explaining >> what this does. > > Right sorry forgot your comment. > I'd go with: > > +/* Try to efficiently initialize t

Re: [Qemu-devel] [PATCH 11/12] chardev: disallow TLS/telnet/websocket with tcp_chr_wait_connected

2019-01-16 Thread Daniel P . Berrangé
On Wed, Jan 16, 2019 at 01:54:54AM +0400, Marc-André Lureau wrote: > On Tue, Jan 15, 2019 at 6:54 PM Daniel P. Berrangé > wrote: > > > > In the previous commit > > > > commit 1dc8a6695c731abb7461c637b2512c3670d82be4 > > Author: Marc-André Lureau > > Date: Tue Aug 16 12:33:32 2016 +

Re: [Qemu-devel] [PATCH v2 4/6] s390x/pci: Ignore the unplug call if we already have a release_timer

2019-01-16 Thread Cornelia Huck
On Tue, 15 Jan 2019 17:53:17 -0500 Collin Walling wrote: > On 1/14/19 5:31 AM, David Hildenbrand wrote: > > ... otherwise two successive calls to qdev_unplug() (e.g. by an impatient > > user) will effectively overwrite pbdev->release_timer, resulting in a > > memory leak. We are already processin

Re: [Qemu-devel] [RFC PATCH v2 12/37] hw/nios2/Makefile.objs: Conditionally build nios2

2019-01-16 Thread Thomas Huth
On 2019-01-15 15:10, Yang Zhong wrote: > CONFIG_NIOS2_10M50_BOARD added for 10m50 dev board. > > Signed-off-by: Yang Zhong > --- > default-configs/nios2-softmmu.mak | 1 + > hw/nios2/Makefile.objs| 3 ++- > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/default-con

Re: [Qemu-devel] [PATCH v2 4/6] s390x/pci: Ignore the unplug call if we already have a release_timer

2019-01-16 Thread David Hildenbrand
On 15.01.19 23:53, Collin Walling wrote: > On 1/14/19 5:31 AM, David Hildenbrand wrote: >> ... otherwise two successive calls to qdev_unplug() (e.g. by an impatient >> user) will effectively overwrite pbdev->release_timer, resulting in a >> memory leak. We are already processing the unplug. >> > >

Re: [Qemu-devel] [RFC PATCH v2 13/37] hw/riscv/Makefile.objs: Create CONFIG_* for riscv boards

2019-01-16 Thread Thomas Huth
On 2019-01-15 15:10, Yang Zhong wrote: > Add the new configs to default-configs/riscv*-sofmmu.mak. > > Signed-off-by: Yang Zhong > --- > default-configs/riscv32-softmmu.mak | 6 ++ > default-configs/riscv64-softmmu.mak | 6 ++ > hw/riscv/Makefile.objs | 22 +++-

Re: [Qemu-devel] [PATCH 01/14] tests: acpi: add uefi_find_rsdp_addr() helper

2019-01-16 Thread Igor Mammedov
On Tue, 15 Jan 2019 21:06:16 +0100 Laszlo Ersek wrote: > Hi Igor, > > On 01/15/19 16:40, Igor Mammedov wrote: > > introduce UEFI specific counterpart to acpi_find_rsdp_address() > > that will help to find RSDP address when [OA]VMF is used as > > firmware. It requires a [OA]VMF built with PcdAcpi

Re: [Qemu-devel] [RFC PATCH v2 14/37] hw/sparc64/Makefile.objs: Create CONFIG_* for sparc64

2019-01-16 Thread Thomas Huth
On 2019-01-15 15:10, Yang Zhong wrote: > Add the new configs to default-configs/sparc64-sofmmu.mak. > > Signed-off-by: Yang Zhong > --- > default-configs/sparc64-softmmu.mak | 2 ++ > hw/sparc64/Makefile.objs| 6 +++--- > 2 files changed, 5 insertions(+), 3 deletions(-) > > diff --g

Re: [Qemu-devel] [PATCH 08/14] tests: acpi: introduce an abilty start tests with UEFI firmware

2019-01-16 Thread Igor Mammedov
On Tue, 15 Jan 2019 21:18:18 +0100 Laszlo Ersek wrote: > On 01/15/19 16:41, Igor Mammedov wrote: > > For testcase to use UEFI firmware, one needs to provide and specify > > firmware and varstore blobs names in test_data { uefi_fl1, uefi_fl2) } > > fields respectively. > > > > Signed-off-by: Igor

Re: [Qemu-devel] [PATCH 03/15] hw/ssi: Remove SSIBus from "qemu/typedefs.h"

2019-01-16 Thread Paolo Bonzini
On 16/01/19 09:33, Markus Armbruster wrote: > What problem exactly are we trying to solve here? > To the best of my knowledge, typedefs.h has been working just fine for > us, and I can't see why it shouldn't continue to work just fine. Patches don't have to solve problems. They can just help long

Re: [Qemu-devel] [PATCH] hw/rdma: Verify that ptr is not NULL before freeing

2019-01-16 Thread Yuval Shaia
On Mon, Jan 14, 2019 at 04:11:22PM +0100, Philippe Mathieu-Daudé wrote: > Hi Yuval, > > On 1/14/19 3:10 PM, Yuval Shaia wrote: > > Make sure objects are not NULL before calling to non-nulll-safe > > null will fix > > > destructors. > > > > Signed-off-by: Yuval Shaia > > --- > > hw/rdma/rdma

[Qemu-devel] [PATCH] vnc: detect and optimize pageflips

2019-01-16 Thread Gerd Hoffmann
When size and format of the display surface stays the same we can just tag the guest display as dirty and be done with it. There is no need need to resize the vnc server display or to touch the vnc client dirty bits. On the next refresh cycle vnc_refresh_server_surface() will check for actual dis

Re: [Qemu-devel] [PATCH v2 3/4] optionrom: add new PVH option rom

2019-01-16 Thread Liam Merwick
Hi Stefano, Code LGTM, just a few minor comments below On 15/01/2019 10:00, Stefano Garzarella wrote: The new pvh.bin option rom can be used with SeaBIOS to boot uncompressed kernel using the x86/HVM direct boot ABI. pvh.S contains the entry point of the option rom. It runs in real mode, loads

Re: [Qemu-devel] [PATCH v2 0/4] pvh: add new PVH option rom

2019-01-16 Thread Liam Merwick
On 15/01/2019 10:00, Stefano Garzarella wrote: This patch series is based on "[RFC v2 0/4] QEMU changes to do PVH boot" and provides a PVH option rom that can be used with SeaBIOS to boot uncompressed kernel using the x86/HVM direct boot ABI. Patches 1 and 2 are to prepare the PVH option rom,

Re: [Qemu-devel] [PATCH v3 15/19] nbd/client: Add nbd_receive_export_list()

2019-01-16 Thread Vladimir Sementsov-Ogievskiy
12.01.2019 20:58, Eric Blake wrote: > We want to be able to detect whether a given qemu NBD server is > exposing the right export(s) and dirty bitmaps, at least for > regression testing. We could use 'nbd-client -l' from the upstream > NBD project to list exports, but it's annoying to rely on > ou

Re: [Qemu-devel] [PATCH] vnc: detect and optimize pageflips

2019-01-16 Thread Daniel P . Berrangé
On Wed, Jan 16, 2019 at 11:10:49AM +0100, Gerd Hoffmann wrote: > When size and format of the display surface stays the same we can just > tag the guest display as dirty and be done with it. > > There is no need need to resize the vnc server display or to touch the > vnc client dirty bits. On the

Re: [Qemu-devel] [PATCH v6 1/3] cputlb: do not evict empty entries to the vtlb

2019-01-16 Thread Alex Bennée
Emilio G. Cota writes: > Currently we evict an entry to the victim TLB when it doesn't match > the current address. But it could be that there's no match because > the current entry is empty (i.e. all -1's, for instance via tlb_flush). > Do not evict the entry to the vtlb in that case. > > This

Re: [Qemu-devel] [PATCH v5 4/4] i386: allow to load initrd below 4G for recent linux

2019-01-16 Thread Li Zhijian
Hi Michael, Eduardo On 1/15/19 09:46, Michael S. Tsirkin wrote: On Tue, Jan 15, 2019 at 09:35:09AM +0800, Li Zhijian wrote: Hi Eduardo On 1/15/19 01:53, Eduardo Habkost wrote: +if (protocol >= 0x20c && +lduw_p(header+0x236) & XLF_CAN_BE_LOADED_ABOVE_4G) {

Re: [Qemu-devel] [PATCH v2 0/6] s390x/pci: hotplug handler fixes and reworks

2019-01-16 Thread Cornelia Huck
On Mon, 14 Jan 2019 11:31:04 +0100 David Hildenbrand wrote: > A bunch of fixes and reworks for s390x/pci hotplug infrastructure. > > Patch 1,2: Reworks already posted (pre_plug handler) > Patch 3,4: Fixes for memory leaks > Patch 5: Rework unplug handler (introduce unplug_request handler) which

Re: [Qemu-devel] [PATCH 10/14] tests: acpi: ignore SMBIOS tests when UEFI firmware is used

2019-01-16 Thread Igor Mammedov
On Tue, 15 Jan 2019 21:31:54 +0100 Laszlo Ersek wrote: > On 01/15/19 16:41, Igor Mammedov wrote: > > once FW provides a pointer to SMBIOS entry point like it does for > > RSDP it should be possible to enable this one the same way. > > Good point, I didn't think of SMBIOS. > > We have the foll

Re: [Qemu-devel] [PATCH v3 10/19] nbd/client: Split out nbd_send_one_meta_context()

2019-01-16 Thread Vladimir Sementsov-Ogievskiy
15.01.2019 18:44, Eric Blake wrote: > On 1/15/19 7:18 AM, Vladimir Sementsov-Ogievskiy wrote: >> 12.01.2019 20:58, Eric Blake wrote: >>> Refactor nbd_negotiate_simple_meta_context() to pull out the >>> code that can be reused to send a LIST request for 0 or 1 query. >>> No semantic change. The old

Re: [Qemu-devel] [RFC PATCH v2 19/37] kconfig: introduce kconfig files

2019-01-16 Thread Thomas Huth
On 2019-01-15 15:10, Yang Zhong wrote: > From: Paolo Bonzini > > The Kconfig files were generated mostly with this script: > > for i in `grep -ho CONFIG_[A-Z0-9_]* default-configs/* | sort -u`; do > set fnord `git grep -lw $i -- 'hw/*/Makefile.objs' ` > shift > if test $# = 1; then

Re: [Qemu-devel] [PATCH v3 16/19] nbd/client: Add meta contexts to nbd_receive_export_list()

2019-01-16 Thread Vladimir Sementsov-Ogievskiy
12.01.2019 20:58, Eric Blake wrote: > We want to be able to detect whether a given qemu NBD server is > exposing the right export(s) and dirty bitmaps, at least for > regression testing. We could use 'nbd-client -l' from the upstream > NBD project to list exports, but it's annoying to rely on > ou

Re: [Qemu-devel] [PATCH v2 1/4] hostmem-memfd: disable for systems wihtout sealing support

2019-01-16 Thread Ilya Maximets
So, can we have any conclusion about this patch and the series? Best regards, Ilya Maximets. On 05.01.2019 5:43, Eduardo Habkost wrote: > On Tue, Dec 11, 2018 at 04:48:23PM +0100, Igor Mammedov wrote: >> On Tue, 11 Dec 2018 13:29:19 +0300 >> Ilya Maximets wrote: >> >> CCing libvirt folk for an o

[Qemu-devel] HACKING vs. CODING_STYLE (was: Re: [PATCH] HACKING: Clarify the paragraph about typedefs)

2019-01-16 Thread Thomas Huth
On 2019-01-11 11:38, Paolo Bonzini wrote: [...] > And, I would move it to CODING_STYLE since we are at it. :) I just got some feedback in IRC already, and seems like I am not alone, so let's discuss it here on the mailing list, too: What's the exact difference between CODING_STYLE and HACKING? Som

Re: [Qemu-devel] [PATCH v2 3/4] optionrom: add new PVH option rom

2019-01-16 Thread Stefano Garzarella
Hi Liam, On Wed, Jan 16, 2019 at 10:16:04AM +, Liam Merwick wrote: > Hi Stefano, > > Code LGTM, just a few minor comments below > > On 15/01/2019 10:00, Stefano Garzarella wrote: > > The new pvh.bin option rom can be used with SeaBIOS to boot > > uncompressed kernel using the x86/HVM direct

Re: [Qemu-devel] [RFC PATCH v2 20/37] build: switch to Kconfig

2019-01-16 Thread Thomas Huth
On 2019-01-15 15:10, Yang Zhong wrote: > From: Paolo Bonzini > > The make_device_config.sh script is replaced by minikconf, which > is modified to support the same command line as its predecessor. > > The roots of the parsing are default-configs/*.mak, Kconfig.host and > hw/Kconfig. One differe

Re: [Qemu-devel] [PATCH 10/14] tests: acpi: ignore SMBIOS tests when UEFI firmware is used

2019-01-16 Thread Laszlo Ersek
+Gerd On 01/16/19 11:32, Igor Mammedov wrote: > On Tue, 15 Jan 2019 21:31:54 +0100 > Laszlo Ersek wrote: > >> On 01/15/19 16:41, Igor Mammedov wrote: >>> once FW provides a pointer to SMBIOS entry point like it does for >>> RSDP it should be possible to enable this one the same way. >> >> Good

Re: [Qemu-devel] [RFC PATCH 1/1] target/ppc: support single stepping with KVM HV

2019-01-16 Thread Fabiano Rosas
Alexey Kardashevskiy writes: > Fabiano, > > Are you planning on reposting this any time soon? I am interested in the > feature. Thanks. Yes, I'm almost done with v3 of the series. Will probably send it later this week.

Re: [Qemu-devel] [PATCH 10/14] tests: acpi: ignore SMBIOS tests when UEFI firmware is used

2019-01-16 Thread Laszlo Ersek
On 01/16/19 12:07, Laszlo Ersek wrote: > +Gerd > > On 01/16/19 11:32, Igor Mammedov wrote: >> On Tue, 15 Jan 2019 21:31:54 +0100 >> Laszlo Ersek wrote: >> >>> On 01/15/19 16:41, Igor Mammedov wrote: once FW provides a pointer to SMBIOS entry point like it does for RSDP it should be poss

Re: [Qemu-devel] [PATCH] egl-helpers.h: add a missing X11 include

2019-01-16 Thread Philippe Mathieu-Daudé
On 1/16/19 6:53 AM, Gerd Hoffmann wrote: > On Tue, Jan 15, 2019 at 09:47:08PM +0100, Alexander Kanavin wrote: >> On Tue, 15 Jan 2019 at 20:58, Philippe Mathieu-Daudé >> wrote: >>> Cc'ing Gerd (the maintainer) and Marc-André. >>> | EGLSurface qemu_egl_init_surface_x11(EGLContext ectx, Window

Re: [Qemu-devel] [RFC PATCH v2 21/37] ide: express dependencies with Kconfig

2019-01-16 Thread Thomas Huth
On 2019-01-15 15:10, Yang Zhong wrote: > From: Paolo Bonzini > > Signed-off-by: Paolo Bonzini > --- > default-configs/alpha-softmmu.mak | 2 -- > default-configs/pci.mak | 3 --- > hw/ide/Kconfig| 15 +++ > 3 files changed, 15 insertions(+), 5 deletio

Re: [Qemu-devel] HACKING vs. CODING_STYLE (was: Re: [PATCH] HACKING: Clarify the paragraph about typedefs)

2019-01-16 Thread Paolo Bonzini
On 16/01/19 11:58, Thomas Huth wrote: >> And, I would move it to CODING_STYLE since we are at it. :) > I just got some feedback in IRC already, and seems like I am not alone, > so let's discuss it here on the mailing list, too: What's the exact > difference between CODING_STYLE and HACKING? Some of

Re: [Qemu-devel] [RFC PATCH v2 22/37] hw/pci/Makefile.objs: make pcie configurable

2019-01-16 Thread Thomas Huth
On 2019-01-15 15:10, Yang Zhong wrote: > Make pcie splited from pci and make it configurable. > > Signed-off-by: Yang Zhong > --- > default-configs/pci.mak | 1 + > hw/pci/Kconfig | 3 +++ > hw/pci/Makefile.objs| 5 +++-- > 3 files changed, 7 insertions(+), 2 deletions(-) > > diff

Re: [Qemu-devel] [PATCH V9 5/6] hostmem: add more information in error messages

2019-01-16 Thread Stefano Garzarella
On Wed, Jan 16, 2019 at 9:17 AM Zhang Yi wrote: > > When there are multiple memory backends in use, including the object type > name and the property name in the error message can help users to locate > the error. > > Signed-off-by: Haozhong Zhang > Signed-off-by: Zhang Yi > Reviewed-by: Eduardo

Re: [Qemu-devel] [PATCH 03/15] hw/ssi: Remove SSIBus from "qemu/typedefs.h"

2019-01-16 Thread Gerd Hoffmann
Hi, > typedefs.h is useful to avoid rebuilding the world too often if a type > is used many times as a pointer, but rarely as a struct and rarely has > functions called on its instances. Related: Can also be used to keep struct content private. struct QemuConsole for example is private to ui/

[Qemu-devel] [PATCH RFC 01/10] qdev: Let the hotplug_handler_unplug() caller delete the device

2019-01-16 Thread David Hildenbrand
When unplugging a device, at one point the device will be destroyed via object_unparent(). This will, one the one hand, unrealize the removed device hierarchy, and on the other hand, destroy/free the device hierarchy. When chaining interrupt handlers, we want to overwrite a bus hotplug handler by

[Qemu-devel] [PATCH RFC 02/10] qdev: Let machine hotplug handler to override bus hotplug handler

2019-01-16 Thread David Hildenbrand
From: Igor Mammedov it will allow to return another hotplug handler than the default one for a specific bus based device type. Which is needed to handle non trivial plug/unplug sequences that need the access to resources configured outside of bus where device is attached. That will allow for ret

[Qemu-devel] [PATCH RFC 03/10] qdev: Provide qdev_get_bus_hotplug_handler()

2019-01-16 Thread David Hildenbrand
Let's use a wrapper instead of looking it up manually. This function can than be reused when we explicitly want to have the bus hotplug handler (e.g. when the bus hotplug handler was overwritten by the machine hotplug handler). Signed-off-by: David Hildenbrand --- hw/core/qdev.c | 10 +++

[Qemu-devel] [PATCH RFC 00/10] qdev: Hotplug handler chaining + virtio-pmem

2019-01-16 Thread David Hildenbrand
This series implements supprt for hotplug handler chaining (proposed by Igor), something that is necessary to turn selected virtio devices into memory devices. Planned devices inlude virtio-mem and virtio-pmem. The current prototype of virtio-pmem is included. The machine hotplug handler can inter

[Qemu-devel] [PATCH RFC 05/10] virtio-pci: Allow to specify additional interfaces for the base type

2019-01-16 Thread David Hildenbrand
Let's allow to specify additional interfaces for the base type (e.g. later TYPE_MEMORY_DEVICE), something that was possible before the rework of virtio PCI device instantiation. Signed-off-by: David Hildenbrand --- hw/virtio/virtio-pci.c | 1 + hw/virtio/virtio-pci.h | 1 + 2 files changed, 2 in

[Qemu-devel] [PATCH RFC 07/10] hmp: Handle virtio-pmem when printing memory device infos

2019-01-16 Thread David Hildenbrand
Print the memory device info just like for PCDIMM/NVDIMM. Signed-off-by: David Hildenbrand --- hmp.c | 27 +++ 1 file changed, 15 insertions(+), 12 deletions(-) diff --git a/hmp.c b/hmp.c index 8da5fd8760..25c32e0810 100644 --- a/hmp.c +++ b/hmp.c @@ -2553,6 +2553,7 @@ v

[Qemu-devel] [PATCH RFC 04/10] virtio-pmem: Prototype

2019-01-16 Thread David Hildenbrand
From: Pankaj Gupta This is the current protoype of virtio-pmem. Support will require machine changes for the architectures that will support it, so it will not yet be compiled. TODO: - Use separate struct for tracking requests internally - Move request/response structs to linux headers - Factor

[Qemu-devel] [PATCH RFC 10/10] pc: Enable support for virtio-pmem

2019-01-16 Thread David Hildenbrand
As we can now properly hotplug PCI based memory devices on x86, we can now unlock support for virtio-pmem (which will unlock virtio-pmem-pci). Signed-off-by: David Hildenbrand --- default-configs/i386-softmmu.mak | 1 + 1 file changed, 1 insertion(+) diff --git a/default-configs/i386-softmmu.ma

[Qemu-devel] [PATCH RFC 09/10] pc: Support for PCI based memory devices

2019-01-16 Thread David Hildenbrand
Override the PCI device hotplug handler to properly handle the memory device part from the machine hotplug handler and forward to the actual PCI bus hotplug handler. As PCI hotplug has not been properly factored out into hotplug handlers, most magic is performed in the (un)realize functions. Also

[Qemu-devel] [PATCH RFC 06/10] virtio-pci: Proxy for virtio-pmem

2019-01-16 Thread David Hildenbrand
From: Pankaj Gupta We need a proxy device for virtio-pmem, and this device has to be the actual memory device so we can cleanly hotplug it. Forward memory device class functions either to the actual device or use properties of the virtio-pmem device to implement these in the proxy. virtio-pmem

Re: [Qemu-devel] [PATCH qemu 1/2] update-linux-headers.sh: Copy new headers

2019-01-16 Thread Stefano Garzarella
On Wed, Jan 16, 2019 at 5:20 AM Alexey Kardashevskiy wrote: > > Since Linux'es ab66dcc76d "powerpc: generate uapi header and system call > table files" there are 2 new files: unistd_32.h and unistd_64.h. These > files content is moved from unistd.h so now we have to copy new files > as well, just

[Qemu-devel] [PATCH] egl-helpers.h: do not depend on X11 Window type, use EGLNativeWindowType

2019-01-16 Thread Alexander Kanavin
It was assumed that mesa provides the necessary X11 includes, but it is not always the case, as it can be configured without x11 support. Signed-off-by: Alexander Kanavin --- include/ui/egl-helpers.h | 2 +- ui/egl-helpers.c | 4 ++-- ui/gtk-egl.c | 2 +- 3 files changed, 4 i

[Qemu-devel] [PATCH RFC 08/10] numa: Handle virtio-pmem in NUMA stats

2019-01-16 Thread David Hildenbrand
Account the memory to node 0 for now. Once (if ever) virtio-pmem supports NUMA, we can account it to the right node. Signed-off-by: David Hildenbrand --- numa.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/numa.c b/numa.c index 50ec016013..f426e0

Re: [Qemu-devel] [RFC PATCH v2 23/37] build: convert pci.mak to Kconfig

2019-01-16 Thread Thomas Huth
On 2019-01-15 15:10, Yang Zhong wrote: > From: Paolo Bonzini > > Instead of including the same list of devices for each target, > set CONFIG_PCI to true, and make the devices default to present > whenever PCI is available. > > Done mostly with the following script: > > while read i; do >

Re: [Qemu-devel] [PATCH] egl-helpers.h: add a missing X11 include

2019-01-16 Thread Alexander Kanavin
On Wed, 16 Jan 2019 at 12:10, Philippe Mathieu-Daudé wrote: > >> we build mesa explicitly using "--with-platforms='drm surfaceless'" > >> (x11 is not in the list), which means MESA_EGL_NO_X11_HEADERS is > >> indeed defined according to [1]. We also enable opengl and gtk in > >> qemu. > > > > Hmm,

Re: [Qemu-devel] [PATCH v5 2/3] ppc: Fix duplicated typedefs to be able to compile with Clang in gnu99 mode

2019-01-16 Thread Cédric Le Goater
On 1/11/19 9:17 AM, Thomas Huth wrote: > When compiling the ppc code with clang and -std=gnu99, there are a > couple of warnings/errors like this one: > > CC ppc64-softmmu/hw/intc/xics.o > In file included from hw/intc/xics.c:35: > include/hw/ppc/xics.h:43:25: error: redefinition of typedef

Re: [Qemu-devel] [PATCH v5 2/3] ppc: Fix duplicated typedefs to be able to compile with Clang in gnu99 mode

2019-01-16 Thread Thomas Huth
On 2019-01-16 12:43, Cédric Le Goater wrote: > On 1/11/19 9:17 AM, Thomas Huth wrote: >> When compiling the ppc code with clang and -std=gnu99, there are a >> couple of warnings/errors like this one: >> >> CC ppc64-softmmu/hw/intc/xics.o >> In file included from hw/intc/xics.c:35: >> include

Re: [Qemu-devel] [PATCH RFC 00/10] qdev: Hotplug handler chaining + virtio-pmem

2019-01-16 Thread David Hildenbrand
On 16.01.19 12:35, David Hildenbrand wrote: > This series implements supprt for hotplug handler chaining (proposed > by Igor), something that is necessary to turn selected virtio devices into > memory devices. Planned devices inlude virtio-mem and virtio-pmem. The > current prototype of virtio-pmem

Re: [Qemu-devel] [PATCH qemu 0/2] linux-headers: Update to v5.0-rc2

2019-01-16 Thread Paolo Bonzini
On 16/01/19 12:47, Cornelia Huck wrote: > On Wed, 16 Jan 2019 15:17:10 +1100 > Alexey Kardashevskiy wrote: > >> Here is the update script update and what it did to the v5.0-rc2 kernel. >> >> This is based on sha1 >> a0a8bff Greg Kurz "target/ppc/kvm: Drop useless include directive". >> >> Please

Re: [Qemu-devel] [PATCH qemu 0/2] linux-headers: Update to v5.0-rc2

2019-01-16 Thread Cornelia Huck
On Wed, 16 Jan 2019 15:17:10 +1100 Alexey Kardashevskiy wrote: > Here is the update script update and what it did to the v5.0-rc2 kernel. > > This is based on sha1 > a0a8bff Greg Kurz "target/ppc/kvm: Drop useless include directive". > > Please comment. Thanks. Hm, Paolo had already posted an

Re: [Qemu-devel] [PATCH 03/15] hw/ssi: Remove SSIBus from "qemu/typedefs.h"

2019-01-16 Thread Paolo Bonzini
On 16/01/19 12:34, Gerd Hoffmann wrote: > Hi, > >> typedefs.h is useful to avoid rebuilding the world too often if a type >> is used many times as a pointer, but rarely as a struct and rarely has >> functions called on its instances. > > Related: Can also be used to keep struct content private

Re: [Qemu-devel] [RFC PATCH v2 26/37] scsi: express dependencies with Kconfig

2019-01-16 Thread Thomas Huth
On 2019-01-15 15:10, Yang Zhong wrote: > From: Paolo Bonzini > > This lets you disable SCSI altogether with "CONFIG_SCSI=n". Sorry for my ignorant question, but: Can we really disable SCSI if the Kconfig files use "select SCSI" all over the place? I'd rather expect that "CONFIG_SCSI=n" only work

Re: [Qemu-devel] [PATCH 10/14] tests: acpi: ignore SMBIOS tests when UEFI firmware is used

2019-01-16 Thread Gerd Hoffmann
Hi, > This approach allows the UEFI app source to live in the QEMU tree, and > the affected maintainer(s) would be personally responsible for setting > up their edk2 clones, and compilers. (The edk2 clone could even be a > submodule of QEMU, for example at roms/edk2.) For example, > "roms/Makefi

Re: [Qemu-devel] [Qemu-ppc] [PATCH qemu] spapr: Fix fdt warnings

2019-01-16 Thread BALATON Zoltan
On Wed, 16 Jan 2019, Richard Henderson wrote: On 1/16/19 3:19 PM, Alexey Kardashevskiy wrote: because TARGET_FMT_lx is defined as "%016"PRIx64. This uses simple "%lx" to suppress the warning. Since it is spapr which is always 64bit, we assume here that hwaddr is always "long". This file is no

[Qemu-devel] [PATCH] xen: Fix format string

2019-01-16 Thread Philippe Mathieu-Daudé
Trivial format string fix to solve: hw/block/xen-block.c: In function 'xen_block_realize': hw/block/xen-block.c:218:53: error: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type 'int64_t {aka long long int}' [-Werror=format=] xen_device_backend_printf(xe

Re: [Qemu-devel] [PATCH] xen: Fix format string

2019-01-16 Thread Paul Durrant
> -Original Message- > From: Philippe Mathieu-Daudé [mailto:phi...@redhat.com] > Sent: 16 January 2019 12:01 > To: qemu-devel@nongnu.org > Cc: Paul Durrant ; Anthony Perard > ; Max Reitz ; qemu- > bl...@nongnu.org; Stefano Stabellini ; xen- > de...@lists.xenproject.org; Kevin Wolf ; Philipp

Re: [Qemu-devel] [PATCH] egl-helpers.h: do not depend on X11 Window type, use EGLNativeWindowType

2019-01-16 Thread Philippe Mathieu-Daudé
Cc'ing Gerd again. $ ./scripts/get_maintainer.pl -f include/ui/egl-helpers.h Gerd Hoffmann (odd fixer:Graphics) qemu-devel@nongnu.org (open list:All patches CC here) On 1/16/19 12:37 PM, Alexander Kanavin wrote: > It was assumed that mesa provides the necessary X11 includes, > but it is not alwa

[Qemu-devel] [PATCH] hw/block/xen: use proper format string for printing sectors

2019-01-16 Thread Alex Bennée
The %lu format string is different depending on the host architecture which causes builds like the debian-armhf-cross build to fail. Use the correct PRi64 format string. Signed-off-by: Alex Bennée --- hw/block/xen-block.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/blo

Re: [Qemu-devel] [PATCH] xen: Fix format string

2019-01-16 Thread Paul Durrant
> -Original Message- > From: Xen-devel [mailto:xen-devel-boun...@lists.xenproject.org] On Behalf > Of Paul Durrant > Sent: 16 January 2019 12:04 > To: 'Philippe Mathieu-Daudé' ; qemu-devel@nongnu.org > Cc: Kevin Wolf ; Stefano Stabellini > ; qemu-bl...@nongnu.org; Max Reitz > ; Anthony Pera

Re: [Qemu-devel] [PATCH] hw/block/xen: use proper format string for printing sectors

2019-01-16 Thread Paul Durrant
> -Original Message- > From: Alex Bennée [mailto:alex.ben...@linaro.org] > Sent: 16 January 2019 12:14 > To: peter.mayd...@linaro.org > Cc: qemu-devel@nongnu.org; Alex Bennée ; Stefano > Stabellini ; Anthony Perard > ; Paul Durrant ; Kevin > Wolf ; Max Reitz ; open list:X86 > ; open list:Bl

Re: [Qemu-devel] [PATCH 10/14] tests: acpi: ignore SMBIOS tests when UEFI firmware is used

2019-01-16 Thread Igor Mammedov
On Wed, 16 Jan 2019 12:09:03 +0100 Laszlo Ersek wrote: > On 01/16/19 12:07, Laszlo Ersek wrote: > > +Gerd > > > > On 01/16/19 11:32, Igor Mammedov wrote: > >> On Tue, 15 Jan 2019 21:31:54 +0100 > >> Laszlo Ersek wrote: > >> > >>> On 01/15/19 16:41, Igor Mammedov wrote: > once FW prov

Re: [Qemu-devel] [PATCH] .cirrus.yml: basic compile and test for FreeBSD

2019-01-16 Thread Alex Bennée
Ed Maste writes: > From: Ed Maste > > Cirrus-CI (https://cirrus-ci.org) is a hosted CI service which supports > several platforms, including FreeBSD. Later on we could build for other > hosts in Cirrus-CI, but I'm starting with only FreeBSD as it is not > supported by other CI services. Do y

Re: [Qemu-devel] [PATCH 11/14] tests: acpi: add AVMF firmware blobs

2019-01-16 Thread Igor Mammedov
On Tue, 15 Jan 2019 21:47:49 +0100 Laszlo Ersek wrote: > On 01/15/19 16:41, Igor Mammedov wrote: > > Add firmware blobs built with PcdAcpiTestSupport=TRUE, > > that puts RSDP address in RAM after 1Mb aligned GUID > > AB87A6B1-2034-BDA0-71BD-375007757785 > > so that tests could scan and find it

Re: [Qemu-devel] [PATCH 10/14] tests: acpi: ignore SMBIOS tests when UEFI firmware is used

2019-01-16 Thread Igor Mammedov
On Wed, 16 Jan 2019 12:52:17 +0100 Gerd Hoffmann wrote: > Hi, > > > This approach allows the UEFI app source to live in the QEMU tree, and > > the affected maintainer(s) would be personally responsible for setting > > up their edk2 clones, and compilers. (The edk2 clone could even be a > > sub

  1   2   3   4   >