> -----Original Message----- > From: Philippe Mathieu-Daudé [mailto:phi...@redhat.com] > Sent: 16 January 2019 12:01 > To: qemu-devel@nongnu.org > Cc: Paul Durrant <paul.durr...@citrix.com>; Anthony Perard > <anthony.per...@citrix.com>; Max Reitz <mre...@redhat.com>; qemu- > bl...@nongnu.org; Stefano Stabellini <sstabell...@kernel.org>; xen- > de...@lists.xenproject.org; Kevin Wolf <kw...@redhat.com>; Philippe > Mathieu-Daudé <phi...@redhat.com> > Subject: [PATCH] xen: Fix format string > > Trivial format string fix to solve: > > hw/block/xen-block.c: In function 'xen_block_realize': > hw/block/xen-block.c:218:53: error: format '%lu' expects argument of > type 'long unsigned int', but argument 4 has type 'int64_t {aka long long > int}' [-Werror=format=] > xen_device_backend_printf(xendev, "sectors", "%lu", > ^ > blk_getlength(conf->blk) / > conf->logical_block_size); > > blk_getlength() returns an int64_t. > > Signed-off-by: Philippe Mathieu-Daudé <phi...@redhat.com>
Reviewed-by: Paul Durrant <paul.durr...@citrix.com> > --- > hw/block/xen-block.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/block/xen-block.c b/hw/block/xen-block.c > index be28b63442..3cf215b730 100644 > --- a/hw/block/xen-block.c > +++ b/hw/block/xen-block.c > @@ -215,7 +215,7 @@ static void xen_block_realize(XenDevice *xendev, Error > **errp) > > xen_device_backend_printf(xendev, "sector-size", "%u", > conf->logical_block_size); > - xen_device_backend_printf(xendev, "sectors", "%lu", > + xen_device_backend_printf(xendev, "sectors", "%lld", > blk_getlength(conf->blk) / > conf->logical_block_size); > > -- > 2.17.2
