Re: [Qemu-devel] [PATCH v2 10/13] spapr_irq: Expose the phandle of the interrupt controller

On 1/11/19 10:04 PM, Greg Kurz wrote: > This will be used by PHB hotplug in order to create the "interrupt-map" > property of the PHB node. > > Signed-off-by: Greg Kurz > --- > hw/intc/spapr_xive.c| 34 -- > hw/intc/xics_spapr.c| 28 +++

[Qemu-devel] [GIT PULL for qemu-pseries] pseries: Update SLOF firmware image

The following changes since commit 27df21ca3886fff4dd3d70e515517667963a52f1: Merge remote-tracking branch 'remotes/kraxel/tags/misc-20190111-pull-request' into staging (2019-01-11 16:45:59 +) are available in the Git repository at: g...@github.com:aik/qemu.git tags/qemu-slo

Re: [Qemu-devel] [PATCH v2 11/13] spapr_irq: Allow synchronization of a single irq state to KVM

On 1/11/19 10:04 PM, Greg Kurz wrote: > When using the in-kernel interrupt controller, the state of all irqs is > synchronized to KVM at machine reset time. In the case of PHB hotplug, we > will need to synchronize LSIs manually. Yes. This is because the interrupt sources in the KVM XICS device ha

Re: [Qemu-devel] [PATCH v3 1/8] nbd: Add some error case testing to iotests 223

11.01.2019 22:47, Eric Blake wrote: > Testing success paths is important, but it's also nice to highlight > expected failure handling, to show that we don't crash, and so that > upcoming tests that change behavior can demonstrate the resulting > effects on error paths. > > Add the following errors

Re: [Qemu-devel] [PATCH v9 10/21] qapi: introduce replay.json for record/replay-related stuff

> From: Markus Armbruster [mailto:arm...@redhat.com] > Pavel Dovgalyuk writes: > > > This patch adds replay.json file. It will be > > used for adding record/replay-related data structures and commands. > > > > Signed-off-by: Pavel Dovgalyuk > > --- > > MAINTAINERS |1 + > > Make

Re: [Qemu-devel] [PATCH v3 2/8] nbd: Forbid nbd-server-stop when server is not running

11.01.2019 22:47, Eric Blake wrote: > Since we already forbid other nbd-server commands when not > in the right state, it is unlikely that any caller was relying > on a second stop to behave as a silent no-op. Update iotest > 223 to show the improved behavior. > > Signed-off-by: Eric Blake Rev

Re: [Qemu-devel] [PATCH 02/15] hw/pcmcia: Remove PCMCIACardState from "qemu/typedefs.h"

On 2019-01-11 15:08, Philippe Mathieu-Daudé wrote: > From: Philippe Mathieu-Daudé > > There is only one file requiring this typedef (hw/arm/pxa.h), I'd suggest to replace "file" with "header file" here. Reviewed-by: Thomas Huth > let it include "hw/pcmcia.h" directly to simplify "qemu/typedef

Re: [Qemu-devel] [PATCH] hw/vfio/common: Refactor container initialization

Hi Alexey, On 1/14/19 7:32 AM, Alexey Kardashevskiy wrote: > > > On 12/01/2019 03:45, Eric Auger wrote: >> In vfio_connect_container() the code that selects the >> iommu type can benefit from helpers such as >> vfio_iommu_get_type() and vfio_init_container(). As >> a result we end up with a swit

Re: [Qemu-devel] [PATCH 03/15] hw/ssi: Remove SSIBus from "qemu/typedefs.h"

On 2019-01-11 15:08, Philippe Mathieu-Daudé wrote: > From: Philippe Mathieu-Daudé > > There are only three files requiring this typedef, let them s/files/header files/ Reviewed-by: Thomas Huth > include "hw/ssi/ssi.h" directly to simplify "qemu/typedefs.h". > > To clean "qemu/typedefs.h", mo

Re: [Qemu-devel] [PATCH 04/15] hw/ide/ahci: Remove AllwinnerAHCIState from "qemu/typedefs.h"

On 2019-01-11 15:08, Philippe Mathieu-Daudé wrote: > From: Philippe Mathieu-Daudé > > Files requiring AllwinnerAHCIState already include "hw/ide/ahci.h". > > To clean "qemu/typedefs.h", move the declaration to "hw/ide/ahci.h" > (removing the forward declaration). > > Signed-off-by: Philippe Mat

Re: [Qemu-devel] [PATCH] hw/vfio/common: Refactor container initialization

On Mon, 14 Jan 2019 09:34:12 +0100 Auger Eric wrote: > Hi Alexey, > > On 1/14/19 7:32 AM, Alexey Kardashevskiy wrote: > > > > > > On 12/01/2019 03:45, Eric Auger wrote: > >> In vfio_connect_container() the code that selects the > >> iommu type can benefit from helpers such as > >> vfio_iommu

Re: [Qemu-devel] [PATCH 10/15] range: Remove Range from "qemu/typedefs.h"

On 2019-01-11 15:08, Philippe Mathieu-Daudé wrote: > Range is only used in "hw/pci-host/q35.h" in the MCHPCIState, and > in "hw/pci/pci.h" by pci_bus_get_w64_range(). Let them include > "qemu/range.h" directly to simplify "qemu/typedefs.h". > > To clean "qemu/typedefs.h", move the declaration to

Re: [Qemu-devel] [PATCH v9 11/21] replay: introduce info hmp/qmp command

> From: Markus Armbruster [mailto:arm...@redhat.com] > Pavel Dovgalyuk writes: > > diff --git a/replay/replay-debugging.c b/replay/replay-debugging.c > > new file mode 100644 > > index 000..9956405 > > --- /dev/null > > +++ b/replay/replay-debugging.c > > The file name suggests the instruct

[Qemu-devel] [PATCH] QGA: Fix guest-get-fsinfo PCI address collection in Windows

From: Matt Hines Signed-off-by: Matt Hines --- configure| 2 +- qga/commands-win32.c | 295 +-- qga/qapi-schema.json | 3 +- 3 files changed, 197 insertions(+), 103 deletions(-) diff --git a/configure b/configure index 5b1d83ea26.

Re: [Qemu-devel] [PATCH 12/15] ui/console: Remove MouseTransformInfo from qemu/typedefs.h

On 2019-01-11 15:08, Philippe Mathieu-Daudé wrote: > MouseTransformInfo is only used in "ui/console.h", there is no > need to expose it via "qemu/typedefs.h". You also touch devices.h here ... that should be mentioned, too? Thomas > Move the declaration to "ui/console.h" (removing the forward

Re: [Qemu-devel] [PATCH v7] s390x/pci: add common function measurement block

On 09/01/2019 12:43, David Hildenbrand wrote: On 09.01.19 12:29, David Hildenbrand wrote: On 08.01.19 18:37, Pierre Morel wrote: From: Yi Min Zhao Common function measurement block is used to report zPCI internal counters of successful pcilg/stg/stb and rpcit instructions to a memory location

Re: [Qemu-devel] [PATCH v7] s390x/pci: add common function measurement block

On 14.01.19 10:18, Pierre Morel wrote: > On 09/01/2019 12:43, David Hildenbrand wrote: >> On 09.01.19 12:29, David Hildenbrand wrote: >>> On 08.01.19 18:37, Pierre Morel wrote: From: Yi Min Zhao Common function measurement block is used to report zPCI internal counters of succe

Re: [Qemu-devel] Internship idea: virtio-blk oss-fuzz support

On Fri, Jan 11, 2019 at 05:16:40PM +0100, Paolo Bonzini wrote: > On 11/01/19 16:41, Max Moroz wrote: > > On Fri, Jan 11, 2019 at 7:34 AM Paolo Bonzini > > wrote: > > > > On 11/01/19 16:04, Max Moroz wrote: > > > We usually have a single fuzzing process, it star

[Qemu-devel] [Bug 1811653] [NEW] usbredir slow when multi bulk packet per second

Public bug reported: QEMU Ver: all version Client: virt-viewer by spice Guest VM: win7 Bug description:   Use Qemu 2.1 or later with usbredir, When I redirect a bulk usb-device from virt-viewer client,the bulk-usb-device driver or app in GuestVM will send 50 bulk-urb per times.   In VM, using th

Re: [Qemu-devel] [PATCH v7] s390x/pci: add common function measurement block

On 14/01/2019 10:23, David Hildenbrand wrote: On 14.01.19 10:18, Pierre Morel wrote: On 09/01/2019 12:43, David Hildenbrand wrote: On 09.01.19 12:29, David Hildenbrand wrote: On 08.01.19 18:37, Pierre Morel wrote: From: Yi Min Zhao Common function measurement block is used to report zPCI in

Re: [Qemu-devel] [PATCH v9 13/21] replay: implement replay-seek command to proceed to the desired step

> From: Markus Armbruster [mailto:arm...@redhat.com] > Pavel Dovgalyuk writes: > > > This patch adds hmp/qmp commands replay_seek/replay-seek that proceed > > the execution to the specified step. > > The command automatically loads nearest snapshot and replay the execution > > to find the desired

Re: [Qemu-devel] [PATCH] QGA: Fix guest-get-fsinfo PCI address collection in Windows

Patchew URL: https://patchew.org/QEMU/20190114090324.16176-1-mhi...@scalecomputing.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190114090324.16176-1-mhi...@scalecomputing.com Subject: [Qemu-devel] [PATCH] QGA: Fix guest-ge

[Qemu-devel] [Bug 1811653] Re: usbredir slow when multi bulk packet per second

** Description changed: QEMU Ver: all version Client: virt-viewer by spice Guest VM: win7 Bug description:   Use Qemu 2.1 or later with usbredir, When I redirect a bulk usb-device from virt-viewer client,the bulk-usb-device driver or app in GuestVM will send 50 bulk-urb per times. -   

Re: [Qemu-devel] [PATCH v7] s390x/pci: add common function measurement block

On Mon, 14 Jan 2019 10:23:58 +0100 David Hildenbrand wrote: > On 14.01.19 10:18, Pierre Morel wrote: > > On 09/01/2019 12:43, David Hildenbrand wrote: > >> On 09.01.19 12:29, David Hildenbrand wrote: > >>> On 08.01.19 18:37, Pierre Morel wrote: > From: Yi Min Zhao > > Common

[Qemu-devel] [Bug 1523246] Re: Virtio-blk does not support TRIM

While the Linux virtio-blk guest driver now supports discard and write zeroes, QEMU's virtio-blk device emulation does not support it yet. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1523246 Title:

Re: [Qemu-devel] [QEMU-devel][PATCH v4 0/2] Fix concurrent aio_poll/set_fd_handler.

On Sat, Jan 12, 2019 at 08:30:08AM +, Stefan Hajnoczi wrote: Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block Thanks ! Remy

Re: [Qemu-devel] [PATCH v3 3/8] nbd: Only require disabled bitmap for read-only exports

11.01.2019 22:47, Eric Blake wrote: > Our initial implementation of x-nbd-server-add-bitmap put > in a restriction because of incremental backups: in that > usage, we are exporting one qcow2 file (the temporary overlay > target of a blockdev-backup sync:none job) and a dirty bitmap > owned by a sec

Re: [Qemu-devel] [PATCH 4/4] hw/i386/pc: use PVH option rom

On Fri, Jan 11, 2019 at 5:34 PM Stefan Hajnoczi wrote: > > On Fri, Jan 11, 2019 at 02:18:36PM +0100, Stefano Garzarella wrote: > > Use pvh.bin option rom when we are booting an uncompressed > > kernel using the x86/HVM direct boot ABI. > > > > Signed-off-by: Stefano Garzarella > > Based-on: <1545

Re: [Qemu-devel] [PATCH v3 0/5] kvm "virtio pmem" device

On Sat 12-01-19 21:17:46, Pankaj Gupta wrote: > > > > Right. Thinking about this I would be more concerned about the fact that > > > > guest can effectively pin amount of host's page cache upto size of the > > > > device/file passed to guest as PMEM, can't it Pankaj? Or is there some > > > > QEMU >

[Qemu-devel] [PULL 00/25] ivshmem deprecation, qtests, typedefs and gnu99

Hi Peter, the following changes since commit 27df21ca3886fff4dd3d70e515517667963a52f1: Merge remote-tracking branch 'remotes/kraxel/tags/misc-20190111-pull-request' into staging (2019-01-11 16:45:59 +) are available in the git repository at: https://gitlab.com/huth/qemu.git tags/pull-

[Qemu-devel] [PULL 05/25] tests/Makefile: Use some more CONFIG switches for x86 tests

To be able to build and test QEMU binaries where certain devices are disabled, we have to use the right CONFIG_* switches to run certain tests only if the corresponding device really has been compiled into the binary. Signed-off-by: Thomas Huth --- tests/Makefile.include | 10 +- 1 file

[Qemu-devel] [PULL 06/25] tests/Makefile: Use some more CONFIG switches for ppc tests

To be able to build and test QEMU binaries where certain devices or machines are disabled, we have to use the right CONFIG_* switches to run certain tests only if the corresponding device or machine really has been compiled into the binary. Reviewed-by: Wainer dos Santos Moschetta Signed-off-by:

[Qemu-devel] [PULL 02/25] tests: vhost-user-test: initialize 'fd' in chr_read

From: Li Qiang Currently when processing VHOST_USER_SET_VRING_CALL if 'qemu_chr_fe_get_msgfds' get no fd, the 'fd' will be a stack uninitialized value. Signed-off-by: Li Qiang Reviewed-by: Thomas Huth Reviewed-by: Michael S. Tsirkin Signed-off-by: Thomas Huth --- tests/vhost-user-test.c | 2

[Qemu-devel] [PULL 10/25] hw/input/ps2: Remove PS2State from "qemu/typedefs.h"

From: Philippe Mathieu-Daudé PS2State is only used in "hw/input/ps2.h", there is no need to expose it via "qemu/typedefs.h". To clean "qemu/typedefs.h", move the forward declaration to "hw/input/ps2.h". Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Signed-off-by: Thomas Huth

[Qemu-devel] [PULL 03/25] vhost-user: fix ioeventfd_enabled

From: Li Qiang Currently, the vhost-user-test assumes the eventfd is available. However it's not true because the accel is qtest. So the 'vhost_set_vring_file' will not add fds to the msg and the server side of vhost-user-test will be broken. The bug is in 'ioeventfd_enabled'. We should make this

[Qemu-devel] [PULL 09/25] tests/pnv-xscom: Make test independent of global_qtest

Pass around the QTestState, so that we can finally get rid of the out-of-favor global_qtest variable in this file, too. Signed-off-by: Thomas Huth --- tests/pnv-xscom-test.c | 29 +++-- 1 file changed, 15 insertions(+), 14 deletions(-) diff --git a/tests/pnv-xscom-test.c

[Qemu-devel] [PULL 18/25] audio: Remove AudioState from "qemu/typedefs.h"

From: Philippe Mathieu-Daudé Files requiring AudioState already include "audio_int.h". To clean "qemu/typedefs.h", move the declaration to "audio_int.h" (removing the forward declaration). Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- audio/audio_int.h | 4 ++--

[Qemu-devel] [PULL 04/25] util: check the return value of fcntl in qemu_set_{block, nonblock}

From: Li Qiang Assert that the return value is not an error. This is like commit 7e6478e7d4f for qemu_set_cloexec. Signed-off-by: Li Qiang Reviewed-by: Thomas Huth Signed-off-by: Thomas Huth --- util/oslib-posix.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/ut

[Qemu-devel] [PULL 16/25] hw/char/serial: Remove SerialState from "qemu/typedefs.h"

From: Philippe Mathieu-Daudé Files requiring SerialState already include "hw/char/serial.h". To clean "qemu/typedefs.h", move the declaration to "hw/char/serial.h" (removing the forward declaration). Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- include/hw/char/serial.

[Qemu-devel] [PULL 01/25] hw/misc/ivshmem: Remove deprecated "ivshmem" legacy device

It's been marked as deprecated in QEMU v2.6.0 already, so really nobody should use the legacy "ivshmem" device anymore (but use ivshmem-plain or ivshmem-doorbell instead). Time to remove the deprecated device now. Belatedly also update a mention of the deprecated "ivshmem" in the file docs/specs/i

[Qemu-devel] [PULL 17/25] hw/i386: Remove PCMachineClass from "qemu/typedefs.h"

From: Philippe Mathieu-Daudé Files requiring PCMachineClass already include "hw/i386/pc.h". To clean "qemu/typedefs.h", move the declaration to "hw/i386/pc.h" (removing the forward declaration). Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- include/hw/i386/pc.h| 4

Re: [Qemu-devel] [PATCH v1] s390x/pci: Send correct event on hotplug.

On 11/01/2019 10:38, Cornelia Huck wrote: On Fri, 11 Jan 2019 08:16:41 +0100 David Hildenbrand wrote: On 10.01.19 22:03, David Hildenbrand wrote: Comit 2c28c490571f ("s390x/pci: let pci devices start in configured mode") changed the initial state of zPCI devices from ZPCI_FS_STANDBY to ZPCI_F

[Qemu-devel] [PULL 07/25] tests/endianesss: Make test independent of global_qtest

Pass around the test state explicitly, to be able to use the qtest_in*() and qtest_out*() function in this test. Signed-off-by: Thomas Huth --- tests/endianness-test.c | 329 1 file changed, 166 insertions(+), 163 deletions(-) diff --git a/tests/

[Qemu-devel] [PULL 13/25] hw/ide/ahci: Remove AllwinnerAHCIState from "qemu/typedefs.h"

From: Philippe Mathieu-Daudé Files requiring AllwinnerAHCIState already include "hw/ide/ahci.h". To clean "qemu/typedefs.h", move the declaration to "hw/ide/ahci.h" (removing the forward declaration). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Signed-off-by: Thomas Huth -

[Qemu-devel] [PULL 24/25] configure: Force the C standard to gnu99

Different versions of GCC and Clang use different versions of the C standard. This repeatedly caused problems already, e.g. with duplicated typedefs: https://lists.gnu.org/archive/html/qemu-devel/2018-11/msg05829.html or with for-loop variable initializers: https://lists.gnu.org/archive/html/q

[Qemu-devel] [PULL 08/25] tests/boot-order: Make test independent of global_qtest

Pass around the QTestState from function to function, so that we can finally get rid of the out-of-favor global_qtest variable in this file, too. Signed-off-by: Thomas Huth --- tests/boot-order-test.c | 59 - 1 file changed, 29 insertions(+), 30 de

[Qemu-devel] [PULL 11/25] hw/pcmcia: Remove PCMCIACardState from "qemu/typedefs.h"

From: Philippe Mathieu-Daudé There is only one header file requiring this typedef (hw/arm/pxa.h), let it include "hw/pcmcia.h" directly to simplify "qemu/typedefs.h". To clean "qemu/typedefs.h", move the declaration to "hw/pcmcia.h" (removing the forward declaration). Signed-off-by: Philippe Ma

Re: [Qemu-devel] [PATCH v4] tests: vm: auto_install OpenBSD

On Mon, Jan 14, 2019 at 11:50:08AM +0800, Fam Zheng wrote: > > > > On Jan 9, 2019, at 21:59, Daniel P. Berrangé wrote: > > > > On Wed, Jan 09, 2019 at 01:55:04PM +, Daniel P. Berrangé wrote: > >> On Wed, Nov 14, 2018 at 05:58:07PM +0800, Fam Zheng wrote: > >>> On Sun, 11/11 18:20, Brad Smit

[Qemu-devel] [PULL 23/25] ppc: Fix duplicated typedefs to be able to compile with Clang in gnu99 mode

When compiling the ppc code with clang and -std=gnu99, there are a couple of warnings/errors like this one: CC ppc64-softmmu/hw/intc/xics.o In file included from hw/intc/xics.c:35: include/hw/ppc/xics.h:43:25: error: redefinition of typedef 'ICPState' is a C11 feature [-Werror,-Wtype

[Qemu-devel] [PULL 20/25] ui/console: Remove DisplayState/DisplaySurface from "qemu/typedefs.h"

From: Philippe Mathieu-Daudé Files requiring DisplayState/DisplaySurface already include "ui/console.h". To clean "qemu/typedefs.h", move the declarations to "ui/console.h" (removing DisplaySurface forward declaration). Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- inc

[Qemu-devel] [PULL 14/25] hw/i2c/smbus: Remove SMBusDevice from "qemu/typedefs.h"

From: Philippe Mathieu-Daudé Files requiring SMBusDevice already include "hw/i2c/smbus.h". To clean "qemu/typedefs.h", move the forward declaration to "hw/i2c/smbus.h". Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- include/hw/i2c/smbus.h | 2 ++ include/qemu/typedefs.

[Qemu-devel] [PULL 25/25] tests/hexloader-test: Don't pass -nographic to the QEMU under test

From: Peter Maydell The hexloader test invokes QEMU with the -nographic argument. This is unnecessary, because the qtest_initf() function will pass it -display none, which suffices to disable the graphical window. It also means that the QEMU process will make the stdin/stdout O_NONBLOCK. Since O_

[Qemu-devel] [PULL 12/25] hw/ssi: Remove SSIBus from "qemu/typedefs.h"

From: Philippe Mathieu-Daudé There are only three header files requiring this typedef, let them include "hw/ssi/ssi.h" directly to simplify "qemu/typedefs.h". To clean "qemu/typedefs.h", move the forward declaration to "hw/ssi/ssi.h". Signed-off-by: Philippe Mathieu-Daudé [thuth: slightly twea

[Qemu-devel] [PULL 15/25] hw/bt: Remove HCIInfo from "qemu/typedefs.h"

From: Philippe Mathieu-Daudé Files requiring HCIInfo already include "sysemu/bt.h". To clean "qemu/typedefs.h", move the declaration to "sysemu/bt.h" (removing the forward declaration). Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- include/qemu/typedefs.h | 1 - includ

Re: [Qemu-devel] [PATCH v2 10/13] spapr_irq: Expose the phandle of the interrupt controller

On 1/14/19 11:03 AM, Greg Kurz wrote: > On Mon, 14 Jan 2019 09:11:47 +0100 > Cédric Le Goater wrote: > >> On 1/11/19 10:04 PM, Greg Kurz wrote: >>> This will be used by PHB hotplug in order to create the "interrupt-map" >>> property of the PHB node. >>> >>> Signed-off-by: Greg Kurz >>> --- >>>

[Qemu-devel] [PULL 19/25] ui/console: Remove QemuDmaBuf from "qemu/typedefs.h"

From: Philippe Mathieu-Daudé Files requiring QemuDmaBuf already include "ui/console.h". To clean "qemu/typedefs.h", move the declaration to "ui/console.h" (removing the forward declaration). Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- include/qemu/typedefs.h | 1 - i

Re: [Qemu-devel] [PATCH 3/4] accel/tcg: Add cluster number to TCG TB hash

On Mon, 14 Jan 2019 at 01:08, Aleksandar Markovic wrote: > > > > On Tuesday, January 8, 2019, Peter Maydell wrote: >> >> Include the cluster number in the hash we use to look >> up TBs. This is important because a TB that is valid >> for one cluster at a given physical address and set >> of CPU f

[Qemu-devel] [PULL 22/25] ppc: Move spapr-related prototypes from xics.h into a seperate header file

When compiling with Clang in -std=gnu99 mode, there is a warning/error: CC ppc64-softmmu/hw/intc/xics_spapr.o In file included from /home/thuth/devel/qemu/hw/intc/xics_spapr.c:34: /home/thuth/devel/qemu/include/hw/ppc/xics.h:203:34: error: redefinition of typedef 'sPAPRMachineState' is a C

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 02/13] spapr: Rename xics to intc in interrupt controller agnostic code

On Mon, 14 Jan 2019 08:58:26 +0100 Cédric Le Goater wrote: > On 1/11/19 10:00 PM, Greg Kurz wrote: > > All this code is used with both the XICS and XIVE interrupt controllers. > > I am not fond of the name : spapr_dt_intc_irq(), it seems a bit redundant. > Yeah, I guess it could be spapr_dt_

[Qemu-devel] [PULL 21/25] linux-user: Fix compilation with clang 3.4

Clang version 3.4.2 does not know the -Wpragmas option yet and bails out with an error when we try to disable it in linux-user/qemu.h. Fortunately, clang has a __has_warning() macro which allows us to add an explicit check for the option that we want to ignore. With that we can check for the availa

Re: [Qemu-devel] qemu-user-linux: how could I measure performance for aarch64 and arm?

пн, 14 янв. 2019 г. в 13:24, Peter Maydell : > > On Sun, 13 Jan 2019 at 07:31, Matwey V. Kornilov > wrote: > > > > пт, 11 янв. 2019 г. в 22:24, Matwey V. Kornilov : > > > Indeed, qemu-arm from master runs for 4 minutes where 2.11 runs for 2 > > > hours for me. It is impressive improvement. > > > >

Re: [Qemu-devel] [PATCH v3 0/5] kvm "virtio pmem" device

> > > > > Right. Thinking about this I would be more concerned about the fact > > > > > that > > > > > guest can effectively pin amount of host's page cache upto size of > > > > > the > > > > > device/file passed to guest as PMEM, can't it Pankaj? Or is there > > > > > some > > > > > QEMU > > > >

Re: [Qemu-devel] [PATCH v2 10/13] spapr_irq: Expose the phandle of the interrupt controller

On Mon, 14 Jan 2019 09:11:47 +0100 Cédric Le Goater wrote: > On 1/11/19 10:04 PM, Greg Kurz wrote: > > This will be used by PHB hotplug in order to create the "interrupt-map" > > property of the PHB node. > > > > Signed-off-by: Greg Kurz > > --- > > hw/intc/spapr_xive.c| 34 +

Re: [Qemu-devel] [PATCH v4] tests: vm: auto_install OpenBSD

On Mon, 14 Jan 2019 at 10:20, Daniel P. Berrangé wrote: > If you don't have SDL then there's no audio driver impl available for > QEMU, so configure fails with: > > ERROR: sdl not found or disabled, can not use sdl audio driver Ideally we should fix configure/the audio driver selection logic so

Re: [Qemu-devel] [PULL 0/2] Vga 20190111 patches

On Fri, 11 Jan 2019 at 14:00, Gerd Hoffmann wrote: > > The following changes since commit a311f891abf3833c1e4c5a62a6e5b0f1b81f22c3: > > Merge remote-tracking branch > 'remotes/vivier2/tags/linux-user-for-4.0-pull-request' into staging > (2019-01-10 17:49:54 +) > > are available in the git

Re: [Qemu-devel] [PATCH v16 5/6] acpi: add ACPI memory clear interface

On Wed, 9 Jan 2019 23:31:14 +0400 Marc-André Lureau wrote: > The interface is described in the "TCG Platform Reset Attack > Mitigation Specification", chapter 6 "ACPI _DSM Function". According I'd add a spec version here as well adn maybe a link like it's in 4/6 (but links are often go stale so

Re: [Qemu-devel] [RFC PATCH 15/15] ui/console: Add "ui/pixelformat.h" to declare PixelFormat

On 1/11/19 6:32 PM, Paolo Bonzini wrote: > On 11/01/19 15:08, Philippe Mathieu-Daudé wrote: >> PixelFormat is used by "ui/console.h" and by "ui/qemu-pixman.h". > > ui/console.h already includes ui/qemu-pixman.h, just move it there? That was my first though but then noticed pixman seems a bit diff

Re: [Qemu-devel] Remaining CI failures

On Fri, 11 Jan 2019 at 19:10, Alex Bennée wrote: > I did run the make under strace to see who is using O_NONBLOCK but even > after filtering out a bunch of stuff it seems to be quite embedded: > > ag "O_NONBLOCK" check.strace | ag -v "/sys" | ag -v "/dev" | grep -v ".git" > | wc -l > 2449 The

Re: [Qemu-devel] [Qemu-ppc] [PATCH] smbus: Remove unneeded include

On 2019-01-12 02:32, BALATON Zoltan wrote: > The file no longer uses error_report after review so the header is not > needed either. > > Signed-off-by: BALATON Zoltan > --- > Forgot to delete this when rewriting after review. This > can be squashed into 7713f5bed in dgibson/qemu/ppc-for-4.0 > >

Re: [Qemu-devel] [PATCH v4 for-4.0 0/7] vhost-user-blk: Add support for backend reconnecting

On Sat, Jan 12, 2019 at 12:50:12PM +0800, Yongji Xie wrote: > On Fri, 11 Jan 2019 at 23:53, Stefan Hajnoczi wrote: > > > > On Thu, Jan 10, 2019 at 06:59:27PM +0800, Yongji Xie wrote: > > > On Thu, 10 Jan 2019 at 18:25, Stefan Hajnoczi wrote: > > > > > > > > On Wed, Jan 09, 2019 at 07:27:21PM +080

Re: [Qemu-devel] [PATCH v16 5/6] acpi: add ACPI memory clear interface

Hi On Mon, Jan 14, 2019 at 2:17 PM Igor Mammedov wrote: > > On Wed, 9 Jan 2019 23:31:14 +0400 > Marc-André Lureau wrote: > > > The interface is described in the "TCG Platform Reset Attack > > Mitigation Specification", chapter 6 "ACPI _DSM Function". According > I'd add a spec version here as w

Re: [Qemu-devel] [PATCH 05/15] hw/nvram/fw_cfg: Remove various typedefs from "qemu/typedefs.h"

On 1/11/19 5:26 PM, Laszlo Ersek wrote: > On 01/11/19 15:08, Philippe Mathieu-Daudé wrote: >> There are only three files requiring these typedefs, let them >> include "hw/nvram/fw_cfg.h" directly to simplify "qemu/typedefs.h". >> >> To clean "qemu/typedefs.h", move the forward declarations >> to "h

[Qemu-devel] [PATCH v2 1/6] s390x/pci: Use hotplug_dev instead of looking up the host bridge

We directly have it in our hands. Signed-off-by: David Hildenbrand --- hw/s390x/s390-pci-bus.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390x/s390-pci-bus.c index 7f911b216a..86dda831f9 100644 --- a/hw/s390x/s390-pci-bus.c +++ b/hw/s390

Re: [Qemu-devel] qemu-user-linux: how could I measure performance for aarch64 and arm?

On Sun, 13 Jan 2019 at 07:31, Matwey V. Kornilov wrote: > > пт, 11 янв. 2019 г. в 22:24, Matwey V. Kornilov : > > Indeed, qemu-arm from master runs for 4 minutes where 2.11 runs for 2 > > hours for me. It is impressive improvement. > > I've managed to bisected the first good (fast) commit: > > com

Re: [Qemu-devel] [PATCH 10/15] range: Remove Range from "qemu/typedefs.h"

On 1/14/19 9:56 AM, Thomas Huth wrote: > On 2019-01-11 15:08, Philippe Mathieu-Daudé wrote: >> Range is only used in "hw/pci-host/q35.h" in the MCHPCIState, and >> in "hw/pci/pci.h" by pci_bus_get_w64_range(). Let them include >> "qemu/range.h" directly to simplify "qemu/typedefs.h". >> >> To clea

[Qemu-devel] [PATCH v2 2/6] s390x/pci: Move some hotplug checks to the pre_plug handler

Let's move most of the checks to the new pre_plug handler. As a PCI bridge is just a PCI device, we can simplify the code. Notes: We cannot yet move the MSIX check or device ID creation + zPCI device creation to the pre_plug handler as both parts are not fixed before actual device realization (and

Re: [Qemu-devel] [PATCH 0/2 v2] Break down the MTP write operation

On 1/11/19 11:44 AM, Gerd Hoffmann wrote: > On Fri, Jan 11, 2019 at 03:20:41AM -0500, Bandan Das wrote: >> v2: >> Rebased on top of master and retested > > Thanks. Added to usb queue. Hi Gerd, did you update MTP_WRITE_BUF_SZ as suggested by Eric? +#include "qemu/units.h" ... -#define MTP_WR

[Qemu-devel] [PATCH v2 3/6] s390x/pci: Always delete and free the release_timer

We should always get rid of it. I don't see a reason to keep the timer alive if the devices are going away. This looks like a memory leak. (hmp) device_add virtio-mouse-pci,id=test (hmp) device_del test -> guest notified, timer pending. -> guest does not react for some reason (e.g. crash) -> s390_

[Qemu-devel] [PATCH v2 0/6] s390x/pci: hotplug handler fixes and reworks

A bunch of fixes and reworks for s390x/pci hotplug infrastructure. Patch 1,2: Reworks already posted (pre_plug handler) Patch 3,4: Fixes for memory leaks Patch 5: Rework unplug handler (introduce unplug_request handler) which also fixes some unplug scenarios Patch 6: Handle leftover unplu

Re: [Qemu-devel] [PATCH 1/1] block: Eliminate the S_1KiB, S_2KiB, ... macros

On 1/13/19 10:41 AM, Leonid Bloch wrote: > On 1/11/19 9:14 PM, Markus Armbruster wrote: >> We define 54 macros for the powers of two >= 1024. We use six, in six >> macro definitions. Four of them could just as well use the common MiB >> macro, so do that. The remaining two can't, because they ge

[Qemu-devel] [PATCH v2 4/6] s390x/pci: Ignore the unplug call if we already have a release_timer

... otherwise two successive calls to qdev_unplug() (e.g. by an impatient user) will effectively overwrite pbdev->release_timer, resulting in a memory leak. We are already processing the unplug. If there is already a release_timer, the unplug will be performed after the timeout. Can be easily tri

[Qemu-devel] [PATCH v2 6/6] s390x/pci: Unplug remaining devices on pcihost reset

When resetting the guest we should unplug and remove all devices that are still pending. Otherwise the fresh guest will see devices that will suddenly vanish. Can be triggered e.g. via (hmp) device_add virtio-mouse-pci,id=test (hmp) stop (hmp) device_del test (hmp) system_reset (hmp) c The device

Re: [Qemu-devel] [PATCH] hw/misc/edu: add msi_uninit() for pci_edu_uninit()

On 1/14/19 8:18 AM, Peter Xu wrote: > On Mon, Jan 14, 2019 at 08:02:23AM +0100, Markus Armbruster wrote: >> Peter Xu writes: >> >>> On Sun, Jan 13, 2019 at 10:36:41PM +0800, Fei Li wrote: From: Fei Li Let's supplement the msi_uninit() when failing to realize the pci edu device

[Qemu-devel] [PATCH v2 5/6] s390x/pci: Introduce unplug requests and split unplug handler

PCI on s390x is really weird and how it was modeled in QEMU might not have been the right choice. Anyhow, right now it is the case that: - Hotplugging a PCI device will silently create a zPCI device (if none is provided) - Hotunplugging a zPCI device will unplug the PCI device (if any) - Hotunplu

Re: [Qemu-devel] [PATCH] smbus: Remove unneeded include

On 1/12/19 2:32 AM, BALATON Zoltan wrote: > The file no longer uses error_report after review so the header is not > needed either. > > Signed-off-by: BALATON Zoltan Reviewed-by: Philippe Mathieu-Daudé > --- > Forgot to delete this when rewriting after review. This > can be squashed into 7713f

Re: [Qemu-devel] [PATCH] vhost-user-blk: enable discard/write zeroes features

On Mon, Jan 14, 2019 at 03:35:17PM +0800, Changpeng Liu wrote: > Linux commit 1f23816b8 "virtio_blk: add discard and write zeroes support" > added the support in the Guest kernel, while here enable the feature bits > support with vhost-user-blk driver. Also enable the test example utility > with D

Re: [Qemu-devel] [PATCH v4 2/2] colo: compare the packet based on the tcp sequence number

On 2017-12-25 03:54, Mao Zhongyi wrote: > Packet size some time different or when network is busy. > Based on same payload size, but TCP protocol can not > guarantee send the same one packet in the same way, [...] > Signed-off-by: Mao Zhongyi > Signed-off-by: Li Zhijian > Signed-off-by: Zhang Che

Re: [Qemu-devel] [PATCH v2 1/1] riscv: Ensure the kernel start address is correctly cast

Hi Alistair, On 1/12/19 2:17 AM, Alistair Francis wrote: > Cast the kernel start address to the target bit length. > > This ensures that we calculate the initrd offset to a valid address for > the architecture. Can you add an example of the failure symptoms? > > Signed-off-by: Alistair Francis

Re: [Qemu-devel] [PATCH] file-posix: Check effective size in truncate operation

On 26.11.18 04:57, zhenwei pi wrote: > Function raw_co_truncate does not check effective size for BLK device file, > and QEMU may notify guest without any size changing. > > Two cases can be reproduced easily by qmp command: > CASE 1: > 1, create a logical volume(12M) by LVM, and guest uses this v

Re: [Qemu-devel] [PATCH v4 2/2] colo: compare the packet based on the tcp sequence number

On Mon, Jan 14, 2019, 6:34 PM Thomas Huth On 2017-12-25 03:54, Mao Zhongyi wrote: > > Packet size some time different or when network is busy. > > Based on same payload size, but TCP protocol can not > > guarantee send the same one packet in the same way, > [...] > > Signed-off-by: Mao Zhongyi >

Re: [Qemu-devel] [PATCH] hw/pvrdma: Make function pvrdma_qp_send/recv return void.

On 1/9/19 9:21 PM, Yuval Shaia wrote: > The functions handles errors internaly, callers have nothing to do with > the return value. > > Signed-off-by: Yuval Shaia Reviewed-by: Philippe Mathieu-Daudé > --- > hw/rdma/vmw/pvrdma_qp_ops.c | 14 ++ > hw/rdma/vmw/pvrdma_qp_ops.h | 4 ++

Re: [Qemu-devel] [PATCH v5 4/8] linux-user: Split out preadv, pwritev, readv, writev, pread64, pwrite64

On 11/01/2019 22:31, Richard Henderson wrote: On 1/11/19 2:17 AM, Laurent Vivier wrote: On 19/12/2018 05:21, Richard Henderson wrote: Signed-off-by: Richard Henderson --- linux-user/syscall-defs.h | 14 linux-user/syscall-file.inc.c | 124 ++ linux

[Qemu-devel] [RFC PATCH] tests: use g_usleep instead of rem = sleep(time)

Relying on sleep to always return having slept isn't safe as a signal may have occurred. If signals are constantly incoming the program will never reach it's termination condition. This is believed to be the mechanism causing time outs for qht-test in Travis. The glib g_usleep() deals with all of

[Qemu-devel] [Bug 1795100] Re: VNC unix-domain socket unlink()ed prematurely

It only affects VNC, not chardevs because the chardevs fail to call qio_channel_close() and just rely on finalize() cleaning up the open socket. To fix this we just need to made the code conditional on it being a listener socket if (qio_channel_has_feature(ioc, QIO_CHANNEL_FEATURE_LISTEN)) {

Re: [Qemu-devel] [PATCH] hw/rdma: Delete unused struct member

On 1/9/19 9:19 PM, Yuval Shaia wrote: > This member is used only in init_device_caps function, make it local. > > Signed-off-by: Yuval Shaia Reviewed-by: Philippe Mathieu-Daudé > --- > hw/rdma/rdma_backend.c | 26 ++ > hw/rdma/rdma_backend_defs.h | 1 - > 2 files

Re: [Qemu-devel] 3.1: second invocation of migrate crashes qemu

* Michael Tokarev (m...@tls.msk.ru) wrote: > $ qemu-system-x86_64 -monitor stdio -hda foo.img > QEMU 3.1.0 monitor - type 'help' for more information > (qemu) stop > (qemu) migrate "exec:cat >/dev/null" > (qemu) migrate "exec:cat >/dev/null" > qemu-system-x86_64: /build/qemu/qemu-3.1/block.c:4647:

Re: [Qemu-devel] [PATCH v2 1/3] nvme: use TYPE_NVME instead of constant string

On 1/11/19 3:08 AM, Li Qiang wrote: > Signed-off-by: Li Qiang > Reviewed-by: Max Reitz Reviewed-by: Philippe Mathieu-Daudé > --- > hw/block/nvme.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/block/nvme.c b/hw/block/nvme.c > index 7c8c63e8f5..f206391e8e 100644

Re: [Qemu-devel] [PATCH] i386/kvm: expose HV_CPUID_ENLIGHTMENT_INFO.EAX and HV_CPUID_NESTED_FEATURES.EAX as feature words

Vitaly Kuznetsov writes: > Eduardo Habkost writes: > >> On Wed, Dec 19, 2018 at 06:25:06PM +0100, Vitaly Kuznetsov wrote: >>> Eduardo Habkost writes: >>> >>> > On Mon, Dec 03, 2018 at 03:17:06PM +0100, Vitaly Kuznetsov wrote: >>> >> Eduardo Habkost writes: >>> > [...] >>> >> > But note that w

Re: [Qemu-devel] [PATCH v4 for-4.0 0/7] vhost-user-blk: Add support for backend reconnecting

On Mon, 14 Jan 2019 at 18:22, Stefan Hajnoczi wrote: > > On Sat, Jan 12, 2019 at 12:50:12PM +0800, Yongji Xie wrote: > > On Fri, 11 Jan 2019 at 23:53, Stefan Hajnoczi wrote: > > > > > > On Thu, Jan 10, 2019 at 06:59:27PM +0800, Yongji Xie wrote: > > > > On Thu, 10 Jan 2019 at 18:25, Stefan Hajnoc

Re: [Qemu-devel] [PULL 0/2] Work around test-qht-par + gprof issues

On Fri, 11 Jan 2019 at 18:25, Eduardo Habkost wrote: > > The following changes since commit e53f7796fbe71a5c7c24ffebf04b4aa9a759da36: > > Merge remote-tracking branch > 'remotes/ehabkost/tags/machine-next-pull-request' into staging (2019-01-11 > 13:35:48 +) > > are available in the Git rep

  1   2   3   4   5   6   >