On 1/14/19 9:56 AM, Thomas Huth wrote: > On 2019-01-11 15:08, Philippe Mathieu-Daudé wrote: >> Range is only used in "hw/pci-host/q35.h" in the MCHPCIState, and >> in "hw/pci/pci.h" by pci_bus_get_w64_range(). Let them include >> "qemu/range.h" directly to simplify "qemu/typedefs.h". >> >> To clean "qemu/typedefs.h", move the declaration to "qemu/range.h" >> (removing the forward declaration). > > Since Range seems to be meant as a common type (i.e. not specific to any > device like the other typedefs that you move in this series), I think > it's should be OK if this resides in typedefs.h ?
My idea was to clean files not very used, and this one is only used twice. Why rebuild the World if someone add another function or fix a typo in "qemu/range.h"? I agree this typedef is meant for global use however. Since I don't have a strong opinion, I'll drop it (until someone else respond to this thread).
