Re: [Qemu-devel] [PATCH] block: don't probe zeroes in bs->file by default on block_status

2019-01-11 Thread Vladimir Sementsov-Ogievskiy
10.01.2019 23:51, Eric Blake wrote: > On 1/10/19 7:20 AM, Vladimir Sementsov-Ogievskiy wrote: >> drv_co_block_status digs bs->file for additional, more accurate search >> for hole inside region, reported as DATA by bs since 5daa74a6ebc. > > s/region, reported/regions reported/ > >> >> This accura

Re: [Qemu-devel] [PATCH v9 08/21] migration: introduce icount field for snapshots

2019-01-11 Thread Markus Armbruster
Pavel Dovgalyuk writes: > Saving icount as a parameters of the snapshot allows navigation between > them in the execution replay scenario. > This information can be used for finding a specific snapshot for rewinding > the recorded execution to the specific moment of the time. > E.g., 'reverse ste

[Qemu-devel] [PATCH v5 3/3] configure: Force the C standard to gnu99

2019-01-11 Thread Thomas Huth
Different versions of GCC and Clang use different versions of the C standard. This repeatedly caused problems already, e.g. with duplicated typedefs: https://lists.gnu.org/archive/html/qemu-devel/2018-11/msg05829.html or with for-loop variable initializers: https://lists.gnu.org/archive/html/q

[Qemu-devel] [PATCH v5 2/3] ppc: Fix duplicated typedefs to be able to compile with Clang in gnu99 mode

2019-01-11 Thread Thomas Huth
When compiling the ppc code with clang and -std=gnu99, there are a couple of warnings/errors like this one: CC ppc64-softmmu/hw/intc/xics.o In file included from hw/intc/xics.c:35: include/hw/ppc/xics.h:43:25: error: redefinition of typedef 'ICPState' is a C11 feature [-Werror,-Wtype

[Qemu-devel] [PATCH v5 0/3] Force the C standard to gnu99

2019-01-11 Thread Thomas Huth
Different versions of GCC and Clang use different versions of the C standard by default. To avoid compilation problems with different compilers in the future, we should enforce one language level for all compilers. Since "gnu99" is the only usable option right now (later versions are still marked a

[Qemu-devel] [PATCH 0/2 v2] Break down the MTP write operation

2019-01-11 Thread Bandan Das
v2: Rebased on top of master and retested For larger files, not only do we keep reallocating to increase the mtp buffer size, the write also happens in one go. This does two things: Write to file upto a certain data size we have received so far and second, reuse the buffer again instead of real

[Qemu-devel] [PATCH 1/2 v2] usb-mtp: Reallocate buffer in multiples of MTP_WRITE_BUF_SZ

2019-01-11 Thread Bandan Das
This is a "pre-patch" to breaking up the write buffer for MTP writes. Instead of allocating a mtp buffer equal to size sent by the initiator, we start with a small size and reallocate multiples (of that small size) as needed. Signed-off-by: Bandan Das --- hw/usb/dev-mtp.c | 26 --

[Qemu-devel] [PATCH v5 1/3] ppc: Move spapr-related prototypes from xics.h into a seperate header file

2019-01-11 Thread Thomas Huth
When compiling with Clang in -std=gnu99 mode, there is a warning/error: CC ppc64-softmmu/hw/intc/xics_spapr.o In file included from /home/thuth/devel/qemu/hw/intc/xics_spapr.c:34: /home/thuth/devel/qemu/include/hw/ppc/xics.h:203:34: error: redefinition of typedef 'sPAPRMachineState' is a C

[Qemu-devel] [PATCH 2/2 v2] usb-mtp: breakup MTP write into smaller chunks

2019-01-11 Thread Bandan Das
For every MTP_WRITE_BUF_SZ copied, this patch writes it to file before getting the next block of data. The file is kept opened for the duration of the operation but the sanity checks on the write operation are performed only once when the write operation starts. Additionally, we also update the fil

Re: [Qemu-devel] [PATCH v2 3/3] virtio: Make disable-legacy/disable-modern compat properties optional

2019-01-11 Thread Cornelia Huck
On Fri, 11 Jan 2019 01:06:45 +0400 Marc-André Lureau wrote: > On Thu, Jan 10, 2019 at 10:07 PM Eduardo Habkost wrote: > > > > On Thu, Jan 10, 2019 at 03:01:25PM +, Dr. David Alan Gilbert wrote: > > > * Michael S. Tsirkin (m...@redhat.com) wrote: > > > > On Thu, Jan 10, 2019 at 11:31:23AM

Re: [Qemu-devel] [PATCH v9 11/21] replay: introduce info hmp/qmp command

2019-01-11 Thread Markus Armbruster
Pavel Dovgalyuk writes: > This patch introduces 'info replay' monitor command and > corresponding qmp request. > These commands request the current record/replay mode, replay log file name, > and the execution step (number or recorded/replayed instructions). s/or/of/ > User may use step number

[Qemu-devel] [PATCH] slirp: check data length while emulating ident function

2019-01-11 Thread P J P
From: Prasad J Pandit While emulating identification protocol, tcp_emu() does not check available space in the 'sc_rcv->sb_data' buffer. It could lead to heap buffer overflow issue. Add check to avoid it. Reported-by: Kira <864786...@qq.com> Signed-off-by: Prasad J Pandit --- slirp/tcp_subr.c

Re: [Qemu-devel] [PATCH v5 2/3] ppc: Fix duplicated typedefs to be able to compile with Clang in gnu99 mode

2019-01-11 Thread Cédric Le Goater
On 1/11/19 9:17 AM, Thomas Huth wrote: > When compiling the ppc code with clang and -std=gnu99, there are a > couple of warnings/errors like this one: > > CC ppc64-softmmu/hw/intc/xics.o > In file included from hw/intc/xics.c:35: > include/hw/ppc/xics.h:43:25: error: redefinition of typedef

Re: [Qemu-devel] [PATCH v4 for-4.0 1/7] char-socket: Enable "nowait" option on client sockets

2019-01-11 Thread Daniel P . Berrangé
On Fri, Jan 11, 2019 at 03:50:40PM +0800, Yongji Xie wrote: > On Fri, 11 Jan 2019 at 00:41, Daniel P. Berrangé wrote: > > > > On Thu, Jan 10, 2019 at 10:29:20PM +0800, Yongji Xie wrote: > > > On Thu, 10 Jan 2019 at 22:11, Daniel P. Berrangé > > > wrote: > > > > > > > > On Thu, Jan 10, 2019 at 10

Re: [Qemu-devel] [PATCH v4 for-4.0 1/7] char-socket: Enable "nowait" option on client sockets

2019-01-11 Thread Yongji Xie
On Fri, 11 Jan 2019 at 16:32, Daniel P. Berrangé wrote: > > On Fri, Jan 11, 2019 at 03:50:40PM +0800, Yongji Xie wrote: > > On Fri, 11 Jan 2019 at 00:41, Daniel P. Berrangé > > wrote: > > > > > > On Thu, Jan 10, 2019 at 10:29:20PM +0800, Yongji Xie wrote: > > > > On Thu, 10 Jan 2019 at 22:11, Da

Re: [Qemu-devel] [PATCH v9 12/21] replay: introduce breakpoint at the specified step

2019-01-11 Thread Markus Armbruster
Pavel Dovgalyuk writes: > This patch introduces replay_break, replay_delete_break > qmp and hmp commands. > These commands allow stopping at the specified instruction. > It may be useful for debugging when there are some known > events that should be investigated. > replay_break command has one a

Re: [Qemu-devel] [PATCH v5 2/3] ppc: Fix duplicated typedefs to be able to compile with Clang in gnu99 mode

2019-01-11 Thread Greg Kurz
On Fri, 11 Jan 2019 09:17:51 +0100 Thomas Huth wrote: > When compiling the ppc code with clang and -std=gnu99, there are a > couple of warnings/errors like this one: > > CC ppc64-softmmu/hw/intc/xics.o > In file included from hw/intc/xics.c:35: > include/hw/ppc/xics.h:43:25: error: redefi

[Qemu-devel] [PATCH] HACKING: Clarify the paragraph about typedefs

2019-01-11 Thread Thomas Huth
The paragraph about typedefs is very sparse and caused some trouble already: Is this mandatory coding style or just a recommendation? ... since this is the HACKING file and not in CODING_STYLE. And various versions of GCC and Clang disallow duplicated typedefs in certain language modes, so the "enf

Re: [Qemu-devel] [PATCH v5 3/3] configure: Force the C standard to gnu99

2019-01-11 Thread Greg Kurz
On Fri, 11 Jan 2019 09:17:52 +0100 Thomas Huth wrote: > Different versions of GCC and Clang use different versions of the C standard. > This repeatedly caused problems already, e.g. with duplicated typedefs: > > https://lists.gnu.org/archive/html/qemu-devel/2018-11/msg05829.html > > or with fo

Re: [Qemu-devel] [PATCH v9 13/21] replay: implement replay-seek command to proceed to the desired step

2019-01-11 Thread Markus Armbruster
Pavel Dovgalyuk writes: > This patch adds hmp/qmp commands replay_seek/replay-seek that proceed > the execution to the specified step. > The command automatically loads nearest snapshot and replay the execution > to find the desired step. "step" again. > > Signed-off-by: Pavel Dovgalyuk > > --

[Qemu-devel] [PATCH v5 1/4] unify len and addr type for memory/address APIs

2019-01-11 Thread Li Zhijian
Some address/memory APIs have different type between 'hwaddr/target_ulong addr' and 'int len'. It is very unsafe, especially some APIs will be passed a non-int len by caller which might cause overflow quietly. Below is an potential overflow case: dma_memory_read(uint32_t len) -> dma_memor

[Qemu-devel] [PATCH v5 2/4] hw/core/loader.c: Read as long as possible in load_image_size()

2019-01-11 Thread Li Zhijian
Don't expect read(2) can always read as many as it's told. CC: Richard Henderson CC: Stefano Garzarella Signed-off-by: Li Zhijian Reviewed-by: Richard Henderson Reviewed-by: Stefano Garzarella --- V5: update subject and add reviewed-by tag (Stefano Garzarella) V4: add reviewed-by tag --- hw

Re: [Qemu-devel] [PATCH] slirp: check data length while emulating ident function

2019-01-11 Thread Marc-André Lureau
Hi On Fri, Jan 11, 2019 at 12:31 PM P J P wrote: > > From: Prasad J Pandit > > While emulating identification protocol, tcp_emu() does not check > available space in the 'sc_rcv->sb_data' buffer. It could lead to > heap buffer overflow issue. Add check to avoid it. > > Reported-by: Kira <864786.

[Qemu-devel] [PATCH v5 4/4] i386: allow to load initrd below 4G for recent linux

2019-01-11 Thread Li Zhijian
Since linux commit: cf8fa920cb42 ("i386: handle an initrd in highmem (version 2)") linux has supported initrd up to 4 GB, but the header field ramdisk_max is still set to 2 GB to avoid "possible bootloader bugs". When use '-kernel vmlinux -initrd initrd.cgz' to launch a VM, the firmware(it could

[Qemu-devel] [PATCH v5 3/4] i386: import & use bootparam.h

2019-01-11 Thread Li Zhijian
it's from v4.20-rc5. CC: Michael S. Tsirkin Signed-off-by: Li Zhijian Reviewed-by: Michael S. Tsirkin --- V5: add reviewed-by tag V4: use scirpt to import bootparam.h (Michael S. Tsirkin) V3: new patch --- hw/i386/pc.c | 8 +-- include/standard-headers/asm-

[Qemu-devel] [PATCH v5 0/4] allow to load initrd below 4G for recent kernel

2019-01-11 Thread Li Zhijian
Long long ago, linux kernel has supported up to 4G initrd, but it's header still hard code to allow loading initrd below 2G only. cutting from arch/boot/x86/header.S: # (Header version 0x0203 or later) the highest safe address for the contents # of an initrd. The current kernel allows up to 4 GB

Re: [Qemu-devel] [PATCH] slirp: check data length while emulating ident function

2019-01-11 Thread P J P
+-- On Fri, 11 Jan 2019, Marc-André Lureau wrote --+ | > +if (m->m_len > so_rcv->sb_datalen | > +- (so_rcv->sb_wptr - so_rcv->sb_data)) { | > +m_free(m); | > +return 0; | > +} | | Check looks correct, it should pro

Re: [Qemu-devel] [PATCH v5 1/3] ppc: Move spapr-related prototypes from xics.h into a seperate header file

2019-01-11 Thread Daniel P . Berrangé
On Fri, Jan 11, 2019 at 09:17:50AM +0100, Thomas Huth wrote: > When compiling with Clang in -std=gnu99 mode, there is a warning/error: > > CC ppc64-softmmu/hw/intc/xics_spapr.o > In file included from /home/thuth/devel/qemu/hw/intc/xics_spapr.c:34: > /home/thuth/devel/qemu/include/hw/ppc/xi

Re: [Qemu-devel] [PATCH v5 2/3] ppc: Fix duplicated typedefs to be able to compile with Clang in gnu99 mode

2019-01-11 Thread Daniel P . Berrangé
On Fri, Jan 11, 2019 at 09:17:51AM +0100, Thomas Huth wrote: > When compiling the ppc code with clang and -std=gnu99, there are a > couple of warnings/errors like this one: > > CC ppc64-softmmu/hw/intc/xics.o > In file included from hw/intc/xics.c:35: > include/hw/ppc/xics.h:43:25: error: r

Re: [Qemu-devel] [PATCH v5 3/3] configure: Force the C standard to gnu99

2019-01-11 Thread Daniel P . Berrangé
On Fri, Jan 11, 2019 at 09:17:52AM +0100, Thomas Huth wrote: > Different versions of GCC and Clang use different versions of the C standard. > This repeatedly caused problems already, e.g. with duplicated typedefs: > > https://lists.gnu.org/archive/html/qemu-devel/2018-11/msg05829.html > > or wi

[Qemu-devel] [PATCH 3/5] vfio/display: add xres + yres properties

2019-01-11 Thread Gerd Hoffmann
This allows configure the display resolution which the vgpu should use. The information will be passed to the guest using EDID, so the mdev driver must support the vfio edid region for this to work. Signed-off-by: Gerd Hoffmann --- hw/vfio/pci.h | 2 ++ hw/vfio/display.c | 10 -- hw

[Qemu-devel] [PATCH 4/5] vfio/display: delay link up event

2019-01-11 Thread Gerd Hoffmann
Kick the display link up event with a 0.1 sec delay, so the guest has a chance to notice the link down first. Signed-off-by: Gerd Hoffmann --- include/hw/vfio/vfio-common.h | 1 + hw/vfio/display.c | 22 -- 2 files changed, 21 insertions(+), 2 deletions(-) diff

[Qemu-devel] [PATCH 0/5] vfio/display: add edid support.

2019-01-11 Thread Gerd Hoffmann
The 5.0-rc1 linux kernel header update -- which contains the vfio api update for edid support -- is about to land in qemu master. Intel just posted patches implementing EDID support. Time to undust the test patches, polish them and post them for review & merge. This series adds EDID support to t

[Qemu-devel] [PATCH 2/5] vfio/display: add edid support.

2019-01-11 Thread Gerd Hoffmann
This patch adds EDID support to the vfio display (aka vgpu) code. When supported by the mdev driver qemu will generate a EDID blob and pass it on using the new vfio edid region. The EDID blob will be updated on UI changes (i.e. window resize), so the guest can adapt. Signed-off-by: Gerd Hoffmann

[Qemu-devel] [PATCH 5/5] [debug] some logging

2019-01-11 Thread Gerd Hoffmann
--- hw/vfio/display.c | 16 1 file changed, 16 insertions(+) diff --git a/hw/vfio/display.c b/hw/vfio/display.c index a3a710b3ee..96b5474243 100644 --- a/hw/vfio/display.c +++ b/hw/vfio/display.c @@ -42,6 +42,8 @@ static void vfio_display_edid_link_up(void *opaque) VFIOPCIDe

[Qemu-devel] [PATCH 1/5] vfio: update kernel headers.

2019-01-11 Thread Gerd Hoffmann
Temporary, for testing convinience. Once qemu master is synced with the linux 5.0-rc1 headers this is not needed any more. Signed-off-by: Gerd Hoffmann --- linux-headers/linux/vfio.h | 50 ++ 1 file changed, 50 insertions(+) diff --git a/linux-header

Re: [Qemu-devel] [PATCH v1] s390x/pci: Send correct event on hotplug.

2019-01-11 Thread Cornelia Huck
On Fri, 11 Jan 2019 08:16:41 +0100 David Hildenbrand wrote: > On 10.01.19 22:03, David Hildenbrand wrote: > > Comit 2c28c490571f ("s390x/pci: let pci devices start in configured mode") > > changed the initial state of zPCI devices from ZPCI_FS_STANDBY to > > ZPCI_FS_DISABLED (a.k.a. configured).

Re: [Qemu-devel] [PATCH v5 3/4] i386: import & use bootparam.h

2019-01-11 Thread Stefano Garzarella
Hi Li, On Fri, Jan 11, 2019 at 10:06 AM Li Zhijian wrote: > > it's from v4.20-rc5. > > CC: Michael S. Tsirkin > Signed-off-by: Li Zhijian > Reviewed-by: Michael S. Tsirkin > --- > V5: add reviewed-by tag > V4: use scirpt to import bootparam.h (Michael S. Tsirkin) > V3: new patch > --- > hw/i3

Re: [Qemu-devel] qemu-user-linux: how could I measure performance for aarch64 and arm?

2019-01-11 Thread Peter Maydell
On Thu, 10 Jan 2019 at 19:33, Matwey V. Kornilov wrote: > I am running the same application compiled for aarch64 and armv7l on > x86_64 platform using qemu-user-linux tools. > > I see dramatic performance difference (30 times) between emulated > architectures: aarch64 runs for ~4 minutes, armv7l r

Re: [Qemu-devel] [PATCH] qga: check length of command-line & environment variables

2019-01-11 Thread P J P
+-- On Mon, 7 Jan 2019, P J P wrote --+ | Qemu guest agent while executing user commands does not seem to | check length of argument list and/or environment variables passed. | It may lead to integer overflow or infinite loop issues. Add check | to avoid it. | | -size_t str_size = 1; | +si

Re: [Qemu-devel] [PATCH v2 0/3] optimize waiting for free thread to do compression

2019-01-11 Thread Markus Armbruster
guangrong.x...@gmail.com writes: > From: Xiao Guangrong > > Changelog in v2: > squash 'compress-wait-thread-adaptive' into 'compress-wait-thread' based > on peter's suggestion > > > Currently we have two behaviors if all threads are busy to do compression, > the main thread mush wait one of them

Re: [Qemu-devel] [PATCH] qga: check length of command-line & environment variables

2019-01-11 Thread Daniel P . Berrangé
On Fri, Jan 11, 2019 at 03:22:51PM +0530, P J P wrote: > +-- On Mon, 7 Jan 2019, P J P wrote --+ > | Qemu guest agent while executing user commands does not seem to > | check length of argument list and/or environment variables passed. > | It may lead to integer overflow or infinite loop issues. Ad

Re: [Qemu-devel] [PATCH v2 3/3] migration: introduce adaptive model for waiting thread

2019-01-11 Thread Markus Armbruster
guangrong.x...@gmail.com writes: > From: Xiao Guangrong > > Currently we have two behaviors if all threads are busy to do compression, > the main thread mush wait one of them becoming free if @compress-wait-thread > set to on or the main thread can directly return without wait and post > the page

Re: [Qemu-devel] [PATCH v3 0/6] include: Auto-generate the sizes lookup table

2019-01-11 Thread Kevin Wolf
Am 10.01.2019 um 20:18 hat Eric Blake geschrieben: > Patches speak louder than words. This is my counter-proposal to > Leonid's thread on how best to respresent the S_*iB macros in units.h, > where my proposal is that we don't need them at all. (hence my subject > line, even though it is completel

Re: [Qemu-devel] [PATCH v5 3/4] i386: import & use bootparam.h

2019-01-11 Thread Li Zhijian
Hi Stefano On 1/11/19 17:48, Stefano Garzarella wrote: Hi Li, On Fri, Jan 11, 2019 at 10:06 AM Li Zhijian wrote: +# unnecessary import of several video/ist/etc headers +sed -e '/__ASSEMBLY__/,/__ASSEMBLY__/d' $tmpdir/include/asm/bootparam.h > $tmpdir/bootparam.h +cp_

Re: [Qemu-devel] [PATCH 1/4] migration: add RAMBlock's offset validation

2019-01-11 Thread Igor Mammedov
On Thu, 10 Jan 2019 20:14:19 + "Dr. David Alan Gilbert" wrote: > * Yury Kotov (yury-ko...@yandex-team.ru) wrote: > > RAM migration has a RAMBlock validation stage (flag RAM_SAVE_FLAG_MEM_SIZE). > > In this stage QEMU checks further information about RAMBlock: > > 1. Presence (by idstr), > > 2

Re: [Qemu-devel] [Spice-devel] [PATCH spice 1/3] QXL interface: add a function to identify monitors in the guest

2019-01-11 Thread Lukáš Hrázký
On Wed, 2019-01-09 at 11:36 -0600, Jonathon Jongsma wrote: > On Tue, 2019-01-08 at 16:26 +0100, Lukáš Hrázký wrote: > > Adds a function to let QEMU provide information to identify graphics > > devices and their monitors in the guest. The function > > (spice_qxl_set_device_info) sets the device addr

Re: [Qemu-devel] [PATCH] block: don't probe zeroes in bs->file by default on block_status

2019-01-11 Thread Vladimir Sementsov-Ogievskiy
11.01.2019 10:54, Vladimir Sementsov-Ogievskiy wrote: > 10.01.2019 23:51, Eric Blake wrote: >> On 1/10/19 7:20 AM, Vladimir Sementsov-Ogievskiy wrote: >>> drv_co_block_status digs bs->file for additional, more accurate search >>> for hole inside region, reported as DATA by bs since 5daa74a6ebc. >>

Re: [Qemu-devel] [PATCH v3] qdev/core: fix qbus_is_full()

2019-01-11 Thread Halil Pasic
On Thu, 10 Jan 2019 10:50:30 -0500 Tony Krowiak wrote: > On 1/9/19 12:35 PM, Halil Pasic wrote: > > On Wed, 9 Jan 2019 10:36:11 -0500 > > Tony Krowiak wrote: > > > >> On 1/9/19 5:14 AM, Cornelia Huck wrote: [..] > >> A search reveals that max_index is used in only two places: It is used > >>

Re: [Qemu-devel] [PATCH v3 0/4] Introduce attributes for timers subsystem and remove QEMU_CLOCK_VIRTUAL_EXT clock type

2019-01-11 Thread Paolo Bonzini
On 10/01/19 14:30, Pavel Dovgalyuk wrote: > Now timerlist_deadline_ns uses all virtual timers for deadline calculation > (including external > ones). > qemu_start_warp_timer uses the deadline for setting warp timer (which should > be deterministic). Can you introduce a variant of qemu_clock_dead

Re: [Qemu-devel] [PATCH v3] qdev/core: fix qbus_is_full()

2019-01-11 Thread Halil Pasic
On Thu, 10 Jan 2019 17:57:22 +0100 Cornelia Huck wrote: > > I thought the same. They could also be made unsigned long or > > unsigned long long to increase the number of child devices that can be > > plugged in before having to deal with exceeding the index value. > > Making them unsigned long

Re: [Qemu-devel] [PATCH] HACKING: Clarify the paragraph about typedefs

2019-01-11 Thread Paolo Bonzini
On 11/01/19 09:42, Thomas Huth wrote: > 2.3. Typedefs > -Typedefs are used to eliminate the redundant 'struct' keyword. > +Typedefs can be used to eliminate the redundant 'struct' keyword. This is > +especially helpful for common types that are used all over the place. Since > +certain C compilers

Re: [Qemu-devel] [PATCH v3 2/6] block: Take advantage of QemuOpt default integers

2019-01-11 Thread Kevin Wolf
Am 10.01.2019 um 20:18 hat Eric Blake geschrieben: > Instead of defining an integer to a default string value (where we > have to be careful how we spelled the integer because of the use of > stringify), populate a default integer value instead. > > Drop a useless stringify(0); a missing default i

Re: [Qemu-devel] [PATCH] block: don't probe zeroes in bs->file by default on block_status

2019-01-11 Thread Kevin Wolf
Am 10.01.2019 um 14:20 hat Vladimir Sementsov-Ogievskiy geschrieben: > drv_co_block_status digs bs->file for additional, more accurate search > for hole inside region, reported as DATA by bs since 5daa74a6ebc. > > This accuracy is not free: assume we have qcow2 disk. Actually, qcow2 > knows, where

Re: [Qemu-devel] [PATCH v2 0/3] Fix & improve icon display on GTK and SDL frontends

2019-01-11 Thread Gerd Hoffmann
On Thu, Jan 10, 2019 at 12:00:44PM +, Daniel P. Berrangé wrote: > This series improves the GTK and SDL frontends so that they display the > high quality QEMU logo. > > Changed in v2: > > - Add a 'regenerate' make target in ui/icons to rebuild icons > from SVG using inkscape. > - Allow

Re: [Qemu-devel] [PATCH 0/2 v2] Break down the MTP write operation

2019-01-11 Thread Gerd Hoffmann
On Fri, Jan 11, 2019 at 03:20:41AM -0500, Bandan Das wrote: > v2: > Rebased on top of master and retested Thanks. Added to usb queue. cheers, Gerd

Re: [Qemu-devel] If Qemu support NVMe over Fabrics ?y

2019-01-11 Thread Paolo Bonzini
On 11/01/19 06:46, Yang Zhong wrote: > On Thu, Jan 10, 2019 at 10:36:37AM +, Stefan Hajnoczi wrote: >> On Thu, Jan 10, 2019 at 04:37:53PM +0800, Yang Zhong wrote: >>> Do you know if Qemu support NVMe over Fabrics(NVMe-oF)? >>> https://nvmexpress.org/wp-content/uploads/NVMe_Over_Fabrics.pdf >>>

Re: [Qemu-devel] [PATCH v9 19/21] replay: add BH oneshot event for block layer

2019-01-11 Thread Kevin Wolf
Am 09.01.2019 um 13:13 hat Pavel Dovgalyuk geschrieben: > Replay is capable of recording normal BH events, but sometimes > there are single use callbacks scheduled with aio_bh_schedule_oneshot > function. This patch enables recording and replaying such callbacks. > Block layer uses these events for

Re: [Qemu-devel] [PATCH] usb: dev-mtp: close fd in usb_mtp_object_readdir()

2019-01-11 Thread Gerd Hoffmann
On Mon, Jan 07, 2019 at 10:35:30AM +, Peter Maydell wrote: > On Mon, 7 Jan 2019 at 10:22, Gerd Hoffmann wrote: > > > > On Thu, Jan 03, 2019 at 05:31:13AM -0800, Li Qiang wrote: > > > Spotted by Coverity: CID 1397070 > > > > #ifdef CONFIG_INOTIFY1 > > > @@ -682,6 +683,7 @@ static void usb_mtp

Re: [Qemu-devel] [PULL v7 00/35] Misc patches for 2018-12-18

2019-01-11 Thread Peter Maydell
On Thu, 10 Jan 2019 at 20:52, Paolo Bonzini wrote: > > The following changes since commit 147923b1a901a0370f83a0f4c58ec1baffef22f0: > > Merge remote-tracking branch > 'remotes/kraxel/tags/usb-20190108-pull-request' into staging (2019-01-08 > 16:07:32 +) > > are available in the Git reposit

Re: [Qemu-devel] [PULL 0/2] Audio 20190110 patches

2019-01-11 Thread Peter Maydell
On Thu, 10 Jan 2019 at 09:25, Gerd Hoffmann wrote: > > The following changes since commit e59dbbac0364344a3ad84c3497a98c56003d3fb8: > > Merge remote-tracking branch > 'remotes/philmd/tags/fw_cfg-20190104-pull-request' into staging (2019-01-04 > 18:23:13 +) > > are available in the git repo

Re: [Qemu-devel] [PATCH v5 3/3] configure: Force the C standard to gnu99

2019-01-11 Thread Alex Bennée
Thomas Huth writes: > Different versions of GCC and Clang use different versions of the C standard. > This repeatedly caused problems already, e.g. with duplicated typedefs: > > https://lists.gnu.org/archive/html/qemu-devel/2018-11/msg05829.html > > or with for-loop variable initializers: > >

Re: [Qemu-devel] [PATCH 1/4] migration: add RAMBlock's offset validation

2019-01-11 Thread Dr. David Alan Gilbert
* Igor Mammedov (imamm...@redhat.com) wrote: > On Thu, 10 Jan 2019 20:14:19 + > "Dr. David Alan Gilbert" wrote: > > > * Yury Kotov (yury-ko...@yandex-team.ru) wrote: > > > RAM migration has a RAMBlock validation stage (flag > > > RAM_SAVE_FLAG_MEM_SIZE). > > > In this stage QEMU checks furth

Re: [Qemu-devel] [PULL v7 00/35] Misc patches for 2018-12-18

2019-01-11 Thread Paolo Bonzini
On 11/01/19 11:51, Peter Maydell wrote: > make: Entering directory > '/home/petmay01/linaro/qemu-for-merges/build/all-linux-static' > BUILD debian9 > The command '/bin/sh -c DEBIAN_FRONTEND=noninteractive eatmydata > apt install -y --no-install-recommends bison > build-essential

Re: [Qemu-devel] [PATCH v3 1/2] globals: Allow global properties to be optional

2019-01-11 Thread Marc-André Lureau
Hi On Thu, Jan 10, 2019 at 10:05 PM Eduardo Habkost wrote: > > Making some global properties optional will let us simplify > compat code when a given property works on most (but not all) > subclasses of a given type. > > Device types will be able to opt out from optional compat > properties by si

Re: [Qemu-devel] [PATCH v3 2/2] virtio: Make disable-legacy/disable-modern compat properties optional

2019-01-11 Thread Cornelia Huck
On Thu, 10 Jan 2019 16:04:58 -0200 Eduardo Habkost wrote: > The disable-legacy and disable-modern properties apply only to > some virtio-pci devices. Make those properties optional. > > This fixes the crash introduced by commit f6e501a28ef9 ("virtio: Provide > version-specific variants of virti

Re: [Qemu-devel] [PATCH v3 1/2] globals: Allow global properties to be optional

2019-01-11 Thread Cornelia Huck
On Thu, 10 Jan 2019 16:04:57 -0200 Eduardo Habkost wrote: > Making some global properties optional will let us simplify > compat code when a given property works on most (but not all) > subclasses of a given type. > > Device types will be able to opt out from optional compat > properties by simp

Re: [Qemu-devel] [PATCH] slirp: check data length while emulating ident function

2019-01-11 Thread Marc-André Lureau
Hi On Fri, Jan 11, 2019 at 1:18 PM P J P wrote: > > +-- On Fri, 11 Jan 2019, Marc-André Lureau wrote --+ > | > +if (m->m_len > so_rcv->sb_datalen > | > +- (so_rcv->sb_wptr - so_rcv->sb_data)) { > | > +m_free(m); > | > +return

[Qemu-devel] [PATCH 0/2] s390x: Diag 308 improvements

2019-01-11 Thread Janosch Frank
Let's make it architecture compliant and a bit more readable. Each non implemented diag 308 supcode should result in a specification exception. Operating systems use the exceptions to query which codes are available. Janosch Frank (2): s390x: Diag308 move common parameter checking into function

[Qemu-devel] [PATCH 2/2] s390x: Return specification exception for unimplemented diag 308 subcodes

2019-01-11 Thread Janosch Frank
The architecture specifies specification exceptions for all unavailable subcodes. The presence of subcodes is indicated by checking some query subcode. For example 6 will indicate that 3-6 are available. So future systems might call new subcodes to check for new features. This should not trigger a

[Qemu-devel] [PATCH 1/2] s390x: Diag308 move common parameter checking into function

2019-01-11 Thread Janosch Frank
Let's make that switch statement a bit shorter. Signed-off-by: Janosch Frank --- target/s390x/diag.c | 34 ++ 1 file changed, 18 insertions(+), 16 deletions(-) diff --git a/target/s390x/diag.c b/target/s390x/diag.c index acb0f3d4af..cfd7222ddd 100644 --- a/target

Re: [Qemu-devel] [PATCH] block: don't probe zeroes in bs->file by default on block_status

2019-01-11 Thread Vladimir Sementsov-Ogievskiy
11.01.2019 13:41, Kevin Wolf wrote: > Am 10.01.2019 um 14:20 hat Vladimir Sementsov-Ogievskiy geschrieben: >> drv_co_block_status digs bs->file for additional, more accurate search >> for hole inside region, reported as DATA by bs since 5daa74a6ebc. >> >> This accuracy is not free: assume we have q

Re: [Qemu-devel] [PATCH 2/2] s390x: Return specification exception for unimplemented diag 308 subcodes

2019-01-11 Thread Christian Borntraeger
On 11.01.2019 12:36, Janosch Frank wrote: > The architecture specifies specification exceptions for all > unavailable subcodes. > > The presence of subcodes is indicated by checking some query subcode. > For example 6 will indicate that 3-6 are available. So future systems > might call new subc

Re: [Qemu-devel] [PATCH] pc-bios/s390-ccw: Use proper register names for Clang

2019-01-11 Thread Cornelia Huck
On Thu, 10 Jan 2019 13:32:39 +0100 Thomas Huth wrote: > When compiling the s390-ccw firmware with Clang 7.0.1, I get the > following errors: > > pc-bios/s390-ccw/start.S:62:19: error: invalid use of length addressing > stctg 0,0,0(15) > ^ > pc-bios/s390-ccw/start.S:63:1

[Qemu-devel] [PULL 0/1] Misc 20190111 patches

2019-01-11 Thread Gerd Hoffmann
The following changes since commit 291741033f611a4f0bbce3f7c9dead84ce315f96: Merge remote-tracking branch 'remotes/kraxel/tags/audio-20190110-pull-request' into staging (2019-01-10 18:45:23 +) are available in the git repository at: git://git.kraxel.org/qemu tags/misc-201

[Qemu-devel] [PULL 1/1] roms: seabios: Rename CROSS_COMPILE to CROSS_PREFIX

2019-01-11 Thread Gerd Hoffmann
From: Roman Bolshakov SeaBIOS introduced CROSS_PREFIX in 2013 but it's not set in roms Makefile. With the change it's possible to cross-compile SeaBIOS on macOS, if acpica/iasl is installed: cd roms export PATH=/path/to/cross/x86_64-unknown-linux-gnu/bin:$PATH make bios system=unknown-linu

[Qemu-devel] [PATCH] target/xtensa: rework zero overhead loops implementation

2019-01-11 Thread Max Filippov
Don't invalidate TB with the end of zero overhead loop when LBEG or LEND change. Instead encode the distance from the start of the page where the TB starts to the LEND in the TB cs_base and generate loopback code when the next PC matches encoded LEND. Distance to a destination within the same page

Re: [Qemu-devel] [PATCH] HACKING: Clarify the paragraph about typedefs

2019-01-11 Thread Cédric Le Goater
On 1/11/19 11:38 AM, Paolo Bonzini wrote: > On 11/01/19 09:42, Thomas Huth wrote: >> 2.3. Typedefs >> -Typedefs are used to eliminate the redundant 'struct' keyword. >> +Typedefs can be used to eliminate the redundant 'struct' keyword. This is >> +especially helpful for common types that are used

Re: [Qemu-devel] [PATCH v2 0/3] HMP/snapshot changes - do not use ID anymore

2019-01-11 Thread Kevin Wolf
Am 10.01.2019 um 19:22 hat Eric Blake geschrieben: > On 1/10/19 11:06 AM, Dr. David Alan Gilbert wrote: > > >>> savevm [-t] [-i] [tag|id] > >>> > >>> then: > >>> a) with neither -t or -i it would behave in the same roulette way > >>> as it does in the moment, and it might be a tag or id >

Re: [Qemu-devel] [PATCH] block: don't probe zeroes in bs->file by default on block_status

2019-01-11 Thread Kevin Wolf
Am 11.01.2019 um 12:40 hat Vladimir Sementsov-Ogievskiy geschrieben: > 11.01.2019 13:41, Kevin Wolf wrote: > > Am 10.01.2019 um 14:20 hat Vladimir Sementsov-Ogievskiy geschrieben: > >> drv_co_block_status digs bs->file for additional, more accurate search > >> for hole inside region, reported as DA

Re: [Qemu-devel] [PATCH v2 0/3] HMP/snapshot changes - do not use ID anymore

2019-01-11 Thread Max Reitz
On 09.01.19 18:52, Eric Blake wrote: > On 1/9/19 11:38 AM, Max Reitz wrote: > >> >> >> Actually, to me what you're saying sounds more like "Our deprecation >> policy is useless" to which I wholeheartedly agree. I think we should >> only remove things in major releases, and only if it was depreca

[Qemu-devel] [PATCH 3/4] accel/tcg: Add cluster number to TCG TB hash

2019-01-11 Thread Aleksandar Markovic
Hello, Peter. First of all, I want to tell you that I support this series and I salute efforts in this and related areas. It is known that there have been strong trends towards asymmetric multi-core systems now for some longish time - and that QEMU support in that area will greately enhance QEMU i

Re: [Qemu-devel] Help needed: test-qht-par hangs on Travis

2019-01-11 Thread Paolo Bonzini
On 10/01/19 21:58, Eduardo Habkost wrote: > On Mon, Dec 10, 2018 at 05:09:42PM -0200, Eduardo Habkost wrote: >> On Mon, Dec 10, 2018 at 03:34:27PM -0200, Eduardo Habkost wrote: >>> On Mon, Dec 10, 2018 at 12:07:20PM -0500, Emilio G. Cota wrote: On Mon, Dec 10, 2018 at 14:36:01 -0200, Eduardo H

Re: [Qemu-devel] [PATCH v5 1/3] ppc: Move spapr-related prototypes from xics.h into a seperate header file

2019-01-11 Thread Philippe Mathieu-Daudé
On 1/11/19 9:17 AM, Thomas Huth wrote: > When compiling with Clang in -std=gnu99 mode, there is a warning/error: > > CC ppc64-softmmu/hw/intc/xics_spapr.o > In file included from /home/thuth/devel/qemu/hw/intc/xics_spapr.c:34: > /home/thuth/devel/qemu/include/hw/ppc/xics.h:203:34: error: re

[Qemu-devel] [PATCH] ftgmac100: implement the new MDIO interface on Aspeed SoC

2019-01-11 Thread Cédric Le Goater
The PHY behind the MAC of an Aspeed SoC can be controlled using two different MDC/MDIO interfaces. The same registers PHYCR (MAC60) and PHYDATA (MAC64) are involved but they have a different layout. BIT31 of the Feature Register (MAC40) controls which MDC/MDIO interface is active. Signed-off-by:

Re: [Qemu-devel] [PATCH] block: don't probe zeroes in bs->file by default on block_status

2019-01-11 Thread Vladimir Sementsov-Ogievskiy
11.01.2019 15:21, Kevin Wolf wrote: > Am 11.01.2019 um 12:40 hat Vladimir Sementsov-Ogievskiy geschrieben: >> 11.01.2019 13:41, Kevin Wolf wrote: >>> Am 10.01.2019 um 14:20 hat Vladimir Sementsov-Ogievskiy geschrieben: drv_co_block_status digs bs->file for additional, more accurate search

Re: [Qemu-devel] [PATCH v5 2/3] ppc: Fix duplicated typedefs to be able to compile with Clang in gnu99 mode

2019-01-11 Thread Philippe Mathieu-Daudé
On 1/11/19 9:17 AM, Thomas Huth wrote: > When compiling the ppc code with clang and -std=gnu99, there are a > couple of warnings/errors like this one: > > CC ppc64-softmmu/hw/intc/xics.o > In file included from hw/intc/xics.c:35: > include/hw/ppc/xics.h:43:25: error: redefinition of typedef

Re: [Qemu-devel] [PATCH v3 0/4] Introduce attributes for timers subsystem and remove QEMU_CLOCK_VIRTUAL_EXT clock type

2019-01-11 Thread Artem Pisarenko
> It seems, that this approach is not always correct. > Now timerlist_deadline_ns uses all virtual timers for deadline calculation > (including external > ones). > qemu_start_warp_timer uses the deadline for setting warp timer (which should > be deterministic). > Therefore warp timer may become n

Re: [Qemu-devel] [PATCH 3/4] accel/tcg: Add cluster number to TCG TB hash

2019-01-11 Thread Peter Maydell
On Fri, 11 Jan 2019 at 12:49, Aleksandar Markovic wrote: > 1. What would be, in more detail, if possible in layman terms, > the "bad case" that this series fixes? I describe this in the cover letter (which also has a link to a tarball with a test case demonstrating it): > TCG implicitly assumes t

Re: [Qemu-devel] [Qemu-trivial] Whitespace cleanup: target/ppc/translate_init.inc.c

2019-01-11 Thread Philippe Mathieu-Daudé
On 1/11/19 8:20 AM, Laurent Vivier wrote: > On 11/01/2019 01:37, David Gibson wrote: >> On Wed, Jan 09, 2019 at 11:15:26AM +0100, Laurent Vivier wrote: >>> Hi Jon, >>> >>> please cc: qemu-devel and MAINTAINERS when you send a patch. >>> >>> You can have the list of maintainers using a script in qem

Re: [Qemu-devel] [PATCH v3 24/35] target/riscv: Move gen_arith_imm() decoding into trans_* functions

2019-01-11 Thread Bastian Koppelmann
On 10/31/18 11:18 PM, Richard Henderson wrote: Surely the shri and sari functions need the same shamt >= TARGET_LONG_BITS check as slli. Otherwise RV32 shri should definitely produce an assert in tcg_gen_shri_tl. I did wonder about changing the decode of the shift functions such that only th

Re: [Qemu-devel] [PATCH v1 16/19] docker: Use a stable snapshot for Debian Sid

2019-01-11 Thread Philippe Mathieu-Daudé
On 1/10/19 6:45 PM, Alex Bennée wrote: > From: Philippe Mathieu-Daudé > > The Debian Sid repository is not garanteed to be stable, as his > 'unstable' name suggest :) > To allow quick testing, packages are pushed various time a day, > which my be annoying when trying to use it for stable developm

Re: [Qemu-devel] [PATCH] block: don't probe zeroes in bs->file by default on block_status

2019-01-11 Thread Kevin Wolf
Am 11.01.2019 um 13:59 hat Vladimir Sementsov-Ogievskiy geschrieben: > 11.01.2019 15:21, Kevin Wolf wrote: > > Am 11.01.2019 um 12:40 hat Vladimir Sementsov-Ogievskiy geschrieben: > >> 11.01.2019 13:41, Kevin Wolf wrote: > >>> Am 10.01.2019 um 14:20 hat Vladimir Sementsov-Ogievskiy geschrieben: > >

[Qemu-devel] [PATCH 4/4] hw/i386/pc: use PVH option rom

2019-01-11 Thread Stefano Garzarella
Use pvh.bin option rom when we are booting an uncompressed kernel using the x86/HVM direct boot ABI. Signed-off-by: Stefano Garzarella Based-on: <1545422632-2-5-git-send-email-liam.merw...@oracle.com> --- hw/i386/pc.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/i386/pc.c b/hw/

Re: [Qemu-devel] [PATCH] throttle-groups: fix restart coroutine iothread race

2019-01-11 Thread Alberto Garcia
On Wed 09 Jan 2019 04:34:10 PM CET, Alberto Garcia wrote: > On Wed 09 Jan 2019 12:01:44 PM CET, Stefan Hajnoczi wrote: >> The following QMP command leads to a crash when iothreads are used: >> >> { 'execute': 'device_del', 'arguments': {'id': 'data'} } > > How did you reproduce this? Do you have

[Qemu-devel] [PATCH 0/4] pvh: add new PVH option rom

2019-01-11 Thread Stefano Garzarella
This patch series is based on "[RFC v2 0/4] QEMU changes to do PVH boot" and provides a PVH option rom that can be used with SeaBIOS to boot uncompressed kernel using the x86/HVM direct boot ABI. Patches 1 and 2 are to prepare the PVH option rom, moving common functions in a new header. Patch 3 a

[Qemu-devel] [Bug 1810603] Re: QEMU QCow Images grow dramatically

2019-01-11 Thread Kevin Wolf
Regarding snapshot deletion, QEMU does punch holes into the image file when deleting snapshots, so the space should effectively be freed, even if this isn't visible in the file size. To get actually meaningful numbers, you'd have to look at the allocated blocks rather than the file size (e.g. by us

Re: [Qemu-devel] [PULL v7 00/35] Misc patches for 2018-12-18

2019-01-11 Thread Philippe Mathieu-Daudé
On 1/11/19 11:58 AM, Paolo Bonzini wrote: > On 11/01/19 11:51, Peter Maydell wrote: >> make: Entering directory >> '/home/petmay01/linaro/qemu-for-merges/build/all-linux-static' >> BUILD debian9 >> The command '/bin/sh -c DEBIAN_FRONTEND=noninteractive eatmydata >> apt install -y --no-install-r

Re: [Qemu-devel] [PATCH for-4.0 v9 09/16] qemu_thread: supplement error handling for pci_edu_realize

2019-01-11 Thread Fei Li
在 2019/1/11 上午10:49, Peter Xu 写道: On Thu, Jan 10, 2019 at 09:29:38PM +0800, Fei Li wrote: 在 2019/1/8 下午4:43, Markus Armbruster 写道: Peter Xu writes: On Tue, Jan 08, 2019 at 07:14:11AM +0100, Jiri Slaby wrote: On 07. 01. 19, 18:29, Markus Armbruster wrote: static void pci_edu_uninit(P

[Qemu-devel] [PATCH 1/4] linuxboot_dma: remove duplicate definitions of FW_CFG

2019-01-11 Thread Stefano Garzarella
FW_CFG_DMA_CTL_* bits and struct fw_cfg_dma_access are defined in the qemu_fw_cfg.h header file already included in linuxboot_dma.c, so we can remove the definition of BIOS_CFG_DMA_CTL_* and struct FWCfgDmaAccess. Signed-off-by: Stefano Garzarella --- pc-bios/optionrom/linuxboot_dma.c | 20 -

  1   2   3   4   >