Am 09.01.2019 um 13:13 hat Pavel Dovgalyuk geschrieben: > Replay is capable of recording normal BH events, but sometimes > there are single use callbacks scheduled with aio_bh_schedule_oneshot > function. This patch enables recording and replaying such callbacks. > Block layer uses these events for calling the completion function. > Replaying these calls makes the execution deterministic. > > Signed-off-by: Pavel Dovgalyuk <pavel.dovga...@ispras.ru>
This still doesn't come even close to catching all BHs that need to be caught. While you managed to show a few BHs that actually don't need to be considered for recording when I asked for this in v7, most BHs in the block layer can in some way lead to device callbacks and must therefore be recorded. How bad would it be to record some BHs even if recording them isn't necessary? I'd definitely try to err on the safe side here. Having two different sets of BH functions, you can't expect that people always use the right one (especially if you don't even make the existing code base consistently use the right one intially). Kevin
