Re: [Qemu-devel] [PATCH v1] s390x/pci: Send correct event on hotplug.

2019-01-10 Thread David Hildenbrand
On 10.01.19 22:03, David Hildenbrand wrote: > Comit 2c28c490571f ("s390x/pci: let pci devices start in configured mode") > changed the initial state of zPCI devices from ZPCI_FS_STANDBY to > ZPCI_FS_DISABLED (a.k.a. configured). However we still only send a > HP_EVENT_RESERVED_TO_STANDBY event to t

Re: [Qemu-devel] [Qemu-trivial] ppc: e6500 registers SPR 604 twice

2019-01-10 Thread Laurent Vivier
On 11/01/2019 01:35, David Gibson wrote: On Wed, Jan 09, 2019 at 11:17:00AM +0100, Laurent Vivier wrote: David, will you take this through your ppc branch? Somehow I missed this one, sorry. Even when I look back through my mail archives I can't see the original message of this thread. Can y

Re: [Qemu-devel] [Qemu-trivial] Whitespace cleanup: target/ppc/translate_init.inc.c

2019-01-10 Thread Laurent Vivier
On 11/01/2019 01:37, David Gibson wrote: On Wed, Jan 09, 2019 at 11:15:26AM +0100, Laurent Vivier wrote: Hi Jon, please cc: qemu-devel and MAINTAINERS when you send a patch. You can have the list of maintainers using a script in qemu directory: ./scripts/get_maintainer.pl .patch Than

Re: [Qemu-devel] [PATCH v3 0/5] kvm "virtio pmem" device

2019-01-10 Thread Pankaj Gupta
> > On Wed, Jan 09, 2019 at 08:17:31PM +0530, Pankaj Gupta wrote: > > This patch series has implementation for "virtio pmem". > > "virtio pmem" is fake persistent memory(nvdimm) in guest > > which allows to bypass the guest page cache. This also > > implements a VIRTIO based asynchronous flu

Re: [Qemu-devel] [PATCH v4 for-4.0 1/7] char-socket: Enable "nowait" option on client sockets

2019-01-10 Thread Yongji Xie
On Fri, 11 Jan 2019 at 00:41, Daniel P. Berrangé wrote: > > On Thu, Jan 10, 2019 at 10:29:20PM +0800, Yongji Xie wrote: > > On Thu, 10 Jan 2019 at 22:11, Daniel P. Berrangé > > wrote: > > > > > > On Thu, Jan 10, 2019 at 10:08:54PM +0800, Yongji Xie wrote: > > > > On Thu, 10 Jan 2019 at 21:24, Da

Re: [Qemu-devel] [PATCH v2 1/1] include: Auto-generate the sizes lookup table

2019-01-10 Thread Markus Armbruster
Leonid Bloch writes: > On 1/10/19 2:51 PM, wrote: >> Leonid Bloch writes: >> >>> Hi, >>> >>> On 1/8/19 2:20 PM, Kevin Wolf wrote: Am 03.01.2019 um 22:33 hat Leonid Bloch geschrieben: > The lookup table for power-of-two sizes is now auto-generated during the > build, and not hard-c

Re: [Qemu-devel] [PATCH] main-loop: remove unused header file

2019-01-10 Thread Li Qiang
Ping... Thanks, Li Qiang Li Qiang 于2018年12月17日周一 下午2:34写道: > Signed-off-by: Li Qiang > --- > util/main-loop.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/util/main-loop.c b/util/main-loop.c > index affe0403c5..845a4b1f13 100644 > --- a/util/main-loop.c > +++ b/util/main-loop.c > @

Re: [Qemu-devel] [PATCH v2 1/3] qom: Don't keep error value between object_property_parse() calls

2019-01-10 Thread Marc-André Lureau
On Thu, Jan 10, 2019 at 6:04 AM Eduardo Habkost wrote: > > When handling errp==NULL at object_apply_global_props(), we are > leaving the old error value in `err` after printing a warning. > This makes QEMU crash if two global properties generate warnings: > > $ echo device_add rtl8139 | qemu-sys

Re: [Qemu-devel] [PATCH v1 1/1] default-configs: Enable USB support for RISC-V machines

2019-01-10 Thread Thomas Huth
On 2019-01-10 01:01, Alistair Francis wrote: > Signed-off-by: Alistair Francis > --- > default-configs/riscv32-softmmu.mak | 1 + > default-configs/riscv64-softmmu.mak | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/default-configs/riscv32-softmmu.mak > b/default-configs/riscv32-soft

[Qemu-devel] [PULL 8/8] spice: Remove unused include

2019-01-10 Thread Gerd Hoffmann
From: Frediano Ziglio The definitions in the header are not used. Also this fixes porting SPICE to Windows where the header is not available. Signed-off-by: Frediano Ziglio Reviewed-by: Philippe Mathieu-Daudé Message-id: 20190107184404.31993-1-fzig...@redhat.com Signed-off-by: Gerd Hoffmann

[Qemu-devel] [PULL 7/8] keymaps: drop support for include files

2019-01-10 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Reviewed-by: Li Qiang Message-id: 20181116104319.10329-5-kra...@redhat.com --- ui/keymaps.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/ui/keymaps.c b/ui/keymaps.c index 085889b555..6e44f738ed 100644 --- a/ui/keymaps.c +++ b/ui/keymaps.

[Qemu-devel] [PULL 2/8] configure: bump spice-server required version to 0.12.5

2019-01-10 Thread Gerd Hoffmann
From: Marc-André Lureau Looking at chardev/spice.c code, I realize compilation was broken for a while with spice-server < 0.12.3. Let's bump required version to 0.12.5, released May 19 2014, instead of adding more #ifdef. (this patch combines changes from an early version and some of Frediano "[

[Qemu-devel] [PULL 5/8] keymaps: drop nl-be map

2019-01-10 Thread Gerd Hoffmann
It doesn't define any keys, only includes "common". Which makes it effectively an "en-us" map. Signed-off-by: Gerd Hoffmann Message-id: 20181116104319.10329-3-kra...@redhat.com --- Makefile | 2 +- pc-bios/keymaps/nl-be | 3 --- 2 files changed, 1 insertion(+), 4 deletions(-) delet

[Qemu-devel] [PULL 6/8] keymaps: remove common include

2019-01-10 Thread Gerd Hoffmann
Copy the content into the sl and sv files (the only ones left which are not generated by qemu-keymap). Signed-off-by: Gerd Hoffmann Message-id: 20181116104319.10329-4-kra...@redhat.com --- Makefile | 2 +- pc-bios/keymaps/common | 174 -

[Qemu-devel] [PULL 4/8] keymaps: remove modifiers include

2019-01-10 Thread Gerd Hoffmann
"common" is the only file using it, so we can just include it directly. Signed-off-by: Gerd Hoffmann Message-id: 20181116104319.10329-2-kra...@redhat.com --- Makefile | 2 +- pc-bios/keymaps/common| 19 ++- pc-bios/keymaps/modifiers | 18 --

[Qemu-devel] [PULL 3/8] ui/console: Remove qemu_create_display_surface_guestmem()

2019-01-10 Thread Gerd Hoffmann
From: Peter Maydell The qemu_create_display_surface_guestmem() function was added in commit a77549b3ffcc24c32ee4e but apparently never used. Remove it. (The API of this function is in any case awkward as a generic function: it assumes that a physical address uniquely identifies a piece of memory

[Qemu-devel] [PULL 1/8] egl-headless: add egl_create_context

2019-01-10 Thread Gerd Hoffmann
We must set the correct context (via eglMakeCurrent) before calling qemu_egl_create_context, so we need a thin wrapper and can't hook qemu_egl_create_context directly as ->dpy_gl_ctx_create callback. Reported-by: Frederik Carlier Signed-off-by: Gerd Hoffmann Message-id: 20181129123502.30129-1-kr

[Qemu-devel] [PULL 0/8] Ui 20190110 patches

2019-01-10 Thread Gerd Hoffmann
The following changes since commit e59dbbac0364344a3ad84c3497a98c56003d3fb8: Merge remote-tracking branch 'remotes/philmd/tags/fw_cfg-20190104-pull-request' into staging (2019-01-04 18:23:13 +) are available in the git repository at: git://git.kraxel.org/qemu tags/ui-201

[Qemu-devel] [PULL 1/2] Add getsockopt for settable SOL_IPV6 options

2019-01-10 Thread Laurent Vivier
From: Tom Deseyn Signed-off-by: Tom Deseyn Message-Id: <20181213130611.7496-1-tom.des...@gmail.com> Signed-off-by: Laurent Vivier --- linux-user/syscall.c | 39 +++ 1 file changed, 39 insertions(+) diff --git a/linux-user/syscall.c b/linux-user/syscall.c in

[Qemu-devel] If Qemu support NVMe over Fabrics ?

2019-01-10 Thread Yang Zhong
Hello all, Do you know if Qemu support NVMe over Fabrics(NVMe-oF)? https://nvmexpress.org/wp-content/uploads/NVMe_Over_Fabrics.pdf The Qemu has enabled RDMA in last year, and i am not sure if Qemu should support NVME-oF. If Qemu support it, would you please share me the qemu related command or g

[Qemu-devel] [PULL 0/2] Linux user for 4.0 patches

2019-01-10 Thread Laurent Vivier
The following changes since commit 147923b1a901a0370f83a0f4c58ec1baffef22f0: Merge remote-tracking branch 'remotes/kraxel/tags/usb-20190108-pull-request' into staging (2019-01-08 16:07:32 +) are available in the Git repository at: git://github.com/vivier/qemu.git tags/linux-user-for-4.0

[Qemu-devel] [PULL 2/2] linux-user: make pwrite64/pread64(fd, NULL, 0, offset) return 0

2019-01-10 Thread Laurent Vivier
From: Peter Maydell Linux returns success if pwrite64() or pread64() are called with a zero length NULL buffer, but QEMU was returning -TARGET_EFAULT. This is the same bug that we fixed in commit 58cfa6c2e6eb51b23cc9 for the write syscall, and long before that in 38d840e6790c29f59 for the read s

Re: [Qemu-devel] [PATCH] hw/audio/marvell: Don't include unnecessary i2c.h header file

2019-01-10 Thread Gerd Hoffmann
On Fri, Jan 04, 2019 at 04:02:26PM +0100, Thomas Huth wrote: > This device does not use I2C, so no need to include the header file here. Added to audio queue. thanks, Gerd

Re: [Qemu-devel] [PATCH v2 3/3] virtio: Make disable-legacy/disable-modern compat properties optional

2019-01-10 Thread Marc-André Lureau
Hi On Thu, Jan 10, 2019 at 6:05 AM Eduardo Habkost wrote: > > The disable-legacy and disable-modern properties apply only to > some virtio-pci devices. Make those properties optional. > > This fixes the crash introduced by commit f6e501a28ef9 ("virtio: Provide > version-specific variants of virt

Re: [Qemu-devel] [PATCH] vfio/common: Work around kernel overflow bug in DMA unmap

2019-01-10 Thread Cornelia Huck
On Wed, 09 Jan 2019 16:10:51 -0700 Alex Williamson wrote: > A kernel bug was introduced in v4.15 via commit 71a7d3d78e3c which > adds a test for address space wrap-around in the vfio DMA unmap path. > Unfortunately due to overflow, the kernel detects an unmap of the last > page in the 64-bit addr

Re: [Qemu-devel] [PATCH v2 43/52] audio: add mixeng option (documentation)

2019-01-10 Thread Markus Armbruster
Eric Blake writes: > On 12/23/18 2:52 PM, Kővágó, Zoltán wrote: >> This will allow us to disable mixeng when we use a decent backend. >> >> Disabling mixeng have a few advantages: >> * we no longer convert the audio output from one format to another, when >> the underlying audio system would j

[Qemu-devel] [PATCH v4 2/3] ppc: Drop duplicated typedefs to be able to compile with Clang in gnu99 mode

2019-01-10 Thread Thomas Huth
When compiling the ppc code with clang and -std=gnu99, there are a couple of warnings/errors like this one: CC ppc64-softmmu/hw/intc/xics.o In file included from /home/thuth/devel/qemu/hw/intc/xics.c:35: /home/thuth/devel/qemu/include/hw/ppc/xics.h:43:25: error: redefinition of typedef 'IC

[Qemu-devel] [PATCH v4 0/3] Force the C standard to gnu99

2019-01-10 Thread Thomas Huth
Different versions of GCC and Clang use different versions of the C standard by default. To avoid compilation problems with different compilers in the future, we should enforce one language level for all compilers. Since "gnu99" is the only usable option right now (later versions are still marked a

[Qemu-devel] [PATCH v4 3/3] configure: Force the C standard to gnu99

2019-01-10 Thread Thomas Huth
Different versions of GCC and Clang use different versions of the C standard. This repeatedly caused problems already, e.g. with duplicated typedefs: https://lists.gnu.org/archive/html/qemu-devel/2018-11/msg05829.html or with for-loop variable initializers: https://lists.gnu.org/archive/html/q

[Qemu-devel] [PATCH v4 1/3] ppc: Move spapr-related prototypes from xics.h into a seperate header file

2019-01-10 Thread Thomas Huth
When compiling with Clang in -std=gnu99 mode, there is a warning/error: CC ppc64-softmmu/hw/intc/xics_spapr.o In file included from /home/thuth/devel/qemu/hw/intc/xics_spapr.c:34: /home/thuth/devel/qemu/include/hw/ppc/xics.h:203:34: error: redefinition of typedef 'sPAPRMachineState' is a C

Re: [Qemu-devel] [PATCH for-4.0 v9 16/16] qemu_thread_join: fix segmentation fault

2019-01-10 Thread Markus Armbruster
fei writes: >> 在 2019年1月9日,23:24,Markus Armbruster 写道: >> >> Fei Li writes: >> 在 2019/1/9 上午1:29, Markus Armbruster 写道: fei writes: >> 在 2019年1月8日,01:55,Markus Armbruster 写道: >> >> Fei Li writes: >> >>> To avoid the segmentation fault in qemu_thread_jo

[Qemu-devel] [PULL 1/2] hw/audio/marvell: Don't include unnecessary i2c.h header file

2019-01-10 Thread Gerd Hoffmann
From: Thomas Huth This device does not use I2C, so no need to include the header file here. Signed-off-by: Thomas Huth Message-Id: <1546614146-10525-1-git-send-email-th...@redhat.com> Signed-off-by: Gerd Hoffmann --- hw/audio/marvell_88w8618.c | 1 - 1 file changed, 1 deletion(-) diff --git

[Qemu-devel] [PULL 0/2] Audio 20190110 patches

2019-01-10 Thread Gerd Hoffmann
The following changes since commit e59dbbac0364344a3ad84c3497a98c56003d3fb8: Merge remote-tracking branch 'remotes/philmd/tags/fw_cfg-20190104-pull-request' into staging (2019-01-04 18:23:13 +) are available in the git repository at: git://git.kraxel.org/qemu tags/audio-201

[Qemu-devel] [PULL 2/2] usb-audio: ignore usb packages with wrong size

2019-01-10 Thread Gerd Hoffmann
usb packets with no payload (zero length) seem to happen in practice for whatever reason. Add a check and skip the packet then, otherwise we'll trigger an assert. Reported-by: Leonardo Soares Müller Signed-off-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daudé Message-id: 20181211072649.207

Re: [Qemu-devel] [PATCH v4 1/3] ppc: Move spapr-related prototypes from xics.h into a seperate header file

2019-01-10 Thread Greg Kurz
On Thu, 10 Jan 2019 10:15:34 +0100 Thomas Huth wrote: > When compiling with Clang in -std=gnu99 mode, there is a warning/error: > > CC ppc64-softmmu/hw/intc/xics_spapr.o > In file included from /home/thuth/devel/qemu/hw/intc/xics_spapr.c:34: > /home/thuth/devel/qemu/include/hw/ppc/xics.h:

Re: [Qemu-devel] [PATCH] json: Fix % handling when not interpolating

2019-01-10 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Wed, Jan 09, 2019 at 04:02:28PM +0100, Max Reitz wrote: >> On 09.01.19 15:49, Daniel P. Berrangé wrote: >> > On Wed, Jan 09, 2019 at 03:32:47PM +0100, Markus Armbruster wrote: >> >> Max Reitz writes: >> >> >> >>> On 08.01.19 11:36, Markus Armbruster wrote: >>

Re: [Qemu-devel] [PATCH v2 06/52] audio: -audiodev command line option basic implementation

2019-01-10 Thread Zoltán Kővágó
On 2019-01-10 08:25, Gerd Hoffmann wrote: > Hi, > >> I was thinking about creating an Audiodev (the qapi type) directly would >> be better, then somehow print it with reflection. While this is not a >> typical use of qapi, at least qmp_qom_list creates qapi objects >> directly, so I assume it's

[Qemu-devel] [PATCH v2 0/2] arm: Stub out NRF51 TWI magnetometer/accelerometer detection

2019-01-10 Thread Stefan Hajnoczi
v2: * Move stub code into a separate device [Peter] * Instantiate stub from microbit board instead of nRF51 SoC since this is microbit-specific. Other boards using the nRF51 wouldn't necessarily want to see these TWI/I2C devices. * Add test case This series stubs out the microbit's TWI/I

[Qemu-devel] [PATCH v2 1/2] arm: Stub out NRF51 TWI magnetometer/accelerometer detection

2019-01-10 Thread Stefan Hajnoczi
From: Steffen Görtz Recent microbit firmwares panic if the TWI magnetometer/accelerometer devices are not detected during startup. We don't implement TWI (I2C) so let's stub out these devices just to let the firmware boot. Signed-off by: Steffen Görtz Signed-off-by: Stefan Hajnoczi --- hw/i2

[Qemu-devel] [PATCH v2 2/2] tests/microbit-test: add TWI stub device test

2019-01-10 Thread Stefan Hajnoczi
This test verifies that we read back the expected I2C WHO_AM_I register values for the accelerometer/magnetometer. Signed-off-by: Stefan Hajnoczi --- tests/microbit-test.c | 44 +++ 1 file changed, 44 insertions(+) diff --git a/tests/microbit-test.c b/tes

Re: [Qemu-devel] [PATCH v2 1/1] include: Auto-generate the sizes lookup table

2019-01-10 Thread Leonid Bloch
Hi, On 1/8/19 11:31 AM, Markus Armbruster wrote: > I'd leave it hard-coded. Replacing a few trivial defines by an arguably > less trivial script doesn't feel like an improvement. In this case, it > doesn't even save lines. As I've said, I'm fine with that. The autogeneration sounds the right t

Re: [Qemu-devel] [PATCH v2 2/2] tests/microbit-test: add TWI stub device test

2019-01-10 Thread Thomas Huth
On 2019-01-10 10:40, Stefan Hajnoczi wrote: > This test verifies that we read back the expected I2C WHO_AM_I register > values for the accelerometer/magnetometer. > > Signed-off-by: Stefan Hajnoczi > --- > tests/microbit-test.c | 44 +++ > 1 file changed,

Re: [Qemu-devel] [PATCH v4 1/3] ppc: Move spapr-related prototypes from xics.h into a seperate header file

2019-01-10 Thread Cédric Le Goater
On 1/10/19 10:15 AM, Thomas Huth wrote: > When compiling with Clang in -std=gnu99 mode, there is a warning/error: > > CC ppc64-softmmu/hw/intc/xics_spapr.o > In file included from /home/thuth/devel/qemu/hw/intc/xics_spapr.c:34: > /home/thuth/devel/qemu/include/hw/ppc/xics.h:203:34: error: r

Re: [Qemu-devel] [PATCH v2 1/1] include: Auto-generate the sizes lookup table

2019-01-10 Thread Leonid Bloch
Hi, On 1/8/19 2:20 PM, Kevin Wolf wrote: > Am 03.01.2019 um 22:33 hat Leonid Bloch geschrieben: >> The lookup table for power-of-two sizes is now auto-generated during the >> build, and not hard-coded into the units.h file. >> >> This partially reverts commit 540b8492618eb. >> >> Signed-off-by: Le

Re: [Qemu-devel] [PATCH v2 2/2] tests/microbit-test: add TWI stub device test

2019-01-10 Thread Julia Suvorova via Qemu-devel
On 10.01.2019 12:48, Thomas Huth wrote: On 2019-01-10 10:40, Stefan Hajnoczi wrote: This test verifies that we read back the expected I2C WHO_AM_I register values for the accelerometer/magnetometer. Signed-off-by: Stefan Hajnoczi --- tests/microbit-test.c | 44

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/2] include/hw/ppc: Fix compilation with clang -std=gnu99

2019-01-10 Thread Daniel P . Berrangé
On Wed, Jan 09, 2019 at 03:25:53PM -0600, Eric Blake wrote: > On 1/9/19 3:20 PM, Paolo Bonzini wrote: > > On 09/01/19 18:28, Daniel P. Berrangé wrote: > >>> so both files include each other, how nice ... > >> If the header files are mutually dependent it makes me wonder what the > >> point of havin

Re: [Qemu-devel] [PATCH v3 0/5] kvm "virtio pmem" device

2019-01-10 Thread Jan Kara
On Thu 10-01-19 12:26:17, Dave Chinner wrote: > On Wed, Jan 09, 2019 at 08:17:31PM +0530, Pankaj Gupta wrote: > > This patch series has implementation for "virtio pmem". > > "virtio pmem" is fake persistent memory(nvdimm) in guest > > which allows to bypass the guest page cache. This also > >

Re: [Qemu-devel] [PATCH v4 for-4.0 0/7] vhost-user-blk: Add support for backend reconnecting

2019-01-10 Thread Stefan Hajnoczi
On Wed, Jan 09, 2019 at 07:27:21PM +0800, elohi...@gmail.com wrote: > From: Xie Yongji > > This patchset is aimed at supporting qemu to reconnect > vhost-user-blk backend after vhost-user-blk backend crash or > restart. > > The patch 1 uses exisiting wait/nowait options to make QEMU not > do a c

Re: [Qemu-devel] [PATCH v2 1/6] nbd: Only require disabled bitmap for read-only exports

2019-01-10 Thread Vladimir Sementsov-Ogievskiy
10.01.2019 10:13, Eric Blake wrote: > Our initial implementation of x-nbd-server-add-bitmap put > in a restriction because of incremental backups: in that > usage, we are exporting one qcow2 file (the temporary overlay > target of a blockdev-backup sync:none job) and a dirty bitmap > owned by a sec

[Qemu-devel] [PATCH v2] linux-user: Fix compilation with clang 3.4

2019-01-10 Thread Thomas Huth
Clang version 3.4.2 does not know the -Wpragmas option yet and bails out with an error when we try to disable it in linux-user/qemu.h. Fortunately, clang has a __has_warning() macro which allows us to add an explicit check for the warning that we like to disable. With that we can check for the avai

Re: [Qemu-devel] Emulation of TCG OPAL self-encrypting drive

2019-01-10 Thread Stefan Hajnoczi
On Thu, Jan 10, 2019 at 12:05:32AM +0100, David Kozub wrote: > On Mon, 7 Jan 2019, Stefan Hajnoczi wrote: > > > QEMU supports LUKS encrypted disk images so no new code is needed for > > the actual encryption. > > Thanks for the feedback, Stefan. I know very little about qemu internals (I > looked

Re: [Qemu-devel] [PATCH v9 10/21] qapi: introduce replay.json for record/replay-related stuff

2019-01-10 Thread Markus Armbruster
Pavel Dovgalyuk writes: > This patch adds replay.json file. It will be > used for adding record/replay-related data structures and commands. > > Signed-off-by: Pavel Dovgalyuk > --- > MAINTAINERS |1 + > Makefile.objs |4 ++-- > include/sysemu/replay.h |1 + >

Re: [Qemu-devel] [PATCH] target/arm: Allow to switch from MON->HYP on AArch32

2019-01-10 Thread Peter Maydell
On Thu, 10 Jan 2019 at 06:43, Alexander Graf wrote: > > > > On 10.01.19 00:08, Peter Maydell wrote: > > On Wed, 9 Jan 2019 at 17:14, Alexander Graf wrote: > >> > >> On 01/09/2019 05:59 PM, Peter Maydell wrote: > >>> On Wed, 9 Jan 2019 at 16:52, Peter Maydell > >>> wrote: > On Wed, 9 Jan 20

Re: [Qemu-devel] If Qemu support NVMe over Fabrics ?

2019-01-10 Thread Stefan Hajnoczi
On Thu, Jan 10, 2019 at 04:37:53PM +0800, Yang Zhong wrote: > Do you know if Qemu support NVMe over Fabrics(NVMe-oF)? > https://nvmexpress.org/wp-content/uploads/NVMe_Over_Fabrics.pdf > > The Qemu has enabled RDMA in last year, and i am not sure if Qemu > should support NVME-oF. If Qemu support i

Re: [Qemu-devel] [PATCH] main-loop: remove unused header file

2019-01-10 Thread Stefan Hajnoczi
On Sun, Dec 16, 2018 at 10:34:16PM -0800, Li Qiang wrote: > Signed-off-by: Li Qiang > --- A candidate for the trivial patches tree. > util/main-loop.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/util/main-loop.c b/util/main-loop.c > index affe0403c5..845a4b1f13 100644 > --- a/util/

Re: [Qemu-devel] [PATCH v2 06/52] audio: -audiodev command line option basic implementation

2019-01-10 Thread Gerd Hoffmann
> > Can we just drop the nesting? > > > > Have a look at DisplayOptions (qapi struct used to store -display > > options). It's a union, has some common base fields, and the > > discriminator field (type in that case) decides which of the data > > branches is used. And on the command line I can d

Re: [Qemu-devel] [PATCH v4 for-4.0 0/7] vhost-user-blk: Add support for backend reconnecting

2019-01-10 Thread Marc-André Lureau
Hi On Wed, Jan 9, 2019 at 3:28 PM wrote: > > From: Xie Yongji > > This patchset is aimed at supporting qemu to reconnect > vhost-user-blk backend after vhost-user-blk backend crash or > restart. > > The patch 1 uses exisiting wait/nowait options to make QEMU not > do a connect on client sockets

Re: [Qemu-devel] [PATCH v2 2/6] nbd: Merge nbd_export_set_name into nbd_export_new

2019-01-10 Thread Vladimir Sementsov-Ogievskiy
10.01.2019 10:13, Eric Blake wrote: > The existing NBD code had a weird split where nbd_export_new() > created an export but did not add it to the list of exported > names until a later nbd_export_set_name() came along and grabbed > a second reference on the object; later, nbd_export_close() > drop

Re: [Qemu-devel] [PATCH v2 1/3] qom: Don't keep error value between object_property_parse() calls

2019-01-10 Thread Cornelia Huck
On Thu, 10 Jan 2019 00:02:57 -0200 Eduardo Habkost wrote: > When handling errp==NULL at object_apply_global_props(), we are > leaving the old error value in `err` after printing a warning. > This makes QEMU crash if two global properties generate warnings: > > $ echo device_add rtl8139 | qemu-

Re: [Qemu-devel] [PATCH v4 for-4.0 0/7] vhost-user-blk: Add support for backend reconnecting

2019-01-10 Thread Yongji Xie
On Thu, 10 Jan 2019 at 18:25, Stefan Hajnoczi wrote: > > On Wed, Jan 09, 2019 at 07:27:21PM +0800, elohi...@gmail.com wrote: > > From: Xie Yongji > > > > This patchset is aimed at supporting qemu to reconnect > > vhost-user-blk backend after vhost-user-blk backend crash or > > restart. > > > > Th

Re: [Qemu-devel] [PATCH v2 2/3] globals: Allow global properties to be optional

2019-01-10 Thread Cornelia Huck
On Thu, 10 Jan 2019 00:02:58 -0200 Eduardo Habkost wrote: > Making some global properties optional will let us simplify > compat code when a given property works on most (but not all) > subclasses of a given type. > > Device types will be able to opt out from optional compat > properties by simp

Re: [Qemu-devel] [PATCH v2] linux-user: Fix compilation with clang 3.4

2019-01-10 Thread Laurent Vivier
On 10/01/2019 11:23, Thomas Huth wrote: Clang version 3.4.2 does not know the -Wpragmas option yet and bails out with an error when we try to disable it in linux-user/qemu.h. Fortunately, clang has a __has_warning() macro which allows us to add an explicit check for the warning that we like to di

Re: [Qemu-devel] [PATCH v4 for-4.0 0/7] vhost-user-blk: Add support for backend reconnecting

2019-01-10 Thread Yongji Xie
On Thu, 10 Jan 2019 at 18:39, Marc-André Lureau wrote: > > Hi > > On Wed, Jan 9, 2019 at 3:28 PM wrote: > > > > From: Xie Yongji > > > > This patchset is aimed at supporting qemu to reconnect > > vhost-user-blk backend after vhost-user-blk backend crash or > > restart. > > > > The patch 1 uses e

Re: [Qemu-devel] [PATCH v2 3/3] virtio: Make disable-legacy/disable-modern compat properties optional

2019-01-10 Thread Dr. David Alan Gilbert
* Marc-André Lureau (marcandre.lur...@gmail.com) wrote: > Hi > > On Thu, Jan 10, 2019 at 6:05 AM Eduardo Habkost wrote: > > > > The disable-legacy and disable-modern properties apply only to > > some virtio-pci devices. Make those properties optional. > > > > This fixes the crash introduced by c

Re: [Qemu-devel] [PATCH v2 0/3] HMP/snapshot changes - do not use ID anymore

2019-01-10 Thread Kevin Wolf
Am 09.01.2019 um 20:02 hat Eric Blake geschrieben: > On 1/9/19 12:51 PM, Kevin Wolf wrote: > > >> Indeed, and libvirt IS using 'savevm' via HMP via QMP's > >> human-monitor-command, since there is no QMP counterpart for internal > >> snapshot. Even though lately we consistently tell people that i

Re: [Qemu-devel] [PATCH v2 0/3] HMP/snapshot changes - do not use ID anymore

2019-01-10 Thread Dr. David Alan Gilbert
* Kevin Wolf (kw...@redhat.com) wrote: > Am 09.01.2019 um 20:02 hat Eric Blake geschrieben: > > On 1/9/19 12:51 PM, Kevin Wolf wrote: > > > > >> Indeed, and libvirt IS using 'savevm' via HMP via QMP's > > >> human-monitor-command, since there is no QMP counterpart for internal > > >> snapshot. Ev

[Qemu-devel] [PATCH v2 2/3] ui: fix icon display for GTK frontend under GNOME Shell with Wayland

2019-01-10 Thread Daniel P . Berrangé
The icon associated with a GtkWindow is just a hint to window managers and not all of them will honour it. Some will instead want to show the icon listed by the .desktop file. The desktop file is located based on the application ID, which is set using g_set_prgname. QEMU has not historically provid

Re: [Qemu-devel] [PATCH v2 3/6] nbd: Allow bitmap export during QMP nbd-server-add

2019-01-10 Thread Vladimir Sementsov-Ogievskiy
10.01.2019 10:13, Eric Blake wrote: > With the experimental x-nbd-server-add-bitmap command, there was > a window of time where an NBD client could see the export but not > the associated dirty bitmap, which can cause a client that planned > on using the dirty bitmap to be forced to treat the entir

[Qemu-devel] [PATCH v2 0/3] Fix & improve icon display on GTK and SDL frontends

2019-01-10 Thread Daniel P . Berrangé
This series improves the GTK and SDL frontends so that they display the high quality QEMU logo. Changed in v2: - Add a 'regenerate' make target in ui/icons to rebuild icons from SVG using inkscape. - Allow use of SDL_Image to be disabled with --enable-sdl-image configure arg - Reduc

[Qemu-devel] [PATCH v2 3/3] sdl: add support for high resolution window icon

2019-01-10 Thread Daniel P . Berrangé
Modern desktop environments can render icons at very large sizes, especially with high DPI screens. Providing a 32x32 pixel bitmap is nowhere near sufficient anymore. When displayed in GNOME shell the QEMU icon looks awful, having been scaled up to at least x4 its base size. This is compounded by

[Qemu-devel] [PATCH v2 1/3] ui: install logo icons to $prefix/share/icons

2019-01-10 Thread Daniel P . Berrangé
QEMU currently installs loogs to $prefix/share/qemu/ which means no GUI toolkit or applications can find them by default. The accepted standards for desktop applications declare that application logos / icons should be installed under $prefix/share/icons, so use this directory location. Pre-rende

[Qemu-devel] [PATCH 3/4] migration: introduce ignore-external capability

2019-01-10 Thread Yury Kotov
We want to use local migration to update QEMU for running guests. In this case we don't need to migrate external RAM. So, add a capability to ignore such blocks during live migration. Signed-off-by: Yury Kotov --- exec.c| 5 + include/exec/cpu-common.h | 1 + migration/

[Qemu-devel] [PATCH 4/4] tests/migration-test: Add a test for ignore-external capability

2019-01-10 Thread Yury Kotov
Signed-off-by: Yury Kotov --- tests/migration-test.c | 109 + 1 file changed, 89 insertions(+), 20 deletions(-) diff --git a/tests/migration-test.c b/tests/migration-test.c index 06ca5068d8..67e6d6dad2 100644 --- a/tests/migration-test.c +++ b/tests/migrat

[Qemu-devel] [PATCH 1/4] migration: add RAMBlock's offset validation

2019-01-10 Thread Yury Kotov
RAM migration has a RAMBlock validation stage (flag RAM_SAVE_FLAG_MEM_SIZE). In this stage QEMU checks further information about RAMBlock: 1. Presence (by idstr), 2. Length (trying to resize, when differs), 3. Optional page size. This patch adds a check for RAMBlock's offset. Currently we check it

Re: [Qemu-devel] [PATCH v2 3/6] nbd: Allow bitmap export during QMP nbd-server-add

2019-01-10 Thread Vladimir Sementsov-Ogievskiy
cc Nikolay 10.01.2019 10:13, Eric Blake wrote: > With the experimental x-nbd-server-add-bitmap command, there was > a window of time where an NBD client could see the export but not > the associated dirty bitmap, which can cause a client that planned > on using the dirty bitmap to be forced to tre

[Qemu-devel] [PATCH 2/4] exec: add RAM_EXTERNAL flag to mark non-QEMU allocated blocks

2019-01-10 Thread Yury Kotov
This flag allows to determine whether RAM block is available from the outside. E.g. when we use -object memory-backend-file or -mem-path options we have a RAM block which is mapped to shared file. We need this flag in the following commits. Signed-off-by: Yury Kotov --- backends/hostmem-file.c

[Qemu-devel] [PATCH 0/4] Add ignore-external migration capability

2019-01-10 Thread Yury Kotov
Hi, The series adds migration capability which allows to skip 'external' RAM blocks during migration. External block is a RAMBlock which available from the outside of current QEMU process (e.g. file in /dev/shm). It's useful for fast local migration to update QEMU for the running guests. Patches:

Re: [Qemu-devel] [PATCH v2 4/6] nbd: Remove x-nbd-server-add-bitmap

2019-01-10 Thread Vladimir Sementsov-Ogievskiy
10.01.2019 10:13, Eric Blake wrote: > Now that nbd-server-add can do the same functionality, we no > longer need the experimental separate command. > > Signed-off-by: Eric Blake Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

[Qemu-devel] [PATCH v3] usb: assign unique serial numbers to hid devices

2019-01-10 Thread Gerd Hoffmann
Windows guests have trouble dealing with usb devices having identical serial numbers. So, assign unique serial numbers to usb hid devices. All other usb devices have this already. In the past the fixed serial number has been used to indicate working remote setup to linux guests. Here is a bit of

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/2] include/hw/ppc: Fix compilation with clang -std=gnu99

2019-01-10 Thread Greg Kurz
On Thu, 10 Jan 2019 10:12:43 + Daniel P. Berrangé wrote: > On Wed, Jan 09, 2019 at 03:25:53PM -0600, Eric Blake wrote: > > On 1/9/19 3:20 PM, Paolo Bonzini wrote: > > > On 09/01/19 18:28, Daniel P. Berrangé wrote: > > >>> so both files include each other, how nice ... > > >> If the head

Re: [Qemu-devel] [qemu-s390x] [PATCH 10/15] s390-bios: Support for running format-0/1 channel programs

2019-01-10 Thread Cornelia Huck
On Wed, 9 Jan 2019 15:01:19 -0500 "Jason J. Herne" wrote: > On 1/9/19 1:34 PM, Cornelia Huck wrote: > > On Wed, 9 Jan 2019 13:10:26 -0500 > > "Jason J. Herne" wrote: > >> I'm not sure what value there is in abstracting sense at the moment. I'm > >> not even sure > >> what other device's sense

[Qemu-devel] [PATCH 04/11] target/arm: Record the GP bit for a page in MemTxAttrs

2019-01-10 Thread Richard Henderson
This isn't really a transaction attribute, but that's the most convenient place to hold a random bit of information within the softmmu tlb. Signed-off-by: Richard Henderson --- include/exec/memattrs.h | 2 ++ target/arm/helper.c | 6 ++ 2 files changed, 8 insertions(+) diff --git a/incl

Re: [Qemu-devel] [PATCH v3] usb: assign unique serial numbers to hid devices

2019-01-10 Thread Daniel P . Berrangé
On Thu, Jan 10, 2019 at 01:08:43PM +0100, Gerd Hoffmann wrote: > Windows guests have trouble dealing with usb devices having identical > serial numbers. So, assign unique serial numbers to usb hid devices. > All other usb devices have this already. > > In the past the fixed serial number has been

[Qemu-devel] [PATCH 00/11] target/arm: Implement ARMv8.5-BTI

2019-01-10 Thread Richard Henderson
The branch target identification extension does not yet have kernel or gcc support. It should be in shape for developing those though. In system mode I do honor the GP bit from the page tables. In user-only mode, there is a way to pretend that the GP bit is always set. Further linux-user changes

[Qemu-devel] [PATCH 02/11] target/arm: Add PSTATE.BTYPE

2019-01-10 Thread Richard Henderson
Place this in its own field within ENV, as that will make it easier to reset from within TCG generated code. With the change to pstate_read/write, exception entry and return are automatically handled. Signed-off-by: Richard Henderson --- target/arm/cpu.h | 8 ++-- target/arm/trans

[Qemu-devel] [PATCH 07/11] target/arm: Set btype for indirect branches

2019-01-10 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate-a64.c | 37 - 1 file changed, 36 insertions(+), 1 deletion(-) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index f319fa000e..5f0ecb297f 100644 --- a/target/arm/translate-a64.c ++

[Qemu-devel] [PATCH 01/11] target/arm: Introduce isar_feature_aa64_bti

2019-01-10 Thread Richard Henderson
Also create field definitions for id_aa64pfr1 from ARMv8.5. Signed-off-by: Richard Henderson --- target/arm/cpu.h | 8 1 file changed, 8 insertions(+) diff --git a/target/arm/cpu.h b/target/arm/cpu.h index 8512ca3552..fadb74d9a6 100644 --- a/target/arm/cpu.h +++ b/target/arm/cpu.h @@ -

[Qemu-devel] [PATCH 09/11] target/arm: Enable BTI for -cpu max

2019-01-10 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/cpu64.c | 4 1 file changed, 4 insertions(+) diff --git a/target/arm/cpu64.c b/target/arm/cpu64.c index 713d2d5579..64fbe75eca 100644 --- a/target/arm/cpu64.c +++ b/target/arm/cpu64.c @@ -372,6 +372,10 @@ static void aarch64_max_initfn(Object

[Qemu-devel] [PATCH 03/11] target/arm: Add BT and BTYPE to tb->flags

2019-01-10 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/cpu.h | 2 ++ target/arm/translate.h | 4 target/arm/helper.c| 22 +++--- target/arm/translate-a64.c | 2 ++ 4 files changed, 23 insertions(+), 7 deletions(-) diff --git a/target/arm/cpu.h b/target/arm/

[Qemu-devel] [PATCH 10/11] linux-user/aarch64: Reset btype for signal handlers

2019-01-10 Thread Richard Henderson
It does not make sense for a SIGILL handler to enter with the btype set as for the indirect branch that caused the SIGILL. Nor does it make sense to return from a handler with BTYPE set. This could be argued to be the handler's job, setting BTYPE within ucontext->uc_mcontext.pstate, but handling t

[Qemu-devel] [PATCH 05/11] target/arm: Default handling of BTYPE during translation

2019-01-10 Thread Richard Henderson
The branch target exception for guarded pages has high priority, and only 8 instructions are valid for that case. Perform this check before doing any other decode. Clear BTYPE after all insns that neither set BTYPE nor exit via exception (DISAS_NORETURN). Not yet handled are insns that exit via

[Qemu-devel] [PATCH 08/11] target/arm: Add guarded_pages cpu property for user-only

2019-01-10 Thread Richard Henderson
While waiting for a proper userland ABI, allow static test cases to be written assuming that GP is set for all pages. Signed-off-by: Richard Henderson --- target/arm/cpu.h | 4 target/arm/cpu64.c | 18 ++ target/arm/translate-a64.c | 8 +++- 3 files c

[Qemu-devel] [PATCH 06/11] target/arm: Reset btype for direct branches and syscalls

2019-01-10 Thread Richard Henderson
This is all of the non-exception cases of DISAS_NORETURN. For the rest of the synchronous exceptions, the state of SPSR_ELx.BTYPE is CONSTRAINED UNPREDICTABLE. However, it makes more sense to me to have syscalls reset BTYPE. Signed-off-by: Richard Henderson --- target/arm/translate-a64.c | 9 +

[Qemu-devel] [PATCH 11/11] tests/tcg/aarch64: Add bti smoke test

2019-01-10 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tests/tcg/aarch64/bti-1.c | 61 +++ tests/tcg/aarch64/bti-crt.inc.c | 51 ++ tests/tcg/aarch64/Makefile.target | 7 +++- 3 files changed, 118 insertions(+), 1 deletion(-) create mode 100644 tests/

Re: [Qemu-devel] [PATCH v2 5/6] nbd: Merge nbd_export_bitmap into nbd_export_new

2019-01-10 Thread Vladimir Sementsov-Ogievskiy
10.01.2019 10:13, Eric Blake wrote: > We only have one caller that wants to export a bitmap name, > which it does right after creation of the export. But there is > still a brief window of time where an NBD client could see the > export but not the dirty bitmap, which a robust client would > have t

[Qemu-devel] [PATCH] pc-bios/s390-ccw: Use proper register names for Clang

2019-01-10 Thread Thomas Huth
When compiling the s390-ccw firmware with Clang 7.0.1, I get the following errors: pc-bios/s390-ccw/start.S:62:19: error: invalid use of length addressing stctg 0,0,0(15) ^ pc-bios/s390-ccw/start.S:63:12: error: invalid use of length addressing oi 6(15), 0x2

Re: [Qemu-devel] [PATCH v2 1/1] include: Auto-generate the sizes lookup table

2019-01-10 Thread Markus Armbruster
Leonid Bloch writes: > Hi, > > On 1/8/19 11:31 AM, Markus Armbruster wrote: >> I'd leave it hard-coded. Replacing a few trivial defines by an arguably >> less trivial script doesn't feel like an improvement. In this case, it >> doesn't even save lines. > > As I've said, I'm fine with that. The

Re: [Qemu-devel] [PATCH] pc-bios/s390-ccw: Use proper register names for Clang

2019-01-10 Thread Christian Borntraeger
On 10.01.2019 13:32, Thomas Huth wrote: > When compiling the s390-ccw firmware with Clang 7.0.1, I get the > following errors: > > pc-bios/s390-ccw/start.S:62:19: error: invalid use of length addressing > stctg 0,0,0(15) > ^ > pc-bios/s390-ccw/start.S:63:12: error: inv

[Qemu-devel] [PATCH 4/4] target/arm: Enable TBI for user-only

2019-01-10 Thread Richard Henderson
This has been enabled in the linux kernel since v3.11 (commit d50240a5f6cea, 2013-09-03, "arm64: mm: permit use of tagged pointers at EL0"). Signed-off-by: Richard Henderson --- target/arm/cpu.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/target/arm/cpu.c b/target/arm/cpu.c index 1

[Qemu-devel] [PATCH 1/4] target/arm: Add TBFLAG_A64_TBID, split out gen_top_byte_ignore

2019-01-10 Thread Richard Henderson
Split out gen_top_byte_ignore in preparation of handling these data accesses; the new tbflags field is not yet honored. Signed-off-by: Richard Henderson --- target/arm/cpu.h | 1 + target/arm/translate.h | 3 ++- target/arm/helper.c| 1 + target/arm/translate-a64.c | 40

  1   2   3   4   >