On 10.01.2019 13:32, Thomas Huth wrote:
> When compiling the s390-ccw firmware with Clang 7.0.1, I get the
> following errors:
>
> pc-bios/s390-ccw/start.S:62:19: error: invalid use of length addressing
> stctg 0,0,0(15)
> ^
> pc-bios/s390-ccw/start.S:63:12: error: invalid use of length addressing
> oi 6(15), 0x2
> ^
> pc-bios/s390-ccw/start.S:64:19: error: invalid use of length addressing
> lctlg 0,0,0(15)
> ^
> pc-bios/s390-ccw/start.S:76:19: error: invalid use of length addressing
> stctg 0,0,0(15)
> ^
> pc-bios/s390-ccw/start.S:77:12: error: invalid use of length addressing
> ni 6(15), 0xfd
> ^
> pc-bios/s390-ccw/start.S:78:19: error: invalid use of length addressing
> lctlg 0,0,0(15)
> ^
> pc-bios/s390-ccw/start.S:79:12: error: invalid operand for instruction
> br 14
> ^
>
> Let's use proper register names like in the rest of this file to fix it.
Sad that this does no longer work, but
Reviewed-by: Christian Borntraeger <[email protected]>
>
> Signed-off-by: Thomas Huth <[email protected]>
> ---
> pc-bios/s390-ccw/start.S | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/pc-bios/s390-ccw/start.S b/pc-bios/s390-ccw/start.S
> index eb8d024..3b7fa3f 100644
> --- a/pc-bios/s390-ccw/start.S
> +++ b/pc-bios/s390-ccw/start.S
> @@ -59,9 +59,9 @@ disabled_wait:
> .globl consume_sclp_int
> consume_sclp_int:
> /* enable service interrupts in cr0 */
> - stctg 0,0,0(15)
> - oi 6(15), 0x2
> - lctlg 0,0,0(15)
> + stctg %c0,%c0,0(%r15)
> + oi 6(%r15),0x2
> + lctlg %c0,%c0,0(%r15)
> /* prepare external call handler */
> larl %r1, external_new_code
> stg %r1, 0x1b8
> @@ -73,10 +73,10 @@ consume_sclp_int:
>
> external_new_code:
> /* disable service interrupts in cr0 */
> - stctg 0,0,0(15)
> - ni 6(15), 0xfd
> - lctlg 0,0,0(15)
> - br 14
> + stctg %c0,%c0,0(%r15)
> + ni 6(%r15),0xfd
> + lctlg %c0,%c0,0(%r15)
> + br %r14
>
> .align 8
> disabled_wait_psw:
>
