Re: [Qemu-devel] [RFC PATCH 13/25] scsi: express dependencies with Kconfig

2019-01-08 Thread Yang Zhong
On Fri, Jan 04, 2019 at 02:39:50PM +0100, Thomas Huth wrote: > On 2018-12-27 07:34, Yang Zhong wrote: > > From: Paolo Bonzini > > > > This lets you disable SCSI altogether with "CONFIG_SCSI=n". > > > > Signed-off-by: Paolo Bonzini > > Signed-off-by: Yang Zhong > > --- > > hw/scsi/Kconfig

[Qemu-devel] [Bug 1810603] Re: QEMU QCow Images grow dramatically

2019-01-08 Thread Lenny Helpline
I don't have many commands handy, as we manage almost everything through libvirt manager. 3) create a snapshot of the lined clone: virsh snapshot-create-as --domain --name "test" --halt 4) revert the snapshot every X minutes / hours: virsh destroy virsh snapshot-revert --snapshotname test --r

[Qemu-devel] [PATCH v14 2/6] tpm: allocate/map buffer for TPM Physical Presence interface

2019-01-08 Thread Marc-André Lureau
From: Stefan Berger Implement a virtual memory device for the TPM Physical Presence interface. The memory is located at 0xFED45000 and used by ACPI to send messages to the firmware (BIOS) and by the firmware to provide parameters for each one of the supported codes. This interface should be used

[Qemu-devel] [PATCH v14 1/6] tpm: add a "ppi" boolean property

2019-01-08 Thread Marc-André Lureau
The following patches implement the TPM Physical Presence Interface, make use of a new memory region and a fw_cfg entry. Enable PPI by default with >=4.0 machine type, to avoid migration issues. Signed-off-by: Marc-André Lureau Reviewed-by: Igor Mammedov Reviewed-by: Philippe Mathieu-Daudé ---

[Qemu-devel] [PATCH v14 3/6] acpi: expose TPM/PPI configuration parameters to firmware via fw_cfg

2019-01-08 Thread Marc-André Lureau
From: Stefan Berger To avoid having to hard code the base address of the PPI virtual memory device we introduce a fw_cfg file etc/tpm/config that holds the base address of the PPI device, the version of the PPI interface and the version of the attached TPM. Signed-off-by: Stefan Berger [ Marc-A

[Qemu-devel] [PATCH v14 0/6] Add support for TPM Physical Presence interface

2019-01-08 Thread Marc-André Lureau
Hi, The following patches implement the TPM Physical Presence Interface that allows a user to set a command via ACPI (sysfs entry in Linux) that, upon the next reboot, the firmware looks for and acts upon by sending sequences of commands to the TPM. A dedicated memory region is added to the TPM C

[Qemu-devel] [PATCH v14 6/6] tpm: clear RAM when "memory overwrite" requested

2019-01-08 Thread Marc-André Lureau
Note: the "Platform Reset Attack Mitigation" specification isn't explicit about NVDIMM, since they could have different usages. It uses the term "system memory" generally (and also "volatile memory RAM" in its introduction). For initial support, I propose to consider non-volatile memory as not bein

[Qemu-devel] [PATCH v14 5/6] acpi: add ACPI memory clear interface

2019-01-08 Thread Marc-André Lureau
The interface is described in the "TCG Platform Reset Attack Mitigation Specification", chapter 6 "ACPI _DSM Function". According to Laszlo, it's not so easy to implement in OVMF, he suggested to do it in qemu instead. See specification documentation for more details, and next commit for memory cl

Re: [Qemu-devel] [PATCH PULL 02/31] contrib/rdmacm-mux: Add implementation of RDMA User MAD multiplexer

2019-01-08 Thread Marcel Apfelbaum
On 1/7/19 7:54 PM, Cornelia Huck wrote: On Mon, 7 Jan 2019 19:28:10 +0200 Marcel Apfelbaum wrote: On 1/3/19 12:34 PM, Cornelia Huck wrote: On Sat, 22 Dec 2018 11:50:07 +0200 Marcel Apfelbaum wrote: From: Yuval Shaia RDMA MAD kernel module (ibcm) disallow more than one MAD-agent for

[Qemu-devel] [PATCH v14 4/6] acpi: build TPM Physical Presence interface

2019-01-08 Thread Marc-André Lureau
From: Stefan Berger The TPM Physical Presence interface consists of an ACPI part, a shared memory part, and code in the firmware. Users can send messages to the firmware by writing a code into the shared memory through invoking the ACPI code. When a reboot happens, the firmware looks for the code

Re: [Qemu-devel] [PATCH for-4.0 v9 09/16] qemu_thread: supplement error handling for pci_edu_realize

2019-01-08 Thread Markus Armbruster
Peter Xu writes: > On Tue, Jan 08, 2019 at 07:14:11AM +0100, Jiri Slaby wrote: >> On 07. 01. 19, 18:29, Markus Armbruster wrote: >> >static void pci_edu_uninit(PCIDevice *pdev) >> >{ >> >EduState *edu = EDU(pdev); >> > >> >qemu_mutex_lock(&edu->thr_mutex); >> >edu

Re: [Qemu-devel] [RFC PATCH 15/25] isa: express dependencies with kconfig

2019-01-08 Thread Yang Zhong
On Fri, Jan 04, 2019 at 02:55:20PM +0100, Thomas Huth wrote: > On 2018-12-27 07:34, Yang Zhong wrote: > > From: Paolo Bonzini > > > > Signed-off-by: Paolo Bonzini > > Signed-off-by: Yang Zhong > > --- > [...] > > diff --git a/hw/display/Kconfig b/hw/display/Kconfig > > index 5e73277cc2..e0d7919

Re: [Qemu-devel] [PATCH PULL 02/31] contrib/rdmacm-mux: Add implementation of RDMA User MAD multiplexer

2019-01-08 Thread Cornelia Huck
On Tue, 8 Jan 2019 10:41:38 +0200 Marcel Apfelbaum wrote: > On 1/7/19 7:54 PM, Cornelia Huck wrote: > > On Mon, 7 Jan 2019 19:28:10 +0200 > > Marcel Apfelbaum wrote: > > > >> On 1/3/19 12:34 PM, Cornelia Huck wrote: > >>> clang-6.0: error: -libumad: 'linker' input unused > >>> [-Werror,-Wu

Re: [Qemu-devel] [RFC PATCH 17/25] i2c: express dependencies with Kconfig

2019-01-08 Thread Yang Zhong
On Fri, Jan 04, 2019 at 04:30:01PM +0100, Thomas Huth wrote: > On 2018-12-27 07:34, Yang Zhong wrote: > > From: Paolo Bonzini > > > > Signed-off-by: Paolo Bonzini > > Signed-off-by: Yang Zhong > > --- > [...] > > diff --git a/hw/display/Kconfig b/hw/display/Kconfig > > index 8ce968bfff..8ddce09

Re: [Qemu-devel] [PATCH v4 06/16] virtio: split virtio 9p bits from virtio-pci

2019-01-08 Thread Greg Kurz
On Thu, 3 Jan 2019 15:10:03 +0100 Juan Quintela wrote: > Reviewed-by: Laurent Vivier > Signed-off-by: Juan Quintela > > --- > It looks like you didn't collect some ack/review tags from v3, so: Acked-by: Greg Kurz > Also disable virtio9p test (lvivier) > --- > hw/virtio/Makefile.objs |

Re: [Qemu-devel] [PATCH v4 16/16] virtio: virtio 9p really requires CONFIG_VIRTFS to work

2019-01-08 Thread Greg Kurz
On Thu, 3 Jan 2019 15:10:13 +0100 Juan Quintela wrote: > Signed-off-by: Juan Quintela > --- Reviewed-by: Greg Kurz > default-configs/virtio.mak | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/default-configs/virtio.mak b/default-configs/virtio.mak > index 5ae4a6101

Re: [Qemu-devel] [PATCH v2 1/1] include: Auto-generate the sizes lookup table

2019-01-08 Thread Markus Armbruster
Copying our resident shell script guru Eric. Leonid Bloch writes: > The lookup table for power-of-two sizes is now auto-generated during the > build, and not hard-coded into the units.h file. > > This partially reverts commit 540b8492618eb. > > Signed-off-by: Leonid Bloch > --- > .gitignore

Re: [Qemu-devel] [PATCH 06/15] spapr: enable PHB hotplug for default pseries machine type

2019-01-08 Thread Greg Kurz
On Thu, 3 Jan 2019 13:00:58 +1100 David Gibson wrote: > On Fri, Dec 21, 2018 at 01:36:32AM +0100, Greg Kurz wrote: > > From: Michael Roth > > > > The 'dr_phb_enabled' field of that class can be set as part of > > machine-specific init code. It will be used to conditionally > > enable creation o

Re: [Qemu-devel] [PATCH 1/3] spapr: Eliminate SPAPR_PCI_2_7_MMIO_WIN_SIZE macro

2019-01-08 Thread Cornelia Huck
On Mon, 7 Jan 2019 17:30:18 -0200 Eduardo Habkost wrote: > The macro is only used in one place, where the purpose of the > value is obvious. Eliminate the macro so we don't need to rely > on stringify(). > > Signed-off-by: Eduardo Habkost > --- > include/hw/pci-host/spapr.h | 1 - > hw/ppc/s

Re: [Qemu-devel] [PATCH 2/3] machine: Eliminate unnecessary stringify() usage

2019-01-08 Thread Cornelia Huck
On Mon, 7 Jan 2019 17:30:19 -0200 Eduardo Habkost wrote: > stringify() is useful when we need to use macros in compat_props > (like when we set virtio-baloon-pci.class=PCI_CLASS_MEMORY_RAM at > pc_i440fx_1_0_machine_options()), but it is pointless when we are > already providing a number literal

Re: [Qemu-devel] [PATCH 15/15] spapr: add hotplug hooks for PHB hotplug

2019-01-08 Thread Greg Kurz
On Thu, 3 Jan 2019 13:17:03 +1100 David Gibson wrote: > On Fri, Dec 21, 2018 at 07:36:12AM +0100, Greg Kurz wrote: > > From: Michael Roth > > > > Hotplugging PHBs is a machine-level operation, but PHBs reside on the > > main system bus, so we register spapr machine as the handler for the > > ma

Re: [Qemu-devel] [PATCH 3/3] machine: Use shorter format for GlobalProperty arrays

2019-01-08 Thread Cornelia Huck
On Tue, 8 Jan 2019 07:45:43 +0100 Gerd Hoffmann wrote: > Hi, > > > +{ "migration", "decompress-error-check", "off" }, > > +{ "hda-audio", "use-timer", "false" }, > > +{ "cirrus-vga", "global-vmstate", "true" }, > > +{ "VGA", "global-vmstate", "true" }, > > +{ "vmware-svga",

Re: [Qemu-devel] [PATCH 3/3] machine: Use shorter format for GlobalProperty arrays

2019-01-08 Thread Cornelia Huck
On Mon, 7 Jan 2019 17:30:20 -0200 Eduardo Habkost wrote: > Instead of verbose arrays with 4 lines for each entry, make each > entry take only one line. This makes long arrays that couldn't > fit in the screen become short and readable. > > Signed-off-by: Eduardo Habkost > --- > include/hw/i3

[Qemu-devel] [PATCH] i2c-ddc: fix oob read

2019-01-08 Thread Gerd Hoffmann
Suggested-by: Michael Hanselmann Signed-off-by: Gerd Hoffmann --- hw/i2c/i2c-ddc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i2c/i2c-ddc.c b/hw/i2c/i2c-ddc.c index be34fe072c..0a0367ff38 100644 --- a/hw/i2c/i2c-ddc.c +++ b/hw/i2c/i2c-ddc.c @@ -56,7 +56,7 @@ static in

Re: [Qemu-devel] [PULL v4 00/35] Misc patches for 2018-12-18

2019-01-08 Thread Peter Maydell
On Mon, 7 Jan 2019 at 22:35, Paolo Bonzini wrote: > > The following changes since commit 9b2e891ec5ccdb4a7d583b77988848282606fdea: > > Merge remote-tracking branch 'remotes/marcel/tags/rdma-pull-request' into > staging (2018-12-22 11:25:31 +) > > are available in the Git repository at: > >

Re: [Qemu-devel] [PATCH] json: Fix % handling when not interpolating

2019-01-08 Thread Markus Armbruster
Copying block maintainers for help with assessing the bug's (non-)impact on security. Christophe Fergeau writes: > On Mon, Jan 07, 2019 at 04:47:44PM +0100, Markus Armbruster wrote: >> Eric Blake writes: >> >> > On 1/2/19 12:01 PM, Christophe Fergeau wrote: >> >> Adding Markus to cc: list, I f

Re: [Qemu-devel] [PATCH] i2c-ddc: fix oob read

2019-01-08 Thread Michael Hanselmann
On 08.01.19 11:23, Gerd Hoffmann wrote: > Suggested-by: Michael Hanselmann > Signed-off-by: Gerd Hoffmann Looks good to me. Reviewed-by: Michael Hanselmann signature.asc Description: OpenPGP digital signature

Re: [Qemu-devel] [RFC PATCH 20/25] hyperv: express dependencies with kconfig

2019-01-08 Thread Yang Zhong
On Fri, Jan 04, 2019 at 04:38:34PM +0100, Thomas Huth wrote: > On 2018-12-27 07:34, Yang Zhong wrote: > > remove default-configs/hyperv.mak and make dependencies > > with Kconfig. > > > > Signed-off-by: Yang Zhong > > --- > > default-configs/hyperv.mak | 2 -- > > default-configs/i386-soft

Re: [Qemu-devel] [RFC PATCH 20/25] hyperv: express dependencies with kconfig

2019-01-08 Thread Yang Zhong
On Fri, Jan 04, 2019 at 08:50:23PM +0100, Paolo Bonzini wrote: > On 04/01/19 16:38, Thomas Huth wrote: > > On 2018-12-27 07:34, Yang Zhong wrote: > >> remove default-configs/hyperv.mak and make dependencies > >> with Kconfig. > >> > >> Signed-off-by: Yang Zhong > >> --- > >> default-configs/hyper

Re: [Qemu-devel] [RFC PATCH 21/25] virtio: make virtio dependencies with Kconfig

2019-01-08 Thread Yang Zhong
On Fri, Jan 04, 2019 at 08:54:54PM +0100, Thomas Huth wrote: > On 2018-12-27 07:34, Yang Zhong wrote: > > Signed-off-by: Yang Zhong > > --- > > default-configs/i386-softmmu.mak | 1 - > > hw/9pfs/Kconfig | 2 ++ > > hw/block/Kconfig | 2 ++ > > hw/char/Kconfig

Re: [Qemu-devel] [PATCH v6 04/11] block: remove 'x' prefix from experimental bitmap APIs

2019-01-08 Thread Vladimir Sementsov-Ogievskiy
04.01.2019 2:21, Eric Blake wrote: > On 12/21/18 3:35 AM, John Snow wrote: >> The 'x' prefix was added because I was uncertain of the direction we'd >> take for the libvirt API. With the general approach solidified, I feel >> comfortable committing to this API for 4.0. >> >> Signed-off-by: John Sno

Re: [Qemu-devel] [RFC PATCH 22/25] i386-softmmu.mak: remove all CONFIG_* except boards definitions

2019-01-08 Thread Yang Zhong
Hello Paolo, Thanks for detailed comments, i will change this one by one. The previous plan put all "selects" into hw/i386/Kconfig file, which can easily config board if we want to optimize i440fx or q35 platform. The new solution will spread "selects" into detailed hw/*/Kconfig file. Regards,

Re: [Qemu-devel] [RFC PATCH 23/25] x86_64-softmmu.mak: remove i386-softmmu.mak include

2019-01-08 Thread Yang Zhong
On Fri, Jan 04, 2019 at 08:58:09PM +0100, Thomas Huth wrote: > On 2018-12-27 07:34, Yang Zhong wrote: > > Only keep same boards definitions as i386-softmmu.mak in > > x86_64-softmmu.mak. > > > > Signed-off-by: Yang Zhong > > --- > > default-configs/x86_64-softmmu.mak | 6 +- > > 1 file chang

Re: [Qemu-devel] [RFC PATCH 23/25] x86_64-softmmu.mak: remove i386-softmmu.mak include

2019-01-08 Thread Yang Zhong
On Sat, Jan 05, 2019 at 03:32:13PM +, Peter Maydell wrote: > On Thu, 27 Dec 2018 at 06:35, Yang Zhong wrote: > > > > Only keep same boards definitions as i386-softmmu.mak in > > x86_64-softmmu.mak. > > > > Signed-off-by: Yang Zhong > > --- > > default-configs/x86_64-softmmu.mak | 6 +- >

Re: [Qemu-devel] [PATCH 10/15] s390-bios: Support for running format-0/1 channel programs

2019-01-08 Thread Cornelia Huck
On Mon, 7 Jan 2019 14:02:45 -0500 "Jason J. Herne" wrote: > On 12/13/18 12:21 PM, Cornelia Huck wrote: > > On Wed, 12 Dec 2018 09:11:13 -0500 > > "Jason J. Herne" wrote: > > > >> Add struct for format-0 ccws. Support executing format-0 channel > >> programs and waiting for their completion be

Re: [Qemu-devel] do not lseek in qcow2 block_status

2019-01-08 Thread Vladimir Sementsov-Ogievskiy
07.01.2019 15:52, Max Reitz wrote: > On 24.12.18 16:50, Vladimir Sementsov-Ogievskiy wrote: >> Hi all! >> >> bdrv_co_block_status digs bs->file for additional, more accurate search for >> hole >> inside region, reported as DATA by bs since long-ago >> >> commit 5daa74a6ebce7543aaad178c4061dc08

Re: [Qemu-devel] [PATCH v1] dump: Set correct vaddr for ELF dump

2019-01-08 Thread Laszlo Ersek
On 01/08/19 07:31, Jon Doron wrote: > Thank you for looking into this, perhaps I could change the patch (at > least in the C part not the python script) to something like: > -phdr.p_vaddr = cpu_to_dumpXX(s, memory_mapping->virt_addr); > +phdr.p_vaddr = cpu_to_dumpXX(s, memory_mapping->virt_

Re: [Qemu-devel] [PATCH] usb: drop unnecessary usb_device_post_load checks

2019-01-08 Thread Gerd Hoffmann
On Mon, Jan 07, 2019 at 05:51:40PM +, Jonathan Davies wrote: > In usb_device_post_load, certain values of dev->setup_len or > dev->setup_index can cause -EINVAL to be returned. One example is when > setup_len exceeds 4096, the hard-coded value of sizeof(dev->data_buf). > This can happen through

Re: [Qemu-devel] [PATCH] usb: dev-mtp: fix memory leak in error path

2019-01-08 Thread Gerd Hoffmann
On Thu, Jan 03, 2019 at 02:38:25PM +0100, Philippe Mathieu-Daudé wrote: > On 1/3/19 2:26 PM, Li Qiang wrote: > > Spotted by Coverity: CID 1397074 > > > > Gerd, if you take this, can you add: > > Fixes: c52d46e041b Done. Thanks for looking up. cheers, Gerd

Re: [Qemu-devel] [PATCH] hw/usb: Add generic sys-bus EHCI controller

2019-01-08 Thread Gerd Hoffmann
On Sat, Dec 29, 2018 at 06:00:57PM +0800, Hongbo Zhang wrote: > This patch introduces a new system bus generic EHCI controller. > For the system bus EHCI controller, we've already had "xlnx", > "exynos4210", "tegra2", "ppc4xx" and "fusbh200", they are specific and > only suitable for their own plat

Re: [Qemu-devel] [PULL 0/3] target/alpha update

2019-01-08 Thread Peter Maydell
ll/tags/pull-target-arm-20190107' into staging (2019-01-07 > 16:56:33 +) > > are available in the Git repository at: > > https://github.com/rth7680/qemu.git tags/pull-axp-20190108 > > for you to fetch changes up to ac89de40ef5d4eb1704aa830342a5371413a81dc:

Re: [Qemu-devel] [RFC PATCH 13/25] scsi: express dependencies with Kconfig

2019-01-08 Thread Paolo Bonzini
On 08/01/19 09:04, Yang Zhong wrote: > On Fri, Jan 04, 2019 at 02:39:50PM +0100, Thomas Huth wrote: >> On 2018-12-27 07:34, Yang Zhong wrote: >>> From: Paolo Bonzini >>> >>> This lets you disable SCSI altogether with "CONFIG_SCSI=n". >>> >>> Signed-off-by: Paolo Bonzini >>> Signed-off-by: Yang Zh

Re: [Qemu-devel] [PATCH v2] usb: move ehci_create_ich9_with_companions to hw/i386

2019-01-08 Thread Gerd Hoffmann
On Mon, Dec 17, 2018 at 05:32:38PM +0100, Paolo Bonzini wrote: > This function is only needed when Q35 is in use. Moving it to > the same file that uses it lets you disable the entire USB > subsystem in x86_64-softmmu.mak; of course doing that will > cause -usb to break horribly, but one thing at

Re: [Qemu-devel] [RFC PATCH 17/25] i2c: express dependencies with Kconfig

2019-01-08 Thread Paolo Bonzini
On 08/01/19 10:15, Yang Zhong wrote: >> config SM501 >> bool >> +depends on I2C >> >> config TCX >> bool > I think XLNX_ZYNQMP_ARM likely needs "depends on I2C" nowadays, too ? CONFIG_DDC should depend on I2C, while CONFIG_AUX should select I2C. In a second phase, XLNX_ZYNQMP wi

[Qemu-devel] [PATCH 0/5] intel_iommu: misc fixes for error exposed after error_report_once()

2019-01-08 Thread Peter Xu
Recently we have switched quite a few VT-d trace points into error_report_once()s and this does expose some errors that we didn't detect before (previously tracepoints won't trigger as long as tracepoints weren't enabled). These errors are not severe in that all of them will not affect functionali

[Qemu-devel] [PATCH 2/5] intel_iommu: reset intr_enabled when system reset

2019-01-08 Thread Peter Xu
This is found when I was debugging another problem. Until now no bug is reported with this but we'd better reset the IR status correctly after a system reset. Signed-off-by: Peter Xu --- hw/i386/intel_iommu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/i386/intel_iommu.c b/hw/i386/in

[Qemu-devel] [PATCH 5/5] vfio: retry one more time conditionally for type1 unmap

2019-01-08 Thread Peter Xu
In Linux version v4.15+ there's a bug (introduced in 71a7d3d78e3c, "vfio/type1: silence integer overflow warning", 2017-10-20) that could potentially reject a valid unmap region that covers exactly the whole u64 address space (like iova=0xfef0, size=2^64-0xfef0). Besides a fix on the kernel

[Qemu-devel] [PATCH 1/5] intel_iommu: fix operator in vtd_switch_address_space

2019-01-08 Thread Peter Xu
When calculating use_iommu, we wanted to first detect whether DMAR is enabled, then check whether PT is enabled if DMAR is enabled. However in the current code we used "&" rather than "&&" so the ordering requirement is lost (instead it'll be an "AND" operation). This could introduce errors dumpe

[Qemu-devel] [PATCH 3/5] pci/msi: export msi_is_masked()

2019-01-08 Thread Peter Xu
It is going to be used later on outside MSI code to detect whether one MSI vector is masked out. Signed-off-by: Peter Xu --- hw/pci/msi.c | 2 +- include/hw/pci/msi.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/pci/msi.c b/hw/pci/msi.c index 5e05ce5ec2..47d2b0

[Qemu-devel] [PATCH 4/5] i386/kvm: ignore masked irqs when update msi routes

2019-01-08 Thread Peter Xu
When we are with intel-iommu device and with IR on, KVM will register an IEC notifier to detect interrupt updates from the guest and we'll kick off kvm_update_msi_routes_all() when it happens to make sure kernel IRQ cache is matching the latest. Though, kvm_update_msi_routes_all() is buggy in that

Re: [Qemu-devel] [PATCH] hw/char/stm32f2xx_usart: Do not update data register when device is disabled

2019-01-08 Thread Peter Maydell
On Fri, 4 Jan 2019 at 18:21, Philippe Mathieu-Daudé wrote: > > When the device is disable, the internal circuitry keep the data > register loaded and doesn't update it. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/char/stm32f2xx_usart.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deleti

Re: [Qemu-devel] [RFC PATCH 22/25] i386-softmmu.mak: remove all CONFIG_* except boards definitions

2019-01-08 Thread Paolo Bonzini
On 08/01/19 11:53, Yang Zhong wrote: > Thanks for detailed comments, i will change this one by one. > The previous plan put all "selects" into hw/i386/Kconfig file, which > can easily config board if we want to optimize i440fx or q35 platform. The selects are for mandatory devices, so if you remov

Re: [Qemu-devel] [PATCH v3] hw/arm/virt-acpi-build: Set COHACC override flag in IORT SMMUv3 node

2019-01-08 Thread Peter Maydell
On Mon, 7 Jan 2019 at 10:10, Eric Auger wrote: > > Let's report IO-coherent access is supported for translation > table walks, descriptor fetches and queues by setting the COHACC > override flag. Without that, we observe wrong command opcodes. > The DT description also advertises the dma coherency

Re: [Qemu-devel] [PATCH] arm: Stub out NRF51 TWI magnetometer/accelerometer detection

2019-01-08 Thread Peter Maydell
On Sat, 5 Jan 2019 at 15:02, Stefan Hajnoczi wrote: > > From: Steffen Görtz > > Recent microbit firmwares panic if the TWI magnetometer/accelerometer > devices are not detected during startup. We don't implement TWI (I2C) > so let's stub out these devices just to let the firmware boot. > > Signe

[Qemu-devel] [Bug 1810545] Re: [alpha] Strange exception address reported

2019-01-08 Thread Peter Maydell
commit ac89de40ef5d4eb1704aa now in QEMU git master updates the palcode guest ROM blob to a version which includes the fix for this bug. ** Changed in: qemu Status: New => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed

Re: [Qemu-devel] [PATCH 0/2] Break down the MTP write operation

2019-01-08 Thread Gerd Hoffmann
Hi, > For larger files, not only do we keep reallocating to increase the mtp buffer > size, the write also happens in one go. This does two things: > > Write to file upto a certain data size we have received so far and second, > reuse the buffer again instead of reallocating to a larger buffer

Re: [Qemu-devel] [PATCH] hw/usb: Add generic sys-bus EHCI controller

2019-01-08 Thread BALATON Zoltan
On Tue, 8 Jan 2019, Gerd Hoffmann wrote: On Sat, Dec 29, 2018 at 06:00:57PM +0800, Hongbo Zhang wrote: This patch introduces a new system bus generic EHCI controller. For the system bus EHCI controller, we've already had "xlnx", "exynos4210", "tegra2", "ppc4xx" and "fusbh200", they are specific

Re: [Qemu-devel] [PATCH 1/8] target/mips: Move comment containing summary of CP0 registers

2019-01-08 Thread Aleksandar Markovic
On Thursday, January 3, 2019, Aleksandar Markovic < aleksandar.marko...@rt-rk.com> wrote: > From: Aleksandar Markovic > > Move comment containing summary of CP0 registers. Checkpatch > script reported some tabs in the resutling diff, so convert > these tabs to spaces too. > > Signed-off-by: Aleks

Re: [Qemu-devel] [PATCH v2] qemu-io: Reinitialize optind to 1 (not 0) before parsing inner command.

2019-01-08 Thread Kevin Wolf
Am 07.01.2019 um 19:40 hat Richard W.M. Jones geschrieben: > On Mon, Jan 07, 2019 at 06:50:53PM +0100, Max Reitz wrote: > [...] > > I don't particularly care how we fix this, but it breaks the nbdkit > tests on FreeBSD so I am keen to fix it one way or another. > > > And if optreset not being ava

Re: [Qemu-devel] [PATCH v2 1/1] include: Auto-generate the sizes lookup table

2019-01-08 Thread Kevin Wolf
Am 03.01.2019 um 22:33 hat Leonid Bloch geschrieben: > The lookup table for power-of-two sizes is now auto-generated during the > build, and not hard-coded into the units.h file. > > This partially reverts commit 540b8492618eb. > > Signed-off-by: Leonid Bloch During a downstream review, Max fou

Re: [Qemu-devel] [PATCH] hw/usb: Add generic sys-bus EHCI controller

2019-01-08 Thread Gerd Hoffmann
On Tue, Jan 08, 2019 at 01:11:29PM +0100, BALATON Zoltan wrote: > On Tue, 8 Jan 2019, Gerd Hoffmann wrote: > > On Sat, Dec 29, 2018 at 06:00:57PM +0800, Hongbo Zhang wrote: > > > This patch introduces a new system bus generic EHCI controller. > > > For the system bus EHCI controller, we've already

[Qemu-devel] [PATCH] qmp-shell: Fix example with objects as values

2019-01-08 Thread Anthony PERARD
The example shown that is suppose to let a user passes an object/array as argument doesn't work. The quotes get removed by shlex.split() and then both JSON parser complains. Fix the example by adding quotes and add examples with boolean and array. Signed-off-by: Anthony PERARD --- scripts/qmp/qm

Re: [Qemu-devel] [PATCH 1/1] qdev: rename qdev_create() argument to sync with qdev_try_create()

2019-01-08 Thread Markus Armbruster
Dongli Zhang writes: > The second argument used by qdev_create() is typename and 'name' is very > confusing. Rename it from 'name' to 'type', which is the same used by > qdev_try_create(). > > Signed-off-by: Dongli Zhang > --- > hw/core/qdev.c | 8 > 1 file changed, 4 insertions(+), 4

[Qemu-devel] [PATCH v1 0/3] gitdm updates

2019-01-08 Thread Aleksandar Markovic
On Monday, January 7, 2019, Alex Bennée wrote: > > Hi, > > Added a few more updates mostly of IBMers with non corporate emails. Hi, Alex, could you please add leon.al...@imgtec.com to Wave Computing group? (my email client automatically inserts and displays "ae" as one letter, the last name

Re: [Qemu-devel] [PATCH v2 1/3] util/cutils: Move size_to_str() from "qemu-common.h" to "cutils.h"

2019-01-08 Thread Cornelia Huck
On Fri, 4 Jan 2019 19:12:06 +0100 Philippe Mathieu-Daudé wrote: > The size_to_str() function doesn't need to be in a generic header. > > It makes also sens to find this function in the same header than > the opposite string to size functions: qemu_strtosz*(). > Note than this function is alread

Re: [Qemu-devel] [RFC] Questions on the I/O performance of emulated host cdrom device

2019-01-08 Thread Kevin Wolf
Am 29.12.2018 um 07:33 hat Ying Fang geschrieben: > Hi. > Recently one of our customer complained about the I/O performance of QEMU > emulated host cdrom device. > I did some investigation on it and there was still some point I could not > figure out. So I had to ask for your help. > > Here is t

Re: [Qemu-devel] [PATCH v7 16/18] xen: automatically create XenBlockDevice-s

2019-01-08 Thread Kevin Wolf
Am 04.01.2019 um 17:40 hat Paul Durrant geschrieben: > > -Original Message- > > From: Anthony PERARD [mailto:anthony.per...@citrix.com] > > Sent: 04 January 2019 16:31 > > To: Paul Durrant > > Cc: qemu-devel@nongnu.org; qemu-bl...@nongnu.org; xen- > > de...@lists.xenproject.org; Kevin Wolf

Re: [Qemu-devel] [PATCH v2 2/3] util/cutils: Move ctype macros to "cutils.h"

2019-01-08 Thread Cornelia Huck
On Fri, 4 Jan 2019 14:15:49 -0600 Eric Blake wrote: > On 1/4/19 12:12 PM, Philippe Mathieu-Daudé wrote: > > Introduced in cd390083ad1, these macros don't need to be in > > a generic header. > > Add documentation to justify their use. > > > > Reviewed-by: Stefano Garzarella > > Signed-off-by: Ph

Re: [Qemu-devel] [PATCH v2 3/3] util/cutils: Move function documentations to the header

2019-01-08 Thread Cornelia Huck
On Fri, 4 Jan 2019 14:17:14 -0600 Eric Blake wrote: > On 1/4/19 12:12 PM, Philippe Mathieu-Daudé wrote: > > Many functions have documentation before the implementation in > > cutils.c. Since we expect documentation around the prototype > > declaration in headers, move the comments in cutils.h. >

Re: [Qemu-devel] [PATCH for-4.0] ui/console: Remove qemu_create_display_surface_guestmem()

2019-01-08 Thread Peter Maydell
On Mon, 10 Dec 2018 at 14:31, Gerd Hoffmann wrote: > > On Thu, Nov 22, 2018 at 05:03:09PM +, Peter Maydell wrote: > > The qemu_create_display_surface_guestmem() function was added in > > commit a77549b3ffcc24c32ee4e but apparently never used. Remove it. > > > > (The API of this function is in

[Qemu-devel] [PATCH v2] dump: Set correct vaddr for ELF dump

2019-01-08 Thread Jon Doron
vaddr needs to be equal to the paddr since the dump file represents the physical memory image. Without setting vaddr correctly, GDB would load all the different memory regions on top of each other to vaddr 0, thus making GDB showing the wrong memory data for a given address. Signed-off-by: Jon Do

Re: [Qemu-devel] [PATCH v2] dump: Set correct vaddr for ELF dump

2019-01-08 Thread Marc-André Lureau
On Tue, Jan 8, 2019 at 5:02 PM Jon Doron wrote: > > vaddr needs to be equal to the paddr since the dump file represents the > physical memory image. > > Without setting vaddr correctly, GDB would load all the different memory > regions on top of each other to vaddr 0, thus making GDB showing the w

Re: [Qemu-devel] [PATCH v7 16/18] xen: automatically create XenBlockDevice-s

2019-01-08 Thread Paul Durrant
> -Original Message- > From: Kevin Wolf [mailto:kw...@redhat.com] > Sent: 08 January 2019 12:53 > To: Paul Durrant > Cc: Anthony Perard ; qemu-devel@nongnu.org; > qemu-bl...@nongnu.org; xen-de...@lists.xenproject.org; Max Reitz > ; Stefano Stabellini > Subject: Re: [PATCH v7 16/18] xen: a

Re: [Qemu-devel] [PATCH v3 1/2] qapi: move to QOM path for x-block-latency-histogram-set

2019-01-08 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > Move to way of device selecting, however fall back to device name if > path is not found. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > qapi/block-core.json | 4 ++-- > blockdev.c | 22 +++--- > 2 files changed, 17 inse

Re: [Qemu-devel] [PATCH] arm: Stub out NRF51 TWI magnetometer/accelerometer detection

2019-01-08 Thread Stefan Hajnoczi
On Tue, Jan 8, 2019 at 11:57 AM Peter Maydell wrote: > On Sat, 5 Jan 2019 at 15:02, Stefan Hajnoczi wrote: > > > > From: Steffen Görtz > > > > Recent microbit firmwares panic if the TWI magnetometer/accelerometer > > devices are not detected during startup. We don't implement TWI (I2C) > > so l

Re: [Qemu-devel] [PATCH for-3.2 01/11] vhost-user: define conventions for vhost-user backends

2019-01-08 Thread Marc-André Lureau
Hi On Thu, Dec 20, 2018 at 8:34 PM Michael S. Tsirkin wrote: > > On Thu, Dec 20, 2018 at 04:40:55PM +0400, Marc-André Lureau wrote: > > Hi > > > > On Wed, Dec 19, 2018 at 7:42 PM Michael S. Tsirkin wrote: > > > > > > On Wed, Dec 19, 2018 at 12:01:59PM +0400, Marc-André Lureau wrote: > > > > Hi >

Re: [Qemu-devel] [PATCH v7 16/18] xen: automatically create XenBlockDevice-s

2019-01-08 Thread Anthony PERARD
On Tue, Jan 08, 2019 at 01:07:49PM +, Paul Durrant wrote: > > -Original Message- > > From: Kevin Wolf [mailto:kw...@redhat.com] > > Sent: 08 January 2019 12:53 > > To: Paul Durrant > > Cc: Anthony Perard ; qemu-devel@nongnu.org; > > qemu-bl...@nongnu.org; xen-de...@lists.xenproject.org

Re: [Qemu-devel] Building QEMU for WebAssembly

2019-01-08 Thread Stefan Hajnoczi
On Mon, Jan 7, 2019 at 5:07 PM Anatoly Trosinenko wrote: > > Multi-threading is not yet available in WebAssembly. Hopefully this > > will change soon because multi-threading and related infrastructure > > like atomics are used at the core of several areas in QEMU. > > Technically, I have managed

Re: [Qemu-devel] [PATCH v11 09/10] qcow2: skip writing zero buffers to empty COW areas

2019-01-08 Thread Alberto Garcia
On Tue 18 Dec 2018 08:57:45 AM CET, Anton Nefedov wrote: > @@ -2126,24 +2202,33 @@ static coroutine_fn int > qcow2_co_pwritev(BlockDriverState *bs, uint64_t offset, > goto fail; > } > > +qemu_co_mutex_unlock(&s->lock); > + > +ret = handle_alloc_space(bs, l2m

Re: [Qemu-devel] [PATCH v5 1/6] Stream block job involves copy-on-read filter driver

2019-01-08 Thread Vladimir Sementsov-Ogievskiy
30.12.2018 23:09, Andrey Shinkevich wrote: > The copy-on-read filter is applied to block-stream operation. > It is necessary for further block discard option. If we move to c-o-r filter in stream, I think we should: 1. get rid of COPY_ON_READ flag in stream code (so, this thing to be done in one

Re: [Qemu-devel] [PATCH v7 16/18] xen: automatically create XenBlockDevice-s

2019-01-08 Thread Paul Durrant
> -Original Message- > From: Anthony PERARD [mailto:anthony.per...@citrix.com] > Sent: 08 January 2019 13:28 > To: Paul Durrant > Cc: 'Kevin Wolf' ; qemu-devel@nongnu.org; qemu- > bl...@nongnu.org; xen-de...@lists.xenproject.org; Max Reitz > ; Stefano Stabellini > Subject: Re: [PATCH v7 1

Re: [Qemu-devel] [PATCH v7 16/18] xen: automatically create XenBlockDevice-s

2019-01-08 Thread Paul Durrant
> -Original Message- > From: Xen-devel [mailto:xen-devel-boun...@lists.xenproject.org] On Behalf > Of Paul Durrant > Sent: 08 January 2019 14:11 > To: Anthony Perard > Cc: 'Kevin Wolf' ; Stefano Stabellini > ; qemu-bl...@nongnu.org; qemu-devel@nongnu.org; > Max Reitz ; xen-de...@lists.xenp

Re: [Qemu-devel] [PATCH v2] dump: Set correct vaddr for ELF dump

2019-01-08 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190108130219.18550-1-ari...@gmail.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH v2] dump: Set correct vaddr for ELF dump Message-id: 20190108130219.18550-1-

Re: [Qemu-devel] [PATCH] i2c-ddc: fix oob read

2019-01-08 Thread Philippe Mathieu-Daudé
On 1/8/19 11:23 AM, Gerd Hoffmann wrote: > Suggested-by: Michael Hanselmann > Signed-off-by: Gerd Hoffmann > --- > hw/i2c/i2c-ddc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/i2c/i2c-ddc.c b/hw/i2c/i2c-ddc.c > index be34fe072c..0a0367ff38 100644 > --- a/hw/i2c/i

Re: [Qemu-devel] [PATCH v14 6/6] tpm: clear RAM when "memory overwrite" requested

2019-01-08 Thread Philippe Mathieu-Daudé
On 1/8/19 9:40 AM, Marc-André Lureau wrote: > Note: the "Platform Reset Attack Mitigation" specification isn't > explicit about NVDIMM, since they could have different usages. It uses > the term "system memory" generally (and also "volatile memory RAM" in > its introduction). For initial support, I

Re: [Qemu-devel] [PATCH 2/3] machine: Eliminate unnecessary stringify() usage

2019-01-08 Thread Philippe Mathieu-Daudé
On 1/7/19 8:30 PM, Eduardo Habkost wrote: > stringify() is useful when we need to use macros in compat_props > (like when we set virtio-baloon-pci.class=PCI_CLASS_MEMORY_RAM at > pc_i440fx_1_0_machine_options()), but it is pointless when we are > already providing a number literal. > > Replace str

Re: [Qemu-devel] [PATCH v7 16/18] xen: automatically create XenBlockDevice-s

2019-01-08 Thread Paul Durrant
> -Original Message- > From: Anthony PERARD [mailto:anthony.per...@citrix.com] > Sent: 08 January 2019 13:28 > To: Paul Durrant > Cc: 'Kevin Wolf' ; qemu-devel@nongnu.org; qemu- > bl...@nongnu.org; xen-de...@lists.xenproject.org; Max Reitz > ; Stefano Stabellini > Subject: Re: [PATCH v7 1

Re: [Qemu-devel] [PATCH 3/3] machine: Use shorter format for GlobalProperty arrays

2019-01-08 Thread Philippe Mathieu-Daudé
On 1/7/19 8:30 PM, Eduardo Habkost wrote: > Instead of verbose arrays with 4 lines for each entry, make each > entry take only one line. This makes long arrays that couldn't > fit in the screen become short and readable. And we'll thank you for the next git diff :)

Re: [Qemu-devel] [PATCH v7 16/18] xen: automatically create XenBlockDevice-s

2019-01-08 Thread Anthony PERARD
> I've tested your patch and it does seem like the best way forward. I'll > squash it in. Do you want me to put your S-o-b on the combined patch? You can, I'll have to add it anyway when I'll prepare the pull request. Thanks, -- Anthony PERARD

Re: [Qemu-devel] [Bug 1810603] Re: QEMU QCow Images grow dramatically

2019-01-08 Thread Eric Blake
On 1/8/19 2:30 AM, Lenny Helpline wrote: > I don't have many commands handy, as we manage almost everything through > libvirt manager. > > 3) create a snapshot of the lined clone: > > virsh snapshot-create-as --domain --name "test" --halt > > 4) revert the snapshot every X minutes / hours: > >

Re: [Qemu-devel] [RFC v2 0/4] QEMU changes to do PVH boot

2019-01-08 Thread Liam Merwick
Hi Stefano, [ Catching up on mail after vacation ] On 03/01/2019 17:22, Stefano Garzarella wrote: Hi Liam, Hi Maran, I'm writing the optionrom to do PVH boot also with SeaBIOS. It is almost complete and I'm testing it, but I have some issue with QEMU -initrd parameter. (It works correctly witho

Re: [Qemu-devel] [RFC v2 1/4] elf: Add optional function ptr to load_elf() to parse ELF notes

2019-01-08 Thread Liam Merwick
On 02/01/2019 13:06, Stefan Hajnoczi wrote: On Fri, Dec 21, 2018 at 08:03:49PM +, Liam Merwick wrote: diff --git a/include/hw/elf_ops.h b/include/hw/elf_ops.h index 74679ff8da3a..37d20a3800c1 100644 --- a/include/hw/elf_ops.h +++ b/include/hw/elf_ops.h @@ -266,6 +266,7 @@ fail: } s

[Qemu-devel] [PATCH v9 03/18] xen: introduce 'xen-block', 'xen-disk' and 'xen-cdrom'

2019-01-08 Thread Paul Durrant
This patch adds new XenDevice-s: 'xen-disk' and 'xen-cdrom', both derived from a common 'xen-block' parent type. These will eventually replace the 'xen_disk' (note the underscore rather than hyphen) legacy PV backend but it is illustrative to build up the implementation incrementally, along with th

Re: [Qemu-devel] [RFC v2 4/4] pvh: Boot uncompressed kernel using direct boot ABI

2019-01-08 Thread Liam Merwick
On 02/01/2019 13:18, Stefan Hajnoczi wrote: On Fri, Dec 21, 2018 at 08:03:52PM +, Liam Merwick wrote: @@ -1336,7 +1470,7 @@ void pc_memory_init(PCMachineState *pcms, int linux_boot, i; MemoryRegion *ram, *option_rom_mr; MemoryRegion *ram_below_4g, *ram_above_4g; -FWC

Re: [Qemu-devel] [RFC v2 2/4] elf-ops.h: Add get_elf_note_type()

2019-01-08 Thread Liam Merwick
On 02/01/2019 13:12, Stefan Hajnoczi wrote: On Fri, Dec 21, 2018 at 08:03:50PM +, Liam Merwick wrote: +while (note_type != elf_note_type) { +nhdr_namesz = nhdr->n_namesz; +nhdr_descsz = nhdr->n_descsz; + +elf_note_entry_offset = nhdr_size + +QEMU_AL

[Qemu-devel] [PATCH v9 07/18] xen: add event channel interface for XenDevice-s

2019-01-08 Thread Paul Durrant
The legacy PV backend infrastructure provides functions to bind, unbind and send notifications to event channnels. Similar functionality will be required by XenDevice implementations so this patch adds the necessary support. Signed-off-by: Paul Durrant Reviewed-by: Anthony Perard --- Cc: Stefano

[Qemu-devel] [PATCH v9 09/18] xen: remove unnecessary code from dataplane/xen-block.c

2019-01-08 Thread Paul Durrant
Not all of the code duplicated from xen_disk.c is required as the basis for the new dataplane implementation so this patch removes extraneous code, along with the legacy #includes and calls to the legacy xen_pv_printf() function. Error messages are changed to be reported using error_report(). NOTE

[Qemu-devel] [PATCH v9 02/18] xen: introduce new 'XenBus' and 'XenDevice' object hierarchy

2019-01-08 Thread Paul Durrant
This patch adds the basic boilerplate for a 'XenBus' object that will act as a parent to 'XenDevice' PV backends. A new 'XenBridge' object is also added to connect XenBus to the system bus. The XenBus object is instantiated by a new xen_bus_init() function called from the same sites as the legacy

[Qemu-devel] [PATCH v9 06/18] xen: add grant table interface for XenDevice-s

2019-01-08 Thread Paul Durrant
The legacy PV backend infrastructure provides functions to map, unmap and copy pages granted by frontends. Similar functionality will be required by XenDevice implementations so this patch adds the necessary support. Signed-off-by: Paul Durrant Reviewed-by: Anthony Perard --- Cc: Stefano Stabell

[Qemu-devel] [PATCH v9 08/18] xen: duplicate xen_disk.c as basis of dataplane/xen-block.c

2019-01-08 Thread Paul Durrant
The new xen-block XenDevice implementation requires the same core dataplane as the legacy xen_disk implementation it will eventually replace. This patch therefore copies the legacy xen_disk.c source module into a new dataplane/xen-block.c source module as the basis for the new dataplane and adjusts

  1   2   3   4   >