Recently we have switched quite a few VT-d trace points into error_report_once()s and this does expose some errors that we didn't detect before (previously tracepoints won't trigger as long as tracepoints weren't enabled). These errors are not severe in that all of them will not affect functionality of the guest otherwise we'll notice them even earlier. However it still worths to fix all of them. This patchset tries to fix quite a few errors like this (except the last patch, which should also workaround an error but has nothing to do with the newly introduced error_report_once).
All the errors could easily be triggered by rebooting a guest with both vfio-pci device and vIOMMU, and we can see errors dumped in stderr like: qemu-kvm: vtd_iova_to_slpte: detected slpte permission error (iova=0xffd9ce00, level=0x2, slpte=0x0, write=1) qemu-kvm: vtd_iommu_translate: detected translation failure (dev=02:00:00, iova=0x0) qemu-kvm: vtd_interrupt_remap_msi: MSI address low 32 bit invalid: 0x0 Regarding to the patchset itself: Patch 1: fixes slpte permission error warning Patch 2: fixes intr_enabled flag reset missing Patch 3-4: fixes MSI translation warning Patch 5: workaround of a kernel bug that could cause UNMAP fail error It was tested that this series can fix all the error messages observed in below bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1662270 https://bugzilla.redhat.com/show_bug.cgi?id=1662291 Please have a look, thanks. Peter Xu (5): intel_iommu: fix operator in vtd_switch_address_space intel_iommu: reset intr_enabled when system reset pci/msi: export msi_is_masked() i386/kvm: ignore masked irqs when update msi routes vfio: retry one more time conditionally for type1 unmap hw/i386/intel_iommu.c | 3 ++- hw/pci/msi.c | 2 +- hw/vfio/common.c | 16 ++++++++++++++++ hw/vfio/trace-events | 1 + include/hw/pci/msi.h | 1 + target/i386/kvm.c | 14 +++++++++++--- 6 files changed, 32 insertions(+), 5 deletions(-) -- 2.17.1
