Re: [Qemu-devel] [PATCH 08/16] MAINTAINERS: Add missing entries for the TI touchscreen devices

2019-01-07 Thread Philippe Mathieu-Daudé
Hi Thomas, On 1/7/19 8:18 AM, Thomas Huth wrote: > On 2019-01-04 18:58, Philippe Mathieu-Daudé wrote: >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> MAINTAINERS | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index f571b29077..03872552ee 100644 >> -

Re: [Qemu-devel] [PATCH 09/16] hw/devices: Move TI touchscreen declarations into a new header

2019-01-07 Thread Philippe Mathieu-Daudé
On 1/7/19 8:22 AM, Thomas Huth wrote: > On 2019-01-04 18:58, Philippe Mathieu-Daudé wrote: >> Since uWireSlave is only used in this new header, there is no >> need to expose it via "qemu/typedefs.h". >> >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> MAINTAINERS | 2 ++ >>

Re: [Qemu-devel] [PATCH 12/16] hw/devices: Move LAN9118 declarations into a new header

2019-01-07 Thread Philippe Mathieu-Daudé
On 1/7/19 8:29 AM, Thomas Huth wrote: > On 2019-01-04 18:58, Philippe Mathieu-Daudé wrote: >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> hw/arm/kzm.c | 2 +- >> hw/arm/mps2.c| 2 +- >> hw/arm/realview.c| 1 + >> hw/arm/vexpress.c| 2 +- >> hw/net/l

Re: [Qemu-devel] [PATCH 08/16] MAINTAINERS: Add missing entries for the TI touchscreen devices

2019-01-07 Thread Thomas Huth
On 2019-01-07 09:02, Philippe Mathieu-Daudé wrote: > Hi Thomas, > > On 1/7/19 8:18 AM, Thomas Huth wrote: >> On 2019-01-04 18:58, Philippe Mathieu-Daudé wrote: >>> Signed-off-by: Philippe Mathieu-Daudé >>> --- >>> MAINTAINERS | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/MAINT

Re: [Qemu-devel] [PATCH v4] Support u-boot noload images for arm as used by, NetBSD/evbarm GENERIC kernel.

2019-01-07 Thread Nick Hudson
Thanks for the comments. On 07/01/2019 00:33, BALATON Zoltan wrote: On Sun, 6 Jan 2019, Nick Hudson wrote: noload kernels are loaded with the u-boot image header and as a result the header size needs adding to the entry point.  Fake up a hdr so the kernel image is loaded at the right address an

Re: [Qemu-devel] [PATCH v3] contrib: add a basic gitdm config

2019-01-07 Thread Aleksandar Markovic
On Friday, December 14, 2018, Alex Bennée wrote: > This is a QEMU specific version of a gitdm config for generating > reports on the contributor base of the project. I've added enough > group maps and domain aliases to ensure the current top ten is as > reflective as it can be. As of this commit

Re: [Qemu-devel] [PATCH] compat: Use explicit type names on HW_COMPAT_2_6

2019-01-07 Thread Cornelia Huck
On Fri, 4 Jan 2019 20:00:50 -0200 Eduardo Habkost wrote: > On Fri, Jan 04, 2019 at 04:13:15PM -0500, Michael S. Tsirkin wrote: > > On Fri, Jan 04, 2019 at 07:06:56PM -0200, Eduardo Habkost wrote: > > > On Fri, Jan 04, 2019 at 03:48:02PM -0500, Michael S. Tsirkin wrote: > > > > On Fri, Jan 04,

Re: [Qemu-devel] Can I have someone's feedback on [bug 1809075] Concurrency bug on keyboard events: capslock LED messing up keycode streams causes character misses at guest kernel

2019-01-07 Thread Gerd Hoffmann
On Thu, Jan 03, 2019 at 12:05:54PM +0100, Philippe Mathieu-Daudé wrote: > Cc'ing Marc-André & Gerd. > > On 12/19/18 10:31 AM, Gao Zhiyuan wrote: > > Hi everyone. > > > > Can I please have someone's feedback on this bug? > > https://bugs.launchpad.net/qemu/+bug/1809075 > > Briefly, guest OS loses

[Qemu-devel] [PATCH v4] Add getsockopt for settable SOL_IPV6 options

2019-01-07 Thread tom . deseyn
From: Tom Deseyn v2: default to unimplemented v3: match kernel behavior v4: braces code-style Signed-off-by: Tom Deseyn --- linux-user/syscall.c | 41 + 1 file changed, 41 insertions(+) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 2801

[Qemu-devel] [Bug 1809075] Re: Concurrency bug on keyboard events: capslock LED messing up keycode streams causes character misses at guest kernel

2019-01-07 Thread Gerd Hoffmann
There is no "capslock LED key event". 0xfa is KBD_REPLY_ACK, and the device queues it in response to guest port writes. Yes, the ack can race with actual key events. But IMO that isn't a bug in qemu. Probably the linux kernel just throws away everything until it got the ack for the port write,

Re: [Qemu-devel] [PATCH v1 1/2] hw/microblaze: s3adsp1800: Create an unimplemented GPIO area

2019-01-07 Thread Luc Michel
On 1/4/19 3:28 PM, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Create an unimplemented GPIO area instead of leaving it unassigned. > > Signed-off-by: Edgar E. Iglesias Reviewed-by: Luc Michel > --- > hw/microblaze/petalogix_s3adsp1800_mmu.c | 4 > 1 file changed, 4 insertio

Re: [Qemu-devel] [PATCH v1 2/2] target/microblaze: Add props enabling exceptions on failed bus accesses

2019-01-07 Thread Luc Michel
On 1/4/19 3:28 PM, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Add MicroBlaze CPU properties to enable exceptions on failed > bus accesses. > > Signed-off-by: Edgar E. Iglesias Reviewed-by: Luc Michel > --- > target/microblaze/cpu.c | 12 +++- > target/microblaze/cpu.h |

Re: [Qemu-devel] [PATCH v1 2/2] target/arm: defer setting up of aarch64 gdb until arm_cpu_realize

2019-01-07 Thread Alex Bennée
Peter Maydell writes: > On Thu, 13 Dec 2018 at 11:55, Alex Bennée wrote: >> >> If we setup earlier we miss the parsing of the aarch64 state of the >> CPU. If the user has booted up with: >> >> qemu-system-aarch64 -cpu host,aarch64=off -enable-kvm >> >> we end up presenting an aarch64 view of

Re: [Qemu-devel] [PATCH v8 00/16] gdbstub: support for the multiprocess extension

2019-01-07 Thread Luc Michel
On 1/4/19 4:12 PM, Peter Maydell wrote: > On Fri, 7 Dec 2018 at 09:01, Luc Michel wrote: >> This series adds support for the multiprocess extension of the GDB >> remote protocol in the QEMU GDB stub. >> >> This extension is useful to split QEMU emulated CPUs in different >> processes from the poin

Re: [Qemu-devel] [PATCH v2 1/3] util/cutils: Move size_to_str() from "qemu-common.h" to "cutils.h"

2019-01-07 Thread Stefano Garzarella
On Fri, Jan 4, 2019 at 7:12 PM Philippe Mathieu-Daudé wrote: > > The size_to_str() function doesn't need to be in a generic header. > > It makes also sens to find this function in the same header than > the opposite string to size functions: qemu_strtosz*(). > Note than this function is already im

Re: [Qemu-devel] [PATCH v2 3/3] util/cutils: Move function documentations to the header

2019-01-07 Thread Stefano Garzarella
On Fri, Jan 4, 2019 at 7:13 PM Philippe Mathieu-Daudé wrote: > > Many functions have documentation before the implementation in > cutils.c. Since we expect documentation around the prototype > declaration in headers, move the comments in cutils.h. > > Signed-off-by: Philippe Mathieu-Daudé > --- >

Re: [Qemu-devel] [PATCH v6] s390x/pci: add common function measurement block

2019-01-07 Thread Pierre Morel
On 04/01/2019 15:39, Cornelia Huck wrote: On Thu, 3 Jan 2019 11:17:00 +0100 Pierre Morel wrote: +static void fmb_update(void *opaque) +{ +S390PCIBusDevice *pbdev = opaque; +int64_t t = qemu_clock_get_ms(QEMU_CLOCK_VIRTUAL); +int i; + +/* Update U bit */ +pbdev->fmb.last_up

Re: [Qemu-devel] [qemu-s390x] 答复: [PATCH v2] s390: avoid potential null dereference ins390_pcihost_unplug()

2019-01-07 Thread David Hildenbrand
On 04.01.19 15:33, Li Qiang wrote: > What do you think of ‘g_assert_not_reached();’. For example: > >   > > else { > > g_assert_not_reached(); > > } > I agree, if thisever happens, it is a serious programming error, not an error to report to the user. (after all, he did nothing wrong) I

Re: [Qemu-devel] [PATCH v6] s390x/pci: add common function measurement block

2019-01-07 Thread Thomas Huth
On 2019-01-07 10:08, Pierre Morel wrote: > On 04/01/2019 15:39, Cornelia Huck wrote: >> On Thu,  3 Jan 2019 11:17:00 +0100 >> Pierre Morel wrote: >> >>> +static void fmb_update(void *opaque) >>> +{ >>> +    S390PCIBusDevice *pbdev = opaque; >>> +    int64_t t = qemu_clock_get_ms(QEMU_CLOCK_VIRTUAL

Re: [Qemu-devel] [PATCH v4] Add getsockopt for settable SOL_IPV6 options

2019-01-07 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190107082751.6461-1-tom.des...@gmail.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v4] Add getsockopt for settable SOL_IPV6 options Message-id: 20190107082751.6461-1-to

Re: [Qemu-devel] Emulation of TCG OPAL self-encrypting drive

2019-01-07 Thread Stefan Hajnoczi
On Sat, Jan 05, 2019 at 07:27:03PM +0100, David Kozub wrote: > Hi, > > Can QEMU emulate an OPAL disk? The only relevant thing I found is a post > from 2017 about TPM that mentions OPAL: > https://lists.gnu.org/archive/html/qemu-devel/2017-07/msg04586.html CCing John Snow (IDE/ATA) and Kevin Wolf

Re: [Qemu-devel] [PATCH v6] s390x/pci: add common function measurement block

2019-01-07 Thread Pierre Morel
On 07/01/2019 10:11, Thomas Huth wrote: On 2019-01-07 10:08, Pierre Morel wrote: On 04/01/2019 15:39, Cornelia Huck wrote: On Thu,  3 Jan 2019 11:17:00 +0100 Pierre Morel wrote: +static void fmb_update(void *opaque) +{ +    S390PCIBusDevice *pbdev = opaque; +    int64_t t = qemu_clock_get_ms

[Qemu-devel] [PATCH v5] Add getsockopt for settable SOL_IPV6 options

2019-01-07 Thread tom . deseyn
From: Tom Deseyn v2: default to unimplemented v3: match kernel behavior v4: braces code-style v5: pointer code-style Signed-off-by: Tom Deseyn --- linux-user/syscall.c | 41 + 1 file changed, 41 insertions(+) diff --git a/linux-user/syscall.c b/linux-us

Re: [Qemu-devel] [PATCH v2 10/12] qapi: document DisplayType enum

2019-01-07 Thread Gerd Hoffmann
On Thu, Dec 20, 2018 at 08:46:13AM -0600, Eric Blake wrote: > On 12/20/18 8:15 AM, Marc-André Lureau wrote: > > Signed-off-by: Marc-André Lureau > > --- > > qapi/ui.json | 24 > > 1 file changed, 24 insertions(+) > > > > diff --git a/qapi/ui.json b/qapi/ui.json > > ind

[Qemu-devel] [Bug 1530386] Re: command.com on win95 throws video mode out

2019-01-07 Thread Thomas Huth
Can you still reproduce this issue with the latest version of QEMU? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1530386 Title: command.com on

[Qemu-devel] [Bug 1535497] Re: Guest can not boot up when assigned more than 20 vcpus with option "-no-acpi"

2019-01-07 Thread Thomas Huth
Can you still reproduce this issue with the latest version of QEMU? If this is a bug in seabios, have you tried to report this to seabios instead? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subsc

Re: [Qemu-devel] [PATCH v2 23/52] audio: remove audio_MIN, audio_MAX

2019-01-07 Thread Gerd Hoffmann
> The first one is fixable with an explicit cast (ugly but works), but the > second one is more problematic. It means we can't write stuff like > > USBPort uports[MAX(MAXPORTS_2, MAXPORTS_3)]; > > when not in a function. So we either need a dumb version of MIN/MAX, or > scrape the idea altogethe

Re: [Qemu-devel] [PATCH v2] osdep: Make MIN/MAX evaluate arguments only once

2019-01-07 Thread Dr. David Alan Gilbert
* Eric Blake (ebl...@redhat.com) wrote: > Add the macro QEMU_TYPEOF() to access __auto_type in new enough > compilers, while falling back to typeof on older compilers (the > fallback doesn't handle variable length arrays, but we don't use > those; it also expands to more text). > > Then use that m

[Qemu-devel] [Bug 1534382] Re: loadvm makes Windows 7 x86 guest crash with some CPUs

2019-01-07 Thread Thomas Huth
Looking through old bug tickets... can you still reproduce this issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscrib

Re: [Qemu-devel] [PATCH v2 27/52] audio: use size_t where makes sense

2019-01-07 Thread Gerd Hoffmann
Hi, > > void AUD_close_out (QEMUSoundCard *card, SWVoiceOut *sw); > > -int AUD_write (SWVoiceOut *sw, void *pcm_buf, int size); > > Can you add short documentation while modifying headers? Such: > > /** > * AUD_write: > * > * Returns: the number of bytes written. > */ While this certain

Re: [Qemu-devel] [PATCH 02/16] hw: Remove unused 'hw/devices.h' include

2019-01-07 Thread Thomas Huth
On 2019-01-04 18:58, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/alpha/typhoon.c | 1 - > hw/arm/allwinner-a10.c | 1 - > hw/arm/collie.c | 1 - > hw/arm/cubieboard.c | 1 - >

Re: [Qemu-devel] [PATCH for-4.0 v4 1/4] unify len and addr type for memory/address APIs

2019-01-07 Thread Stefano Garzarella
Hi Li, On Thu, Dec 6, 2018 at 3:26 AM Li Zhijian wrote: > > Some address/memory APIs have different type between > 'hwaddr/target_ulong addr' and 'int len'. It is very unsafe, espcially As Philippe already suggested, s/espcially/especially > some APIs will be passed a non-int len by caller wh

[Qemu-devel] [PATCH v3] hw/arm/virt-acpi-build: Set COHACC override flag in IORT SMMUv3 node

2019-01-07 Thread Eric Auger
Let's report IO-coherent access is supported for translation table walks, descriptor fetches and queues by setting the COHACC override flag. Without that, we observe wrong command opcodes. The DT description also advertises the dma coherency. Fixes a703b4f6c1ee ("hw/arm/virt-acpi-build: Add smmuv3

Re: [Qemu-devel] [PATCH] usb: dev-mtp: close fd in usb_mtp_object_readdir()

2019-01-07 Thread Gerd Hoffmann
On Thu, Jan 03, 2019 at 05:31:13AM -0800, Li Qiang wrote: > Spotted by Coverity: CID 1397070 > diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c > index b19b576278..666bafd9e8 100644 > --- a/hw/usb/dev-mtp.c > +++ b/hw/usb/dev-mtp.c > @@ -666,6 +666,7 @@ static void usb_mtp_object_readdir(MTPState

Re: [Qemu-devel] [PATCH v4] Support u-boot noload images for arm as used by, NetBSD/evbarm GENERIC kernel.

2019-01-07 Thread Peter Maydell
On Mon, 7 Jan 2019 at 07:54, Nick Hudson wrote: > On 06/01/2019 22:56, no-re...@patchew.org wrote: > > This series seems to have some coding style problems. See output below for > > more information: > > The files being touched have lots of coding style problems already. I'm > avoiding i) fixing

Re: [Qemu-devel] [PATCH for-4.0 v4 2/4] refactor load_image_size

2019-01-07 Thread Stefano Garzarella
On Mon, Dec 24, 2018 at 3:16 AM Li Zhijian wrote: > > > On 12/22/18 00:12, Michael S. Tsirkin wrote: > > On Thu, Dec 06, 2018 at 10:32:11AM +0800, Li Zhijian wrote: > >> Don't expect read(2) can always read as many as it's told. > >> > >> Signed-off-by: Li Zhijian > >> Reviewed-by: Richard Hender

Re: [Qemu-devel] [PATCH] usb: dev-mtp: close fd in usb_mtp_object_readdir()

2019-01-07 Thread Peter Maydell
On Mon, 7 Jan 2019 at 10:22, Gerd Hoffmann wrote: > > On Thu, Jan 03, 2019 at 05:31:13AM -0800, Li Qiang wrote: > > Spotted by Coverity: CID 1397070 > > #ifdef CONFIG_INOTIFY1 > > @@ -682,6 +683,7 @@ static void usb_mtp_object_readdir(MTPState *s, > > MTPObject *o) > > usb_mtp_add_chil

[Qemu-devel] [PATCH] qga: check length of command-line & environment variables

2019-01-07 Thread P J P
From: Prasad J Pandit Qemu guest agent while executing user commands does not seem to check length of argument list and/or environment variables passed. It may lead to integer overflow or infinite loop issues. Add check to avoid it. Reported-by: Niu Guoxiang Signed-off-by: Prasad J Pandit ---

Re: [Qemu-devel] [PATCH] Introduce new "no_guest_reset" parameter for usb-host device (fwd)

2019-01-07 Thread Gerd Hoffmann
On Thu, Dec 27, 2018 at 02:19:09PM -0800, Alexander Kappner wrote: > > Resending; forgot to CC maintainer. Now the list mail address is wrong (.com instead of .org). > 1) Guest recognizes new device, sends reset to emulated USB host > 2) QEMU's USB host sends reset to host kernel > 3) Host kerne

[Qemu-devel] [PATCH] configure: Force the C standard to gnu11

2019-01-07 Thread Thomas Huth
Different versions of GCC and Clang use different versions of the C standard. This repeatedly caused problems already, e.g. with duplicated typedefs: https://lists.gnu.org/archive/html/qemu-devel/2018-11/msg05829.html or with for-loop variable initializers: https://lists.gnu.org/archive/html/q

[Qemu-devel] [PATCH v1 1/3] contrib/gitdm: add Nokia and Proxmox to the domain-map

2019-01-07 Thread Alex Bennée
Signed-off-by: Alex Bennée --- contrib/gitdm/domain-map | 2 ++ 1 file changed, 2 insertions(+) diff --git a/contrib/gitdm/domain-map b/contrib/gitdm/domain-map index 8cbbcfe93d..0ab41ee27a 100644 --- a/contrib/gitdm/domain-map +++ b/contrib/gitdm/domain-map @@ -9,7 +9,9 @@ greensocs.com Green

[Qemu-devel] [PATCH v1 2/3] contrib/gitdm: Add other IBMers

2019-01-07 Thread Alex Bennée
From: Joel Stanley Here are some IBMers who use their personal addresses when submitting patches. Signed-off-by: Joel Stanley Acked-by: Andrew Jeffery Signed-off-by: Alex Bennée --- contrib/gitdm/group-map-ibm | 5 + 1 file changed, 5 insertions(+) diff --git a/contrib/gitdm/group-map-i

[Qemu-devel] [PATCH v1 0/3] gitdm updates

2019-01-07 Thread Alex Bennée
Hi, Added a few more updates mostly of IBMers with non corporate emails. The year-end stats as per: git log --numstat --after="1/1/2018 00:00" \ --before="31/12/2018 23:59" | gitdm -n -l 10 Are: Top changeset contributors by employer Red Hat 3091 (43.

[Qemu-devel] [PATCH v1 3/3] contrib/gitdm: add two more IBM'ers to group-map-ibm

2019-01-07 Thread Alex Bennée
Signed-off-by: Alex Bennée --- contrib/gitdm/group-map-ibm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/contrib/gitdm/group-map-ibm b/contrib/gitdm/group-map-ibm index 6c0570107d..22727319b3 100644 --- a/contrib/gitdm/group-map-ibm +++ b/contrib/gitdm/group-map-ibm @@ -6,6 +6,8 @@ a...@o

Re: [Qemu-devel] [PATCH v3 1/2] tests: tcg: mips: Move source files to new location

2019-01-07 Thread Alex Bennée
Aleksandar Markovic writes: > From: Aleksandar Markovic > > New directory organization is as follows: > > tests > tcg > mips > user > isa > r5900 > ase > dsp > system > ase > dsp > > New file names are unique within tests/

Re: [Qemu-devel] [PATCH v3 2/2] tests: tcg: mips: Remove old directories after moving source files

2019-01-07 Thread Alex Bennée
Aleksandar Markovic writes: > From: Aleksandar Markovic > > Remove old directories after reorganization of MIPS TCG tests. > > Signed-off-by: Aleksandar Markovic > --- > tests/tcg/mips/mips32-dsp/Makefile| 136 - > tests/tcg/mips/mips32-dspr2/Makefile | 71 --- >

[Qemu-devel] [PATCH v5] Support u-boot noload images for arm as used by, NetBSD/evbarm GENERIC kernel.

2019-01-07 Thread Nick Hudson
noload kernels are loaded with the u-boot image header and as a result the header size needs adding to the entry point. Fake up a hdr so the kernel image is loaded at the right address and the entry point is adjusted appropriately. The default location for the uboot file is 32MiB above bottom o

Re: [Qemu-devel] [PATCH v6] s390x/pci: add common function measurement block

2019-01-07 Thread David Hildenbrand
On 03.01.19 11:17, Pierre Morel wrote: > From: Yi Min Zhao > > Common function measurement block is used to report zPCI internal > counters of successful pcilg/stg/stb and rpcit instructions to > a memory location provided by the program. > > This patch introduces a new ZpciFmb structure and sch

Re: [Qemu-devel] [RFC PATCH 01/25] build: actually use CONFIG_PAM

2019-01-07 Thread Yang Zhong
On Thu, Jan 03, 2019 at 03:15:44PM +0100, Thomas Huth wrote: > Hi, > > On 2018-12-27 07:33, Yang Zhong wrote: > > From: Paolo Bonzini > > > > Do not link it unconditionally into all binaries. > > > > Signed-off-by: Paolo Bonzini > > --- > > hw/pci-host/Makefile.objs | 2 +- > > 1 file change

Re: [Qemu-devel] [PATCH 0/2] fp-bench fixes

2019-01-07 Thread Alex Bennée
Emilio G. Cota writes: > Two small fixes for fp-bench. They fix the fact that we weren't > generating normals, even though we intended to. > > You can pull this series from: > https://github.com/cota/qemu/tree/fp-bench-fixes > > Thanks, > > Emilio Queued to fpu/next, thanks. -

Re: [Qemu-devel] [PATCH v2 17/27] target/arm: Create ARMVAParameters and helpers

2019-01-07 Thread Peter Maydell
On Fri, 14 Dec 2018 at 05:24, Richard Henderson wrote: > > Split out functions to extract the virtual address parameters. > Let the functions choose T0 or T1 address space half, if present. > Extract (most of) the control bits that vary between EL or Tx. > > Signed-off-by: Richard Henderson > ---

Re: [Qemu-devel] [PATCH v2 18/27] target/arm: Reuse aa64_va_parameters for setting tbflags

2019-01-07 Thread Peter Maydell
On Fri, 14 Dec 2018 at 05:24, Richard Henderson wrote: > > The arm_regime_tbi{0,1} functions are replacable with the new function > by giving the lowest and highest address. > > Signed-off-by: Richard Henderson > --- > target/arm/cpu.h| 35 -- > target/arm/helper.c |

Re: [Qemu-devel] [PATCH 08/16] MAINTAINERS: Add missing entries for the TI touchscreen devices

2019-01-07 Thread Philippe Mathieu-Daudé
On 1/7/19 9:05 AM, Thomas Huth wrote: > On 2019-01-07 09:02, Philippe Mathieu-Daudé wrote: >> Hi Thomas, >> >> On 1/7/19 8:18 AM, Thomas Huth wrote: >>> On 2019-01-04 18:58, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 2 ++ 1 file chan

Re: [Qemu-devel] [PATCH v2 19/27] target/arm: Export aa64_va_parameters to internals.h

2019-01-07 Thread Peter Maydell
On Fri, 14 Dec 2018 at 05:24, Richard Henderson wrote: > > We need to reuse this from helper-a64.c. Provide a stub > definition for CONFIG_USER_ONLY. This matches the stub > definitions that we removed for arm_regime_tbi{0,1} before. > > Signed-off-by: Richard Henderson > --- > target/arm/inte

Re: [Qemu-devel] [RFC PATCH] fpu: add compile time check for old glibc/libm and fma

2019-01-07 Thread Alex Bennée
Richard Henderson writes: > On 12/21/18 11:30 AM, Emilio G. Cota wrote: >> +ua.s = 0x0021; >> +ub.s = 0x3ca0; >> +uc.s = 0x0020; >> +ur.h = fma(ua.h, ub.h, uc.h); >> +if (ur.s != 0x0021) { > > Forgot your ull's, but otherwise o

Re: [Qemu-devel] [PATCH v2 20/27] target/arm: Implement pauth_strip

2019-01-07 Thread Peter Maydell
On Fri, 14 Dec 2018 at 05:24, Richard Henderson wrote: > > Stripping out the authentication data does not require any crypto, > it merely requires the virtual address parameters. > > Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell thanks -- PMM

Re: [Qemu-devel] [PULL 00/28] Machine props patches

2019-01-07 Thread Peter Maydell
On Fri, 4 Jan 2019 at 17:30, Marc-André Lureau wrote: > > The following changes since commit 6395fe0c2c7d9f336d87960a7c9924b630c57c91: > > Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' > into staging (2019-01-04 13:22:51 +) > > are available in the Git repository a

Re: [Qemu-devel] [PATCH v2 21/27] target/arm: Implement pauth_auth

2019-01-07 Thread Peter Maydell
On Fri, 14 Dec 2018 at 05:24, Richard Henderson wrote: > > This is not really functional yet, because the crypto is not yet > implemented. This, however follows the Auth pseudo function. > > Signed-off-by: Richard Henderson > --- > target/arm/helper-a64.c | 21 - > 1 file ch

Re: [Qemu-devel] [RFC PATCH 04/25] minikconfig: add AST

2019-01-07 Thread Yang Zhong
On Fri, Jan 04, 2019 at 03:13:03PM +0100, Paolo Bonzini wrote: > On 27/12/18 07:33, Yang Zhong wrote: > > +self.clauses.append(KconfigData.DependsOnClause(var, expr)) > > > > def do_select(self, var, symbol, cond=None): > > -pass > > +cond = (cond & var) if not (cond

[Qemu-devel] [PATCH] block: Fix hangs in synchronous APIs with iothreads

2019-01-07 Thread Kevin Wolf
In the block layer, synchronous APIs are often implemented by creating a coroutine that calls the asynchronous coroutine-based implementation and then waiting for completion with BDRV_POLL_WHILE(). For this to work with iothreads (more specifically, when the synchronous API is called in a thread t

Re: [Qemu-devel] [PATCH for-4.0 v4 4/4] i386: allow to load initrd below 4G for recent linux

2019-01-07 Thread Stefano Garzarella
Hi, On Thu, Dec 27, 2018 at 9:32 PM Eduardo Habkost wrote: > > On Fri, Dec 21, 2018 at 11:10:30AM -0500, Michael S. Tsirkin wrote: > > On Thu, Dec 06, 2018 at 10:32:13AM +0800, Li Zhijian wrote: > > > a new field xloadflags was added to recent x86 linux, and BIT 1: > > > XLF_CAN_BE_LOADED_ABOVE_4

Re: [Qemu-devel] [PATCH v4 04/11] pci/pcie: stop plug/unplug if the slot is locked

2019-01-07 Thread David Hildenbrand
On 12.12.18 10:16, David Hildenbrand wrote: > We better stop right away. For now, errors would be partially ignored > (so the guest might get informed or the device might get unplugged), > although actual plug/unplug will be reported as failed to the user. > > While at it, properly move the check

Re: [Qemu-devel] [PATCH v1] dump: Set correct vaddr for ELF dump

2019-01-07 Thread Marc-André Lureau
Hi On Tue, Dec 25, 2018 at 5:52 PM Jon Doron wrote: > > vaddr needs to be equal to the paddr since the dump file represents the > physical memory image. > > Without setting vaddr correctly, GDB would load all the different memory > regions on top of each other to vaddr 0, thus making GDB showing

[Qemu-devel] [PULL v2 01/28] hw: apply accel compat properties without touching globals

2019-01-07 Thread Marc-André Lureau
Instead of registering compat properties as globals, let's keep them in their own array, to avoid mixing with user globals. Introduce object_apply_global_props() function, to apply compatibility properties from a GPtrArray. Signed-off-by: Marc-André Lureau Reviewed-by: Igor Mammedov Reviewed-by

[Qemu-devel] [PULL v2 08/28] compat: replace PC_COMPAT_2_12 & HW_COMPAT_2_12 macros

2019-01-07 Thread Marc-André Lureau
Use static arrays instead. Suggested-by: Eduardo Habkost Signed-off-by: Marc-André Lureau Reviewed-by: Igor Mammedov Reviewed-by: Cornelia Huck Acked-by: Eduardo Habkost --- include/hw/boards.h| 3 +++ include/hw/compat.h| 27 --- include/hw/i386/pc.h

[Qemu-devel] [PULL v2 06/28] compat: replace PC_COMPAT_3_1 & HW_COMPAT_3_1 macros

2019-01-07 Thread Marc-André Lureau
Use static arrays instead. Suggested-by: Eduardo Habkost Signed-off-by: Marc-André Lureau Reviewed-by: Igor Mammedov Reviewed-by: Cornelia Huck Acked-by: Eduardo Habkost --- include/hw/boards.h| 3 +++ include/hw/compat.h| 11 --- include/hw/i386/pc.h | 9 ++--

[Qemu-devel] [PULL v2 02/28] machines: replace COMPAT define with a static array

2019-01-07 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau Reviewed-by: Igor Mammedov Reviewed-by: Cornelia Huck Acked-by: Eduardo Habkost --- include/hw/boards.h| 10 +- hw/arm/virt.c | 45 ++-- hw/i386/pc_piix.c | 474 + hw/i386/pc_q35.c |

[Qemu-devel] [PULL v2 04/28] machine: move compat properties out of globals

2019-01-07 Thread Marc-André Lureau
Move the compat arrays inside functions that use them. Signed-off-by: Marc-André Lureau Reviewed-by: Igor Mammedov Reviewed-by: Cornelia Huck Acked-by: Eduardo Habkost --- hw/arm/virt.c | 94 +++--- hw/i386/pc_piix.c | 607 ++--- hw/i386/

[Qemu-devel] [PULL v2 15/28] compat: replace PC_COMPAT_2_5 & HW_COMPAT_2_5 macros

2019-01-07 Thread Marc-André Lureau
Use static arrays instead. Suggested-by: Eduardo Habkost Signed-off-by: Marc-André Lureau Reviewed-by: Igor Mammedov Reviewed-by: Cornelia Huck Acked-by: Eduardo Habkost --- include/hw/boards.h| 3 +++ include/hw/compat.h| 24 include/hw/i386/pc.h

[Qemu-devel] [PULL v2 03/28] hw: apply machine compat properties without touching globals

2019-01-07 Thread Marc-André Lureau
Similarly to accel properties, move compat properties out of globals registration, and apply the machine compat properties during device_post_init(). Signed-off-by: Marc-André Lureau Reviewed-by: Igor Mammedov Reviewed-by: Cornelia Huck Acked-by: Eduardo Habkost --- include/hw/boards.h

[Qemu-devel] [PULL v2 11/28] compat: replace PC_COMPAT_2_9 & HW_COMPAT_2_9 macros

2019-01-07 Thread Marc-André Lureau
Use static arrays instead. Suggested-by: Eduardo Habkost Signed-off-by: Marc-André Lureau Reviewed-by: Igor Mammedov Reviewed-by: Cornelia Huck Acked-by: Eduardo Habkost --- include/hw/boards.h| 3 +++ include/hw/compat.h| 19 --- include/hw/i386/pc.h |

[Qemu-devel] [PULL v2 13/28] compat: replace PC_COMPAT_2_7 & HW_COMPAT_2_7 macros

2019-01-07 Thread Marc-André Lureau
Use static arrays instead. Suggested-by: Eduardo Habkost Signed-off-by: Marc-André Lureau Reviewed-by: Igor Mammedov Reviewed-by: Cornelia Huck Acked-by: Eduardo Habkost --- include/hw/boards.h| 3 +++ include/hw/compat.h| 23 --- include/hw/i386/pc.h

[Qemu-devel] [PULL v2 17/28] compat: replace PC_COMPAT_2_3 & HW_COMPAT_2_3 macros

2019-01-07 Thread Marc-André Lureau
Use static arrays instead. I decided to rename the conflicting pc_compat_2_3() function with pc_compat_2_3_fn(). Suggested-by: Eduardo Habkost Signed-off-by: Marc-André Lureau Reviewed-by: Igor Mammedov Reviewed-by: Cornelia Huck Acked-by: Eduardo Habkost --- include/hw/boards.h | 3 ++ i

[Qemu-devel] [PULL v2 10/28] compat: replace PC_COMPAT_2_10 & HW_COMPAT_2_10 macros

2019-01-07 Thread Marc-André Lureau
Use static arrays instead. Suggested-by: Eduardo Habkost Signed-off-by: Marc-André Lureau Reviewed-by: Igor Mammedov Reviewed-by: Cornelia Huck Acked-by: Eduardo Habkost --- include/hw/boards.h| 3 +++ include/hw/compat.h| 11 --- include/hw/i386/pc.h | 17 ++--

[Qemu-devel] [PULL v2 12/28] compat: replace PC_COMPAT_2_8 & HW_COMPAT_2_8 macros

2019-01-07 Thread Marc-André Lureau
Use static arrays instead. Suggested-by: Eduardo Habkost Signed-off-by: Marc-André Lureau Reviewed-by: Igor Mammedov Reviewed-by: Cornelia Huck Acked-by: Eduardo Habkost --- include/hw/boards.h| 3 +++ include/hw/compat.h| 43 --- include/hw/i

[Qemu-devel] [PULL v2 24/28] qdev-props: convert global_props to GPtrArray

2019-01-07 Thread Marc-André Lureau
A step towards being able to call a common function, object_apply_global_props(). Signed-off-by: Marc-André Lureau Reviewed-by: Igor Mammedov Reviewed-by: Cornelia Huck Acked-by: Eduardo Habkost --- hw/core/qdev-properties.c | 29 - 1 file changed, 20 insertions(+)

[Qemu-devel] [PULL v2 19/28] compat: replace PC_COMPAT_2_1 & HW_COMPAT_2_1 macros

2019-01-07 Thread Marc-André Lureau
Use static arrays instead. I decided to rename the conflicting pc_compat_2_1() function with pc_compat_2_1_fn(). Suggested-by: Eduardo Habkost Signed-off-by: Marc-André Lureau Reviewed-by: Igor Mammedov Reviewed-by: Cornelia Huck Acked-by: Eduardo Habkost --- include/hw/boards.h | 3 +++

[Qemu-devel] [PULL v2 05/28] hw: remove SET_MACHINE_COMPAT

2019-01-07 Thread Marc-André Lureau
No longer needed. Signed-off-by: Marc-André Lureau Reviewed-by: Igor Mammedov Reviewed-by: Cornelia Huck Acked-by: Eduardo Habkost --- include/hw/boards.h | 12 1 file changed, 12 deletions(-) diff --git a/include/hw/boards.h b/include/hw/boards.h index f14c38bb63..0566742412 10

[Qemu-devel] [PULL v2 16/28] compat: replace PC_COMPAT_2_4 & HW_COMPAT_2_4 macros

2019-01-07 Thread Marc-André Lureau
Use static arrays instead. Suggested-by: Eduardo Habkost Signed-off-by: Marc-André Lureau Reviewed-by: Igor Mammedov Reviewed-by: Cornelia Huck Acked-by: Eduardo Habkost --- include/hw/boards.h| 3 ++ include/hw/compat.h| 27 -- include/hw/i386/pc.h | 74 ++

[Qemu-devel] [PULL v2 09/28] compat: replace PC_COMPAT_2_11 & HW_COMPAT_2_11 macros

2019-01-07 Thread Marc-André Lureau
Use static arrays instead. Suggested-by: Eduardo Habkost Signed-off-by: Marc-André Lureau Reviewed-by: Igor Mammedov Reviewed-by: Cornelia Huck Acked-by: Eduardo Habkost --- include/hw/boards.h| 3 +++ include/hw/compat.h| 19 --- include/hw/i386/pc.h |

[Qemu-devel] [PULL v2 07/28] compat: replace PC_COMPAT_3_0 & HW_COMPAT_3_0 macros

2019-01-07 Thread Marc-André Lureau
Use static arrays instead. Suggested-by: Eduardo Habkost Signed-off-by: Marc-André Lureau Reviewed-by: Igor Mammedov Reviewed-by: Cornelia Huck Acked-by: Eduardo Habkost --- include/hw/boards.h| 3 +++ include/hw/compat.h| 3 --- include/hw/i386/pc.h | 17 ++--

[Qemu-devel] [PULL v2 18/28] compat: replace PC_COMPAT_2_2 & HW_COMPAT_2_2 macros

2019-01-07 Thread Marc-André Lureau
Use static arrays instead. I decided to rename the conflicting pc_compat_2_2() function with pc_compat_2_2_fn(). Suggested-by: Eduardo Habkost Signed-off-by: Marc-André Lureau Reviewed-by: Igor Mammedov Reviewed-by: Cornelia Huck Acked-by: Eduardo Habkost --- include/hw/boards.h | 3 ++ i

[Qemu-devel] [PULL v2 00/28] Machine props patches

2019-01-07 Thread Marc-André Lureau
The following changes since commit e59dbbac0364344a3ad84c3497a98c56003d3fb8: Merge remote-tracking branch 'remotes/philmd/tags/fw_cfg-20190104-pull-request' into staging (2019-01-04 18:23:13 +) are available in the Git repository at: https://github.com/elmarco/qemu.git tags/machine-pro

[Qemu-devel] [PULL v2 20/28] include: remove compat.h

2019-01-07 Thread Marc-André Lureau
The header is now empty. Signed-off-by: Marc-André Lureau Reviewed-by: Igor Mammedov Reviewed-by: Cornelia Huck Acked-by: Eduardo Habkost --- include/hw/compat.h| 4 include/hw/i386/pc.h | 1 - hw/arm/virt.c | 1 - hw/ppc/spapr.c | 1 - hw/s390x/s39

[Qemu-devel] [PULL v2 21/28] compat: remove remaining PC_COMPAT macros

2019-01-07 Thread Marc-André Lureau
Use static arrays instead. I decided to rename the conflicting pc_compat_2_1() function with pc_compat_2_1_fn(). Suggested-by: Eduardo Habkost Signed-off-by: Marc-André Lureau Reviewed-by: Igor Mammedov Reviewed-by: Cornelia Huck Acked-by: Eduardo Habkost --- include/hw/i386/pc.h | 236 +++-

[Qemu-devel] [PULL v2 23/28] qdev: all globals are now user-provided

2019-01-07 Thread Marc-André Lureau
All globals are now either provided via -global or through -cpu features (CPU features are implemented by registering globals). If the global isn't being used, it should warn in either case. We can thus consider that all global_props are "user-provided" globals. No need to track this per-globals

[Qemu-devel] [PULL v2 14/28] compat: replace PC_COMPAT_2_6 & HW_COMPAT_2_6 macros

2019-01-07 Thread Marc-André Lureau
Use static arrays instead. Suggested-by: Eduardo Habkost Signed-off-by: Marc-André Lureau Reviewed-by: Igor Mammedov Reviewed-by: Cornelia Huck Acked-by: Eduardo Habkost --- include/hw/boards.h| 3 +++ include/hw/compat.h| 15 --- include/hw/i386/pc.h | 23

[Qemu-devel] [PULL v2 22/28] qdev: make a separate helper function to apply compat properties

2019-01-07 Thread Marc-André Lureau
This will allow to apply compat properties on other objects than QDev easily. Signed-off-by: Marc-André Lureau Reviewed-by: Cornelia Huck Reviewed-by: Igor Mammedov Acked-by: Eduardo Habkost --- include/hw/qdev-core.h | 2 ++ hw/core/qdev.c | 6 +- 2 files changed, 7 insertions(+)

[Qemu-devel] [PULL v2 26/28] qdev-props: call object_apply_global_props()

2019-01-07 Thread Marc-André Lureau
It's now possible to use the common function. Teach object_apply_global_props() to warn if Error argument is NULL. Signed-off-by: Marc-André Lureau Reviewed-by: Igor Mammedov Reviewed-by: Cornelia Huck Acked-by: Eduardo Habkost --- hw/core/qdev-properties.c | 24 ++-- qom

Re: [Qemu-devel] [PATCH for-4.0 v9 00/16] qemu_thread_create: propagate the error to callers to handle

2019-01-07 Thread Fei Li
Hi all, Sorry for the mistakenly deleted " include "qapi/error.h" " for [PATCH for-4.0 v9 11/16] qemu_thread: supplement error handling for emulated_realize, will add this #include back in next version. Have a nice day, and again sorry for the trouble. Fei 在 2019/1/2 下午9:46, no-re...@patche

Re: [Qemu-devel] [RFC PATCH] fpu: add compile time check for old glibc/libm and fma

2019-01-07 Thread Alex Bennée
Emilio G. Cota writes: > On Thu, Dec 20, 2018 at 11:10:08 +, Alex Bennée wrote: > (snip) >> +#if defined(__GLIBC__) && (__GLIBC__ == 2 && __GLIBC_MINOR__ <= 12) >> +#define QEMU_HARDFLOAT_USE_FMA 0 >> +#else >> +#define QEMU_HARDFLOAT_USE_FMA 1 >> +#endif >> +#else >> +#define QEMU_HARDFLOA

[Qemu-devel] [PULL v2 28/28] hostmem: use object id for memory region name with >= 4.0

2019-01-07 Thread Marc-André Lureau
hostmem-file and hostmem-memfd use the whole object path for the memory region name, and hostname-ram uses only the path component (the object id, or canonical path basename): qemu -m 1024 -object memory-backend-file,id=mem,size=1G,mem-path=/tmp/foo -numa node,memdev=mem -monitor stdio (qemu) inf

[Qemu-devel] [PULL v2 25/28] qdev-props: remove errp from GlobalProperty

2019-01-07 Thread Marc-André Lureau
All qdev_prop_register_global() set &error_fatal for errp, except '-rtc driftfix=slew', which arguably should also use &error_fatal, as otherwise failing to apply the property would only report a warning. Signed-off-by: Marc-André Lureau Reviewed-by: Igor Mammedov Reviewed-by: Cornelia Huck Ack

[Qemu-devel] [PULL v2 27/28] arm: replace instance_post_init()

2019-01-07 Thread Marc-André Lureau
Replace arm_cpu_post_init() instance callback by calling it from leaf classes, to avoid potential ordering issue with other post_init callbacks. Signed-off-by: Marc-André Lureau Suggested-by: Igor Mammedov Reviewed-by: Igor Mammedov Acked-by: Eduardo Habkost --- target/arm/cpu-qom.h | 3 +++

Re: [Qemu-devel] [PATCH] sun4u: add power_mem_read routine

2019-01-07 Thread Mark Cave-Ayland
On 04/01/2019 09:53, P J P wrote: > +-- On Fri, 4 Jan 2019, Mark Cave-Ayland wrote --+ > | I asked someone with real Ultra-5 hardware to check this for me, and > they've > | sent me back the following output: > | > | ok .properties > | address fffb8000 > | button > | interrupts

Re: [Qemu-devel] do not lseek in qcow2 block_status

2019-01-07 Thread Max Reitz
On 24.12.18 16:50, Vladimir Sementsov-Ogievskiy wrote: > Hi all! > > bdrv_co_block_status digs bs->file for additional, more accurate search for > hole > inside region, reported as DATA by bs since long-ago > >commit 5daa74a6ebce7543aaad178c4061dc087bb4c705 >Author: Paolo Bonzini >D

Re: [Qemu-devel] How to add a new target architecture

2019-01-07 Thread Yoshinori Sato
On Mon, 07 Jan 2019 06:48:33 +0900, Richard Henderson wrote: > > On 1/6/19 11:11 PM, Yoshinori Sato wrote: > > Hello. > > I written Renesas RX port. > > It is works to boot linux kernel of minimal configuration. > > > > I'd like to merge this into the qmeu release and I need some > > advice on ho

Re: [Qemu-devel] [PATCH] qga: check length of command-line & environment variables

2019-01-07 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190107103426.2669-1-ppan...@redhat.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!

Re: [Qemu-devel] [PATCH v2 00/10] tcg vector improvements

2019-01-07 Thread Mark Cave-Ayland
On 04/01/2019 22:31, Richard Henderson wrote: > I've split this out from the target/ppc patch set in which > it was developed. > > > r~ > > > Richard Henderson (10): > tcg: Add logical simplifications during gvec expand > tcg: Add gvec expanders for nand, nor, eqv > tcg: Add write_aofs t

Re: [Qemu-devel] [PATCH 0/3] Allow hw/audio drivers to pass raw DB values to audio/ drivers

2019-01-07 Thread Gerd Hoffmann
On Fri, Dec 21, 2018 at 10:14:42PM +0100, Yaroslav Isakov wrote: > This patch series introduces the ability for virtual audio drivers to pass > information about guest-chosen DB values to backend audio drivers. > > For now, supported virtual driver is hda-codec, and backend is pulseaudio, as > the

  1   2   3   4   >