On 21/12/18 22:09, Peter Maydell wrote:
> I don't really understand what's going on here, or why
> it only happens with this one system (my main x86-64
> Linux Ubuntu 16.04.5 box) and not the various others I'm
> running test builds on. But it does seem to be 100%
> reliable with any of these pullr
On 22/12/18 02:01, Robert Hoo wrote:
> On Fri, 2018-12-21 at 16:27 +0100, Paolo Bonzini wrote:
>> On 21/12/18 16:22, Philippe Mathieu-Daudé wrote:
>>> Hi Paolo,
>>>
>>> On 12/21/18 7:30 AM, Paolo Bonzini wrote:
From: Robert Hoo
Processor tracing is not yet implemented for KVM and it
On 21/12/18 23:31, Max Reitz wrote:
> I suppose the issue is that QMP events are sent by one thread, and
> client disconnects are handled by a different one. So if a QMP event is
> sent while a client disconnects concurrently, races may occur; and the
> only protection against concurrent access ap
On 2018/12/11 1:31, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert"
>
> Hi,
> This is the first RFC for the QEMU side of 'virtio-fs';
> a new mechanism for mounting host directories into the guest
> in a fast, consistent and secure manner. Our primary use
> case is kata co
From: Yuval Shaia
Device is not supporting QP0, only QP1.
Signed-off-by: Yuval Shaia
Reviewed-by: Marcel Apfelbaum
Signed-off-by: Marcel Apfelbaum
---
hw/rdma/rdma_backend.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/rdma/rdma_backend.h b/hw/rdma/rdma_backend.h
in
From: Yuval Shaia
RDMA MAD kernel module (ibcm) disallow more than one MAD-agent for a
given MAD class.
This does not go hand-by-hand with qemu pvrdma device's requirements
where each VM is MAD agent.
Fix it by adding implementation of RDMA MAD multiplexer service which on
one hand register as a
From: Yuval Shaia
Return value of 0 means ok, we want to free the memory only in case of
error.
Signed-off-by: Yuval Shaia
Message-Id: <20181025061700.17050-1-yuval.sh...@oracle.com>
Reviewed-by: Marcel Apfelbaum
Signed-off-by: Marcel Apfelbaum
---
hw/rdma/vmw/pvrdma_cmd.c | 2 +-
1 file chan
The following changes since commit 891ff9f4a371da2dbd5244590eb35e8d803e18d8:
Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-4.0-20181221' into
staging (2018-12-21 15:49:59 +)
are available in the Git repository at:
https://github.com/marcel-apf/qemu tags/rdma-pull-request
f
From: Yuval Shaia
Commit 6e7dba23af ("hw/pvrdma: Make default pkey 0x") exports
default pkey as external definition but omit the change from 0x7FFF to
0x.
Fixes: 6e7dba23af ("hw/pvrdma: Make default pkey 0x")
Signed-off-by: Yuval Shaia
Reviewed-by: Marcel Apfelbaum
Signed-off-by:
From: Yuval Shaia
The function pvrdma_post_cqe populates CQE entry with opcode from the
given completion element. For receive operation value was not set. Fix
it by setting it to IBV_WC_RECV.
Signed-off-by: Yuval Shaia
Reviewed-by: Marcel Apfelbaum
Signed-off-by: Marcel Apfelbaum
---
hw/rdma
From: Yuval Shaia
Function create_ah might return NULL, let's exit with an error.
Signed-off-by: Yuval Shaia
Reviewed-by: Marcel Apfelbaum
Signed-off-by: Marcel Apfelbaum
---
hw/rdma/rdma_backend.c | 4
1 file changed, 4 insertions(+)
diff --git a/hw/rdma/rdma_backend.c b/hw/rdma/rdma_
From: Yuval Shaia
pvrdma requires that the same GID attached to it will be attached to the
backend device in the host.
A new QMP messages is defined so pvrdma device can broadcast any change
made to its GID table. This event is captured by libvirt which in turn
will update the GID table in the
From: Yuval Shaia
Upon completion of incoming packet the device pushes CQE to driver's RX
ring and notify the driver (msix).
While for data-path incoming packets the driver needs the ability to
control whether it wished to receive interrupts or not, for control-path
packets such as incoming MAD t
From: Yuval Shaia
MAD (Management Datagram) packets are widely used by various modules
both in kernel and in user space for example the rdma_* API which is
used to create and maintain "connection" layer on top of RDMA uses
several types of MAD packets.
For more information please refer to chapte
From: Yuval Shaia
pvrdma setup requires vmxnet3 device on PCI function 0 and PVRDMA device
on PCI function 1.
pvrdma device needs to access vmxnet3 device object for several reasons:
1. Make sure PCI function 0 is vmxnet3.
2. To monitor vmxnet3 device state.
3. To configure node_guid accoring to
From: Yuval Shaia
opcode for WC should be set by the device and not taken from work
element.
Signed-off-by: Yuval Shaia
Reviewed-by: Marcel Apfelbaum
Signed-off-by: Marcel Apfelbaum
---
hw/rdma/vmw/pvrdma_qp_ops.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/rdma/vm
From: Yuval Shaia
Add ability to pass specific WC attributes to CQE such as GRH_BIT flag.
Signed-off-by: Yuval Shaia
Reviewed-by: Marcel Apfelbaum
Signed-off-by: Marcel Apfelbaum
---
hw/rdma/rdma_backend.c | 59 +++--
hw/rdma/rdma_backend.h | 4 +--
From: Yuval Shaia
This function cannot fail - fix it to return void
Signed-off-by: Yuval Shaia
Reviewed-by: Marcel Apfelbaum
Signed-off-by: Marcel Apfelbaum
---
hw/rdma/vmw/pvrdma_main.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/hw/rdma/vmw/pvrdma_main.c b/hw/rdm
From: Yuval Shaia
Guest driver enforces it, we should also.
Signed-off-by: Yuval Shaia
Reviewed-by: Marcel Apfelbaum
Signed-off-by: Marcel Apfelbaum
---
hw/rdma/vmw/pvrdma.h | 2 ++
hw/rdma/vmw/pvrdma_main.c | 12
2 files changed, 14 insertions(+)
diff --git a/hw/rdma/vmw
From: Yuval Shaia
node_guid should be set once device is load.
Make node_guid be GID format (32 bit) of PCI function 0 vmxnet3 device's
MAC.
A new function was added to do the conversion.
So for example the MAC 56:b6:44:e9:62:dc will be converted to GID
54b6:44ff:fee9:62dc.
Signed-off-by: Yuval
From: Yuval Shaia
The control over the RDMA device's GID table is done by updating the
device's Ethernet function addresses.
Usually the first GID entry is determined by the MAC address, the second
by the first IPv6 address and the third by the IPv4 address. Other
entries can be added by adding m
From: Yuval Shaia
Driver checks error code let's set it.
In addition, for code simplification purposes, set response's fields
ack, response and err outside of the scope of command handlers.
Signed-off-by: Yuval Shaia
Reviewed-by: Marcel Apfelbaum
Signed-off-by: Marcel Apfelbaum
---
hw/rdma/v
From: Yuval Shaia
User should be able to control the device by changing Ethernet function
state so if user runs 'ifconfig ens3 down' the PVRDMA function should be
down as well.
Signed-off-by: Yuval Shaia
Reviewed-by: Marcel Apfelbaum
Signed-off-by: Marcel Apfelbaum
---
hw/rdma/vmw/pvrdma_cmd
From: Yuval Shaia
Device supports only one port, let's remove a dead code that handles
more than one port.
Signed-off-by: Yuval Shaia
Reviewed-by: Marcel Apfelbaum
Signed-off-by: Marcel Apfelbaum
---
hw/rdma/rdma_rm.c | 34 --
hw/rdma/rdma_rm.h | 2
From: Yuval Shaia
In order to clean some external resources such as GIDs, QPs etc,
register to receive notification when VM is shutdown.
Signed-off-by: Yuval Shaia
Reviewed-by: Marcel Apfelbaum
Signed-off-by: Marcel Apfelbaum
---
hw/rdma/vmw/pvrdma.h | 2 ++
hw/rdma/vmw/pvrdma_main.c |
From: Yuval Shaia
Notifier will be used for signaling shutdown event to inform system is
shutdown. This will allow devices and other component to run some
cleanup code needed before VM is shutdown.
Signed-off-by: Yuval Shaia
Reviewed-by: Cornelia Huck
Signed-off-by: Marcel Apfelbaum
---
incl
From: Prasad J Pandit
create_cq and create_qp routines allocate ring object, but it's
not released in case of an error, leading to memory leakage.
Reported-by: Li Qiang
Signed-off-by: Prasad J Pandit
Reviewed-by: Yuval Shaia
Signed-off-by: Marcel Apfelbaum
---
hw/rdma/vmw/pvrdma_cmd.c | 37
From: Yuval Shaia
bitmap_zero_extend is designed to work for extending, not for
shrinking.
Using g_free instead.
Signed-off-by: Yuval Shaia
Reviewed-by: Marcel Apfelbaum
Signed-off-by: Marcel Apfelbaum
---
hw/rdma/rdma_rm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/
From: Prasad J Pandit
rdma back-end has scatter/gather array ibv_sge[MAX_SGE=4] set
to have 4 elements. A guest could send a 'PvrdmaSqWqe' ring element
with 'num_sge' set to > MAX_SGE, which may lead to OOB access issue.
Add check to avoid it.
Reported-by: Saar Amar
Signed-off-by: Prasad J Pand
From: Prasad J Pandit
With commit 4481985c (rdma: check num_sge does not exceed MAX_SGE)
macro VENDOR_ERR_NO_SGE is no longer in use - delete it.
Signed-off-by: Prasad J Pandit
Reviewed-by: Yuval Shaia
Signed-off-by: Marcel Apfelbaum
---
hw/rdma/rdma_backend.c | 3 +--
1 file changed, 1 inse
From: Prasad J Pandit
Define skeleton 'uar_read' routine. Avoid NULL dereference.
Reported-by: Li Qiang
Signed-off-by: Prasad J Pandit
Reviewed-by: Marcel Apfelbaum
Signed-off-by: Marcel Apfelbaum
---
hw/rdma/vmw/pvrdma_main.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/hw/rdm
From: Prasad J Pandit
When creating CQ/QP rings, an object can have up to
PVRDMA_MAX_FAST_REG_PAGES 8 pages. Check 'npages' parameter
to avoid excessive memory allocation or a null dereference.
Reported-by: Li Qiang
Signed-off-by: Prasad J Pandit
Reviewed-by: Yuval Shaia
Signed-off-by: Marcel
From: Yuval Shaia
When device goes down the function fini_ports loops over all entries in
gid table regardless of the fact whether entry is valid or not. In case
that entry is not valid we'd like to skip from any further processing in
backend device.
Signed-off-by: Yuval Shaia
Reviewed-by: Marc
From: Prasad J Pandit
pvrdma_idx_ring_has_[data/space] routines also return invalid
index PVRDMA_INVALID_IDX[=-1], if ring has no data/space. Check
return value from these routines to avoid plausible infinite loops.
Reported-by: Li Qiang
Signed-off-by: Prasad J Pandit
Reviewed-by: Yuval Shaia
From: Prasad J Pandit
If during pvrdma device initialisation an error occurs,
pvrdma_realize() does not release memory resources, leading
to memory leakage.
Reported-by: Li Qiang
Signed-off-by: Prasad J Pandit
Message-Id: <20181212175817.815-1-ppan...@redhat.com>
Reviewed-by: Yuval Shaia
Sign
From: Yuval Shaia
Interface with the device is changed with the addition of support for
MAD packets.
Adjust documentation accordingly.
While there fix a minor mistake which may lead to think that there is a
relation between using RXE on host and the compatibility with bare-metal
peers.
Signed-o
Memset vhost_dev to zero in the vhost_dev_cleanup function.
This causes dev.vqs to be NULL, so that
vqs does not free up space when calling the g_free function.
This will result in a memory leak. But you can't release vqs
directly in the vhost_dev_cleanup function, because vhost_net
will also call
On Sat, 22 Dec 2018 at 08:41, Paolo Bonzini wrote:
>
> On 21/12/18 22:09, Peter Maydell wrote:
> > I don't really understand what's going on here, or why
> > it only happens with this one system (my main x86-64
> > Linux Ubuntu 16.04.5 box) and not the various others I'm
> > running test builds on
On Sat, 22 Dec 2018 at 09:50, Marcel Apfelbaum
wrote:
>
> The following changes since commit 891ff9f4a371da2dbd5244590eb35e8d803e18d8:
>
> Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-4.0-20181221'
> into staging (2018-12-21 15:49:59 +)
>
> are available in the Git repository
Hi Peter,
On 12/22/18 3:59 PM, Peter Maydell wrote:
On Sat, 22 Dec 2018 at 09:50, Marcel Apfelbaum
wrote:
The following changes since commit 891ff9f4a371da2dbd5244590eb35e8d803e18d8:
Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-4.0-20181221'
into staging (2018-12-21 15:49:59
On Mon 17 Dec 2018 11:43:18 PM CET, Max Reitz wrote:
> @@ -3327,6 +,7 @@ static int img_rebase(int argc, char **argv)
> qdict_put_bool(options, BDRV_OPT_FORCE_SHARE, true);
> }
>
> +bdrv_refresh_filename(bs);
> overlay_filename = bs->exa
Public bug reported:
The bug is present in QEMU 2.8.1 and, if my analysis is correct, also on
master.
I first noticed that a PL011 UART driver, which is fine on real
hardware, fails to enable the RX interrupt in the IMSC register when
running in QEMU. However, the problem only comes up if the cod
Adding the link script.
** Attachment added: "linkscript.ld"
https://bugs.launchpad.net/qemu/+bug/1809546/+attachment/5224337/+files/linkscript.ld
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/18
Sorry for a mess, forgot to add maintainer. Gerd, please, take a look
at these patches.
пт, 21 дек. 2018 г. в 22:40, Yaroslav Isakov :
>
> This patch series introduces the ability for virtual audio drivers to pass
> information about guest-chosen DB values to backend audio drivers.
>
> For now, su
Patchew URL:
https://patchew.org/QEMU/20181213223737.11793-1-pbonz...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20181213223737.11793-1-pbonz...@redhat.com
Type: series
Subject: [Qemu-devel] [PATCH 0/2] Fix TABs in
On 20/12/2018 17:57, Richard Henderson wrote:
> On 12/20/18 8:31 AM, Mark Cave-Ayland wrote:
>> The VSX register array is a block of 64 128-bit registers where the first 32
>> registers consist of the existing 64-bit FP registers extended to 128-bit
>> using new VSR registers, and the last 32 regi
This bug is not present in QEMU-3.1.0.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1793275
Title:
Hosts fail to start after update to QEMU 3.0
Status in QEMU:
New
Bug description:
Host OS:
On 12/22/18 10:09 AM, Mark Cave-Ayland wrote:
> Do you want these helpers used just within
> linux-user/ppc/signal.c or also within the other files touched by this patch
> e.g.
> arch_dump.c, gdbstub.c etc.?
Everywhere. Thanks!
r~
The dmg file has many tables which describe: "start from sector XXX to
sector XXX, the compression method is XXX and where the compressed data
resides on".
Each sector in the expanded file should be covered by a table. The table
will describe the offset of compressed data (or raw depends on the ty
There are two bugs in dmg reading.
First, it may hang in binary search. this problem is solved by patch 1.
Second, because of lacking zero chunk table, reading zero sector will
return EIO. thie problem is solved by patch 2 and 3.
Thanks
v1 - >v2:
* fix typos in patch 1
* add patch 2 and patch 3
Signed-off-by: yuchenlin
---
block/dmg.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/block/dmg.c b/block/dmg.c
index 0e05702f5d..6b0a057bf8 100644
--- a/block/dmg.c
+++ b/block/dmg.c
@@ -267,7 +267,7 @@ static int dmg_read_mish_block(BDRVDMGState *s,
DmgHeaderState *d
There is a possible hang in original binary search implementation. That is
if chunk1 = 4, chunk2 = 5, chunk3 = 4, and we go else case.
The chunk1 will be still 4, and so on.
Signed-off-by: yuchenlin
---
block/dmg.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/block/
Because of lacking zero chunk table, reading zero sector will return EIO.
I have submitted a series to fix this problem.
Please refer to this series: http://lists.nongnu.org/archive/html/qemu-
devel/2018-12/msg05637.html
Thanks,
Yu-Chen Lin
--
You received this bug notification because you are
Patchew URL:
https://patchew.org/QEMU/1544796678-12736-1-git-send-email-pmo...@linux.ibm.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 1544796678-12736-1-git-send-email-pmo...@linux.ibm.com
Type: series
Subject: [Qemu-devel]
54 matches
Mail list logo
