[Qemu-devel] [PATCH PULL 01/31] hw/pvrdma: Check the correct return value

[Marcel Apfelbaum]

From: Yuval Shaia <yuval.sh...@oracle.com>

Return value of 0 means ok, we want to free the memory only in case of
error.

Signed-off-by: Yuval Shaia <yuval.sh...@oracle.com>
Message-Id: <20181025061700.17050-1-yuval.sh...@oracle.com>
Reviewed-by: Marcel Apfelbaum<marcel.apfelb...@gmail.com>
Signed-off-by: Marcel Apfelbaum <marcel.apfelb...@gmail.com>
---
 hw/rdma/vmw/pvrdma_cmd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/rdma/vmw/pvrdma_cmd.c b/hw/rdma/vmw/pvrdma_cmd.c
index 4faeb21631..57d6f41ae6 100644
--- a/hw/rdma/vmw/pvrdma_cmd.c
+++ b/hw/rdma/vmw/pvrdma_cmd.c
@@ -232,7 +232,7 @@ static int create_mr(PVRDMADev *dev, union pvrdma_cmd_req 
*req,
                                      cmd->start, cmd->length, host_virt,
                                      cmd->access_flags, &resp->mr_handle,
                                      &resp->lkey, &resp->rkey);
-    if (host_virt && !resp->hdr.err) {
+    if (resp->hdr.err && host_virt) {
         munmap(host_virt, cmd->length);
     }
 
-- 
2.17.1