Re: [Qemu-devel] [PATCH 07/15] spapr_pci: Define SPAPR_MAX_PHBS in hw/pci-host/spapr.h

2018-12-21 Thread Cédric Le Goater
On 12/21/18 1:36 AM, Greg Kurz wrote: > PHB hotplug will bring more users for it. Let's define it along with > the PHB defines from which it is derived for simplicity. > > While here fix a misleading comment about manual placement, which was > abandoned with 30b3bc5aa9f4. > > Signed-off-by: Greg

Re: [Qemu-devel] [PATCH v8 10/20] replay: introduce info hmp/qmp command

2018-12-21 Thread Pavel Dovgalyuk
> From: Markus Armbruster [mailto:arm...@redhat.com] > Pavel Dovgalyuk writes: > > > This patch introduces 'info replay' monitor command and > > corresponding qmp request. > > These commands request the current record/replay mode, replay log file name, > > and the execution step (number or record

Re: [Qemu-devel] [PATCH 0/2] optimize waiting for free thread to do compression

2018-12-21 Thread Peter Xu
On Thu, Dec 13, 2018 at 03:57:25PM +0800, guangrong.x...@gmail.com wrote: > From: Xiao Guangrong > > Currently we have two behaviors if all threads are busy to do compression, > the main thread mush wait one of them becoming free if @compress-wait-thread > set to on or the main thread can directl

Re: [Qemu-devel] [PATCH 14/15] spapr: Expose the name of the interrupt controller node

2018-12-21 Thread Cédric Le Goater
On 12/21/18 7:35 AM, Greg Kurz wrote: > This will be needed by PHB hotplug in order to access the phandle property. > > Signed-off-by: Greg Kurz I would have used the prefix 'spapr_dt_', but it's minor. Reviewed-by: Cédric Le Goater Thanks, C. > --- > hw/intc/spapr_xive.c|9 +++

Re: [Qemu-devel] is the "tcg translation" necessary when the "kvm acceleration" emulation mode enabled?

2018-12-21 Thread tugouxp
much appreciate! :) At 2018-12-21 14:33:08, "Paolo Bonzini" wrote: >> scenario 1: did the tcg translation need to be done in this case now >> that the host and target arch is the same? or let the kvm emulation >> the system wit the original instructions with out the TCG >> translation

[Qemu-devel] [Bug 1809252] Re: Password authentication in FIPS-compliant mode

2018-12-21 Thread Tomasz Barański
I understand. Thank you, guys! -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1809252 Title: Password authentication in FIPS-compliant mode Status in QEMU: Invalid Bug description: The documen

Re: [Qemu-devel] travis failures

2018-12-21 Thread Greg Kurz
On Fri, 21 Dec 2018 07:47:07 +0100 Thomas Huth wrote: > On 2018-12-21 04:06, Alexey Kardashevskiy wrote: > > Hi > > > > I am trying https://travis-ci.org/aik/qemu/ and that thing fails every > > time I am not so sure why. > > > > One example: > > https://travis-ci.org/aik/qemu/jobs/470796318 >

Re: [Qemu-devel] did the qemu can emulate the whole system with the processor that without support the "virtulization and kvm"?

2018-12-21 Thread Alex Bennée
tugouxp <13824125...@163.com> writes: > Hi alex: > now my host machine did not have the "/dev/kvm" nodes and no chance to > make it exists. > so i want to know whether the "/dev/kvm" is mandatory for qemu to emulate > the whole system. > so i can make the emulation without the support of

[Qemu-devel] [PATCH v7 00/28] Generalize machine compatibility properties

2018-12-21 Thread Marc-André Lureau
Hi, During "[PATCH v2 05/10] qom/globals: generalize object_property_set_globals()" review, Eduardo suggested to rework the GlobalProperty handling, so that -global is limited to QDev only and we avoid mixing the machine compats and the user-provided -global properties (instead of generalizing -gl

[Qemu-devel] [PATCH v7 06/28] compat: replace PC_COMPAT_3_1 & HW_COMPAT_3_1 macros

2018-12-21 Thread Marc-André Lureau
Use static arrays instead. Suggested-by: Eduardo Habkost Signed-off-by: Marc-André Lureau --- include/hw/boards.h| 3 +++ include/hw/compat.h| 3 --- include/hw/i386/pc.h | 4 ++-- hw/arm/virt.c | 6 +- hw/core/machine.c | 3 +++ hw/i386/pc.c

[Qemu-devel] [PATCH v7 01/28] hw: apply accel compat properties without touching globals

2018-12-21 Thread Marc-André Lureau
Instead of registering compat properties as globals, let's keep them in their own array, to avoid mixing with user globals. Introduce object_apply_global_props() function, to apply compatibility properties from a GPtrArray. Signed-off-by: Marc-André Lureau Reviewed-by: Igor Mammedov --- includ

[Qemu-devel] [PATCH v7 12/28] compat: replace PC_COMPAT_2_8 & HW_COMPAT_2_8 macros

2018-12-21 Thread Marc-André Lureau
Use static arrays instead. Suggested-by: Eduardo Habkost Signed-off-by: Marc-André Lureau --- include/hw/boards.h| 3 +++ include/hw/compat.h| 43 --- include/hw/i386/pc.h | 29 ++-- hw/arm/virt.c | 5 +

[Qemu-devel] [PATCH v7 03/28] hw: apply machine compat properties without touching globals

2018-12-21 Thread Marc-André Lureau
Similarly to accel properties, move compat properties out of globals registration, and apply the machine compat properties during device_post_init(). Signed-off-by: Marc-André Lureau --- include/hw/boards.h| 3 +- hw/arm/virt.c | 27 hw/core/machine.c

[Qemu-devel] [PATCH v7 07/28] compat: replace PC_COMPAT_3_0 & HW_COMPAT_3_0 macros

2018-12-21 Thread Marc-André Lureau
Use static arrays instead. Suggested-by: Eduardo Habkost Signed-off-by: Marc-André Lureau --- include/hw/boards.h| 3 +++ include/hw/compat.h| 3 --- include/hw/i386/pc.h | 17 ++--- hw/arm/virt.c | 6 +- hw/core/machine.c | 3 +++

[Qemu-devel] [PATCH v7 02/28] machines: replace COMPAT define with a static array

2018-12-21 Thread Marc-André Lureau
Signed-off-by: Marc-André Lureau --- include/hw/boards.h| 10 +- hw/arm/virt.c | 45 +-- hw/i386/pc_piix.c | 563 + hw/i386/pc_q35.c | 66 - hw/ppc/spapr.c | 201 ++--- hw/s390x/s390-virtio-ccw.

[Qemu-devel] [PATCH v7 18/28] compat: replace PC_COMPAT_2_2 & HW_COMPAT_2_2 macros

2018-12-21 Thread Marc-André Lureau
Use static arrays instead. I decided to rename the conflicting pc_compat_2_2() function with pc_compat_2_2_fn(). Suggested-by: Eduardo Habkost Signed-off-by: Marc-André Lureau --- include/hw/boards.h | 3 ++ include/hw/compat.h | 3 -- include/hw/i386/pc.h | 97 ++--

[Qemu-devel] [PATCH v7 10/28] compat: replace PC_COMPAT_2_10 & HW_COMPAT_2_10 macros

2018-12-21 Thread Marc-André Lureau
Use static arrays instead. Suggested-by: Eduardo Habkost Signed-off-by: Marc-André Lureau --- include/hw/boards.h| 3 +++ include/hw/compat.h| 11 --- include/hw/i386/pc.h | 17 ++--- hw/arm/virt.c | 6 +- hw/core/machine.c |

[Qemu-devel] [PATCH v7 04/28] machine: move compat properties out of globals

2018-12-21 Thread Marc-André Lureau
Move the compat arrays inside functions that use them. Signed-off-by: Marc-André Lureau --- hw/arm/virt.c | 94 +++-- hw/i386/pc_piix.c | 705 ++--- hw/i386/pc_q35.c | 121 +++ hw/ppc/spapr.c | 254 +++-- hw

[Qemu-devel] [PATCH v7 11/28] compat: replace PC_COMPAT_2_9 & HW_COMPAT_2_9 macros

2018-12-21 Thread Marc-André Lureau
Use static arrays instead. Suggested-by: Eduardo Habkost Signed-off-by: Marc-André Lureau --- include/hw/boards.h| 3 +++ include/hw/compat.h| 19 --- include/hw/i386/pc.h | 9 ++--- hw/arm/virt.c | 6 +- hw/core/machine.c |

[Qemu-devel] [PATCH v7 27/28] arm: replace instance_post_init()

2018-12-21 Thread Marc-André Lureau
Replace arm_cpu_post_init() instance callback by calling it from leaf classes, to avoid potential ordering issue with other post_init callbacks. Signed-off-by: Marc-André Lureau Suggested-by: Igor Mammedov Reviewed-by: Igor Mammedov --- target/arm/cpu-qom.h | 3 +++ target/arm/cpu.h | 2

[Qemu-devel] [PATCH v7 15/28] compat: replace PC_COMPAT_2_5 & HW_COMPAT_2_5 macros

2018-12-21 Thread Marc-André Lureau
Use static arrays instead. Suggested-by: Eduardo Habkost Signed-off-by: Marc-André Lureau --- include/hw/boards.h| 3 +++ include/hw/compat.h| 24 include/hw/i386/pc.h | 4 ++-- hw/core/machine.c | 26 ++ hw/i386/

[Qemu-devel] [PATCH v7 16/28] compat: replace PC_COMPAT_2_4 & HW_COMPAT_2_4 macros

2018-12-21 Thread Marc-André Lureau
Use static arrays instead. Suggested-by: Eduardo Habkost Signed-off-by: Marc-André Lureau --- include/hw/boards.h| 3 ++ include/hw/compat.h| 27 -- include/hw/i386/pc.h | 74 ++ hw/core/machine.c | 29 +

[Qemu-devel] [PATCH v7 05/28] hw: remove SET_MACHINE_COMPAT

2018-12-21 Thread Marc-André Lureau
No longer needed. Signed-off-by: Marc-André Lureau --- include/hw/boards.h | 12 1 file changed, 12 deletions(-) diff --git a/include/hw/boards.h b/include/hw/boards.h index f02d5a1bbd..f743d9d4a4 100644 --- a/include/hw/boards.h +++ b/include/hw/boards.h @@ -287,16 +287,4 @@ struc

[Qemu-devel] [PATCH v7 19/28] compat: replace PC_COMPAT_2_1 & HW_COMPAT_2_1 macros

2018-12-21 Thread Marc-André Lureau
Use static arrays instead. I decided to rename the conflicting pc_compat_2_1() function with pc_compat_2_1_fn(). Suggested-by: Eduardo Habkost Signed-off-by: Marc-André Lureau --- include/hw/boards.h | 3 +++ include/hw/compat.h | 31 --- include/hw/i386/pc.h | 1

[Qemu-devel] [PATCH v7 23/28] qdev: all globals are now user-provided

2018-12-21 Thread Marc-André Lureau
All globals are now either provided via -global or through -cpu features (CPU features are implemented by registering globals). If the global isn't being used, it should warn in either case. We can thus consider that all global_props are "user-provided" globals. No need to track this per-globals

[Qemu-devel] [PATCH v7 08/28] compat: replace PC_COMPAT_2_12 & HW_COMPAT_2_12 macros

2018-12-21 Thread Marc-André Lureau
Use static arrays instead. Suggested-by: Eduardo Habkost Signed-off-by: Marc-André Lureau --- include/hw/boards.h| 3 +++ include/hw/compat.h| 27 --- include/hw/i386/pc.h | 21 ++--- hw/arm/virt.c | 5 + hw/core/m

[Qemu-devel] [PATCH v7 21/28] compat: remove remaining PC_COMPAT macros

2018-12-21 Thread Marc-André Lureau
Use static arrays instead. I decided to rename the conflicting pc_compat_2_1() function with pc_compat_2_1_fn(). Suggested-by: Eduardo Habkost Signed-off-by: Marc-André Lureau --- include/hw/i386/pc.h | 236 +++ hw/i386/pc.c | 232 +++

[Qemu-devel] [PATCH v7 09/28] compat: replace PC_COMPAT_2_11 & HW_COMPAT_2_11 macros

2018-12-21 Thread Marc-André Lureau
Use static arrays instead. Suggested-by: Eduardo Habkost Signed-off-by: Marc-André Lureau --- include/hw/boards.h| 3 +++ include/hw/compat.h| 19 --- include/hw/i386/pc.h | 13 ++--- hw/arm/virt.c | 5 + hw/core/machine.c

[Qemu-devel] [PATCH v7 26/28] qdev-props: call object_apply_global_props()

2018-12-21 Thread Marc-André Lureau
It's now possible to use the common function. Teach object_apply_global_props() to warn if Error argument is NULL. Signed-off-by: Marc-André Lureau Reviewed-by: Igor Mammedov --- hw/core/qdev-properties.c | 24 ++-- qom/object.c | 12 +++- 2 files chang

[Qemu-devel] [PATCH v7 13/28] compat: replace PC_COMPAT_2_7 & HW_COMPAT_2_7 macros

2018-12-21 Thread Marc-André Lureau
Use static arrays instead. Suggested-by: Eduardo Habkost Signed-off-by: Marc-André Lureau --- include/hw/boards.h| 3 +++ include/hw/compat.h| 23 --- include/hw/i386/pc.h | 34 ++ hw/arm/virt.c | 5 +

[Qemu-devel] [PATCH v7 22/28] qdev: make a separate helper function to apply compat properties

2018-12-21 Thread Marc-André Lureau
This will allow to apply compat properties on other objects than QDev easily. Signed-off-by: Marc-André Lureau --- include/hw/qdev-core.h | 2 ++ hw/core/qdev.c | 6 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/include/hw/qdev-core.h b/include/hw/qdev-core.h index

[Qemu-devel] [PATCH v7 24/28] qdev-props: convert global_props to GPtrArray

2018-12-21 Thread Marc-André Lureau
A step towards being able to call a common function, object_apply_global_props(). Signed-off-by: Marc-André Lureau Reviewed-by: Igor Mammedov --- hw/core/qdev-properties.c | 29 - 1 file changed, 20 insertions(+), 9 deletions(-) diff --git a/hw/core/qdev-properties.

[Qemu-devel] [PATCH v7 14/28] compat: replace PC_COMPAT_2_6 & HW_COMPAT_2_6 macros

2018-12-21 Thread Marc-André Lureau
Use static arrays instead. Suggested-by: Eduardo Habkost Signed-off-by: Marc-André Lureau --- include/hw/boards.h| 3 +++ include/hw/compat.h| 15 --- include/hw/i386/pc.h | 23 ++- hw/arm/virt.c | 5 + hw/core/machine.c

[Qemu-devel] [PATCH v7 25/28] qdev-props: remove errp from GlobalProperty

2018-12-21 Thread Marc-André Lureau
All qdev_prop_register_global() set &error_fatal for errp, except '-rtc driftfix=slew', which arguably should also use &error_fatal, as otherwise failing to apply the property would only report a warning. Signed-off-by: Marc-André Lureau Reviewed-by: Igor Mammedov --- include/hw/qdev-core.h

[Qemu-devel] [PATCH v7 17/28] compat: replace PC_COMPAT_2_3 & HW_COMPAT_2_3 macros

2018-12-21 Thread Marc-André Lureau
Use static arrays instead. I decided to rename the conflicting pc_compat_2_3() function with pc_compat_2_3_fn(). Suggested-by: Eduardo Habkost Signed-off-by: Marc-André Lureau --- include/hw/boards.h | 3 ++ include/hw/compat.h | 39 include/hw/i386/pc.h | 88 ++

[Qemu-devel] [PATCH v7 28/28] hostmem: use object id for memory region name with >= 4.0

2018-12-21 Thread Marc-André Lureau
hostmem-file and hostmem-memfd use the whole object path for the memory region name, and hostname-ram uses only the path component (the object id, or canonical path basename): qemu -m 1024 -object memory-backend-file,id=mem,size=1G,mem-path=/tmp/foo -numa node,memdev=mem -monitor stdio (qemu) inf

[Qemu-devel] [PATCH v7 20/28] include: remove compat.h

2018-12-21 Thread Marc-André Lureau
The header is now empty. Signed-off-by: Marc-André Lureau --- include/hw/compat.h| 4 include/hw/i386/pc.h | 1 - hw/arm/virt.c | 1 - hw/ppc/spapr.c | 1 - hw/s390x/s390-virtio-ccw.c | 1 - 5 files changed, 8 deletions(-) delete mode 100644 include/h

[Qemu-devel] [PATCH v6 06/11] iotests: add filter_generated_node_ids

2018-12-21 Thread John Snow
To mimic the common filter of the same name, but for the python tests. Signed-off-by: John Snow Reviewed-by: Eric Blake Reviewed-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/iotests.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-

[Qemu-devel] [PATCH v6 00/11] bitmaps: remove x- prefix from QMP api

2018-12-21 Thread John Snow
Fix some outstanding bugs, change the design of an API element, remove the x- prefix to signify stability, and add iotests. V6: - Cover letter touchups - 09: Rewrite qmp_filter to cope with lists or dicts. - 11: small touchups. V5: 002: New bugfix. 003: I forgot to actually capture state->bitmap

[Qemu-devel] [PATCH v6 07/11] iotests: add qmp recursive sorting function

2018-12-21 Thread John Snow
Python before 3.6 does not sort dictionaries (including kwargs). Therefore, printing QMP objects involves sorting the keys to have a predictable ordering in the iotests output. This means that iotests output will sometimes show arguments in an order not specified by the test author. Presently, we

[Qemu-devel] [PATCH v6 08/11] iotests: remove default filters from qmp_log

2018-12-21 Thread John Snow
Several places in iotests deal with serializing objects into JSON strings, but to add pretty-printing it seems desirable to localize all of those cases. log() seems like a good candidate for that centralized behavior. log() can already serialize json objects, but when it does so, it assumes filter

[Qemu-devel] [PATCH v6 04/11] block: remove 'x' prefix from experimental bitmap APIs

2018-12-21 Thread John Snow
The 'x' prefix was added because I was uncertain of the direction we'd take for the libvirt API. With the general approach solidified, I feel comfortable committing to this API for 4.0. Signed-off-by: John Snow Reviewed-by: Eric Blake Reviewed-by: Vladimir Sementsov-Ogievskiy --- blockdev.c

[Qemu-devel] [PATCH v6 05/11] iotests.py: don't abort if IMGKEYSECRET is undefined

2018-12-21 Thread John Snow
Instead of using os.environ[], use .get with a default of empty string to match the setup in check to allow us to import the iotests module (for debugging, say) without needing a crafted environment just to import the module. Signed-off-by: John Snow Reviewed-by: Eric Blake Reviewed-by: Vladimir

[Qemu-devel] [PATCH v6 10/11] iotests: implement pretty-print for log and qmp_log

2018-12-21 Thread John Snow
If iotests have lines exceeding >998 characters long, git doesn't want to send it plaintext to the list. We can solve this by allowing the iotests to use pretty printed QMP output that we can match against instead. As a bonus, it's much nicer for human eyes too. Signed-off-by: John Snow Reviewed

[Qemu-devel] [PATCH v6 02/11] block/dirty-bitmap: remove assertion from restore

2018-12-21 Thread John Snow
When making a backup of a dirty bitmap (for transactions), we want to restore that backup whether or not the bitmap is enabled. It is perfectly valid to write into bitmaps that are disabled. It is only illegitimate for the guest to have done so. Remove this assertion. Reviewed-by: Eric Blake Re

[Qemu-devel] [PATCH v6 09/11] iotests: change qmp_log filters to expect QMP objects only

2018-12-21 Thread John Snow
As laid out in the previous commit's message: ``` Several places in iotests deal with serializing objects into JSON strings, but to add pretty-printing it seems desirable to localize all of those cases. log() seems like a good candidate for that centralized behavior. log() can already serialize j

[Qemu-devel] [PATCH v6 01/11] blockdev: abort transactions in reverse order

2018-12-21 Thread John Snow
Presently, we abort transactions in the same order they were processed in. Bitmap commands, though, attempt to restore backup data structures on abort. That's not valid, they need to be aborted in reverse chronological order. Replace the QSIMPLEQ data structure with a QTAILQ one, so we can iterat

[Qemu-devel] [PATCH v6 03/11] blockdev: n-ary bitmap merge

2018-12-21 Thread John Snow
Especially outside of transactions, it is helpful to provide all-or-nothing semantics for bitmap merges. This facilitates the coalescing of multiple bitmaps into a single target for the "checkpoint" interpretation when assembling bitmaps that represent arbitrary points in time from component bitmap

[Qemu-devel] [PATCH v6 11/11] iotests: add iotest 236 for testing bitmap merge

2018-12-21 Thread John Snow
New interface, new smoke test. Signed-off-by: John Snow Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake --- tests/qemu-iotests/236 | 161 + tests/qemu-iotests/236.out | 351 + tests/qemu-iotests/group | 1 + 3 files

Re: [Qemu-devel] [PATCH for-4.0 v8 6/7] qemu_thread_create: propagate the error to callers to handle

2018-12-21 Thread Fei Li
On 12/19/2018 08:14 PM, Fei Li wrote: On 12/19/2018 06:10 PM, Markus Armbruster wrote: Fei Li writes: On 12/13/2018 03:26 PM, Markus Armbruster wrote: There's a question for David Gibson inline.  Please search for /ppc/. Fei Li writes: Make qemu_thread_create() return a Boolean to ind

Re: [Qemu-devel] [PATCH 07/15] spapr_pci: Define SPAPR_MAX_PHBS in hw/pci-host/spapr.h

2018-12-21 Thread Greg Kurz
On Fri, 21 Dec 2018 09:03:49 +0100 Cédric Le Goater wrote: > On 12/21/18 1:36 AM, Greg Kurz wrote: > > PHB hotplug will bring more users for it. Let's define it along with > > the PHB defines from which it is derived for simplicity. > > > > While here fix a misleading comment about manual placem

Re: [Qemu-devel] [PATCH 14/15] spapr: Expose the name of the interrupt controller node

2018-12-21 Thread Greg Kurz
On Fri, 21 Dec 2018 09:12:24 +0100 Cédric Le Goater wrote: > On 12/21/18 7:35 AM, Greg Kurz wrote: > > This will be needed by PHB hotplug in order to access the phandle property. > > > > Signed-off-by: Greg Kurz > > I would have used the prefix 'spapr_dt_', but it's minor. > I guess there

[Qemu-devel] [PATCH] tcmu: Introduce qemu-tcmu utility

2018-12-21 Thread Yaowei Bai
This patch introduces a new utility, qemu-tcmu. Apart from the underlaying protocol it interacts with the world much like qemu-nbd. This patch bases on Fam's version. Qemu-tcmu handles SCSI commands which are passed through userspace from kernel by LIO subsystem using TCMU protocol. Libtcmu is the

Re: [Qemu-devel] travis failures

2018-12-21 Thread Greg Kurz
On Fri, 21 Dec 2018 09:36:23 +0100 Greg Kurz wrote: > On Fri, 21 Dec 2018 07:47:07 +0100 > Thomas Huth wrote: > > > On 2018-12-21 04:06, Alexey Kardashevskiy wrote: > > > Hi > > > > > > I am trying https://travis-ci.org/aik/qemu/ and that thing fails every > > > time I am not so sure why. >

Re: [Qemu-devel] [PATCH v8 08/20] migration: introduce icount field for snapshots

2018-12-21 Thread Pavel Dovgalyuk
> From: Markus Armbruster [mailto:arm...@redhat.com] > Pavel Dovgalyuk writes: > > > Saving icount as a parameters of the snapshot allows navigation between > > them in the execution replay scenario. > > This information can be used for finding a specific snapshot for rewinding > > the recorded e

Re: [Qemu-devel] [RFC PATCH v2 1/7] kbd-state: add keyboard state tracker

2018-12-21 Thread Daniel P . Berrangé
On Wed, Dec 19, 2018 at 01:08:58PM +0100, Gerd Hoffmann wrote: > Now that most user interfaces are using QKeyCodes it is easier to have > common keyboard code useable by all user interfaces. > > This patch adds helper code to track the state of all keyboard keys, > using a bitmap indexed by QKeyCo

Re: [Qemu-devel] [RFC PATCH v2 2/7] kbd-state: use state tracker for sdl2

2018-12-21 Thread Daniel P . Berrangé
On Wed, Dec 19, 2018 at 01:08:59PM +0100, Gerd Hoffmann wrote: > Use the new keyboard state tracked for sdl2. We can drop the modifier > state tracking from sdl2. Also keyup code is simpler, the state tracker > will take care to not send suspious keyup events to the guest. > > Signed-off-by: Ger

Re: [Qemu-devel] [RFC PATCH v2 3/7] sdl2: use only QKeyCode in sdl2_process_key()

2018-12-21 Thread Daniel P . Berrangé
On Wed, Dec 19, 2018 at 01:09:00PM +0100, Gerd Hoffmann wrote: > Small cleanup. Also drop the special backspace handling, > kbd_put_qcode_console() learned to handle that meanwhile. I'm not seeing what backspace handlking is changed in this patch - i guess this comment is left over from a previou

Re: [Qemu-devel] [RFC PATCH v2 4/7] kbd-state: use state tracker for gtk

2018-12-21 Thread Daniel P . Berrangé
On Wed, Dec 19, 2018 at 01:09:01PM +0100, Gerd Hoffmann wrote: > Use the new keyboard state tracked for gtk. Allows to drop the > gtk-specific modifier state tracking code. > > Signed-off-by: Gerd Hoffmann > --- > include/ui/gtk.h | 2 ++ > ui/gtk.c | 38 ++-

Re: [Qemu-devel] [PATCH 1/3] vfio-ccw: add capabilities chain

2018-12-21 Thread Cornelia Huck
On Wed, 19 Dec 2018 09:28:00 -0700 Alex Williamson wrote: > On Tue, 18 Dec 2018 18:24:00 +0100 > Cornelia Huck wrote: > > > On Mon, 17 Dec 2018 16:53:34 -0500 > > Eric Farman wrote: > > > > > On 11/22/2018 11:54 AM, Cornelia Huck wrote: > > > > > > ...snip... > > > > > > > diff --git

Re: [Qemu-devel] [RFC PATCH v2 5/7] kbd-state: use state tracker for vnc

2018-12-21 Thread Daniel P . Berrangé
On Wed, Dec 19, 2018 at 01:09:02PM +0100, Gerd Hoffmann wrote: > Use the new keyboard state tracked for vnc. Allows to drop the > vnc-specific modifier state tracking code. > > Signed-off-by: Gerd Hoffmann > --- > ui/vnc.h | 5 ++- > ui/vnc.c | 120 > ++---

Re: [Qemu-devel] [RFC PATCH v2 6/7] keymap: pass full keyboard state to keysym2scancode

2018-12-21 Thread Daniel P . Berrangé
On Wed, Dec 19, 2018 at 01:09:03PM +0100, Gerd Hoffmann wrote: > Pass the keyboard state tracker handle down to keysym2scancode(), > so the code can fully inspect the keyboard state as needed. No > functional change. > > Signed-off-by: Gerd Hoffmann > --- > ui/keymaps.h | 3 ++- > ui/curses.c

Re: [Qemu-devel] [RFC PATCH v2 7/7] keymap: fix keyup mappings

2018-12-21 Thread Daniel P . Berrangé
On Wed, Dec 19, 2018 at 01:09:04PM +0100, Gerd Hoffmann wrote: > It is possible that the modifier state on keyup is different from the > modifier state on keydown. In that case the keycode lookup can end up > with different keys in case multiple keysym -> keycode mappings exist, > because it picks

Re: [Qemu-devel] [PATCH 0/3] vfio-ccw: support hsch/csch (kernel part)

2018-12-21 Thread Cornelia Huck
On Wed, 19 Dec 2018 15:17:19 +0100 Halil Pasic wrote: > On Wed, 19 Dec 2018 12:54:42 +0100 > Cornelia Huck wrote: > > > On Fri, 7 Dec 2018 17:54:23 +0100 > > Halil Pasic wrote: > > > > > On Fri, 7 Dec 2018 11:05:29 +0100 > > > Cornelia Huck wrote: > > > > > > > > > I think most of the s

Re: [Qemu-devel] [QEMU-devel][PATCH v4 0/2] Fix concurrent aio_poll/set_fd_handler.

2018-12-21 Thread Paolo Bonzini
On 20/12/18 17:37, Stefan Hajnoczi wrote: > On Thu, Dec 20, 2018 at 04:20:28PM +0100, remy.n...@blade-group.com wrote: >> From: Remy Noel >> >> It is possible for an io_poll/read/write callback to be concurrently >> executed along >> with an aio_set_fd_handlers. This can cause all sorts of proble

Re: [Qemu-devel] did the qemu can emulate the whole system with the processor that without support the "virtulization and kvm"?

2018-12-21 Thread tugouxp
thank you. i just want to confirm one thing, that is whether the qemu can emulate a whole operation system just by analysis instructions by instructions manually without the support of KVM. so from the answer you give to me, it is feasible, right? thanks very much! At 2018-12-21 1

Re: [Qemu-devel] [PATCH v7 01/28] hw: apply accel compat properties without touching globals

2018-12-21 Thread Cornelia Huck
On Fri, 21 Dec 2018 13:03:43 +0400 Marc-André Lureau wrote: > Instead of registering compat properties as globals, let's keep them > in their own array, to avoid mixing with user globals. > > Introduce object_apply_global_props() function, to apply compatibility > properties from a GPtrArray. >

Re: [Qemu-devel] [PATCH v7 02/28] machines: replace COMPAT define with a static array

2018-12-21 Thread Cornelia Huck
On Fri, 21 Dec 2018 13:03:44 +0400 Marc-André Lureau wrote: > Signed-off-by: Marc-André Lureau > --- > include/hw/boards.h| 10 +- > hw/arm/virt.c | 45 +-- > hw/i386/pc_piix.c | 563 + > hw/i386/pc_q35.c | 66 -

[Qemu-devel] [PULL 23/35] test: replace gtester with a TAP driver

2018-12-21 Thread Paolo Bonzini
gtester is deprecated by upstream glib (see for example the announcement at https://blog.gtk.org/2018/07/11/news-from-glib-2-58/) and it does not support tests that call g_test_skip in some glib stable releases. glib suggests instead using Automake's TAP support, which gtest itself supports since

[Qemu-devel] [PULL 22/35] test: execute g_test_run when tests are skipped

2018-12-21 Thread Paolo Bonzini
Sometimes a test's main() function recognizes that the environment does not support the test, and therefore exits. In this case, we still should run g_test_run() so that a TAP harness will print the test plan ("1..0") and the test will be marked as skipped. Signed-off-by: Paolo Bonzini Message-I

Re: [Qemu-devel] [PATCH v7 03/28] hw: apply machine compat properties without touching globals

2018-12-21 Thread Cornelia Huck
On Fri, 21 Dec 2018 13:03:45 +0400 Marc-André Lureau wrote: > Similarly to accel properties, move compat properties out of globals > registration, and apply the machine compat properties during > device_post_init(). > > Signed-off-by: Marc-André Lureau > --- > include/hw/boards.h| 3 +

[Qemu-devel] [PULL v4 00/35] Misc patches for 2018-12-21

2018-12-21 Thread Paolo Bonzini
The following changes since commit e85c577158a2e8e252414959da9ef15c12eec63d: Merge remote-tracking branch 'remotes/huth-gitlab/tags/pull-request-2018-12-17' into staging (2018-12-18 14:31:06 +) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstream

Re: [Qemu-devel] [PATCH v6 09/11] iotests: change qmp_log filters to expect QMP objects only

2018-12-21 Thread Vladimir Sementsov-Ogievskiy
21.12.2018 12:35, John Snow wrote: > As laid out in the previous commit's message: > > ``` > Several places in iotests deal with serializing objects into JSON > strings, but to add pretty-printing it seems desirable to localize > all of those cases. > > log() seems like a good candidate for that

Re: [Qemu-devel] [PATCH 0/3] vfio-ccw: support hsch/csch (kernel part)

2018-12-21 Thread Halil Pasic
On Fri, 21 Dec 2018 12:23:32 +0100 Cornelia Huck wrote: [..] > > You've really lost me here :( I fear you're criticizing something I > don't want to implement; I'll write some code, that should make things > much easier to discuss. > Nod. > TBH, I have no idea how this will scale to many vfio

Re: [Qemu-devel] [PATCH v7 04/28] machine: move compat properties out of globals

2018-12-21 Thread Cornelia Huck
On Fri, 21 Dec 2018 13:03:46 +0400 Marc-André Lureau wrote: > Move the compat arrays inside functions that use them. > > Signed-off-by: Marc-André Lureau > --- > hw/arm/virt.c | 94 +++-- > hw/i386/pc_piix.c | 705 ++--- > hw/i386/pc_q35.c

[Qemu-devel] [PATCH] i386: mark the 'INTEL_PT' CPUID bit as unmigratable

2018-12-21 Thread Paolo Bonzini
Marshaling of processor tracing MSRs is not yet implemented in QEMU, mark the feature as unmigratable. Cc: qemu-sta...@nongnu.org Signed-off-by: Paolo Bonzini --- target/i386/cpu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target/i386/cpu.c b/target/i386/cpu.c index 9c54c41e7a..a6a597d

Re: [Qemu-devel] [PATCH v7 05/28] hw: remove SET_MACHINE_COMPAT

2018-12-21 Thread Cornelia Huck
On Fri, 21 Dec 2018 13:03:47 +0400 Marc-André Lureau wrote: > No longer needed. > > Signed-off-by: Marc-André Lureau > --- > include/hw/boards.h | 12 > 1 file changed, 12 deletions(-) Reviewed-by: Cornelia Huck

Re: [Qemu-devel] [PATCH v7 06/28] compat: replace PC_COMPAT_3_1 & HW_COMPAT_3_1 macros

2018-12-21 Thread Cornelia Huck
On Fri, 21 Dec 2018 13:03:48 +0400 Marc-André Lureau wrote: > Use static arrays instead. > > Suggested-by: Eduardo Habkost > Signed-off-by: Marc-André Lureau > --- > include/hw/boards.h| 3 +++ > include/hw/compat.h| 3 --- > include/hw/i386/pc.h | 4 ++-- > hw/arm/virt.

Re: [Qemu-devel] [PATCH v7 07/28] compat: replace PC_COMPAT_3_0 & HW_COMPAT_3_0 macros

2018-12-21 Thread Cornelia Huck
On Fri, 21 Dec 2018 13:03:49 +0400 Marc-André Lureau wrote: > Use static arrays instead. > > Suggested-by: Eduardo Habkost > Signed-off-by: Marc-André Lureau > --- > include/hw/boards.h| 3 +++ > include/hw/compat.h| 3 --- > include/hw/i386/pc.h | 17 ++---

Re: [Qemu-devel] [PATCH v7 08/28] compat: replace PC_COMPAT_2_12 & HW_COMPAT_2_12 macros

2018-12-21 Thread Cornelia Huck
On Fri, 21 Dec 2018 13:03:50 +0400 Marc-André Lureau wrote: > Use static arrays instead. > > Suggested-by: Eduardo Habkost > Signed-off-by: Marc-André Lureau > --- > include/hw/boards.h| 3 +++ > include/hw/compat.h| 27 --- > include/hw/i386/pc.h

Re: [Qemu-devel] [PATCH v7 09/28] compat: replace PC_COMPAT_2_11 & HW_COMPAT_2_11 macros

2018-12-21 Thread Cornelia Huck
On Fri, 21 Dec 2018 13:03:51 +0400 Marc-André Lureau wrote: > Use static arrays instead. > > Suggested-by: Eduardo Habkost > Signed-off-by: Marc-André Lureau > --- > include/hw/boards.h| 3 +++ > include/hw/compat.h| 19 --- > include/hw/i386/pc.h | 13 +

Re: [Qemu-devel] [PATCH v7 10/28] compat: replace PC_COMPAT_2_10 & HW_COMPAT_2_10 macros

2018-12-21 Thread Cornelia Huck
On Fri, 21 Dec 2018 13:03:52 +0400 Marc-André Lureau wrote: > Use static arrays instead. > > Suggested-by: Eduardo Habkost > Signed-off-by: Marc-André Lureau > --- > include/hw/boards.h| 3 +++ > include/hw/compat.h| 11 --- > include/hw/i386/pc.h | 17 ++---

Re: [Qemu-devel] [PATCH v7 11/28] compat: replace PC_COMPAT_2_9 & HW_COMPAT_2_9 macros

2018-12-21 Thread Cornelia Huck
On Fri, 21 Dec 2018 13:03:53 +0400 Marc-André Lureau wrote: > Use static arrays instead. > > Suggested-by: Eduardo Habkost > Signed-off-by: Marc-André Lureau > --- > include/hw/boards.h| 3 +++ > include/hw/compat.h| 19 --- > include/hw/i386/pc.h | 9 +

Re: [Qemu-devel] [PATCH v7 12/28] compat: replace PC_COMPAT_2_8 & HW_COMPAT_2_8 macros

2018-12-21 Thread Cornelia Huck
On Fri, 21 Dec 2018 13:03:54 +0400 Marc-André Lureau wrote: > Use static arrays instead. > > Suggested-by: Eduardo Habkost > Signed-off-by: Marc-André Lureau > --- > include/hw/boards.h| 3 +++ > include/hw/compat.h| 43 --- > include/hw/i386/p

Re: [Qemu-devel] [PATCH v7 13/28] compat: replace PC_COMPAT_2_7 & HW_COMPAT_2_7 macros

2018-12-21 Thread Cornelia Huck
On Fri, 21 Dec 2018 13:03:55 +0400 Marc-André Lureau wrote: > Use static arrays instead. > > Suggested-by: Eduardo Habkost > Signed-off-by: Marc-André Lureau > --- > include/hw/boards.h| 3 +++ > include/hw/compat.h| 23 --- > include/hw/i386/pc.h |

Re: [Qemu-devel] [PATCH v7 14/28] compat: replace PC_COMPAT_2_6 & HW_COMPAT_2_6 macros

2018-12-21 Thread Cornelia Huck
On Fri, 21 Dec 2018 13:03:56 +0400 Marc-André Lureau wrote: > Use static arrays instead. > > Suggested-by: Eduardo Habkost > Signed-off-by: Marc-André Lureau > --- > include/hw/boards.h| 3 +++ > include/hw/compat.h| 15 --- > include/hw/i386/pc.h | 23 ++---

Re: [Qemu-devel] [PATCH v7 15/28] compat: replace PC_COMPAT_2_5 & HW_COMPAT_2_5 macros

2018-12-21 Thread Cornelia Huck
On Fri, 21 Dec 2018 13:03:57 +0400 Marc-André Lureau wrote: > Use static arrays instead. > > Suggested-by: Eduardo Habkost > Signed-off-by: Marc-André Lureau > --- > include/hw/boards.h| 3 +++ > include/hw/compat.h| 24 > include/hw/i386/pc.h |

Re: [Qemu-devel] [PATCH v7 16/28] compat: replace PC_COMPAT_2_4 & HW_COMPAT_2_4 macros

2018-12-21 Thread Cornelia Huck
On Fri, 21 Dec 2018 13:03:58 +0400 Marc-André Lureau wrote: > Use static arrays instead. > > Suggested-by: Eduardo Habkost > Signed-off-by: Marc-André Lureau > --- > include/hw/boards.h| 3 ++ > include/hw/compat.h| 27 -- > include/hw/i386/pc.h | 74 ++-

Re: [Qemu-devel] [PATCH v7 17/28] compat: replace PC_COMPAT_2_3 & HW_COMPAT_2_3 macros

2018-12-21 Thread Cornelia Huck
On Fri, 21 Dec 2018 13:03:59 +0400 Marc-André Lureau wrote: > Use static arrays instead. I decided to rename the conflicting > pc_compat_2_3() function with pc_compat_2_3_fn(). > > Suggested-by: Eduardo Habkost > Signed-off-by: Marc-André Lureau > --- > include/hw/boards.h | 3 ++ > includ

Re: [Qemu-devel] [PATCH v7 18/28] compat: replace PC_COMPAT_2_2 & HW_COMPAT_2_2 macros

2018-12-21 Thread Cornelia Huck
On Fri, 21 Dec 2018 13:04:00 +0400 Marc-André Lureau wrote: > Use static arrays instead. I decided to rename the conflicting > pc_compat_2_2() function with pc_compat_2_2_fn(). > > Suggested-by: Eduardo Habkost > Signed-off-by: Marc-André Lureau > --- > include/hw/boards.h | 3 ++ > includ

Re: [Qemu-devel] [PATCH v7 19/28] compat: replace PC_COMPAT_2_1 & HW_COMPAT_2_1 macros

2018-12-21 Thread Cornelia Huck
On Fri, 21 Dec 2018 13:04:01 +0400 Marc-André Lureau wrote: > Use static arrays instead. I decided to rename the conflicting > pc_compat_2_1() function with pc_compat_2_1_fn(). > > Suggested-by: Eduardo Habkost > Signed-off-by: Marc-André Lureau > --- > include/hw/boards.h | 3 +++ > inclu

[Qemu-devel] [Bug 1809453] [NEW] Windows qemu download Big file bug in net user mode

2018-12-21 Thread zhaoby
Public bug reported: hi Windows qemu with -net user downloading big files has a bug, -net tap is good! I suspect that the Slirp protocol has a bug on the Windows pc, which is normal on ubuntu. ** Affects: qemu Importance: Undecided Status: New -- You received this bug notificati

Re: [Qemu-devel] [PATCH v7 20/28] include: remove compat.h

2018-12-21 Thread Cornelia Huck
On Fri, 21 Dec 2018 13:04:02 +0400 Marc-André Lureau wrote: > The header is now empty. > > Signed-off-by: Marc-André Lureau > --- > include/hw/compat.h| 4 > include/hw/i386/pc.h | 1 - > hw/arm/virt.c | 1 - > hw/ppc/spapr.c | 1 - > hw/s390x/s390-v

Re: [Qemu-devel] [PATCH v7 21/28] compat: remove remaining PC_COMPAT macros

2018-12-21 Thread Cornelia Huck
On Fri, 21 Dec 2018 13:04:03 +0400 Marc-André Lureau wrote: > Use static arrays instead. I decided to rename the conflicting > pc_compat_2_1() function with pc_compat_2_1_fn(). > > Suggested-by: Eduardo Habkost > Signed-off-by: Marc-André Lureau > --- > include/hw/i386/pc.h | 236 +++

[Qemu-devel] [PATCH] hw/usb: fix mistaken de-initialization of CCID state

2018-12-21 Thread Daniel P . Berrangé
In previous commit: commit 7dea29e4af17fc1d27478de9f8ea38144deac54a Author: Li Qiang Date: Fri Oct 19 03:50:36 2018 -0700 hw: ccid-card-emulated: cleanup resource when realize in error path The emulated_realize method was changed so that it jumps to a cleanup label to de-initialize

Re: [Qemu-devel] [PATCH v11 06/10] file-posix: reset fallocate-related flags without CONFIG_FALLOCATE*

2018-12-21 Thread Vladimir Sementsov-Ogievskiy
18.12.2018 10:57, Anton Nefedov wrote: > these flags currently affect nothing without CONFIG_FALLOCATE*, so it's > not a bug. Fixing it makes possible to adjust supported zero flag > BDRV_REQ_ALLOCATE regardless of configuration (in the following patch). > > Signed-off-by: Anton Nefedov I'd pref

Re: [Qemu-devel] [PATCH v8 00/23] Add support for RDMA MAD

2018-12-21 Thread Marcel Apfelbaum
On 12/17/18 8:45 PM, Yuval Shaia wrote: Hi all. Hi Yuval, The series does not apply on master anymore, can you please rebase it and send ii again? Thanks, Marcel This is a major enhancement to the pvrdma device to allow it to work with state of the art applications such as MPI. As descri

[Qemu-devel] [PATCH] dmg: fix binary search

2018-12-21 Thread yuchenlin
There is a possible hang in original binary searsh implemtation. That is if chunk1 = 4, chunk2 = 5, chunk3 = 4, and we go else case. The chunk1 will be still 4, and so on. Signed-off-by: yuchenlin --- block/dmg.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/block/dm

[Qemu-devel] [PATCH RFC] i386: Enable NPT and NRIPSAVE for Epyc CPUs

2018-12-21 Thread Vitaly Kuznetsov
Epyc CPUs support NPT and NRIPSAVE features and KVM exposes these when present. Add them to EPYC and EPYC-IBPB cpu models. Signed-off-by: Vitaly Kuznetsov --- - RFC part: I'm not sure when these features first appeared, we may want to modify some Opteron_* models too. --- target/i386/cpu.c | 4

Re: [Qemu-devel] did the qemu can emulate the whole system with the processor that without support the "virtulization and kvm"?

2018-12-21 Thread Li Zhijian
On 12/21/18 19:40, tugouxp wrote: thank you. i just want to confirm one thing, that is whether the qemu can emulate a whole operation system just by analysis instructions by instructions manually without the support of KVM. IIUC, "operation system" often means a software but QEMU usually

  1   2   3   >