On Wed, Dec 19, 2018 at 01:09:04PM +0100, Gerd Hoffmann wrote: > It is possible that the modifier state on keyup is different from the > modifier state on keydown. In that case the keycode lookup can end up > with different keys in case multiple keysym -> keycode mappings exist, > because it picks the mapping depending on modifier state. > > To fix that change the lookup logic for keyup events. Instead of > looking at the modifier state check the key state and prefer a keycodes > where the key is in "down" state right now. > > Fixes: abb4f2c965 keymap: consider modifier state when picking a mapping > Buglink: https://bugs.launchpad.net/bugs/1738283 > Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1658676 > Signed-off-by: Gerd Hoffmann <kra...@redhat.com> > --- > ui/keymaps.h | 2 +- > ui/curses.c | 2 +- > ui/keymaps.c | 55 ++++++++++++++++++++++++++++++++++--------------------- > ui/vnc.c | 2 +- > 4 files changed, 37 insertions(+), 24 deletions(-)
Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
