Re: [Qemu-devel] [PATCH 23/34] target/ppc: convert xxspltib to vector operations

2018-12-19 Thread David Gibson
On Mon, Dec 17, 2018 at 10:39:00PM -0800, Richard Henderson wrote: > Signed-off-by: Richard Henderson Acked-by: David Gibson > --- > target/ppc/translate/vsx-impl.inc.c | 12 +--- > 1 file changed, 5 insertions(+), 7 deletions(-) > > diff --git a/target/ppc/translate/vsx-impl.inc.c >

Re: [Qemu-devel] [PATCH 21/34] target/ppc: nand, nor, eqv are now generic vector operations

2018-12-19 Thread David Gibson
On Mon, Dec 17, 2018 at 10:38:58PM -0800, Richard Henderson wrote: > Signed-off-by: Richard Henderson Acked-by: David Gibson > --- > target/ppc/translate/vmx-impl.inc.c | 26 +++--- > 1 file changed, 3 insertions(+), 23 deletions(-) > > diff --git a/target/ppc/translate/vm

Re: [Qemu-devel] [PATCH 31/34] target/ppc: Add set_vscr_sat

2018-12-19 Thread David Gibson
On Mon, Dec 17, 2018 at 10:39:08PM -0800, Richard Henderson wrote: > This is required before changing the representation of the register. > > Signed-off-by: Richard Henderson Acked-by: David Gibson > --- > target/ppc/int_helper.c | 29 + > 1 file changed, 17 insert

Re: [Qemu-devel] [PATCH 20/34] target/ppc: convert vsplt[bhw] to use vector operations

2018-12-19 Thread David Gibson
On Mon, Dec 17, 2018 at 10:38:57PM -0800, Richard Henderson wrote: > Signed-off-by: Richard Henderson Acked-by: David Gibson > --- > target/ppc/helper.h | 3 -- > target/ppc/int_helper.c | 24 --- > target/ppc/translate/vmx-impl.inc.c | 45 +

Re: [Qemu-devel] [PATCH 29/34] target/ppc: Add helper_mfvscr

2018-12-19 Thread David Gibson
On Mon, Dec 17, 2018 at 10:39:06PM -0800, Richard Henderson wrote: > This is required before changing the representation of the register. > > Signed-off-by: Richard Henderson Acked-by: David Gibson > --- > target/ppc/helper.h | 1 + > target/ppc/arch_dump.c | 3 ++

Re: [Qemu-devel] [PATCH 32/34] target/ppc: Split out VSCR_SAT to a vector field

2018-12-19 Thread David Gibson
On Mon, Dec 17, 2018 at 10:39:09PM -0800, Richard Henderson wrote: > Change the representation of VSCR_SAT such that it is easy > to set from vector code. > > Signed-off-by: Richard Henderson Acked-by: David Gibson > --- > target/ppc/cpu.h| 4 +++- > target/ppc/int_helper.c | 11

Re: [Qemu-devel] [PATCH 11/34] target/ppc: introduce get_fpr() and set_fpr() helpers for FP register access

2018-12-19 Thread David Gibson
On Mon, Dec 17, 2018 at 10:38:48PM -0800, Richard Henderson wrote: > From: Mark Cave-Ayland > > These helpers allow us to move FP register values to/from the specified > TCGv_i64 > argument in the VSR helpers to be introduced shortly. > > To prevent FP helpers accessing the cpu_fpr array direct

Re: [Qemu-devel] [PATCH 34/34] target/ppc: convert vmin* and vmax* to vector operations

2018-12-19 Thread David Gibson
On Mon, Dec 17, 2018 at 10:39:11PM -0800, Richard Henderson wrote: > Signed-off-by: Richard Henderson Acked-by: David Gibson > --- > target/ppc/helper.h | 16 --- > target/ppc/int_helper.c | 27 > target/ppc/translate/vmx-impl.in

Re: [Qemu-devel] [PATCH 16/34] target/ppc: move FP and VMX registers into aligned vsr register array

2018-12-19 Thread David Gibson
On Mon, Dec 17, 2018 at 10:38:53PM -0800, Richard Henderson wrote: > From: Mark Cave-Ayland > > The VSX register array is a block of 64 128-bit registers where the first 32 > registers consist of the existing 64-bit FP registers extended to 128-bit > using new VSR registers, and the last 32 regis

Re: [Qemu-devel] [PATCH 30/34] target/ppc: Use mtvscr/mfvscr for vmstate

2018-12-19 Thread David Gibson
On Mon, Dec 17, 2018 at 10:39:07PM -0800, Richard Henderson wrote: > This is required before changing the representation of the register. > > Signed-off-by: Richard Henderson Acked-by: David Gibson > --- > target/ppc/machine.c | 44 +--- > 1 file change

Re: [Qemu-devel] [PATCH 33/34] target/ppc: convert vadd*s and vsub*s to vector operations

2018-12-19 Thread David Gibson
On Mon, Dec 17, 2018 at 10:39:10PM -0800, Richard Henderson wrote: > Signed-off-by: Richard Henderson Acked-by: David Gibson > --- > target/ppc/helper.h | 24 ++-- > target/ppc/int_helper.c | 18 ++--- > target/ppc/translate/vmx-impl.inc.c | 57 +

Re: [Qemu-devel] [PATCH for-3.2 01/11] vhost-user: define conventions for vhost-user backends

2018-12-19 Thread Marc-André Lureau
Hi On Wed, Dec 19, 2018 at 3:20 AM Michael S. Tsirkin wrote: > > On Tue, Dec 18, 2018 at 10:35:05PM +0400, Marc-André Lureau wrote: > > Hi > > > > On Tue, Dec 11, 2018 at 10:56 PM Michael S. Tsirkin wrote: > > > > > > On Tue, Dec 11, 2018 at 09:29:44AM +, Daniel P. Berrangé wrote: > > > > On

Re: [Qemu-devel] [Qemu-trivial] [PATCH 1/2] typedefs: (Re-)sort entries alphabetically

2018-12-19 Thread Laurent Vivier
On 15/11/2018 22:17, Eric Blake wrote: > Since the last time we sorted things (2988cbeaf), we've had a > few relapses that were inserted out of order. Also, we had more > entries that were sorted case-insensitively than not, so let's > document that convention and stick to it. > > Signed-off-by:

[Qemu-devel] how to get the "intermediate tcg" string output to debug qemu?

2018-12-19 Thread tugouxp
hi folks: i want to get the translated tcg operations printed on my test pattern, so is there any way to get this for convenient? thanks for your kindley help.

[Qemu-devel] how to get the "intermediate tcg" string output to debug qemu?

2018-12-19 Thread tugouxp
hi folks: i want to get the translated tcg operations printed on my test pattern, so is there any way to get this for convenient? thanks for your kindley help.

Re: [Qemu-devel] [RFC PATCH v2 13/15] Revert "qapi-events: add 'if' condition to implicit event enum"

2018-12-19 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > On Tue, Dec 18, 2018 at 10:27 PM Markus Armbruster wrote: >> >> This reverts commit 7bd263490590ee6fcf34ecb6203437e22f6e5a9c. >> >> The commit applied the events' conditions to the members of enum >> QAPIEvent. Awkward, because it renders QAPIEvent unusable in

[Qemu-devel] [PATCH] qga: Support for Windows Server 2019 in the get-osinfo command

2018-12-19 Thread Bishara AbuHattoum
This patch of a one commit fixes a bug that has been reported in the bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1659071 In which the command get-osinfo doesnt work as expected when the ga is running on a Windows Server 2019 guest. Bishara AbuHattoum (1): qga-win: Adding support for W

[Qemu-devel] [PATCH] qga-win: Adding support for Windows Server 2019 get-osinfo command

2018-12-19 Thread Bishara AbuHattoum
Since Windows Server 2016, Microsoft stopped upgrading the major and minor versions of their new Windows Server product, so, the current functionality of checking major and minor version numbers to determine the Windows Server version wont work as expected. The implemented solution here is to use t

Re: [Qemu-devel] [PATCH v2 for-4.0 6/7] vhost-user-blk: Add support to reconnect backend

2018-12-19 Thread Yongji Xie
On Tue, 18 Dec 2018 at 23:33, Yury Kotov wrote: > > > > 18.12.2018, 17:59, "Yongji Xie" : > > On Tue, 18 Dec 2018 at 22:35, Yury Kotov wrote: > >> 18.12.2018, 17:16, "Yongji Xie" : > >> > On Tue, 18 Dec 2018 at 20:30, Yury Kotov > >> wrote: > >> >> + wrfsh@ > >> >> > >> >> Hi, > >> >> > >

[Qemu-devel] [PATCH 0/4] q35: change defaults for kernel irqchip and IR

2018-12-19 Thread Peter Xu
This only changes q35. Nothing else. Before this series, we have these default parameters: - machine kernel-irqchip: on - intel-iommu IR: off This series wants to change these default variables into: - machine kernel-irqchip: split - intel-iommu IR: on and at the meantime we should ke

[Qemu-devel] [PATCH 3/4] x86-iommu: switch intr_supported to OnOffAuto type

2018-12-19 Thread Peter Xu
Switch the intr_supported variable from a boolean to OnOffAuto type so that we can know whether the user specified it or not. With that we'll have a chance to help the user to choose more wisely where possible. Introduce x86_iommu_ir_supported() to mask these changes. No functional change at all

[Qemu-devel] [PATCH 2/4] q35: set split kernel irqchip as default

2018-12-19 Thread Peter Xu
Starting from QEMU 4.0, let's specify "split" as the default value for kernel-irqchip. So for QEMU>=4.0 we'll have: allowed=Y,required=N,split=Y for QEMU<=3.1 we'll have: allowed=Y,required=N,split=N (omitting all the "kernel_irqchip_" prefix) Note that this "split" is optional - we'll firs

[Qemu-devel] [PATCH 1/4] kvm: let split be optional for kvm_arch_irqchip_create

2018-12-19 Thread Peter Xu
This patch allows the kvm_arch_irqchip_create() to return 0 if the split irqchip is specified but not forced by the user. Also, modify kvm_irqchip_create() similiarly. This patch should have no functional change for existing code since currently if split is specified it must be forced by the user

[Qemu-devel] [PATCH 4/4] x86-iommu: turn on IR by default if proper

2018-12-19 Thread Peter Xu
When the user didn't specify "intremap" for the IOMMU device, we turn it on by default if it is supported. This will turn IR on for the default Q35 platform as long as the IOMMU device is specified on new kernels. Signed-off-by: Peter Xu --- hw/i386/x86-iommu.c | 7 --- 1 file changed, 4 in

Re: [Qemu-devel] [RFC PATCH v2 00/15] qapi: add #if pre-processor conditions to generated code (part 3)

2018-12-19 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > On Tue, Dec 18, 2018 at 10:26 PM Markus Armbruster wrote: >> >> Marc-André posted v1 that relies on a QAPI schema language extension >> 'top-unit' to permit splitting the generated code. Here is his cover >> letter: >> >> The thrid and last part (of "[PATC

Re: [Qemu-devel] [PATCH v2 for-4.0 1/7] chardev: Add disconnected option for chardev socket

2018-12-19 Thread Yongji Xie
On Wed, 19 Dec 2018 at 00:09, Daniel P. Berrangé wrote: > > On Tue, Dec 18, 2018 at 11:02:46AM -0500, Michael S. Tsirkin wrote: > > On Tue, Dec 18, 2018 at 03:25:20PM +, Daniel P. Berrangé wrote: > > > On Tue, Dec 18, 2018 at 04:24:26PM +0400, Marc-André Lureau wrote: > > > > Hi > > > > > > >

Re: [Qemu-devel] [PATCH V7 6/6] hostmem-file: add 'sync' option

2018-12-19 Thread Yi Zhang
On 2018-12-18 at 09:18:50 -0500, Michael S. Tsirkin wrote: > On Tue, Dec 18, 2018 at 04:17:39PM +0800, Zhang Yi wrote: > > This option controls whether QEMU mmap(2) > > will mmap > > > the memory backend file with > > MAP_SYNC flag, which could consistent filesystem metadata > > I'm not sure wha

[Qemu-devel] [PATCH] ui/cocoa: Include less of the generated modular QAPI headers

2018-12-19 Thread Markus Armbruster
Avoids pointless recompilation. Missed in commit 112ed241f5d. Signed-off-by: Markus Armbruster --- Untested; I don't have access to a Mac. ui/cocoa.m | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ui/cocoa.m b/ui/cocoa.m index ecf12bfc2e..43e751693c 100644 --- a/ui/cocoa

Re: [Qemu-devel] [PATCH v3 3/5] hw/acpi: Use QEMU_NONSTRING for non NUL-terminated arrays

2018-12-19 Thread Igor Mammedov
On Tue, 18 Dec 2018 18:51:20 +0100 Philippe Mathieu-Daudé wrote: > GCC 8 added a -Wstringop-truncation warning: > > The -Wstringop-truncation warning added in GCC 8.0 via r254630 for > bug 81117 is specifically intended to highlight likely unintended > uses of the strncpy function that tru

Re: [Qemu-devel] [PATCH v3 3/5] hw/acpi: Use QEMU_NONSTRING for non NUL-terminated arrays

2018-12-19 Thread Philippe Mathieu-Daudé
Le mer. 19 déc. 2018 10:16, Igor Mammedov a écrit : > On Tue, 18 Dec 2018 18:51:20 +0100 > Philippe Mathieu-Daudé wrote: > > > GCC 8 added a -Wstringop-truncation warning: > > > > The -Wstringop-truncation warning added in GCC 8.0 via r254630 for > > bug 81117 is specifically intended to hig

Re: [Qemu-devel] [PATCH v3 2/5] block/sheepdog: Use QEMU_NONSTRING for non NUL-terminated arrays

2018-12-19 Thread Philippe Mathieu-Daudé
Le mer. 19 déc. 2018 00:09, Michael S. Tsirkin a écrit : > On Tue, Dec 18, 2018 at 06:51:19PM +0100, Philippe Mathieu-Daudé wrote: > > GCC 8 added a -Wstringop-truncation warning: > > > > The -Wstringop-truncation warning added in GCC 8.0 via r254630 for > > bug 81117 is specifically intended

Re: [Qemu-devel] [PATCH v3 5/5] migration: Use strnlen() for fixed-size string

2018-12-19 Thread Philippe Mathieu-Daudé
Le mer. 19 déc. 2018 00:16, Michael S. Tsirkin a écrit : > On Tue, Dec 18, 2018 at 06:51:22PM +0100, Philippe Mathieu-Daudé wrote: > > GCC 8 introduced the -Wstringop-overflow, which detect buffer overflow > > by string-modifying functions declared in , such strncpy(), > > used in global_state_st

Re: [Qemu-devel] [PATCH V7 3/6] util/mmap-alloc: support MAP_SYNC in qemu_ram_mmap()

2018-12-19 Thread Yi Zhang
On 2018-12-18 at 08:52:09 -0500, Michael S. Tsirkin wrote: > On Tue, Dec 18, 2018 at 04:17:12PM +0800, Zhang Yi wrote: > > When a file supporting DAX is used as vNVDIMM backend, mmap it with > > MAP_SYNC flag in addition can guarantee the persistence of guest write > > to the backend file without o

Re: [Qemu-devel] [PATCH for-4.0 v8 6/7] qemu_thread_create: propagate the error to callers to handle

2018-12-19 Thread Markus Armbruster
David Gibson writes: > On Thu, 13 Dec 2018 08:26:48 +0100 > Markus Armbruster wrote: > >> There's a question for David Gibson inline. Please search for /ppc/. >> >> Fei Li writes: >> >> > Make qemu_thread_create() return a Boolean to indicate if it succeeds >> > rather than failing with an e

[Qemu-devel] Can I have someone's feedback on [bug 1809075] Concurrency bug on keyboard events: capslock LED messing up keycode streams causes character misses at guest kernel

2018-12-19 Thread Gao Zhiyuan
Hi everyone. Can I please have someone's feedback on this bug? https://bugs.launchpad.net/qemu/+bug/1809075 Briefly, guest OS loses characters sent to it via vnc. And I spot the bug in relation to ps2 driver. I'm thinking of possible fixes and I might want to use a memory barrier. But I woul

Re: [Qemu-devel] [PATCH v3 5/5] keymap: consider modifier state when picking a mapping

2018-12-19 Thread Gerd Hoffmann
Hi, > > This is quite horrible though. I'm more inclined > > to revert this patch and find another way to fix the original problem > > which won't require the UI frontends to track modifier state. > > The UIs track modifier state anyway. > > I fact I have some WIP patches to add a generic key

Re: [Qemu-devel] [PATCH v4] s390x/pci: add common function measurement block

2018-12-19 Thread Cornelia Huck
On Tue, 18 Dec 2018 18:28:59 +0100 Pierre Morel wrote: > From: Yi Min Zhao > > Common function measurement block is used to report zPCI internal > counters of successful pcilg/stg/stb and rpcit instructions to > a memory location provided by the program. > > This patch introduces a new ZpciFmb

Re: [Qemu-devel] Monitor and serial output window broken with SDL2

2018-12-19 Thread Daniel P . Berrangé
On Tue, Dec 18, 2018 at 08:05:59PM +0100, BALATON Zoltan wrote: > On Tue, 18 Dec 2018, Daniel P. Berrangé wrote: > > I don't see any difference depending on whether I use Ctrl-Alt-3 before > > or after the yellow screen - both work as expected. The fact that you > > see a difference though does sug

Re: [Qemu-devel] [PATCH 10/10] display: add -display app launching external application

2018-12-19 Thread Gerd Hoffmann
On Wed, Dec 19, 2018 at 11:44:07AM +0400, Marc-André Lureau wrote: > On Wed, Dec 19, 2018 at 11:13 AM Gerd Hoffmann wrote: > > > > Hi, > > > > > > Also: remote-viewer accepts config files. I'd suggest to write one, so > > > > it is easy to restart remote-viewer. Also I would not use a temp di

Re: [Qemu-devel] [PATCH v2 10/12] MAINTAINERS: Orphanize the 'CPU (QOM)' subsystem

2018-12-19 Thread Daniel P . Berrangé
On Tue, Dec 18, 2018 at 10:22:39PM +0100, Paolo Bonzini wrote: > On 18/12/18 20:13, Eduardo Habkost wrote: > > On Tue, Dec 18, 2018 at 06:15:06PM +0100, Paolo Bonzini wrote: > >> On 18/12/18 16:57, Eduardo Habkost wrote: > >>> On Tue, Dec 18, 2018 at 04:44:25PM +0100, Thomas Huth wrote: > On 2

Re: [Qemu-devel] [PATCH v3 3/5] hw/acpi: Use QEMU_NONSTRING for non NUL-terminated arrays

2018-12-19 Thread Igor Mammedov
On Wed, 19 Dec 2018 10:20:36 +0100 Philippe Mathieu-Daudé wrote: > Le mer. 19 déc. 2018 10:16, Igor Mammedov a écrit : > > > On Tue, 18 Dec 2018 18:51:20 +0100 > > Philippe Mathieu-Daudé wrote: > > > > > GCC 8 added a -Wstringop-truncation warning: > > > > > > The -Wstringop-truncation war

Re: [Qemu-devel] [PATCH 1/3] ui: install logo icons to $prefix/share/icons

2018-12-19 Thread Daniel P . Berrangé
On Wed, Dec 19, 2018 at 08:20:23AM +0100, Gerd Hoffmann wrote: > On Tue, Dec 18, 2018 at 02:26:27PM +, Daniel P. Berrangé wrote: > > QEMU currently installs loogs to $prefix/share/qemu/ which means no GUI > > toolkit or applications can find them by default. > > > > The accepted standards for

Re: [Qemu-devel] Question about aio_poll and glib aio_ctx_dispatch

2018-12-19 Thread Li Qiang
Sent it to qemu-devel. Li Qiang 于2018年12月19日周三 下午6:04写道: > Hello Paolo, Stefan, Fam and all, > > Here I have a question about 'aio_poll'. > IIUC the 'aio_poll' is (mostly) used for synchronous IO > as I see a lot of code like this: > while(condition) > aio_poll(); > > However it seems the 'aio_

Re: [Qemu-devel] [PATCH for-4.0 v8 6/7] qemu_thread_create: propagate the error to callers to handle

2018-12-19 Thread Markus Armbruster
Fei Li writes: > On 12/13/2018 03:26 PM, Markus Armbruster wrote: >> There's a question for David Gibson inline. Please search for /ppc/. >> >> Fei Li writes: >> >>> Make qemu_thread_create() return a Boolean to indicate if it succeeds >>> rather than failing with an error. And add an Error par

Re: [Qemu-devel] [PATCH v3 3/5] hw/acpi: Use QEMU_NONSTRING for non NUL-terminated arrays

2018-12-19 Thread Andrew Jones
On Tue, Dec 18, 2018 at 06:51:20PM +0100, Philippe Mathieu-Daudé wrote: > GCC 8 added a -Wstringop-truncation warning: > > The -Wstringop-truncation warning added in GCC 8.0 via r254630 for > bug 81117 is specifically intended to highlight likely unintended > uses of the strncpy function tha

Re: [Qemu-devel] [PATCH for-4.0 v8 6/7] qemu_thread_create: propagate the error to callers to handle

2018-12-19 Thread Markus Armbruster
Fei Li writes: > On 12/17/2018 03:29 PM, Fei Li wrote: >> >> >> On 12/13/2018 03:26 PM, Markus Armbruster wrote: >>> There's a question for David Gibson inline.  Please search for /ppc/. >>> >>> Fei Li writes: >>> Make qemu_thread_create() return a Boolean to indicate if it succeeds ra

Re: [Qemu-devel] [PATCH 1/3] ui: install logo icons to $prefix/share/icons

2018-12-19 Thread Gerd Hoffmann
Hi, > > How did you create the png files? > > Can you drop a script or Makefile for that into the ui/icons directory? > > I used GIMP so that it created high quality antialiased pngs. Ok, so that'll be hardly scriptable. A short README will do then I guess. > > Should we commit them to git, o

Re: [Qemu-devel] [PATCH v4 1/5] iotests: add qmp recursive sorting function

2018-12-19 Thread Vladimir Sementsov-Ogievskiy
19.12.2018 4:52, John Snow wrote: > Python before 3.6 does not sort kwargs by default. > If we want to print out pretty-printed QMP objects while > preserving the "exec" > "arguments" ordering, we need a custom sort. > > We can accomplish this by sorting **kwargs into an OrderedDict, > which does

Re: [Qemu-devel] [PATCH 1/3] ui: install logo icons to $prefix/share/icons

2018-12-19 Thread Daniel P . Berrangé
On Wed, Dec 19, 2018 at 11:19:57AM +0100, Gerd Hoffmann wrote: > Hi, > > > > How did you create the png files? > > > Can you drop a script or Makefile for that into the ui/icons directory? > > > > I used GIMP so that it created high quality antialiased pngs. > > Ok, so that'll be hardly script

Re: [Qemu-devel] [PATCH v3 1/2] intel-iommu: differentiate host address width from IOVA address width.

2018-12-19 Thread Igor Mammedov
On Wed, 19 Dec 2018 10:57:17 +0800 Yu Zhang wrote: > On Tue, Dec 18, 2018 at 03:55:36PM +0100, Igor Mammedov wrote: > > On Tue, 18 Dec 2018 17:27:23 +0800 > > Yu Zhang wrote: > > > > > On Mon, Dec 17, 2018 at 02:17:40PM +0100, Igor Mammedov wrote: > > > > On Wed, 12 Dec 2018 21:05:38 +0800

Re: [Qemu-devel] [PATCH v4 2/5] iotests: remove default filters from qmp_log

2018-12-19 Thread Vladimir Sementsov-Ogievskiy
19.12.2018 4:52, John Snow wrote: > Only test 206 uses it, so remove it. s-o-b Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

Re: [Qemu-devel] [PATCH v4 3/5] iotests: change qmp_log filters to expect QMP objects only

2018-12-19 Thread Vladimir Sementsov-Ogievskiy
19.12.2018 4:52, John Snow wrote: > log() treats filters as if they can always filter its primary argument. > qmp_log treats filters as if they're always text. > > Change qmp_log to treat filters as if they're always qmp object filters, > then change the logging call to rely on log()'s ability to

Re: [Qemu-devel] [PATCH v3 5/5] keymap: consider modifier state when picking a mapping

2018-12-19 Thread Daniel P . Berrangé
On Wed, Dec 19, 2018 at 10:42:14AM +0100, Gerd Hoffmann wrote: > Hi, > > > > This is quite horrible though. I'm more inclined > > > to revert this patch and find another way to fix the original problem > > > which won't require the UI frontends to track modifier state. > > > > The UIs track mo

Re: [Qemu-devel] [PATCH v4 3/5] iotests: change qmp_log filters to expect QMP objects only

2018-12-19 Thread Vladimir Sementsov-Ogievskiy
19.12.2018 14:07, Vladimir Sementsov-Ogievskiy wrote: > 19.12.2018 4:52, John Snow wrote: >> log() treats filters as if they can always filter its primary argument. >> qmp_log treats filters as if they're always text. >> >> Change qmp_log to treat filters as if they're always qmp object filters, >>

[Qemu-devel] [Bug 1738283] Re: 'Less than' (<), 'more than' (>), and 'pipe' (|) can't be typed via VNC

2018-12-19 Thread Daniel Berrange
Discussing the problem & likely solution here: https://lists.gnu.org/archive/html/qemu-devel/2018-12/msg04631.html -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1738283 Title: 'Less than' (<), '

[Qemu-devel] QEMU crashed when reconnecting over iscsi protocol

2018-12-19 Thread Bob Chen
I looked into the source code, and found some reconnect method from libiscsi. Are they able to work? QEMU: 2.12.1 libiscsi: 1.18.0 (https://github.com/sahlberg/libiscsi) (gdb) f #0 0x7fcd956933bd in iscsi_reconnect (iscsi=0x7fcd97f206d0) at connect.c:461 461 memcpy(tmp_iscsi->old_iscsi, is

Re: [Qemu-devel] [PATCH v2 2/3] nbd/client: Trace all server option error messages

2018-12-19 Thread Vladimir Sementsov-Ogievskiy
19.12.2018 1:57, Eric Blake wrote: > Not all servers send free-form text alongside option error replies, but > for servers that do (such as qemu), we pass the server's message as a > hint alongside our own error reporting. However, it would also be > useful to trace such server messages, since we

Re: [Qemu-devel] [PATCH 0/3] vfio-ccw: support hsch/csch (kernel part)

2018-12-19 Thread Cornelia Huck
On Fri, 7 Dec 2018 17:54:23 +0100 Halil Pasic wrote: > On Fri, 7 Dec 2018 11:05:29 +0100 > Cornelia Huck wrote: > > > > > I think most of the sorting-out-the-operations stuff should be done by > > > > the hardware itself, and we should not really try to enforce anything > > > > special in our v

Re: [Qemu-devel] [QEMU PATCH] block: Remove blk_attach_dev_legacy() / legacy_dev code

2018-12-19 Thread Thomas Huth
On 2018-12-18 19:33, Markus Armbruster wrote: > Thomas Huth writes: > >> The last user of blk_attach_dev_legacy() is the code in xen_disk.c. >> It passes a pointer to a XenBlkDev as second parameter. XenBlkDev >> is derived from XenDevice which in turn is derived from DeviceState >> since commit

Re: [Qemu-devel] [PATCH v2 0/3] nbd-client: drop extra error noise

2018-12-19 Thread Vladimir Sementsov-Ogievskiy
19.12.2018 1:57, Eric Blake wrote: > This is a counter-proposal to Vladimir's initial post for > reducing the noise in iotest 083. The difference is that > I dropped error_get_hint, since I couldn't find any useful > hint to be traced during transmission phase in the first place, > and instead add

Re: [Qemu-devel] QEMU crashed when reconnecting over iscsi protocol

2018-12-19 Thread Bob Chen
BTW, the iscsi server I used is scsi-target-utils ( https://github.com/fujita/tgt). Bob Chen 于2018年12月19日周三 下午7:34写道: > I looked into the source code, and found some reconnect method from > libiscsi. Are they able to work? > > QEMU: 2.12.1 > libiscsi: 1.18.0 (https://github.com/sahlberg/libisc

[Qemu-devel] [RFC PATCH v2 3/7] sdl2: use only QKeyCode in sdl2_process_key()

2018-12-19 Thread Gerd Hoffmann
Small cleanup. Also drop the special backspace handling, kbd_put_qcode_console() learned to handle that meanwhile. And sdl2_process_key is never called with scon == NULL. Signed-off-by: Gerd Hoffmann --- ui/sdl2-input.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/

[Qemu-devel] [RFC PATCH v2 2/7] kbd-state: use state tracker for sdl2

2018-12-19 Thread Gerd Hoffmann
Use the new keyboard state tracked for sdl2. We can drop the modifier state tracking from sdl2. Also keyup code is simpler, the state tracker will take care to not send suspious keyup events to the guest. Signed-off-by: Gerd Hoffmann --- include/ui/sdl2.h | 2 ++ ui/sdl2-input.c | 40 +++---

[Qemu-devel] [RFC PATCH v2 1/7] kbd-state: add keyboard state tracker

2018-12-19 Thread Gerd Hoffmann
Now that most user interfaces are using QKeyCodes it is easier to have common keyboard code useable by all user interfaces. This patch adds helper code to track the state of all keyboard keys, using a bitmap indexed by QKeyCode. Modifier state is tracked too, as separate bitmap. That makes check

[Qemu-devel] [RFC PATCH v2 0/7] ui: add generic keyboard state tracker, fix keymap

2018-12-19 Thread Gerd Hoffmann
Gerd Hoffmann (7): kbd-state: add keyboard state tracker kbd-state: use state tracker for sdl2 sdl2: use only QKeyCode in sdl2_process_key() kbd-state: use state tracker for gtk kbd-state: use state tracker for vnc keymap: pass full keyboard state to keysym2scancode keymap: fix key

[Qemu-devel] [RFC PATCH v2 4/7] kbd-state: use state tracker for gtk

2018-12-19 Thread Gerd Hoffmann
Use the new keyboard state tracked for gtk. Allows to drop the gtk-specific modifier state tracking code. Signed-off-by: Gerd Hoffmann --- include/ui/gtk.h | 2 ++ ui/gtk.c | 38 ++ 2 files changed, 8 insertions(+), 32 deletions(-) diff --git a/incl

[Qemu-devel] [RFC PATCH v2 6/7] keymap: pass full keyboard state to keysym2scancode

2018-12-19 Thread Gerd Hoffmann
Pass the keyboard state tracker handle down to keysym2scancode(), so the code can fully inspect the keyboard state as needed. No functional change. Signed-off-by: Gerd Hoffmann --- ui/keymaps.h | 3 ++- ui/curses.c | 2 +- ui/keymaps.c | 8 ui/vnc.c | 5 + 4 files changed, 8 i

[Qemu-devel] [RFC PATCH v2 5/7] kbd-state: use state tracker for vnc

2018-12-19 Thread Gerd Hoffmann
Use the new keyboard state tracked for vnc. Allows to drop the vnc-specific modifier state tracking code. Signed-off-by: Gerd Hoffmann --- ui/vnc.h | 5 ++- ui/vnc.c | 120 ++- 2 files changed, 35 insertions(+), 90 deletions(-) diff

Re: [Qemu-devel] how to get the "intermediate tcg" string output to debug qemu?

2018-12-19 Thread Alex Bennée
tugouxp <13824125...@163.com> writes: > hi folks: > i want to get the translated tcg operations printed on my test > pattern, so is there any way to get this for convenient? $QEMU -d help You can use something like $QEMU -d in_asm,op,op_opt,out_asm If you want lots of output. > > > than

[Qemu-devel] [RFC PATCH v2 7/7] keymap: fix keyup mappings

2018-12-19 Thread Gerd Hoffmann
It is possible that the modifier state on keyup is different from the modifier state on keydown. In that case the keycode lookup can end up with different keys in case multiple keysym -> keycode mappings exist, because it picks the mapping depending on modifier state. To fix that change the looku

Re: [Qemu-devel] [PATCH for-4.0 v8 6/7] qemu_thread_create: propagate the error to callers to handle

2018-12-19 Thread Fei Li
On 12/19/2018 06:10 PM, Markus Armbruster wrote: Fei Li writes: On 12/13/2018 03:26 PM, Markus Armbruster wrote: There's a question for David Gibson inline. Please search for /ppc/. Fei Li writes: Make qemu_thread_create() return a Boolean to indicate if it succeeds rather than failin

Re: [Qemu-devel] [PATCH] hw/sparc64: Create VGA device only if it has really been requested

2018-12-19 Thread Mark Cave-Ayland
On 18/12/2018 20:26, Thomas Huth wrote: > Am Mon, 17 Dec 2018 12:48:31 +0100 (CET) > schrieb BALATON Zoltan : > >> On Sun, 16 Dec 2018, Thomas Huth wrote: >>> The sun4u/sun4v machine currently always creates a VGA device, even >>> if the user started QEMU with "-nodefaults" or "-vga none". That's

Re: [Qemu-devel] [PATCH v4] s390x/pci: add common function measurement block

2018-12-19 Thread Pierre Morel
On 19/12/2018 10:48, Cornelia Huck wrote: On Tue, 18 Dec 2018 18:28:59 +0100 Pierre Morel wrote: From: Yi Min Zhao Common function measurement block is used to report zPCI internal counters of successful pcilg/stg/stb and rpcit instructions to a memory location provided by the program. This

Re: [Qemu-devel] [PATCH 11/34] target/ppc: introduce get_fpr() and set_fpr() helpers for FP register access

2018-12-19 Thread Mark Cave-Ayland
On 19/12/2018 06:15, David Gibson wrote: > On Mon, Dec 17, 2018 at 10:38:48PM -0800, Richard Henderson wrote: >> From: Mark Cave-Ayland >> >> These helpers allow us to move FP register values to/from the specified >> TCGv_i64 >> argument in the VSR helpers to be introduced shortly. >> >> To prev

Re: [Qemu-devel] [PATCH 10/10] display: add -display app launching external application

2018-12-19 Thread Marc-André Lureau
Hi On Wed, Dec 19, 2018 at 1:54 PM Gerd Hoffmann wrote: > > On Wed, Dec 19, 2018 at 11:44:07AM +0400, Marc-André Lureau wrote: > > On Wed, Dec 19, 2018 at 11:13 AM Gerd Hoffmann wrote: > > > > > > Hi, > > > > > > > > Also: remote-viewer accepts config files. I'd suggest to write one, > > >

Re: [Qemu-devel] [PATCH v6 16/18] xen: automatically create XenBlockDevice-s

2018-12-19 Thread Anthony PERARD
On Mon, Dec 17, 2018 at 01:30:09PM +, Paul Durrant wrote: > +static char *xen_block_blockdev_add(const char *id, QDict *qdict, > +Error **errp) > +{ > +const char *driver = qdict_get_try_str(qdict, "driver"); > +BlockdevOptions *options = NULL; > +

Re: [Qemu-devel] [PATCH v6 15/18] xen: add a mechanism to automatically create XenDevice-s...

2018-12-19 Thread Anthony PERARD
On Mon, Dec 17, 2018 at 01:30:08PM +, Paul Durrant wrote: > ...that maintains compatibility with existing Xen toolstacks. > > Xen toolstacks instantiate PV backends by simply writing information into > xenstore and expecting a backend implementation to be watching for this. > > This patch add

Re: [Qemu-devel] [PATCH v8 10/20] replay: introduce info hmp/qmp command

2018-12-19 Thread Markus Armbruster
Pavel Dovgalyuk writes: > This patch introduces 'info replay' monitor command and > corresponding qmp request. > These commands request the current record/replay mode, replay log file name, > and the execution step (number or recorded/replayed instructions). > User may use step number for replay_

Re: [Qemu-devel] [PATCH v3 3/5] hw/acpi: Use QEMU_NONSTRING for non NUL-terminated arrays

2018-12-19 Thread Philippe Mathieu-Daudé
Hi Drew, On 12/19/18 11:10 AM, Andrew Jones wrote: > On Tue, Dec 18, 2018 at 06:51:20PM +0100, Philippe Mathieu-Daudé wrote: >> GCC 8 added a -Wstringop-truncation warning: >> >> The -Wstringop-truncation warning added in GCC 8.0 via r254630 for >> bug 81117 is specifically intended to highlig

Re: [Qemu-devel] [PATCH v6 16/18] xen: automatically create XenBlockDevice-s

2018-12-19 Thread Paul Durrant
> -Original Message- > From: Anthony PERARD [mailto:anthony.per...@citrix.com] > Sent: 19 December 2018 12:39 > To: Paul Durrant > Cc: qemu-devel@nongnu.org; qemu-bl...@nongnu.org; xen- > de...@lists.xenproject.org; Kevin Wolf ; Max Reitz > ; Stefano Stabellini > Subject: Re: [PATCH v6 16

Re: [Qemu-devel] [PATCH v8 08/20] migration: introduce icount field for snapshots

2018-12-19 Thread Markus Armbruster
Pavel Dovgalyuk writes: > Saving icount as a parameters of the snapshot allows navigation between > them in the execution replay scenario. > This information can be used for finding a specific snapshot for rewinding > the recorded execution to the specific moment of the time. > E.g., 'reverse ste

Re: [Qemu-devel] [PATCH 10/10] display: add -display app launching external application

2018-12-19 Thread Gerd Hoffmann
> > > > Everything needed, so launching remote-viewer is > > > > just "remote-viewer /path/to/config.vv". > > > > > > If it's just what is needed to launch the viewer, why not stick to the > > > url syntax? > > > > First, the info needed to launch is located on a fixed & well known > > place on dis

[Qemu-devel] [PATCH v5] s390x/pci: add common fmb

2018-12-19 Thread Pierre Morel
After the last review round I corrected the commit message and use the sizeof of the target entries in the fmb_di_update() function. Regards, Pierre Yi Min Zhao (1): s390x/pci: add common function measurement block hw/s390x/s390-pci-bus.c | 4 +- hw/s390x/s390-pci-bus.h | 29 +++

[Qemu-devel] [PATCH v5] s390x/pci: add common function measurement block

2018-12-19 Thread Pierre Morel
From: Yi Min Zhao Common function measurement block is used to report zPCI internal counters of successful pcilg/stg/stb and rpcit instructions to a memory location provided by the program. This patch introduces a new ZpciFmb structure and schedules a timer callback to copy the zPCI measures to

Re: [Qemu-devel] [PATCH v3 3/5] hw/acpi: Use QEMU_NONSTRING for non NUL-terminated arrays

2018-12-19 Thread Andrew Jones
On Wed, Dec 19, 2018 at 01:43:40PM +0100, Philippe Mathieu-Daudé wrote: > Hi Drew, > > On 12/19/18 11:10 AM, Andrew Jones wrote: > > On Tue, Dec 18, 2018 at 06:51:20PM +0100, Philippe Mathieu-Daudé wrote: > >> GCC 8 added a -Wstringop-truncation warning: > >> > >> The -Wstringop-truncation warni

Re: [Qemu-devel] [PATCH v8 11/20] replay: introduce breakpoint at the specified step

2018-12-19 Thread Markus Armbruster
Pavel Dovgalyuk writes: > This patch introduces replay_break, replay_delete_break > qmp and hmp commands. > These commands allow stopping at the specified instruction. > It may be useful for debugging when there are some known > events that should be investigated. > replay_break command has one a

Re: [Qemu-devel] [PATCH v8 12/20] replay: implement replay-seek command to proceed to the desired step

2018-12-19 Thread Markus Armbruster
Pavel Dovgalyuk writes: > This patch adds hmp/qmp commands replay_seek/replay-seek that proceed > the execution to the specified step. > The commands automatically loads nearest snapshot and replay the execution > to find the desired step. > > Signed-off-by: Pavel Dovgalyuk [...] > diff --git a/

Re: [Qemu-devel] [PATCH v2 09/22] nbd/client: Refactor nbd_receive_list()

2018-12-19 Thread Vladimir Sementsov-Ogievskiy
15.12.2018 16:53, Eric Blake wrote: > Right now, nbd_receive_list() is only called by > nbd_receive_query_exports(), which in turn is only called if the > server lacks NBD_OPT_GO but has working option negotiation, and is > merely used as a quality-of-implementation trick since servers > can't give

[Qemu-devel] [PATCH v2] hw/misc/ivshmem: Remove deprecated "ivshmem" legacy device

2018-12-19 Thread Thomas Huth
It's been marked as deprecated in QEMU v2.6.0 already, so really nobody should use the legacy "ivshmem" device anymore (but use ivshmem-plain or ivshmem-doorbell instead). Time to remove the deprecated device now. Belatedly also update a mention of the deprecated "ivshmem" in the file docs/specs/i

Re: [Qemu-devel] Booting Raspbian on RPi emulation

2018-12-19 Thread Peter Maydell
On Tue, 18 Dec 2018 at 21:57, Ben Hekster via Qemu-devel wrote: > Did it for me using stock QEMU 3.1.0. (I need "-nographic" > because the OS X port crashes without it) OSX works for me, though I don't test it thoroughly. If you are getting a crash that you can reproduce, please could you repro

[Qemu-devel] [PATCH 0/2] Revert exposure of PCONFIG to guest

2018-12-19 Thread Robert Hoo
PCONFIG is not supposed to be exposed to guest. These 2 patches fix this. Robert Hoo (2): i386: remove the new CPUID 'PCONFIG' from Icelake-Server CPU model Revert "i386: Add CPUID bit for PCONFIG" target/i386/cpu.c | 5 ++--- target/i386/cpu.h | 1 - 2 files changed, 2 insertions(+), 4 dele

[Qemu-devel] [PATCH 1/2] i386: remove the new CPUID 'PCONFIG' from Icelake-Server CPU model

2018-12-19 Thread Robert Hoo
Signed-off-by: Robert Hoo --- target/i386/cpu.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/target/i386/cpu.c b/target/i386/cpu.c index 677a3bd..b6113d0 100644 --- a/target/i386/cpu.c +++ b/target/i386/cpu.c @@ -2613,8 +2613,7 @@ static X86CPUDefinition builtin_x86_defs[

[Qemu-devel] [PATCH 2/2] Revert "i386: Add CPUID bit for PCONFIG"

2018-12-19 Thread Robert Hoo
This reverts commit 5131dc433df54b37e8e918d8fba7fe10344e7a7b. For new instruction 'PCONFIG' will not be exposed to guest. Signed-off-by: Robert Hoo --- target/i386/cpu.c | 2 +- target/i386/cpu.h | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/target/i386/cpu.c b/target/i386

Re: [Qemu-devel] [PATCH v6 16/18] xen: automatically create XenBlockDevice-s

2018-12-19 Thread Anthony PERARD
On Wed, Dec 19, 2018 at 12:43:24PM +, Paul Durrant wrote: > > Kevin seems to say that this could be done without the _flat_confused > > version. The flat_confused version seems to be useful just because > > the key "cache.direct" is used earlier, and because everything in qdict > > is a string.

Re: [Qemu-devel] [PATCH 1/2] i386: remove the new CPUID 'PCONFIG' from Icelake-Server CPU model

2018-12-19 Thread Daniel P . Berrangé
On Wed, Dec 19, 2018 at 09:44:40PM +0800, Robert Hoo wrote: > Signed-off-by: Robert Hoo > --- > target/i386/cpu.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/target/i386/cpu.c b/target/i386/cpu.c > index 677a3bd..b6113d0 100644 > --- a/target/i386/cpu.c > +++ b/tar

Re: [Qemu-devel] [PATCH v6 16/18] xen: automatically create XenBlockDevice-s

2018-12-19 Thread Paul Durrant
> -Original Message- > From: Anthony PERARD [mailto:anthony.per...@citrix.com] > Sent: 19 December 2018 14:01 > To: Paul Durrant > Cc: qemu-devel@nongnu.org; qemu-bl...@nongnu.org; xen- > de...@lists.xenproject.org; Kevin Wolf ; Max Reitz > ; Stefano Stabellini > Subject: Re: [PATCH v6 16

Re: [Qemu-devel] [PATCH for-4.0 v8 3/7] migration: fix the multifd code when receiving less channels

2018-12-19 Thread Markus Armbruster
Fei Li writes: > On 12/13/2018 02:17 PM, Markus Armbruster wrote: >> Fei Li writes: >> >>> In our current code, when multifd is used during migration, if there >>> is an error before the destination receives all new channels, the >>> source keeps running, however the destination does not exit bu

Re: [Qemu-devel] [PATCH 0/3] vfio-ccw: support hsch/csch (kernel part)

2018-12-19 Thread Halil Pasic
On Wed, 19 Dec 2018 12:54:42 +0100 Cornelia Huck wrote: > On Fri, 7 Dec 2018 17:54:23 +0100 > Halil Pasic wrote: > > > On Fri, 7 Dec 2018 11:05:29 +0100 > > Cornelia Huck wrote: > > > > > > > I think most of the sorting-out-the-operations stuff should be done by > > > > > the hardware itself,

Re: [Qemu-devel] [PATCH v5] s390x/pci: add common function measurement block

2018-12-19 Thread Cornelia Huck
On Wed, 19 Dec 2018 13:57:05 +0100 Pierre Morel wrote: > From: Yi Min Zhao > > Common function measurement block is used to report zPCI internal > counters of successful pcilg/stg/stb and rpcit instructions to > a memory location provided by the program. > > This patch introduces a new ZpciFmb

Re: [Qemu-devel] [PULL 00/35] Misc patches for 2018-12-18

2018-12-19 Thread Peter Maydell
On Mon, 17 Dec 2018 at 23:23, Paolo Bonzini wrote: > > The following changes since commit 0f98c9945899c5dfacd5a410ff04178eda605a16: > > Merge remote-tracking branch > 'remotes/huth-gitlab/tags/pull-request-2018-12-12' into staging (2018-12-14 > 10:19:47 +) > > are available in the Git repo

  1   2   3   4   >