Re: [Qemu-devel] [PATCH v5 04/36] ppc/xive: introduce the XiveRouter model

On 11/22/18 7:50 AM, Benjamin Herrenschmidt wrote: > On Thu, 2018-11-22 at 15:44 +1100, David Gibson wrote: >> >> Sorry, didn't think of this in my first reply. >> >> 1) Does the hardware ever actually write back to the EAS? I know it >> does for the END, but it's not clear why it would need to fo

Re: [Qemu-devel] [PATCH] checkpatch: g_test_message does not need a a trailing newline

On 2018-11-21 19:38, Philippe Mathieu-Daudé wrote: > > > On 21/11/18 19:27, Paolo Bonzini wrote: >> Signed-off-by: Paolo Bonzini >> --- >>   scripts/checkpatch.pl | 3 ++- >>   1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl >> index

Re: [Qemu-devel] [PATCH 3/5] Add migration functions for VFIO devices

> -Original Message- > From: Qemu-devel [mailto:qemu-devel- > bounces+yan.y.zhao=intel@nongnu.org] On Behalf Of Kirti Wankhede > Sent: Wednesday, November 21, 2018 4:40 AM > To: alex.william...@redhat.com; c...@nvidia.com > Cc: zhengxiao...@alibaba-inc.com; Tian, Kevin ; Liu, Yi > L

Re: [Qemu-devel] [PATCH for-3.2] RISC-V: Deprecate hifive_e and hifive_u machines

Hi, On 2018-11-22 00:31, Palmer Dabbelt wrote: > These machines had names that were too general: there are many E > and U machines, and it's easy for users to get confused about which one > is which. The one configuration that can faithfully match an existing > ASIC-based board has been renamed

Re: [Qemu-devel] [PATCH 2/2] contrib/elf2dmp: elf2dmp for Windows hosts

On Wed, Nov 21, 2018 at 10:54:15AM -0600, Eric Blake wrote: > On 11/21/18 4:25 AM, Roman Kagan wrote: > > On Fri, Nov 02, 2018 at 03:28:18AM +0300, Viktor Prutyanov wrote: > > > After this patch elf2dmp can be built by mingw64 for Windows hosts. > > > > What prevents building it with mingw32? (I

Re: [Qemu-devel] 答复: Can't see mouse cursor on VNC viewer

Hi Gerd, One more question: do you know any VNC client which supports rich cursor extension? We'd like to try such client to see the real effect. Thanks, Heyi On 2018/11/21 16:23, Gerd Hoffmann wrote: Hi, and can’t see cursor either with “virtio-gpu”. Does that mean virtio-gpu + VNC mu

Re: [Qemu-devel] [PATCH for-3.1 1/2] MAINTAINERS: Any file with "riscv" in the name is a RISC-V file

On 2018-11-22 02:44, Palmer Dabbelt wrote: > On Wed, 21 Nov 2018 16:29:09 PST (-0800), phi...@redhat.com wrote: >> On 22/11/18 0:46, Palmer Dabbelt wrote: >>> There was a recent thread about unmaintained files in QEMU where it was >>> noted that a few RISC-V related files had slipped through the pa

Re: [Qemu-devel] [RFC v8 15/18] hw/arm/virt: Add virtio-iommu to the virt board

Hi Bharat, On 11/22/18 10:15 AM, Bharat Bhushan wrote: > Hi Eric, > > >> -Original Message- >> From: Eric Auger >> Sent: Friday, November 9, 2018 5:00 PM >> To: eric.auger@gmail.com; eric.au...@redhat.com; qemu- >> de...@nongnu.org; qemu-...@nongnu.org; peter.mayd...@linaro.org; >>

Re: [Qemu-devel] [PATCH v2 for-3.2 v2 00/30] slirp: make it again a standalone project

> There has been some attempts to make slirp a seperate project in the past. > (https://lists.gnu.org/archive/html/qemu-devel/2017-02/msg01092.html) > Unfortunately, they forked from QEMU and didn't provide enough > compatibility for QEMU to make use of it (in particular, vmstate > handling was rem

Re: [Qemu-devel] [RFC v8 15/18] hw/arm/virt: Add virtio-iommu to the virt board

Hi Eric, > -Original Message- > From: Eric Auger > Sent: Friday, November 9, 2018 5:00 PM > To: eric.auger@gmail.com; eric.au...@redhat.com; qemu- > de...@nongnu.org; qemu-...@nongnu.org; peter.mayd...@linaro.org; > m...@redhat.com; jean-philippe.bruc...@arm.com > Cc: kevin.t...@inte

Re: [Qemu-devel] [PATCH] slirp: Mark debugging calls as unlikely

Marc-André Lureau, le jeu. 22 nov. 2018 11:13:51 +0400, a ecrit: > With s/unlikely/G_UNLIKELY: > Reviewed-by: Marc-André Lureau Right, pushed, thanks :)

[Qemu-devel] [PATCH] hw: arm: musicpal: drop TYPE_WM8750 in object_property_set_link()

The third argument of object_property_set_link() is the name of property, not related with the QOM type name, using the constant string instead. Signed-off-by: Li Qiang --- hw/arm/musicpal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/arm/musicpal.c b/hw/arm/musicpal.c

Re: [Qemu-devel] 答复: Can't see mouse cursor on VNC viewer

On Thu, Nov 22, 2018 at 05:08:16PM +0800, Heyi Guo wrote: > Hi Gerd, > > One more question: do you know any VNC client which supports rich > cursor extension? We'd like to try such client to see the real effect. remote-viewer (comes with virt-viewer) supports it for sure. cheers, Gerd

Re: [Qemu-devel] [PATCH v1] tpm: check localities index

+-- On Wed, 21 Nov 2018, Stefan Berger wrote --+ | I audited all functions yesterday and my proposed patches are on the mailing | list. The abort related ones seem most critical but they are all passed values | they can handle. I do not think that an out-of-bounds access can occur with | the curren

Re: [Qemu-devel] 答复: [PATCH RESEND v15 10/10] target-arm: kvm64: handle SIGBUS signal from kernel or KVM

On 22 November 2018 at 10:28, Peter Maydell wrote: > On 22 November 2018 at 03:05, gengdongjiu wrote: >>> > >>> Shouldn't there be something in here to say "only report this error to the >>> guest if we are actually reporting RAS errors to the guest" ? >> >> Yes, We can say something that such a

Re: [Qemu-devel] 答复: [PATCH RESEND v15 10/10] target-arm: kvm64: handle SIGBUS signal from kernel or KVM

On 22 November 2018 at 03:05, gengdongjiu wrote: >> > >> > +void kvm_arch_on_sigbus_vcpu(CPUState *c, int code, void *addr) { >> > +ram_addr_t ram_addr; >> > +hwaddr paddr; >> > + >> > +assert(code == BUS_MCEERR_AR || code == BUS_MCEERR_AO); >> > +if (addr) { >> > +ram_addr

Re: [Qemu-devel] [PATCH v2 for-3.2 v2 02/30] slirp: drop

Hi On Thu, Nov 22, 2018 at 2:10 AM Marc-André Lureau wrote: > > Since commit 12f8def0e02232d7c6416ad9b66640f973c531d1 (v2.9), qemu > requires Vista. Let's remove some conditional code. > > Note that this introduces a missing declaration warning with mingw. > warning: implicit declaration of funct

Re: [Qemu-devel] [PATCH] hw: arm: musicpal: drop TYPE_WM8750 in object_property_set_link()

Hi Li, On 22/11/18 11:00, Li Qiang wrote: > The third argument of object_property_set_link() is the name of > property, not related with the QOM type name, using the constant > string instead. You are correct. > > Signed-off-by: Li Qiang > --- > hw/arm/musicpal.c | 2 +- > 1 file changed, 1 i

Re: [Qemu-devel] [PATCH] scsi-disk: Fix crash if underlying host file or disk returns error.

Am 21.11.2018 um 19:31 hat Paolo Bonzini geschrieben: > On 21/11/18 13:47, Richard W.M. Jones wrote: > > Commit 40dce4ee6 "scsi-disk: fix rerror/werror=ignore" introduced a > > bug which causes qemu to crash with the assertion error below if the > > host file or disk returns an error: > > > > qe

[Qemu-devel] [PATCH 0/2] acpi: RSDP: fix checksum calculations

* arm/virt is broken but it looks like linux doesn't care, lets fix it anyways * x86, got lucky since we didn't use extended fields, fix it so that it will calculate checksum using correct length so that it would be easier to unify arm/x86 into one impl. Igor Mammedov (2): pc: acpi: use

[Qemu-devel] [PATCH 2/2] arm/virt: acpi: fix incorrect checksums in RSDP

When RSDP table was introduced (d4bec5d87), we calculated only legacy checksum, and that was incorrect as it - specified rev=2 and forgot about extended checksum. - legacy checksum calculated on full table instead of the 1st 20 bytes Fix it by adding extended checksum calculation and using corre

[Qemu-devel] [PATCH 1/2] pc: acpi: use correct RSDT length for checksum

AcpiRsdpDescriptor describes revision 2 RSDP table so using sizeof(*rsdp) for checksum calculation isn't correct since we are adding extra 16 bytes. But acpi_data_push() zeroes out table, so just by luck we are summing up exta zeros which still yelds correct checksum. Fix it up by explicitly stati

Re: [Qemu-devel] [PATCH] hw: arm: musicpal: drop TYPE_WM8750 in object_property_set_link()

On 22 November 2018 at 10:35, Philippe Mathieu-Daudé wrote: > Hi Li, > > On 22/11/18 11:00, Li Qiang wrote: >> The third argument of object_property_set_link() is the name of >> property, not related with the QOM type name, using the constant >> string instead. > > You are correct. > >> >> Signed-

Re: [Qemu-devel] [PATCH v5 00/24] ACPI reorganization for hardware-reduced API addition

On Wed, 21 Nov 2018 15:38:16 +0100 Samuel Ortiz wrote: > Igor, > > On Wed, Nov 21, 2018 at 03:15:26PM +0100, Igor Mammedov wrote: > > On Wed, 21 Nov 2018 07:35:47 -0500 > > "Michael S. Tsirkin" wrote: > > > > > On Mon, Nov 19, 2018 at 04:31:10PM +0100, Igor Mammedov wrote: > > > > On Fri,

Re: [Qemu-devel] [PATCH] hw: arm: musicpal: drop TYPE_WM8750 in object_property_set_link()

Peter Maydell 于2018年11月22日周四 下午6:38写道： > On 22 November 2018 at 10:35, Philippe Mathieu-Daudé > wrote: > > Hi Li, > > > > On 22/11/18 11:00, Li Qiang wrote: > >> The third argument of object_property_set_link() is the name of > >> property, not related with the QOM type name, using the constant

Re: [Qemu-devel] [PATCH for-3.2 v7 0/6] Connect a PCIe host and graphics support to RISC-V

On Wed, 2018-11-21 at 17:02 +, Alistair Francis wrote: > V7: > - Fix the GPEX memory mapping thanks to Bin Meng > - Fix the interrupt mapping thanks to Logan Gunthorpe > [...] > > Alistair Francis (6): > hw/riscv/virt: Increase the number of interrupts > hw/riscv/virt: Adjust memory lay

[Qemu-devel] [PATCH for-3.2 0/4] build-sys: require Vista API by default globally

Hi, Here is a small series improving a bit Windows headers inclusion, and setting the default required API version globally to Vista. It also allows easier tweaking of available API version via CFLAGS. Building QGA for older versions (XP) seems possible so far: the dependency on libqemuutil.a imp

[Qemu-devel] [PATCH for-3.2 2/4] build-sys: move windows defines in osdep.h header

This removes some clutter in compilation logging, and allows some easier tweaking per compilation unit/CFLAGS overriding. Note that we can't move those define in os-win32.h, since they must be set before the first system headers are included. Signed-off-by: Marc-André Lureau --- include/qemu/os

[Qemu-devel] [PATCH for-3.2 1/4] build-sys: don't include windows.h, osdep.h does it

osdep.h will also define the available Windows API version for QEMU. Signed-off-by: Marc-André Lureau --- accel/tcg/translate-all.c | 4 1 file changed, 4 deletions(-) diff --git a/accel/tcg/translate-all.c b/accel/tcg/translate-all.c index 639f0b2728..8cb8c8870e 100644 --- a/accel/tcg/tra

[Qemu-devel] [PATCH for-3.2 3/4] build-sys: build with Vista API by default

Both qemu & qga build with Vista API by default already, by defining _WIN32_WINNT 0x0600. Set it globally in osdep.h instead. This replaces WINVER by _WIN32_WINNT in osdep.h. WINVER doesn't seem to be really useful these days. (see also https://blogs.msdn.microsoft.com/oldnewthing/20070411-00/?p=2

[Qemu-devel] [PATCH for-3.2 4/4] RFC: qga: drop < Vista compatibility

Building QGA for XP seems possible so far: the dependency on libqemuutil.a implies building qemu-thread-win32.c, which requires Vista API since commit 12f8def0 (v2.9). But qemu-thread isn't being used in QGA, the resulting binary may still work on XP. XP is no longer supported for the past 4.5y, i

Re: [Qemu-devel] [PATCH] hw: arm: musicpal: drop TYPE_WM8750 in object_property_set_link()

On 22/11/18 11:40, Li Qiang wrote: > Peter Maydell > 于2018年11月22日周四 下午6:38写道： > > On 22 November 2018 at 10:35, Philippe Mathieu-Daudé > mailto:phi...@redhat.com>> wrote: > > Hi Li, > > > > On 22/11/18 11:00, Li Qiang wrote: > >> The third

Re: [Qemu-devel] SeaBIOS booting time optimization

Hi, I continued to investigate how to reduce the boot time with SeaBIOS and QEMU when it used with linuxboot_dma.bin (-kernel parameter). I reached ~12ms with a SeaBIOS configuration (attached) where I disabled debug output, all Hardware support (except SMM & MTRRs) and I applied a small patch to d

Re: [Qemu-devel] [PATCH v5 06/36] ppc/xive: add support for the END Event State buffers

On Fri, Nov 16, 2018 at 11:56:59AM +0100, Cédric Le Goater wrote: > The Event Notification Descriptor also contains two Event State > Buffers providing further coalescing of interrupts, one for the > notification event (ESn) and one for the escalation events (ESe). A > MMIO page is assigned for eac

Re: [Qemu-devel] [PATCH v4 10/23] json: Define new QMP message for pvrdma

On Mon, Nov 19, 2018 at 08:16:08AM +0100, Markus Armbruster wrote: > The subsystem tag in the commit message's title should be "qapi: " not > "json: ". Done. > > Yuval Shaia writes: > > > pvrdma requires that the same GID attached to it will be attached to the > > backend device in the host. >

Re: [Qemu-devel] [PATCH v3] qapi: Reduce Makefile boilerplate

On Tue, Nov 20, 2018 at 01:17:28PM +0200, Eric Blake wrote: > Adding a new qapi module had some rather tedious repetition to > wire it into Makefile, Makefile.objs, and .gitignore (for example, > see commit bf42508f and its followup b61acdec). For make, add some > indirection by taking advantage of

[Qemu-devel] [PATCH for-4.0 0/3] Avoid cpu_physical_memory_read() in generic code

This patchset takes three places in generic code which use cpu_physical_memory_read(), and changes them to use address_space_read() instead. cpu_physical_memory_{read,rw,write} all implicitly assume that there is exactly one view of physical memory. This is sort-of true today, but we'd like to be

[Qemu-devel] [PATCH for-4.0 2/3] monitor: Use address_space_read() to read memory

Currently monitor.c reads physical memory using cpu_physical_memory_read(). This effectively hard-codes assuming that all CPUs have the same view of physical memory. Switch to address_space_read() instead, which lets us use the AddressSpace for the CPU we're reading memory for (falling back to addr

[Qemu-devel] [PATCH for-4.0 3/3] elf_ops.h: Use address_space_write() to write memory

Currently the load_elf function in elf_ops.h uses cpu_physical_memory_write() to write the ELF file to memory if it is not handling it as a ROM blob. This means we ignore the AddressSpace that the function is passed to define where it should be loaded. Use address_space_write() instead. Signed-off

[Qemu-devel] [PATCH for-4.0 1/3] disas.c: Use address_space_read() to read memory

Currently disas.c reads physical memory using cpu_physical_memory_read(). This effectively hard-codes assuming that all CPUs have the same view of physical memory. Switch to address_space_read() instead, which lets us use the AddressSpace for the CPU we're disassembling for. Signed-off-by: Peter M

Re: [Qemu-devel] [PATCH for-4.0 3/3] elf_ops.h: Use address_space_write() to write memory

On 22/11/18 12:29, Peter Maydell wrote: > Currently the load_elf function in elf_ops.h uses > cpu_physical_memory_write() to write the ELF file to > memory if it is not handling it as a ROM blob. This > means we ignore the AddressSpace that the function > is passed to define where it should be load

Re: [Qemu-devel] SeaBIOS booting time optimization

On Thu, Nov 22, 2018 at 12:08:55PM +0100, Stefano Garzarella wrote: > Hi, > I continued to investigate how to reduce the boot time with SeaBIOS > and QEMU when it used with linuxboot_dma.bin (-kernel parameter). > I reached ~12ms with a SeaBIOS configuration (attached) where I > disabled debug outp

[Qemu-devel] [PATCH] 9p: fix QEMU crash when renaming files

When using the 9P2000.u version of the protocol, the following shell command line in the guest can cause QEMU to crash: while true; do rm -rf aa; mkdir -p a/b & touch a/b/c & mv a aa; done With 9P2000.u, file renaming is handled by the WSTAT command. The v9fs_wstat() function calls v9fs_compl

Re: [Qemu-devel] [PATCH] roms: seabios: Rename CROSS_COMPILE to CROSS_PREFIX

On Wed, Nov 21, 2018 at 11:37:21PM +0300, Roman Bolshakov wrote: > SeaBIOS introduced CROSS_PREFIX in 2013 but it's not set in roms > Makefile. > - CROSS_COMPILE=$(x86_64_cross_prefix) \ > + CROSS_PREFIX=$(x86_64_cross_prefix) \ I'm wondering how that slipped though, IIRC

[Qemu-devel] [PATCH v5 22/24] hw/rdma: Do not call rdma_backend_del_gid on an empty gid

When device goes down the function fini_ports loops over all entries in gid table regardless of the fact whether entry is valid or not. In case that entry is not valid we'd like to skip from any further processing in backend device. Signed-off-by: Yuval Shaia Reviewed-by: Marcel Apfelbaum --- h

[Qemu-devel] [PATCH v5 19/24] vl: Introduce shutdown_notifiers

Notifier will be used for signaling shutdown event to inform system is shutdown. This will allow devices and other component to run some cleanup code needed before VM is shutdown. Signed-off-by: Yuval Shaia Reviewed-by: Cornelia Huck --- include/sysemu/sysemu.h | 1 + vl.c|

[Qemu-devel] [PATCH v5 09/24] hw/pvrdma: Set the correct opcode for send completion

opcode for WC should be set by the device and not taken from work element. Signed-off-by: Yuval Shaia Reviewed-by: Marcel Apfelbaum --- hw/rdma/vmw/pvrdma_qp_ops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/rdma/vmw/pvrdma_qp_ops.c b/hw/rdma/vmw/pvrdma_qp_ops.c index

[Qemu-devel] [PATCH v5 20/24] hw/pvrdma: Clean device's resource when system is shutdown

In order to clean some external resources such as GIDs, QPs etc, register to receive notification when VM is shutdown. Signed-off-by: Yuval Shaia Reviewed-by: Marcel Apfelbaum --- hw/rdma/vmw/pvrdma.h | 2 ++ hw/rdma/vmw/pvrdma_main.c | 15 +++ 2 files changed, 17 insertions(+

[Qemu-devel] [PATCH v5 21/24] hw/rdma: Do not use bitmap_zero_extend to free bitmap

bitmap_zero_extend is designed to work for extending, not for shrinking. Using g_free instead. Signed-off-by: Yuval Shaia Reviewed-by: Marcel Apfelbaum --- hw/rdma/rdma_rm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/rdma/rdma_rm.c b/hw/rdma/rdma_rm.c index b7d4ebe97

[Qemu-devel] [PATCH v5 18/24] hw/rdma: Remove unneeded code that handles more that one port

Device supports only one port, let's remove a dead code that handles more than one port. Signed-off-by: Yuval Shaia Reviewed-by: Marcel Apfelbaum --- hw/rdma/rdma_rm.c | 34 -- hw/rdma/rdma_rm.h | 2 +- hw/rdma/rdma_rm_defs.h | 4 ++-- 3 files changed

[Qemu-devel] [PATCH v5 14/24] hw/rdma: Initialize node_guid from vmxnet3 mac address

node_guid should be set once device is load. Make node_guid be GID format (32 bit) of PCI function 0 vmxnet3 device's MAC. A new function was added to do the conversion. So for example the MAC 56:b6:44:e9:62:dc will be converted to GID 54b6:44ff:fee9:62dc. Signed-off-by: Yuval Shaia Reviewed-by:

[Qemu-devel] [PATCH v5 24/24] docs: Update pvrdma device documentation

Interface with the device is changed with the addition of support for MAD packets. Adjust documentation accordingly. While there fix a minor mistake which may lead to think that there is a relation between using RXE on host and the compatibility with bare-metal peers. Signed-off-by: Yuval Shaia

[Qemu-devel] [PATCH v5 16/24] hw/pvrdma: Fill all CQE fields

Add ability to pass specific WC attributes to CQE such as GRH_BIT flag. Signed-off-by: Yuval Shaia Reviewed-by: Marcel Apfelbaum --- hw/rdma/rdma_backend.c | 59 +++-- hw/rdma/rdma_backend.h | 4 +-- hw/rdma/vmw/pvrdma_qp_ops.c | 31 +++

[Qemu-devel] [PATCH v5 13/24] hw/pvrdma: Make sure PCI function 0 is vmxnet3

Guest driver enforces it, we should also. Signed-off-by: Yuval Shaia --- hw/rdma/vmw/pvrdma.h | 2 ++ hw/rdma/vmw/pvrdma_main.c | 12 2 files changed, 14 insertions(+) diff --git a/hw/rdma/vmw/pvrdma.h b/hw/rdma/vmw/pvrdma.h index b019cb843a..10a3c4fb7c 100644 --- a/hw/rdma/v

[Qemu-devel] [PATCH v5 17/24] hw/pvrdma: Fill error code in command's response

Driver checks error code let's set it. Signed-off-by: Yuval Shaia --- hw/rdma/vmw/pvrdma_cmd.c | 67 1 file changed, 48 insertions(+), 19 deletions(-) diff --git a/hw/rdma/vmw/pvrdma_cmd.c b/hw/rdma/vmw/pvrdma_cmd.c index 0d3c818c20..a326c5d470 100644 --

[Qemu-devel] [PATCH v5 01/24] contrib/rdmacm-mux: Add implementation of RDMA User MAD multiplexer

RDMA MAD kernel module (ibcm) disallow more than one MAD-agent for a given MAD class. This does not go hand-by-hand with qemu pvrdma device's requirements where each VM is MAD agent. Fix it by adding implementation of RDMA MAD multiplexer service which on one hand register as a sole MAD agent with

[Qemu-devel] [PATCH v5 23/24] hw/pvrdma: Do not clean resources on shutdown

All resources are already cleaned at rm_fini phase. Signed-off-by: Yuval Shaia --- hw/rdma/rdma_backend.c | 21 + 1 file changed, 1 insertion(+), 20 deletions(-) diff --git a/hw/rdma/rdma_backend.c b/hw/rdma/rdma_backend.c index 6a1e39d4c0..8ab25e94b1 100644 --- a/hw/rdma/rd

[Qemu-devel] [PATCH v5 00/24] Add support for RDMA MAD

Hi all. This is a major enhancement to the pvrdma device to allow it to work with state of the art applications such as MPI. As described in patch #5, MAD packets are management packets that are used for many purposes including but not limited to communication layer above IB verbs API. Patch 1 e

[Qemu-devel] [PATCH v5 08/24] hw/pvrdma: Set the correct opcode for recv completion

The function pvrdma_post_cqe populates CQE entry with opcode from the given completion element. For receive operation value was not set. Fix it by setting it to IBV_WC_RECV. Signed-off-by: Yuval Shaia Reviewed-by: Marcel Apfelbaum --- hw/rdma/vmw/pvrdma_qp_ops.c | 3 ++- 1 file changed, 2 inser

Re: [Qemu-devel] [PATCH for-4.0 1/3] disas.c: Use address_space_read() to read memory

On 22/11/18 12:29, Peter Maydell wrote: > Currently disas.c reads physical memory using > cpu_physical_memory_read(). This effectively hard-codes > assuming that all CPUs have the same view of physical > memory. Switch to address_space_read() instead, which > lets us use the AddressSpace for the CP

[Qemu-devel] [PATCH v5 15/24] hw/pvrdma: Make device state depend on Ethernet function state

User should be able to control the device by changing Ethernet function state so if user runs 'ifconfig ens3 down' the PVRDMA function should be down as well. Signed-off-by: Yuval Shaia Reviewed-by: Marcel Apfelbaum --- hw/rdma/vmw/pvrdma_cmd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deleti

[Qemu-devel] [PATCH v5 12/24] vmxnet3: Move some definitions to header file

pvrdma setup requires vmxnet3 device on PCI function 0 and PVRDMA device on PCI function 1. pvrdma device needs to access vmxnet3 device object for several reasons: 1. Make sure PCI function 0 is vmxnet3. 2. To monitor vmxnet3 device state. 3. To configure node_guid accoring to vmxnet3 device's MAC

Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered

On 2018-11-21 19:14, Markus Armbruster wrote: > Time for another update. My HEAD is at v3.1.0-rc2. Thanks a lot for this, Markus, very appreciated! [...] > Unmaintained files sorted by number of commits in the past year > (v2.11.0-rc2): > > $ for i in `cat unmaintained-files`; do echo -n "$i ";

Re: [Qemu-devel] [PATCH] target: hax: replace g_malloc with g_malloc0

On 21/11/2018 18:55, Paolo Bonzini wrote: > On 15/11/18 07:05, Li Qiang wrote: >> And also the g_malloc doesn't need check return value, >> remove it. >> >> Cc: qemu-triv...@nongnu.org >> >> Signed-off-by: Li Qiang >> --- >> target/i386/hax-all.c | 15 +++ >> 1 file changed, 3 inserti

[Qemu-devel] [PATCH v5 07/24] hw/pvrdma: Make default pkey 0xFFFF

Commit 6e7dba23af ("hw/pvrdma: Make default pkey 0x") exports default pkey as external definition but omit the change from 0x7FFF to 0x. Fixes: 6e7dba23af ("hw/pvrdma: Make default pkey 0x") Signed-off-by: Yuval Shaia Reviewed-by: Marcel Apfelbaum --- hw/rdma/vmw/pvrdma.h | 2 +- 1

[Qemu-devel] [PATCH v5 02/24] hw/rdma: Add ability to force notification without re-arm

Upon completion of incoming packet the device pushes CQE to driver's RX ring and notify the driver (msix). While for data-path incoming packets the driver needs the ability to control whether it wished to receive interrupts or not, for control-path packets such as incoming MAD the driver needs to b

Re: [Qemu-devel] [PATCH 2/2] arm/virt: acpi: fix incorrect checksums in RSDP

On Thu, Nov 22, 2018 at 11:29:34AM +0100, Igor Mammedov wrote: > When RSDP table was introduced (d4bec5d87), we calculated only legacy > checksum, and that was incorrect as it > - specified rev=2 and forgot about extended checksum. > - legacy checksum calculated on full table instead of the 1st 2

[Qemu-devel] [PATCH v5 06/24] hw/pvrdma: Make function reset_device return void

This function cannot fail - fix it to return void Signed-off-by: Yuval Shaia Reviewed-by: Marcel Apfelbaum --- hw/rdma/vmw/pvrdma_main.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/rdma/vmw/pvrdma_main.c b/hw/rdma/vmw/pvrdma_main.c index 6c8c0154fa..fc2abd34af 1006

Re: [Qemu-devel] [Qemu-trivial] [PATCH v3] qapi: Reduce Makefile boilerplate

On 16/11/2018 21:00, Eric Blake wrote: > Adding a new qapi module had some rather tedious repetition to > wire it into Makefile, Makefile.objs, and .gitignore (for example, > see commit bf42508f and its followup b61acdec). For make, add some > indirection by taking advantage of GNU Make string proc

[Qemu-devel] [PATCH v5 05/24] hw/rdma: Add support for MAD packets

MAD (Management Datagram) packets are widely used by various modules both in kernel and in user space for example the rdma_* API which is used to create and maintain "connection" layer on top of RDMA uses several types of MAD packets. For more information please refer to chapter 13.4 in Volume 1 A

[Qemu-devel] [PATCH v5 03/24] hw/rdma: Return qpn 1 if ibqp is NULL

Device is not supporting QP0, only QP1. Signed-off-by: Yuval Shaia Reviewed-by: Marcel Apfelbaum --- hw/rdma/rdma_backend.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/rdma/rdma_backend.h b/hw/rdma/rdma_backend.h index 86e8fe8ab6..3ccc9a2494 100644 --- a/hw/rdma/rdma_

[Qemu-devel] [PATCH v5 10/24] qapi: Define new QMP message for pvrdma

pvrdma requires that the same GID attached to it will be attached to the backend device in the host. A new QMP messages is defined so pvrdma device can broadcast any change made to its GID table. This event is captured by libvirt which in turn will update the GID table in the backend device. Sign

[Qemu-devel] [PATCH v5 11/24] hw/pvrdma: Add support to allow guest to configure GID table

The control over the RDMA device's GID table is done by updating the device's Ethernet function addresses. Usually the first GID entry is determined by the MAC address, the second by the first IPv6 address and the third by the IPv4 address. Other entries can be added by adding more IP addresses. Th

[Qemu-devel] [PATCH v5 04/24] hw/rdma: Abort send-op if fail to create addr handler

Function create_ah might return NULL, let's exit with an error. Signed-off-by: Yuval Shaia Reviewed-by: Marcel Apfelbaum --- hw/rdma/rdma_backend.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/rdma/rdma_backend.c b/hw/rdma/rdma_backend.c index d7a4bbd91f..1e148398a2 100644 --- a/h

Re: [Qemu-devel] [PATCH 1/1] Acceptance tests: add test for set-numa-node error handler fix

On 11/21/2018 11:41 AM, Cleber Rosa wrote: Commit a22528b918 fixed an issue that is exposed by means of the "set-numa-node" QMP command (introduced in f3be67812). This adds a test that pretty much maps the steps documented on the fix. Additionally, given that 'set-numa-node' is only allowed i

Re: [Qemu-devel] [Qemu-trivial] [PATCH] misc: Avoid UTF-8 in error messages

On 20/11/2018 21:36, Eric Blake wrote: > While most developers are now using UTF-8 environments, it's > harder to guarantee that error messages will be output to > a multibyte locale. Rather than risking error messages that > get corrupted into mojibake when the user runs qemu in a > non-multibyte

[Qemu-devel] [PATCH] MAINTAINERS: Add some missing entries related to accelerators

Add some files from accel/stubs/, include/hw/kvm/ and scripts/kvm/ to the MAINTAINERS file. Signed-off-by: Thomas Huth --- MAINTAINERS | 5 + 1 file changed, 5 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 63c88e1..6522621 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -117,6 +1

Re: [Qemu-devel] [PATCH for-4.0 2/3] monitor: Use address_space_read() to read memory

* Peter Maydell (peter.mayd...@linaro.org) wrote: > Currently monitor.c reads physical memory using > cpu_physical_memory_read(). This effectively hard-codes > assuming that all CPUs have the same view of physical > memory. Switch to address_space_read() instead, which > lets us use the AddressSpac

Re: [Qemu-devel] encrypt in threads

21.11.2018 20:30, Vladimir Sementsov-Ogievskiy wrote: > Hi Daniel! > > After moving compression to threads in Qcow2 it's an obvious next step to > "threadyfy" encryption in Qcow2 too. > > But it turned out to be not as simple as I assumed. If I call > qcrypto_block_encrypt > in parallel threads

[Qemu-devel] [PATCH] MAINTAINERS: Add missing hw/pci-host entries

Bonito belongs to Fulong-2E, Sabre belongs to Sun4u, and Mac-Newworld and Mips-Boston were missing the header files. Signed-off-by: Thomas Huth --- MAINTAINERS | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 6522621..46a5581 100644 --- a/M

Re: [Qemu-devel] [PATCH] MAINTAINERS: Add some missing entries related to accelerators

On 22/11/18 13:57, Thomas Huth wrote: > Add some files from accel/stubs/, include/hw/kvm/ and scripts/kvm/ > to the MAINTAINERS file. > > Signed-off-by: Thomas Huth > --- > MAINTAINERS | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 63c88e1..65226

Re: [Qemu-devel] [PATCH for-3.1] MAINTAINERS: Add an entry for the Firmware Configuration (fw_cfg) device

On 22/11/18 03:11, Philippe Mathieu-Daudé wrote: > Step in to maintain it, with Laszlo (EDK2) and Gerd (SeaBIOS) > as designated reviewers. > > Signed-off-by: Philippe Mathieu-Daudé > --- > Note than OpenBIOS also consumes this device (PPC/Sparc). > > MAINTAINERS | 13 + > 1 file ch

Re: [Qemu-devel] [PATCH] target: hax: replace g_malloc with g_malloc0

On 22/11/18 13:08, Laurent Vivier wrote: > On 21/11/2018 18:55, Paolo Bonzini wrote: >> On 15/11/18 07:05, Li Qiang wrote: >>> And also the g_malloc doesn't need check return value, >>> remove it. >>> >>> Cc: qemu-triv...@nongnu.org >>> >>> Signed-off-by: Li Qiang >>> --- >>> target/i386/hax-all.

Re: [Qemu-devel] [PATCH] checkpatch: g_test_message does not need a a trailing newline

On 21/11/18 19:38, Philippe Mathieu-Daudé wrote: > > > On 21/11/18 19:27, Paolo Bonzini wrote: >> Signed-off-by: Paolo Bonzini >> --- >>   scripts/checkpatch.pl | 3 ++- >>   1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl >> index e

Re: [Qemu-devel] [PATCH for-3.2 09/41] slirp: add a set_nonblock() callback

On 21/11/18 22:02, Marc-André Lureau wrote: > Hi > On Thu, Nov 15, 2018 at 5:09 PM Paolo Bonzini wrote: >> >> On 14/11/2018 13:36, Marc-André Lureau wrote: >>> qemu_set_nonblock() does some event registration with the main loop on >>> win32, let's have a callback. >>> >>> Signed-off-by: Marc-André

Re: [Qemu-devel] [PATCH] Xen PCI passthrough: fix passthrough failure when irq map failure

On Thu, Oct 18, 2018 at 03:56:36PM +0100, Roger Pau Monné wrote: > On Thu, Oct 18, 2018 at 08:22:41AM +, Zhao, Yan Y wrote: > > Hi > > The background for this patch is that: for some pci device, even it's > > PCI_INTERRUPT_PIN is not 0, it actually does not support INTx mode, so we > > should

[Qemu-devel] [PATCH for 3.1 v3] spapr: Fix ibm, max-associativity-domains property number of nodes

Laurent Vivier reported off by one with maximum number of NUMA nodes provided by qemu-kvm being less by one than required according to description of "ibm,max-associativity-domains" property in LoPAPR. It appears that I incorrectly treated LoPAPR description of this property assuming it provides l

Re: [Qemu-devel] [Qemu-ppc] [PATCH for 3.1 v3] spapr: Fix ibm, max-associativity-domains property number of nodes

On Thu, 22 Nov 2018 08:19:27 -0500 Serhii Popovych wrote: > Laurent Vivier reported off by one with maximum number of NUMA nodes > provided by qemu-kvm being less by one than required according to > description of "ibm,max-associativity-domains" property in LoPAPR. > > It appears that I incorrec

Re: [Qemu-devel] [PATCH] MAINTAINERS: Add missing hw/pci-host entries

Thomas wrote: > Bonito belongs to Fulong-2E, Sabre belongs to Sun4u, and Mac-Newworld > and Mips-Boston were missing the header files. > > Signed-off-by: Thomas Huth > --- > MAINTAINERS | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) For MIPS bits and pieces (Fulong-2E and Boston b

[Qemu-devel] [PATCH] audio/hda: fix guest triggerable assert

Guest writes to a readonly register trigger the assert in intel_hda_reg_write(). Add a check and just ignore them. Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1628433 Signed-off-by: Gerd Hoffmann --- hw/audio/intel-hda.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/audio/

[Qemu-devel] [PATCH for-4.0 1/2] exec.c: Rename cpu_physical_memory_write_rom_internal()

Rename cpu_physical_memory_write_rom_internal() to address_space_write_rom_internal(), and make it take MemTxAttrs and return a MemTxResult. This brings its API into line with address_space_write(). This is an internal function to exec.c; fixing its API will allow us to change the global function

[Qemu-devel] [PATCH for-4.0 0/2] Rename cpu_physical_memory_write_rom() to address_space_write_rom()

The API of cpu_physical_memory_write_rom() is odd, because it takes an AddressSpace, unlike all the other cpu_physical_memory_* access functions. We note this oddity as a TODO in the docs/devel/loads-stores.rst documentation. Rename cpu_physical_memory_write_rom() to address_space_write_rom(), and

Re: [Qemu-devel] [Qemu-trivial] [PATCH] MAINTAINERS: Add missing hw/pci-host entries

On 22/11/2018 14:02, Thomas Huth wrote: > Bonito belongs to Fulong-2E, Sabre belongs to Sun4u, and Mac-Newworld > and Mips-Boston were missing the header files. > > Signed-off-by: Thomas Huth > --- > MAINTAINERS | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/MAINT

Re: [Qemu-devel] [PATCH for 3.1 v3] spapr: Fix ibm, max-associativity-domains property number of nodes

On 22/11/2018 14:19, Serhii Popovych wrote: > Laurent Vivier reported off by one with maximum number of NUMA nodes > provided by qemu-kvm being less by one than required according to > description of "ibm,max-associativity-domains" property in LoPAPR. > > It appears that I incorrectly treated LoPA

Re: [Qemu-devel] [PATCH v3] MAINTAINERS: Assign some more files in the hw/arm/ directory

On 21 November 2018 at 06:42, Thomas Huth wrote: > I apparently missed some more files and even a complete machine (the > "imx25-pdk") in my previous patch... but now we should hopefully have > a completely coverage for all available ARM boards. > > Fixes: 95a5db3ae5698b49c63144610ad02913e780c828

[Qemu-devel] [PATCH for-4.0 2/2] Rename cpu_physical_memory_write_rom() to address_space_write_rom()

The API of cpu_physical_memory_write_rom() is odd, because it takes an AddressSpace, unlike all the other cpu_physical_memory_* access functions. Rename it to address_space_write_rom(), and bring its API into line with address_space_write(). Signed-off-by: Peter Maydell --- include/exec/cpu-comm

Re: [Qemu-devel] [RFC PATCH v2 1/3] target/ppc: Add macro definitions for relocated interrupt vectors offsets

On Wed, Nov 21, 2018 at 04:13:45PM -0200, Fabiano Rosas wrote: > The PowerISA prescribes that depending on the values of MSR_IR, > MSR_DR, MSR_HV and LPCR_AIL, the interrupt vectors might be relocated > by specific offsets. > > This patch defines macros for these offsets so that they can be used >

[Qemu-devel] [PATCH v1 02/16] virtio: introduce packed ring definitions

From: Wei Xu >From 1.1 spec. Signed-off-by: Wei Xu --- include/standard-headers/linux/virtio_config.h | 15 + include/standard-headers/linux/virtio_ring.h | 43 ++ 2 files changed, 58 insertions(+) diff --git a/include/standard-headers/linux/virtio_config.h

[Qemu-devel] [PATCH v1 03/16] virtio: redefine structure & memory cache for packed ring

From: Wei Xu Redefine packed ring structure according to Qemu nomenclature, field data(wrap counter, etc) are introduced also. Signed-off-by: Wei Xu --- hw/virtio/virtio.c | 16 1 file changed, 16 insertions(+) diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index 4136d2

[Qemu-devel] [PATCH v1 00/16] packed ring virtio-net backend support

From: Wei Xu Code base: https://github.com/Whishay/qemu.git rfc v3 -> v1 - migration support for both userspace and vhost-net, need tweak vhost ioctl() to make it work(the code is pasted in the commit message of vhost migration patch #13). Note: the high 32-bit guest feature bit is s

  1   2   3   >