Re: [Qemu-devel] [PATCH V7 4/6] hw/arm/virt: Use the pvpanic device

2018-11-21 Thread peng.hao2
> > Add pvpanic device in arm virt machine. > > > > Signed-off-by: Peng Hao > > Signed-off-by: Philippe Mathieu-Daudé > > --- > > default-configs/arm-softmmu.mak | 1 + > > hw/arm/virt.c | 21 + > > include/hw/arm/virt.h | 1 + > > 3 files chang

Re: [Qemu-devel] 答复: Can't see mouse cursor on VNC viewer

2018-11-21 Thread Gerd Hoffmann
Hi, > and can’t see cursor either with “virtio-gpu”. Does that mean > virtio-gpu + VNC must rely on VNC client to draw the cursor image on > the screen? Yes. virtio-gpu sends the cursor to the vnc client (via rich cursor extension) and expects the vnc client to show it. So, if you ask your vn

Re: [Qemu-devel] [PATCH v4] hw/arm: Add arm SBSA reference machine

2018-11-21 Thread Hongbo Zhang
Well, considering all the comments/suggestions I received, I'd like to try to create a generic sysbus xhci. This would take some time for me, so my plan is to send out a new v5 iteration of this sbsa-ref patch with updates according to Peter's comments, but without any xhci feature this time, and l

Re: [Qemu-devel] 答复: Can't see mouse cursor on VNC viewer

2018-11-21 Thread Heyi Guo
Hi Gerd, Is there any hacking way to turn off hardware cursor support for virtio-gpu, and make the cursor also be rendered to the framebuffer? Thanks, Heyi On 2018/11/21 16:23, Gerd Hoffmann wrote: Hi, and can’t see cursor either with “virtio-gpu”. Does that mean virtio-gpu + VNC must

Re: [Qemu-devel] [RFC 1/1] qemu-ga: add missing libpcre to MSI build

2018-11-21 Thread Sameeh Jubran
Hi thomas, Can you please share more info on why libpcre is needed in the first place? I have tried to build qemu without it and I see no issues of qemu-ga failing. On Fri, Jul 7, 2017 at 9:47 AM Thomas Lamprecht wrote: > > Hi, > > On 06/02/2017 01:42 PM, Marc-André Lureau wrote: > > Hi > > > > O

Re: [Qemu-devel] [PATCH 15/22] pci-bridge/dec: Convert sysbus init function to realize function

2018-11-21 Thread David Gibson
On Mon, Nov 19, 2018 at 08:08:13PM +0800, Mao Zhongyi wrote: > Use DeviceClass rather than SysBusDeviceClass in > pci_dec_21154_device_class_init(). > > Cc: da...@gibson.dropbear.id.au > Cc: m...@redhat.com > Cc: marcel.apfelb...@gmail.com > Cc: qemu-...@nongnu.org > > Signed-off-by: Mao Zhongyi

Re: [Qemu-devel] [PATCH for-3.2 v3 02/14] qom: make interface types abstract

2018-11-21 Thread Igor Mammedov
On Tue, 20 Nov 2018 19:54:23 +0100 Laszlo Ersek wrote: > On 11/20/18 17:33, Igor Mammedov wrote: > > On Wed, 7 Nov 2018 16:36:40 +0400 > > Marc-André Lureau wrote: > > > >> Interfaces don't have instance, let's make the interface type really > >> abstract to avoid confusion. > >> > >> Signed

Re: [Qemu-devel] [PATCH] lsi53c895a: check script ram address value

2018-11-21 Thread P J P
Hello Petr, Paolo, +-- On Tue, 6 Nov 2018, Paolo Bonzini wrote --+ | On 06/11/2018 13:03, Peter Maydell wrote: | > When can this masking have any effect? These functions are | > the read and write ops for lsi_ram_ops, which we register with | > memory_region_init_io(&s->ram_io, OBJECT(s), &l

Re: [Qemu-devel] [PATCH 6/6] tests: exercise NBD server in TLS mode

2018-11-21 Thread Daniel P . Berrangé
On Tue, Nov 20, 2018 at 12:22:39PM -0600, Eric Blake wrote: > On 11/20/18 11:53 AM, Daniel P. Berrangé wrote: > > > > > > +echo > > > > > +echo "== preparing TLS creds ==" > > > > > + > > > > > +tls_x509_create_root_ca "ca1" > > > > > +tls_x509_create_root_ca "ca2" > > > > > +tls_x509_create_serve

Re: [Qemu-devel] [PATCH] qom: avoid reporting errors for NULL error object

2018-11-21 Thread Daniel P . Berrangé
On Tue, Nov 20, 2018 at 07:16:31PM +0100, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > When debugging QEMU it is often useful to put a breakpoint on the > > error_setg_internal method impl. > > > > Unfortunately the object_property_add / object_class_property_add > > methods call o

Re: [Qemu-devel] [PATCH] iotests: Skip 233 if certtool not installed

2018-11-21 Thread Kevin Wolf
Am 20.11.2018 um 23:52 hat Eric Blake geschrieben: > The use of TLS while building qemu is optional. While the > 'certtool' binary should be available on every platform that > supports building against TLS, that does not imply that the > developer has installed it. Make the test gracefully skip >

Re: [Qemu-devel] [PATCH] iotests: Skip 233 if certtool not installed

2018-11-21 Thread Daniel P . Berrangé
On Tue, Nov 20, 2018 at 04:52:41PM -0600, Eric Blake wrote: > The use of TLS while building qemu is optional. While the > 'certtool' binary should be available on every platform that > supports building against TLS, that does not imply that the > developer has installed it. Make the test gracefull

Re: [Qemu-devel] [PATCH] migration/migration.c: Add COLO dependency checks

2018-11-21 Thread Zhang Chen
On Thu, Nov 15, 2018 at 11:55 AM Peter Xu wrote: > On Thu, Nov 15, 2018 at 03:09:12AM +0800, Zhang Chen wrote: > > From: Zhang Chen > > > > Current COLO mode(independent disk mode) need replication module work > > together. Suggested by Dr. David Alan Gilbert . > > > > Signed-off-by: Zhang Chen

Re: [Qemu-devel] [PATCH for-next? 0/2] qemu-img: Minor fixes to an amend error path

2018-11-21 Thread Kevin Wolf
Am 19.11.2018 um 11:19 hat Max Reitz geschrieben: > One of the amend error paths has two issues that are fixed by this > series. Since they are relatively minor and have been present in 3.0 > already, I think there is no need to get them into 3.1. OTOH they are > bug fixes, so they could go into

Re: [Qemu-devel] [PATCH 1/2] contrib/elf2dmp: use GLib file mapping

2018-11-21 Thread Roman Kagan
On Fri, Nov 02, 2018 at 03:28:17AM +0300, Viktor Prutyanov wrote: > Replace POSIX mmap with GLib g_mapped_file_new to make elf2dmp > cross-paltform. After this patch there are no direct POSIX calls. > > Signed-off-by: Viktor Prutyanov > --- > Makefile | 2 +- > contrib/elf2

Re: [Qemu-devel] [PATCH] qapi: add query-display-options command

2018-11-21 Thread Erik Skultety
On Tue, Nov 20, 2018 at 09:56:03AM +0100, Gerd Hoffmann wrote: > Add query-display-options command, which allows to query the qemu > display configuration, and -- as intentional side effect -- makes > DisplayOptions discoverable via query-qmp-schema so libvirt can go > figure which display options

Re: [Qemu-devel] 答复: Can't see mouse cursor on VNC viewer

2018-11-21 Thread Gerd Hoffmann
On Wed, Nov 21, 2018 at 04:54:15PM +0800, Heyi Guo wrote: > Hi Gerd, > > Is there any hacking way to turn off hardware cursor support for virtio-gpu, > and make the cursor also be rendered to the framebuffer? Well, you can configure xorg in the guest to force software cursor mode. cheers, Ger

Re: [Qemu-devel] [PATCH 2/2] contrib/elf2dmp: elf2dmp for Windows hosts

2018-11-21 Thread Roman Kagan
On Fri, Nov 02, 2018 at 03:28:18AM +0300, Viktor Prutyanov wrote: > After this patch elf2dmp can be built by mingw64 for Windows hosts. What prevents building it with mingw32? (I realize that since the tool uses mmaped access to the dump data it's limited to dumps under a couple of gigs but it's

Re: [Qemu-devel] [PATCH v2 1/9] cutils: Add qemu_strtod() and qemu_strtod_finite()

2018-11-21 Thread David Hildenbrand
On 20.11.18 21:07, Markus Armbruster wrote: > Eric Blake writes: > >> On 11/20/18 3:25 AM, David Hildenbrand wrote: >>> Let's provide a wrapper for strtod(). >>> >>> Reviewed-by: Eric Blake >> >> This changed enough from v1 that I would have dropped R-b to ensure >> that reviewers notice the dif

Re: [Qemu-devel] [PATCH v2 2/9] cutils: Fix qemu_strtosz() & friends to reject non-finite sizes

2018-11-21 Thread David Hildenbrand
On 20.11.18 21:41, Eric Blake wrote: > On 11/20/18 2:31 PM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> On 11/20/18 3:25 AM, David Hildenbrand wrote: qemu_strtosz() & friends reject NaNs, but happily accept inifities. >>> >>> s/inifities/infinities/ >>> They shouldn't. Fix that

Re: [Qemu-devel] [PATCH] fmops: fix off-by-one in AR_TABLE and DR_TABLE array size

2018-11-21 Thread P J P
Hello Gerd, +-- On Mon, 12 Nov 2018, Gerd Hoffmann wrote --+ | On Tue, Oct 30, 2018 at 09:23:40AM +0100, Gerd Hoffmann wrote: | > Fixes: CVE-2018-??? | > Cc: P J P | | ping, do we have a cve number meanwhile? No, the off-by-one does not seem to have an adverse effect. One byte past AR_TABLE[7

Re: [Qemu-devel] [PATCH v2 5/9] test-string-input-visitor: Add more tests

2018-11-21 Thread David Hildenbrand
On 20.11.18 18:26, Eric Blake wrote: > On 11/20/18 11:20 AM, Eric Blake wrote: >> On 11/20/18 11:06 AM, Eric Blake wrote: >>> On 11/20/18 3:25 AM, David Hildenbrand wrote: Test that very big/small values are not accepted and that ranges with only one element work. Also test that ranges ar

Re: [Qemu-devel] [PATCH] Fix for crashes and non-responsive UI on macOS Mojave

2018-11-21 Thread Programmingkid
> On 13 November 2018 at 12:12, Programmingkid > wrote: >>> On Nov 11, 2018, at 4:35 PM, Berkus Decker wrote: >>> These changes are ought to work on OSX 10.6, although I don?t have a >>> machine handy to test it. >> >> I have Mac OS 10.6 available for testing. > > This is perhaps a good poin

Re: [Qemu-devel] [PATCH v2 6/9] qapi: Rewrite string-input-visitor

2018-11-21 Thread David Hildenbrand
On 20.11.18 21:58, Markus Armbruster wrote: > I think the title should be something like > > qapi: Rewrite string-input-visitor's integer and list parsing > > because you don't actually rewrite all of it. > > Eric Blake writes: > >> On 11/20/18 3:25 AM, David Hildenbrand wrote: >>> The inp

Re: [Qemu-devel] [PATCH] Fix for crashes and non-responsive UI on macOS Mojave

2018-11-21 Thread Daniel P . Berrangé
On Wed, Nov 21, 2018 at 05:53:50AM -0500, Programmingkid wrote: > > > On 13 November 2018 at 12:12, Programmingkid > > wrote: > >>> On Nov 11, 2018, at 4:35 PM, Berkus Decker wrote: > >>> These changes are ought to work on OSX 10.6, although I don?t have a > >>> machine handy to test it. > >>

Re: [Qemu-devel] [PATCH V2] migration/colo.c: Fix compilation issue when disable replication

2018-11-21 Thread Dr. David Alan Gilbert
* Zhang Chen (zhangc...@gmail.com) wrote: > This compilation issue will occur when user use --disable-replication > to config Qemu. > > Reported-by: Thomas Huth > Signed-off-by: Zhang Chen Queued. > --- > migration/colo.c | 28 +++- > 1 file changed, 27 insertions(+),

[Qemu-devel] [PATCH] net: tap: use qemu_set_nonblock

2018-11-21 Thread Li Qiang
The fcntl will change the flags directly, use qemu_set_nonblock() instead. Signed-off-by: Li Qiang --- net/tap.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/net/tap.c b/net/tap.c index cc8525f154..e8aadd8d4b 100644 --- a/net/tap.c +++ b/net/tap.c @@ -592,7 +592

Re: [Qemu-devel] [PATCH] net: tap: use qemu_set_nonblock

2018-11-21 Thread Marc-André Lureau
Hi On Wed, Nov 21, 2018 at 3:22 PM Li Qiang wrote: > > The fcntl will change the flags directly, use qemu_set_nonblock() > instead. qemu_set_nonblock() will preserve the existing flags. And on windows, it will register the FD to the event loop. that's a reasonable thing to do, is this fixing an

Re: [Qemu-devel] [PATCH v3] MAINTAINERS: Assign some more files in the hw/arm/ directory

2018-11-21 Thread Philippe Mathieu-Daudé
On 21/11/18 7:42, Thomas Huth wrote: I apparently missed some more files and even a complete machine (the "imx25-pdk") in my previous patch... but now we should hopefully have a completely coverage for all available ARM boards. Fixes: 95a5db3ae5698b49c63144610ad02913e780c828 Signed-off-by: Thoma

Re: [Qemu-devel] [PATCH] net: tap: use qemu_set_nonblock

2018-11-21 Thread Li Qiang
Marc-André Lureau 于2018年11月21日周三 下午7:28写道: > Hi > > On Wed, Nov 21, 2018 at 3:22 PM Li Qiang wrote: > > > > The fcntl will change the flags directly, use qemu_set_nonblock() > > instead. > > qemu_set_nonblock() will preserve the existing flags. And on windows, > it will register the FD to the ev

Re: [Qemu-devel] [PATCH] migration/migration.c: Add COLO dependency checks

2018-11-21 Thread Dr. David Alan Gilbert
* Zhang Chen (chen.zh...@intel.com) wrote: > From: Zhang Chen > > Current COLO mode(independent disk mode) need replication module work > together. Suggested by Dr. David Alan Gilbert . > > Signed-off-by: Zhang Chen Queued > --- > migration/migration.c | 9 + > 1 file changed, 9 inse

Re: [Qemu-devel] [PATCH] misc: Avoid UTF-8 in error messages

2018-11-21 Thread Philippe Mathieu-Daudé
On 20/11/18 23:01, Eric Blake wrote: [adding Markus in CC, since git didn't do it automatically from the 'Reported-by'] On 11/20/18 3:28 PM, John Snow wrote: On 11/20/18 3:36 PM, Eric Blake wrote: While most developers are now using UTF-8 environments, it's harder to guarantee that error me

Re: [Qemu-devel] [PATCH v1] tpm: check localities index

2018-11-21 Thread P J P
Hello Stefan, Marc, +-- On Tue, 20 Nov 2018, P J P wrote --+ | | On 11/20/18 2:22 AM, P J P wrote: | | > From: Prasad J Pandit | | > While performing mmio device r/w operations, guest could set 'addr' | | > parameter such that 'locty' index exceeds TPM_TIS_NUM_LOCALITIES=5 | | > after setting n

Re: [Qemu-devel] [PATCH] iotests: Skip 233 if certtool not installed

2018-11-21 Thread Wainer dos Santos Moschetta
On 11/20/2018 08:52 PM, Eric Blake wrote: The use of TLS while building qemu is optional. While the 'certtool' binary should be available on every platform that supports building against TLS, that does not imply that the developer has installed it. Make the test gracefully skip in that case.

[Qemu-devel] 答复: [PATCH RESEND v15 07/10] KVM: Move related hwpoison page functions to accel/kvm/ folder

2018-11-21 Thread gengdongjiu
Hi Peter, Thanks very much for the commands and review. > On 8 November 2018 at 10:29, Dongjiu Geng wrote: > > kvm_hwpoison_page_add() and kvm_unpoison_all() will be used both by > > X86 and ARM platforms, so move these functions to a common accel/kvm/ > > folder to avoid duplicate code. > > >

Re: [Qemu-devel] [PATCH] net: tap: use qemu_set_nonblock

2018-11-21 Thread Daniel P . Berrangé
On Wed, Nov 21, 2018 at 03:28:29PM +0400, Marc-André Lureau wrote: > Hi > > On Wed, Nov 21, 2018 at 3:22 PM Li Qiang wrote: > > > > The fcntl will change the flags directly, use qemu_set_nonblock() > > instead. > > qemu_set_nonblock() will preserve the existing flags. And on windows, > it will r

Re: [Qemu-devel] [PATCH v2 01/12] i2c: Split smbus into parts

2018-11-21 Thread Peter Maydell
On 20 November 2018 at 19:30, Philippe Mathieu-Daudé wrote: > On 20/11/18 16:47, Peter Maydell wrote: >> We don't yet use SPDX headers. (They're just a different and >> shorter way to write the license statement.) > > > Does that mean we can use them, or you rather prefer we don't? > > While they

Re: [Qemu-devel] [PATCH] target/xtensa: xtfpga: provide default memory sizes

2018-11-21 Thread Philippe Mathieu-Daudé
Hi Max, On 20/11/18 21:38, Max Filippov wrote: Provide default RAM sizes for all XTFPGA boards, so that when started without -m option they do the right thing. Signed-off-by: Max Filippov --- hw/xtensa/xtfpga.c | 8 1 file changed, 8 insertions(+) diff --git a/hw/xtensa/xtfpga.c b

Re: [Qemu-devel] [PATCH RESEND v15 09/10] hw/arm/virt: Add RAS platform version for migration

2018-11-21 Thread gengdongjiu
> > On 8 November 2018 at 10:29, Dongjiu Geng wrote: > > Support this feature since version 2.12, disable it by default in the > > old version. > > > > Signed-off-by: Dongjiu Geng > > --- > > Address Shannon's comments to add platform version in [1]. > > > > [1]: https://lkml.org/lkml/2017/8/25/

Re: [Qemu-devel] [PATCH] target/xtensa: xtfpga: provide default memory sizes

2018-11-21 Thread Max Filippov
Hi Philippe, thanks for your review. On Wed, Nov 21, 2018 at 4:00 AM Philippe Mathieu-Daudé wrote: > On 20/11/18 21:38, Max Filippov wrote: > > static const TypeInfo xtfpga_lx200_nommu_type = { > > @@ -632,6 +636,7 @@ static void xtfpga_ml605_class_init(ObjectClass *oc, > > void *data) > >

Re: [Qemu-devel] [PATCH] net: tap: use qemu_set_nonblock

2018-11-21 Thread Michael S. Tsirkin
On Wed, Nov 21, 2018 at 11:57:18AM +, Daniel P. Berrangé wrote: > On Wed, Nov 21, 2018 at 03:28:29PM +0400, Marc-André Lureau wrote: > > Hi > > > > On Wed, Nov 21, 2018 at 3:22 PM Li Qiang wrote: > > > > > > The fcntl will change the flags directly, use qemu_set_nonblock() > > > instead. > >

[Qemu-devel] [PATCH v2] target/xtensa: xtfpga: provide default memory sizes

2018-11-21 Thread Max Filippov
Provide default RAM sizes for all XTFPGA boards, so that when started without -m option they do the right thing. Signed-off-by: Max Filippov --- Changes v1->v2: - fix memory sizes for ml605 and kc705 with MMU hw/xtensa/xtfpga.c | 8 1 file changed, 8 insertions(+) diff --git a/hw/xten

Re: [Qemu-devel] [PATCH v5 00/24] ACPI reorganization for hardware-reduced API addition

2018-11-21 Thread Michael S. Tsirkin
On Mon, Nov 19, 2018 at 04:31:10PM +0100, Igor Mammedov wrote: > On Fri, 16 Nov 2018 17:37:54 +0100 > Paolo Bonzini wrote: > > > On 16/11/18 17:29, Igor Mammedov wrote: > > > General suggestions for this series: > > > 1. Preferably don't do multiple changes within a patch > > > neither pos

[Qemu-devel] [Bug 1804323] Re: qemu segfaults in virtio-scsi driver if underlying device returns -EIO

2018-11-21 Thread Richard Jones
Kevin suggested this change, which works for me: diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c index 6eb258d3f3..0e9027c8f3 100644 --- a/hw/scsi/scsi-disk.c +++ b/hw/scsi/scsi-disk.c @@ -482,7 +482,7 @@ static bool scsi_handle_rw_error(SCSIDiskReq *r, int error, bool acct_failed) if

Re: [Qemu-devel] [PATCH v3 00/11] pci: hotplug handler reworks

2018-11-21 Thread David Hildenbrand
On 20.11.18 12:04, David Hildenbrand wrote: > This series reworks some pci hotplug handlers (except for s390, that will > require more work but is not required for now). > > 1. Route all unplug calls via the hotplug handler when called from the >unplug_request handler. This will be required to

[Qemu-devel] [PATCH] scsi-disk: Fix crash if underlying host file or disk returns error.

2018-11-21 Thread Richard W.M. Jones
Commit 40dce4ee6 "scsi-disk: fix rerror/werror=ignore" introduced a bug which causes qemu to crash with the assertion error below if the host file or disk returns an error: qemu-system-x86_64: hw/scsi/scsi-bus.c:1374: scsi_req_complete: Assertion `req->status == -1' failed. Kevin Wolf suggest

Re: [Qemu-devel] 3.1.0-rc{0,1} doesn't start

2018-11-21 Thread Eduardo Habkost
On Tue, Nov 20, 2018 at 11:28:59PM -0500, Bandan Das wrote: > baldu...@units.it writes: > > > hello > > > >> incomplete because it can return 0 for data. Can you try this: > >> > >> diff --git a/target/i386/kvm.c b/target/i386/kvm.c > >> index f524e7d929..4878ffb90b 100644 > >> --- a/target/i386/k

Re: [Qemu-devel] [[RFC v3 12/12] virtio: feature vhost-net support for packed ring

2018-11-21 Thread Maxime Coquelin
Hi Wei, On 10/11/18 4:08 PM, w...@redhat.com wrote: From: Wei Xu (cherry picked from commit 305a2c4640c15c5717245067ab937fd10f478ee6) Signed-off-by: Wei Xu (cherry picked from commit 46476dae6f44c6fef8802a4a0ac7d0d79fe399e3) Signed-off-by: Wei Xu --- hw/virtio/vhost.c | 3 +++ hw

[Qemu-devel] [PULL 0/2] migration queue

2018-11-21 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" The following changes since commit 47c1cc30e440860aa695358f7c2dd0b9d7b53d16: Update version for v3.1.0-rc2 release (2018-11-20 18:10:26 +) are available in the Git repository at: git://github.com/dagrh/qemu.git tags/pull-migration-20181121a for you to fe

[Qemu-devel] [PULL 1/2] migration/colo.c: Fix compilation issue when disable replication

2018-11-21 Thread Dr. David Alan Gilbert (git)
From: Zhang Chen This compilation issue will occur when user use --disable-replication to config Qemu. Reported-by: Thomas Huth Signed-off-by: Zhang Chen Message-Id: <20181101021226.6353-1-zhangc...@gmail.com> Tested-by: Thomas Huth Signed-off-by: Dr. David Alan Gilbert --- migration/colo.c

[Qemu-devel] [PULL 2/2] migration/migration.c: Add COLO dependency checks

2018-11-21 Thread Dr. David Alan Gilbert (git)
From: Zhang Chen Current COLO mode(independent disk mode) need replication module work together. Suggested by Dr. David Alan Gilbert . Signed-off-by: Zhang Chen Message-Id: <20181114190912.7242-1-chen.zh...@intel.com> Reviewed-by: Peter Xu Signed-off-by: Dr. David Alan Gilbert --- migration/

Re: [Qemu-devel] [PATCH] fmops: fix off-by-one in AR_TABLE and DR_TABLE array size

2018-11-21 Thread Gerd Hoffmann
On Wed, Nov 21, 2018 at 04:19:11PM +0530, P J P wrote: > Hello Gerd, > > +-- On Mon, 12 Nov 2018, Gerd Hoffmann wrote --+ > | On Tue, Oct 30, 2018 at 09:23:40AM +0100, Gerd Hoffmann wrote: > | > Fixes: CVE-2018-??? > | > Cc: P J P > | > | ping, do we have a cve number meanwhile? > > No, the of

[Qemu-devel] [PATCH v2] qapi: add query-display-options command

2018-11-21 Thread Gerd Hoffmann
Add query-display-options command, which allows querying the qemu display configuration, and -- as an intentional side effect -- makes DisplayOptions discoverable via query-qmp-schema so libvirt can go figure which display options are supported. Signed-off-by: Gerd Hoffmann Reviewed-by: Eric Blak

Re: [Qemu-devel] [PATCH v3 00/11] pci: hotplug handler reworks

2018-11-21 Thread Michael S. Tsirkin
On Wed, Nov 21, 2018 at 01:43:05PM +0100, David Hildenbrand wrote: > On 20.11.18 12:04, David Hildenbrand wrote: > > This series reworks some pci hotplug handlers (except for s390, that will > > require more work but is not required for now). > > > > 1. Route all unplug calls via the hotplug handl

Re: [Qemu-devel] [PATCH v1] tpm: check localities index

2018-11-21 Thread Stefan Berger
On 11/20/18 1:06 PM, P J P wrote: Hello Stefan, +-- On Tue, 20 Nov 2018, Stefan Berger wrote --+ | On 11/20/18 2:22 AM, P J P wrote: | > From: Prasad J Pandit | > | > While performing mmio device r/w operations, guest could set 'addr' | > parameter such that 'locty' index exceeds TPM_TIS_NUM

Re: [Qemu-devel] [PATCH v5 00/24] ACPI reorganization for hardware-reduced API addition

2018-11-21 Thread Samuel Ortiz
Hi Michael, On Wed, Nov 21, 2018 at 07:35:47AM -0500, Michael S. Tsirkin wrote: > On Mon, Nov 19, 2018 at 04:31:10PM +0100, Igor Mammedov wrote: > > On Fri, 16 Nov 2018 17:37:54 +0100 > > Paolo Bonzini wrote: > > > > > On 16/11/18 17:29, Igor Mammedov wrote: > > > > General suggestions for this

[Qemu-devel] [PATCH 1/1] Acceptance tests: add test for set-numa-node error handler fix

2018-11-21 Thread Cleber Rosa
Commit a22528b918 fixed an issue that is exposed by means of the "set-numa-node" QMP command (introduced in f3be67812). This adds a test that pretty much maps the steps documented on the fix. Additionally, given that 'set-numa-node' is only allowed in 'preconfig' state, a specific check for that

[Qemu-devel] [PATCH 0/1] Acceptance tests: add test for set-numa-node error handler fix

2018-11-21 Thread Cleber Rosa
This cover letter does nothing but provides hopefully useful references to reviewers. More information on the patch itself. Git Info: - URI: https://github.com/clebergnu/qemu/tree/sent/set-numa-node - Remote: https://github.com/clebergnu/qemu - Branch: sent/set-numa-node Travis CI Info:

Re: [Qemu-devel] [PATCH v5 00/24] ACPI reorganization for hardware-reduced API addition

2018-11-21 Thread Michael S. Tsirkin
On Wed, Nov 21, 2018 at 02:50:30PM +0100, Samuel Ortiz wrote: > Hi Michael, > > On Wed, Nov 21, 2018 at 07:35:47AM -0500, Michael S. Tsirkin wrote: > > On Mon, Nov 19, 2018 at 04:31:10PM +0100, Igor Mammedov wrote: > > > On Fri, 16 Nov 2018 17:37:54 +0100 > > > Paolo Bonzini wrote: > > > > > > >

Re: [Qemu-devel] [Qemu-ppc] [PATCH for 3.1] spapr: Fix ibm, max-associativity-domains property number of nodes

2018-11-21 Thread Greg Kurz
On Tue, 20 Nov 2018 20:58:45 +0200 Serhii Popovych wrote: > Greg Kurz wrote: > > On Mon, 19 Nov 2018 14:48:34 +0100 > > Laurent Vivier wrote: > > > >> On 19/11/2018 14:27, Greg Kurz wrote: > >>> On Mon, 19 Nov 2018 08:09:38 -0500 > >>> Serhii Popovych wrote: > >>> > Laurent Vivie

Re: [Qemu-devel] 3.1.0-rc{0,1} doesn't start

2018-11-21 Thread Paolo Bonzini
On 21/11/18 05:05, Bandan Das wrote: >> Oh, wait. I didn't understand that. Then yeah, fixing QEMU is enough. >> KVM is not reporting the MSR in the list on AMD, but it should (and it >> should implement the MSR, of course!). >> > Until AMD implements somethinig, on the KVM side, shouldn't we le

Re: [Qemu-devel] [PATCH v2 1/9] cutils: Add qemu_strtod() and qemu_strtod_finite()

2018-11-21 Thread Markus Armbruster
David Hildenbrand writes: > On 20.11.18 21:07, Markus Armbruster wrote: >> Eric Blake writes: >> >>> On 11/20/18 3:25 AM, David Hildenbrand wrote: Let's provide a wrapper for strtod(). Reviewed-by: Eric Blake >>> >>> This changed enough from v1 that I would have dropped R-b to e

Re: [Qemu-devel] [PATCH v2 5/9] test-string-input-visitor: Add more tests

2018-11-21 Thread Markus Armbruster
David Hildenbrand writes: > On 20.11.18 18:26, Eric Blake wrote: >> On 11/20/18 11:20 AM, Eric Blake wrote: >>> On 11/20/18 11:06 AM, Eric Blake wrote: On 11/20/18 3:25 AM, David Hildenbrand wrote: > Test that very big/small values are not accepted and that ranges with > only one ele

Re: [Qemu-devel] [PATCH v2 6/9] qapi: Rewrite string-input-visitor

2018-11-21 Thread Markus Armbruster
David Hildenbrand writes: > On 20.11.18 21:58, Markus Armbruster wrote: >> I think the title should be something like >> >> qapi: Rewrite string-input-visitor's integer and list parsing >> >> because you don't actually rewrite all of it. >> >> Eric Blake writes: >> >>> On 11/20/18 3:25 A

Re: [Qemu-devel] [PATCH v5 00/24] ACPI reorganization for hardware-reduced API addition

2018-11-21 Thread Igor Mammedov
On Wed, 21 Nov 2018 07:35:47 -0500 "Michael S. Tsirkin" wrote: > On Mon, Nov 19, 2018 at 04:31:10PM +0100, Igor Mammedov wrote: > > On Fri, 16 Nov 2018 17:37:54 +0100 > > Paolo Bonzini wrote: > > > > > On 16/11/18 17:29, Igor Mammedov wrote: > > > > General suggestions for this series: > >

Re: [Qemu-devel] [PATCH v2 2/9] cutils: Fix qemu_strtosz() & friends to reject non-finite sizes

2018-11-21 Thread Markus Armbruster
David Hildenbrand writes: > On 20.11.18 21:41, Eric Blake wrote: >> On 11/20/18 2:31 PM, Markus Armbruster wrote: >>> Eric Blake writes: >>> On 11/20/18 3:25 AM, David Hildenbrand wrote: > qemu_strtosz() & friends reject NaNs, but happily accept inifities. s/inifities/infiniti

Re: [Qemu-devel] [PATCH] scsi-disk: Fix crash if underlying host file or disk returns error.

2018-11-21 Thread Kevin Wolf
Am 21.11.2018 um 13:47 hat Richard W.M. Jones geschrieben: > Commit 40dce4ee6 "scsi-disk: fix rerror/werror=ignore" introduced a > bug which causes qemu to crash with the assertion error below if the > host file or disk returns an error: > > qemu-system-x86_64: hw/scsi/scsi-bus.c:1374: scsi_req_

Re: [Qemu-devel] [PATCH] net: tap: use qemu_set_nonblock

2018-11-21 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > On Wed, Nov 21, 2018 at 11:57:18AM +, Daniel P. Berrangé wrote: >> On Wed, Nov 21, 2018 at 03:28:29PM +0400, Marc-André Lureau wrote: >> > Hi >> > >> > On Wed, Nov 21, 2018 at 3:22 PM Li Qiang wrote: >> > > >> > > The fcntl will change the flags directly, use

Re: [Qemu-devel] [PATCH RESEND v15 08/10] target-arm: kvm64: inject synchronous External Abort

2018-11-21 Thread gengdongjiu
Hi Peter, Thanks for the review and comments. > > On 8 November 2018 at 10:29, Dongjiu Geng wrote: > > Add synchronous external abort injection logic, setup exception type > > and syndrome value. When switch to guest, guest will jump to the > > synchronous external abort vector table entry. >

Re: [Qemu-devel] [PATCH v5 00/24] ACPI reorganization for hardware-reduced API addition

2018-11-21 Thread Samuel Ortiz
Igor, On Wed, Nov 21, 2018 at 03:15:26PM +0100, Igor Mammedov wrote: > On Wed, 21 Nov 2018 07:35:47 -0500 > "Michael S. Tsirkin" wrote: > > > On Mon, Nov 19, 2018 at 04:31:10PM +0100, Igor Mammedov wrote: > > > On Fri, 16 Nov 2018 17:37:54 +0100 > > > Paolo Bonzini wrote: > > > > > > > On 16

Re: [Qemu-devel] [RFC v3 00/12] packed ring virtio-net userspace backend support

2018-11-21 Thread Tiwei Bie
Hi Wei, FYI, the latest packed ring series for guest driver doesn't set the _F_NEXT bit for indirect descriptors any more. So below hack in guest driver is needed to make it work with this series: diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c index cd7e755484e3..42faea7

Re: [Qemu-devel] [PATCH v5 05/24] hw: acpi: Implement XSDT support for RSDP

2018-11-21 Thread Samuel Ortiz
Hi Igor, On Thu, Nov 08, 2018 at 03:16:23PM +0100, Igor Mammedov wrote: > On Mon, 5 Nov 2018 02:40:28 +0100 > Samuel Ortiz wrote: > > > XSDT is the 64-bit version of the legacy ACPI RSDT (Root System > > Description Table). RSDT only allow for 32-bit addressses and have thus > > been deprecated

Re: [Qemu-devel] [PATCH v5 01/24] hw: i386: Decouple the ACPI build from the PC machine type

2018-11-21 Thread Samuel Ortiz
Hi Igor, On Fri, Nov 09, 2018 at 03:23:16PM +0100, Igor Mammedov wrote: > On Mon, 5 Nov 2018 02:40:24 +0100 > Samuel Ortiz wrote: > > > ACPI tables are platform and machine type and even architecture > > agnostic, and as such we want to provide an internal ACPI API that > > only depends on plat

Re: [Qemu-devel] [PATCH v5 02/24] hw: acpi: Export ACPI build alignment API

2018-11-21 Thread Samuel Ortiz
On Fri, Nov 09, 2018 at 03:27:16PM +0100, Igor Mammedov wrote: > On Mon, 5 Nov 2018 02:40:25 +0100 > Samuel Ortiz wrote: > > > This is going to be needed by the Hardware-reduced ACPI routines. > > > > Reviewed-by: Philippe Mathieu-Daudé > > Tested-by: Philippe Mathieu-Daudé > > Signed-off-by:

Re: [Qemu-devel] [PATCH v5 07/24] hw: acpi: Generalize AML build routines

2018-11-21 Thread Samuel Ortiz
Hi Igor, On Fri, Nov 09, 2018 at 02:37:33PM +0100, Igor Mammedov wrote: > On Mon, 5 Nov 2018 02:40:30 +0100 > Samuel Ortiz wrote: > > > From: Yang Zhong > > > > Most of the AML build routines under acpi-build are not even > > architecture specific. They can be moved to the more generic hw/acp

[Qemu-devel] [PATCH 07/18] xen: add event channel interface for XenDevice-s

2018-11-21 Thread Paul Durrant
The legacy PV backend infrastructure provides functions to bind, unbind and send notifications to event channnels. Similar functionality will be required by XenDevice implementations so this patch adds the necessary support. Signed-off-by: Paul Durrant --- Cc: Stefano Stabellini Cc: Anthony Pera

[Qemu-devel] [PATCH 08/18] xen: duplicate xen_disk.c as basis of dataplane/xen-qdisk.c

2018-11-21 Thread Paul Durrant
The new xen-qdisk XenDevice implementation requires the same core dataplane as the legacy xen_disk implementation it will eventually replace. This patch therefore copies the legacy xen_disk.c source module into a new dataplane/xen-qdisk.c source module as the basis for the new dataplane and adjusts

[Qemu-devel] [PATCH 03/18] xen: introduce 'xen-qdisk'

2018-11-21 Thread Paul Durrant
This patch adds a new XenDevice: 'xen-qdisk' [1]. This will eventually replace the 'xen_disk' legacy PV backend but it is illustrative to build up the implementation incrementally, along with the XenBus/XenDevice framework. Subsequent patches will therefore add to this device's implementation as ne

[Qemu-devel] [PATCH 00/18] Xen PV backend 'qdevification'

2018-11-21 Thread Paul Durrant
This series introduces a new QOM compliant framework for Xen PV backends. This is achieved by first moving the current non-compliant framework aside, before building up a new framework incrementally. This series was prompted by a thread [1] started by Kevin Wolf in response to patches against xen_

[Qemu-devel] [PATCH 01/18] xen: re-name XenDevice to XenLegacyDevice...

2018-11-21 Thread Paul Durrant
...and xen_backend.h to xen-legacy-backend.h Rather than attempting to convert the existing backend infrastructure to be QOM compliant (which would be hard to do in an incremental fashion), subsequent patches will introduce a completely new framework for Xen PV backends. Hence it is necessary to r

[Qemu-devel] [PATCH 09/18] xen: remove unnecessary code from dataplane/xen-qdisk.c

2018-11-21 Thread Paul Durrant
Not all of the code duplicated from xen_disk.c is required as the basis for the new dataplane implementation so this patch removes extraneous code, along with the legacy #includes and calls to the legacy xen_pv_printf() function. Error messages are changed to be reported using error_report(). NOTE

[Qemu-devel] [PATCH 06/18] xen: add grant table interface for XenDevice-s

2018-11-21 Thread Paul Durrant
The legacy PV backend infrastructure provides functions to map, unmap and copy pages granted by frontends. Similar functionality will be required by XenDevice implementations so this patch adds the necessary support. Signed-off-by: Paul Durrant --- Cc: Stefano Stabellini Cc: Anthony Perard ---

[Qemu-devel] [PATCH 02/18] xen: introduce new 'XenBus' and 'XenDevice' object hierarchy

2018-11-21 Thread Paul Durrant
This patch adds the basic boilerplate for a 'XenBus' object that will act as a parent to 'XenDevice' PV backends. A new 'XenBridge' object is also added to connect XenBus to the system bus. The XenBus object is instantiated by a new xen_bus_init() function called from the same sites as the legacy

[Qemu-devel] [PATCH 05/18] xen: add xenstore watcher infratructure

2018-11-21 Thread Paul Durrant
A Xen PV frontend communicates its state to the PV backend by writing to the 'state' key in the frontend area in xenstore. It is therefore necessary for a XenDevice implementation to be notified whenever the value of this key changes. This patch adds code to do this as follows: - an 'fd handler'

[Qemu-devel] [PATCH 04/18] xen: create xenstore areas for XenDevice-s

2018-11-21 Thread Paul Durrant
This patch adds a new source module, xen-bus-helper.c, which builds on basic libxenstore primitives to provide functions to create (setting permissions appropriately) and destroy xenstore areas, and functions to 'printf' and 'scanf' nodes therein. The main xen-bus code then uses these primitives [1

Re: [Qemu-devel] [PATCH] Fix for crashes and non-responsive UI on macOS Mojave

2018-11-21 Thread Peter Maydell
(Hi Gerd -- I have a question at the bottom of this email about the thread/locking semantics of the UI midlayer...) On 20 November 2018 at 12:59, Peter Maydell wrote: > On 11 November 2018 at 21:24, Berkus Decker wrote: >> It seems that Cocoa checks are stricter on Mojave and some callbacks that

[Qemu-devel] [PATCH 13/18] xen: purge 'blk' and 'ioreq' from function names in dataplane/xen-qdisk.c

2018-11-21 Thread Paul Durrant
This is a purely cosmetic patch that purges remaining use of 'blk' and 'ioreq' in local function names. No functional change. Signed-off-by: Paul Durrant --- Cc: Stefano Stabellini Cc: Anthony Perard Cc: Stefan Hajnoczi Cc: Kevin Wolf Cc: Max Reitz --- hw/block/dataplane/xen-qdisk.c | 86 +

[Qemu-devel] [PATCH 16/18] xen: automatically create XenQdiskDevice-s

2018-11-21 Thread Paul Durrant
This patch adds a creator function for XenQdiskDevice-s so that they can be created automatically when the Xen toolstack instantiates a new PV backend. When the XenQdiskDevice is created this way it is also necessary to create a drive which matches the configuration that the Xen toolstack has writt

[Qemu-devel] [PATCH 12/18] xen: remove 'ioreq' struct/varable/field names from dataplane/xen-qdisk.c

2018-11-21 Thread Paul Durrant
This is a purely cosmetic patch that purges the name 'ioreq' from struct, variable and field names. (This name has been problematic for a long time as 'ioreq' is the name used for generic I/O requests coming from Xen). The patch replaces 'struct ioreq' with a new 'XenQdiskRequest' type and 'ioreq'

[Qemu-devel] [PATCH 11/18] xen: remove 'XenBlkDev' and 'blkdev' names from dataplane/xen-qdisk

2018-11-21 Thread Paul Durrant
This is a purely cosmetic patch that substitutes the old 'struct XenBlkDev' name with 'XenQdiskDataPlane' and 'blkdev' field/variable names with 'dataplane', and then does necessary fix-up to adhere to coding style. No functional change. Signed-off-by: Paul Durrant --- Cc: Stefano Stabellini Cc

[Qemu-devel] [PATCH 14/18] xen: add implementations of xen-qdisk connect and disconnect functions...

2018-11-21 Thread Paul Durrant
...and wire in the dataplane. This patch adds the remaining code to make the xen-qdisk XenDevice functional. The parameters that a block frontend expects to find are populated in the backend xenstore area, and the 'ring-ref' and 'event-channel' values specified in the frontend xenstore area are ma

[Qemu-devel] [PATCH 17/18] MAINTAINERS: add myself as a Xen maintainer

2018-11-21 Thread Paul Durrant
I have made many significant contributions to the Xen code in QEMU, particularly the recent patches introducing a new PV device framework. I intend to make further significant contributions, porting other PV back- ends to the new framework with the intent of eventually removing the legacy code. It

[Qemu-devel] [PATCH 15/18] xen: add a mechanism to automatically create XenDevice-s...

2018-11-21 Thread Paul Durrant
...that maintains compatibility with existing Xen toolstacks. Xen toolstacks instantiate PV backends by simply writing information into xenstore and expecting a backend implementation to be watching for this. This patch adds a new 'xen-backend' module to allow individual XenDevice implementations

[Qemu-devel] [PATCH 18/18] xen: remove the legacy 'xen_disk' backend

2018-11-21 Thread Paul Durrant
This backend has now been replaced by the 'xen-qdisk' XenDevice. Signed-off-by: Paul Durrant --- Cc: Kevin Wolf Cc: Max Reitz --- hw/block/Makefile.objs |1 - hw/block/xen_disk.c| 1011 2 files changed, 1012 deletions(-) delete mode 100

[Qemu-devel] [PATCH 10/18] xen: add header and build dataplane/xen-qdisk.c

2018-11-21 Thread Paul Durrant
This patch adds the transformations necessary to get dataplane/xen-qdisk.c to build against the new XenBus/XenDevice framework. MAINTAINERS is also updated due to the introduction of dataplane/xen-qdisk.h. NOTE: Existing data structure names are retained for the moment. These will be modifie

[Qemu-devel] [PATCH] MAINTAINERS: Update email address for Fam Zheng

2018-11-21 Thread Fam Zheng
Since I am about to change company, update the email address in MAINTAINERS to my personal one. Depending on responsibility changes I may eventually fade out in some of the maintained areas, but that will be figured out afterward, or maybe I'll use the work email later. For now, just do a search an

[Qemu-devel] [ANNOUNCE] QEMU 3.1.0-rc2 is now available

2018-11-21 Thread Michael Roth
Hello, On behalf of the QEMU Team, I'd like to announce the availability of the third release candidate for the QEMU 3.1 release. This release is meant for testing purposes and should not be used in a production environment. http://download.qemu-project.org/qemu-3.1.0-rc2.tar.xz http://downl

Re: [Qemu-devel] [PATCH v1] tpm: check localities index

2018-11-21 Thread Stefan Berger
On 11/20/18 2:22 AM, P J P wrote: From: Prasad J Pandit While performing mmio device r/w operations, guest could set 'addr' parameter such that 'locty' index exceeds TPM_TIS_NUM_LOCALITIES=5 after setting new 'locty' via 'tpm_tis_new_active_locality'. Add check to avoid OOB access. Reported-by

Re: [Qemu-devel] [PATCH v5 10/24] hw: acpi: Export the PCI host and holes getters

2018-11-21 Thread Samuel Ortiz
On Tue, Nov 13, 2018 at 04:59:18PM +0100, Igor Mammedov wrote: > On Mon, 5 Nov 2018 02:40:33 +0100 > Samuel Ortiz wrote: > > > This is going to be needed by the hardware reduced implementation, so > > let's export it. > > Once the ACPI builder methods and getters will be implemented, the > > acp

Re: [Qemu-devel] [PATCH 1/1] Acceptance tests: add test for set-numa-node error handler fix

2018-11-21 Thread Markus Armbruster
Cleber Rosa writes: > Commit a22528b918 fixed an issue that is exposed by means of the > "set-numa-node" QMP command (introduced in f3be67812). This adds a > test that pretty much maps the steps documented on the fix. > > Additionally, given that 'set-numa-node' is only allowed in > 'preconfig'

  1   2   3   4   >