On 11/16/18 10:51 AM, Edgar E. Iglesias wrote:
> On Thu, Nov 15, 2018 at 10:41:55AM +0100, Luc Michel wrote:
>> Add a couple of helper functions to cope with GDB threads and processes.
>>
>> The gdb_get_process() function looks for a process given a pid.
>>
>> The gdb_get_cpu() function returns
On Fri 16 Nov 2018 05:45:24 PM CET, Max Reitz wrote:
> bdrv_reopen_multiple() does not invoke bdrv_reopen_abort() for the
> element of the reopen queue for which bdrv_reopen_prepare() failed,
> because it assumes that the prepare function will have rolled back all
> changes already.
>
> However, bd
Hi,
> I'm investigating the SeaBIOS booting time, to understand if we can
> reduce the boot time in some cases (e.g. legacy hardware is not
> needed). I think this can be interesting also for NEMU developers.
> The goal is to have only one image of SeaBIOS configurable at runtime
> to reduce th
On Fri 16 Nov 2018 05:45:26 PM CET, Max Reitz wrote:
> Signed-off-by: Max Reitz
Reviewed-by: Alberto Garcia
Berto
Hi Samuel,
On Mon, Nov 19, 2018 at 12:31 AM Samuel Ortiz wrote:
> Hi Stefano,
>
> On Fri, Nov 16, 2018 at 05:13:59PM +0100, Stefano Garzarella wrote:
> > Hi,
> > I'm investigating the SeaBIOS booting time, to understand if we can
> reduce
> > the boot time in some cases (e.g. legacy hardware is
create_opts was leaked here. This is not too bad since the process is
about to exit anyway, but relying on that does not make the code nicer
to read.
Fixes: d402b6a21a825a5c07aac9251990860723d49f5d
Reported-by: Kevin Wolf
Cc: qemu-sta...@nongnu.org
Signed-off-by: Max Reitz
---
qemu-img.c | 1 +
One of the amend error paths has two issues that are fixed by this
series. Since they are relatively minor and have been present in 3.0
already, I think there is no need to get them into 3.1. OTOH they are
bug fixes, so they could go into 3.1 if you, dear reader, insist.
Max Reitz (2):
qemu-i
Fixes: d402b6a21a825a5c07aac9251990860723d49f5d
Reported-by: Kevin Wolf
Cc: qemu-sta...@nongnu.org
Signed-off-by: Max Reitz
---
qemu-img.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qemu-img.c b/qemu-img.c
index 13a6ca31b4..a9a2470e1a 100644
--- a/qemu-img.c
+++ b/qemu-i
On 11/16/18 11:04 AM, Edgar E. Iglesias wrote:
> On Thu, Nov 15, 2018 at 10:41:58AM +0100, Luc Michel wrote:
>> Change the thread info related packets handling to support multiprocess
>> extension.
>>
>> Add the CPUs class name in the extra info to help differentiate
>> them in multiprocess mode
On Fri, Nov 16, 2018 at 03:43:16PM -0600, Eric Blake wrote:
> On 11/16/18 3:41 PM, Eric Blake wrote:
>
> > > +#!/bin/bash
> >
> > I know we're using bash,
> >
> > > +
> > > +function nbd_server_stop()
> > > +{
> >
> > > +function nbd_server_wait_for_unix_socket()
> >
> > and bash supports 'fun
On Sat, Nov 17, 2018 at 08:19:10PM -0600, Eric Blake wrote:
> On 11/16/18 9:53 AM, Daniel P. Berrangé wrote:
> > When sending a NBD_CMD_DISC message there is no reply expected,
> > however, the nbd_read_eof() coroutine is still waiting for a reply.
> > In a plain NBD connection this doesn't matter
On 16 November 2018 at 21:30, Palmer Dabbelt wrote:
> The following changes since commit cb968d275c145467c8b385a3618a207ec111eab1:
>
> Update version for v3.1.0-rc1 release (2018-11-13 18:16:14 +)
>
> are available in the Git repository at:
>
> git://github.com/riscv/riscv-qemu.git tags/ri
On Fri 16 Nov 2018 05:45:25 PM CET, Max Reitz wrote:
> s->locked_shared_perm is the set of bits locked in the file, which is
> the inverse of the permissions actually shared. So we need to pass them
> as they are to raw_apply_lock_bytes() instead of inverting them again.
>
> Reported-by: Alberto
On Fri, Nov 16, 2018 at 10:39:03AM -0600, Eric Blake wrote:
> On 11/16/18 9:53 AM, Daniel P. Berrangé wrote:
> > Add helpers to common.tls for creating TLS certificates for a CA,
> > server and client.
>
> MUCH appreciated! We NEED this coverage, easily automated.
>
> >
> > Signed-off-by: Danie
On Sat, Nov 17, 2018 at 09:01:57PM -0600, Eric Blake wrote:
> On 11/16/18 9:53 AM, Daniel P. Berrangé wrote:
> > The helpers for starting/stopping qemu-nbd in 058 will be useful in
> > other test cases, so move them into a common.nbd file.
> >
> > Signed-off-by: Daniel P. Berrangé
> > ---
>
> >
On Fri, Nov 16, 2018 at 10:24:54AM -0600, Eric Blake wrote:
> On 11/16/18 9:53 AM, Daniel P. Berrangé wrote:
> > If the qemu-nbd UNIX socket has not shown up, the tests will sleep a bit
> > and then check again repeatedly for upto 30 seconds. This is pointless
>
> s/upto/up to/
>
> > if the qemu-
On Sun, Nov 18, 2018 at 9:33 PM Philippe Mathieu-Daudé wrote:
>
> This image is based on Gentoo and the toolchain is built using crossdev.
>
> Recipe from:
> https://lists.gnu.org/archive/html/qemu-devel/2018-09/msg03944.html
>
> Suggested-by: Fredrik Noring
> Signed-off-by: Philippe Mathieu-Da
On Fri, Nov 16, 2018 at 11:20:26AM -0600, Eric Blake wrote:
> On 11/16/18 9:53 AM, Daniel P. Berrangé wrote:
> > Add tests that validate it is possible to connect to an NBD server
> > running TLS mode. Also test mis-matched TLS vs non-TLS connections
> > correctly fail.
> > ---
> > tests/qemu-iot
On Sat, Nov 17, 2018 at 03:31:34PM -0600, Eric Blake wrote:
> On 11/16/18 11:20 AM, Eric Blake wrote:
> > On 11/16/18 9:53 AM, Daniel P. Berrangé wrote:
> > > Add tests that validate it is possible to connect to an NBD server
> > > running TLS mode. Also test mis-matched TLS vs non-TLS connections
On Sat, Nov 17, 2018 at 04:32:21PM -0600, Eric Blake wrote:
> Commit 37ec36f6 intentionally ignores errors when trying to reply
> to an NBD_OPT_ABORT request for plaintext clients, but did not make
> the same change for a TLS server. Since NBD_OPT_ABORT is
> documented as being a potential for an
On Sat, Nov 17, 2018 at 02:49:22PM -0600, Eric Blake wrote:
> On 11/16/18 9:53 AM, Daniel P. Berrangé wrote:
> > Add tests that validate it is possible to connect to an NBD server
> > running TLS mode. Also test mis-matched TLS vs non-TLS connections
> > correctly fail.
> > ---
>
> Missing your Si
On Fri, 16 Nov 2018 01:45:51 -0200
Eduardo Habkost wrote:
> On Thu, Nov 15, 2018 at 05:29:24PM +0100, Andrea Bolognani wrote:
> > One thing that I'm very much not convinced about is the naming,
> > specifically leaving the virtio revision out: I get it that we
> > Should Never Need™ another majo
On Sat, Nov 17, 2018 at 08:24:03PM -0600, Eric Blake wrote:
> Enhance test 233 to also perform I/O beyond the initial handshake.
>
> Signed-off-by: Eric Blake
> ---
>
> Depends on my tweak to 2/6 to suppress an EIO error message
> on a failed read after NBD_CMD_DISC.
>
> tests/qemu-iotests/233
On Mon, Nov 19, 2018 at 9:49 AM Gerd Hoffmann wrote:
> Hi,
>
> > I'm investigating the SeaBIOS booting time, to understand if we can
> > reduce the boot time in some cases (e.g. legacy hardware is not
> > needed). I think this can be interesting also for NEMU developers.
>
> > The goal is to ha
On Fri, Nov 16, 2018 at 02:00:16PM -0600, Eric Blake wrote:
> Adding a new qapi module had some rather tedious repetition to
> wire it into Makefile, Makefile.objs, and .gitignore (for example,
> see commit bf42508f and its followup b61acdec). For make, add some
> indirection by taking advantage of
Hi Seth,
On Mon, Nov 19, 2018 at 4:17 AM Seth K wrote:
>
> From: Seth Kintigh
>
> I corrected these 2 memory regions based on specifications from the chip
> manufacturer. The existing ranges seem to overlap and and cause odd
> behavior and/or crashes when trying to set up multiple UARTs,
>
> Sig
On Fri, Nov 16, 2018 at 03:50:02PM -0600, Eric Blake wrote:
> Bash allows functions to be declared with or without the leading
> keyword 'function'; but including the keyword does not comply with
> POSIX syntax, and is confusing to ksh users where the use of the
> keyword changes the scoping rules
cc'ing in Paolo, Eduardo and Robert
* baldu...@units.it (baldu...@units.it) wrote:
> hello
>
> I'm building qemu from source and happily using it since a bit
> (2.3.0)
>
> Since 3.1.0-rc0 (including latest 3.1.0-rc1) I'm no more able to start
> qemu, getting:
>
> 8<
> install:11
On Fri, 16 Nov 2018 at 19:29, Peter Maydell wrote:
>
> On 16 November 2018 at 10:46, Hongbo Zhang wrote:
> > On Fri, 16 Nov 2018 at 00:05, Peter Maydell
> > wrote:
> >> If after you've done that this patch is still more than
> >> about 500 lines long, I would recommend that you split it
> >> up
On Mon, 19 Nov 2018 at 18:49, Hongbo Zhang wrote:
>
> On Fri, 16 Nov 2018 at 19:29, Peter Maydell wrote:
> >
> > On 16 November 2018 at 10:46, Hongbo Zhang wrote:
> > > On Fri, 16 Nov 2018 at 00:05, Peter Maydell
> > > wrote:
> > >> If after you've done that this patch is still more than
> > >
On 16/11/18 22:50, Eric Blake wrote:
Bash allows functions to be declared with or without the leading
keyword 'function'; but including the keyword does not comply with
POSIX syntax, and is confusing to ksh users where the use of the
keyword changes the scoping rules for functions. Stick to the
On 19.11.18 11:27, Daniel P. Berrangé wrote:
> On Fri, Nov 16, 2018 at 10:39:03AM -0600, Eric Blake wrote:
>> On 11/16/18 9:53 AM, Daniel P. Berrangé wrote:
>>> Add helpers to common.tls for creating TLS certificates for a CA,
>>> server and client.
>>
>> MUCH appreciated! We NEED this coverage, e
Signed-off-by: Cornelia Huck
---
hw/s390x/s390-virtio-ccw.c | 17 -
include/hw/compat.h| 3 +++
2 files changed, 19 insertions(+), 1 deletion(-)
diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c
index a0615a8b35..fd9d0b0542 100644
--- a/hw/s390x/s390-v
On 19 November 2018 at 10:43, Philippe Mathieu-Daudé wrote:
> Hi Seth,
>
> On Mon, Nov 19, 2018 at 4:17 AM Seth K wrote:
>>
>> From: Seth Kintigh
>>
>> I corrected these 2 memory regions based on specifications from the chip
>> manufacturer. The existing ranges seem to overlap and and cause odd
From: Prasad J Pandit
The length parameter values are not negative, thus use an unsigned
type 'size_t' for them. Many routines pass 'len' values to memcpy(3)
calls. If it was negative, it could lead to memory corruption issues.
Add check to avoid it.
Reported-by: Arash TC
Signed-off-by: Prasad
+-- On Tue, 6 Nov 2018, Philippe Mathieu-Daudé wrote --+
| > @@ -113,6 +113,7 @@ static void vhci_host_send(void *opaque,
| > static uint8_t buf[4096];
| >
| > buf[0] = type;
| > +assert(len <= sizeof(buf) - 1);
|
| Why not simply "assert(len < sizeof(buf));"?
| > for (;;
On 17 November 2018 at 18:38, Aleksandar Markovic
wrote:
> From: Aleksandar Markovic
>
> The following changes since commit 83c496599cc04926ecbc3e47a37debaa3e38b686:
>
> Merge remote-tracking branch
> 'remotes/kraxel/tags/fixes-31-20181116-pull-request' into staging (2018-11-16
> 13:53:01 +00
On 16 November 2018 at 15:33, Cornelia Huck wrote:
> On Fri, 16 Nov 2018 09:23:27 -0600
> Eric Blake wrote:
>
>> On 11/16/18 9:14 AM, Cornelia Huck wrote:
>
>> +++ b/MAINTAINERS
>> @@ -12,9 +12,14 @@ consult qemu-devel and not any specific individual
>> privately.
>> Descr
On Mon, Nov 19, 2018 at 12:08 PM Peter Maydell wrote:
> On 19 November 2018 at 10:43, Philippe Mathieu-Daudé wrote:
> > Hi Seth,
> >
> > On Mon, Nov 19, 2018 at 4:17 AM Seth K wrote:
> >>
> >> From: Seth Kintigh
> >>
> >> I corrected these 2 memory regions based on specifications from the chip
16.11.2018 17:29, Stefan Hajnoczi wrote:
> On Tue, Oct 16, 2018 at 04:20:18PM +0300, Vladimir Sementsov-Ogievskiy wrote:
>> Theoretically possible that we finish the skipping loop with bs = NULL
>> and the following code will crash trying to dereference it. Fix that.
>>
>> Signed-off-by: Vladimir S
Am 18.11.2018 um 13:32 hat Mark Cave-Ayland geschrieben:
> On 13/11/2018 20:29, John Snow wrote:
>
> > On 11/13/18 8:16 AM, Kevin Wolf wrote:
> >> Am 12.11.2018 um 20:58 hat John Snow geschrieben:
> >>>
> >>>
> >>> On 11/11/18 4:40 AM, Mark Cave-Ayland wrote:
> Commit c8a35f1cf0f "fdc: use Is
Am 17.11.2018 um 21:59 hat Nir Soffer geschrieben:
> On Fri, Nov 16, 2018 at 5:26 PM Kevin Wolf wrote:
>
> > Am 15.11.2018 um 23:27 hat Nir Soffer geschrieben:
> > > On Sun, Nov 11, 2018 at 6:11 PM Nir Soffer wrote:
> > >
> > > > On Wed, Nov 7, 2018 at 7:55 PM Nir Soffer wrote:
> > > >
> > > >>
Use DeviceClass rather than SysBusDeviceClass in
milkymist_softusb_class_init().
Cc: mich...@walle.cc
Signed-off-by: Mao Zhongyi
Signed-off-by: Zhang Shengju
---
hw/input/milkymist-softusb.c | 15 ++-
1 file changed, 6 insertions(+), 9 deletions(-)
diff --git a/hw/input/milkymist-
Use DeviceClass rather than SysBusDeviceClass in
pl050_class_init().
Cc: peter.mayd...@linaro.org
Cc: qemu-...@nongnu.org
Signed-off-by: Mao Zhongyi
Signed-off-by: Zhang Shengju
---
hw/input/pl050.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/hw/input/pl050.c
Use DeviceClass rather than SysBusDeviceClass in
puv3_dma_class_init().
Cc: g...@mprc.pku.edu.cn
Signed-off-by: Mao Zhongyi
Signed-off-by: Zhang Shengju
---
hw/dma/puv3_dma.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/hw/dma/puv3_dma.c b/hw/dma/puv3_dma.c
in
Use DeviceClass rather than SysBusDeviceClass in
milkymist_hpdmc_class_init().
Cc: g...@mprc.pku.edu.cn
Cc: mich...@walle.cc
Signed-off-by: Mao Zhongyi
Signed-off-by: Zhang Shengju
---
hw/intc/puv3_intc.c | 1 +
hw/misc/milkymist-hpdmc.c | 9 +++--
2 files changed, 4 insertions(+), 6
Use DeviceClass rather than SysBusDeviceClass in
pci_dec_21154_device_class_init().
Cc: da...@gibson.dropbear.id.au
Cc: m...@redhat.com
Cc: marcel.apfelb...@gmail.com
Cc: qemu-...@nongnu.org
Signed-off-by: Mao Zhongyi
Signed-off-by: Zhang Shengju
---
hw/pci-bridge/dec.c | 11 +--
1 fil
Use DeviceClass rather than SysBusDeviceClass in
onenand_class_init().
Cc: kw...@redhat.com
Cc: mre...@redhat.com
Cc: qemu-bl...@nongnu.org
Signed-off-by: Mao Zhongyi
Signed-off-by: Zhang Shengju
---
hw/block/onenand.c | 19 ---
1 file changed, 8 insertions(+), 11 deletions(-)
Currently, all sysbus devices have been converted to realize(),
so remove this path.
Cc: ehabk...@redhat.com
Cc: th...@redhat.com
Cc: pbonz...@redhat.com
Cc: arm...@redhat.com
Cc: peter.mayd...@linaro.org
Cc: richard.hender...@linaro.org
Cc: alistair.fran...@wdc.com
Signed-off-by: Mao Zhongyi
Si
Use DeviceClass rather than SysBusDeviceClass in
empty_slot_class_init().
Signed-off-by: Mao Zhongyi
Signed-off-by: Zhang Shengju
---
hw/core/empty_slot.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/hw/core/empty_slot.c b/hw/core/empty_slot.c
index c1b9c2b104..2
Use DeviceClass rather than SysBusDeviceClass in
milkymist_pfpu_class_init().
Cc: mich...@walle.cc
Signed-off-by: Mao Zhongyi
Signed-off-by: Zhang Shengju
---
hw/misc/milkymist-pfpu.c | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/hw/misc/milkymist-pfpu.c b/hw/
Use DeviceClass rather than SysBusDeviceClass in
xen_sysdev_class_init().
Cc: sstabell...@kernel.org
Cc: anthony.per...@citrix.com
Cc: xen-de...@lists.xenproject.org
Signed-off-by: Mao Zhongyi
Signed-off-by: Zhang Shengju
---
hw/xen/xen_backend.c | 6 ++
1 file changed, 2 insertions(+), 4
Use DeviceClass rather than SysBusDeviceClass in
grlib_gptimer_class_init().
Cc: chout...@adacore.com
Signed-off-by: Mao Zhongyi
Signed-off-by: Zhang Shengju
---
hw/timer/grlib_gptimer.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/hw/timer/grlib_gptimer.c b/h
The SysBusDeviceClass::init() interface is considered
as a legacy interface and there are currently some
efforts going on to get rid of it. Thus convert
SysBusDeviceClass::init to DeviceClass::realize.
Cc: alistair.fran...@wdc.com
Cc: anthony.per...@citrix.com
Cc: arm...@redhat.com
Cc: borntrae..
Use DeviceClass rather than SysBusDeviceClass in
nvram_sysbus_class_init().
Cc: pbonz...@redhat.com
Cc: marcandre.lur...@redhat.com
Signed-off-by: Mao Zhongyi
Signed-off-by: Zhang Shengju
---
hw/nvram/ds1225y.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/hw
Use DeviceClass rather than SysBusDeviceClass in
etraxfs_timer_class_init().
Cc: edgar.igles...@gmail.com
Signed-off-by: Mao Zhongyi
Signed-off-by: Zhang Shengju
---
hw/timer/etraxfs_timer.c | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/hw/timer/etraxfs_time
Most of the SysBusDeviceClass variables are named sbc,
and sbdc here is a bit weird, so changing sbdc to keep
it consistent with others might look good.
Cc: coh...@redhat.com
Cc: borntrae...@de.ibm.com
Cc: r...@twiddle.net
Cc: da...@redhat.com
Cc: qemu-s3...@nongnu.org
Signed-off-by: Mao Zhongyi
Use DeviceClass rather than SysBusDeviceClass in
puv3_gpio_class_init().
Cc: g...@mprc.pku.edu.cn
Signed-off-by: Mao Zhongyi
Signed-off-by: Zhang Shengju
---
hw/gpio/puv3_gpio.c | 28 +---
1 file changed, 13 insertions(+), 15 deletions(-)
diff --git a/hw/gpio/puv3_gpio
Use DeviceClass rather than SysBusDeviceClass in
puv3_intc_class_init().
Cc: g...@mprc.pku.edu.cn
Signed-off-by: Mao Zhongyi
Signed-off-by: Zhang Shengju
---
hw/intc/puv3_intc.c | 14 +-
1 file changed, 5 insertions(+), 9 deletions(-)
diff --git a/hw/intc/puv3_intc.c b/hw/intc/puv
Philippe Mathieu-Daudé writes:
> This image is based on Gentoo and the toolchain is built using crossdev.
>
> Recipe from:
> https://lists.gnu.org/archive/html/qemu-devel/2018-09/msg03944.html
>
> Suggested-by: Fredrik Noring
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> TODO:
> - Add Fre
Use DeviceClass rather than SysBusDeviceClass in
mv88w8618_wlan_class_init().
Cc: jan.kis...@web.de
Cc: peter.mayd...@linaro.org
Cc: qemu-...@nongnu.org
Signed-off-by: Mao Zhongyi
Signed-off-by: Zhang Shengju
---
hw/arm/musicpal.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
Use DeviceClass rather than SysBusDeviceClass in
grlib_apbuart_class_init().
Cc: chout...@adacore.com
Cc: marcandre.lur...@redhat.com
Cc: pbonz...@redhat.com
Signed-off-by: Mao Zhongyi
Signed-off-by: Zhang Shengju
---
hw/char/grlib_apbuart.c | 11 ---
1 file changed, 4 insertions(+), 7
Use DeviceClass rather than SysBusDeviceClass in
puv3_pm_class_init().
Cc: g...@mprc.pku.edu.cn
Signed-off-by: Mao Zhongyi
Signed-off-by: Zhang Shengju
---
hw/misc/puv3_pm.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/hw/misc/puv3_pm.c b/hw/misc/puv3_pm.c
ind
Use DeviceClass rather than SysBusDeviceClass in
tusb6010_class_init().
Cc: kra...@redhat.com
Signed-off-by: Mao Zhongyi
Signed-off-by: Zhang Shengju
---
hw/usb/tusb6010.c | 13 +
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/hw/usb/tusb6010.c b/hw/usb/tusb6010.c
in
Use DeviceClass rather than SysBusDeviceClass in
g364fb_sysbus_class_init().
Cc: pbonz...@redhat.com
Cc: kra...@redhat.com
Cc: f4...@amsat.org
Cc: alistair.fran...@wdc.com
Signed-off-by: Mao Zhongyi
Signed-off-by: Zhang Shengju
---
hw/display/g364fb.c | 14 +-
1 file changed, 5 ins
Use DeviceClass rather than SysBusDeviceClass in
puv3_ost_class_init().
Cc: g...@mprc.pku.edu.cn
Signed-off-by: Mao Zhongyi
Signed-off-by: Zhang Shengju
---
hw/timer/puv3_ost.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/hw/timer/puv3_ost.c b/hw/timer/puv3_
On Mon, 19 Nov 2018 20:08:19 +0800
Mao Zhongyi wrote:
> Most of the SysBusDeviceClass variables are named sbc,
> and sbdc here is a bit weird, so changing sbdc to keep
> it consistent with others might look good.
A quick git grep also gives sbd and k as variable names, and it is used
in a total
On Mon, 19 Nov 2018 20:07:58 +0800
Mao Zhongyi wrote:
> The SysBusDeviceClass::init() interface is considered
> as a legacy interface and there are currently some
> efforts going on to get rid of it. Thus convert
> SysBusDeviceClass::init to DeviceClass::realize.
In case my comment to the s390
On Fri, Nov 16, 2018 at 02:04:07PM -0800, Ard Biesheuvel wrote:
> > > > What is this using the exynos4210 USB device for? That
> > > > is definitely not correct for a generic board.
> > > >
> > > Checked the code:
> > > #define TYPE_SYS_BUS_EHCI "sysbus-ehci-usb"
> > > #define TYPE_EXYNOS4210_EHCI
hi
thanks for taking the time to reply
Dr. David Alan Gilbert writes:
> > I suspect that this might be some problem on my side, as I couldn't
> > find any similar report (apart some old (qemu-2.8.50) threads, that
> > didn't help)
>
> Not necessarily; can you tell me:
> a) At what point does it
On Mon, Nov 12, 2018 at 04:42:10PM -0500, Steffen Görtz wrote:
> This series contains additional peripheral devices for the nRF51822
> microcontroller.
Hi Steffen,
I have finished reviewing this revision, please feel free to send the
next revision addressing comments. It's getting very close and
On Mon, Nov 19, 2018 at 11:42:28AM +0100, Stefano Garzarella wrote:
> On Mon, Nov 19, 2018 at 9:49 AM Gerd Hoffmann wrote:
>
> > Hi,
> >
> > > I'm investigating the SeaBIOS booting time, to understand if we can
> > > reduce the boot time in some cases (e.g. legacy hardware is not
> > > needed).
Laurent Vivier reported off by one with maximum number of NUMA nodes
provided by qemu-kvm being less by one than required according to
description of "ibm,max-associativity-domains" property in LoPAPR.
It appears that I incorrectly treated LoPAPR description of this
property assuming it provides l
On 11/16/18 7:29 AM, Gerd Hoffmann wrote:
From: Erik Skultety
Unlike SPICE, egl-headless doesn't offer a way of specifying the DRM
node used for OpenGL, hence QEMU always selecting the first one that is
available. Thus, add the 'rendernode' option for egl-headless to QAPI.
Signed-off-by: Erik
Eric Blake writes:
> Adding a new qapi module had some rather tedious repetition to
> wire it into Makefile, Makefile.objs, and .gitignore (for example,
> see commit bf42508f and its followup b61acdec). For make, add some
> indirection by taking advantage of GNU Make string processing to
> expand
>Hi Peng,
>
>On 11/17/18 8:22 PM, Peng Hao wrote:
>> In match function it should not call OBJECK_CHECK. When there is
>> a mismatch, we should continue to match rather than assert().
>
>Normally this issue should have been fixed by
>e9ac8e84f0 "hw/arm/sysbus-fdt: Only call match_fn callback if the
On Mon, 19 Nov 2018 08:09:38 -0500
Serhii Popovych wrote:
> Laurent Vivier reported off by one with maximum number of NUMA nodes
> provided by qemu-kvm being less by one than required according to
> description of "ibm,max-associativity-domains" property in LoPAPR.
>
> It appears that I incorrec
On 19/11/2018 14:27, Greg Kurz wrote:
> On Mon, 19 Nov 2018 08:09:38 -0500
> Serhii Popovych wrote:
>
>> Laurent Vivier reported off by one with maximum number of NUMA nodes
>> provided by qemu-kvm being less by one than required according to
>> description of "ibm,max-associativity-domains" prop
On Mon, Nov 19, 2018 at 07:10:21AM -0600, Eric Blake wrote:
> On 11/16/18 7:29 AM, Gerd Hoffmann wrote:
> > From: Erik Skultety
> >
> > Unlike SPICE, egl-headless doesn't offer a way of specifying the DRM
> > node used for OpenGL, hence QEMU always selecting the first one that is
> > available. Th
Am 16.11.2018 um 17:45 hat Max Reitz geschrieben:
> These are fixes for issues I found when looking after something Berto
> has reported. The second patch fixes that issue Berto found, the first
> one is only kind of related.
>
> For the first patch: bdrv_reopen_abort() or bdrv_reopen_commit() a
GNUTLS takes a paranoid approach when seeing 0 bytes returned by the
underlying OS read() function. It will consider this an error and
return GNUTLS_E_PREMATURE_TERMINATION instead of propagating the 0
return value. It expects apps to arrange for clean termination at
the protocol level and not rely
Philippe Mathieu-Daudé writes:
> This image is based on Gentoo and the toolchain is built using crossdev.
>
> Recipe from:
> https://lists.gnu.org/archive/html/qemu-devel/2018-09/msg03944.html
>
> Suggested-by: Fredrik Noring
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> TODO:
> - Add Fre
Hi,
i guess many of you are occupied with 3.1,
but had anyone time to look at this?
kind regards
On 10/31/18 12:52 PM, Dominik Csapak wrote:
This series improves the QMP SHUTDOWN and RESET events by adding
the ShutdownCause as additional parameter and splitting
the HOST_QMP reason into HOST_QM
On Sat, Nov 17, 2018 at 08:19:10PM -0600, Eric Blake wrote:
> On 11/16/18 9:53 AM, Daniel P. Berrangé wrote:
> > When sending a NBD_CMD_DISC message there is no reply expected,
> > however, the nbd_read_eof() coroutine is still waiting for a reply.
> > In a plain NBD connection this doesn't matter
On 19/11/2018 14:27, Greg Kurz wrote:
> On Mon, 19 Nov 2018 08:09:38 -0500
> Serhii Popovych wrote:
>
>> Laurent Vivier reported off by one with maximum number of NUMA nodes
>> provided by qemu-kvm being less by one than required according to
>> description of "ibm,max-associativity-domains" prop
When debugging QEMU it is often useful to put a breakpoint on the
error_setg_internal method impl.
Unfortunately the object_property_add / object_class_property_add
methods call object_property_find / object_class_property_find methods
to check if a property exists already before adding the new pr
On 2018-11-19 13:25, Cornelia Huck wrote:
> On Mon, 19 Nov 2018 20:08:19 +0800
> Mao Zhongyi wrote:
>
>> Most of the SysBusDeviceClass variables are named sbc,
>> and sbdc here is a bit weird, so changing sbdc to keep
>> it consistent with others might look good.
>
> A quick git grep also gives
>>
>> Tests have to be fixed up:
>> - Two BUGs were hardcoded that are fixed now
>> - The string-input-visitor now actually returns a parsed list and not
>> an ordered set.
>
> I'd expect this to necessitate an update of callers that expect a set, but...
>
>> Signed-off-by: David Hildenbrand
>
On Mon, Nov 19, 2018 at 1:23 PM Alex Bennée wrote:
> Philippe Mathieu-Daudé writes:
>
> > This image is based on Gentoo and the toolchain is built using crossdev.
> >
> > Recipe from:
> > https://lists.gnu.org/archive/html/qemu-devel/2018-09/msg03944.html
> >
> > Suggested-by: Fredrik Noring
>
On 19.11.18 12:05, Cornelia Huck wrote:
> Signed-off-by: Cornelia Huck
> ---
> hw/s390x/s390-virtio-ccw.c | 17 -
> include/hw/compat.h| 3 +++
> 2 files changed, 19 insertions(+), 1 deletion(-)
>
> diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c
> i
Hello,
I tried to run my VM with qemu git and I am greeted with:
Block format 'raw' does not support the option 'serial'
Is there any sensible reason to *not^ support disk serial number?
Thanks
Michal
On Mon, Nov 19, 2018 at 01:07:13PM +, Stefan Hajnoczi wrote:
> On Mon, Nov 19, 2018 at 11:42:28AM +0100, Stefano Garzarella wrote:
> > On Mon, Nov 19, 2018 at 9:49 AM Gerd Hoffmann wrote:
> >
> > > Why at runtime? What is bad with two images? With a runtime option
> > > you probably need so
* baldu...@units.it (baldu...@units.it) wrote:
> hi
>
> thanks for taking the time to reply
>
> Dr. David Alan Gilbert writes:
> > > I suspect that this might be some problem on my side, as I couldn't
> > > find any similar report (apart some old (qemu-2.8.50) threads, that
> > > didn't help)
> >
On Mon, Nov 19, 2018 at 03:15:27PM +0100, Michal Suchánek wrote:
> Hello,
>
> I tried to run my VM with qemu git and I am greeted with:
>
> Block format 'raw' does not support the option 'serial'
>
> Is there any sensible reason to *not^ support disk serial number?
The 'serial' property on -dri
On 17 November 2018 at 16:02, Luc Michel wrote:
> This commit fixes a case where the CPU would try to go to EL3 when
> executing an smc instruction, even though ARM_FEATURE_EL3 is false. This
> case is raised when the PSCI conduit is set to smc, but the smc
> instruction does not lead to a valid P
On 11/19/18 4:23 AM, Daniel P. Berrangé wrote:
Simply setting the 'quit' flag after sending NBD_CMD_DISC is enough to
get the coroutine to stop waiting for a reply and thus supress the error
message.
Actually, it's not quite enough - once you actually start performing I/O,
enough coroutines ar
On 11/19/18 5:04 AM, Max Reitz wrote:
+tls_dir="${TEST_DIR}/tls"
+
+function tls_x509_cleanup()
+{
+rm -f ${tls_dir}/*.pem
+rm -f ${tls_dir}/*/*.pem
+rmdir ${tls_dir}/*
+rmdir ${tls_dir}
Why not just:
rm -rf $tls_dir
Yeah, I guess we could do that for simplicity
Also, the q
From: Mark Cave-Ayland
Commit c8a35f1cf0f "fdc: use IsaDma interface instead of global DMA_*
functions" accidentally introduced a segfault in fdctrl_stop_transfer() for
non-DMA transfers.
If fdctrl->dma_chann has not been configured then the fdctrl->dma interface
reference isn't initialised duri
From: Eric Blake
Our code was already checking that we did not attempt to
allocate more clusters than what would fit in an INT64 (the
physical maximimum if we can access a full off_t's worth of
data). But this does not catch smaller limits enforced by
various spots in the qcow2 image description
From: Li Qiang
Currently, the nvme_cmb_ops mr doesn't check the addr and size.
This can lead an oob access issue. This is triggerable in the guest.
Add check to avoid this issue.
Fixes CVE-2018-16847.
Reported-by: Li Qiang
Reviewed-by: Paolo Bonzini
Signed-off-by: Li Qiang
Signed-off-by: Kev
1 - 100 of 280 matches
Mail list logo
