On 11/16/18 7:29 AM, Gerd Hoffmann wrote:
From: Erik Skultety <eskul...@redhat.com>

Unlike SPICE, egl-headless doesn't offer a way of specifying the DRM
node used for OpenGL, hence QEMU always selecting the first one that is
available. Thus, add the 'rendernode' option for egl-headless to QAPI.

Signed-off-by: Erik Skultety <eskul...@redhat.com>
Message-id: 
7658e15eca72d520e7a5fb1c2e724702d83d4f7f.1542362949.git.eskul...@redhat.com
Signed-off-by: Gerd Hoffmann <kra...@redhat.com>
---
  qapi/ui.json | 17 ++++++++++++++++-
  1 file changed, 16 insertions(+), 1 deletion(-)

This has already landed, but I noticed via an off-list discussion that it is not introspectible through query-qmp-schema, because DisplayOptions is currently used only for command line handling. I don't know off-hand whether query-command-line-options even exposes the existence of DisplayOptions (not all of our command line options can be queried), but even if it does, I also know that our current command line queries are not detailed enough to readily expose the addition of a new optional member. I think it would be appropriate for the 3.1 timeframe to add a new QMP command that exposes the display configuration set up at runtime, if only so that the DisplayOptions becomes visible through query-qmp-commands as a bug fix for making this change easier to use.

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Reply via email to