[Qemu-devel] [PATCH 02/10] cputlb: Remove tcg_enabled hack from tlb_flush_nocheck

2018-10-23 Thread Richard Henderson
The bugs this was working around were fixed with commits 022d6378c7fd target/unicore32: remove tlb_flush from uc32_init_fn 6e11beecfde0 target/alpha: remove tlb_flush from alpha_cpu_initfn Signed-off-by: Richard Henderson --- accel/tcg/cputlb.c | 7 --- 1 file changed, 7 deletions(-) diff

[Qemu-devel] [PATCH 03/10] cputlb: Move cpu->pending_tlb_flush to env->tlb_c.pending_flush

2018-10-23 Thread Richard Henderson
Protect it with the tlb_lock instead of using atomics. The move puts it in or near the same cacheline as the lock; using the lock means we don't need a second atomic operation in order to perform the update. Which makes it cheap to also update pending_flush in tlb_flush_by_mmuidx_async_work. Sign

[Qemu-devel] [PATCH 06/10] cputlb: Merge tlb_flush_nocheck into tlb_flush_by_mmuidx_async_work

2018-10-23 Thread Richard Henderson
The difference between the two sets of APIs is now miniscule. This allows tlb_flush, tlb_flush_all_cpus, and tlb_flush_all_cpus_synced to be merged with their corresponding by_mmuidx functions as well. For accounting, consider mmu_idx_bitmask = ALL_MMUIDX_BITS to be a full flush. Signed-off-by:

[Qemu-devel] [PATCH 05/10] cputlb: Move env->vtlb_index to env->tlb_d.vindex

2018-10-23 Thread Richard Henderson
The rest of the tlb victim cache is per-tlb, the next use index should be as well. Signed-off-by: Richard Henderson --- include/exec/cpu-defs.h | 5 +++-- accel/tcg/cputlb.c | 5 ++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/include/exec/cpu-defs.h b/include/exec/cpu-

[Qemu-devel] [PATCH 07/10] cputlb: Merge tlb_flush_page into tlb_flush_page_by_mmuidx

2018-10-23 Thread Richard Henderson
The difference between the two sets of APIs is now miniscule. Signed-off-by: Richard Henderson --- accel/tcg/cputlb.c | 58 ++ 1 file changed, 12 insertions(+), 46 deletions(-) diff --git a/accel/tcg/cputlb.c b/accel/tcg/cputlb.c index 6b0f93ec01..444

[Qemu-devel] [PATCH 08/10] cputlb: Count "partial" and "elided" tlb flushes

2018-10-23 Thread Richard Henderson
Our only statistic so far was "full" tlb flushes, where all mmu_idx are flushed at the same time. Now count "partial" tlb flushes where sets of mmu_idx are flushed, but the set is not maximal. Account one per mmu_idx flushed, as that is the unit of work performed. We don't actually count elided

[Qemu-devel] [PATCH, build fix] osdep: Work around MinGW assert

2018-10-23 Thread Richard Henderson
In several places we use assert(FEATURE), and assume that if FEATURE is disabled, all following code is removed as unreachable. Which allows us to compile-out functions that are only present with FEATURE, and have a link-time failure if the functions remain used. MinGW does not mark its internal

[Qemu-devel] [PATCH 10/10] cputlb: Remove tlb_c.pending_flushes

2018-10-23 Thread Richard Henderson
This is essentially redundant with tlb_c.dirty. [??? Collect data to back up this supposition] Signed-off-by: Richard Henderson --- include/exec/cpu-defs.h | 6 -- accel/tcg/cputlb.c | 16 ++-- 2 files changed, 2 insertions(+), 20 deletions(-) diff --git a/include/exec/cpu

[Qemu-devel] [PATCH 09/10] cputlb: Filter flushes on already clean tlbs

2018-10-23 Thread Richard Henderson
Especially for guests with large numbers of tlbs, like ARM or PPC, we may well not use all of them in between flush operations. Remember which tlbs have been used since the last flush, and avoid any useless flushing. Signed-off-by: Richard Henderson --- include/exec/cpu-defs.h | 7 ++- acce

Re: [Qemu-devel] [PATCH v4 04/11] hw/m68k: add macfb video card

2018-10-23 Thread Thomas Huth
On 2018-10-18 19:28, Mark Cave-Ayland wrote: > From: Laurent Vivier > > Co-developed-by: Mark Cave-Ayland > Signed-off-by: Mark Cave-Ayland > Signed-off-by: Laurent Vivier > --- > arch_init.c | 4 + > hw/display/Makefile.objs| 1 + > hw/display/macfb-template.h | 158 +

[Qemu-devel] [PATCH 01/10] cputlb: Move tlb_lock to CPUTLBCommon

2018-10-23 Thread Richard Henderson
This is the first of several moves to reduce the size of the CPU_COMMON_TLB macro and improve some locality of refernce. Signed-off-by: Richard Henderson --- include/exec/cpu-defs.h | 17 --- accel/tcg/cputlb.c | 48 - 2 files changed, 38

[Qemu-devel] [PATCH 00/10] cputlb: track dirty tlbs and general cleanup

2018-10-23 Thread Richard Henderson
The motivation here is reducing the total overhead. Before a few patches went into target-arm.next, I measured total tlb flush overhead for aarch64 at 25%. This appears to reduce the total overhead to about 5% (I do need to re-run the control tests, not just watch perf top as I'm doing now). The

[Qemu-devel] [PATCH 04/10] cputlb: Split large page tracking per mmu_idx

2018-10-23 Thread Richard Henderson
The set of large pages in the kernel is probably not the same as the set of large pages in the application. Forcing one range to cover both will flush more often than necessary. This allows tlb_flush_page_async_work to flush just the one mmu_idx implicated, which in turn allows us to remove tlb_c

Re: [Qemu-devel] [PATCH v4 05/11] hw/m68k: Apple Sound Chip (ASC) emulation

2018-10-23 Thread Thomas Huth
On 2018-10-18 19:28, Mark Cave-Ayland wrote: > From: Laurent Vivier > > This is broken as the linux driver seems broken too... So is this required for the initial version, or does Linux also boot without this device in the emulated machine? In the first case, please mention it in the cover lette

Re: [Qemu-devel] [PATCH v4 07/11] hw/m68k: add Nubus support

2018-10-23 Thread Thomas Huth
On 2018-10-18 19:28, Mark Cave-Ayland wrote: > From: Laurent Vivier > > Co-developed-by: Mark Cave-Ayland > Signed-off-by: Mark Cave-Ayland > Signed-off-by: Laurent Vivier > --- [...] > +static void nubus_register_format_block(NubusDevice *dev) > +{ > +char fblock_name[27]; > + > +spri

Re: [Qemu-devel] [PATCH v2] s390x/pci: add common fmb

2018-10-23 Thread Yi Min Zhao
在 2018/10/22 下午8:17, Thomas Huth 写道: On 2018-10-22 10:02, Yi Min Zhao wrote: Common function measurement block is used to report counters of successfully issued pcilg/stg/stb and rpcit instructions. This patch introduces a new struct ZpciFmb and schedules a timer callback to copy fmb to the g

Re: [Qemu-devel] [PATCH] qapi: add info about reset to SHUTDOWN event

2018-10-23 Thread Dominik Csapak
On 10/17/18 4:43 PM, Paolo Bonzini wrote: On 17/10/2018 15:54, Eric Blake wrote: So the problem with shutdown_caused_by_guest is that you get the same value for both guest reset and guest shutdown.  Could we instead just pass the ShutdownCause in the event (similar to what was proposed even whe

Re: [Qemu-devel] [PATCH v7 1/3] Bootstrap Python venv for tests

2018-10-23 Thread Philippe Mathieu-Daudé
On 18/10/18 17:31, Cleber Rosa wrote: A number of QEMU tests are written in Python, and may benefit from an untainted Python venv. By using make rules, tests that depend on specific Python libs can set that rule as a requirement, along with rules that require the presence or installation of spec

Re: [Qemu-devel] [PATCH] qapi: Fix COLOStatus and query-colo-status since version

2018-10-23 Thread Dr. David Alan Gilbert
* Zhang Chen (zhangc...@gmail.com) wrote: > This structure and command have missed qemu version 3.0, so fix it to since > version 3.1. > > Signed-off-by: Zhang Chen Reviewed-by: Dr. David Alan Gilbert > --- > qapi/migration.json | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >

Re: [Qemu-devel] [PATCH v2 13/29] target/riscv: Convert RV32D insns to decodetree

2018-10-23 Thread Richard Henderson
On 10/20/18 8:14 AM, Bastian Koppelmann wrote: > Signed-off-by: Bastian Koppelmann > Signed-off-by: Peer Adelt > --- > v1 -> v2: > - Add REQUIRE_FPU to arithm helpers Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH v2 16/29] target/riscv: Convert quadrant 0 of RVXC insns to decodetree

2018-10-23 Thread Richard Henderson
On 10/20/18 8:14 AM, Bastian Koppelmann wrote: > v1 -> v2: > - Stack allocate arg_c_* structs > - ex_rvc_register returns int > - special case of trans_c_addi4spn() returns false ... > +static bool trans_c_addi4spn(DisasContext *ctx, arg_c_addi4spn *a, > +uint16_t insn) > +{ > +

Re: [Qemu-devel] [PATCH v2 09/29] target/riscv: Convert RV32A insns to decodetree

2018-10-23 Thread Richard Henderson
On 10/20/18 8:14 AM, Bastian Koppelmann wrote: > Signed-off-by: Bastian Koppelmann > Signed-off-by: Peer Adelt > --- > v1 -> v2: > - simplified gen_amo() with function pointers > - rs2 @atom_ld is now decimal > > target/riscv/insn32.decode | 17 +++ > target/riscv/insn_tra

Re: [Qemu-devel] [PATCH v2 17/29] target/riscv: Convert quadrant 1 of RVXC insns to decodetree

2018-10-23 Thread Richard Henderson
On 10/20/18 8:14 AM, Bastian Koppelmann wrote: > --- a/target/riscv/insn_trans/trans_rvc.inc.c > +++ b/target/riscv/insn_trans/trans_rvc.inc.c > @@ -23,8 +23,7 @@ static bool trans_c_addi4spn(DisasContext *ctx, > arg_c_addi4spn *a, > { > if (a->nzuimm == 0) { > /* Reserved in ISA */

Re: [Qemu-devel] [PATCH v2 18/29] target/riscv: Convert quadrant 2 of RVXC insns to decodetree

2018-10-23 Thread Richard Henderson
On 10/20/18 8:14 AM, Bastian Koppelmann wrote: > This also removes all functions that now became obsolete. > > Signed-off-by: Bastian Koppelmann > --- > target/riscv/insn16.decode | 34 +- > target/riscv/insn_trans/trans_rvc.inc.c | 103 > target/riscv/translat

Re: [Qemu-devel] [PATCH v2 23/29] target/riscv: Move gen_arith_imm() decoding into trans_* functions

2018-10-23 Thread Richard Henderson
On 10/20/18 8:14 AM, Bastian Koppelmann wrote: > static bool trans_srli(DisasContext *ctx, arg_srli *a, uint32_t insn) > { > -gen_arith_imm(ctx, OPC_RISC_SHIFT_RIGHT_I, a->rd, a->rs1, a->shamt); > +if (a->rd != 0) { > +TCGv t = tcg_temp_new(); > +gen_get_gpr(t, a->rs1); >

Re: [Qemu-devel] [PATCH v2 24/29] target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists

2018-10-23 Thread Richard Henderson
On 10/20/18 8:14 AM, Bastian Koppelmann wrote: > +static bool trans_arith(DisasContext *ctx, arg_arith *a, > +void(*func)(TCGv, TCGv, TCGv)) gen_arith. r~

Re: [Qemu-devel] [PATCH v2 24/29] target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists

2018-10-23 Thread Richard Henderson
On 10/23/18 9:53 AM, Richard Henderson wrote: > On 10/20/18 8:14 AM, Bastian Koppelmann wrote: >> +static bool trans_arith(DisasContext *ctx, arg_arith *a, >> +void(*func)(TCGv, TCGv, TCGv)) > > gen_arith. Oh, right, last patch. Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PULL 0/3] Linux user for 3.1 patches

2018-10-23 Thread Peter Maydell
On 19 October 2018 at 13:19, Laurent Vivier wrote: > The following changes since commit 1b7490446bf41f54130c2d495dd4c8768c8e1ce3: > > Merge remote-tracking branch > 'remotes/vivier2/tags/linux-user-for-3.1-pull-request' into staging > (2018-10-19 11:20:05 +0100) > > are available in the Git re

Re: [Qemu-devel] [PATCH 00/27] ACPI hardware-reduced support

2018-10-23 Thread Samuel Ortiz
On Mon, Oct 22, 2018 at 05:28:54PM -0400, Michael S. Tsirkin wrote: > On Mon, Oct 22, 2018 at 08:36:30PM +0200, Samuel Ortiz wrote: > > This patch set implements support for the ACPI hardware-reduced > > specification. > > > > The changes are coming from the NEMU [1] project where we're defining >

Re: [Qemu-devel] [PATCH v2 26/29] target/riscv: Remove manual decoding of RV32/64M insn

2018-10-23 Thread Richard Henderson
On 10/20/18 8:14 AM, Bastian Koppelmann wrote: > static bool trans_mulh(DisasContext *ctx, arg_mulh *a, uint32_t insn) > { > -gen_arith(ctx, OPC_RISC_MULH, a->rd, a->rs1, a->rs2); > +TCGv source1 = tcg_temp_new(); > +TCGv source2 = tcg_temp_new(); > +gen_get_gpr(source1, a->rs1);

Re: [Qemu-devel] [PATCH v2 28/29] target/riscv: Remove decode_RV32_64G()

2018-10-23 Thread Richard Henderson
On 10/20/18 8:14 AM, Bastian Koppelmann wrote: > decodetree handles all instructions now so the fallback is not necessary > anymore. > > Signed-off-by: Bastian Koppelmann > Signed-off-by: Peer Adelt > --- > v1 -> v2: > - Add missing gen_exception_illegal Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH v2 29/29] target/riscv: Rename trans_arith to gen_arith

2018-10-23 Thread Richard Henderson
On 10/20/18 8:14 AM, Bastian Koppelmann wrote: > Signed-off-by: Bastian Koppelmann > --- > target/riscv/insn_trans/trans_rvi.inc.c | 14 +++--- > target/riscv/insn_trans/trans_rvm.inc.c | 14 +++--- > target/riscv/translate.c| 4 ++-- > 3 files changed, 16 inserti

[Qemu-devel] [PATCH v2 2/2] [RFC] arm: program migrated guests' invariant registers with host ones

2018-10-23 Thread mjaggi
From: Manish Jaggi When KVM_SET_ONE_REG returns KVM_EINVARIANT call KVM_GET_ONE_REG to query and then replace the particular guest invariant register value with destination hosts register. Signed-off-by: Manish Jaggi diff --git a/target/arm/kvm.c b/target/arm/kvm.c index 65f867d..8cf4dc9 10064

[Qemu-devel] [PATCH v2 1/2] [RFC] arm: Introduce hostinvariant command line option

2018-10-23 Thread mjaggi
From: Manish Jaggi This option is user opt-in. hostinvariant will replace guest's invariant registers with hosts. Signed-off-by: Manish Jaggi diff --git a/qemu-options.hx b/qemu-options.hx index 654ef48..d8c0da7 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -3896,6 +3896,19 @@ STEXI p

[Qemu-devel] [PATCH v2 0/2] [RFC] qemu: arm: Migration between machines with different MIDR values

2018-10-23 Thread mjaggi
From: Manish Jaggi QEMU on arm systems use -machine virt -cpu host option for a VM. Migration thus is limited between machines with same cpu. This is a limitation if migration is desired between cpus which are of same family and have only few difeerences like bug fixes which have no effect on VM

[Qemu-devel] [PATCH 2/3] linux-user: Add support for semtimedop() syscall

2018-10-23 Thread Aleksandar Markovic
From: Aleksandar Rikalo Add support for semtimedop() emulation. Signed-off-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic --- linux-user/syscall.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index b8435

[Qemu-devel] Call for patches for the qemu-trivial pull request

2018-10-23 Thread Laurent Vivier
Hi, I'm going to collect patches for the next pull request for the qemu-trivial I'd like to do before the softfreeze. As we didn't have any pull request for more than 3 months and some of the patches have been pushed through another maintainer branches, it's a little bit difficult to collect corr

[Qemu-devel] [PATCH 1/3] linux-user: Add support for statx() syscall

2018-10-23 Thread Aleksandar Markovic
From: Aleksandar Rikalo Implement support for translation of system call statx(). The implementation includes invoking other (more mature) syscalls (from the same 'stat' family) on the host side. This way, problems of availability of statx() on the host side are avoided. Signed-off-by: Aleksanda

[Qemu-devel] [PATCH 3/3] linux-user: Add support for SO_REUSEPORT

2018-10-23 Thread Aleksandar Markovic
From: Yunqiang Su Add support for SO_REUSEPORT, including strace support. SO_REUSEPORT was introduced relatively recently, since Linux 3.9, so use '#if defined SO_REUSEPORT'. Signed-off-by: Yunqiang Su Signed-off-by: Aleksandar Markovic --- linux-user/strace.c | 3 +++ linux-user/syscall.c

[Qemu-devel] [PATCH 0/3] linux-user: Support for misc feateres

2018-10-23 Thread Aleksandar Markovic
From: Aleksandar Markovic This series add support for two system calls and a socket-related improvement. Aleksandar Rikalo (2): linux-user: Add support for statx() syscall linux-user: Add support for semtimedop() syscall Yunqiang Su (1): linux-user: Add support for SO_REUSEPORT linux-us

Re: [Qemu-devel] [PATCH v6 08/11] authz: add QAuthZList object type for an access control list

2018-10-23 Thread Philippe Mathieu-Daudé
On 19/10/18 15:38, Daniel P. Berrangé wrote: From: "Daniel P. Berrange" Add a QAuthZList object type that implements the QAuthZ interface. This built-in implementation maintains a trivial access control list with a sequence of match rules and a final default policy. This replicates the function

Re: [Qemu-devel] [PATCH] hw/arm/virt: remove unused header files

2018-10-23 Thread Hongbo Zhang
Well, after checking manually, the header files "hw/arm/primecell.h" "qapi/visitor.h" "hw/arm/smmuv3.h" are really not used in virt.c, still can be removed. On 22 October 2018 at 18:17, Hongbo Zhang wrote: > On 22 October 2018 at 09:37, Hongbo Zhang wrote: >> On 19 October 2018 at 19:59, Peter M

[Qemu-devel] [RFC] [PATCH] kvm: arm: Introduce error code KVM_EINVARIANT

2018-10-23 Thread mjaggi
From: Manish Jaggi This patch introduces an error code KVM_EINVARIANT which is returned by KVM when userland tries to set an invariant register. The need for this error code is in VM Migration for arm64. ARM64 systems use mainly -machine virt -cpu host as parameter to qemu. Migration requires bo

Re: [Qemu-devel] [PATCH, build fix] osdep: Work around MinGW assert

2018-10-23 Thread Philippe Mathieu-Daudé
On 23/10/18 9:02, Richard Henderson wrote: In several places we use assert(FEATURE), and assume that if FEATURE is disabled, all following code is removed as unreachable. Which allows us to compile-out functions that are only present with FEATURE, and have a link-time failure if the functions re

Re: [Qemu-devel] [PATCH 01/10] cputlb: Move tlb_lock to CPUTLBCommon

2018-10-23 Thread Philippe Mathieu-Daudé
On 23/10/18 9:02, Richard Henderson wrote: This is the first of several moves to reduce the size of the CPU_COMMON_TLB macro and improve some locality of refernce. "reference" Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé --- include/exec/cpu-defs.h | 17 ++

Re: [Qemu-devel] [PATCH 05/10] cputlb: Move env->vtlb_index to env->tlb_d.vindex

2018-10-23 Thread Philippe Mathieu-Daudé
On 23/10/18 9:02, Richard Henderson wrote: The rest of the tlb victim cache is per-tlb, the next use index should be as well. Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé --- include/exec/cpu-defs.h | 5 +++-- accel/tcg/cputlb.c | 5 ++--- 2 files changed,

Re: [Qemu-devel] [PATCH v6 11/11] authz: delete existing ACL implementation

2018-10-23 Thread Philippe Mathieu-Daudé
On 19/10/18 15:38, Daniel P. Berrangé wrote: From: "Daniel P. Berrange" The 'qemu_acl' type was a previous non-QOM based attempt to provide an authorization facility in QEMU. Because it is non-QOM based it cannot be created via the command line and requires special monitor commands to manipulat

Re: [Qemu-devel] [PATCH, build fix] osdep: Work around MinGW assert

2018-10-23 Thread Peter Maydell
On 22 October 2018 at 19:16, Richard Henderson wrote: > In several places we use assert(FEATURE), and assume that if FEATURE > is disabled, all following code is removed as unreachable. Which allows > us to compile-out functions that are only present with FEATURE, and > have a link-time failure i

Re: [Qemu-devel] [PATCH v4 11/11] hw/m68k: define Macintosh Quadra 800

2018-10-23 Thread Thomas Huth
On 2018-10-18 19:28, Mark Cave-Ayland wrote: > From: Laurent Vivier > > Co-developed-by: Mark Cave-Ayland > Signed-off-by: Mark Cave-Ayland > Signed-off-by: Laurent Vivier > --- [...] > diff --git a/hw/m68k/Makefile.objs b/hw/m68k/Makefile.objs > index d1f089c08a..18ebf1937a 100644 > --- a/hw/

[Qemu-devel] [PATCH v5 04/14] qga-win: prevent crash when executing fsinfo command

2018-10-23 Thread Tomáš Golembiovský
From: Sameeh Jubran The fsinfo command is currently implemented for Windows only and it's disk parameter can be enabled by adding the define "CONFIG_QGA_NTDDSCSI" to the qga code. When enabled and executed the qemu-ga crashed with the following message: --

[Qemu-devel] [PATCH v5 09/14] qga-win: refactor disk properties (bus)

2018-10-23 Thread Tomáš Golembiovský
Refactor code that queries bus type to be more generic. The function get_disk_bus_type() has been renamed to build_guest_disk_info(). Following commit(s) will extend this function. Signed-off-by: Tomáš Golembiovský --- qga/commands-win32.c | 44 +++- 1 fil

[Qemu-devel] [PATCH v5 05/14] qga-win: fsinfo: pci-info: allow partial info

2018-10-23 Thread Tomáš Golembiovský
From: Sameeh Jubran The call to SetupDiGetDeviceRegistryProperty might fail because the value doesn't exist in the registry, in this case we shouldn't exit from the loop but instead continue to look for other available values in the registry and set this value as unavailable (-1). Signed-off-by:

[Qemu-devel] [PATCH v5 00/14] qga: report serial number and disk node

2018-10-23 Thread Tomáš Golembiovský
Note that PCI controller reporting on Windows was and still is broken. Unfortunately I don't know how to fix it at the momemnt. See commit message and code comment. If anyone has environment where the original code works let me know. CCing author of the code In case I missed something obvious. v5:

[Qemu-devel] [PATCH v5 01/14] configure: add test for libudev

2018-10-23 Thread Tomáš Golembiovský
Signed-off-by: Tomáš Golembiovský Reviewed-by: Marc-André Lureau --- configure | 22 ++ 1 file changed, 22 insertions(+) diff --git a/configure b/configure index c3da1a2587..26e8605bbc 100755 --- a/configure +++ b/configure @@ -477,6 +477,7 @@ libxml2="" docker="no" debug_

[Qemu-devel] [PATCH v5 02/14] qga: linux: report disk serial number

2018-10-23 Thread Tomáš Golembiovský
Add reporting of disk serial number on Linux guests. The feature depends on libudev. Example: { "name": "dm-2", "mountpoint": "/", ... "disk": [ { "serial": "SAMSUNG_MZ7LN512HCHP-000L1_S1ZKNXAG822493", ... } ], } Signed-of

[Qemu-devel] [PATCH v5 06/14] *additonal fixup for NULL pci_controller field

2018-10-23 Thread Tomáš Golembiovský
From: Michael Roth (cherry picked from commit 51fe925a7b473c76e06b60ddb8a862c91901b290) Signed-off-by: Michael Roth Signed-off-by: Tomáš Golembiovský --- qga/commands-win32.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/qga/commands-win32.c b/qga/commands-win32.c

[Qemu-devel] [PATCH v5 10/14] qga-win: report disk serial number

2018-10-23 Thread Tomáš Golembiovský
Signed-off-by: Tomáš Golembiovský --- qga/commands-win32.c | 25 + 1 file changed, 25 insertions(+) diff --git a/qga/commands-win32.c b/qga/commands-win32.c index 5ebacd241f..e7d9cdea62 100644 --- a/qga/commands-win32.c +++ b/qga/commands-win32.c @@ -609,6 +609,31 @@ stat

[Qemu-devel] [PATCH v5 07/14] build: rename CONFIG_QGA_NTDDDISK to CONFIG_QGA_NTDDSCSI

2018-10-23 Thread Tomáš Golembiovský
There was inconsistency between commits: 50cbebb9a3 configure: add configure check for ntdddisk.h a3ef3b2272 qga: added bus type and disk location path The first commit added #define CONFIG_QGA_NTDDDISK but the second commit expected the name to be CONFIG_QGA_NTDDSCSI. As a result the code in

[Qemu-devel] [PATCH v5 03/14] qga: linux: return disk device in guest-get-fsinfo

2018-10-23 Thread Tomáš Golembiovský
Report device node of the disk on Linux (e.g. "/dev/sda2"). Requirs libudev. Signed-off-by: Tomáš Golembiovský --- qga/commands-posix.c | 7 ++- qga/qapi-schema.json | 3 ++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/qga/commands-posix.c b/qga/commands-posix.c index d087

[Qemu-devel] [PATCH v5 08/14] qga-win: add debugging information

2018-10-23 Thread Tomáš Golembiovský
The windows code generaly lacks debug information (compared to posix code). This patch adds some related to HW info in guest-get-fsinfo command. Signed-off-by: Tomáš Golembiovský Reviewed-by: Marc-André Lureau --- dtc | 2 +- qga/commands-win32.c | 15 +++ 2 files

[Qemu-devel] [PATCH v5 12/14] qga-win: handle multi-disk volumes

2018-10-23 Thread Tomáš Golembiovský
Probe the volume for disk extents and return list of all disks. Originally only first disk of composite volume was returned. Note that the patch changes get_pci_info() from one state of brokenness into a different state of brokenness. In other words it still does not do what it's supposed to do (s

[Qemu-devel] [PATCH v5 11/14] qga-win: refactor disk info

2018-10-23 Thread Tomáš Golembiovský
Refactor building of disk info into a function that builds the list and a function that returns infor for single disk. This will be used in future commit that will handle multi-disk volumes. Signed-off-by: Tomáš Golembiovský --- qga/commands-win32.c | 58 ++---

[Qemu-devel] [PATCH v5 13/14] qga-win: return disk device in guest-get-fsinfo

2018-10-23 Thread Tomáš Golembiovský
Report device UNC of the disk. It is reported as "\\.\PhysicalDriveX". Signed-off-by: Tomáš Golembiovský --- qga/commands-win32.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/qga/commands-win32.c b/qga/commands-win32.c index 09566b3f47..12aba8cc50 1

[Qemu-devel] [PATCH v5 14/14] qga-win: demystify namespace stripping

2018-10-23 Thread Tomáš Golembiovský
It was not obvious what exactly the cryptic string copying does to the GUID. This change makes the intent clearer. Signed-off-by: Tomáš Golembiovský --- qga/commands-win32.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/qga/commands-win32.c b/qga/commands-win32.c

[Qemu-devel] [PATCH 3/7] target/riscv: Update for decodetree insn argument change

2018-10-23 Thread Richard Henderson
??? Should be merged back into previous patches. ??? Additional changes required for compact mode. --- .../riscv/insn_trans/trans_privileged.inc.c | 19 ++- target/riscv/insn_trans/trans_rva.inc.c | 44 +++--- target/riscv/insn_trans/trans_rvc.inc.c | 148 +- target

[Qemu-devel] [PATCH 4/7] target/riscv: Rename some argument sets in insn32.decode

2018-10-23 Thread Richard Henderson
For format x, use &x for the argument set and @x for the extract. This is less confusing than e.g. "arith" for format R. --- target/riscv/insn_trans/trans_rvi.inc.c | 2 +- target/riscv/translate.c| 10 +- target/riscv/insn32.decode | 12 ++-- 3 files

[Qemu-devel] [PATCH 0/7] riscv decodetree followup

2018-10-23 Thread Richard Henderson
The first patch is the promised change to argument sets to allow them to be shared between two decoders. Then I set about trying to use this... and ran into some other interesting problems. The first of which is that bool trans_add(DecodeContext *ctx, struct arg_r *a, uint32_t insn); bool t

[Qemu-devel] [PATCH 7/7] target/riscv: Splice decodetree inputs for riscv32 vs riscv64

2018-10-23 Thread Richard Henderson
This primarily solves the case for RVC that several insns are completely different, decode and all, between the two. But it also means that we need less ifdefing for RV{I,M,A,F,D}. --- target/riscv/insn_trans/trans_rva.inc.c | 46 +--- target/riscv/insn_trans/trans_rvc.inc.c | 71

[Qemu-devel] [PATCH 2/7] decodetree: Remove "insn" argument from trans_* expanders

2018-10-23 Thread Richard Henderson
??? Needs simultaneous corresponding changes to all translators using decodetree. --- scripts/decodetree.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/scripts/decodetree.py b/scripts/decodetree.py index a9b10452ef..c0bb447095 100755 --- a/scripts/decodetree.py +++ b/s

[Qemu-devel] [PATCH 5/7] target/riscv: Convert @cs_2 insns to share translation functions

2018-10-23 Thread Richard Henderson
These all expand simply to R format instructions. --- target/riscv/insn_trans/trans_rvc.inc.c | 36 - target/riscv/translate.c| 20 +++--- target/riscv/insn16.decode | 17 +++- 3 files changed, 26 insertions(+), 47 deletions(-)

[Qemu-devel] [PATCH 6/7] target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns

2018-10-23 Thread Richard Henderson
--- target/riscv/insn_trans/trans_rvc.inc.c | 34 +++-- target/riscv/insn16.decode | 18 +++-- target/riscv/insn32.decode | 3 ++- 3 files changed, 16 insertions(+), 39 deletions(-) diff --git a/target/riscv/insn_trans/trans_rvc.inc.c b/targ

[Qemu-devel] [PATCH 1/7] decodetree: Add !extern flag to argument sets

2018-10-23 Thread Richard Henderson
Allow argument sets to be shared between two decoders by avoiding a re-declaration error. Make sure that anonymous argument sets have unique names. Signed-off-by: Richard Henderson --- scripts/decodetree.py | 34 +++--- 1 file changed, 23 insertions(+), 11 deletions(

Re: [Qemu-devel] [PATCH v2 1/7] qapi: correctly parse uint64_t values from strings

2018-10-23 Thread David Hildenbrand
On 17/10/2018 14:42, Markus Armbruster wrote: > Quick peek only for now. > > David Hildenbrand writes: > >> Right now, we parse uint64_t values just like int64_t values, resulting >> in negative values getting accepted and certain valid large numbers only >> being representable as negative numbe

Re: [Qemu-devel] [PATCH 2/3] linux-user: Add support for semtimedop() syscall

2018-10-23 Thread Philippe Mathieu-Daudé
Hi Aleksandar, On 23/10/18 11:58, Aleksandar Markovic wrote: From: Aleksandar Rikalo Add support for semtimedop() emulation. Signed-off-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic --- linux-user/syscall.c | 27 +++ 1 file changed, 27 insertions(+) di

Re: [Qemu-devel] [PATCH 7/7] target/riscv: Splice decodetree inputs for riscv32 vs riscv64

2018-10-23 Thread Philippe Mathieu-Daudé
On 23/10/18 14:04, Richard Henderson wrote: This primarily solves the case for RVC that several insns are completely different, decode and all, between the two. But it also means that we need less ifdefing for RV{I,M,A,F,D}. Lovely! Probably due to the jet lag you forgot your S-o-b :p With it

Re: [Qemu-devel] [PATCH 4/7] target/riscv: Rename some argument sets in insn32.decode

2018-10-23 Thread Philippe Mathieu-Daudé
On 23/10/18 14:04, Richard Henderson wrote: For format x, use &x for the argument set and @x for the extract. This is less confusing than e.g. "arith" for format R. With your S-o-b: Reviewed-by: Philippe Mathieu-Daudé --- target/riscv/insn_trans/trans_rvi.inc.c | 2 +- target/riscv/trans

Re: [Qemu-devel] [PATCH 5/7] target/riscv: Convert @cs_2 insns to share translation functions

2018-10-23 Thread Philippe Mathieu-Daudé
On 23/10/18 14:04, Richard Henderson wrote: These all expand simply to R format instructions. --- target/riscv/insn_trans/trans_rvc.inc.c | 36 - target/riscv/translate.c| 20 +++--- target/riscv/insn16.decode | 17 +++- 3

Re: [Qemu-devel] [PATCH 6/7] target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns

2018-10-23 Thread Philippe Mathieu-Daudé
With S-o-b: Reviewed-by: Philippe Mathieu-Daudé On 23/10/18 14:04, Richard Henderson wrote: --- target/riscv/insn_trans/trans_rvc.inc.c | 34 +++-- target/riscv/insn16.decode | 18 +++-- target/riscv/insn32.decode | 3 ++- 3 files chan

Re: [Qemu-devel] [PATCH v2 2/2] x86: hv_evmcs CPU flag support

2018-10-23 Thread Roman Kagan
On Mon, Oct 22, 2018 at 06:55:06PM +0200, Vitaly Kuznetsov wrote: > Adds a new CPU flag to enable the Enlightened VMCS KVM feature. > QEMU enables KVM_CAP_HYPERV_ENLIGHTENED_VMCS and gets back the > version to be advertised in lower 16 bits of CPUID.0x400A:EAX. > > Suggested-by: Ladi Prosek >

Re: [Qemu-devel] [PATCH 00/27] ACPI hardware-reduced support

2018-10-23 Thread Michael S. Tsirkin
On Tue, Oct 23, 2018 at 11:00:18AM +0200, Samuel Ortiz wrote: > > I wonder whether the code can be refactored slightly differently: > > instead of common code calling out to platform specific one, > > have platform code call out to generic one. > > That would avoid indicectiin should have been ind

Re: [Qemu-devel] [PATCH 1/7] decodetree: Add !extern flag to argument sets

2018-10-23 Thread Bastian Koppelmann
On 10/23/18 2:04 PM, Richard Henderson wrote: Allow argument sets to be shared between two decoders by avoiding a re-declaration error. Make sure that anonymous argument sets have unique names. Signed-off-by: Richard Henderson --- scripts/decodetree.py | 34 +++-

Re: [Qemu-devel] [PATCH] vhost-scsi: prevent using uninitialized vqs

2018-10-23 Thread Michael S. Tsirkin
On Tue, Oct 23, 2018 at 01:49:16AM +0200, Philippe Mathieu-Daudé wrote: > On 22/10/18 4:17, yuchenlin via Qemu-devel wrote: > > Ping? > > > > On 2018-10-12 17:07, yuchen...@synology.com wrote: > > > From: yuchenlin > > > > > > There are 3 virtqueues (ctrl, event and cmd) for virtio scsi device,

Re: [Qemu-devel] [PATCH 4/7] target/riscv: Rename some argument sets in insn32.decode

2018-10-23 Thread Richard Henderson
On 10/23/18 1:21 PM, Philippe Mathieu-Daudé wrote: > On 23/10/18 14:04, Richard Henderson wrote: >> For format x, use &x for the argument set and @x for the extract. >> This is less confusing than e.g. "arith" for format R. > > With your S-o-b: > Reviewed-by: Philippe Mathieu-Daudé Oh no. I ful

[Qemu-devel] [PULL v2 00/40] Error reporting patches for 2018-10-22

2018-10-23 Thread Markus Armbruster
The following changes since commit b312532fd03413d0e6ae6767ec793a3e30f487b8: Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2018-10-19 19:01:07 +0100) are available in the Git repository at: git://repo.or.cz/qemu/armbru.git tags/pull-error-2018-10-22-v2 for

Re: [Qemu-devel] [PATCH 5/7] target/riscv: Convert @cs_2 insns to share translation functions

2018-10-23 Thread Richard Henderson
On 10/23/18 1:26 PM, Philippe Mathieu-Daudé wrote: >>   +#pragma GCC diagnostic push >> +#pragma GCC diagnostic ignored "-Wredundant-decls" > > We might move that to a generic Makefile rule, this will be useful for other > archs. > > Something like: > > translate*.o: CPPFLAGS += -Wno-redundant-d

Re: [Qemu-devel] [PATCH 2/7] decodetree: Remove "insn" argument from trans_* expanders

2018-10-23 Thread Bastian Koppelmann
On 10/23/18 2:04 PM, Richard Henderson wrote: ??? Needs simultaneous corresponding changes to all translators using decodetree. --- scripts/decodetree.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) Was the only intend of the insn argument to be used for manual decoding in a

Re: [Qemu-devel] [PULL 0/3] Qcrypto next patches

2018-10-23 Thread Peter Maydell
On 19 October 2018 at 14:43, Daniel P. Berrangé wrote: > The following changes since commit 2ec24af2379e331d062a6fc1cda65bc262c7c17b: > > Merge remote-tracking branch > 'remotes/amarkovic/tags/mips-queue-october-2018-part1-v2' into staging > (2018-10-19 10:08:31 +0100) > > are available in the

[Qemu-devel] [PULL v2 05/40] block: Use warn_report() & friends to report warnings

2018-10-23 Thread Markus Armbruster
Calling error_report() in a function that takes an Error ** argument is suspicious. Convert a few that are actually warnings to warn_report(). While there, improve a rather useless warning in sheepdog.c. Cc: Kevin Wolf Cc: Ronnie Sahlberg Cc: Paolo Bonzini Cc: Peter Lieven Cc: Liu Yuan Sign

[Qemu-devel] [PATCH v2 2/3] linux-user: Add support for semtimedop() syscall

2018-10-23 Thread Aleksandar Markovic
From: Aleksandar Rikalo Add support for semtimedop() emulation. Signed-off-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic --- linux-user/syscall.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 8b01a

[Qemu-devel] [PATCH v2 1/3] linux-user: Add support for statx() syscall

2018-10-23 Thread Aleksandar Markovic
From: Aleksandar Rikalo Implement support for translation of system call statx(). The implementation includes invoking other (more mature) syscalls (from the same 'stat' family) on the host side. This way, problems of availability of statx() on the host side are avoided. Signed-off-by: Aleksanda

[Qemu-devel] [PATCH] target/mips: Add initrd support for Boston board

2018-10-23 Thread Aleksandar Markovic
From: Aleksandar Rikalo Add support for initial ramdisk loading for the Mips Boston board. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic --- v2->v3: - a comment was reformatted - rebased to the latest QEMU code v1->v2: - 'long in

Re: [Qemu-devel] [PATCH 2/7] decodetree: Remove "insn" argument from trans_* expanders

2018-10-23 Thread Richard Henderson
On 10/23/18 2:04 PM, Bastian Koppelmann wrote: > On 10/23/18 2:04 PM, Richard Henderson wrote: >> ??? Needs simultaneous corresponding changes to all >> translators using decodetree. >> --- >>   scripts/decodetree.py | 5 ++--- >>   1 file changed, 2 insertions(+), 3 deletions(-) >> > > Was the onl

[Qemu-devel] [PATCH v2 0/3] linux-user: Support for misc features

2018-10-23 Thread Aleksandar Markovic
From: Aleksandar Markovic This series add support for two system calls and a socket-related improvement. v1->v2: - fixed a typo in the title - cosmetic comment reformats - fixed build error related to old label 'efault' - fixed wrong email addresses Aleksandar Rikalo (2): linux-user:

[Qemu-devel] [PATCH v2 3/3] linux-user: Add support for SO_REUSEPORT

2018-10-23 Thread Aleksandar Markovic
From: Yunqiang Su Add support for SO_REUSEPORT, including strace support. SO_REUSEPORT was introduced relatively recently, since Linux 3.9, so use '#if defined SO_REUSEPORT'. Signed-off-by: Yunqiang Su Signed-off-by: Aleksandar Markovic --- linux-user/strace.c | 3 +++ linux-user/syscall.c

Re: [Qemu-devel] [PATCH v4 11/11] hw/m68k: define Macintosh Quadra 800

2018-10-23 Thread Philippe Mathieu-Daudé
Hi Laurent, Mark, On 18/10/18 20:28, Mark Cave-Ayland wrote: From: Laurent Vivier Co-developed-by: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Signed-off-by: Laurent Vivier --- MAINTAINERS | 19 ++ default-configs/m68k-softmmu.mak | 14 ++ hw/intc/Makefile.ob

Re: [Qemu-devel] [PATCH 2/7] decodetree: Remove "insn" argument from trans_* expanders

2018-10-23 Thread Bastian Koppelmann
On 10/23/18 3:08 PM, Richard Henderson wrote: On 10/23/18 2:04 PM, Bastian Koppelmann wrote: On 10/23/18 2:04 PM, Richard Henderson wrote: ??? Needs simultaneous corresponding changes to all translators using decodetree. ---   scripts/decodetree.py | 5 ++---   1 file changed, 2 insertions(+

Re: [Qemu-devel] Virtual IOMMU is working for Windows VM?

2018-10-23 Thread Peter Xu
On Mon, Oct 22, 2018 at 10:43:32AM -0400, Jintack Lim wrote: > On Mon, Oct 22, 2018 at 5:27 AM Peter Xu wrote: > > > > On Mon, Oct 22, 2018 at 12:22:02AM -0400, Jintack Lim wrote: > > > Hi, > > > > > > I wonder if vIOMMU is working for Windows VM? > > > > > > I tried it with v2.11.0, but it didn't

Re: [Qemu-devel] [PATCH 2/7] decodetree: Remove "insn" argument from trans_* expanders

2018-10-23 Thread Philippe Mathieu-Daudé
On 23/10/18 15:08, Richard Henderson wrote: On 10/23/18 2:04 PM, Bastian Koppelmann wrote: On 10/23/18 2:04 PM, Richard Henderson wrote: ??? Needs simultaneous corresponding changes to all translators using decodetree. ---   scripts/decodetree.py | 5 ++---   1 file changed, 2 insertions(+), 3

Re: [Qemu-devel] [PATCH 1/7] decodetree: Add !extern flag to argument sets

2018-10-23 Thread Philippe Mathieu-Daudé
On 23/10/18 14:04, Richard Henderson wrote: Allow argument sets to be shared between two decoders by avoiding a re-declaration error. Make sure that anonymous argument sets have unique names. Signed-off-by: Richard Henderson --- scripts/decodetree.py | 34 +++---

Re: [Qemu-devel] [PATCH 3/7] target/riscv: Update for decodetree insn argument change

2018-10-23 Thread Bastian Koppelmann
On 10/23/18 2:04 PM, Richard Henderson wrote: ??? Should be merged back into previous patches. ??? Additional changes required for compact mode. --- .../riscv/insn_trans/trans_privileged.inc.c | 19 ++- target/riscv/insn_trans/trans_rva.inc.c | 44 +++--- target/riscv/insn_trans/t

  1   2   3   >