On 10/23/18 2:04 PM, Bastian Koppelmann wrote: > On 10/23/18 2:04 PM, Richard Henderson wrote: >> ??? Needs simultaneous corresponding changes to all >> translators using decodetree. >> --- >> scripts/decodetree.py | 5 ++--- >> 1 file changed, 2 insertions(+), 3 deletions(-) >> > > Was the only intend of the insn argument to be used for manual decoding in a > trans_ function?
I didn't quite know what it might be used for, and thought I was planning ahead. Now I see that it's probably counter-productive. In particular, think of how you were calling the trans_foo functions yourself, passing along the uint16_t input to the uint32_t output. Which would have worked not at all had you actually been using it for decode within the insn32 code base. r~
