On 10/7/18 6:33 AM, Li Qiang wrote:
> It makes sense to print the error message while reading
> file failed.
>
> Signed-off-by: Li Qiang
> ---
> vl.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/vl.c b/vl.c
> index cc55fe04a2..3db410e771 100644
> --- a/vl.c
> ++
Hello,
Gavin Grant, le jeu. 30 août 2018 16:57:57 +0100, a ecrit:
> Commit 27d92ebc5ed1bb0b518d0ebc4c609182ad20a799 handled the case where the TCP
> connection is abruptly closed via a RST packet, by checking for the ECONNRESET
> errno. However it does not consider the case where the connection ha
From: Gavin Grant
Commit 27d92ebc5ed1bb0b518d0ebc4c609182ad20a799 handled the case where the TCP
connection is abruptly closed via a RST packet, by checking for the ECONNRESET
errno. However it does not consider the case where the connection has been
half-closed by the host (FIN/ACK), then the ho
From: Peter Maydell
and fix confusing datasize name into gapsize in m_inc.
Signed-off-by: Peter Maydell
Signed-off-by: Samuel Thibault
---
slirp/mbuf.c | 14 +++---
slirp/mbuf.h | 13 +
2 files changed, 20 insertions(+), 7 deletions(-)
diff --git a/slirp/mbuf.c b/slirp/mb
From: Andrew Oates
On Linux, SOCK_DGRAM+IPPROTO_ICMP sockets give only the ICMP packet when
read from. On macOS, however, the socket acts like a SOCK_RAW socket
and includes the IP header as well.
This change strips the extra IP header from the received packet on macOS
before sending it to the
The following changes since commit 3c2d3042849686969add641bd38b08b9877b9e8f:
Merge remote-tracking branch
'remotes/mcayland/tags/qemu-openbios.for-upstream-20181005' into staging
(2018-10-05 17:55:22 +0100)
are available in the Git repository at:
https://people.debian.org/~sthibault/qemu.g
Rather than test NOCHAIN before linking, do not emit the
goto_tb opcode at all. We already do this for goto_ptr.
Previously, nochain seemed more or less a hack to debug code gen.
But there's a real use case when it comes to tracing, so spend a
little more effort on what we produce.
Signed-off-by
On PCXS chips (PA7000, pa 1.1a), trap #18 is raised on memory faults,
while all later chips (>= PA7100) generate either trap #26, #27 or #28
(depending on the fault type).
Since the current qemu emulation emulates a B160L machine (with a
PA7300LC PCX-L2 chip, we should raise trap #26 (EXCP_DMAR) i
On 26.09.18 20:05, Jeff Cody wrote:
> I'll not be involved in day-to-day qemu development. Remove myself as
> maintainer from the remainder of the network block drivers, and revert
> them to the general block layer maintainership.
>
> Move 'sheepdog' to the 'Odd Fixes' support level.
>
> For VHD
On 19.09.18 16:47, Alberto Garcia wrote:
> If qemu_opts_absorb_qdict() fails and we carry on and call
> update_flags_from_options() then that can result on a failed
> assertion:
>
>$ qemu-io -c 'reopen -o read-only=foo' hd.qcow2
>block.c:1101: update_flags_from_options: Assertion `qemu_opt
On 19.09.18 16:47, Alberto Garcia wrote:
> This patch replaces the bdrv_reopen() calls that set and remove the
> BDRV_O_RDWR flag with the new bdrv_reopen_set_read_only() function.
>
> Signed-off-by: Alberto Garcia
> ---
> block.c | 10 +-
> 1 file changed, 5 insertions(+), 5 deletions(-
Isolate the computation of an index from an address into a
helper before we change that function.
Signed-off-by: Richard Henderson
---
Emilio, this should make your dynamic tlb sizing patch 1/6
significantly smaller.
r~
---
accel/tcg/softmmu_template.h | 68 +-
On Fri, Oct 05, 2018 at 08:12:12AM +0200, Thomas Huth wrote:
> On 2018-10-05 06:25, David Gibson wrote:
> > On Thu, Oct 04, 2018 at 12:07:01PM +0200, Thomas Huth wrote:
> >> The spapr-rng device is suboptimal when compared to virtio-rng, so
> >> users might want to disable it in their builds. Thus
On 19.09.18 16:47, Alberto Garcia wrote:
> Most callers of bdrv_reopen() only use it to switch a BlockDriverState
> between read-only and read-write, so this patch adds a new function
> that does just that.
>
> We also want to get rid of the flags parameter in the bdrv_reopen()
> API, so this func
On 19.09.18 16:47, Alberto Garcia wrote:
> This patch replaces the bdrv_reopen() calls that set and remove the
> BDRV_O_RDWR flag with the new bdrv_reopen_set_read_only() function.
>
> Signed-off-by: Alberto Garcia
> ---
> block/commit.c | 16 ++--
> 1 file changed, 6 insertions(+),
On 19.09.18 16:47, Alberto Garcia wrote:
> This patch replaces the bdrv_reopen() calls that set and remove the
> BDRV_O_RDWR flag with the new bdrv_reopen_set_read_only() function.
>
> Signed-off-by: Alberto Garcia
> ---
> block/commit.c | 7 +++
> 1 file changed, 3 insertions(+), 4 deletion
On 19.09.18 16:47, Alberto Garcia wrote:
> This patch replaces the bdrv_reopen() calls that set and remove the
> BDRV_O_RDWR flag with the new bdrv_reopen_set_read_only() function.
>
> Signed-off-by: Alberto Garcia
> ---
> block/stream.c | 20 ++--
> 1 file changed, 10 insertions
On 19.09.18 16:47, Alberto Garcia wrote:
> This patch replaces the bdrv_reopen() calls that set and remove the
> BDRV_O_RDWR flag with the new bdrv_reopen_set_read_only() function.
>
> Signed-off-by: Alberto Garcia
> ---
> blockdev.c | 8 ++--
> 1 file changed, 2 insertions(+), 6 deletions(-
On 19.09.18 16:47, Alberto Garcia wrote:
> This patch replaces the bdrv_reopen() calls that set and remove the
> BDRV_O_RDWR flag with the new bdrv_reopen_set_read_only() function.
Ha! Got you! It's just one call this time, not "calls"! :-)
> Signed-off-by: Alberto Garcia
> ---
> blockdev.c |
On 19.09.18 16:47, Alberto Garcia wrote:
> The 'block-commit' QMP command is implemented internally using two
> different drivers. If the source image is the active layer then the
> mirror driver is used (commit_active_start()), otherwise the commit
> driver is used (commit_start()).
>
> In both c
On 10/6/18 2:45 PM, Emilio G. Cota wrote:
> -#define CPU_COMMON_TLB \
> +typedef struct CPUTLBDesc {
> +size_t size;
> +size_t mask; /* (.size - 1) << CPU_TLB_ENTRY_BITS for TLB fast path */
> +} CPUTLBDesc;
I think you don't need both size and mask. Size is (or ought to be) used
infreque
On 19.09.18 16:47, Alberto Garcia wrote:
> No one is using this function anymore, so we can safely remove it
Is this such a minor action to you that you think it doesn't need a full
stop? ;-)
> Signed-off-by: Alberto Garcia
> ---
> block.c | 21 -
> include/blo
On Sun, Oct 07, 2018 at 19:37:50 +0200, Philippe Mathieu-Daudé wrote:
> On 10/6/18 11:45 PM, Emilio G. Cota wrote:
> > 2. System boot + shutdown, ubuntu 18.04 x86_64:
>
> You can also run the VM tests to build QEMU:
>
> $ make vm-test
Thanks, will give that a look.
> > +if (rate == 100) {
>
On 19.09.18 16:47, Alberto Garcia wrote:
> When reopen_f() puts a block device in the reopen queue, some of the
> new options are passed using a QDict, but others ("read-only" and the
> cache options) are passed as flags.
>
> This patch puts those flags in the QDict. This way the flags parameter
>
On 10/6/18 2:45 PM, Emilio G. Cota wrote:
> Currently we evict an entry to the victim TLB when it doesn't match
> the current address. But it could be that there's no match because
> the current entry is invalid. Do not evict the entry to the vtlb
> in that case.
>
> This change will help us keep
Cc: qemu-triv...@nongnu.org
Signed-off-by: Li Qiang
---
util/aio-posix.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/util/aio-posix.c b/util/aio-posix.c
index 621b302..51c41ed 100644
--- a/util/aio-posix.c
+++ b/util/aio-posix.c
@@ -40,7 +40,7 @@ struct AioHandler
#ifde
On 19.09.18 16:47, Alberto Garcia wrote:
> This function is used to put the hidden and secondary disks in
> read-write mode before launching the backup job, and back in read-only
> mode afterwards.
>
> This patch does the following changes:
>
> - Use an options QDict with the "read-only" option
On Fri, 10/05 10:00, yuchenlin wrote:
> Ping?
Hi,
This was merged as 51b3c6b73acae1e3fd3c7d441fc86dd17356695f.
Fam
>
> On 2018-09-13 16:34, Fam Zheng wrote:
> > On Thu, 09/13 16:29, yuchen...@synology.com wrote:
> > > From: yuchenlin
> > >
> > > There is a rare case which the size of last co
On 19.09.18 16:47, Alberto Garcia wrote:
> Now that all callers are passing all flag changes as QDict options,
> the flags parameter is no longer necessary, so we can get rid of it.
>
> Signed-off-by: Alberto Garcia
> ---
> block.c | 5 +++--
> block/replication.c | 6 ++
> i
On 19.09.18 16:47, Alberto Garcia wrote:
> Now that all callers are passing the new options using the QDict we no
> longer need the 'flags' parameter.
>
> This patch makes the following changes:
>
>1) The update_options_from_flags() call is no longer necessary
> so it can be removed.
>
On 2018年09月13日 15:55, Peter Xu wrote:
There are two callers for vtd_sync_shadow_page_table_range(), one
provided a valid context entry and one not. Move that fetching
operation into the caller vtd_sync_shadow_page_table() where we need to
fetch the context entry.
Meanwhile, we should handle
On 10/6/18 2:45 PM, Emilio G. Cota wrote:
> From: Pranith Kumar
>
> This paves the way for implementing a dynamically-sized softmmu.
>
> Signed-off-by: Pranith Kumar
> Signed-off-by: Emilio G. Cota
> ---
There's no point in this, since the original constraint was due to encoding
immediates in
On 10/6/18 2:45 PM, Emilio G. Cota wrote:
> @@ -89,7 +89,7 @@ typedef uint64_t target_ulong;
> * 0x18 (the offset of the addend field in each TLB entry) plus the offset
> * of tlb_table inside env (which is non-trivial but not huge).
> */
> -#define CPU_TLB_BITS
On Fri, Oct 05, 2018 at 11:20:11AM +0200, David Hildenbrand wrote:
> Handle id==NULL better and indicate that we are dealing with memory
> devices.
>
> Signed-off-by: David Hildenbrand
Reviewed-by: David Gibson
> ---
> hw/mem/memory-device.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 delet
On 10/6/18 2:45 PM, Emilio G. Cota wrote:
> @@ -753,6 +763,7 @@ void tlb_set_page_with_attrs(CPUState *cpu, target_ulong
> vaddr,
> }
>
> copy_tlb_helper_locked(te, &tn);
> +env->tlb_desc[mmu_idx].used++;
> qemu_spin_unlock(&env->tlb_lock);
> }
So.. you're computing what? T
On Mon, Sep 24, 2018 at 05:48:14AM -0400, Pankaj Gupta wrote:
>
> > On 24/09/2018 07:45, David Gibson wrote:
> > > On Thu, Sep 20, 2018 at 12:32:38PM +0200, David Hildenbrand wrote:
> > >> From: Pankaj Gupta
> > >>
> > >> This is the current protoype of virtio-pmem. Support will require
> > >> ma
On 2018年09月29日 11:36, Peter Xu wrote:
v4:
- add a patch to introduce vtd_reset_caches()
- reset the caches in the two places where GCMD update happens [Eric]
Please review, thanks.
Peter Xu (2):
intel_iommu: introduce vtd_reset_caches()
intel_iommu: better handling of dmar state switch
On 2018-10-08 10:38, Fam Zheng wrote:
On Fri, 10/05 10:00, yuchenlin wrote:
Ping?
Hi,
This was merged as 51b3c6b73acae1e3fd3c7d441fc86dd17356695f.
Fam
Hi,
Thank you for your information.
yuchenlin
On 2018-09-13 16:34, Fam Zheng wrote:
> On Thu, 09/13 16:29, yuchen...@synology.com wro
On 2018年10月04日 19:43, Dominik Csapak wrote:
this patch series aims to execute a script when qemu exits
so that one can do cleanups when using --daemonize without
having to use the qmp monitor
Hi:
Can you give a example of why it must be done through this way? It looks
to me that we can do
The ptcr (partition table control register) is used to store the address
and size of the partition table. For nested kvm-hv we have a level 1
guest register the location of it's partition table with the hypervisor.
Thus to support migration we need to be able to read this out of kvm
and restore it
Add the spapr cap SPAPR_CAP_NESTED_KVM_HV to be used to control the
availability of nested kvm-hv to the level 1 (L1) guest.
Assuming a hypervisor with support enabled an L1 guest can be allowed to
use the kvm-hv module (and thus run it's own kvm-hv guests) by setting:
-machine pseries,cap-nested-
This patch series adds the qemu support for running nested kvm-hv on a
POWER9 platform with appropriate hypervisor support and migration of
these guests.
That is, the ability to run kvm-hv guests as guests of an operating system
which is itself a kvm-hv guest.
The host (L0 hypervisor) and level 1
Signed-off-by: Suraj Jitindar Singh
---
linux-headers/asm-powerpc/kvm.h | 1 +
linux-headers/linux/kvm.h | 1 +
2 files changed, 2 insertions(+)
diff --git a/linux-headers/asm-powerpc/kvm.h b/linux-headers/asm-powerpc/kvm.h
index 1b32b56a03..8c876c166e 100644
--- a/linux-headers/asm-powerp
On 10/6/18 2:45 PM, Emilio G. Cota wrote:
> @@ -122,6 +123,39 @@ size_t tlb_flush_count(void)
> return count;
> }
>
> +/* Call with tlb_lock held */
> +static void tlb_mmu_resize_locked(CPUArchState *env, int mmu_idx)
> +{
> +CPUTLBDesc *desc = &env->tlb_desc[mmu_idx];
> +size_t rat
Hello David,
Thanks for the review.
> >
> > > On 24/09/2018 07:45, David Gibson wrote:
> > > > On Thu, Sep 20, 2018 at 12:32:38PM +0200, David Hildenbrand wrote:
> > > >> From: Pankaj Gupta
> > > >>
> > > >> This is the current protoype of virtio-pmem. Support will require
> > > >> machine chan
From: Cortland Setlow Tölva
This patch series enables programs running under QEMU Linux user mode
emulation to implement user-space USB drivers via the USBFS ioctl()s.
Support is limited to control, bulk, and possibly interrupt transfers.
Usbfs ioctl codes were incorrect whenever host and target
Userspace submits a USB Request Buffer to the kernel, optionally
discards it, and finally reaps the URB. Thunk buffers from target
to host and back.
Tested by running an i386 scanner driver on ARMv7, by running
the PowerPC lsusb utility on x86_64, and MIPS lsusb on ARMv7.
The discard urb ioctl
Size calculation should have used the target struct. Fix the error by
marking these ioctls as needing runtime size calcuation.
Signed-off-by: Cortland Tölva
---
linux-user/syscall_defs.h | 38 ++
1 file changed, 18 insertions(+), 20 deletions(-)
diff --git a
On Mon, Oct 01, 2018 at 07:44:37PM +, Singh, Brijesh wrote:
> Register the interrupt remapping callback and read/write ops for the
> amd-iommu-ir memory region.
>
> amd-iommu-ir is set to higher priority to ensure that this region won't
> be masked out by other memory regions.
>
> Signed-off-
On Mon, Oct 08, 2018 at 11:08:31AM +0800, Jason Wang wrote:
[...]
> > +static int vtd_sync_shadow_page_table(VTDAddressSpace *vtd_as)
> > +{
> > int ret;
> > +VTDContextEntry ce;
> > +IOMMUNotifier *n;
> > -if (ce) {
> > -/* If the caller provided context entry, use it *
On Mon, Oct 01, 2018 at 07:44:39PM +, Singh, Brijesh wrote:
> Emulate the interrupt remapping support when guest virtual APIC is
> not enabled.
>
> For more info Refer: AMD IOMMU spec Rev 3.0 - section 2.2.5.1
>
> When VAPIC is not enabled, it uses interrupt remapping as defined in
> Table 20
On Mon, Oct 01, 2018 at 01:36:50PM +0200, Auger Eric wrote:
> Hi Peter,
> On 9/13/18 9:55 AM, Peter Xu wrote:
> > There are two callers for vtd_sync_shadow_page_table_range(), one
> > provided a valid context entry and one not. Move that fetching
> > operation into the caller vtd_sync_shadow_page_
On 2018-10-05 18:32, Peter Maydell wrote:
> On 5 October 2018 at 10:42, Thomas Huth wrote:
>> Each device that is instantiatable by the users should be marked with
>> a category.
>
> Presumably we could assert() this somewhere (at which
> point we'd find that we have dozens of devices that
> fail
On Mon, Oct 08, 2018 at 02:06:20PM +0800, Peter Xu wrote:
> > > -static int vtd_sync_shadow_page_table(VTDAddressSpace *vtd_as)
> > > -{
> > > -return vtd_sync_shadow_page_table_range(vtd_as, NULL, 0, UINT64_MAX);
> > > +return vtd_sync_shadow_page_table_range(vtd_as, &ce, 0, UINT64_MAX);
>
On 2018-10-05 18:17, Paolo Bonzini wrote:
> Commit 31d2dda ("build-system: remove per-test GCOV reporting", 2018-06-20)
> removed users of the variables, since those uses can be replaced by a simple
> overall report produced by gcovr. However, the variables were never removed.
> Do it now.
>
> Si
On Mon, Oct 08, 2018 at 02:47:11PM +0800, Peter Xu wrote:
> v2:
> - split patch into more, remove useless comment [Eric]
> - remove one error_report_once() when rework the code [Jason]
>
> This series fixes a QEMU crash reported here:
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1627272
>
> P
Reviewed-by: Sameeh Jubran
On Thu, Oct 4, 2018 at 4:23 PM Marc-André Lureau
wrote:
>
> Hi
>
> On Thu, Oct 4, 2018 at 3:22 PM Tomáš Golembiovský wrote:
> >
> > There was inconsistency between commits:
> >
> > 50cbebb9a3 configure: add configure check for ntdddisk.h
> > a3ef3b2272 qga: added b
Your advice was taken and implemented, sending changes in the next version.
On Thu, Sep 27, 2018 at 2:48 PM Marc-André Lureau <
marcandre.lur...@gmail.com> wrote:
> Hi
>
> On Thu, Sep 27, 2018 at 11:41 AM Bishara AbuHattoum
> wrote:
> >
> > Currently whenever the qemu-ga's service doesn't find t
As I already clarified in the cover letter, I will fix the typo in the
commit message and drop the message ID from all the patches, changes will
be in the next version.
On Thu, Sep 27, 2018 at 2:45 PM Marc-André Lureau <
marcandre.lur...@gmail.com> wrote:
> Hi
>
> On Thu, Sep 27, 2018 at 11:39 AM
As I already clarified in the cover letter, I will fix the typo in the
commit message and drop the message ID from all the patches, changes will
be in the next version.
On Thu, Sep 27, 2018 at 2:44 PM Marc-André Lureau <
marcandre.lur...@gmail.com> wrote:
> Hi
>
> On Thu, Sep 27, 2018 at 11:37 AM
This is the command line. All of the devices are wired to pci.0, there is
no pci bridge.
According to this, Integrated Endpoints are not hot-pluggable. However I
can still use device_del to delete a device and device_add to add e1000
with no issues.
https://github.com/qemu/qemu/blob/master/docs/p
Changes from v1:
[1/7] qga: group agent init/cleanup init separate routines
Fixed typo in the commit message and dropped the unnecessary message ID
[2/7] qga: hang GAConfig/socket_activation off of GAState global
Dropped the unnecessary message ID
[3/7] qga: move w32 service ha
From: Michael Roth
For w32 services we rely on the global GAState to access resources
associated with the agent within service_main(). Currently this is
sufficient for starting the agent since we open the channel once prior
to calling service_main(), and simply start the GMainLoop to start the
ag
From: Michael Roth
This patch better separates the init/cleanup routines out into
separate functions to make the start-up procedure a bit easier to
follow. This will be useful when we eventually break out the actual
start/stop of the agent's main loop into separates routines that
can be called mu
+1, this is much clearer.
On Thu, Oct 4, 2018 at 4:34 PM Marc-André Lureau
wrote:
>
> Hi
>
> On Thu, Oct 4, 2018 at 3:22 PM Tomáš Golembiovský wrote:
> >
> > It was not obvious what exactly the cryptic string copying does to the
> > GUID. This change makes the intent clearer.
> >
> > Signed-off-b
From: Michael Roth
It's nicer from a management perspective that the agent can survive
hotplug/unplug of the channel device, or be started prior to the
installation of the channel device's driver without and still be able
to resume normal function afterward. On linux there are alternatives
like s
From: Michael Roth
Eventually we want a w32 service to be able to restart the qga main
loop from within service_main(). To allow for this we move service
handling out of run_agent() such that service_main() calls
run_agent() instead of the reverse.
Signed-off-by: Michael Roth
Signed-off-by: Bis
From: Michael Roth
This adds an option to instruct the agent to periodically attempt
re-opening the communication channel after a channel error has
occurred. The main use-case for this is providing an OS-independent
way of allowing the agent to survive situations like hotplug/unplug of
the commun
From: Michael Roth
Useful in general, but especially now that errors might occur more
frequently with --retry-path set.
Signed-off-by: Michael Roth
---
qga/channel-win32.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/qga/channel-win32.c b/qga/channel-win32.c
index b359
Currently whenever the qemu-ga's service doesn't find the virtio-serial
the run_agent() loops in a QGA_RETRY_INTERVAL (default 5 seconds)
intervals and try to restart the qemu-ga which causes a synchronous loop.
Changed to wait and listen for the serial events by registering for
notifications a pro
I did a quick scan for the documentation and the code and it seems that the
name format that you're looking for is provided by the "QueryDosDeviceW"
function. The function returns multiple names and in the current code we
only check the first one. I believe that one of these names provided should
b
Use MAP_STACK in qemu_alloc_stack() on OpenBSD.
Added to -current and will be in our soon to be 6.4 release.
MAP_STACK Indicate that the mapping is used as a stack. This
flag must be used in combination with MAP_ANON and
MAP_PRIVATE.
Implement MAP_STACK option
On 10/6/18 8:38 PM, Stefan Weil wrote:
> Use %zu instead of %zd for unsigned numbers.
>
> This fixes two error messages from the LSTM static code analyzer:
>
> This argument should be of type 'ssize_t' but is of type 'unsigned long'
Eventually prepend some spaces to have the difference between y
Hi Emilio,
On 10/6/18 11:45 PM, Emilio G. Cota wrote:
> Perform the resizing only on flushes, otherwise we'd
> have to take a perf hit by either rehashing the array
> or unnecessarily flushing it.
>
> We grow the array aggressively, and reduce the size more
> slowly. This accommodates mixed workl
74 matches
Mail list logo
