On 19.09.18 16:47, Alberto Garcia wrote: > If qemu_opts_absorb_qdict() fails and we carry on and call > update_flags_from_options() then that can result on a failed > assertion: > > $ qemu-io -c 'reopen -o read-only=foo' hd.qcow2 > block.c:1101: update_flags_from_options: Assertion `qemu_opt_find(opts, > BDRV_OPT_CACHE_DIRECT)' failed. > Aborted > > This only happens in bdrv_reopen_queue_child(). Although this function > doesn't return errors, we can simply keep the wrong options in the > reopen queue and later bdrv_reopen_prepare() will fail. > > Signed-off-by: Alberto Garcia <be...@igalia.com> > --- > block.c | 11 +++++++++-- > tests/qemu-iotests/133 | 6 ++++++ > tests/qemu-iotests/133.out | 4 ++++ > 3 files changed, 19 insertions(+), 2 deletions(-)
Reviewed-by: Max Reitz <mre...@redhat.com>
signature.asc
Description: OpenPGP digital signature
