Re: [Qemu-devel] [PATCH 1/3] Check for Linux USBFS in configure

2018-10-04 Thread Cortland Setlow Tölva
Hi Laurent, The deeper view on part 3 can wait - I have found an issue with 64-bit hosts. In linux-user/syscall_defs.h the references to struct usbdevfs_urb and so forth are incorrect and I need to define struct target_usbdevfs_urb for the size and the ioctl code to be calculated with the target'

Re: [Qemu-devel] [PATCH v2] block/vvfat: Fix crash when reporting error about too many files in directory

2018-10-04 Thread Thomas Huth
On 2018-07-24 13:52, Thomas Huth wrote: > When using the vvfat driver with a directory that contains too many files, > QEMU currently crashes. This can be triggered like this for example: > > mkdir /tmp/vvfattest > cd /tmp/vvfattest > for ((x=0;x<=513;x++)); do mkdir $x; done > qemu-system-x86

Re: [Qemu-devel] [PATCH] gtk: initialize zoom_to_fit

2018-10-04 Thread Marc-André Lureau
Hi On Thu, Oct 4, 2018 at 9:36 AM Gerd Hoffmann wrote: > > Fixes: CID 1395988 > Signed-off-by: Gerd Hoffmann Same patch sent by Paolo yesterday: https://lists.nongnu.org/archive/html/qemu-devel/2018-10/msg00474.html > --- > ui/gtk.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

Re: [Qemu-devel] [PATCH 1/1] vl.c: call optional script when exiting

2018-10-04 Thread Thomas Huth
On 2018-10-03 11:13, Dominik Csapak wrote: > some users might want to call a script when qemu exits, without listening > to a qmp monitor for events when running with --daemonize > > this can be used for things like external cleanups > > Signed-off-by: Dominik Csapak > --- > qemu-options.hx | 1

Re: [Qemu-devel] [PATCH] configure: remove glib_subprocess check

2018-10-04 Thread Thomas Huth
On 2018-10-03 15:20, Marc-André Lureau wrote: > This should have been removed as part of commit > 692fbdf9f4c6f6bafd0b3a4d4f94973effd3bbae. > > Signed-off-by: Marc-André Lureau > --- > configure | 6 -- > 1 file changed, 6 deletions(-) > > diff --git a/configure b/configure > index a7368044

Re: [Qemu-devel] [PATCH v9 5/6] s390x/vfio: ap: Introduce VFIO AP device

2018-10-04 Thread Pierre Morel
On 27/09/2018 00:54, Tony Krowiak wrote: Introduces a VFIO based AP device. The device is defined via the QEMU command line by specifying: -device vfio-ap,sysfsdev= There may be only one vfio-ap device configured for a guest. The mediated matrix device is created by the VFIO AP device dri

Re: [Qemu-devel] [PATCH v9 2/6] s390x/cpumodel: Set up CPU model for AP device support

2018-10-04 Thread Pierre Morel
On 27/09/2018 00:54, Tony Krowiak wrote: A new CPU model feature and two new CPU model facilities are introduced to support AP devices for a KVM guest. CPU model features: 1. The S390_FEAT_AP CPU model feature indicates whether AP instructions are available to the guest. This feature will

Re: [Qemu-devel] [PATCH] hw/s390x/s390-pci-bus: Convert sysbus init function to realize function

2018-10-04 Thread Cornelia Huck
On Tue, 2 Oct 2018 09:48:11 +0200 Thomas Huth wrote: > The SysBusDeviceClass->init() interface is considered as a legacy interface > and there are currently some efforts going on to get rid of it. Thus let's > convert the init function in the s390x code to realize() instead. > > Signed-off-by:

Re: [Qemu-devel] [PATCH v9 2/6] s390x/cpumodel: Set up CPU model for AP device support

2018-10-04 Thread Pierre Morel
On 27/09/2018 00:54, Tony Krowiak wrote: A new CPU model feature and two new CPU model facilities are introduced to support AP devices for a KVM guest. CPU model features: 1. The S390_FEAT_AP CPU model feature indicates whether AP instructions are available to the guest. This feature will

Re: [Qemu-devel] [PATCH v9 4/6] s390x/ap: base Adjunct Processor (AP) object model

2018-10-04 Thread Pierre Morel
On 27/09/2018 00:54, Tony Krowiak wrote: From: Tony Krowiak Introduces the base object model for virtualizing AP devices. Signed-off-by: Tony Krowiak --- MAINTAINERS | 12 ++ hw/s390x/Makefile.objs | 2 + hw/s390x/ap-bridge.c | 81 ++

Re: [Qemu-devel] [PATCH v9 5/6] s390x/vfio: ap: Introduce VFIO AP device

2018-10-04 Thread Pierre Morel
On 27/09/2018 00:54, Tony Krowiak wrote: Introduces a VFIO based AP device. The device is defined via the QEMU command line by specifying: -device vfio-ap,sysfsdev= There may be only one vfio-ap device configured for a guest. The mediated matrix device is created by the VFIO AP device dri

Re: [Qemu-devel] [PATCH v2 0/4] softfloat: Fix division

2018-10-04 Thread Alex Bennée
Richard Henderson writes: > Changes from v1: > * Preserve udiv_qrnnd as a separate division primitive that > could be used as a building block for float128 division. > * Include asm fragments for x86_64, s390x, and ppc64. It passes my fops fdiv_double test but Emilio's test is reporti

Re: [Qemu-devel] [PATCH] qapi/misc.json: Remove superfluous words in CpuModelExpansionType

2018-10-04 Thread Kashyap Chamarthy
On Wed, Oct 03, 2018 at 09:26:26AM -0500, Eric Blake wrote: > On 10/3/18 5:46 AM, Kashyap Chamarthy wrote: > > While at it, s/QMU/QEMU in @CpuDefinitionInfo. > > Could mention that it was a repetition of 'independent of'. Whoever is merging this, please touch up the commit message by adding:

Re: [Qemu-devel] [PATCH] hw/s390x/s390-pci-bus: Convert sysbus init function to realize function

2018-10-04 Thread David Hildenbrand
On 02/10/2018 09:48, Thomas Huth wrote: > The SysBusDeviceClass->init() interface is considered as a legacy interface > and there are currently some efforts going on to get rid of it. Thus let's > convert the init function in the s390x code to realize() instead. > > Signed-off-by: Thomas Huth > -

[Qemu-devel] [PATCH 1/1] nbd: fix NBD_CMD_CACHE negitiation according to the NBD specification

2018-10-04 Thread Denis V. Lunev
Commit bc37b06a5 was made very bad thing, it has been added NBD_FLAG_SEND_CACHE flag for negotiation. The problem is that the value of the flag was taken wrong and directly violates NBD specification. This value (bit 8) is used at least in the Linux kernel as a part of stable userspace-kernel API s

Re: [Qemu-devel] [PATCH v2 2/4] cputlb: fix assert_cpu_is_self macro

2018-10-04 Thread Alex Bennée
Emilio G. Cota writes: > Signed-off-by: Emilio G. Cota Reviewed-by: Alex Bennée > --- > accel/tcg/cputlb.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/accel/tcg/cputlb.c b/accel/tcg/cputlb.c > index 502eea2850..f6b388c961 100644 > --- a/accel/tcg/cputlb.c >

[Qemu-devel] [PATCH] hw/ppc/spapr_rng: Introduce CONFIG_SPAPR_RNG switch for spapr_rng.c

2018-10-04 Thread Thomas Huth
The spapr-rng device is suboptimal when compared to virtio-rng, so users might want to disable it in their builds. Thus let's introduce a proper CONFIG switch to allow us to compile QEMU without this device. Signed-off-by: Thomas Huth --- default-configs/ppc64-softmmu.mak | 1 + hw/ppc/Makefile

Re: [Qemu-devel] [PATCH v9 6/6] s390: doc: detailed specifications for AP virtualization

2018-10-04 Thread Pierre Morel
On 27/09/2018 00:54, Tony Krowiak wrote: This patch provides documentation describing the AP architecture and design concepts behind the virtualization of AP devices. It also includes an example of how to configure AP devices for exclusive use of KVM guests. Signed-off-by: Tony Krowiak --- MA

[Qemu-devel] [PATCH v2] MAINTAINERS: Add an entry for qemu-options* files in main directory

2018-10-04 Thread Thomas Huth
The file "qemu-options.h", "qemu-options.hx" and "qemu-options-wrapper.h" in the main directory are currently without maintainer according to our get_maintainers.pl script. Considering that the command line options are a public interface and thus quite important, this is quite a bad state. Add an e

Re: [Qemu-devel] [RFC v3 00/15] ARM virt: PCDIMM/NVDIMM at 2TB

2018-10-04 Thread Igor Mammedov
On Wed, 3 Oct 2018 15:49:03 +0200 Auger Eric wrote: > Hi, > > On 7/3/18 9:19 AM, Eric Auger wrote: > > This series aims at supporting PCDIMM/NVDIMM intantiation in > > machvirt at 2TB guest physical address. > > > > This is achieved in 3 steps: > > 1) support more than 40b IPA/GPA > > 2) suppor

Re: [Qemu-devel] [PATCH v2 1/4] exec: introduce tlb_init

2018-10-04 Thread Alex Bennée
Emilio G. Cota writes: > Paves the way for the addition of a per-TLB lock. > > Signed-off-by: Emilio G. Cota Reviewed-by: Alex Bennée > --- > include/exec/exec-all.h | 8 > accel/tcg/cputlb.c | 4 > exec.c | 1 + > 3 files changed, 13 insertions(+) > > d

Re: [Qemu-devel] [PATCH v2 3/4] cputlb: serialize tlb updates with env->tlb_lock

2018-10-04 Thread Alex Bennée
Emilio G. Cota writes: > Currently we rely on atomic operations for cross-CPU invalidations. > There are two cases that these atomics miss: cross-CPU invalidations > can race with either (1) vCPU threads flushing their TLB, which > happens via memset, or (2) vCPUs calling tlb_reset_dirty on the

[Qemu-devel] [PATCH v4 05/11] qga-win: refactor disk properties (bus)

2018-10-04 Thread Tomáš Golembiovský
Refactor code that queries bus type to be more generic. The function get_disk_bus_type() has been renamed to build_guest_disk_info(). Following commit(s) will extend this function. Signed-off-by: Tomáš Golembiovský --- qga/commands-win32.c | 46 +++- 1 fil

Re: [Qemu-devel] [PATCH] qapi: Add vim magic modelines for qapi definitions

2018-10-04 Thread Peter Krempa
On Tue, Sep 04, 2018 at 09:03:10 +0200, Peter Krempa wrote: > The files have a json suffix but look terrible with json syntax > hilighting enabled. Add a magic modeline for vim to switch to python > file format for hilighting similarly to the emacs modeline already > present. > > Signed-off-by: Pe

[Qemu-devel] [PATCH v4 07/11] qga: report disk serial number

2018-10-04 Thread Tomáš Golembiovský
The feature is implemented for Windows and Linux. Reporting of serial number on Linux depends on libudev. Example from Linux: { "name": "dm-2", "mountpoint": "/", ... "disk": [ { "serial": "SAMSUNG_MZ7LN512HCHP-000L1_S1ZKNXAG822493", ...

[Qemu-devel] [PATCH v4 00/11] qga: report serial number and disk node

2018-10-04 Thread Tomáš Golembiovský
Note that PCI controller reporting on Windows was and still is broken. Unfortunately I don't know how to fix it at the momemnt. See commit message and code comment. If anyone has environment where the original code works let me know. CCing author of the code In case I missed something obvious. v4:

Re: [Qemu-devel] [RFC v3 00/15] ARM virt: PCDIMM/NVDIMM at 2TB

2018-10-04 Thread Auger Eric
Hi Igor, On 10/4/18 1:11 PM, Igor Mammedov wrote: > On Wed, 3 Oct 2018 15:49:03 +0200 > Auger Eric wrote: > >> Hi, >> >> On 7/3/18 9:19 AM, Eric Auger wrote: >>> This series aims at supporting PCDIMM/NVDIMM intantiation in >>> machvirt at 2TB guest physical address. >>> >>> This is achieved in 3

[Qemu-devel] [PATCH v4 10/11] qga: return disk device in guest-get-fsinfo

2018-10-04 Thread Tomáš Golembiovský
Report device node of the disk. It is implemented for Linux (needs libudev) and Windows. The node is reported e.g. as "/dev/sda2" on Linux and as "\\.\PhysicalDriveX" on Windows. Signed-off-by: Tomáš Golembiovský --- qga/commands-posix.c | 7 ++- qga/commands-win32.c | 21 +++---

[Qemu-devel] [PATCH v4 11/11] qga-win: demystify namespace striping

2018-10-04 Thread Tomáš Golembiovský
It was not obvious what exactly the cryptic string copying does to the GUID. This change makes the intent clearer. Signed-off-by: Tomáš Golembiovský --- qga/commands-win32.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/qga/commands-win32.c b/qga/commands-win32.c in

[Qemu-devel] [PATCH v4 02/11] qga-win: handle NULL values

2018-10-04 Thread Tomáš Golembiovský
Handle returned NULLs properly to: - avoid crashes in serialization. - properly report errors to the caller Signed-off-by: Tomáš Golembiovský --- qga/commands-win32.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/qga/commands-win32.c b/qga/commands-win32.c index 9c9

[Qemu-devel] [PATCH v4 03/11] build: rename CONFIG_QGA_NTDDDISK to CONFIG_QGA_NTDDSCSI

2018-10-04 Thread Tomáš Golembiovský
There was inconsistency between commits: 50cbebb9a3 configure: add configure check for ntdddisk.h a3ef3b2272 qga: added bus type and disk location path The first commit added #define CONFIG_QGA_NTDDDISK but the second commit expected the name to be CONFIG_QGA_NTDDSCSI. As a result the code in

[Qemu-devel] [PATCH v4 06/11] configure: add test for libudev

2018-10-04 Thread Tomáš Golembiovský
Signed-off-by: Tomáš Golembiovský --- configure | 22 ++ 1 file changed, 22 insertions(+) diff --git a/configure b/configure index 0f168607e8..ac24cb3975 100755 --- a/configure +++ b/configure @@ -477,6 +477,7 @@ libxml2="" docker="no" debug_mutex="no" libpmem="" +libudev=

[Qemu-devel] [PATCH v4 04/11] qga-win: add debugging information

2018-10-04 Thread Tomáš Golembiovský
The windows code generaly lacks debug information (compared to posix code). This patch adds some related to HW info in guest-get-fsinfo command. Signed-off-by: Tomáš Golembiovský --- qga/commands-win32.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/qga/commands-win32.c b/

[Qemu-devel] [PATCH v4 09/11] qga-win: handle multi-disk volumes

2018-10-04 Thread Tomáš Golembiovský
Probe the volume for disk extents and return list of all disks. Originally only first disk of composite volume was returned. Note that the patch changes get_pci_info() from one state of brokenness into a different state of brokenness. In other words it still does not do what it's supposed to do (s

[Qemu-devel] [PATCH v2 3/3] vl.c: call optional script when exiting

2018-10-04 Thread Dominik Csapak
some users might want to call a script when qemu exits, without listening to a qmp monitor for events when running with --daemonize this option is only available on non windows systems, since there is no fork there and no --daemonize option this can be used for things like external cleanups Signe

[Qemu-devel] [PATCH v2 0/3] add exit-script option to qemu

2018-10-04 Thread Dominik Csapak
this patch series aims to execute a script when qemu exits so that one can do cleanups when using --daemonize without having to use the qmp monitor changes since v1: * refactored as qemu_launch_script, only for non-windows platforms * updated net/tap.c to use qemu_launch_script instead of launch_

Re: [Qemu-devel] [PATCH v2] MAINTAINERS: Add an entry for qemu-options* files in main directory

2018-10-04 Thread Paolo Bonzini
On 04/10/2018 12:53, Thomas Huth wrote: > The file "qemu-options.h", "qemu-options.hx" and "qemu-options-wrapper.h" > in the main directory are currently without maintainer according to our > get_maintainers.pl script. Considering that the command line options are > a public interface and thus quit

[Qemu-devel] [PATCH v4 08/11] qga-win: refactor disk info

2018-10-04 Thread Tomáš Golembiovský
Refactor building of disk info into a function that builds the list and a function that returns infor for single disk. This will be used in future commit that will handle multi-disk volumes. Signed-off-by: Tomáš Golembiovský --- qga/commands-win32.c | 54 +

[Qemu-devel] [PATCH v4 01/11] qga-win: fix crashes when PCI info cannot be retrived

2018-10-04 Thread Tomáš Golembiovský
The guest-get-fsinfo command collects also information about PCI controller where the disk is attached. When this fails for some reasons it tries to return just the partial information. However in certain cases the pointer to the structure was not initialized and was set to NULL. This breaks the se

Re: [Qemu-devel] Hotplug handler

2018-10-04 Thread Igor Mammedov
On Wed, 3 Oct 2018 19:50:58 +0300 Sameeh Jubran wrote: > Hi all, > > I am trying to get the hotplug handler of a pci device in Qemu using > "qdev_get_hotplug_handler" function. This function simply tries to get > the hotplug handler from the parent bus. For some reason it's always > null. Why it

[Qemu-devel] [PATCH v2 1/3] osdep: add qemu_launch_script for executing scripts

2018-10-04 Thread Dominik Csapak
this adds a small function for launching an external script via fork/exec (not available for windows) and is intended for replacing 'launch_script' in net/tap.c and to provide a general way to launch scripts Signed-off-by: Dominik Csapak --- i modeled the windows error after the qemu_fork impleme

[Qemu-devel] [PATCH v2 2/3] tap: use qemu_launch_script instead of launch_script

2018-10-04 Thread Dominik Csapak
Signed-off-by: Dominik Csapak --- changes since v1: * new in v2 net/tap.c | 56 ++-- 1 file changed, 10 insertions(+), 46 deletions(-) diff --git a/net/tap.c b/net/tap.c index cc8525f154..15a0dd65b8 100644 --- a/net/tap.c +++ b/net/tap.c @@ -6

Re: [Qemu-devel] ACPI PCI hotplug table updates

2018-10-04 Thread Igor Mammedov
On Wed, 3 Oct 2018 10:44:20 -0700 open sorcerer <0p3n.s0rc3...@gmail.com> wrote: > Hi, > > I am digging into an issue where qmp_device_del does not actually delete > devices when a guest OS is in prelaunch. This seems to be due to the guest > OS not handling ACPI events because it is not currentl

Re: [Qemu-devel] [RFC v3 00/15] ARM virt: PCDIMM/NVDIMM at 2TB

2018-10-04 Thread David Hildenbrand
>>> Alternative to have a split model is having a floating RAM base for a >>> contiguous initial + device memory (contiguity actually depends on >>> initial RAM size alignment too). This requires significant changes in FW >>> and also potentially impacts the legacy virt address map as we need to >>

Re: [Qemu-devel] [PATCH v2] bitmap: Update count after a merge

2018-10-04 Thread Vladimir Sementsov-Ogievskiy
03.10.2018 23:01, Eric Blake wrote: > On 10/3/18 2:57 PM, John Snow wrote: >     - I always forget to update this field.. We definitely should add some generic check on it somewhere, at least in tests. >>> >>> My suggestion (in another thread) was to enhance >>> x-debug-block-dirty-

Re: [Qemu-devel] [RFC v3 00/15] ARM virt: PCDIMM/NVDIMM at 2TB

2018-10-04 Thread Auger Eric
Hi David, On 10/4/18 2:02 PM, David Hildenbrand wrote: Alternative to have a split model is having a floating RAM base for a contiguous initial + device memory (contiguity actually depends on initial RAM size alignment too). This requires significant changes in FW and also pote

Re: [Qemu-devel] [PATCH 0/2] nbd server: drop old-style negotiation

2018-10-04 Thread Vladimir Sementsov-Ogievskiy
03.10.2018 21:08, Eric Blake wrote: > On 10/3/18 12:59 PM, Vladimir Sementsov-Ogievskiy wrote: >> 03.10.2018 20:32, Eric Blake wrote: >> On 10/3/18 12:02 PM, Vladimir Sementsov-Ogievskiy wrote: >> It's unexpected behavior that without -x option qemu-nbd do old-style >> negotiation. Let's use "" as

Re: [Qemu-devel] [PULL 0/5] NBD patches through 2018-10-03

2018-10-04 Thread Eric Blake
On 10/3/18 4:22 PM, Eric Blake wrote: The following changes since commit dafd95053611aa14dda40266857608d12ddce658: Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2018-10-02 18:27:18 +0100) are available in the Git repository at: git://repo.or.cz/qemu/eric

Re: [Qemu-devel] [PATCH v2] block/vvfat: Fix crash when reporting error about too many files in directory

2018-10-04 Thread Kevin Wolf
Am 24.07.2018 um 13:52 hat Thomas Huth geschrieben: > When using the vvfat driver with a directory that contains too many files, > QEMU currently crashes. This can be triggered like this for example: > > mkdir /tmp/vvfattest > cd /tmp/vvfattest > for ((x=0;x<=513;x++)); do mkdir $x; done > qem

Re: [Qemu-devel] [PATCH 1/1] nbd: fix NBD_CMD_CACHE negitiation according to the NBD specification

2018-10-04 Thread Eric Blake
On 10/4/18 5:03 AM, Denis V. Lunev wrote: Commit bc37b06a5 was made very bad thing, it has been added NBD_FLAG_SEND_CACHE flag for negotiation. Oof. Probably my fault for not doing a careful review against the upstream spec. The problem is that the value of the flag was taken wrong and dire

Re: [Qemu-devel] [PATCH 0/2] nbd server: drop old-style negotiation

2018-10-04 Thread Richard W.M. Jones
On Thu, Oct 04, 2018 at 12:10:17PM +, Vladimir Sementsov-Ogievskiy wrote: > this is a bit more difficult and more overhead than option in Qemu.. But > I don't sure we should care about I think Eric's point is that dropping oldstyle in qemu-nbd isn't really a problem because nbdkit has no plan

[Qemu-devel] [PATCH 0/4] Misc MIPS fixes and improvements for October 2018

2018-10-04 Thread Aleksandar Markovic
From: Aleksandar Markovic This series contains support for DSP R3 availability control and emulation of nanoMIPS EVA instructions. Dimitrije Nikolic (2): target/mips: Add opcodes for nanoMIPS EVA instructions target/mips: Implement emulation of nanoMIPS EVA instructions Stefan Markovic (2):

[Qemu-devel] [PATCH 2/4] target/mips: Add availability control for DSP R3 ASE

2018-10-04 Thread Aleksandar Markovic
From: Stefan Markovic Add infrastructure for availability control for DSP R3 ASE MIPS instructions. Only BPOSGE32C currently belongs to DSP R3 ASE, but this is likely to be changed in near future. Signed-off-by: Aleksandar Markovic --- target/mips/internal.h | 11 --- target/

[Qemu-devel] [PATCH 1/4] target/mips: Add bit definitions for DSP R3 ASE

2018-10-04 Thread Aleksandar Markovic
From: Stefan Markovic Add DSP R3 ASE related bit definition for insn_flags and hflags. Signed-off-by: Aleksandar Markovic --- target/mips/cpu.h | 1 + target/mips/mips-defs.h | 1 + 2 files changed, 2 insertions(+) diff --git a/target/mips/cpu.h b/target/mips/cpu.h index 28af4d1..416069

[Qemu-devel] [PATCH 3/4] target/mips: Add opcodes for nanoMIPS EVA instructions

2018-10-04 Thread Aleksandar Markovic
From: Dimitrije Nikolic Add opcodes for nanoMIPS EVA instructions: CACHEE, LBE, LBUE, LHE, LHUE, LLE, LLWPE, LWE, PREFE, SBE, SCE, SCWPE, SHE, SWE. Signed-off-by: Aleksandar Markovic --- target/mips/translate.c | 16 1 file changed, 16 insertions(+) diff --git a/target/mips/t

[Qemu-devel] [PATCH 4/4] target/mips: Implement emulation of nanoMIPS EVA instructions

2018-10-04 Thread Aleksandar Markovic
From: Dimitrije Nikolic Implement emulation of nanoMIPS EVA instructions. They are all part of P.LS.E0 instruction pool, or one of its subpools. Signed-off-by: Aleksandar Markovic --- target/mips/translate.c | 79 + 1 file changed, 79 insertions(

Re: [Qemu-devel] [PATCH v3 13/18] block: introduce new filter driver: fleecing-hook

2018-10-04 Thread Kevin Wolf
Am 01.10.2018 um 12:29 hat Vladimir Sementsov-Ogievskiy geschrieben: > Fleecing-hook filter does copy-before-write operation. It should be > inserted above active disk and has a target node for CBW, like the > following: > > +---+ > | Guest | > +---+---+ > |r,w > v

Re: [Qemu-devel] [PATCH v3 14/18] block/fleecing-hook: internal api

2018-10-04 Thread Kevin Wolf
Am 01.10.2018 um 12:29 hat Vladimir Sementsov-Ogievskiy geschrieben: > Add some functions to use fleecing-hook internally from backup job in > further commit. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > include/block/block.h | 9 > block/fleecing-hook.c | 51 +++

Re: [Qemu-devel] [PATCH 1/1] nbd: fix NBD_CMD_CACHE negitiation according to the NBD specification

2018-10-04 Thread Vladimir Sementsov-Ogievskiy
04.10.2018 15:27, Eric Blake wrote: > On 10/4/18 5:03 AM, Denis V. Lunev wrote: >> Commit bc37b06a5 was made very bad thing, it has been added >> NBD_FLAG_SEND_CACHE flag for negotiation. > > Oof. Probably my fault for not doing a careful review against the > upstream spec. mostly my, to introduc

Re: [Qemu-devel] [RFC PATCH v2 0/3] acceptance tests: Test firmware checking debug console output

2018-10-04 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > Hi, > > This RFC series add simple acceptance tests which boot SeaBIOS and EDK2 on > the pc and virt/aarch64 default machines > > Still PoC but can be useful for the Avocado team to test the > multi-arch targets. I couldn't get this to work on qemu-test (aarch6

Re: [Qemu-devel] [Qemu-block] [PATCH] nbd/server: fix NBD_CMD_CACHE

2018-10-04 Thread Kevin Wolf
Am 03.10.2018 um 17:10 hat Vladimir Sementsov-Ogievskiy geschrieben: > 03.10.2018 17:57, Eric Blake wrote: > > On 10/3/18 9:47 AM, Vladimir Sementsov-Ogievskiy wrote: > >> We should not go to structured-read branch on CACHE command, fix that. > >> > >> Bug intoroduced in bc37b06a5cde24 "nbd/server:

Re: [Qemu-devel] [PATCH 1/1] nbd: fix NBD_CMD_CACHE negitiation according to the NBD specification

2018-10-04 Thread Denis V . Lunev
s/negitiation/negotiation/ On 10/04/2018 01:03 PM, Denis V. Lunev wrote: > Commit bc37b06a5 was made very bad thing, it has been added > NBD_FLAG_SEND_CACHE flag for negotiation. The problem is that the value > of the flag was taken wrong and directly violates NBD specification. > This value (bit

Re: [Qemu-devel] [PATCH] block: replace "discard" literal with BDRV_OPT_DISCARD macro

2018-10-04 Thread Kevin Wolf
Am 03.10.2018 um 12:23 hat Alberto Garcia geschrieben: > Signed-off-by: Alberto Garcia Thanks, applied to the block branch. Kevin

Re: [Qemu-devel] [RFC PATCH v2 0/3] acceptance tests: Test firmware checking debug console output

2018-10-04 Thread Alex Bennée
Alex Bennée writes: > Philippe Mathieu-Daudé writes: > >> Hi, >> >> This RFC series add simple acceptance tests which boot SeaBIOS and EDK2 on >> the pc and virt/aarch64 default machines >> >> Still PoC but can be useful for the Avocado team to test the >> multi-arch targets. > > I couldn't ge

Re: [Qemu-devel] [PATCH v4 01/11] qga-win: fix crashes when PCI info cannot be retrived

2018-10-04 Thread Marc-André Lureau
Hi On Thu, Oct 4, 2018 at 3:22 PM Tomáš Golembiovský wrote: > > The guest-get-fsinfo command collects also information about PCI > controller where the disk is attached. When this fails for some reasons > it tries to return just the partial information. However in certain > cases the pointer to th

Re: [Qemu-devel] [PATCH v4 03/11] build: rename CONFIG_QGA_NTDDDISK to CONFIG_QGA_NTDDSCSI

2018-10-04 Thread Marc-André Lureau
Hi On Thu, Oct 4, 2018 at 3:22 PM Tomáš Golembiovský wrote: > > There was inconsistency between commits: > > 50cbebb9a3 configure: add configure check for ntdddisk.h > a3ef3b2272 qga: added bus type and disk location path > > The first commit added #define CONFIG_QGA_NTDDDISK but the second c

Re: [Qemu-devel] [RFC PATCH v2 0/3] acceptance tests: Test firmware checking debug console output

2018-10-04 Thread Peter Maydell
On 4 October 2018 at 14:04, Alex Bennée wrote: > > Alex Bennée writes: > >> Philippe Mathieu-Daudé writes: >> >>> Hi, >>> >>> This RFC series add simple acceptance tests which boot SeaBIOS and EDK2 on >>> the pc and virt/aarch64 default machines >>> >>> Still PoC but can be useful for the Avocad

Re: [Qemu-devel] [PATCH v4 02/11] qga-win: handle NULL values

2018-10-04 Thread Marc-André Lureau
Hi On Thu, Oct 4, 2018 at 3:22 PM Tomáš Golembiovský wrote: > > Handle returned NULLs properly to: > - avoid crashes in serialization. > - properly report errors to the caller > > Signed-off-by: Tomáš Golembiovský > --- > qga/commands-win32.c | 9 - > 1 file changed, 8 insertions(+), 1 d

Re: [Qemu-devel] [PATCH v6 00/25] Fixing record/replay and adding reverse debugging

2018-10-04 Thread Artem Pisarenko
No, it didn't changed test results, at least for https://github.com/ispras/qemu/tree/rr-180911 . Even step values it stucks on are same for most runs. Playing with master and my own branch gives different results for tests without sleep=off and -rtc base. It seems that patch you mentioned didn't ch

Re: [Qemu-devel] [PATCH v4 07/11] qga: report disk serial number

2018-10-04 Thread Marc-André Lureau
Hi On Thu, Oct 4, 2018 at 3:22 PM Tomáš Golembiovský wrote: > > The feature is implemented for Windows and Linux. Reporting of serial > number on Linux depends on libudev. > > Example from Linux: > > { > "name": "dm-2", > "mountpoint": "/", > ... > "disk": [ >

Re: [Qemu-devel] [RFC v3 00/15] ARM virt: PCDIMM/NVDIMM at 2TB

2018-10-04 Thread Igor Mammedov
On Thu, 4 Oct 2018 13:32:26 +0200 Auger Eric wrote: > Hi Igor, > > On 10/4/18 1:11 PM, Igor Mammedov wrote: > > On Wed, 3 Oct 2018 15:49:03 +0200 > > Auger Eric wrote: > > > >> Hi, > >> > >> On 7/3/18 9:19 AM, Eric Auger wrote: > >>> This series aims at supporting PCDIMM/NVDIMM intantiatio

Re: [Qemu-devel] [PATCH v4 10/11] qga: return disk device in guest-get-fsinfo

2018-10-04 Thread Marc-André Lureau
Hi On Thu, Oct 4, 2018 at 3:22 PM Tomáš Golembiovský wrote: > > Report device node of the disk. It is implemented for Linux (needs > libudev) and Windows. The node is reported e.g. as "/dev/sda2" on Linux > and as "\\.\PhysicalDriveX" on Windows. > > Signed-off-by: Tomáš Golembiovský > --- > qg

Re: [Qemu-devel] [PATCH v4 04/11] qga-win: add debugging information

2018-10-04 Thread Marc-André Lureau
Hi On Thu, Oct 4, 2018 at 3:22 PM Tomáš Golembiovský wrote: > > The windows code generaly lacks debug information (compared to posix > code). This patch adds some related to HW info in guest-get-fsinfo > command. > > Signed-off-by: Tomáš Golembiovský Reviewed-by: Marc-André Lureau > --- > qg

[Qemu-devel] [Bug 1637974] Re: dead code in pl080 functions

2018-10-04 Thread Thomas Huth
Fixed here: https://git.qemu.org/?p=qemu.git;a=commitdiff;h=156448ab640baaeca18 ** Changed in: qemu Status: Confirmed => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1637974 Ti

Re: [Qemu-devel] [PATCH v4 05/11] qga-win: refactor disk properties (bus)

2018-10-04 Thread Marc-André Lureau
Hi On Thu, Oct 4, 2018 at 3:22 PM Tomáš Golembiovský wrote: > > Refactor code that queries bus type to be more generic. The function > get_disk_bus_type() has been renamed to build_guest_disk_info(). > Following commit(s) will extend this function. > > Signed-off-by: Tomáš Golembiovský > --- >

[Qemu-devel] [Bug 1768246] Re: cpu-exec.c:648: cpu_loop_exec_tb: Assertion `use_icount' failed.

2018-10-04 Thread Thomas Huth
Fix has been committed here: https://git.qemu.org/?p=qemu.git;a=commitdiff;h=5b38d0264064055255db991 ** Changed in: qemu Status: New => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/b

Re: [Qemu-devel] [PATCH v4 06/11] configure: add test for libudev

2018-10-04 Thread Marc-André Lureau
On Thu, Oct 4, 2018 at 3:22 PM Tomáš Golembiovský wrote: > > Signed-off-by: Tomáš Golembiovský Reviewed-by: Marc-André Lureau > --- > configure | 22 ++ > 1 file changed, 22 insertions(+) > > diff --git a/configure b/configure > index 0f168607e8..ac24cb3975 100755 > --- a/

[Qemu-devel] [Bug 1786343] Re: QEMU v3.0.0-rc4 configure fails with --enable-mpath on CentOS 7.5

2018-10-04 Thread Thomas Huth
Fixed here: https://git.qemu.org/?p=qemu.git;a=commitdiff;h=1b0578f5c455d5a95384 ** Changed in: qemu Status: Confirmed => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1786343 T

Re: [Qemu-devel] [PATCH v4 11/11] qga-win: demystify namespace striping

2018-10-04 Thread Marc-André Lureau
Hi On Thu, Oct 4, 2018 at 3:22 PM Tomáš Golembiovský wrote: > > It was not obvious what exactly the cryptic string copying does to the > GUID. This change makes the intent clearer. > > Signed-off-by: Tomáš Golembiovský Reviewed-by: Marc-André Lureau > --- > qga/commands-win32.c | 9 -

Re: [Qemu-devel] [RFC 6/6] virtio-net: rss: Add bpf filter

2018-10-04 Thread Daniel P . Berrangé
On Thu, Sep 06, 2018 at 01:26:01PM +0800, Jason Wang wrote: > > > On 2018年09月04日 16:14, Daniel P. Berrangé wrote: > > On Tue, Sep 04, 2018 at 11:07:38AM +0800, Jason Wang wrote: > > > On 2018年09月03日 19:54, Daniel P. Berrangé wrote: > > > > > + * > > > > > + * This work is licensed under the terms

Re: [Qemu-devel] [PATCH 04/11] net: lance: convert SysBus init method to a realize method

2018-10-04 Thread Thomas Huth
On 2018-09-28 15:49, Cédric Le Goater wrote: > Signed-off-by: Cédric Le Goater > --- > hw/net/lance.c | 8 +++- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/hw/net/lance.c b/hw/net/lance.c > index a08d5ac6a848..f987b2fd180f 100644 > --- a/hw/net/lance.c > +++ b/hw/net/l

[Qemu-devel] [PATCH 2/2] nbd: add all possible transmission flags supported by NBD

2018-10-04 Thread Denis V. Lunev
This is done to avoid silly mistakes like one with wrong value of NBD_FLAG_SEND_CACHE flag. Signed-off-by: Denis V. Lunev CC: Vladimir Sementsov-Ogievskiy CC: Eric Blake CC: Paolo Bonzini --- include/block/nbd.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/block/nbd.h b/incl

[Qemu-devel] [Bug 1716292] Re: User mode emulation returns wrong value for write(fd, NULL, 0)

2018-10-04 Thread Thomas Huth
Fix has been committed here: https://git.qemu.org/?p=qemu.git;a=commitdiff;h=58cfa6c2e6eb51b23cc98 ** Changed in: qemu Status: New => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bug

Re: [Qemu-devel] [PATCH RFC v11 2/2] target/arm: Add support for VCPU event states

2018-10-04 Thread Andrew Jones
On Thu, Sep 27, 2018 at 12:55:51PM -0400, Dongjiu Geng wrote: > This patch extends the qemu-kvm state sync logic with support for > KVM_GET/SET_VCPU_EVENTS, giving access to yet missing SError exception. > And also it can support the exception state migration. > > The SError exception states inclu

Re: [Qemu-devel] [PATCH 1/1] tests: Add migration test for aarch64

2018-10-04 Thread Andrew Jones
On Fri, Sep 28, 2018 at 03:47:35PM -0400, Wei Huang wrote: > This patch adds migration test support for aarch64. The test code, which > implements the same functionality as x86, is booted as a kernel in qemu. > Here are the design choices we make for aarch64: > > * We choose this -kernel approach

Re: [Qemu-devel] [PATCH 1/1] nbd: fix NBD_CMD_CACHE negitiation according to the NBD specification

2018-10-04 Thread Eric Blake
On 10/4/18 7:51 AM, Vladimir Sementsov-Ogievskiy wrote: 04.10.2018 15:27, Eric Blake wrote: On 10/4/18 5:03 AM, Denis V. Lunev wrote: Commit bc37b06a5 was made very bad thing, it has been added NBD_FLAG_SEND_CACHE flag for negotiation. Oof. Probably my fault for not doing a careful review aga

Re: [Qemu-devel] [PATCH 0/1] add exit-script option to qemu

2018-10-04 Thread Daniel P . Berrangé
On Wed, Oct 03, 2018 at 11:13:43AM +0200, Dominik Csapak wrote: > this patch aims to execute a script when qemu exits > so that one can do cleanups when using --daemonize without > having to use the qmp monitor IMHO the idea of cleanup scripts run by QEMU itself is flawed. QEMU will inevitably cra

Re: [Qemu-devel] [PATCH 1/1] tests: Add migration test for aarch64

2018-10-04 Thread Wei Huang
On 10/04/2018 08:48 AM, Andrew Jones wrote: > On Fri, Sep 28, 2018 at 03:47:35PM -0400, Wei Huang wrote: >> This patch adds migration test support for aarch64. The test code, which >> implements the same functionality as x86, is booted as a kernel in qemu. >> Here are the design choices we make

Re: [Qemu-devel] [PATCH v3 13/18] block: introduce new filter driver: fleecing-hook

2018-10-04 Thread Vladimir Sementsov-Ogievskiy
04.10.2018 15:44, Kevin Wolf wrote: > Am 01.10.2018 um 12:29 hat Vladimir Sementsov-Ogievskiy geschrieben: >> Fleecing-hook filter does copy-before-write operation. It should be >> inserted above active disk and has a target node for CBW, like the >> following: >> >> +---+ >> | Guest

Re: [Qemu-devel] [PATCH v3 1/5] display/edid: add edid generator to qemu.

2018-10-04 Thread Eric Blake
On 9/25/18 2:56 AM, Gerd Hoffmann wrote: EDID is a metadata format to describe monitors. On physical hardware the monitor has an eeprom with that data block which can be read over i2c bus. +++ b/Makefile @@ -543,6 +543,8 @@ qemu-bridge-helper$(EXESUF): qemu-bridge-helper.o $(COMMON_LDADDS)

Re: [Qemu-devel] [PATCH v4 0/8] discard blockstats

2018-10-04 Thread Anton Nefedov
ping-2 On 18/9/2018 11:12 AM, Anton Nefedov wrote: > ping > > do you think we might proceed with this? or is there any general doubt > about the idea? > > thanks, > > On 21/8/2018 12:46 PM, Anton Nefedov wrote: >> new in v4: >> - patch 7: discard and write-zeroes code paths had been separa

[Qemu-devel] [PATCH] edid: Ignore built binary

2018-10-04 Thread Eric Blake
Added in commit 72d277a7. Signed-off-by: Eric Blake --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 5668d027824..64efdfd9292 100644 --- a/.gitignore +++ b/.gitignore @@ -107,6 +107,7 @@ /qemu-doc.html /qemu-doc.info /qemu-doc.txt +/qemu-edid /

Re: [Qemu-devel] [PATCH] fpu/softfloat: Replace countLeadingZeros32/64 with clz32/64

2018-10-04 Thread Alex Bennée
Thomas Huth writes: > Our minimum required compiler for compiling QEMU is GCC 4.1 these days, > so we can drop the support for compilers which do not provide the > __builtin_clz*() functions yet. Since the countLeadingZeros32/64 are > then identical to the clz32/64 functions, and we do not have

Re: [Qemu-devel] [PATCH 1/1] tests: Add migration test for aarch64

2018-10-04 Thread Thomas Huth
On 2018-10-04 15:48, Andrew Jones wrote: > On Fri, Sep 28, 2018 at 03:47:35PM -0400, Wei Huang wrote: [...] >> diff --git a/tests/migration/aarch64/Makefile >> b/tests/migration/aarch64/Makefile >> new file mode 100644 >> index 000..d440fa8 >> --- /dev/null >> +++ b/tests/migration/aarch64/Mak

Re: [Qemu-devel] [RFC v3 00/15] ARM virt: PCDIMM/NVDIMM at 2TB

2018-10-04 Thread Dr. David Alan Gilbert
* Igor Mammedov (imamm...@redhat.com) wrote: > On Thu, 4 Oct 2018 13:32:26 +0200 > Auger Eric wrote: > > > Hi Igor, > > > > On 10/4/18 1:11 PM, Igor Mammedov wrote: > > > On Wed, 3 Oct 2018 15:49:03 +0200 > > > Auger Eric wrote: > > > > > >> Hi, > > >> > > >> On 7/3/18 9:19 AM, Eric Auger wr

Re: [Qemu-devel] [Qemu-block] [PATCH] nbd/server: fix NBD_CMD_CACHE

2018-10-04 Thread Eric Blake
On 10/4/18 8:02 AM, Kevin Wolf wrote: Am 03.10.2018 um 17:10 hat Vladimir Sementsov-Ogievskiy geschrieben: 03.10.2018 17:57, Eric Blake wrote: On 10/3/18 9:47 AM, Vladimir Sementsov-Ogievskiy wrote: We should not go to structured-read branch on CACHE command, fix that. Bug intoroduced in bc37

[Qemu-devel] [PATCH] tracetool: Include thread id information in log backend

2018-10-04 Thread Fabiano Rosas
Currently the log backend prints the process id of QEMU at the start of each output line, but since threads share the same PID there is no clear distinction between their outputs. Having the thread id present in the log makes it easier to see when output comes from different threads. E.g.: 12423@

[Qemu-devel] [PULL v2 0/6] NBD patches through 2018-10-03

2018-10-04 Thread Eric Blake
The following changes since commit dafd95053611aa14dda40266857608d12ddce658: Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2018-10-02 18:27:18 +0100) are available in the Git repository at: git://repo.or.cz/qemu/ericb.git tags/pull-nbd-2018-10-03-v2 for you

[Qemu-devel] [PULL v2 6/6] nbd: fix NBD_FLAG_SEND_CACHE value

2018-10-04 Thread Eric Blake
From: "Denis V. Lunev" Commit bc37b06a5 added NBD_CMD_CACHE support, but used the wrong value for NBD_FLAG_SEND_CACHE flag for negotiation. That commit picked bit 8, which had already been assigned by the NBD specification to mean NBD_FLAG_CAN_MULTI_CONN, and which was already implemented in the

Re: [Qemu-devel] [RFC PATCH v2 0/3] acceptance tests: Test firmware checking debug console output

2018-10-04 Thread Cleber Rosa
On 10/4/18 8:58 AM, Alex Bennée wrote: > > Philippe Mathieu-Daudé writes: > >> Hi, >> >> This RFC series add simple acceptance tests which boot SeaBIOS and EDK2 on >> the pc and virt/aarch64 default machines >> >> Still PoC but can be useful for the Avocado team to test the >> multi-arch targ

  1   2   3   >