On 2018-10-03 11:13, Dominik Csapak wrote:
> some users might want to call a script when qemu exits, without listening
> to a qmp monitor for events when running with --daemonize
>
> this can be used for things like external cleanups
>
> Signed-off-by: Dominik Csapak <d.csa...@proxmox.com>
> ---
> qemu-options.hx | 18 ++++++++++++++++++
> vl.c | 45 +++++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 63 insertions(+)
[...]
> @@ -4577,5 +4586,41 @@ int main(int argc, char **argv, char **envp)
> migration_object_finalize();
> /* TODO: unref root container, check all devices are ok */
>
> + if (exit_script) {
> + int pid, status;
> + char *args[5];
> +
> + /* try to launch network script */
> + pid = fork();
> + if (pid < 0) {
> + error_report("could not launch exit script '%s'", exit_script);
> + exit(1);
> + }
> + if (pid == 0) {
> + int open_max = sysconf(_SC_OPEN_MAX), i;
> +
> + for (i = 3; i < open_max; i++) {
> + close(i);
> + }
> + args[0] = (char *)exit_script;
> + args[1] = g_strdup_printf("%d", shutdown_reason);
> + args[2] = g_strdup_printf("%d", shutdown_was_reset);
> + args[3] = qemu_get_vm_name();
> + args[4] = NULL;
> + execv(exit_script, args);
> + _exit(1);
> + } else {
> + while (waitpid(pid, &status, 0) != pid) {
> + /* loop */
> + }
> +
> + if (!WIFEXITED(status) || WEXITSTATUS(status) != 0) {
> + error_report("exit script '%s' failed with status %d",
> + exit_script, status);
> + exit(1);
> + }
> + }
> + }
Our main() function is already huge, so please put this into a separate
function instead (or even better, refactor the launch_script function as
you've mentioned it in the cover letter).
Thanks,
Thomas
