Re: [Qemu-devel] [PATCH v2 0/6] target/arm: Some pieces of support for 32-bit Hyp mode

On 8/20/18 5:30 PM, Peter Maydell wrote: > Now we have virtualization support in the GICv2 emulation, > I thought I'd have a look at how much we were still missing > for being able to enable EL2 support for AArch32. > This set of patches fixes some minor missing pieces: > * AArch32 HACTLR2 > * AA

Re: [Qemu-devel] [PATCH] tests/libqos: Utilize newer glib spawn check

On 2018-08-21 21:05, Eric Blake wrote: > During development, I got a 'make check' failure that claimed: > > qemu-img returned status code 32512 > ** > ERROR:tests/libqos/libqos.c:202:mkimg: assertion failed: (!rc) > > But 32512 is too big for a normal exit status value, which means we > failed to

Re: [Qemu-devel] Modeling a device controlled by combination of GPIO and UART

Thanks Peter. I have set it up such that master device has qemu_irq array which it initializes using qdev_init_gpio_out with number of gpio lines going out and slave device calls qdev_init_gpio_in with a callback that should be called when irq is raised. Then I connect them together at higher leve

Re: [Qemu-devel] [RFC 00/15] s390: vfio-ccw dasd ipl support

On Tue, 21 Aug 2018 15:31:55 -0400 "Jason J. Herne" wrote: > On 08/15/2018 07:48 AM, Cornelia Huck wrote: > > On Thu, 5 Jul 2018 13:25:28 -0400 > > "Jason J. Herne" wrote: > > > >> This is to support booting from vfio-ccw dasd devices. We basically > >> implement > >> the real hardware ipl

[Qemu-devel] [PATCH v1 8/8] s390x/tcg: refactor specification checking

We can fit this nicely into less LOC, without harming readability. Signed-off-by: David Hildenbrand --- target/s390x/translate.c | 34 ++ 1 file changed, 6 insertions(+), 28 deletions(-) diff --git a/target/s390x/translate.c b/target/s390x/translate.c index 27d24

[Qemu-devel] [PATCH v1 7/8] s390x/tcg: fix FP register pair checks

Valid register pairs are 0/2, 1/3, 4/6, 5/7, 8/10, 9/11, 12/14, 13/15. R1/R2 always selects the lower number, so the current checks are not correct as e.g. 2/4 could be selected as a pair. Signed-off-by: David Hildenbrand --- target/s390x/translate.c | 24 1 file change

[Qemu-devel] [PATCH v1 5/8] s390x/tcg: check for AFP-register, BFP and DFP data exceptions

With the annotated functions, we can now easily check this at a central place. DXC 1 is to be injected if an AFP register is used (for a HFP instruction) when AFP is disabled. DXC 2 is to be injected if a BFP instruction is used when AFP is disabled. DXC § is to be injected if a DFP instruction is

[Qemu-devel] [PATCH v1 6/8] s390x/tcg: handle privileged instructions via flags

Let's check this also at a central place. Signed-off-by: David Hildenbrand --- target/s390x/insn-data.def | 138 ++--- target/s390x/translate.c | 83 ++ 2 files changed, 76 insertions(+), 145 deletions(-) diff --git a/target/s390x/insn-data

[Qemu-devel] [PATCH v1 3/8] s390x/tcg: support flags for instructions

Storing flags for instructions allows us to efficiently verify certain properties at a central point. Examples might later be handling if AFP is disabled in CR0, we are not in problem state, or if vector instructions are disabled in CR0. Signed-off-by: David Hildenbrand --- target/s390x/insn-dat

[Qemu-devel] [PATCH v1 2/8] s390x/tcg: store in the TB flags if AFP is enabled

We exit the TB when changing the control registers, so just like PSW bits, this should always be consistent for a TB. Using the PSW bit semantic makes things a lot easier compared to manually defining the sapre, shifted bits. Signed-off-by: David Hildenbrand --- target/s390x/cpu.h | 8

[Qemu-devel] [PATCH v1 1/8] s390x/tcg: factor out and fix DATA exception injection

The DXC is to be stored in the low core, and only in the FPC in case AFP is enabled in CR0. Signed-off-by: David Hildenbrand --- target/s390x/cpu.h | 1 + target/s390x/excp_helper.c | 28 target/s390x/fpu_helper.c | 13 +++-- target/s390x/helper.h

[Qemu-devel] [PULL 02/19] check: Only test ne2000 when it is compiled in

Signed-off-by: Juan Quintela Reviewed-by: Thomas Huth --- tests/Makefile.include | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index b68555e94a..24c8a9b24c 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @

[Qemu-devel] [PATCH v1 4/8] s390x/tcg: add instruction flags for floating point instructions

These flags allow us to later on detect if a DATA program interrupt is to be injected, and which DXC (1,2,3) is to be used. Interestingly, some support FP instructions are considered as HFP instructions (I assume simply because they were available very early). Signed-off-by: David Hildenbrand --

[Qemu-devel] [PULL 00/19] Be able to disable several devices

tags/check/20180822 for you to fetch changes up to 889d52a243fb6f1d19c92dec2c8055a7f4efbe22: check: Only test tpm devices when they are compiled in (2018-08-21 19:52:16 +0200) check/next for 20180822 This patch series enable the

[Qemu-devel] [PATCH v1 0/8] s390x/tcg: instruction flags and AFP registers

I wanted to add AFP-register control related checks for a long time. However, doing these checks in each and every relevant handler is ugly. As I will need similar checks for vector instructions (yes, I'm looking into that but it might take some time), I decided to introduce per-instruction flags,

[Qemu-devel] [PULL 01/19] check: Only test vmxnet3 when it is compiled in

Signed-off-by: Juan Quintela Reviewed-by: Thomas Huth --- tests/Makefile.include | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index 760a0f18b6..b68555e94a 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @

[Qemu-devel] [PULL 07/19] check: Only test ac97 when it is compiled in

Signed-off-by: Juan Quintela Reviewed-by: Thomas Huth --- tests/Makefile.include | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index 386e3db7d7..e90a8a251c 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @

[Qemu-devel] [PULL 03/19] check: Only test eepro100 when it is compiled in

Signed-off-by: Juan Quintela Reviewed-by: Thomas Huth --- tests/Makefile.include | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index 24c8a9b24c..b90041 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @

[Qemu-devel] [PULL 05/19] check: Only test rtl8139 when it is compiled in

test-file-redirector uses rtl8139 in everything except s390. Signed-off-by: Juan Quintela Reviewed-by: Thomas Huth --- tests/Makefile.include | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index 0a7101c0bf..bac1a7efe0

[Qemu-devel] [PULL 10/19] check: Only test ioh3420 when it is compiled in

Signed-off-by: Juan Quintela Reviewed-by: Thomas Huth --- tests/Makefile.include | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index 7d13966055..7891e27849 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @

[Qemu-devel] [PULL 06/19] check: Only test es1370 when it is compiled in

Signed-off-by: Juan Quintela Reviewed-by: Thomas Huth --- tests/Makefile.include | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index bac1a7efe0..386e3db7d7 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @

[Qemu-devel] [PULL 14/19] check: Only test pvpanic when it is compiled in

It was not possible to compile out pvpanic. Use the same trick than applesmc. Signed-off-by: Juan Quintela Reviewed-by: Thomas Huth --- hw/misc/pvpanic.c | 11 --- include/hw/misc/pvpanic.h | 11 ++- tests/Makefile.include| 4 ++-- 3 files changed, 12 insertions(+)

[Qemu-devel] [PULL 04/19] check: Only test pcnet when it is compiled in

Signed-off-by: Juan Quintela Reviewed-by: Thomas Huth --- tests/Makefile.include | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index b90041..0a7101c0bf 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include

Re: [Qemu-devel] [PATCH 1/9] hw/intc/arm_gic: Document QEMU interface

On 8/21/18 3:28 PM, Peter Maydell wrote: > The GICv2's QEMU interface (sysbus MMIO regions, IRQs, > etc) is now quite complicated with the addition of the > virtualization extensions. Add a comment in the header > file which documents it. > > Signed-off-by: Peter Maydell > --- > I needed to wri

[Qemu-devel] [PULL 12/19] check: Only test sdhci when it is compiled in

Signed-off-by: Juan Quintela Reviewed-by: Thomas Huth --- tests/Makefile.include | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index d5029c4aaa..9fcd4ce24b 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include

[Qemu-devel] [PULL 08/19] check: Only test hda when it is compiled in

Signed-off-by: Juan Quintela Reviewed-by: Thomas Huth --- tests/Makefile.include | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index e90a8a251c..ff8534056a 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @

[Qemu-devel] [PULL 09/19] check: Only test ipack when it is compiled in

Signed-off-by: Juan Quintela Reviewed-by: Thomas Huth --- tests/Makefile.include | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index ff8534056a..7d13966055 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.inclu

[Qemu-devel] [PULL 11/19] check: Only test i82801b11 when it is compiled in

Signed-off-by: Juan Quintela Reviewed-by: Thomas Huth --- tests/Makefile.include | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index 7891e27849..d5029c4aaa 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @

[Qemu-devel] [PULL 19/19] check: Only test tpm devices when they are compiled in

Signed-off-by: Juan Quintela Reviewed-by: Thomas Huth --- tests/Makefile.include | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index de296ed3e1..6dc8d06f4c 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.inclu

Re: [Qemu-devel] [PATCH 3/9] hw/arm/vexpress: Connect VIRQ and VFIQ

On 8/21/18 3:28 PM, Peter Maydell wrote: > Connect the VIRQ and VFIQ lines from the GIC to the CPU; > these exist always for both CPU and GIC whether the > virtualization extensions are enabled or not, so we > can just unconditionally connect them. > > Signed-off-by: Peter Maydell Reviewed-by: L

Re: [Qemu-devel] [PATCH V11 15/20] net/net.c: Add net client type check function for COLO

On 2018年08月21日 17:26, Zhang Chen wrote: On Tue, Aug 21, 2018 at 11:27 AM Jason Wang > wrote: On 2018年08月12日 04:59, Zhang Chen wrote: > From: Zhang Chen mailto:chen.zh...@intel.com>> > > We add is_colo_support_client_type() to check the net clie

[Qemu-devel] [PULL 13/19] check: Only test wdt_ib700 when it is compiled in

Signed-off-by: Juan Quintela Reviewed-by: Thomas Huth --- tests/Makefile.include | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index 9fcd4ce24b..da153ac566 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @

Re: [Qemu-devel] [PATCH 2/9] hw/intc/arm_gic: Make per-cpu GICH memory regions 0x200 bytes large

On 8/21/18 3:28 PM, Peter Maydell wrote: > Reduce the size of the per-cpu GICH memory regions from 0x1000 > to 0x200. The registers only cover 0x200 bytes, and the Cortex-A15 > wants to map them at a spacing of 0x200 bytes apart. Having the > region be too large interferes with mapping them like

Re: [Qemu-devel] [PATCH 5/9] hw/arm/fsl-imx6ul: Connect VIRQ and VFIQ

On 8/21/18 3:28 PM, Peter Maydell wrote: > Connect the VIRQ and VFIQ lines from the GIC to the CPU; > these exist always for both CPU and GIC whether the > virtualization extensions are enabled or not, so we > can just unconditionally connect them. > > Signed-off-by: Peter Maydell Reviewed-by:

[Qemu-devel] [PULL 15/19] check: Only test nvme when it is compiled in

Signed-off-by: Juan Quintela Reviewed-by: Thomas Huth --- tests/Makefile.include | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index 5d50bf1074..fcccd12ff3 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @

[Qemu-devel] [PULL 16/19] check: Only test usb-ohci when it is compiled in

Signed-off-by: Juan Quintela Reviewed-by: Thomas Huth --- tests/Makefile.include | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index fcccd12ff3..fc32a68ee9 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.inclu

Re: [Qemu-devel] [PATCH 6/9] hw/arm/fsl-imx6ul: Connect VIRQ and VFIQ

On 8/21/18 3:28 PM, Peter Maydell wrote: > Connect the VIRQ and VFIQ lines from the GIC to the CPU; > these exist always for both CPU and GIC whether the > virtualization extensions are enabled or not, so we > can just unconditionally connect them. > > Signed-off-by: Peter Maydell Reviewed-by:

Re: [Qemu-devel] [PATCH v2 1/3] qapi: add x-query-block-graph

On 2018-08-20 20:38, Vladimir Sementsov-Ogievskiy wrote: > 20.08.2018 16:44, Max Reitz wrote: >> On 2018-08-20 12:20, Vladimir Sementsov-Ogievskiy wrote: >>> 18.08.2018 00:03, Max Reitz wrote: On 2018-08-17 22:32, Eric Blake wrote: > On 08/17/2018 01:04 PM, Vladimir Sementsov-Ogievskiy wro

Re: [Qemu-devel] [PATCH 8/9] hw/arm/vexpress: Don't set info->secure_boot if CPU doesn't have EL3

On 8/21/18 3:28 PM, Peter Maydell wrote: > Don't request that the arm_load_kernel() code should boot in secure > state if the CPU doesn't have a secure state. Currently this > doesn't make a difference because the boot.c code only examines > the secure_boot flag in code guarded by an ARM_FEATURE_

Re: [Qemu-devel] [PATCH 7/9] hw/cpu/a15mpcore: If CPU has EL2, enable it on the GIC and wire it up

On 8/21/18 3:28 PM, Peter Maydell wrote: > For the A15MPCore internal peripheral object, we handle GIC > security extensions support by checking whether the CPUs > have EL3 enabled; if so then we enable it also on the GIC. > Handle the virtualization extensions in the same way: if the > CPU has E

[Qemu-devel] [PULL 17/19] check: Only test usb-uhci devices when they are compiled in

Signed-off-by: Juan Quintela Reviewed-by: Thomas Huth --- tests/Makefile.include | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index fc32a68ee9..0b8fb4637c 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.inclu

Re: [Qemu-devel] [PATCH 9/9] hw/arm/vexpress: Add "virtualization" property controlling presence of EL2

On 8/21/18 3:28 PM, Peter Maydell wrote: > Add a "virtualization" property to the vexpress-a15 board, > controlling presence of EL2. As with EL3, we default to > enabling it, but the user can disable it if they have an > older guest which can't cope with it being present. > > Signed-off-by: Pete

[Qemu-devel] [PULL 18/19] check: Only test usb-ehci when it is compiled in

The ehci test also test uhci. Welcome to the worderfull world of USB. Signed-off-by: Juan Quintela Reviewed-by: Thomas Huth --- tests/Makefile.include | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index 0b8fb4637c..de296e

[Qemu-devel] [PATCH] hw/scsi/mptsas: Classify the device as "storage"

Each device should ideally have a category, so put the mptsas1068 device into the "storage" category. Signed-off-by: Thomas Huth --- hw/scsi/mptsas.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/scsi/mptsas.c b/hw/scsi/mptsas.c index 4176e87..929404f 100644 --- a/hw/scsi/mptsas.c +++ b

Re: [Qemu-devel] [PATCH V11 16/20] filter: Add handle_event method for NetFilterClass

On 2018年08月21日 17:25, Zhang Chen wrote: On Tue, Aug 21, 2018 at 11:30 AM Jason Wang wrote: On 2018年08月12日 04:59, Zhang Chen wrote: Filter needs to process the event of checkpoint/failover or other event passed by COLO frame. Signed-off-by: zhanghailiang --- include/net/filter.h | 5

Re: [Qemu-devel] [PATCH 4/9] hw/arm/highbank: Connect VIRQ and VFIQ

On 8/21/18 3:28 PM, Peter Maydell wrote: > Connect the VIRQ and VFIQ lines from the GIC to the CPU; > these exist always for both CPU and GIC whether the > virtualization extensions are enabled or not, so we > can just unconditionally connect them. > > Signed-off-by: Peter Maydell Reviewed-by: L

Re: [Qemu-devel] [PATCH] Remove deprecated -balloon option

On 21.08.2018 12:05, Thomas Huth wrote: > The "-balloon" option has been replaced by "-device virtio-balloon". > It's been marked as deprecated since two releases, and nobody > complained, so let's remove it now. > > Signed-off-by: Thomas Huth > --- > docs/virtio-balloon-stats.txt | 6 +++--- >

Re: [Qemu-devel] [PULL 27/74] checkpatch: allow space in more places before a bracket

On 21/08/2018 20:38, Linus Torvalds wrote: > This is commit 38dca988bb20 ("checkpatch: allow space between colon > and bracket") upstream, why is that not mentioned anywhere? Trivially because I used "git commit -c" instead of "git cherry-pick" (I don't remember exactly why, probably I did the pat

Re: [Qemu-devel] [PATCH] qapi/migration.json: fix the description for "query-migrate" output

wrote: > From: jialina01 > > In the return for command "query-migrate", time information like > "total-time", "setup-time", "downtime", is not included in ram > json-object. > > So fix the description in migration.json by unpacking those information > from ram json-object. > > Signed-off-by: jial

Re: [Qemu-devel] [PATCH] migrate/cpu-throttle: Add max-cpu-throttle migration parameter

Li Qiang wrote: > Currently, the default maximum CPU throttle for migration is > 99(CPU_THROTTLE_PCT_MAX). This is too big and can make a remarkable > performance effect for the guest. We see a lot of packets latency > exceed 500ms when the CPU_THROTTLE_PCT_MAX reached. This patch set > adds a new

[Qemu-devel] [PATCH] pc: acpi: revert back to 1 SRAT entry for hotpluggable area

Commit 10efd7e108 "pc: acpi: fix memory hotplug regression by reducing stub SRAT entry size" attemped to fix hotplug regression introduced by 848a1cc1e "hw/acpi-build: build SRAT memory affinity structures for DIMM devices" fixed issue for Windows/3.0+ linux kernels, however it regressed 2.6

Re: [Qemu-devel] [PATCH 3/3] ui: remove support for SDL1.2 in favour of SDL2

On Wed, Aug 08, 2018 at 02:51:01PM +0100, Peter Maydell wrote: > On 8 August 2018 at 11:49, Daniel P. Berrangé wrote: > > SDL1.2 was deprecated in the 2.12.0 release with: > > > > commit e52c6ba34149b4f39c3fd60e59ee32b809db2bfa > > Author: Daniel P. Berrange > > Date: Mon Jan 15 14:25:33

[Qemu-devel] [PATCH v3 01/10] configure: We don't want to clean configuration files

If you don't want to compile everything, you configure config-devices.mak. And then make clean remove it, and make will create a default one without your configuration. Fix it by not removing it on clean target. Remove it instead on distclean. Signed-off-by: Juan Quintela -- Remove it instea

[Qemu-devel] [PATCH v3 04/10] check: Only test usb-xhci-nec when it is compiled in

Signed-off-by: Juan Quintela --- tests/Makefile.include | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index 15296be246..9a918f7655 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @@ -290,8 +290,9 @@ en

[Qemu-devel] [PATCH v3 03/10] check: Only test isa-testdev when it is compiled in

Once there, untangle endianness-test and boot-serial-test. Signed-off-by: Juan Quintela -- boot-serial-test don't depend on isa-testdev. Thanks Thomas. Signed-off-by: Juan Quintela --- tests/Makefile.include | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) dif

[Qemu-devel] [PATCH v3 02/10] check: Use land/lor when possible

So everythig is (a bit) more consistent Signed-off-by: Juan Quintela --- tests/Makefile.include | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index 6dc8d06f4c..a705793381 100644 --- a/tests/Makefile.include +++ b/

[Qemu-devel] [PATCH v3 00/10] Don't check disabled drivers

Hi In this v3 series: - Redo the make clean removal of config-devices.mak - Remove the CONFIG_SERIAL bits, real solution require more thought (I tried to run boot-serial-test on all the architectures with serial and it was not good). Too many coments, will try to do some cleanup first. -

[Qemu-devel] [PATCH v3 05/10] x86_64-softmmu: Configuration is identical to i386-softmmu

If we ever changed that, just make the things that are different explicit. Signed-off-by: Juan Quintela --- default-configs/x86_64-softmmu.mak | 67 +- 1 file changed, 1 insertion(+), 66 deletions(-) diff --git a/default-configs/x86_64-softmmu.mak b/default-configs/

[Qemu-devel] [PATCH v3 08/10] check: Move VMXNET3 test to common

We protect it with CONFIG_VMXNET3_PCI now, so no need to also put it on i386. Signed-off-by: Juan Quintela --- tests/Makefile.include | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index d524e1bdeb..91ffde3103 100644 --- a/

[Qemu-devel] [PATCH v3 06/10] check: Only test ivshm when it is compiled in

Signed-off-by: Juan Quintela --- tests/Makefile.include | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index 9a918f7655..116e93cdb6 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @@ -243,8 +243,8 @@ gcov-

[Qemu-devel] [PATCH v3 10/10] check: Move wdt_ib700 test to common

It is protected by CONFIG_WDT_IB700. Signed-off-by: Juan Quintela --- tests/Makefile.include | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index f646cd0524..adfce0be95 100644 --- a/tests/Makefile.include +++ b/tests/Makefi

[Qemu-devel] [PATCH v3 07/10] check: Only test boot-serial when sga is compiled in

This is only for x86* architecture. Signed-off-by: Juan Quintela --- tests/Makefile.include | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index 116e93cdb6..d524e1bdeb 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.in

[Qemu-devel] [PATCH v3 09/10] check: Move endianess test to common

It is already protected by CONFIG_ISA_TESTDEV in all architectures. Signed-off-by: Juan Quintela --- tests/Makefile.include | 14 +- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index 91ffde3103..f646cd0524 100644 --- a

Re: [Qemu-devel] [PATCH v6 01/11] migration: disable RDMA WRITE after postcopy started

Lidong Chen wrote: > From: Lidong Chen > > RDMA WRITE operations are performed with no notification to the destination > qemu, then the destination qemu can not wakeup. This patch disable RDMA WRITE > after postcopy started. > > Signed-off-by: Lidong Chen > Reviewed-by: Dr. David Alan Gilbert

Re: [Qemu-devel] [PATCH v6 04/11] migration: Stop rdma yielding during incoming postcopy

Lidong Chen wrote: > From: Lidong Chen > > During incoming postcopy, the destination qemu will invoke > qemu_rdma_wait_comp_channel in a seprate thread. So does not use rdma > yield, and poll the completion channel fd instead. > > Signed-off-by: Lidong Chen > Reviewed-by: Dr. David Alan Gilbert

Re: [Qemu-devel] [PATCH] pc: acpi: revert back to 1 SRAT entry for hotpluggable area

On 08/22/18 11:46, Igor Mammedov wrote: > Commit > 10efd7e108 "pc: acpi: fix memory hotplug regression by reducing stub SRAT > entry size" > attemped to fix hotplug regression introduced by > 848a1cc1e "hw/acpi-build: build SRAT memory affinity structures for DIMM > devices" > > fixed issue

Re: [Qemu-devel] [PATCH v6 05/11] migration: implement io_set_aio_fd_handler function for RDMA QIOChannel

Lidong Chen wrote: > From: Lidong Chen > > if qio_channel_rdma_readv return QIO_CHANNEL_ERR_BLOCK, the destination qemu > crash. > > The backtrace is: > (gdb) bt > #0 0x in ?? () > #1 0x008db50e in qio_channel_set_aio_fd_handler (ioc=0x38111e0, > ctx=0x3726080,

Re: [Qemu-devel] [PATCH v6 06/11] migration: invoke qio_channel_yield only when qemu_in_coroutine()

Lidong Chen wrote: > From: Lidong Chen > > when qio_channel_read return QIO_CHANNEL_ERR_BLOCK, the source qemu crash. > > The backtrace is: > (gdb) bt > #0 0x7fb20aba91d7 in raise () from /lib64/libc.so.6 > #1 0x7fb20abaa8c8 in abort () from /lib64/libc.so.6 > #2 0x

Re: [Qemu-devel] [PATCH v6 07/11] migration: poll the cm event while wait RDMA work request completion

Lidong Chen wrote: > From: Lidong Chen > > If the peer qemu is crashed, the qemu_rdma_wait_comp_channel function > maybe loop forever. so we should also poll the cm event fd, and when > receive RDMA_CM_EVENT_DISCONNECTED and RDMA_CM_EVENT_DEVICE_REMOVAL, > we consider some error happened. > > Sig

Re: [Qemu-devel] [PATCH v3 01/10] configure: We don't want to clean configuration files

On 2018-08-22 11:54, Juan Quintela wrote: > If you don't want to compile everything, you configure > config-devices.mak. And then make clean remove it, and make will > create a default one without your configuration. Fix it by not > removing it on clean target. Remove it instead on distclean. S

Re: [Qemu-devel] [PATCH v6 08/11] migration: implement the shutdown for RDMA QIOChannel

Lidong Chen wrote: > From: Lidong Chen > > Because RDMA QIOChannel not implement shutdown function, > If the to_dst_file was set error, the return path thread > will wait forever. and the migration thread will wait > return path thread exit. > > the backtrace of return path thread is: > > (gdb) b

Re: [Qemu-devel] [PATCH] tests/migration-test: Turn kvm_hv message into a g_debug message

Thomas Huth wrote: > When running "make check" on a non-POWER host, there is currently an ugly > line in the output like this: > > [...] > GTESTER check-qtest-nios2 > GTESTER check-qtest-or1k > GTESTER check-qtest-ppc64 > Skipping test: kvm_hv not available Skipping test: kvm_hv not availa

Re: [Qemu-devel] [PATCH v3 02/10] check: Use land/lor when possible

On 2018-08-22 11:54, Juan Quintela wrote: > So everythig is (a bit) more consistent > > Signed-off-by: Juan Quintela > --- > tests/Makefile.include | 12 > 1 file changed, 4 insertions(+), 8 deletions(-) [...] > @@ -299,9 +297,7 @@ check-qtest-i386-y += tests/q35-test$(EXESUF) > ch

Re: [Qemu-devel] Slow boot in QEMU with virtio-scsi disks

On Sat, 11 Aug 2018 19:39:56 +0200 Oleksandr Natalenko wrote: > Hi. > > On 11.08.2018 14:23, Ming Lei wrote: > > Please test for-4.19/block: > > > > https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git/log/?h=for-4.19/block > > > > This slow boot issue should have been fixed b

Re: [Qemu-devel] [PATCH v3 03/10] check: Only test isa-testdev when it is compiled in

On 2018-08-22 11:54, Juan Quintela wrote: > Once there, untangle endianness-test and boot-serial-test. > > Signed-off-by: Juan Quintela > > -- > > boot-serial-test don't depend on isa-testdev. Thanks Thomas. > > Signed-off-by: Juan Quintela Please remove the duplicated Sob. > @@ -321,15 +3

Re: [Qemu-devel] [PATCH v4 02/10] migration: fix counting normal page for compression

guangrong.x...@gmail.com wrote: > From: Xiao Guangrong > > The compressed page is not normal page > > Reviewed-by: Peter Xu > Signed-off-by: Xiao Guangrong Reviewed-by: Juan Quintela

Re: [Qemu-devel] [PATCH v4 03/10] migration: introduce save_zero_page_to_file

guangrong.x...@gmail.com wrote: > From: Xiao Guangrong > > It will be used by the compression threads > > Reviewed-by: Peter Xu Reviewed-by: Juan Quintela > Signed-off-by: Xiao Guangrong > --- > migration/ram.c | 40 ++-- > 1 file changed, 30 insertions(+)

Re: [Qemu-devel] [PATCH v3 04/10] check: Only test usb-xhci-nec when it is compiled in

On 2018-08-22 11:54, Juan Quintela wrote: > Signed-off-by: Juan Quintela > --- > tests/Makefile.include | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/tests/Makefile.include b/tests/Makefile.include > index 15296be246..9a918f7655 100644 > --- a/tests/Makefile.i

Re: [Qemu-devel] [PATCH v4 04/10] migration: drop the return value of do_compress_ram_page

guangrong.x...@gmail.com wrote: > From: Xiao Guangrong > > It is not used and cleans the code up a little > > Reviewed-by: Peter Xu > Signed-off-by: Xiao Guangrong Reviewed-by: Juan Quintela

Re: [Qemu-devel] [PATCH v3 05/10] x86_64-softmmu: Configuration is identical to i386-softmmu

On 2018-08-22 11:54, Juan Quintela wrote: > If we ever changed that, just make the things that are different > explicit. > > Signed-off-by: Juan Quintela > --- > default-configs/x86_64-softmmu.mak | 67 +- > 1 file changed, 1 insertion(+), 66 deletions(-) Reviewed-by

Re: [Qemu-devel] [PATCH v4 06/10] migration: hold the lock only if it is really needed

guangrong.x...@gmail.com wrote: > From: Xiao Guangrong > > Try to hold src_page_req_mutex only if the queue is not > empty > > Reviewed-by: Dr. David Alan Gilbert > Reviewed-by: Peter Xu > Signed-off-by: Xiao Guangrong Reviewed-by: Juan Quintela

Re: [Qemu-devel] [PATCH v4 05/10] migration: move handle of zero page to the thread

guangrong.x...@gmail.com wrote: > From: Xiao Guangrong > > Detecting zero page is not a light work, moving it to the thread to > speed the main thread up, btw, handling ram_release_pages() for the > zero page is moved to the thread as well > > Reviewed-by: Peter Xu > Signed-off-by: Xiao Guangrong

Re: [Qemu-devel] [PATCH v4 01/10] migration: do not wait for free thread

guangrong.x...@gmail.com wrote: > From: Xiao Guangrong > > Instead of putting the main thread to sleep state to wait for > free compression thread, we can directly post it out as normal > page that reduces the latency and uses CPUs more efficiently > > A parameter, compress-wait-thread, is introdu

Re: [Qemu-devel] [PATCH v3 06/10] check: Only test ivshm when it is compiled in

On 2018-08-22 11:54, Juan Quintela wrote: > Signed-off-by: Juan Quintela > --- > tests/Makefile.include | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/tests/Makefile.include b/tests/Makefile.include > index 9a918f7655..116e93cdb6 100644 > --- a/tests/Makefile.incl

Re: [Qemu-devel] [PATCH] char: Enable build of pty on macOS

On 21/08/2018 20:29, Peter Maydell wrote: >> >> #if defined(__linux__) || defined(__sun__) || defined(__FreeBSD__) \ >> || defined(__NetBSD__) || defined(__OpenBSD__) || >> defined(__DragonFly__) \ >> -|| defined(__GLIBC__) >> +|| defined(__GLIBC__) || defined(__APPLE__) > We sh

Re: [Qemu-devel] [PATCH v3 08/10] check: Move VMXNET3 test to common

On 2018-08-22 12:41, Juan Quintela wrote: > Thomas Huth wrote: >> On 2018-08-22 11:54, Juan Quintela wrote: >>> We protect it with CONFIG_VMXNET3_PCI now, so no need to also put it >>> on i386. >>> >>> Signed-off-by: Juan Quintela >>> --- >>> tests/Makefile.include | 4 ++-- >>> 1 file changed,

Re: [Qemu-devel] [PATCH v3 08/10] check: Move VMXNET3 test to common

Thomas Huth wrote: > On 2018-08-22 11:54, Juan Quintela wrote: >> We protect it with CONFIG_VMXNET3_PCI now, so no need to also put it >> on i386. >> >> Signed-off-by: Juan Quintela >> --- >> tests/Makefile.include | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a

[Qemu-devel] [PATCH] char-pty: remove unnecessary #ifdef

For some reason __APPLE__ was not checked in pty code. However, the #ifdef is redundant: this file is already compiled only if CONFIG_POSIX, same as util/qemu-openpty.c which it uses. Reported-by: Roman Bolshakov Signed-off-by: Paolo Bonzini --- chardev/char-pty.c | 6 -- 1 file changed, 6

Re: [Qemu-devel] [PATCH v3 09/10] check: Move endianess test to common

On 2018-08-22 11:54, Juan Quintela wrote: > It is already protected by CONFIG_ISA_TESTDEV in all architectures. > > Signed-off-by: Juan Quintela > --- > tests/Makefile.include | 14 +- > 1 file changed, 1 insertion(+), 13 deletions(-) > > diff --git a/tests/Makefile.include b/tests/

Re: [Qemu-devel] [PATCH v3 10/10] check: Move wdt_ib700 test to common

On 2018-08-22 11:54, Juan Quintela wrote: > It is protected by CONFIG_WDT_IB700. > > Signed-off-by: Juan Quintela > --- > tests/Makefile.include | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tests/Makefile.include b/tests/Makefile.include > index f646cd0524..adfce

Re: [Qemu-devel] [libvirt] clean/simple Q35 support in libvirt+QEMU for guest OSes that don't support virtio-1.0

On Tue, 2018-08-21 at 14:21 -0400, Laine Stump wrote: > On 08/17/2018 06:35 AM, Andrea Bolognani wrote: > > If we decide we want to explicitly spell out the options instead > > of relying on QEMU changing behavior based on the slot type, which > > is probably a good idea anyway, I think we should h

Re: [Qemu-devel] [PATCH v3 08/10] check: Move VMXNET3 test to common

On 2018-08-22 11:54, Juan Quintela wrote: > We protect it with CONFIG_VMXNET3_PCI now, so no need to also put it > on i386. > > Signed-off-by: Juan Quintela > --- > tests/Makefile.include | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tests/Makefile.include b/tests

Re: [Qemu-devel] [PATCH v3 07/10] check: Only test boot-serial when sga is compiled in

On 2018-08-22 11:54, Juan Quintela wrote: > This is only for x86* architecture. > > Signed-off-by: Juan Quintela > --- > tests/Makefile.include | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/Makefile.include b/tests/Makefile.include > index 116e93cdb6..d524e1bdeb

Re: [Qemu-devel] [PATCH 2/7] jobs: canonize Error object

On 2018-08-21 02:10, John Snow wrote: > > > On 08/17/2018 03:04 PM, John Snow wrote: >> +error_setg_errno(&job->err, -job->ret, "job failed"); > > Kevin specifically asked for me to change this, and I lost it in the > shuffle. I'll send a v3 now, since there are enough nits to warran

Re: [Qemu-devel] [libvirt] clean/simple Q35 support in libvirt+QEMU for guest OSes that don't support virtio-1.0

On Wed, Aug 22, 2018 at 12:36:27PM +0200, Andrea Bolognani wrote: > On Tue, 2018-08-21 at 14:21 -0400, Laine Stump wrote: > > On 08/17/2018 06:35 AM, Andrea Bolognani wrote: > > > If we decide we want to explicitly spell out the options instead > > > of relying on QEMU changing behavior based on th

Re: [Qemu-devel] [PATCH 1/7] jobs: change start callback to run callback

On 2018-08-17 21:04, John Snow wrote: > Presently we codify the entry point for a job as the "start" callback, > but a more apt name would be "run" to clarify the idea that when this > function returns we consider the job to have "finished," except for > any cleanup which occurs in separate callbac

Re: [Qemu-devel] [PATCH 2/7] jobs: canonize Error object

On 2018-08-17 21:04, John Snow wrote: > Jobs presently use both an Error object in the case of the create job, > and char strings in the case of generic errors elsewhere. > > Unify the two paths as just j->err, and remove the extra argument from > job_completed. The integer error code for job_comp

Re: [Qemu-devel] [PATCH 2/7] jobs: canonize Error object

On 2018-08-17 21:04, John Snow wrote: > Jobs presently use both an Error object in the case of the create job, > and char strings in the case of generic errors elsewhere. > > Unify the two paths as just j->err, and remove the extra argument from > job_completed. The integer error code for job_comp

Re: [Qemu-devel] [PATCH] ppc: Remove deprecated ppcemb target

On Tue, Aug 21, 2018 at 01:27:48PM +0200, Thomas Huth wrote: > There is no known available OS for ppc around anymore that uses page > sizes below 4k, so it does not make much sense that we keep wasting > our time on building and testing the ppcemb-softmmu target. It has > been deprecated since two

Re: [Qemu-devel] [PATCH 3/7] jobs: add exit shim

On 2018-08-17 21:04, John Snow wrote: > All jobs do the same thing when they leave their running loop: > - Store the return code in a structure > - wait to receive this structure in the main thread > - signal job completion via job_completed > > Few jobs do anything beyond exactly this. Consolidat

  1   2   3   >