Hi,
> b) Rather than a "legacy-only" model for virtio-0.9, it would be more
> useful to have "transitional". This way the config would work for older
> OSes that don't support virtio-1.0, and when/if the OS was upgraded such
> that it supported virtio-1.0, that would be automatically used withou
Markus Armbruster writes:
> Eric Blake writes:
>
>> On 08/10/2018 10:48 AM, Eric Blake wrote:
>>> On 08/08/2018 07:03 AM, Markus Armbruster wrote:
This is consistent with qobject_to_json(). See commit e2ec3f97680.
>>>
>>> Side note: that commit mentions that on output, ASCII DEL (0x7f) is
On 18.07.2018 08:33, Howard Spoelstra wrote:
> Hi all,
>
> I have two issues when cross compiling current master for Windows with
> mingw 8.1. Host is Fedora29. See further below for gcc and mingw
> versions.
>
> Reproduce with:
> ./configure --cross-prefix=x86_64-w64-mingw32-
> --target-list="pp
While adding the object_initialize_child() function, Paolo suggested
to rename the similar object_new_with_props() function accordingly:
http://marc.info/?i=e034610d-9a1d-a8a5-ee92-b2e3f0ba2...@redhat.com
This way it is more obvious that this function creates a new object
as a child of another ob
On Fri, Aug 17, 2018 at 9:32 AM, David Hildenbrand wrote:
> On 18.07.2018 08:33, Howard Spoelstra wrote:
>> Hi all,
>>
>> I have two issues when cross compiling current master for Windows with
>> mingw 8.1. Host is Fedora29. See further below for gcc and mingw
>> versions.
>>
>> Reproduce with:
>>
On 16/08/2018 20:15, Alex Williamson wrote:
> On Tue, 7 Aug 2018 13:31:23 -0600
> Alex Williamson wrote:
>
>> Remove KVM specific tests in balloon_page(), instead marking
>> ballooning as inhibited without KVM_CAP_SYNC_MMU support.
>>
>> Reviewed-by: David Hildenbrand
>> Reviewed-by: Peter Xu
On Thu, Aug 16, 2018 at 03:01:31PM -0500, Eric Blake wrote:
>> +}
>> +if (!has_size) {
>> +struct stat s;
>> +if (fstat(fd, &s)) {
>> +error_setg_errno(errp, errno, "could not fstat fd to get size");
>> +goto exit;
>> +}
>> +size = s.s
Really? How to mount a blk device to /dev/nbdN?
I always find tips to mount from file-like image to /dev/nbdN
2018-08-16 19:46 GMT+08:00 Eric Blake :
> On 08/16/2018 03:22 AM, Daniel P. Berrangé wrote:
>
>> On Thu, Aug 16, 2018 at 09:35:52AM +0800, lampahome wrote:
>>
>>> We all know there's a fi
Eric Blake writes:
> On 08/08/2018 07:03 AM, Markus Armbruster wrote:
>> The JSON parser has three public headers, json-lexer.h, json-parser.h,
>> json-streamer.h. They all contain stuff that is of no interest
>> outside qobject/json-*.c.
>>
>> Collect the public interface in include/qapi/qmp/js
Sync linux headers to 5c60a7389d79 ("Merge tag 'for-linus-4.19-ofs1' of
git://git.kernel.org/pub/scm/linux/kernel/git/hubcap/linux").
Signed-off-by: Jason Wang
---
include/standard-headers/drm/drm_fourcc.h | 176 +
include/standard-headers/linux/ethtool.h | 1
This patch tries to switch to use new kernel IOTLB format V2. Previous
version may have inconsistent ABI between 32bit and 64bit machines
because of the hole after type field. Refer kernel commit
("429711aec282 vhost: switch to use new message format") for more
information.
To enable this feature,
Eric Blake writes:
> On 08/08/2018 07:03 AM, Markus Armbruster wrote:
>> Section "QGA Synchronization" specifies that sending "a raw 0xFF
>> sentinel byte" makes the server "reset its state and discard all
>> pending data prior to the sentinel." What actually happens there is a
>> lexical error,
On 16 August 2018 at 18:48, Aleksandar Markovic
wrote:
> From: Aleksandar Markovic
>
> The following changes since commit c542a9f9794ec8e0bc3fcf5956d3cc8bce667789:
>
> Merge remote-tracking branch 'remotes/armbru/tags/pull-tests-2018-08-16'
> into staging (2018-08-16 09:50:54 +0100)
>
> are av
On Thu, Aug 16, 2018 at 03:44:54PM -0400, Phillip Susi wrote:
> On 8/16/2018 1:27 PM, Daniel P. Berrangé wrote:
> > Did you actually 'git bisect' to that commit, or is that just a guess ?
>
> No, I haven't actually tried to build it from sources myself yet so I
> just found the source file that ha
On Thu, Aug 16, 2018 at 02:56:10PM -0500, Eric Blake wrote:
> On 08/16/2018 02:02 PM, Vladimir Sementsov-Ogievskiy wrote:
> > Hi Eric!
> >
> > There is a small problem with our qemu-nbd cmdline interface: people
> > forget to use option -x or don't know about it and face into problems
> > with old
On Thu, Aug 16, 2018 at 06:20:29PM -0400, Laine Stump wrote:
> Summary of the problem:
>
> 1) We want to persuade libvirt+QEMU users to move away from the i440fx
> machinetype in favor of Q35. (NB: Someday this *might* lead to the
> ability to deprecate and even remove the 440fx machinetype, but e
On Fri, Aug 17, 2018 at 08:44:38AM +0200, Stefan Priebe - Profihost AG wrote:
> Hello,
>
> i haven't found anything on the web regarding qemu and mentioned variants.
>
> While my host says:
> l1tf:Mitigation: PTE Inversion; VMX: SMT vulnerable, L1D conditional
> cache flushes
> meltdown:Mitigatio
On Fri, Aug 17, 2018 at 09:33:33AM +0200, Thomas Huth wrote:
> While adding the object_initialize_child() function, Paolo suggested
> to rename the similar object_new_with_props() function accordingly:
>
> http://marc.info/?i=e034610d-9a1d-a8a5-ee92-b2e3f0ba2...@redhat.com
>
> This way it is more
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 1534422540-18815-1-git-send-email-hans-erik.flo...@rt-labs.com
Subject: [Qemu-devel] [PATCH] sdhci: add i.MX SD Stable Clock bit
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=b
On 08/17/2018 11:48 AM, Daniel P. Berrangé wrote:
> On Fri, Aug 17, 2018 at 09:33:33AM +0200, Thomas Huth wrote:
>> While adding the object_initialize_child() function, Paolo suggested
>> to rename the similar object_new_with_props() function accordingly:
>>
>> http://marc.info/?i=e034610d-9a1d-a8a
On Fri, Aug 17, 2018 at 11:58:07AM +0200, Thomas Huth wrote:
> On 08/17/2018 11:48 AM, Daniel P. Berrangé wrote:
> > On Fri, Aug 17, 2018 at 09:33:33AM +0200, Thomas Huth wrote:
> >> While adding the object_initialize_child() function, Paolo suggested
> >> to rename the similar object_new_with_prop
On Fri, Aug 17, 2018 at 10:59:44AM +0100, Daniel P. Berrangé wrote:
> On Fri, Aug 17, 2018 at 11:58:07AM +0200, Thomas Huth wrote:
> > On 08/17/2018 11:48 AM, Daniel P. Berrangé wrote:
> > > On Fri, Aug 17, 2018 at 09:33:33AM +0200, Thomas Huth wrote:
> > >> While adding the object_initialize_child
17.08.2018 04:54, Eduardo Habkost wrote:
On Thu, Aug 16, 2018 at 08:20:26PM +0300, Vladimir Sementsov-Ogievskiy wrote:
Render block nodes graph with help of graphviz
Signed-off-by: Vladimir Sementsov-Ogievskiy
Thanks for your patch. Comments below:
---
scripts/qemu.py | 53 ++
On 14 August 2018 at 13:42, Peter Maydell wrote:
> Now we have virtualization support in the GICv2 emulation,
> I thought I'd have a look at how much we were still missing
> for being able to enable EL2 support for AArch32.
> This set of patches fixes some minor missing pieces:
> * various small
Thomas Huth wrote:
> When running "make check" on a non-POWER host, the output is quite
> distorted like this:
>
> [...]
> GTESTER check-qtest-nios2
> GTESTER check-qtest-or1k
> GTESTER check-qtest-ppc64
> Skipping test: kvm_hv not available Skipping test: kvm_hv not available
> Skipping
I just ran into a build failure using the tests/vm/ BSD build tests,
because the NetBSD build image's disk filled up.
Looking more closely there seemed to be 9 stale build trees in
the VM's /var/tmp/qemu-test.* , which is why the disk was full
(they'd used up about 18GB between them).
The other V
Thomas Huth wrote:
> mc146818rtc.c still contains some TABs. Replace them with spaces.
> And while we're at it, also delete trailing whitespace in this file.
>
> Reviewed-by: Markus Armbruster
> Signed-off-by: Thomas Huth
Reviewed-by: Juan Quintela
Thomas Huth wrote:
> There is currently a funny problem with the "mc146818rtc" device:
> 1) Start QEMU like this:
>qemu-system-ppc64 -M pseries -S
> 2) At the HMP monitor, enter "info qom-tree". Note that there is an
>entry for "/rtc (spapr-rtc)".
> 3) Introspect the mc146818rtc device lik
Thomas Huth wrote:
> The tests that check something for all machine types currently spend
> a lot of time checking old machine types (like "pc-i440fx-2.0" for
> example). The chances that we find something new there in addition
> to checking the latest version of a machine type are pretty low, so
On 16/08/2018 13:35, Thomas Huth wrote:
> The basic idea for this patch series are the two patches that improve
> the device-inrospection test: We now check that the qom-tree and the
> qtree do not change during introspection, and the we also turn on the
> device introspection test with all machine
Thomas Huth wrote:
> Introspection should not change the qom-tree / qtree, so we should check
> this in the device-introspect-test, too. This patch helped to find lots
> of instrospection bugs during the QEMU v3.0 soft/hard-freeze period in the
> last two months.
>
> Signed-off-by: Thomas Huth
R
On Fri, 2018-08-17 at 10:29 +0100, Daniel P. Berrangé wrote:
> On Thu, Aug 16, 2018 at 06:20:29PM -0400, Laine Stump wrote:
> > 5) Some guest OSes that we still want to support (and which would
> > otherwise work okay on a Q35 virtual machine) have virtio drivers too
> > old to support virtio-1.0 (
On 17/08/2018 07:18, Emilio G. Cota wrote:
> v1: https://lists.gnu.org/archive/html/qemu-devel/2018-08/msg02186.html
>
> Changes since v1:
>
> - Rebase on current master.
> - Update copyright to 2018.
> - Add -m option to the HMP info command to sort by average wait time,
> as suggested by Paol
On Fri, Aug 17, 2018 at 12:35:11PM +0200, Andrea Bolognani wrote:
> On Fri, 2018-08-17 at 10:29 +0100, Daniel P. Berrangé wrote:
> > On Thu, Aug 16, 2018 at 06:20:29PM -0400, Laine Stump wrote:
> > > 5) Some guest OSes that we still want to support (and which would
> > > otherwise work okay on a Q3
On Fri, Aug 17, 2018 at 11:26:39AM +0100, Peter Maydell wrote:
> I just ran into a build failure using the tests/vm/ BSD build tests,
> because the NetBSD build image's disk filled up.
>
> Looking more closely there seemed to be 9 stale build trees in
> the VM's /var/tmp/qemu-test.* , which is why
* Emilio G. Cota (c...@braap.org) wrote:
> The command introduced here is just for developers. This means that:
>
> - the interface implemented here could change in the future
> - the command is only meant to be used from HMP, not from QMP
>
> Signed-off-by: Emilio G. Cota
> ---
> hmp.h
From: Heinrich Schuchardt
Allow a space between a colon and subsequent opening bracket. This
sequence may occur in inline assembler statements like
asm(
"ldr %[out], [%[in]]\n\t"
: [out] "=r" (ret)
: [in] "r" (addr)
);
Allow a spa
On 17/08/2018 12:04, Daniel P. Berrangé wrote:
> On Fri, Aug 17, 2018 at 10:59:44AM +0100, Daniel P. Berrangé wrote:
>> On Fri, Aug 17, 2018 at 11:58:07AM +0200, Thomas Huth wrote:
>>> On 08/17/2018 11:48 AM, Daniel P. Berrangé wrote:
On Fri, Aug 17, 2018 at 09:33:33AM +0200, Thomas Huth wrote
* Emilio G. Cota (c...@braap.org) wrote:
> The command introduced here is just for developers. This means that:
>
> - the info displayed and the output format could change in the future
> - the command is only meant to be used from HMP, not from QMP
>
> Sample output:
>
> (qemu) sync-profile
> s
On 17 August 2018 at 11:47, Daniel P. Berrangé wrote:
> I'd prefer to see the test process honouring the build directory instead
> of putting stuff in /var/tmp, so that a developer's normal approach to
> cleaning up build artifacts works.
That's tricky because the build directory is outside the V
Thomas Huth wrote:
> Certain device introspection crashes used to only happen if you were
> using a certain machine, e.g. if the machine was using serial_hd() or
> nd_table[], and a device was trying to use these in its instance_init
> function, too.
>
> To be able to catch these problems, let's e
Thomas Huth wrote:
> From: Paolo Bonzini
>
> Thomas has been doing a lot of work on qom-test and device-introspection-test,
> and Laurent has ported libqos to sPAPR and co-mentored Emanuele on the
> upcoming qtest device framework. They deserve recognition. :)
>
> Signed-off-by: Paolo Bonzini
>
On Fri, Aug 17, 2018 at 11:47:06AM +0100, Daniel P. Berrangé wrote:
> On Fri, Aug 17, 2018 at 11:26:39AM +0100, Peter Maydell wrote:
> > I just ran into a build failure using the tests/vm/ BSD build tests,
> > because the NetBSD build image's disk filled up.
> >
> > Looking more closely there seem
* Zhang Chen (zhangc...@gmail.com) wrote:
> Make sure master start block replication after slave's block
> replication started.
>
> Besides, we need to activate VM's blocks before goes into
> COLO state.
>
> Signed-off-by: zhanghailiang
> Signed-off-by: Li Zhijian
> Signed-off-by: Zhang Chen
>
* Zhang Chen (zhangc...@gmail.com) wrote:
> On Tue, Aug 7, 2018 at 10:30 PM Dr. David Alan Gilbert
> wrote:
>
> > * Zhang Chen (zhangc...@gmail.com) wrote:
> > > Make sure master start block replication after slave's block
> > > replication started.
> > >
> > > Besides, we need to activate VM's b
Eric Blake writes:
> On 08/08/2018 07:03 AM, Markus Armbruster wrote:
>> Section "QGA Synchronization" specifies that sending "a raw 0xFF
>> sentinel byte" makes the server "reset its state and discard all
>> pending data prior to the sentinel." What actually happens there is a
>> lexical error,
Remove the obsolete MMIO request_ptr APIs; they have no
users now.
Signed-off-by: Peter Maydell
---
include/exec/memory.h | 35 --
memory.c | 110 --
2 files changed, 145 deletions(-)
diff --git a/include/exec/memory.h b/include/
The mmio_interface device was a purely internal artifact
of the implementation of the memory subsystem's request_ptr
APIs. Now that we have removed those APIs, we can remove
the mmio_interface device too.
Signed-off-by: Peter Maydell
---
hw/misc/Makefile.objs| 1 -
include/hw/misc/
We now support direct execution from MMIO regions in the
core memory subsystem. This means that we don't need to
have device-specific support for it, and we can remove
the request_ptr handling from the Xilinx SPIPS device.
(It was broken anyway due to race conditions, and disabled
by default.)
Thi
Now that support has hit master for direct execution from
arbitrary MMIO regions, we can remove the MMIO request_ptr
API, which required special case support in each device that
wanted to handle it, and also had bad race conditions that
resulted in crashes if you tried to use it heavily.
This API
On 17 August 2018 at 02:33, Eduardo Habkost wrote:
> The following changes since commit bb16c0412a572c2c9cd44496deb3ad430bc49c1a:
>
> Merge remote-tracking branch
> 'remotes/pmaydell/tags/pull-target-arm-20180816' into staging (2018-08-16
> 14:35:50 +0100)
>
> are available in the Git reposito
On Fri, 08/17 11:26, Peter Maydell wrote:
> I just ran into a build failure using the tests/vm/ BSD build tests,
> because the NetBSD build image's disk filled up.
>
> Looking more closely there seemed to be 9 stale build trees in
> the VM's /var/tmp/qemu-test.* , which is why the disk was full
>
Add the ESDHC PRSSTAT_SDSTB bit, using the value of SDHC_CLOCK_INT_STABLE.
Freescale recommends checking this bit when changing clock frequency.
Signed-off-by: Hans-Erik Floryd
---
hw/sd/sdhci-internal.h | 2 ++
hw/sd/sdhci.c | 8
2 files changed, 10 insertions(+)
diff --git a
Add the ESDHC PRSSTAT_SDSTB bit, using the value of SDHC_CLOCK_INT_STABLE.
Freescale recommends checking this bit when changing clock frequency.
Signed-off-by: Hans-Erik Floryd
---
hw/sd/sdhci-internal.h | 2 ++
hw/sd/sdhci.c | 8
2 files changed, 10 insertions(+)
diff --git a
Hi; this is something of a survey question. I'm particularly
interested in answers from people who've recently had to go through
the process of getting up to speed with working on QEMU, so
I've cc'd our current Outreachy and GSoC students, but input
from anybody is welcome.
* If we did one thing t
Separate offset and size of compressed cluster.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/qcow2-refcount.c | 15 ++-
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c
index 566c19fbfa..0ea01e3ee2 100644
--- a/bl
Hi all!
v2:
02, 06: check bdrv_getlength error return code
v1:
We've faced the following problem: after host fs corruption, vm images
becomes invalid. And which is interesting, starting qemu-img check on
them led to allocating of the whole RAM and then killing qemu-img by
OOM Killer.
This was d
Split entry repairing to separate function, to be reused later.
Note: entry in in-memory l2 table (local variable in
check_refcounts_l2) is not updated after this patch.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/qcow2-refcount.c | 147
qcow2_inc_refcounts_imrt() (through realloc_refcount_array()) can eat
an unpredictable amount of memory on corrupted table entries, which are
referencing regions far beyond the end of file.
Prevent this, by skipping such regions from further processing.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Increase corruptions_fixed only after successful fix.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/qcow2-refcount.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c
index 3c539f02e5..615847eb09 100644
--- a/block
Reduce number of structures ignored in overlap check: when checking
active table ignore active tables, when checking inactive table ignore
inactive ones.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/qcow2-refcount.c | 16 +---
1 file changed, 9 insertions(+), 7 deletions(-)
Rewrite corrupted L2 table entry, which reference space out of
underlying file.
Make this L2 table entry read-as-all-zeros without any allocation.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/qcow2-refcount.c | 32
1 file changed, 32 insertions(+)
diff
On 17/08/2018 13:46, Peter Maydell wrote:
> Now that support has hit master for direct execution from
> arbitrary MMIO regions, we can remove the MMIO request_ptr
> API, which required special case support in each device that
> wanted to handle it, and also had bad race conditions that
> resulted i
Zero out corrupted L1 table entry, which reference L2 table out of
underlying file.
Zero L1 table entry means that "the L2 table and all clusters described
by this L2 table are unallocated."
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/qcow2-refcount.c | 44 +
* Lidong Chen (jemmy858...@gmail.com) wrote:
> From: Lidong Chen
>
> If the peer qemu is crashed, the qemu_rdma_wait_comp_channel function
> maybe loop forever. so we should also poll the cm event fd, and when
> receive RDMA_CM_EVENT_DISCONNECTED and RDMA_CM_EVENT_DEVICE_REMOVAL,
> we consider so
On 8/17/2018 4:56 AM, Daniel P. Berrangé wrote:
> Oh one other thing, is whether your QEMU process has an explicit keymap
> configured (this is the -k arg to QEMU), as when that it set, it
> completely changes the way keyboard input is handled in VNC. That code
> has also been massively refactored
On Thu, Aug 16, 2018 at 01:11:05PM -0400, Phillip Susi wrote:
> Hello, I recently upgraded my Xen server from Ubuntu 16.04 to 18.04 and
> am no longer able to type a | over vnc to the xen vms. When I press \
> it works, but when I hold down shift and press \ which should generate a
> |, the vm see
On Fri, Aug 17, 2018 at 08:44:36AM -0400, Phillip Susi wrote:
> On 8/17/2018 4:56 AM, Daniel P. Berrangé wrote:
> > Oh one other thing, is whether your QEMU process has an explicit keymap
> > configured (this is the -k arg to QEMU), as when that it set, it
> > completely changes the way keyboard in
You should maybe try a different NIC model. According to
https://wiki.qemu.org/Documentation/Networking the rtl8139 seems to be a
good choice?
Concerning USB, you've also got to enable an emulated "USB host
controller" to use USB devices. The easiest way to do that is to simply
start QEMU with the
Paolo Bonzini writes:
> From: Heinrich Schuchardt
>
> Allow a space between a colon and subsequent opening bracket. This
> sequence may occur in inline assembler statements like
>
> asm(
> "ldr %[out], [%[in]]\n\t"
> : [out] "=r" (ret)
> : [in] "r
On 8/17/2018 8:58 AM, Daniel P. Berrangé wrote:
> Actually for QEMU there is no default localized keymap. This is desirable
> because it allows VNC to activate its raw scancode extension which is more
> reliable than passing translated X11 key symbols.
>
> I guess there's a chance that Xen might s
On Fri, Aug 17, 2018 at 09:10:54AM -0400, Phillip Susi wrote:
> On 8/17/2018 8:58 AM, Daniel P. Berrangé wrote:
> > Actually for QEMU there is no default localized keymap. This is desirable
> > because it allows VNC to activate its raw scancode extension which is more
> > reliable than passing tran
Daniel P. Berrangé writes:
> On Fri, Aug 17, 2018 at 12:35:11PM +0200, Andrea Bolognani wrote:
>> On Fri, 2018-08-17 at 10:29 +0100, Daniel P. Berrangé wrote:
>> > On Thu, Aug 16, 2018 at 06:20:29PM -0400, Laine Stump wrote:
>> > > 5) Some guest OSes that we still want to support (and which would
If you have access to a Linux box, I'd definitely recommend testing the
same setup there. That way you can distinguish "this doesn't work on
Solaris" from "this doesn't work generally" -- the latter are (a) more
likely to be config/command line issues and (b) are easier for us to
work on where ther
On Fri, Aug 17, 2018 at 12:46:16PM +0100, Peter Maydell wrote:
> Now that support has hit master for direct execution from
> arbitrary MMIO regions, we can remove the MMIO request_ptr
> API, which required special case support in each device that
> wanted to handle it, and also had bad race conditi
Thanks for the patch, comments below:
On Fri, Aug 10, 2018 at 10:06:28PM +0800, Robert Hoo wrote:
> Add kvm_get_supported_feature_msrs() to get supported MSR feature index list.
> Add kvm_arch_get_supported_msr_feature() to get each MSR features value.
>
> kvm_get_supported_feature_msrs() is call
On 8/17/2018 9:12 AM, Daniel P. Berrangé wrote:
> It depends on what the VNC client asks for too. With no '-k' arg, if the
> VNC client asks for raw scancodes it'll get that, otherwise QEMU will
> fallback to en-US.GTK-VNC based clients (remote-viewer, virt-viewer,
> vinagre, virt-manager, GNOM
On Fri, Aug 17, 2018 at 03:13:22PM +0200, Markus Armbruster wrote:
> Daniel P. Berrangé writes:
>
> > On Fri, Aug 17, 2018 at 12:35:11PM +0200, Andrea Bolognani wrote:
> >> On Fri, 2018-08-17 at 10:29 +0100, Daniel P. Berrangé wrote:
> >> > On Thu, Aug 16, 2018 at 06:20:29PM -0400, Laine Stump wr
On Fri, Aug 10, 2018 at 10:06:29PM +0800, Robert Hoo wrote:
> Add an util function feature_word_description(), which help construct the
> string
> describing the feature word (both CPUID and MSR types).
>
> report_unavailable_features(): add MSR_FEATURE_WORD type support.
> x86_cpu_get_feature_wo
On 25 July 2018 at 06:30, Hongbo Zhang wrote:
> For the Aarch64, there is one machine 'virt', it is primarily meant to
> run on KVM and execute virtualization workloads, but we need an
> environment as faithful as possible to physical hardware, for supporting
> firmware and OS development for pysi
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20180810030139.25916-1-pavel.zbits...@gmail.com
Subject: [Qemu-devel] [PATCH 0/7] Some improvements in z/Arch instructions
support
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BAS
02.08.2018 17:48, Eric Blake wrote:
The next patch needs access to a device's minimum permitted
alignment, since NBD wants to advertise this to clients. Add
an accessor function, borrowing from blk_get_max_transfer()
for accessing a backend's block limits.
Signed-off-by: Eric Blake
Reviewed-b
On 08/16/2018 08:27 PM, Programmingkid wrote:
I am by no means an expert at qemu-img. But I did try my best to create what I think
should be the new output for qemu-img --help. This is just the text I
plan on using in a future patch. It is easier to read right now than it will be in
patch fo
On Fri, Aug 17, 2018 at 01:08:42PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> 17.08.2018 04:54, Eduardo Habkost wrote:
> > On Thu, Aug 16, 2018 at 08:20:26PM +0300, Vladimir Sementsov-Ogievskiy
> > wrote:
> > > Render block nodes graph with help of graphviz
> > >
> > > Signed-off-by: Vladimir S
02.08.2018 17:48, Eric Blake wrote:
Both NBD_CMD_BLOCK_STATUS and structured NBD_CMD_READ will split
their reply according to bdrv_block_status() boundaries. If the
block device has a request_alignment smaller than 512, but we
advertise a block alignment of 512 to the client, then this can
result
> > I think some of the previously-implemented similar cases involving
> > read-only bits were handled the same way, and we just built on that. What
> > would you suggest as a more appropriate solution in such cases (of
> > accessing "preset by hardware" bits)?
>
> Well, ctx->insn_flags and ct
Hi,
In commit 25679e5d58e "chardev: tcp: postpone async connection setup"
(and its follow up 99f2f54174a59), Peter moved chardev socket
connection to machine_done event. However, chardev created later will
no longer attempt to connect, and chardev created in tests do not have
machine_done event (b
This reverts commit 99f2f54174a595e3ada6e4332fcd2b37ebb0d55d.
See next commit reverting 25679e5d58e258e9950685ffbd0cae4cd40d9cc2 as
well for rationale.
Signed-off-by: Marc-André Lureau
---
chardev/char-socket.c | 10 --
1 file changed, 10 deletions(-)
diff --git a/chardev/char-socket.c
So far, tcp_chr_update_read_handler() only updated the read
handler. Let's also update the hup handler.
Factorize the code while at it. (note that s->ioc != NULL when
s->connected)
Signed-off-by: Marc-André Lureau
---
chardev/char-socket.c | 59 ---
1 fil
This test exhibits a regression fixed by the previous reverts.
Signed-off-by: Marc-André Lureau
---
tests/test-char.c | 18 ++
1 file changed, 14 insertions(+), 4 deletions(-)
diff --git a/tests/test-char.c b/tests/test-char.c
index 5905d31441..d99742d86d 100644
--- a/tests/test
This reverts commit 25679e5d58e258e9950685ffbd0cae4cd40d9cc2.
This commit broke "reconnect socket" chardev that are created after
"machine_done": they no longer try to connect. It broke also
vhost-user-test that uses chardev while there is no "machine_done"
event.
The goal of this patch was to mo
02.08.2018 17:48, Eric Blake wrote:
When a server advertises an unaligned size but no block sizes,
the code was rounding up to a sector-aligned size (a known
limitation of bdrv_getlength()), then assuming a request_alignment
of 512 (the recommendation of the NBD spec for maximum portability).
How
On Fri, 2018-08-17 at 11:43 +0100, Daniel P. Berrangé wrote:
> On Fri, Aug 17, 2018 at 12:35:11PM +0200, Andrea Bolognani wrote:
> > If we decide we want to explicitly spell out the options instead
> > of relying on QEMU changing behavior based on the slot type, which
> > is probably a good idea an
* Lidong Chen (jemmy858...@gmail.com) wrote:
> The destination qemu only poll the comp_channel->fd in
> qemu_rdma_wait_comp_channel. But when source qemu disconnnect
> the rdma connection, the destination qemu should be notified.
>
> Signed-off-by: Lidong Chen
OK, this could do with an update to
From: Aleksandar Markovic
Add ISA_NANOMIPS32 and CPU_NANOMIPS32 preprocessor constants.
Reviewed-by: Richard Henderson
Signed-off-by: Yongbok Kim
Signed-off-by: Aleksandar Markovic
Signed-off-by: Stefan Markovic
---
target/mips/mips-defs.h | 4
1 file changed, 4 insertions(+)
diff --g
From: Aleksandar Markovic
v9->v10:
- first 15 patches removed since they are applied now to the
main tree
- completely removed connections to and dependance on
MIPS_HFLAG_M16 in nanoMIPS code
- completed reworking of nanoMIPS branch handling
- some fixes and improvements in DSP
From: Aleksandar Markovic
Add empty body and invocation of decode_nanomips_opc() if the bit
ISA_NANOMIPS32 is set in ctx->insn_flags.
Reviewed-by: Richard Henderson
Signed-off-by: Yongbok Kim
Signed-off-by: Aleksandar Markovic
Signed-off-by: Stefan Markovic
---
target/mips/translate.c | 22
From: Yongbok Kim
Add emulation of misc nanoMIPS 16-bit instructions.
Reviewed-by: Richard Henderson
Signed-off-by: Yongbok Kim
Signed-off-by: Aleksandar Markovic
Signed-off-by: Stefan Markovic
---
target/mips/translate.c | 41 +
1 file changed, 41 in
From: Yongbok Kim
Add nanoMIPS opcodes. nanoMIPS instruction are organized by so-called
instruction pools. Each pool contains a set of opcodes, that in turn
can be instruction opcodes or instruction pool opcodes.
Reviewed-by: Richard Henderson
Signed-off-by: Yongbok Kim
Signed-off-by: Aleksand
From: Yongbok Kim
Add emulation of NOT16, AND16, XOR16, OR16 instructions.
Reviewed-by: Richard Henderson
Signed-off-by: Yongbok Kim
Signed-off-by: Aleksandar Markovic
Signed-off-by: Stefan Markovic
---
target/mips/translate.c | 38 ++
1 file changed, 38
1 - 100 of 403 matches
Mail list logo
