Re: [Qemu-devel] [PATCH 24/56] json: Accept overlong \xC0\x80 as U+0000 ("modified UTF-8")

2018-08-13 Thread Markus Armbruster
Eric Blake writes: > On 08/10/2018 10:48 AM, Eric Blake wrote: >> On 08/08/2018 07:03 AM, Markus Armbruster wrote: >>> This is consistent with qobject_to_json(). See commit e2ec3f97680. >> >> Side note: that commit mentions that on output, ASCII DEL (0x7f) is >> always escaped. RFC 7159 does not

Re: [Qemu-devel] [PATCH 25/56] json: Leave rejecting invalid escape sequences to parser

2018-08-13 Thread Markus Armbruster
Eric Blake writes: > On 08/08/2018 07:03 AM, Markus Armbruster wrote: >> Both lexer and parser reject invalid escape sequences in strings. The >> parser's check is useless. >> > >> >> Drop the lexer's escape sequence checking, and make it accept the same >> characters after '\' it accepts elsewh

Re: [Qemu-devel] [PATCH] acpi: SRAT: do not create reserved gap entries

2018-08-13 Thread Igor Mammedov
On Fri, 10 Aug 2018 15:28:35 -0300 Eduardo Habkost wrote: > On Fri, Aug 10, 2018 at 06:01:06PM +0200, Igor Mammedov wrote: > > On Fri, 10 Aug 2018 16:06:57 +0200 > > Igor Mammedov wrote: > > > > > Commit 848a1cc1e8b04 while introducing SRAT entries for DIMM and NVDIMM > > > also introduced fa

Re: [Qemu-devel] [PATCH 28/56] json: Fix \uXXXX for surrogate pairs

2018-08-13 Thread Markus Armbruster
Eric Blake writes: > On 08/08/2018 07:03 AM, Markus Armbruster wrote: >> The JSON parser treats each half of a surrogate pair as unpaired >> surrogate. Fix it to recognize surrogate pairs. >> >> Signed-off-by: Markus Armbruster >> --- >> qobject/json-parser.c | 16 +++- >> tests/

Re: [Qemu-devel] [PATCH 28/56] json: Fix \uXXXX for surrogate pairs

2018-08-13 Thread Markus Armbruster
Paolo Bonzini writes: > On 08/08/2018 14:03, Markus Armbruster wrote: >> +if (cp >= 0xD800 && cp <= 0xDBFF && !leading_surrogate >> +&& ptr[1] == '\\' && ptr[2] == 'u') { >> +ptr += 2; >> +leading_surrogate = cp; >> +

Re: [Qemu-devel] [PATCH v4] tests/libqtest: Improve kill_qemu()

2018-08-13 Thread Markus Armbruster
Eric Blake writes: > On 08/10/2018 08:28 AM, Eric Blake wrote: >> Instead of using a raw assert, print the information in an >> easier to understand way: >> >> /i386/ahci/sanity: tests/libqtest.c:119: kill_qemu() detected QEMU death >> from signal 11 (Segmentation fault) (core dumped) > > Well,

Re: [Qemu-devel] [PATCH] virtio: add support for in-order feature

2018-08-13 Thread Ilya Maximets
On 10.08.2018 22:19, Michael S. Tsirkin wrote: > On Fri, Aug 10, 2018 at 02:04:47PM +0300, Ilya Maximets wrote: >> On 10.08.2018 12:34, Michael S. Tsirkin wrote: >>> On Fri, Aug 10, 2018 at 11:28:47AM +0300, Ilya Maximets wrote: On 10.08.2018 01:51, Michael S. Tsirkin wrote: > On Thu, Aug

Re: [Qemu-devel] [PATCH] MAINTAINERS: Fix F: patterns that don't match anything

2018-08-13 Thread Thomas Huth
On 08/10/2018 01:55 PM, Markus Armbruster wrote: > Commit ba51ef25571 moved hw/dma/sun4m_iommu.c to > hw/sparc/sun4m_iommu.c without updating MAINTAINERS. > > Commit f5980f757c0 deleted include/hw/sparc/sun4m.h without updating > MAINTAINERS. > > Commit 0bcc8e5bd8d fat-fingered tests/check-block-

Re: [Qemu-devel] [PATCH] scripts/checkpatch.pl: Enforce multiline comment syntax

2018-08-13 Thread Paolo Bonzini
On 13/08/2018 08:18, Thomas Huth wrote: > On 08/10/2018 02:45 PM, Paolo Bonzini wrote: >> On 10/08/2018 11:10, Peter Maydell wrote: So my proposal, which is actually consistent with what QEMU is doing, is the following: 1) the first line of a file should always be "/*", otherwis

[Qemu-devel] [Bug 1785698] Re: Solaris build error: unknown type name ‘gcry_error_t’

2018-08-13 Thread Thomas Huth
For providing a Solaris build machine, you best get in touch with Peter Maydell (see MAINTAINERS file for his mail address). Now for your build problems, it seems like "libgcrypt-config --cflags" already should add /opt/csw/include to the list of header search paths, so I wonder why the "#include

Re: [Qemu-devel] [Qemu-block] [PATCH v0 0/2] Postponed actions

2018-08-13 Thread Denis Plotnikov
Ping ping! On 16.07.2018 21:59, John Snow wrote: On 07/16/2018 11:01 AM, Denis Plotnikov wrote: Ping! I never saw a reply to Stefan's question on July 2nd, did you reply off-list? --js Yes, I did. I talked to Stefan why the patch set appeared. On 29.06.2018 15:40, Denis Plotnikov wrot

Re: [Qemu-devel] QEMU on Solaris

2018-08-13 Thread Daniel P . Berrangé
On Sun, Aug 12, 2018 at 11:40:09AM -0400, Michele Denber wrote: > After configuring QEMU on my Sun I got this message: > > "Host OS SunOS support is not currently maintained. > The QEMU project intends to remove support for this host OS in > a future release if nobody volunteers to maintain it and

Re: [Qemu-devel] [qemu-s390x] [PATCH 5/7] target/s390x: add EX support for TRT and TRTR

2018-08-13 Thread David Hildenbrand
On 10.08.2018 05:01, Pavel Zbitskiy wrote: > Improves "b213c9f5: target/s390x: Implement TRTR" by introducing the > intermediate functions, which are compatible with dx_helper type. > > Signed-off-by: Pavel Zbitskiy > --- > target/s390x/mem_helper.c | 16 +++ > tests/tcg/s390x/Make

[Qemu-devel] vTPM 2.0 is recognized as vTPM 1.2 on the Win 10 virtual machine

2018-08-13 Thread 汤福
Hi, I want to use the vTPM in a qemu Windows image. Unfortunately, it didn't work. First, the equipment: TPM 2.0 hardware CentOS 7.2 Qemu v2.10.2 SeaBIOS 1.11.0 libtpm and so on My host is centos 7.2 with the TPM 2.0 hardware and qemu v2.10.2. I make the libtpm and seabios with ./configure, make

Re: [Qemu-devel] [PATCH] file-posix: Skip effectiveless OFD lock operations

2018-08-13 Thread Kevin Wolf
Am 13.08.2018 um 03:45 hat Fam Zheng geschrieben: > On Fri, 08/10 14:14, Kevin Wolf wrote: > > Am 18.07.2018 um 10:43 hat Fam Zheng geschrieben: > > > If we know we've already locked the bytes, don't do it again; similarly > > > don't unlock a byte if we haven't locked it. This doesn't change the >

Re: [Qemu-devel] [qemu-s390x] [PATCH 2/7] target/s390x: add BAL and BALR instructions

2018-08-13 Thread David Hildenbrand
On 10.08.2018 05:01, Pavel Zbitskiy wrote: > These instructions are provided for compatibility purposes and are > used only by old software, in the new code BAS and BASR are preferred. > The difference between the old and new instruction exists only in the > 24-bit mode. > > Signed-off-by: Pavel Z

Re: [Qemu-devel] [qemu-s390x] [PATCH 1/7] tests/tcg: add a simple s390x test

2018-08-13 Thread David Hildenbrand
On 10.08.2018 05:01, Pavel Zbitskiy wrote: > Copied from alpha. > > Signed-off-by: Pavel Zbitskiy > --- > tests/tcg/s390x/Makefile.target | 3 +++ > tests/tcg/s390x/hello-s390x.c | 7 +++ > 2 files changed, 10 insertions(+) > create mode 100644 tests/tcg/s390x/Makefile.target > create mo

Re: [Qemu-devel] [RFC PATCH 0/3] tweaks for QEMU's C standard

2018-08-13 Thread Daniel P . Berrangé
On Fri, Aug 10, 2018 at 06:10:58PM +0100, Alex Bennée wrote: > Hi, > > While I was reviewing Richard's SVE series I found Travis choking on > some perfectly valid c99. It turns out that Travis default image is > old enough that gcc defaults to -std=gnu89 hence the problem. However > switching to c

Re: [Qemu-devel] [PATCH v2 1/4] hw/char: Implement nRF51 SoC UART

2018-08-13 Thread Julia Suvorova via Qemu-devel
On 10.08.2018 09:02, Stefan Hajnoczi wrote: On Wed, Aug 8, 2018 at 10:07 PM, Julia Suvorova wrote: +static uint64_t uart_read(void *opaque, hwaddr addr, unsigned int size) +{ +NRF51UARTState *s = NRF51_UART(opaque); +uint64_t r; + +if (!s->enabled) { +return 0; +} + +

Re: [Qemu-devel] [PATCH v9 6/6] tpm: add ACPI memory clear interface

2018-08-13 Thread Igor Mammedov
On Fri, 10 Aug 2018 17:32:23 +0200 Marc-André Lureau wrote: > This allows to pass the last failing test from the Windows HLK TPM 2.0 > TCG PPI 1.3 tests. > > The interface is described in the "TCG Platform Reset Attack > Mitigation Specification", chapter 6 "ACPI _DSM Function". According > to L

Re: [Qemu-devel] [PATCH 1/2] commit: Add top-node/base-node options

2018-08-13 Thread Kevin Wolf
Am 10.08.2018 um 19:33 hat Eric Blake geschrieben: > On 08/10/2018 11:26 AM, Kevin Wolf wrote: > > The block-commit QMP command required specifying the top and base nodes > > of the commit jobs using the file name of that node. While this works > > in simple cases (local files with absolute paths),

Re: [Qemu-devel] [RFC PATCH 0/3] tweaks for QEMU's C standard

2018-08-13 Thread Daniel P . Berrangé
On Mon, Aug 13, 2018 at 10:07:05AM +0100, Daniel P. Berrangé wrote: > On Fri, Aug 10, 2018 at 06:10:58PM +0100, Alex Bennée wrote: > > Hi, > > > > While I was reviewing Richard's SVE series I found Travis choking on > > some perfectly valid c99. It turns out that Travis default image is > > old en

Re: [Qemu-devel] [RFC PATCH 0/3] tweaks for QEMU's C standard

2018-08-13 Thread Thomas Huth
On 08/13/2018 11:07 AM, Daniel P. Berrangé wrote: > On Fri, Aug 10, 2018 at 06:10:58PM +0100, Alex Bennée wrote: >> Hi, >> >> While I was reviewing Richard's SVE series I found Travis choking on >> some perfectly valid c99. It turns out that Travis default image is >> old enough that gcc defaults t

Re: [Qemu-devel] [RFC PATCH 0/3] tweaks for QEMU's C standard

2018-08-13 Thread Peter Maydell
On 13 August 2018 at 10:18, Daniel P. Berrangé wrote: > Also, we should ensure the min required GCC version via biuld time > check of some kind. eg something like > > #if !(__GNUC_PREREQ(4, 4) || defined(__clang__)) > # error "QEMU requires GCC >= 4.4, or CLang" > #endif Our current minimum is 4.

[Qemu-devel] [PATCH] chardev/char-fe: Fix typos

2018-08-13 Thread Julia Suvorova via Qemu-devel
Fixup some typos in the comments. Signed-off-by: Julia Suvorova --- include/chardev/char-fe.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/include/chardev/char-fe.h b/include/chardev/char-fe.h index 71cd069478..c67271f1ba 100644 --- a/include/chardev/char-fe.h +

Re: [Qemu-devel] Question about dirty page statistics for live migration

2018-08-13 Thread Dr. David Alan Gilbert
* Li Qiang (liq...@gmail.com) wrote: > Hello Dave, Juan and all, > > It is useful to get the dirty page rates in guest to evaluate the guest > loads > so that we can make a decide to live migrate it or not. So I think we can > add a on-demand qmp for showing the dirty page rates. > > I found some

Re: [Qemu-devel] [PATCH] chardev/char-fe: Fix typos

2018-08-13 Thread Peter Maydell
On 13 August 2018 at 10:34, Julia Suvorova via Qemu-devel wrote: > Fixup some typos in the comments. > > Signed-off-by: Julia Suvorova > --- Reviewed-by: Peter Maydell thanks -- PMM

Re: [Qemu-devel] [PATCH 1/2] commit: Add top-node/base-node options

2018-08-13 Thread Markus Armbruster
Kevin Wolf writes: > Am 10.08.2018 um 19:33 hat Eric Blake geschrieben: >> On 08/10/2018 11:26 AM, Kevin Wolf wrote: >> > The block-commit QMP command required specifying the top and base nodes >> > of the commit jobs using the file name of that node. While this works >> > in simple cases (local

Re: [Qemu-devel] [PATCH v2 1/4] hw/char: Implement nRF51 SoC UART

2018-08-13 Thread Stefan Hajnoczi
On Mon, Aug 13, 2018 at 10:08 AM Julia Suvorova wrote: > On 10.08.2018 09:02, Stefan Hajnoczi wrote: > > On Wed, Aug 8, 2018 at 10:07 PM, Julia Suvorova wrote: > >> +static uint64_t uart_read(void *opaque, hwaddr addr, unsigned int size) > >> +{ > >> +NRF51UARTState *s = NRF51_UART(opaque); >

Re: [Qemu-devel] [RFC PATCH 0/3] tweaks for QEMU's C standard

2018-08-13 Thread Alex Bennée
Daniel P. Berrangé writes: > On Mon, Aug 13, 2018 at 10:07:05AM +0100, Daniel P. Berrangé wrote: >> On Fri, Aug 10, 2018 at 06:10:58PM +0100, Alex Bennée wrote: >> > Hi, >> > >> > While I was reviewing Richard's SVE series I found Travis choking on >> > some perfectly valid c99. It turns out th

Re: [Qemu-devel] [PATCH] virtio: add support for in-order feature

2018-08-13 Thread Michael S. Tsirkin
On Mon, Aug 13, 2018 at 10:55:23AM +0300, Ilya Maximets wrote: > On 10.08.2018 22:19, Michael S. Tsirkin wrote: > > On Fri, Aug 10, 2018 at 02:04:47PM +0300, Ilya Maximets wrote: > >> On 10.08.2018 12:34, Michael S. Tsirkin wrote: > >>> On Fri, Aug 10, 2018 at 11:28:47AM +0300, Ilya Maximets wrote:

Re: [Qemu-devel] [PATCH v4 4/6] loader: add rom transaction API

2018-08-13 Thread Stefan Hajnoczi
On Wed, Aug 8, 2018 at 10:32 PM Alistair Francis wrote: > On Fri, Aug 3, 2018 at 7:47 AM, Stefan Hajnoczi wrote: > > @@ -1168,6 +1172,34 @@ void rom_reset_order_override(void) > > fw_cfg_reset_order_override(fw_cfg); > > } > > > > +void rom_transaction_begin(void) > > +{ > > +Rom *rom;

Re: [Qemu-devel] QEMU on Solaris

2018-08-13 Thread Peter Tribble
On Mon, Aug 13, 2018 at 9:34 AM, Daniel P. Berrangé wrote: > On Sun, Aug 12, 2018 at 11:40:09AM -0400, Michele Denber wrote: > > After configuring QEMU on my Sun I got this message: > > > > "Host OS SunOS support is not currently maintained. > > The QEMU project intends to remove support for this

Re: [Qemu-devel] [PATCH] chardev/char-fe: Fix typos

2018-08-13 Thread Paolo Bonzini
On 13/08/2018 11:34, Julia Suvorova wrote: > Fixup some typos in the comments. > > Signed-off-by: Julia Suvorova > --- > include/chardev/char-fe.h | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/include/chardev/char-fe.h b/include/chardev/char-fe.h > index 71

[Qemu-devel] [PATCH 00/33] Qtest driver framework

2018-08-13 Thread Emanuele Giuseppe Esposito
Qgraph API for the qtest driver framework This series of patches introduce a different qtest driver organization, viewing machines, drivers and tests as node in a graph, each having one or multiple edges relations. The idea is to have a framework where each test asks for a specific driver, and th

[Qemu-devel] [PATCH 04/33] tests/qgraph: x86_64/pc machine node

2018-08-13 Thread Emanuele Giuseppe Esposito
Add pc machine for the x86_64 QEMU binary. This machine contains an i440FX-pcihost driver, that contains itself a pci-bus-pc that produces the pci-bus interface. Signed-off-by: Emanuele Giuseppe Esposito --- tests/Makefile.include | 3 + tests/libqos/x86_64_pc-machine.c | 110 ++

[Qemu-devel] [PATCH 02/33] tests/qgraph: rename qpci_init_pc and qpci_init_spapr functions

2018-08-13 Thread Emanuele Giuseppe Esposito
Rename qpci_init_pc in qpci_pc_new and qpci_init_spapr in qpci_spapr_new, since theese function actually allocate a new pci struct and initialize it. Changed QOSOps field name from qpci_init to qpci_new. Signed-off-by: Emanuele Giuseppe Esposito --- tests/e1000e-test.c | 2 +- tests/i440

[Qemu-devel] [PATCH 07/33] tests/qgraph: arm/raspi2 machine node

2018-08-13 Thread Emanuele Giuseppe Esposito
Add arm/raspi2 machine to the graph. This machine contains a generic-sdhci, so its constructor must take care of setting it properly when called. Signed-off-by: Emanuele Giuseppe Esposito --- tests/Makefile.include| 1 + tests/libqos/raspi2-machine.c | 82 +++

[Qemu-devel] [PATCH 05/33] tests/qgraph: sdhci driver and interface nodes

2018-08-13 Thread Emanuele Giuseppe Esposito
Add qgraph nodes for sdhci-pci and generic-sdhci (memory mapped) drivers. Both drivers implement (produce) the same interface sdhci, that provides the readw - readq - writeq functions. Signed-off-by: Emanuele Giuseppe Esposito --- tests/Makefile.include | 1 + tests/libqos/sdhci.c | 163

[Qemu-devel] [PATCH 06/33] tests/qgraph: sdhci test node

2018-08-13 Thread Emanuele Giuseppe Esposito
Convert tests/sdhci-test in first qgraph test node, sdhci-test. This test consumes an sdhci interface and checks that its function return the expected values. Note that this test does not allocate any sdhci structure, it's all done by the qtest walking graph mechanism Signed-off-by: Emanuele Gius

[Qemu-devel] [PATCH 10/33] tests/qgraph: has_buggy_msi flag

2018-08-13 Thread Emanuele Giuseppe Esposito
The Qgraph framework makes any test using pci bus run the same function using pci-pci and pci-spapr bus. However, some tests are not ready to use the spapr bus, due to a MSI bug. Until it does not get fixed, this flag allows them to skip the test Signed-off-by: Emanuele Giuseppe Esposito --- tes

[Qemu-devel] [PATCH 03/33] tests/qgraph: pci-pc driver and interface nodes

2018-08-13 Thread Emanuele Giuseppe Esposito
Add pci-bus-pc node, move QPCIBusPC struct declaration in its header (since it will be needed by other drivers) and introduce a setter method for drivers that do not need to allocate but have to initialize QPCIBusPC. Signed-off-by: Emanuele Giuseppe Esposito --- tests/Makefile.include | 2 + te

[Qemu-devel] [PATCH 13/33] tests/qgraph: virtio_start_device function

2018-08-13 Thread Emanuele Giuseppe Esposito
This function is intended to group all the qvirtio_* functions that start the qvirtio devices. Applied in all tests using this combination of functions. Signed-off-by: Emanuele Giuseppe Esposito --- tests/libqos/virtio.c| 7 +++ tests/libqos/virtio.h| 1 + tests/vhost-user-test.c

[Qemu-devel] [PATCH 16/33] tests/qgraph: arm/virt machine node

2018-08-13 Thread Emanuele Giuseppe Esposito
Add arm/virt machine to the graph. This machine contains virtio-mmio, so its constructor must take care of setting it properly when called. Signed-off-by: Emanuele Giuseppe Esposito --- tests/Makefile.include | 1 + tests/libqos/virt-machine.c | 90 + 2

[Qemu-devel] [PATCH 01/33] tests: qgraph API for the qtest driver framework

2018-08-13 Thread Emanuele Giuseppe Esposito
Add qgraph API that allows to add/remove nodes and edges from the graph, implementation of Depth First Search to discover the paths and basic unit test to check correctness of the API. Included also a main executable that takes care of starting the framework, create the nodes, set the available dri

[Qemu-devel] [PATCH 08/33] tests/qgraph: pci-spapr driver and interface nodes

2018-08-13 Thread Emanuele Giuseppe Esposito
Add pci-bus-spapr node, that produces pci-bus. Move QPCIBusSPAPR struct declaration in its header (since it will be needed by other drivers) and introduce a setter method for drivers that do not need to allocate but have to initialize QPCIBusSPAPR. Signed-off-by: Emanuele Giuseppe Esposito --- t

[Qemu-devel] [PATCH 18/33] tests/qgraph: virtio-serial driver and interface nodes

2018-08-13 Thread Emanuele Giuseppe Esposito
Add qgraph nodes for virtio-serial-pci and virtio-serial-device. Both nodes produce virtio-serial, but virtio-serial-pci receives a pci-bus and uses virtio-pci QOSGraphObject and functions, while virtio-serial-device receives a virtio and implements its own functions Signed-off-by: Emanuele Giusep

[Qemu-devel] [PATCH 19/33] tests/qgraph: virtio-console test node

2018-08-13 Thread Emanuele Giuseppe Esposito
Convert tests/virtio-console-test in qgraph test node, virtio-console-test. This test consumes a virtio-serial interface and checks that its function return the expected values. Note that this test does not allocate any virtio-console structure, it's all done by the qtest walking graph mechanism

[Qemu-devel] [PATCH 09/33] tests/qgraph: ppc64/pseries machine node

2018-08-13 Thread Emanuele Giuseppe Esposito
Add pseries machine for the ppc64 QEMU binary. This machine contains a spapr-pci-host-bridge driver, that contains itself a pci-bus-spapr that produces the pci-bus interface. Signed-off-by: Emanuele Giuseppe Esposito --- tests/Makefile.include | 1 + tests/libqos/ppc64_pseries-m

[Qemu-devel] [PATCH 14/33] tests/qgraph: virtio-pci driver and interface nodes

2018-08-13 Thread Emanuele Giuseppe Esposito
Add QOSGraphObject to QVirtioPCIDevice structure, with a basic constructor. virtio-pci is not present in qgraph, since it will be used as starting point by its subclasses (virtio-*-pci) Signed-off-by: Emanuele Giuseppe Esposito --- tests/Makefile.include| 2 +- tests/libqos/virtio-pci.c | 8

[Qemu-devel] [PATCH 24/33] tests/qgraph: virtio-balloon test node

2018-08-13 Thread Emanuele Giuseppe Esposito
Convert tests/virtio-balloon-test in qgraph test node, virtio-balloon-test. This test consumes a virtio-balloon interface and checks that its function return the expected values. Note that this test does not allocate any virtio-balloon structure, it's all done by the qtest walking graph mechanism

[Qemu-devel] [PATCH 11/33] tests/qgraph: e1000e driver and interface nodes

2018-08-13 Thread Emanuele Giuseppe Esposito
Add qgraph nodes for virtio-e1000e. It consumes a pci-bus, and it's directly used by tests (e1000e is pci based). Signed-off-by: Emanuele Giuseppe Esposito --- tests/Makefile.include | 1 + tests/libqos/e1000e.c | 262 + tests/libqos/e1000e.h | 53 +++

[Qemu-devel] [PATCH 25/33] tests/qgraph: virtio-rng driver and interface nodes

2018-08-13 Thread Emanuele Giuseppe Esposito
Add qgraph nodes for virtio-rng-pci and virtio-rng-device. Both nodes produce virtio-rng, but virtio-rng-pci receives a pci-bus and uses virtio-pci QOSGraphObject and functions, while virtio-rng-device receives a virtio and implements its own functions Signed-off-by: Emanuele Giuseppe Esposito --

[Qemu-devel] [PATCH 20/33] tests/qgraph: virtio-serial test node

2018-08-13 Thread Emanuele Giuseppe Esposito
Convert tests/virtio-serial-test in qgraph test node, virtio-serial-test. This test consumes a virtio-serial interface and checks that its function return the expected values. Note that this test does not allocate any virtio-serial structure, it's all done by the qtest walking graph mechanism Sig

[Qemu-devel] [PATCH 29/33] tests/qgraph: virtio-net driver and interface nodes

2018-08-13 Thread Emanuele Giuseppe Esposito
Add qgraph nodes for virtio-net-pci and virtio-net-device. Both nodes produce virtio-net, but virtio-net-pci receives a pci-bus and overrides virtio-pci QOSGraphObject and its functions, while virtio-net-device receives a virtio and implements its own functions Signed-off-by: Emanuele Giuseppe Esp

[Qemu-devel] [PATCH 12/33] tests/qgraph: e1000e-test node

2018-08-13 Thread Emanuele Giuseppe Esposito
Convert tests/e1000e-test in qgraph test node, e1000e-test. This test consumes an e1000e interface and checks that its function return the expected values. Note that this test does not allocate any e1000e structure, it's all done by the qtest walking graph mechanism Signed-off-by: Emanuele Giusep

[Qemu-devel] [PATCH 28/33] tests/qgraph: virtio-blk test node

2018-08-13 Thread Emanuele Giuseppe Esposito
Convert tests/virtio-blk-test in qgraph test node, virtio-blk-test. This test consumes a virtio-blk interface and checks that its function return the expected values. Some functions are implemented only for virtio-blk-pci, so they don't consume virtio-blk, but virtio-blk-pci Note that this test d

[Qemu-devel] [PATCH 21/33] tests/qgraph: virtio-9p driver and interface nodes

2018-08-13 Thread Emanuele Giuseppe Esposito
Add qgraph nodes for virtio-9p-pci and virtio-9p-device. Both nodes produce virtio-9p, but virtio-9p-pci receives a pci-bus and overrides virtio-pci QOSGraphObject and its functions, while virtio-9p-device receives a virtio and implements its own functions Signed-off-by: Emanuele Giuseppe Esposito

[Qemu-devel] [PATCH 31/33] tests/qgraph: virtio-scsi driver and interface nodes

2018-08-13 Thread Emanuele Giuseppe Esposito
Add qgraph nodes for virtio-scsi-pci and virtio-scsi-device. Both nodes produce virtio-scsi, but virtio-scsi-pci receives a pci-bus and uses virtio-pci QOSGraphObject and its functions, while virtio-scsi-device receives a virtio and implements its own functions Signed-off-by: Emanuele Giuseppe Esp

[Qemu-devel] [PATCH 15/33] tests/qgraph: virtio-mmio driver and interface nodes

2018-08-13 Thread Emanuele Giuseppe Esposito
Add virtio-mmio node in qgraph framework. virtio-mmio produces virtio, the interface consumed by all virtio-*-device nodes. Being a memory-mapped device, it doesn't have to provide a constructor to qgraph, since it's always "contained" inside some other nodes. Also rename qvirtio_mmio_init_device

[Qemu-devel] [PATCH 22/33] tests/qgraph: virtio-9p test node

2018-08-13 Thread Emanuele Giuseppe Esposito
Add qgraph nodes for virtio-9p-pci and virtio-9p-device. Both nodes produce virtio-9p, but virtio-9p-pci receives a pci-bus and uses virtio-pci QOSGraphObject and functions, while virtio-9p-device receives a virtio and implements its own functions Signed-off-by: Emanuele Giuseppe Esposito --- te

[Qemu-devel] [PATCH 32/33] tests/qgraph: virtio-scsi test node

2018-08-13 Thread Emanuele Giuseppe Esposito
Convert tests/virtio-scsi-test in qgraph test node, virtio-scsi-test. This test consumes a virtio-scsi interface and checks that its function return the expected values. Some functions are implemented only for virtio-scsi-pci, so they don't consume virtio-scsi, but virtio-scsi-pci Note that this

[Qemu-devel] [PATCH 17/33] tests: virtio: separate ccw tests from libqos

2018-08-13 Thread Emanuele Giuseppe Esposito
From: Paolo Bonzini Because qtest does not support s390 channel I/O, s390 only performs smoke tests on those few devices that do not have any functional tests. Therefore, every time we add functional tests for a virtio device, the choice is between removing those tests from the s390 suite (so

[Qemu-devel] [PATCH 23/33] tests/qgraph: virtio-balloon driver and interface nodes

2018-08-13 Thread Emanuele Giuseppe Esposito
Add qgraph nodes for virtio-balloon-pci and virtio-balloon-device. Both nodes produce virtio-balloon, but virtio-balloon-pci receives a pci-bus and uses virtio-pci QOSGraphObject and functions, while virtio-balloon-device receives a virtio and implements its own functions Signed-off-by: Emanuele G

[Qemu-devel] [PATCH 27/33] tests/qgraph: virtio-blk driver and interface nodes

2018-08-13 Thread Emanuele Giuseppe Esposito
Add qgraph nodes for virtio-blk-pci and virtio-blk-device. Both nodes produce virtio-blk, but virtio-blk-pci receives a pci-bus and uses virtio-pci QOSGraphObject and functions, while virtio-blk-device receives a virtio and implements its own functions Signed-off-by: Emanuele Giuseppe Esposito --

Re: [Qemu-devel] QEMU on Solaris

2018-08-13 Thread Peter Maydell
On 13 August 2018 at 11:08, Peter Tribble wrote: > You can certainly run illumos (such as OpenIndiana or Tribblix) in a VM > easily, > and freely. I can help with that. A good start would be if we had a wiki page similar to https://wiki.qemu.org/Hosts/BSD (linked to from the "Building QEMU from s

[Qemu-devel] [PATCH 26/33] tests/qgraph: virtio-rng test node

2018-08-13 Thread Emanuele Giuseppe Esposito
Convert tests/virtio-rng-test in qgraph test node, virtio-rng-test. This test consumes a virtio-rng interface and checks that its function return the expected values. Some functions are implemented only for virtio-rng-pci, so they don't consume virtio-rng, but virtio-rng-pci Note that this test d

[Qemu-devel] [PATCH] chardev: Add websocket support

2018-08-13 Thread Julia Suvorova via Qemu-devel
New option "websock" added to allow using websocket protocol for chardev socket backend. Example: -chardev socket,websock,id=... Signed-off-by: Julia Suvorova --- chardev/char-socket.c | 75 --- chardev/char.c| 3 ++ qapi/char.json| 3

[Qemu-devel] [PATCH 30/33] tests/qgraph: virtio-net test node

2018-08-13 Thread Emanuele Giuseppe Esposito
Convert tests/virtio-net-test in qgraph test node, virtio-net-test. This test consumes a virtio-net interface and checks that its function return the expected values. Some functions are implemented only for virtio-net-pci, so they don't consume virtio-net, but virtio-net-pci Note that this test d

Re: [Qemu-devel] [PATCH 26/29] vmsvga: Add basic support for display topology

2018-08-13 Thread Gerd Hoffmann
Hi, > These registers are suppose to indicate to guest the display monitor > size (width & height). > Thus, wiring up GraphicsHwOps->ui_info callback to return new info on > SVGA_REG_DISPLAY_{WIDTH, HEIGHT} registers may be useful only for case > that we want guest to respond to the fact that t

Re: [Qemu-devel] Question about dirty page statistics for live migration

2018-08-13 Thread Li Qiang
2018-08-13 17:35 GMT+08:00 Dr. David Alan Gilbert : > * Li Qiang (liq...@gmail.com) wrote: > > Hello Dave, Juan and all, > > > > It is useful to get the dirty page rates in guest to evaluate the guest > > loads > > so that we can make a decide to live migrate it or not. So I think we can > > add a

[Qemu-devel] [PATCH 33/33] tests/qgraph: temporarly commented vhost-user-test

2018-08-13 Thread Emanuele Giuseppe Esposito
vhost-user-test has not converted to qgraph yet, and since it uses virtio interface, it won't work, causing make check to fail. Commented out until it does not get converted to graph node. Signed-off-by: Emanuele Giuseppe Esposito --- tests/Makefile.include | 8 1 file changed, 4 insert

Re: [Qemu-devel] [PATCH 00/29]: vmsvga: Various fixes and enhancements

2018-08-13 Thread Gerd Hoffmann
Hi, > > But gdm doesn't start, neither with X11 nor with wayland. Which is a > > regression, because the xorg vmware driver manages to handle the current > > qemu emulation just fine so gnome @ X11 works. > > Interesting. Thanks for finding this out. Will have a look. > Can you give more exact

Re: [Qemu-devel] [RFC PATCH 0/3] tweaks for QEMU's C standard

2018-08-13 Thread Daniel P . Berrangé
On Mon, Aug 13, 2018 at 11:25:49AM +0200, Thomas Huth wrote: > On 08/13/2018 11:07 AM, Daniel P. Berrangé wrote: > > On Fri, Aug 10, 2018 at 06:10:58PM +0100, Alex Bennée wrote: > >> Hi, > >> > >> While I was reviewing Richard's SVE series I found Travis choking on > >> some perfectly valid c99. It

Re: [Qemu-devel] [PATCH 00/29]: vmsvga: Various fixes and enhancements

2018-08-13 Thread Liran Alon
- kra...@redhat.com wrote: > Hi, > > > > But gdm doesn't start, neither with X11 nor with wayland. Which > is a > > > regression, because the xorg vmware driver manages to handle the > current > > > qemu emulation just fine so gnome @ X11 works. > > > > Interesting. Thanks for finding thi

Re: [Qemu-devel] [PATCH 33/33] tests/qgraph: temporarly commented vhost-user-test

2018-08-13 Thread Michael S. Tsirkin
On Mon, Aug 13, 2018 at 12:14:53PM +0200, Emanuele Giuseppe Esposito wrote: > vhost-user-test has not converted to qgraph yet, and since > it uses virtio interface, it won't work, causing make check > to fail. > Commented out until it does not get converted to graph node. > > Signed-off-by: Emanue

Re: [Qemu-devel] [PATCH 33/33] tests/qgraph: temporarly commented vhost-user-test

2018-08-13 Thread Paolo Bonzini
On 13/08/2018 13:15, Michael S. Tsirkin wrote: > On Mon, Aug 13, 2018 at 12:14:53PM +0200, Emanuele Giuseppe Esposito wrote: >> vhost-user-test has not converted to qgraph yet, and since >> it uses virtio interface, it won't work, causing make check >> to fail. >> Commented out until it does not ge

Re: [Qemu-devel] [PATCH v7 6/9] qcow2: Increase the default upper limit on the L2 cache size

2018-08-13 Thread Kevin Wolf
Am 13.08.2018 um 03:39 hat Max Reitz geschrieben: > On 2018-08-10 14:00, Alberto Garcia wrote: > > On Fri 10 Aug 2018 08:26:44 AM CEST, Leonid Bloch wrote: > >> The upper limit on the L2 cache size is increased from 1 MB to 32 MB. > >> This is done in order to allow default full coverage with the L

Re: [Qemu-devel] [PATCH v2 04/22] check: Only test isa-testdev when it is compiled in

2018-08-13 Thread Paolo Bonzini
On 10/08/2018 17:17, Juan Quintela wrote: > Paolo Bonzini wrote: >> On 10/08/2018 13:08, Juan Quintela wrote: Emanuele's qos-test would do this automatically. It would be nicer to convert the whole ISA subsystem to use libqos and qos-test... >>> Can we get this in until we get some volu

Re: [Qemu-devel] Question about dirty page statistics for live migration

2018-08-13 Thread Dr. David Alan Gilbert
* Li Qiang (liq...@gmail.com) wrote: > 2018-08-13 17:35 GMT+08:00 Dr. David Alan Gilbert : > > > * Li Qiang (liq...@gmail.com) wrote: > > > Hello Dave, Juan and all, > > > > > > It is useful to get the dirty page rates in guest to evaluate the guest > > > loads > > > so that we can make a decide t

Re: [Qemu-devel] [PATCH v7 5/9] qcow2: Assign the L2 cache relatively to the image size

2018-08-13 Thread Kevin Wolf
Am 11.08.2018 um 21:19 hat Leonid Bloch geschrieben: > > > @item refcount-cache-size > > > The maximum size of the refcount block cache in bytes > > > diff --git a/tests/qemu-iotests/137 b/tests/qemu-iotests/137 > > > index 87965625d8..e3fb078588 100755 > > > --- a/tests/qemu-iotests/137 > > >

Re: [Qemu-devel] [PATCH 0/4] throttle: Race condition fixes and test cases

2018-08-13 Thread Alberto Garcia
ping On Thu 02 Aug 2018 04:50:22 PM CEST, Alberto Garcia wrote: > Hi all, > > here are the patches that I promised yesterday. > > I was originally thinking to propose this for the v3.0 release, but > after debugging and fixing the problem I think that it's not > essential (details below). > > The

Re: [Qemu-devel] [PATCH v7 5/9] qcow2: Assign the L2 cache relatively to the image size

2018-08-13 Thread Leonid Bloch
On 8/13/18 2:33 PM, Kevin Wolf wrote: Am 11.08.2018 um 21:19 hat Leonid Bloch geschrieben: @item refcount-cache-size The maximum size of the refcount block cache in bytes diff --git a/tests/qemu-iotests/137 b/tests/qemu-iotests/137 index 87965625d8..e3fb078588 100755 --- a/tests/qemu-iotes

[Qemu-devel] [PATCH] qemu-options: Fix bad "macaddr" property in the documentation

2018-08-13 Thread Thomas Huth
When using the "-device" option, the property is called "mac". "macaddr" is only used for the legacy "-net nic" option. Reported-by: Harald Hoyer Signed-off-by: Thomas Huth --- qemu-options.hx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-options.hx b/qemu-options.hx

Re: [Qemu-devel] [PATCH] chardev: Add websocket support

2018-08-13 Thread Paolo Bonzini
Thanks Julia, just a few cleanups to simplify the prototypes of some functions. On 13/08/2018 12:20, Julia Suvorova wrote: > New option "websock" added to allow using websocket protocol for > chardev socket backend. > Example: > -chardev socket,websock,id=... > > Signed-off-by: Julia Suvorova

Re: [Qemu-devel] [PATCH 00/33] Qtest driver framework

2018-08-13 Thread Michael S. Tsirkin
On Mon, Aug 13, 2018 at 12:14:20PM +0200, Emanuele Giuseppe Esposito wrote: > Qgraph API for the qtest driver framework > > This series of patches introduce a different qtest driver > organization, viewing machines, drivers and tests as node in a > graph, each having one or multiple edges relation

Re: [Qemu-devel] [PATCH] acpi: SRAT: do not create reserved gap entries

2018-08-13 Thread Eduardo Habkost
On Mon, Aug 13, 2018 at 09:07:13AM +0200, Igor Mammedov wrote: > On Fri, 10 Aug 2018 15:28:35 -0300 > Eduardo Habkost wrote: > > > On Fri, Aug 10, 2018 at 06:01:06PM +0200, Igor Mammedov wrote: > > > On Fri, 10 Aug 2018 16:06:57 +0200 > > > Igor Mammedov wrote: > > > > > > > Commit 848a1cc1e8

Re: [Qemu-devel] [PATCH] chardev: Add websocket support

2018-08-13 Thread Daniel P . Berrangé
On Mon, Aug 13, 2018 at 01:20:37PM +0300, Julia Suvorova via Qemu-devel wrote: > New option "websock" added to allow using websocket protocol for > chardev socket backend. > Example: > -chardev socket,websock,id=... > > Signed-off-by: Julia Suvorova > --- > chardev/char-socket.c | 75 +++

Re: [Qemu-devel] [PATCH] qemu-options: Fix bad "macaddr" property in the documentation

2018-08-13 Thread Markus Armbruster
Thomas Huth writes: > When using the "-device" option, the property is called "mac". > "macaddr" is only used for the legacy "-net nic" option. Indeed: #define DEFINE_NIC_PROPERTIES(_state, _conf)\ --->DEFINE_PROP_MACADDR("mac", _state, _conf.macaddr),

Re: [Qemu-devel] [PATCH v0 0/7] Background snapshots

2018-08-13 Thread Denis Plotnikov
On 26.07.2018 12:23, Peter Xu wrote: On Thu, Jul 26, 2018 at 10:51:33AM +0200, Paolo Bonzini wrote: On 25/07/2018 22:04, Andrea Arcangeli wrote: It may look like the uffd-wp model is wish-feature similar to an optimization, but without the uffd-wp model when the WP fault is triggered by ker

Re: [Qemu-devel] [PATCH 02/17] mirror: Make wait_for_any_operation() coroutine_fn

2018-08-13 Thread Murilo Opsfelder Araujo
Hi, Max. On Mon, Aug 13, 2018 at 04:19:51AM +0200, Max Reitz wrote: > mirror_wait_for_any_operation() calls qemu_co_queue_wait(), which is a > coroutine_fn (technically it is a macro which resolves to a > coroutine_fn). Therefore, this function needs to be a coroutine_fn as > well. > > This patch

[Qemu-devel] [PATCH] block/qapi: Fix memory leak in qmp_query_blockstats()

2018-08-13 Thread Kevin Wolf
For BlockBackends that are skipped in query-blockstats, we would leak info since commit 567dcb31. Allocate info only later to avoid the memory leak. Fixes: CID 1394727 Cc: qemu-sta...@nongnu.org Signed-off-by: Kevin Wolf --- block/qapi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) d

Re: [Qemu-devel] [Qemu-block] [PATCH] block/qapi: Fix memory leak in qmp_query_blockstats()

2018-08-13 Thread Alberto Garcia
On Mon 13 Aug 2018 03:27:54 PM CEST, Kevin Wolf wrote: > For BlockBackends that are skipped in query-blockstats, we would leak > info since commit 567dcb31. Allocate info only later to avoid the memory > leak. > > Fixes: CID 1394727 > Cc: qemu-sta...@nongnu.org > Signed-off-by: Kevin Wolf Reviewe

Re: [Qemu-devel] [PATCH v2] file-posix: Skip effectiveless OFD lock operations

2018-08-13 Thread Kevin Wolf
Am 13.08.2018 um 04:39 hat Fam Zheng geschrieben: > If we know we've already locked the bytes, don't do it again; similarly > don't unlock a byte if we haven't locked it. This doesn't change the > behavior, but fixes a corner case explained below. > > Libvirt had an error handling bug that an imag

Re: [Qemu-devel] [PATCH] i386: Disable TOPOEXT by default on "-cpu host"

2018-08-13 Thread Moger, Babu
Looks good. Did some basic testing. Reviewed-by: Babu Moger > -Original Message- > From: Richard W.M. Jones > Sent: Friday, August 10, 2018 2:41 AM > To: Eduardo Habkost > Cc: qemu-devel@nongnu.org; Paolo Bonzini ; > Richard Henderson ; Moger, Babu > > Subject: Re: [PATCH] i386: Disab

Re: [Qemu-devel] [PATCH 1/4] block: adding lzfse decompressing support as a module.

2018-08-13 Thread Kevin Wolf
Am 10.08.2018 um 06:07 hat Julio Faracco geschrieben: > QEMU dmg support includes zlib and bzip2, but it does not contains lzfse > support. This commit adds the source file to extend compression support > for new DMGs. > > Signed-off-by: Julio Faracco > --- > block/dmg-lzfse.c | 54 +

Re: [Qemu-devel] [PATCH 2/4] configure: adding support to lzfse library.

2018-08-13 Thread Kevin Wolf
Am 10.08.2018 um 06:07 hat Julio Faracco geschrieben: > This commit includes the support to lzfse opensource library. With this > library dmg block driver can decompress images with this type of > compression inside. > > Signed-off-by: Julio Faracco > --- > block/Makefile.objs | 2 ++ > configu

Re: [Qemu-devel] [PATCH 3/4] dmg: including dmg-lzfse module inside dmg block driver.

2018-08-13 Thread Kevin Wolf
Am 10.08.2018 um 06:07 hat Julio Faracco geschrieben: > This commit includes the support to new module dmg-lzfse into dmg block > driver. It includes the support for block type ULFO (0x8007). > > Signed-off-by: Julio Faracco > --- > block/dmg.c | 28 > block/dmg.

Re: [Qemu-devel] [PATCH 4/4] dmg: exchanging hardcoded dmg UDIF block types to enum.

2018-08-13 Thread Kevin Wolf
Am 10.08.2018 um 06:07 hat Julio Faracco geschrieben: > This change is better to understand what kind of block type is being > handled by the code. Using a syntax similar to the DMG documentation is > easier than tracking all hex values assigned to a block type. > > Signed-off-by: Julio Faracco >

Re: [Qemu-devel] [PATCH v8 3/8] qcow2: Avoid duplication in setting the refcount cache size

2018-08-13 Thread Alberto Garcia
On Mon 13 Aug 2018 03:07:24 AM CEST, Leonid Bloch wrote: > The refcount cache size does not need to be set to its minimum value in > read_cache_sizes(), as it is set to at least its minimum value in > qcow2_update_options_prepare(). > > Signed-off-by: Leonid Bloch Reviewed-by: Alberto Garcia Be

  1   2   3   4   >