On 10/08/2018 17:17, Juan Quintela wrote: > Paolo Bonzini <pbonz...@redhat.com> wrote: >> On 10/08/2018 13:08, Juan Quintela wrote: >>>> Emanuele's qos-test would do this automatically. It would be nicer to >>>> convert the whole ISA subsystem to use libqos and qos-test... >>> Can we get this in until we get some volunteer for that other work? >>> /me full of things on his plate at the moment. >> >> Sure, but since this is RFC, I commented. :) > > I didn't expect less of you O:-) > >> With qos-test, all tests >> end up in a single binary that is generic for all QEMU targets, and >> there's no need to synchronize the configuration with the testing. >> >> The disadvantage of doing it at the Makefile level is that it relies on >> the devices being either in all targets or none. For example >> CONFIG_ISA_TESTDEV cannot be removed from just >> default-configs/ppc-softmmu.mak if you are building both a PPC and an >> x86 target.
Anyway, I'm not opposed to merging this part, it's just that they may be unnecessary in the future. The virtio split is more interesting to me, and I am very happy that you are doing it! Paolo
