Re: [Qemu-devel] [PATCH v6 2/4] spapr: introduce a fixed IRQ number space

2018-08-01 Thread Cédric Le Goater
[ ... ] >>> +typedef struct sPAPRMachineState sPAPRMachineState; >>> + >> >> Old compilers (GCC < 4.6) might complain about 'redefinition of typedef' if >> some file, say hw/ppc/spapr.c, includes both this header and "hw/ppc/xics.h". >> We had several build breaks detected by 'make docker-test-bui

Re: [Qemu-devel] [Bug 1783362] Re: qemu-user: mmap should return failure (MAP_FAILED, -1) instead of success (NULL, 0) when len==0

2018-08-01 Thread Laurent Vivier
Le 01/08/2018 à 00:57, umarcor a écrit : > Alex, Laurent, I'm new to this management/development system. So, first > off, thanks for working on this bug. > > I have a few (probably silly) questions: > > 1. What is 'the r-b' that Alex used in #14? "Reviewed-By:", it's a tag I've sent in answer to

Re: [Qemu-devel] [PATCH v3 for-3.0] tests/libqtest: Improve kill_qemu()

2018-08-01 Thread Thomas Huth
On 07/31/2018 12:08 AM, Eric Blake wrote: > In kill_qemu() we have an assert that checks that the QEMU process > didn't dump core: > assert(!WCOREDUMP(wstatus)); > > Unfortunately the WCOREDUMP macro here means the resulting message > is not very easy to comprehend on at least some sys

Re: [Qemu-devel] [PATCH 2/3] migration: Add qmp command for migrate_set_max_cpu_throttle

2018-08-01 Thread Juan Quintela
Daniel P. Berrangé wrote: > On Tue, Jul 31, 2018 at 04:48:35PM +0200, Juan Quintela wrote: >> "Dr. David Alan Gilbert" wrote: >> > * Li Qiang (liq...@gmail.com) wrote: >> >> The default max cpu throttle is 99, this is too big that may >> >> influence the guest loads. Add a qmp to config it can ma

Re: [Qemu-devel] VCPU hotplug on KVM/ARM

2018-08-01 Thread Bharata B Rao
On Tue, Jul 31, 2018 at 3:57 PM, Igor Mammedov wrote: > On Wed, 25 Jul 2018 14:07:12 +0100 > Marc Zyngier wrote: > > > On 25/07/18 13:28, Andrew Jones wrote: > > > On Wed, Jul 25, 2018 at 11:40:54AM +0100, Marc Zyngier wrote: > > >> On 24/07/18 19:35, Maran Wilson wrote: > > >>> It's been a few

Re: [Qemu-devel] [PATCH] vhost: check region type before casting

2018-08-01 Thread Tiwei Bie
Ping.. It seems that the final release for QEMU 3.0 will be out soon [1]. But this fix hasn't been merged yet. [1] https://lists.nongnu.org/archive/html/qemu-devel/2018-07/msg06004.html Thanks, Tiwei On Fri, Jul 20, 2018 at 04:36:44PM +0800, Tiwei Bie wrote: > Check region type first before cas

Re: [Qemu-devel] [PATCH] vhost: check region type before casting

2018-08-01 Thread Jason Wang
On 2018年08月01日 16:22, Tiwei Bie wrote: Ping.. It seems that the final release for QEMU 3.0 will be out soon [1]. But this fix hasn't been merged yet. [1] https://lists.nongnu.org/archive/html/qemu-devel/2018-07/msg06004.html Thanks, Tiwei Cc: qemu-sta...@nongnu.org Acked-by: Jason Wang

Re: [Qemu-devel] [PATCH v6 2/4] spapr: introduce a fixed IRQ number space

2018-08-01 Thread Greg Kurz
On Wed, 1 Aug 2018 09:14:43 +0200 Cédric Le Goater wrote: > [ ... ] > > >>> +typedef struct sPAPRMachineState sPAPRMachineState; > >>> + > >> > >> Old compilers (GCC < 4.6) might complain about 'redefinition of typedef' if > >> some file, say hw/ppc/spapr.c, includes both this header and > >>

[Qemu-devel] [PATCH] ui: use enum to string helpers

2018-08-01 Thread Marc-André Lureau
Minor code simplification. Signed-off-by: Marc-André Lureau --- qemu-keymap.c | 2 +- ui/console.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/qemu-keymap.c b/qemu-keymap.c index 6216371aa1..4d00468747 100644 --- a/qemu-keymap.c +++ b/qemu-keymap.c @@ -84,7 +84,7

Re: [Qemu-devel] [PATCH] kvmclock: run KVM_KVMCLOCK_CTRL ioctl in vcpu thread

2018-08-01 Thread Yongji Xie
Ping... On 11 July 2018 at 21:22, Yongji Xie wrote: > According to KVM API Documentation, we should only > run vcpu ioctls from the same thread that was used > to create the vcpu. This patch makes KVM_KVMCLOCK_CTRL > ioctl consistent with the Documentation. > > No functional change. > > Signed-of

Re: [Qemu-devel] [PATCH v2 2/2] s390x: Enable KVM huge page backing support

2018-08-01 Thread Thomas Huth
On 07/31/2018 11:09 AM, Janosch Frank wrote: > QEMU has had huge page support for a longer time already, but KVM > memory management under s390x needed some changes to work with huge > backings. > > Now that we have support, let's enable it if requested and > available. Otherwise we now properly t

[Qemu-devel] [PATCH] monitor: avoid potential dead-lock when cleaning up

2018-08-01 Thread Marc-André Lureau
When a monitor is connected to a Spice chardev, the monitor cleanup can dead-lock: #0 0x7f43446637fd in __lll_lock_wait () at /lib64/libpthread.so.0 #1 0x7f434465ccf4 in pthread_mutex_lock () at /lib64/libpthread.so.0 #2 0x556dd79f22ba in qemu_mutex_lock_impl (mutex=0x556dd81c922

[Qemu-devel] ARM: SVE movprfx issue

2018-08-01 Thread Laurent Desnogues
Hello Richard, there's a typo in sve_movz_d where n[1] is used instead of n[i]. Thanks, Laurent

Re: [Qemu-devel] [PATCH v2 1/2] hw/arm: check fw_cfg return value before using it

2018-08-01 Thread Hongbo Zhang
On 31 July 2018 at 02:07, Peter Maydell wrote: > On 25 July 2018 at 06:30, Hongbo Zhang wrote: >> The fw_cfg value returned from fw_cfg_find() may be NULL, so check it >> before using. >> >> Signed-off-by: Hongbo Zhang >> --- >> hw/arm/boot.c | 6 +++--- >> 1 file changed, 3 insertions(+), 3 de

Re: [Qemu-devel] [PULL 0/2] ppc-for-3.0 queue 20180801

2018-08-01 Thread Peter Maydell
qemu.git tags/ppc-for-3.0-20180801 > > for you to fetch changes up to 6484ab3dffadc79020a71376010f517d60b81b83: > > sam460ex: Fix PCI interrupts with multiple devices (2018-08-01 11:01:38 > +1000) > > > ppc pa

Re: [Qemu-devel] [PATCH v6 0/3] add support for VCPU event states

2018-08-01 Thread gengdongjiu
Hi Peter, sorry to disturb you, any comments for this series patch? thanks you in advance. On 2018/7/22 2:02, Dongjiu Geng wrote: > Support for KVM_GET/SET_VCPU_EVENTS to get/set the SError exception > state, and support the state migration. > > change since v4: > 1. update the linux header f

Re: [Qemu-devel] [PULL 1/1] slirp: fix ICMP handling on macOS hosts

2018-08-01 Thread Peter Maydell
On 1 August 2018 at 00:25, Andrew Oates wrote: > Both CONFIG_BSD and not-CONFIG_LINUX work on macOS. I unfortunately don't > have access to any other BSDs to test them, though. Is there an easy way to test it? The QEMU makefiles have some runes for setting up a BSD VM... thanks -- PMM

Re: [Qemu-devel] [PATCH] vhost: check region type before casting

2018-08-01 Thread Peter Maydell
On 1 August 2018 at 09:22, Tiwei Bie wrote: > Ping.. > > It seems that the final release for QEMU 3.0 will be > out soon [1]. But this fix hasn't been merged yet. > > [1] https://lists.nongnu.org/archive/html/qemu-devel/2018-07/msg06004.html :-( You just missed rc3 (which we tagged yesterday), a

Re: [Qemu-devel] [PATCH v6 0/3] add support for VCPU event states

2018-08-01 Thread Peter Maydell
On 1 August 2018 at 11:05, gengdongjiu wrote: > Hi Peter, >sorry to disturb you, any comments for this series patch? thanks you in > advance. It is on my to-review list, but I'm afraid I have not yet got to it. thanks -- PMM

Re: [Qemu-devel] [PATCH 4/6] dirty-bitmaps: clean-up bitmaps loading and migration logic

2018-08-01 Thread Dr. David Alan Gilbert
* John Snow (js...@redhat.com) wrote: > I'd rather do something like this: > - Always flush bitmaps to disk on inactivate. Does that increase the time taken by the inactivate measurably? If it's small relative to everything else that's fine; it's just I always worry a little since I think this

Re: [Qemu-devel] [PATCH for-3.1] s390x: remove 's390-squash-mcss' option

2018-08-01 Thread Fam Zheng
On Tue, 07/24 11:24, Cornelia Huck wrote: > diff --git a/hw/s390x/css-bridge.c b/hw/s390x/css-bridge.c > index a02d708239..1bd6c8b458 100644 > --- a/hw/s390x/css-bridge.c > +++ b/hw/s390x/css-bridge.c > @@ -106,7 +106,6 @@ VirtualCssBus *virtual_css_bus_init(void) > /* Create bus on bridge dev

Re: [Qemu-devel] [PATCH v6 0/3] add support for VCPU event states

2018-08-01 Thread gengdongjiu
On 2018/8/1 18:14, Peter Maydell wrote: > On 1 August 2018 at 11:05, gengdongjiu wrote: >> Hi Peter, >>sorry to disturb you, any comments for this series patch? thanks you in >> advance> > It is on my to-review list, but I'm afraid I have not yet > got to it. Thanks very much, it is gre

Re: [Qemu-devel] ARM: SVE movprfx issue

2018-08-01 Thread Richard Henderson
On 08/01/2018 05:38 AM, Laurent Desnogues wrote: > there's a typo in sve_movz_d where n[1] is used instead of n[i]. Oops. Thanks, fix queued. r~

[Qemu-devel] [PATCH] qemu-binfmt-conf.sh: add x86_64 target

2018-08-01 Thread Laurent Vivier
Signed-off-by: Laurent Vivier --- scripts/qemu-binfmt-conf.sh | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/scripts/qemu-binfmt-conf.sh b/scripts/qemu-binfmt-conf.sh index b0dc8a714a..b5a16742a1 100755 --- a/scripts/qemu-binfmt-conf.sh +++ b/scripts/qemu-binfmt-conf.sh

Re: [Qemu-devel] [PATCH V10 08/20] ram/COLO: Record the dirty pages that SVM received

2018-08-01 Thread Zhang Chen
On Sat, Jul 28, 2018 at 2:51 AM, Dr. David Alan Gilbert wrote: > * Zhang Chen (zhangc...@gmail.com) wrote: > > We record the address of the dirty pages that received, > > it will help flushing pages that cached into SVM. > > > > Here, it is a trick, we record dirty pages by re-using migration > >

Re: [Qemu-devel] [PATCH] qemu-binfmt-conf.sh: add x86_64 target

2018-08-01 Thread Richard Henderson
On 08/01/2018 06:29 AM, Laurent Vivier wrote: > Signed-off-by: Laurent Vivier > --- > scripts/qemu-binfmt-conf.sh | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH] qemu-binfmt-conf.sh: add x86_64 target

2018-08-01 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180801102944.23457-1-laur...@vivier.eu Subject: [Qemu-devel] [PATCH] qemu-binfmt-conf.sh: add x86_64 target === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git

Re: [Qemu-devel] [PATCH] vhost: check region type before casting

2018-08-01 Thread Tiwei Bie
On Wed, Aug 01, 2018 at 11:13:34AM +0100, Peter Maydell wrote: > On 1 August 2018 at 09:22, Tiwei Bie wrote: > > Ping.. > > > > It seems that the final release for QEMU 3.0 will be > > out soon [1]. But this fix hasn't been merged yet. > > > > [1] https://lists.nongnu.org/archive/html/qemu-devel/2

Re: [Qemu-devel] [PATCH] qemu-binfmt-conf.sh: add x86_64 target

2018-08-01 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180801102944.23457-1-laur...@vivier.eu Subject: [Qemu-devel] [PATCH] qemu-binfmt-conf.sh: add x86_64 target === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git

[Qemu-devel] [[PATH for 3.1] v2 02/18] check: Only test ne2000 when it is compiled in

2018-08-01 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Thomas Huth --- tests/Makefile.include | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index 11c1463b99..258963810b 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @

[Qemu-devel] [[PATH for 3.1] v2 03/18] check: Only test eepro100 when it is compiled in

2018-08-01 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Thomas Huth --- tests/Makefile.include | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index 258963810b..8cf2c15daf 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @

[Qemu-devel] [[PATH for 3.1] v2 05/18] check: Only test rtl8139 when it is compiled in

2018-08-01 Thread Juan Quintela
test-file-redirector uses rtl8139 in everything except s390. Signed-off-by: Juan Quintela Reviewed-by: Thomas Huth --- tests/Makefile.include | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index f234a68345..14069c0659

[Qemu-devel] [[PATH for 3.1] v2 04/18] check: Only test pcnet when it is compiled in

2018-08-01 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Thomas Huth --- tests/Makefile.include | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index 8cf2c15daf..f234a68345 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include

[Qemu-devel] [[PATH for 3.1] v2 07/18] check: Only test ac97 when it is compiled in

2018-08-01 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Thomas Huth --- tests/Makefile.include | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index abce66539f..89d58540fc 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @

[Qemu-devel] [[PATH for 3.1] v2 00/18] Don't "check" disabled drivers

2018-08-01 Thread Juan Quintela
Hi this are the patches from v1 that have been reviewed. Minor changes in spelled done. I expect to move those for 3.1. I will post the changes and additons on top of this one. Complain now, or I will send the pull once 3.1 opens. ToDo: - I am working on virtio-pci being split - I plan to int

[Qemu-devel] [[PATH for 3.1] v2 11/18] check: Only test i82801b11 when it is compiled in

2018-08-01 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Thomas Huth --- tests/Makefile.include | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index fb3f2dd55d..c9768086be 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @

[Qemu-devel] [[PATH for 3.1] v2 12/18] check: Only test sdhci when it is compiled in

2018-08-01 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Thomas Huth --- tests/Makefile.include | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index c9768086be..42f09dbfdf 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include

[Qemu-devel] [[PATH for 3.1] v2 01/18] check: Only test vmxnet3 when it is compiled in

2018-08-01 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Thomas Huth --- tests/Makefile.include | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index a49282704e..11c1463b99 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @

[Qemu-devel] [[PATH for 3.1] v2 13/18] check: Only test wdt_ib700 when it is compiled in

2018-08-01 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Thomas Huth --- tests/Makefile.include | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index 42f09dbfdf..edbd391f04 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @

[Qemu-devel] [[PATH for 3.1] v2 08/18] check: Only test hda when it is compiled in

2018-08-01 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Thomas Huth --- tests/Makefile.include | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index 89d58540fc..5eac0528b2 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @

[Qemu-devel] [[PATH for 3.1] v2 06/18] check: Only test es1370 when it is compiled in

2018-08-01 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Thomas Huth --- tests/Makefile.include | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index 14069c0659..abce66539f 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @

[Qemu-devel] [[PATH for 3.1] v2 10/18] check: Only test ioh3420 when it is compiled in

2018-08-01 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Thomas Huth --- tests/Makefile.include | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index 63d3dc0953..fb3f2dd55d 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @

[Qemu-devel] [[PATH for 3.1] v2 09/18] check: Only test ipack when it is compiled in

2018-08-01 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Thomas Huth --- tests/Makefile.include | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index 5eac0528b2..63d3dc0953 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.inclu

[Qemu-devel] [[PATH for 3.1] v2 14/18] check: Only test pvpanic when it is compiled in

2018-08-01 Thread Juan Quintela
It was not possible to compile out pvpanic. Use the same trick than applesmc. Signed-off-by: Juan Quintela Reviewed-by: Thomas Huth --- hw/misc/pvpanic.c | 11 --- include/hw/misc/pvpanic.h | 11 ++- tests/Makefile.include| 4 ++-- 3 files changed, 12 insertions(+)

[Qemu-devel] [[PATH for 3.1] v2 16/18] check: Only test usb-ohci when it is compiled in

2018-08-01 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Thomas Huth --- tests/Makefile.include | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index 2642500659..353f068f3b 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.inclu

[Qemu-devel] [[PATH for 3.1] v2 15/18] check: Only test nvme when it is compiled in

2018-08-01 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Thomas Huth --- tests/Makefile.include | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index b9fb80b461..2642500659 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @

Re: [Qemu-devel] [Qemu-ppc] [PULL 0/2] ppc-for-3.0 queue 20180801

2018-08-01 Thread BALATON Zoltan
/dgibson/qemu.git tags/ppc-for-3.0-20180801 for you to fetch changes up to 6484ab3dffadc79020a71376010f517d60b81b83: sam460ex: Fix PCI interrupts with multiple devices (2018-08-01 11:01:38 +1000) ppc patch queue for 2018-08-01

[Qemu-devel] [[PATH for 3.1] v2 18/18] check: Only test usb-ehci when it is compiled in

2018-08-01 Thread Juan Quintela
The ehci test also test uhci. Welcome to the worderfull world of USB. Signed-off-by: Juan Quintela --- tests/Makefile.include | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index f3f8ba48fb..d6f5cc9ccc 100644 --- a/tests/Ma

[Qemu-devel] [[PATH for 3.1] v2 17/18] check: Only test usb-uhci devices when they are compiled in

2018-08-01 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Thomas Huth --- tests/Makefile.include | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index 353f068f3b..f3f8ba48fb 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.inclu

Re: [Qemu-devel] [PATCH v3 2/2] s390x: Enable KVM huge page backing support

2018-08-01 Thread Thomas Huth
On 07/31/2018 02:09 PM, Janosch Frank wrote: > QEMU has had huge page support for a longer time already, but KVM > memory management under s390x needed some changes to work with huge > backings. > > Now that we have support, let's enable it if requested and > available. Otherwise we now properly t

Re: [Qemu-devel] [PATCH v3] block/gluster: Handle changed glfs_ftruncate signature

2018-08-01 Thread Niels de Vos
On Tue, Jul 31, 2018 at 03:51:22PM -0400, Jeff Cody wrote: > On Tue, Jul 31, 2018 at 11:18:02AM +0200, Niels de Vos wrote: > > On Mon, Jul 30, 2018 at 03:27:29PM -0400, Jeff Cody wrote: > > > On Mon, Jul 30, 2018 at 10:07:27AM -0500, Eric Blake wrote: > > > > On 07/28/2018 02:50 AM, Niels de Vos wr

Re: [Qemu-devel] [[PATH for 3.1] v2 18/18] check: Only test usb-ehci when it is compiled in

2018-08-01 Thread Thomas Huth
On 08/01/2018 01:09 PM, Juan Quintela wrote: > The ehci test also test uhci. Welcome to the worderfull world of USB. > > Signed-off-by: Juan Quintela > --- > tests/Makefile.include | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/tests/Makefile.include b/tests/Makefi

Re: [Qemu-devel] [PATCH 4/6] dirty-bitmaps: clean-up bitmaps loading and migration logic

2018-08-01 Thread Vladimir Sementsov-Ogievskiy
21.07.2018 05:41, John Snow wrote: On 06/26/2018 09:50 AM, Vladimir Sementsov-Ogievskiy wrote: This patch aims to bring the following behavior: Just as a primer for anyone else reading this email (nobody) who might not understand the terminology (less than nobody), it might be helpful to rememb

[Qemu-devel] [PATCH 1/4] target/arm: Fix sign of sve_cmpeq_ppzw/sve_cmpne_ppzw

2018-08-01 Thread Richard Henderson
The normal vector element is sign-extended before comparing with the wide vector element. Reported-by: Laurent Desnogues Signed-off-by: Richard Henderson --- target/arm/sve_helper.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/target/arm/sve_helper.c b/target

[Qemu-devel] [PATCH 0/4] target/arm sve fixes

2018-08-01 Thread Richard Henderson
These four patches are minor, reported by Laurent this week. If there happens to be an -rc4 release, it would be nice if they were included. But if not, no biggie. I suspect that other minor issues will be found past these four, so I would hope everyone who cares about sve is just as happy worki

[Qemu-devel] [PATCH 2/4] target/arm: Fix typo in do_sat_addsub_64

2018-08-01 Thread Richard Henderson
Used the wrong temporary in the computation of subtractive overflow. Reported-by: Laurent Desnogues Signed-off-by: Richard Henderson --- target/arm/translate-sve.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/arm/translate-sve.c b/target/arm/translate-sve.c index 3

[Qemu-devel] [PATCH] docs/usb2.txt: ehci has six ports

2018-08-01 Thread npes87184
In commit 5cc194caeb019cf1dae7f74ccbdf0401a56c2ac6, the number of ehci ports is corrected to six. Fix docs related to it. Signed-off-by: npes87184 --- docs/usb2.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/usb2.txt b/docs/usb2.txt index f63c8d9465..172614d3a7

[Qemu-devel] [PATCH 4/4] target/arm: Fix typo in helper_sve_movz_d

2018-08-01 Thread Richard Henderson
Reported-by: Laurent Desnogues Signed-off-by: Richard Henderson --- target/arm/sve_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/arm/sve_helper.c b/target/arm/sve_helper.c index 87594a8adb..c3cbec9cf5 100644 --- a/target/arm/sve_helper.c +++ b/target/arm/sve

[Qemu-devel] [PATCH 3/4] target/arm: Reorganize SVE WHILE

2018-08-01 Thread Richard Henderson
The pseudocode for this operation is an increment + compare loop, so comparing <= the maximum integer produces an all-true predicate. Rather than bound in both the inline code and the helper, pass the helper the number of predicate bits to set instead of the number of predicate elements to set. R

[Qemu-devel] [PATCH] block_int: add missing @ in comment

2018-08-01 Thread npes87184
add missing @ in comment Signed-off-by: npes87184 --- include/block/block_int.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/block/block_int.h b/include/block/block_int.h index 903b9c1034..2ce016ea94 100644 --- a/include/block/block_int.h +++ b/include/block/block_

Re: [Qemu-devel] [PATCH for-3.1] s390x: remove 's390-squash-mcss' option

2018-08-01 Thread Cornelia Huck
On Wed, 1 Aug 2018 18:21:27 +0800 Fam Zheng wrote: > On Tue, 07/24 11:24, Cornelia Huck wrote: > > diff --git a/hw/s390x/css-bridge.c b/hw/s390x/css-bridge.c > > index a02d708239..1bd6c8b458 100644 > > --- a/hw/s390x/css-bridge.c > > +++ b/hw/s390x/css-bridge.c > > @@ -106,7 +106,6 @@ VirtualCssB

[Qemu-devel] [PATCH] migrate/cpu-throttle: Add max-cpu-throttle migration parameter

2018-08-01 Thread Li Qiang
Currently, the default maximum CPU throttle for migration is 99(CPU_THROTTLE_PCT_MAX). This is too big and can make a remarkable performance effect for the guest. We see a lot of packets latency exceed 500ms when the CPU_THROTTLE_PCT_MAX reached. This patch set adds a new max-cpu-throttle parameter

Re: [Qemu-devel] [Qemu-ppc] [PULL 0/2] ppc-for-3.0 queue 20180801

2018-08-01 Thread Peter Maydell
On 1 August 2018 at 12:24, BALATON Zoltan wrote: > On Wed, 1 Aug 2018, Peter Maydell wrote: >> So, we've just put out rc3, which in an ideal world is our >> final release candidate for 3.0. Are these bugs regressions from >> 2.12 ? > > > I don't know about the macio one but the sam460ex PCI interr

Re: [Qemu-devel] [PATCH] ui: use enum to string helpers

2018-08-01 Thread Markus Armbruster
Marc-André Lureau writes: > Minor code simplification. It's also a bit more robust: FOO_str(VAL) checks VAL is in range, FOO_lookup.array[VAL] doesn't. > > Signed-off-by: Marc-André Lureau Reviewed-by: Markus Armbruster

Re: [Qemu-devel] [PATCH for-3.1] s390x: remove 's390-squash-mcss' option

2018-08-01 Thread Cornelia Huck
On Wed, 1 Aug 2018 14:54:51 +0200 Cornelia Huck wrote: > On Wed, 1 Aug 2018 18:21:27 +0800 > Fam Zheng wrote: > > > On Tue, 07/24 11:24, Cornelia Huck wrote: > > > diff --git a/hw/s390x/css-bridge.c b/hw/s390x/css-bridge.c > > > index a02d708239..1bd6c8b458 100644 > > > --- a/hw/s390x/css-bri

Re: [Qemu-devel] [PATCH] qemu-binfmt-conf.sh: add x86_64 target

2018-08-01 Thread Thomas Huth
On 08/01/2018 12:29 PM, Laurent Vivier wrote: > Signed-off-by: Laurent Vivier > --- > scripts/qemu-binfmt-conf.sh | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/scripts/qemu-binfmt-conf.sh b/scripts/qemu-binfmt-conf.sh > index b0dc8a714a..b5a16742a1 100755 > --- a/

Re: [Qemu-devel] [PATCH for-3.1] s390x: remove 's390-squash-mcss' option

2018-08-01 Thread Cornelia Huck
On Wed, 1 Aug 2018 15:11:23 +0200 Cornelia Huck wrote: > On Wed, 1 Aug 2018 14:54:51 +0200 > Cornelia Huck wrote: > > > On Wed, 1 Aug 2018 18:21:27 +0800 > > Fam Zheng wrote: > > > > > On Tue, 07/24 11:24, Cornelia Huck wrote: > > > > diff --git a/hw/s390x/css-bridge.c b/hw/s390x/css-br

Re: [Qemu-devel] [PATCH] monitor: avoid potential dead-lock when cleaning up

2018-08-01 Thread Markus Armbruster
Marc-André Lureau writes: > When a monitor is connected to a Spice chardev, the monitor cleanup > can dead-lock: > > #0 0x7f43446637fd in __lll_lock_wait () at /lib64/libpthread.so.0 > #1 0x7f434465ccf4 in pthread_mutex_lock () at /lib64/libpthread.so.0 > #2 0x556dd79f22ba in qe

[Qemu-devel] [PATCH v4 0/2] s390x: Enable KVM huge page backing support

2018-08-01 Thread Janosch Frank
v4: * Now using MiB * Now supporting 4k memory backings v3: * Fixed Cap name * Added mempath page size check and error reporting Janosch Frank (2): kvm: sync linux headers s390x: Enable KVM huge page backing support linux-headers/linux/kvm.h | 1 + target/s3

[Qemu-devel] [PATCH v4 2/2] s390x: Enable KVM huge page backing support

2018-08-01 Thread Janosch Frank
QEMU has had huge page support for a longer time already, but KVM memory management under s390x needed some changes to work with huge backings. Now that we have support, let's enable it if requested and available. Otherwise we now properly tell the user if there is no support and back out instead

[Qemu-devel] [PATCH v4 1/2] kvm: sync linux headers

2018-08-01 Thread Janosch Frank
Import KVM_CAP_S390_HPAGE_1M. Placeholder for proper sync. Signed-off-by: Janosch Frank --- linux-headers/linux/kvm.h | 1 + 1 file changed, 1 insertion(+) diff --git a/linux-headers/linux/kvm.h b/linux-headers/linux/kvm.h index 98f389a5a3..2aae948219 100644 --- a/linux-headers/linux/kvm.h +++

Re: [Qemu-devel] [PATCH for-3.1] tests/cpu-plug-test: check CPU hotplug on ppc64 with KVM

2018-08-01 Thread Greg Kurz
On Tue, 31 Jul 2018 13:25:59 +1000 David Gibson wrote: [...] > > > > The CPU hotplug test doesn't seem to do anything on the guest side: it > > just checks that 'device_add' returns a response that isn't an > > error. > > Right, which makes this ill suited to being a qtest test. The whole > p

Re: [Qemu-devel] [PATCH v4 2/2] s390x: Enable KVM huge page backing support

2018-08-01 Thread David Hildenbrand
On 01.08.2018 15:19, Janosch Frank wrote: > QEMU has had huge page support for a longer time already, but KVM > memory management under s390x needed some changes to work with huge > backings. > > Now that we have support, let's enable it if requested and > available. Otherwise we now properly tell

[Qemu-devel] [PATCH] tests: virtio: separate ccw tests from libqos

2018-08-01 Thread Paolo Bonzini
Because qtest does not support s390 channel I/O, s390 only performs smoke tests on those few devices that do not have any functional tests. Therefore, every time we add functional tests for a virtio device, the choice is between removing those tests from the s390 suite (so that s390 actually _lo

Re: [Qemu-devel] [PATCH 4/4] target/arm: Fix typo in helper_sve_movz_d

2018-08-01 Thread Laurent Desnogues
On Wed, Aug 1, 2018 at 2:31 PM, Richard Henderson wrote: > Reported-by: Laurent Desnogues > Signed-off-by: Richard Henderson Reviewed-by: Laurent Desnogues Tested-by: Laurent Desnogues Laurent > --- > target/arm/sve_helper.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff

Re: [Qemu-devel] [PATCH 1/4] target/arm: Fix sign of sve_cmpeq_ppzw/sve_cmpne_ppzw

2018-08-01 Thread Laurent Desnogues
On Wed, Aug 1, 2018 at 2:31 PM, Richard Henderson wrote: > The normal vector element is sign-extended before > comparing with the wide vector element. > > Reported-by: Laurent Desnogues > Signed-off-by: Richard Henderson Reviewed-by: Laurent Desnogues Tested-by: Laurent Desnogues Laurent >

Re: [Qemu-devel] [PATCH 3/4] target/arm: Reorganize SVE WHILE

2018-08-01 Thread Laurent Desnogues
On Wed, Aug 1, 2018 at 2:31 PM, Richard Henderson wrote: > The pseudocode for this operation is an increment + compare loop, > so comparing <= the maximum integer produces an all-true predicate. > > Rather than bound in both the inline code and the helper, pass the > helper the number of predicate

Re: [Qemu-devel] [PATCH 0/4] target/arm sve fixes

2018-08-01 Thread Laurent Desnogues
On Wed, Aug 1, 2018 at 2:31 PM, Richard Henderson wrote: > These four patches are minor, reported by Laurent this week. This fixes the reported issues, thanks! > If there happens to be an -rc4 release, it would be nice if > they were included. But if not, no biggie. I suspect that > other mino

Re: [Qemu-devel] [PATCH 2/4] target/arm: Fix typo in do_sat_addsub_64

2018-08-01 Thread Laurent Desnogues
On Wed, Aug 1, 2018 at 2:31 PM, Richard Henderson wrote: > Used the wrong temporary in the computation of subtractive overflow. > > Reported-by: Laurent Desnogues > Signed-off-by: Richard Henderson Reviewed-by: Laurent Desnogues Tested-by: Laurent Desnogues Laurent > --- > target/arm/tran

Re: [Qemu-devel] [PATCH] monitor: avoid potential dead-lock when cleaning up

2018-08-01 Thread Marc-André Lureau
Hi On Wed, Aug 1, 2018 at 3:19 PM, Markus Armbruster wrote: > Marc-André Lureau writes: > >> When a monitor is connected to a Spice chardev, the monitor cleanup >> can dead-lock: >> >> #0 0x7f43446637fd in __lll_lock_wait () at /lib64/libpthread.so.0 >> #1 0x7f434465ccf4 in pthread_m

Re: [Qemu-devel] [PATCH] tests: virtio: separate ccw tests from libqos

2018-08-01 Thread Cornelia Huck
On Wed, 1 Aug 2018 15:27:33 +0200 Paolo Bonzini wrote: > Because qtest does not support s390 channel I/O, s390 only performs smoke > tests on > those few devices that do not have any functional tests. Therefore, every > time we > add functional tests for a virtio device, the choice is between

[Qemu-devel] [PATCH v4 4/4] pc-dimm: assign and verify the "addr" property during pre_plug

2018-08-01 Thread David Hildenbrand
We can assign and verify the address before realizing and trying to plug. reading/writing the address property should never fail for DIMMs, so let's reduce error handling a bit by using &error_abort. Getting access to the memory region now might however fail. So forward errors from get_memory_regio

Re: [Qemu-devel] [PATCH for-3.1] tests/cpu-plug-test: check CPU hotplug on ppc64 with KVM

2018-08-01 Thread Greg Kurz
On Tue, 31 Jul 2018 13:27:15 +1000 David Gibson wrote: > On Mon, Jul 30, 2018 at 11:59:00AM +0200, Greg Kurz wrote: > > On Mon, 30 Jul 2018 10:41:45 +0200 > > Greg Kurz wrote: > > > > > On Mon, 30 Jul 2018 15:57:15 +1000 > > > David Gibson wrote: > > [...] > > > > > > I'm pretty sure try

[Qemu-devel] [PATCH v4 0/4] pc-dimm: pre_plug "slot" and "addr" assignment

2018-08-01 Thread David Hildenbrand
This is basically a resend of v3 with commit message changes. Paolo, if there are no further comments, can you please pick this up for 3.1? Thanks! --- As requested by Igor, assign and verify "slot" and "addr" in the pre_plug handler. Factor out the compatibility handling/configuration for detec

[Qemu-devel] [PATCH v4 1/4] pc-dimm: assign and verify the "slot" property during pre_plug

2018-08-01 Thread David Hildenbrand
We can assign and verify the slot before realizing and trying to plug. reading/writing the slot property should never fail, so let's reduce error handling a bit by using &error_abort. To do this during pre_plug, add and use (x86, ppc) pc_dimm_pre_plug(). Reviewed-by: David Gibson Reviewed-by: Ig

[Qemu-devel] [PATCH v4 2/4] util/oslib-win32: indicate alignment for qemu_anon_ram_alloc()

2018-08-01 Thread David Hildenbrand
Let's set the alignment just like for the posix variant. This will implicitly set the alignment of the underlying memory region and therefore make memory_region_get_alignment(mr) return something > 0 for all memory backends applicable to PCDIMM/NVDIMM. The allocation granularity is ususally 64k, w

Re: [Qemu-devel] [RFC] target/mips: Initial support for MIPS R5900

2018-08-01 Thread Fredrik Noring
Thank you for your review, Maciej, > > The MIPS R5900 is normally taken to be MIPS3, but it has MOVN, MOVZ and PREF > > defined in MIPS4 which is why ISA_MIPS4 is chosen for this patch. > > It also has several instructions removed, so I don't think you can really > just mark it MIPS IV without

[Qemu-devel] [PATCH v4 3/4] pc: drop memory region alignment check for 0

2018-08-01 Thread David Hildenbrand
All applicable memory regions always have an alignment > 0. All memory backends result in file_ram_alloc() or qemu_anon_ram_alloc() getting called, setting the alignment to > 0. So a PCDIMM memory region always has an alignment > 0. NVDIMM copy the alignment of the original memory memory region in

Re: [Qemu-devel] [Qemu-arm] [PATCH 4/4] target/arm: Fix typo in helper_sve_movz_d

2018-08-01 Thread Alex Bennée
Richard Henderson writes: > Reported-by: Laurent Desnogues > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > target/arm/sve_helper.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/arm/sve_helper.c b/target/arm/sve_helper.c > index 87594a8

Re: [Qemu-devel] [Qemu-arm] [PATCH 1/4] target/arm: Fix sign of sve_cmpeq_ppzw/sve_cmpne_ppzw

2018-08-01 Thread Alex Bennée
Richard Henderson writes: > The normal vector element is sign-extended before > comparing with the wide vector element. > > Reported-by: Laurent Desnogues > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > target/arm/sve_helper.c | 12 ++-- > 1 file changed, 6 ins

Re: [Qemu-devel] [RFC] target/mips: Initial support for MIPS R5900

2018-08-01 Thread Richard Henderson
On 08/01/2018 09:39 AM, Fredrik Noring wrote: > Can QEMU be instructed to emulate > the FPU only for Linux user space programs as opposed to hardware emulation? Yes, that can be done. I would suggest something like /* * Hardware traps to the operating system for emulation. * For user-only, qe

Re: [Qemu-devel] [PATCH] scsi: mptsas: Mark as storage device

2018-08-01 Thread Paolo Bonzini
On 01/08/2018 00:28, Guenter Roeck wrote: > mptsas1068 is currently listed as uncategorized device. > Mark it as storage device. > > Signed-off-by: Guenter Roeck > --- > hw/scsi/mptsas.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/scsi/mptsas.c b/hw/scsi/mptsas.c > index 4176e87

Re: [Qemu-devel] [PULL 1/1] slirp: fix ICMP handling on macOS hosts

2018-08-01 Thread Andrew Oates via Qemu-devel
On Wed, Aug 1, 2018 at 6:10 AM Peter Maydell wrote: > On 1 August 2018 at 00:25, Andrew Oates wrote: > > Both CONFIG_BSD and not-CONFIG_LINUX work on macOS. I unfortunately > don't > > have access to any other BSDs to test them, though. > > Is there an easy way to test it? The QEMU makefiles ha

Re: [Qemu-devel] [PATCH] throttle-groups: fix hang when group member leaves

2018-08-01 Thread Alberto Garcia
On Tue 31 Jul 2018 06:47:53 PM CEST, Alberto Garcia wrote: > On Wed 04 Jul 2018 04:54:10 PM CEST, Stefan Hajnoczi wrote: >> Throttle groups consist of members sharing one throttling state >> (including bps/iops limits). Round-robin scheduling is used to ensure >> fairness. If a group member alrea

Re: [Qemu-devel] [PATCH] monitor: avoid potential dead-lock when cleaning up

2018-08-01 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > On Wed, Aug 1, 2018 at 3:19 PM, Markus Armbruster wrote: >> Marc-André Lureau writes: >> >>> When a monitor is connected to a Spice chardev, the monitor cleanup >>> can dead-lock: >>> >>> #0 0x7f43446637fd in __lll_lock_wait () at /lib64/libpthread.so.0

[Qemu-devel] [Bug 1776224] Re: QEMU's SPICE server not getting leds callback when sending capslock

2018-08-01 Thread Bastien Orivel
This is in fact https://bugs.launchpad.net/ubuntu/+source/console-setup/+bug/425704 Sorry for the noise ** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bug

Re: [Qemu-devel] [PATCH 0/4] target/arm sve fixes

2018-08-01 Thread Alex Bennée
Richard Henderson writes: > These four patches are minor, reported by Laurent this week. > > If there happens to be an -rc4 release, it would be nice if > they were included. But if not, no biggie. I suspect that > other minor issues will be found past these four, so I would > hope everyone w

[Qemu-devel] [PATCH] fix "Missing break in switch" coverity reports

2018-08-01 Thread Paolo Bonzini
Many of these are marked as "intentional/fix required" because they just need adding a fall through comment. This is exactly what this patch does, except for target/mips/translate.c where it is easier to duplicate the code, and hw/audio/sb16.c where I consulted the DOSBox sources and decide to jus

Re: [Qemu-devel] [PATCH v3] block/gluster: Handle changed glfs_ftruncate signature

2018-08-01 Thread Eric Blake
On 08/01/2018 06:47 AM, Niels de Vos wrote: If glusterfs-5 releases in October, that may line up with 3.1 or 3.2. Ok, I'll keep these kind of patches in my tree as work-in-progress and when the glusterfs-5 gets tagged for alpha/beta send it again. Even if not optimal, would you accept this as

Re: [Qemu-devel] [PATCH] fix "Missing break in switch" coverity reports

2018-08-01 Thread Philippe Mathieu-Daudé
Le mer. 1 août 2018 12:15, Paolo Bonzini a écrit : > Many of these are marked as "intentional/fix required" because they > just need adding a fall through comment. This is exactly what this > patch does, except for target/mips/translate.c where it is easier to > duplicate the code, and hw/audio/

  1   2   >