Le 01/08/2018 à 00:57, umarcor a écrit : > Alex, Laurent, I'm new to this management/development system. So, first > off, thanks for working on this bug. > > I have a few (probably silly) questions: > > 1. What is 'the r-b' that Alex used in #14?
"Reviewed-By:", it's a tag I've sent in answer to his e-email to say I've reviewed his patch, and it is good for me. > 2. When should I change the status of the bug? I can already see it in GitHub's mirror and in https://git.qemu.org/?p=qemu.git;a=summary. But not in the Changelog: https://wiki.qemu.org/ChangeLog/3.0#User- mode_emulation. I am not sure if it is in 'Fix Committed' or 'Fix Released' state. I didn't update the Changelog, but the fix is now committed. It will be released soon (07/08 or 14/08). But you should test master now to check the commit really fixes your bug. > 3. Where did you push these commits to before they where merge in https://git.qemu.org/?p=qemu.git;a=summary? I cannot find your personal forks/branches. Are commits automatically created from the mailing list? No, sub-system maintainers collect patches from the mailing list. They create and send a pull request (in their own git repo) to the QEMU maintainers, and he merges the patches into the master. my git repo for linux-user pull request is git://github.com/vivier/qemu.git, and generally I prepare my pull request on linux-user-for-3.0 branch (the release number changes). Thanks, Laurent -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1783362 Title: qemu-user: mmap should return failure (MAP_FAILED, -1) instead of success (NULL, 0) when len==0 Status in QEMU: In Progress Status in qemu package in Ubuntu: In Progress Bug description: As shown in https://github.com/beehive- lab/mambo/issues/19#issuecomment-407420602, with len==0 mmap returns success (NULL, 0) instead of failure (MAP_FAILED, -1) in a x86_64 host executing a ELF 64-bit LSB executable, ARM aarch64 binary. Steps to reproduce the bug: - (cross-)compile the attached source file: $ aarch64-linux-gnu-gcc -static -std=gnu99 -lpthread test/mmap_qemu.c -o mmap_qemu - Execute in a x86_64 host with qemu-user and qemu-user-binfmt: $ ./mmap_qemu alloc: 0 MAP_FAILED: -1 errno: 0 mmap_qemu: test/mmap_qemu.c:15: main: Assertion `alloc == MAP_FAILED' failed. qemu: uncaught target signal 6 (Aborted) - core dumped Aborted (core dumped) - Execute in a ARM host without any additional dependecy: $ ./mmap_qemu alloc: -1 MAP_FAILED: -1 errno: 22 The bug is present in Fedora: $ qemu-aarch64 --version qemu-aarch64 version 2.11.2(qemu-2.11.2-1.fc28) Copyright (c) 2003-2017 Fabrice Bellard and the QEMU Project developers $ uname -r 4.17.7-200.fc28.x86_64 And also in Ubuntu: $ qemu-aarch64 --version qemu-aarch64 version 2.12.0 (Debian 1:2.12+dfsg-3ubuntu3) Copyright (c) 2003-2017 Fabrice Bellard and the QEMU Project developers $ uname -r 4.15.0-23-generic Possibly related to: - https://lists.freebsd.org/pipermail/freebsd-hackers/2009-July/029109.html - https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=203852 To manage notifications about this bug go to: https://bugs.launchpad.net/qemu/+bug/1783362/+subscriptions
