Re: [Qemu-devel] [PATCH v5 23/24] replay: add BH oneshot event for block layer

2018-07-31 Thread Pavel Dovgalyuk
> From: Alex Bennée [mailto:alex.ben...@linaro.org] > Pavel Dovgalyuk writes: > > > Replay is capable of recording normal BH events, but sometimes > > there are single use callbacks scheduled with aio_bh_schedule_oneshot > > function. This patch enables recording and replaying such callbacks. > >

Re: [Qemu-devel] [PATCH RFC] monitor: temporary fix for dead-lock on event recursion

2018-07-31 Thread Markus Armbruster
Marc-André Lureau writes: > With a Spice port chardev, it is possible to reenter > monitor_qapi_event_queue() (when the client disconnects for > example). This will dead-lock on monitor_lock. > > Instead, use some TLS variables to check for recursion and queue the > events. [...] > > Note that er

Re: [Qemu-devel] [PATCH 0/3] linux-user/sparc: Fixes for clone

2018-07-31 Thread Alex Bennée
Richard Henderson writes: > There are at least 4 separate bugs preventing clone from working. > > (1) cpu_copy left both cpus sharing the same register window (!) > > (2) cpu_clone_regs did not initialize %o1, so the new thread path > in the guest __clone was always taken, even for the pare

Re: [Qemu-devel] [RFC 3/3] vhost-user: support programming VFIO group in master

2018-07-31 Thread Tiwei Bie
On Mon, Jul 30, 2018 at 12:30:58PM +0300, Michael S. Tsirkin wrote: > On Mon, Jul 30, 2018 at 04:10:04PM +0800, Tiwei Bie wrote: > > On Fri, Jul 27, 2018 at 02:03:00PM -0600, Alex Williamson wrote: > > > On Fri, 27 Jul 2018 09:58:05 +0800 > > > Tiwei Bie wrote: > > > > > > > On Thu, Jul 26, 2018

[Qemu-devel] [PULL 0/4] Misc patches for 2018-07-30

2018-07-31 Thread Paolo Bonzini
The following changes since commit 6d9dd5fb9d0e9f4a174f53a0e20a39fbe809c71e: Merge remote-tracking branch 'remotes/armbru/tags/pull-qobject-2018-07-27-v2' into staging (2018-07-30 09:55:47 +0100) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstream f

[Qemu-devel] [PULL 3/4] timer: remove replay clock probe in deadline calculation

2018-07-31 Thread Paolo Bonzini
From: Pavel Dovgalyuk Ciro Santilli reported that commit a5ed352596a8b7eb2f9acce34371b944ac3056c4 breaks the execution replay. It happens due to the probing the clock for the new instances of iothread. However, this probing was made in replay mode for the timer lists that are empty. This patch re

[Qemu-devel] [PULL 4/4] backends/cryptodev: remove dead code

2018-07-31 Thread Paolo Bonzini
From: Jay Zhou Fix Coverity issue 1390600. Signed-off-by: Jay Zhou Message-Id: <1524894864-7492-1-git-send-email-jianjay.z...@huawei.com> Reviewed-by: Stefan Hajnoczi Signed-off-by: Paolo Bonzini --- backends/cryptodev-vhost-user.c | 5 - 1 file changed, 5 deletions(-) diff --git a/back

[Qemu-devel] [PULL 2/4] i386: implement MSR_SMI_COUNT for TCG

2018-07-31 Thread Paolo Bonzini
This is trivial, so just do it. Signed-off-by: Paolo Bonzini --- target/i386/misc_helper.c | 3 +++ target/i386/smm_helper.c | 1 + 2 files changed, 4 insertions(+) diff --git a/target/i386/misc_helper.c b/target/i386/misc_helper.c index 628f64a..78f2020 100644 --- a/target/i386/misc_helper.c

Re: [Qemu-devel] [PATCH v2 2/4] kvm: Use inhibit to prevent ballooning without synchronous mmu

2018-07-31 Thread David Hildenbrand
On 31.07.2018 01:14, Alex Williamson wrote: > Remove KVM specific tests in balloon_page(), instead marking > ballooning as inhibited without KVM_CAP_SYNC_MMU support. > > Signed-off-by: Alex Williamson > --- > accel/kvm/kvm-all.c|4 > hw/virtio/virtio-balloon.c |4 +--- > 2

Re: [Qemu-devel] [PATCH v2 1/4] balloon: Allow nested inhibits

2018-07-31 Thread David Hildenbrand
On 31.07.2018 01:13, Alex Williamson wrote: > A simple true/false internal state does not allow multiple users. Fix > this within the existing interface by converting to a counter, so long > as the counter is elevated, ballooning is inhibited. > Not sure if "nested" is really the right term here

Re: [Qemu-devel] [qemu-s390x] [PATCH 1/1] s390x/sclp: fix maxram calculation

2018-07-31 Thread David Hildenbrand
On 30.07.2018 17:47, Cornelia Huck wrote: > On Mon, 30 Jul 2018 17:43:42 +0200 > David Hildenbrand wrote: > >> On 30.07.2018 16:09, Christian Borntraeger wrote: >>> We clamp down ram_size to match the sclp increment size. We do >>> not do the same for maxram_size, which means for large guests >>>

[Qemu-devel] [PATCH 3/3] hmp: add hmp for migrate_set_max_cpu_throttle

2018-07-31 Thread Li Qiang
Signed-off-by: Li Qiang --- hmp-commands.hx | 14 ++ hmp.c | 6 ++ hmp.h | 1 + 3 files changed, 21 insertions(+) diff --git a/hmp-commands.hx b/hmp-commands.hx index 91dfe51c37..9d54ecbe4e 100644 --- a/hmp-commands.hx +++ b/hmp-commands.hx @@ -1042,6 +1042,

[Qemu-devel] [PATCH 0/3] Add a new migrate_set_max_cpu_throttle qmp command

2018-07-31 Thread Li Qiang
Currently, the default maximum CPU throttle for migration is 99(CPU_THROTTLE_PCT_MAX). This is too big and can make a remarkable performance effect for the guest. We see a lot of packets latency exceed 500ms when the CPU_THROTTLE_PCT_MAX reached. This patch set adds a new qmp command to limit the

[Qemu-devel] [PATCH 1/3] migrate: replace the cpu throttle percentage max with a variable

2018-07-31 Thread Li Qiang
So we can config it using qmp. Signed-off-by: Li Qiang --- cpus.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/cpus.c b/cpus.c index b5844b7103..6569c73d24 100644 --- a/cpus.c +++ b/cpus.c @@ -83,6 +83,8 @@ static unsigned int throttle_percentage; #define CPU_THROTTLE_

[Qemu-devel] [PATCH 2/3] migration: Add qmp command for migrate_set_max_cpu_throttle

2018-07-31 Thread Li Qiang
The default max cpu throttle is 99, this is too big that may influence the guest loads. Add a qmp to config it can make it more flexible. Signed-off-by: Li Qiang --- cpus.c| 5 + include/qom/cpu.h | 8 migration/migration.c | 10 ++ qapi/migration.json

[Qemu-devel] [PULL 2/3] tests: add check_invalid_maps to test-mmap

2018-07-31 Thread Laurent Vivier
From: Alex Bennée This adds a test to make sure we fail properly for a 0 length mmap. There are most likely other failure conditions we should also check. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Cc: umarcor <1783...@bugs.launchpad.net> Message-Id: <20180730134321.19898-3-alex

[Qemu-devel] [PULL 1/3] linux-user/mmap.c: handle invalid len maps correctly

2018-07-31 Thread Laurent Vivier
From: Alex Bennée I've slightly re-organised the check to more closely match the sequence that the kernel uses in do_mmap(). We check for both the zero case (EINVAL) and the overflow length case (ENOMEM). Signed-off-by: Alex Bennée Cc: umarcor <1783...@bugs.launchpad.net> Reviewed-by: Laurent V

[Qemu-devel] [PATCH] s390x: Enable KVM huge page backing support

2018-07-31 Thread Janosch Frank
From: Janosch Frank QEMU has had huge page support for a longer time already, but KVM memory management under s390x needed some changes to work with huge backings. Now that we have support, let's enable it if requested and available. Otherwise we now properly tell the user if there is no support

[Qemu-devel] [PULL 0/3] Linux user for 3.0 patches

2018-07-31 Thread Laurent Vivier
The following changes since commit 6d9dd5fb9d0e9f4a174f53a0e20a39fbe809c71e: Merge remote-tracking branch 'remotes/armbru/tags/pull-qobject-2018-07-27-v2' into staging (2018-07-30 09:55:47 +0100) are available in the Git repository at: git://github.com/vivier/qemu.git tags/linux-user-for-3.

[Qemu-devel] [PULL 3/3] linux-user: ppc64: don't use volatile register during safe_syscall

2018-07-31 Thread Laurent Vivier
From: Shivaprasad G Bhat r11 is a volatile register on PPC as per calling conventions. The safe_syscall code uses it to check if the signal_pending is set during the safe_syscall. When a syscall is interrupted on return from signal handling, the r11 might be corrupted before we retry the syscall

Re: [Qemu-devel] [PATCH] s390x: Enable KVM huge page backing support

2018-07-31 Thread Cornelia Huck
On Tue, 31 Jul 2018 09:42:36 +0100 Janosch Frank wrote: > From: Janosch Frank > > QEMU has had huge page support for a longer time already, but KVM > memory management under s390x needed some changes to work with huge > backings. > > Now that we have support, let's enable it if requested and >

Re: [Qemu-devel] [PATCH 1/2] bitmap.h: add comments to BITMAP_LAST_WORD_MASK

2018-07-31 Thread Wei Wang
On 07/30/2018 09:19 PM, Juan Quintela wrote: Wei Wang wrote: On 07/30/2018 03:13 PM, Wei Wang wrote: This macro was ported from Linux and we've reached an aggreement there that the corner case "nbits = 0" is not applicable to this macro, because when "nbits = 0", which means no bits to mask, t

Re: [Qemu-devel] [PULL 00/13] Block layer patches

2018-07-31 Thread Peter Maydell
On 30 July 2018 at 16:09, Kevin Wolf wrote: > The following changes since commit 6d9dd5fb9d0e9f4a174f53a0e20a39fbe809c71e: > > Merge remote-tracking branch > 'remotes/armbru/tags/pull-qobject-2018-07-27-v2' into staging (2018-07-30 > 09:55:47 +0100) > > are available in the git repository at:

[Qemu-devel] [PATCH 0/2] etoken patch for 3.1

2018-07-31 Thread Christian Borntraeger
this depends on the current kvms390/next kernel tree. Christian Borntraeger (2): header sync s390x/kvm: add etoken facility linux-headers/asm-s390/kvm.h| 5 - target/s390x/cpu.h | 3 +++ target/s390x/cpu_features.c | 3 ++- target/s390x/cpu_features_def.h | 3 ++-

[Qemu-devel] [PATCH 2/2] s390x/kvm: add etoken facility

2018-07-31 Thread Christian Borntraeger
Provide the etoken facility. We need to handle cpu model, migration and clear reset. Signed-off-by: Christian Borntraeger Acked-by: Janosch Frank --- target/s390x/cpu.h | 3 +++ target/s390x/cpu_features.c | 3 ++- target/s390x/cpu_features_def.h | 3 ++- target/s390x/gen-fe

[Qemu-devel] [PATCH 1/2] header sync

2018-07-31 Thread Christian Borntraeger
-> place holder for proper header sync. Signed-off-by: Christian Borntraeger --- linux-headers/asm-s390/kvm.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/linux-headers/asm-s390/kvm.h b/linux-headers/asm-s390/kvm.h index 11def14301..1ab9901911 100644 --- a/linux-header

[Qemu-devel] [PATCH v2 1/2] kvm: sync linux headers

2018-07-31 Thread Janosch Frank
Import KVM_CAP_S390_HPAGE. Placeholder for proper sync. Signed-off-by: Janosch Frank --- linux-headers/linux/kvm.h | 1 + 1 file changed, 1 insertion(+) diff --git a/linux-headers/linux/kvm.h b/linux-headers/linux/kvm.h index 98f389a5a3..e3b1e3070c 100644 --- a/linux-headers/linux/kvm.h +++ b/l

[Qemu-devel] [PATCH v2 0/2] s390x: Enable KVM huge page backing support

2018-07-31 Thread Janosch Frank
Will be available with kernel 4.19. Janosch Frank (2): kvm: sync linux headers s390x: Enable KVM huge page backing support linux-headers/linux/kvm.h | 1 + target/s390x/kvm.c| 6 ++ 2 files changed, 7 insertions(+) -- 2.14.3

[Qemu-devel] [PATCH v2 2/2] s390x: Enable KVM huge page backing support

2018-07-31 Thread Janosch Frank
QEMU has had huge page support for a longer time already, but KVM memory management under s390x needed some changes to work with huge backings. Now that we have support, let's enable it if requested and available. Otherwise we now properly tell the user if there is no support and back out instead

Re: [Qemu-devel] [PATCH v3] block/gluster: Handle changed glfs_ftruncate signature

2018-07-31 Thread Niels de Vos
On Mon, Jul 30, 2018 at 03:27:29PM -0400, Jeff Cody wrote: > On Mon, Jul 30, 2018 at 10:07:27AM -0500, Eric Blake wrote: > > On 07/28/2018 02:50 AM, Niels de Vos wrote: > > >> > > >>Part of me wishes that libgfapi had just created a new function > > >>'glfs_ftruncate2', so that existing users don't

Re: [Qemu-devel] [PATCH v1 1/1] configure: Add RISC-V host support

2018-07-31 Thread Daniel P . Berrangé
On Mon, Jul 30, 2018 at 07:37:55PM +0100, Peter Maydell wrote: > On 30 July 2018 at 19:20, Philippe Mathieu-Daudé wrote: > > Before this patch: > > > > $ ./configure > > > > ERROR: Unsupported CPU = riscv64, try --enable-tcg-interpreter > > > > $ ./configure --enable-tcg-interpreter > > Unsupporte

Re: [Qemu-devel] [PATCH 2/2] s390x/kvm: add etoken facility

2018-07-31 Thread Cornelia Huck
On Tue, 31 Jul 2018 11:04:48 +0200 Christian Borntraeger wrote: > Provide the etoken facility. We need to handle cpu model, migration and > clear reset. > > Signed-off-by: Christian Borntraeger > Acked-by: Janosch Frank > --- > target/s390x/cpu.h | 3 +++ > target/s390x/cpu_feat

Re: [Qemu-devel] [PATCH v1 1/1] configure: Add RISC-V host support

2018-07-31 Thread Peter Maydell
On 31 July 2018 at 10:30, Daniel P. Berrangé wrote: > On Mon, Jul 30, 2018 at 07:37:55PM +0100, Peter Maydell wrote: >> We should fix this somewhat nonsensical error message by >> completing the deprecate-and-drop cycle for this bit of >> configure, ie by outright rejecting attempts to build on >>

[Qemu-devel] Any tutorial to read/write in qcow2 format by programming way?

2018-07-31 Thread lampahome
As titled I learn some info about qcow2 and tried to write some data and make it qualified for qcow2 format. I do it and mount through qemu-nbd successfully. But I don't know how taking snapshot and backing file works in programming way. Can someone tell me some tutorial to know or code snippet

Re: [Qemu-devel] [PATCH 2/2] s390x/kvm: add etoken facility

2018-07-31 Thread Cornelia Huck
On Tue, 31 Jul 2018 11:04:48 +0200 Christian Borntraeger wrote: > Provide the etoken facility. We need to handle cpu model, migration and > clear reset. ^^^ Hm, anything special for that? I don't see it in the patch. > > Signed-off-by: Christian Borntraeger > Acked-by: Janosch Frank

Re: [Qemu-devel] [PATCH] sam460ex: Fix PCI interrupt connections

2018-07-31 Thread BALATON Zoltan
On Tue, 31 Jul 2018, Sebastian Bauer wrote: There is also the possibility to make the special (num-irqs == 1) the common case, as the Sam460ex platform is the only user of this bus so far (and probably stays the only one). I'm not sure if it is worth all the hassle. I'd vote for this as I've s

Re: [Qemu-devel] [PATCH for-3.0 v2] pc: acpi: fix memory hotplug regression by reducing stub SRAT entry size

2018-07-31 Thread Igor Mammedov
On Mon, 30 Jul 2018 17:26:24 -0300 Eduardo Habkost wrote: > On Mon, Jul 30, 2018 at 11:41:41AM +0200, Igor Mammedov wrote: > > Commit 848a1cc1e (hw/acpi-build: build SRAT memory affinity structures for > > DIMM devices) > > broke the first dimm hotplug in following cases: > > > > 1: there is n

Re: [Qemu-devel] [PULL for-3.0 0/1] s390x fix for -rc3

2018-07-31 Thread Peter Maydell
On 31 July 2018 at 07:50, Cornelia Huck wrote: > The following changes since commit 18a398f6a39df4b08ff86ac0d38384193ca5f4cc: > > Update version for v3.0.0-rc2 release (2018-07-24 22:06:31 +0100) > > are available in the Git repository at: > > git://github.com/cohuck/qem

Re: [Qemu-devel] [PATCH 2/2] s390x/kvm: add etoken facility

2018-07-31 Thread Christian Borntraeger
On 07/31/2018 11:44 AM, Cornelia Huck wrote: > On Tue, 31 Jul 2018 11:04:48 +0200 > Christian Borntraeger wrote: > >> Provide the etoken facility. We need to handle cpu model, migration and >> clear reset. > ^^^ Clear reset is the "strong one". Here we do a memset of the env structu

Re: [Qemu-devel] [PATCH 2/2] s390x/kvm: add etoken facility

2018-07-31 Thread Christian Borntraeger
On 07/31/2018 11:37 AM, Cornelia Huck wrote: > On Tue, 31 Jul 2018 11:04:48 +0200 > Christian Borntraeger wrote: > >> Provide the etoken facility. We need to handle cpu model, migration and >> clear reset. >> >> Signed-off-by: Christian Borntraeger >> Acked-by: Janosch Frank >> --- >> targe

Re: [Qemu-devel] [PULL 1/1] slirp: fix ICMP handling on macOS hosts

2018-07-31 Thread Peter Maydell
On 31 July 2018 at 02:16, Andrew Oates wrote: > Yeah, I suspect (but haven't tested) that this applies to all BSDs. We > could switch CONFIG_DARWIN to CONFIG_BSD (happy to resend the patch, just > LMK). > > Agreed that platform-specific ifdefs are gross, but I don't see a better way > here :/ On

Re: [Qemu-devel] VCPU hotplug on KVM/ARM

2018-07-31 Thread Igor Mammedov
On Wed, 25 Jul 2018 14:07:12 +0100 Marc Zyngier wrote: > On 25/07/18 13:28, Andrew Jones wrote: > > On Wed, Jul 25, 2018 at 11:40:54AM +0100, Marc Zyngier wrote: > >> On 24/07/18 19:35, Maran Wilson wrote: > >>> It's been a few months since this email thread died off. Has anyone > >>> starte

Re: [Qemu-devel] [PATCH v3 for-3.0] tests/libqtest: Improve kill_qemu()

2018-07-31 Thread Richard Henderson
On 07/30/2018 06:08 PM, Eric Blake wrote: > In kill_qemu() we have an assert that checks that the QEMU process > didn't dump core: > assert(!WCOREDUMP(wstatus)); > > Unfortunately the WCOREDUMP macro here means the resulting message > is not very easy to comprehend on at least some sys

[Qemu-devel] [PATCH v2] bitmap: fix BITMAP_LAST_WORD_MASK

2018-07-31 Thread Wei Wang
When "nbits = 0", which means no bits to mask, this macro is expected to return 0, instead of 0x. This patch changes the macro to return 0 when there is no bit needs to be masked. Signed-off-by: Wei Wang CC: Juan Quintela CC: Dr. David Alan Gilbert CC: Peter Xu --- include/qemu/bitmap

Re: [Qemu-devel] [PATCH] sam460ex: Fix PCI interrupt connections

2018-07-31 Thread Sebastian Bauer
Hi, Am 2018-07-31 11:50, schrieb BALATON Zoltan: On Tue, 31 Jul 2018, Sebastian Bauer wrote: There is also the possibility to make the special (num-irqs == 1) the common case, as the Sam460ex platform is the only user of this bus so far (and probably stays the only one). I'm not sure if it is

Re: [Qemu-devel] [RFC PATCH 1/6] qdev: add a power and clock gating support

2018-07-31 Thread Damien Hedde
Hi Philippe, On 07/27/2018 06:33 PM, Philippe Mathieu-Daudé wrote: > Hi Damien, > > On 07/27/2018 11:37 AM, Damien Hedde wrote: >> Add two boolean new fields _powered_ and _clocked_ to hold the gating >> state. Also add methods to act on each gating change. >> The power/clock gating is controlled

[Qemu-devel] [PATCH] monitor: accept input on resume

2018-07-31 Thread Marc-André Lureau
A chardev may stop trying to write if the associated can_read() callback returned 0. This happens when the monitor is suspended. The frontend is supposed to call qemu_chr_fe_accept_input() when it is ready to accept data again. Signed-off-by: Marc-André Lureau --- monitor.c | 1 + 1 file changed

Re: [Qemu-devel] [PATCH 2/4] linux-user: Pass the parent env to cpu_clone_regs

2018-07-31 Thread Alex Bennée
Richard Henderson writes: > Implementing clone for sparc requires that we make modifications > to both the parent and child cpu state. In all other cases, the > new argument can be ignored. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > linux-user/aarch64/target_cpu

Re: [Qemu-devel] [PATCH 1/1] s390x/sclp: fix maxram calculation

2018-07-31 Thread Cornelia Huck
On Tue, 31 Jul 2018 08:52:05 +0200 Cornelia Huck wrote: > On Mon, 30 Jul 2018 11:58:13 -0500 > Michael Roth wrote: > > > Quoting Christian Borntraeger (2018-07-30 10:31:12) > > > Are we still able to get things into 2.12.1 or are we too late? > > > > Freeze is EOD today, but I can grab t

Re: [Qemu-devel] [PATCH 2/2] s390x/kvm: add etoken facility

2018-07-31 Thread Cornelia Huck
On Tue, 31 Jul 2018 12:14:28 +0200 Christian Borntraeger wrote: > On 07/31/2018 11:44 AM, Cornelia Huck wrote: > > On Tue, 31 Jul 2018 11:04:48 +0200 > > Christian Borntraeger wrote: > > > >> Provide the etoken facility. We need to handle cpu model, migration and > >> clear reset. > > ^^^

Re: [Qemu-devel] [PATCH 1/4] linux-user: Disallow setting newsp for fork

2018-07-31 Thread Alex Bennée
Richard Henderson writes: > Or really, just clone devolving into fork. This should not ever happen > in practice. We do want to reserve calling cpu_clone_regs for the case > in which we are actually performing a clone. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- >

[Qemu-devel] [PATCH for-3.1] xics: don't include "target/ppc/cpu-qom.h" in "hw/ppc/xics.h"

2018-07-31 Thread Greg Kurz
The last user of the PowerPCCPU typedef in "hw/ppc/xics.h" vanished with commit b1fd36c363d73969841468146ebfb9fd84a5ee52. It isn't necessary to include "target/ppc/cpu-qom.h" there anymore. Signed-off-by: Greg Kurz --- include/hw/ppc/xics.h |1 - 1 file changed, 1 deletion(-) diff --git a/i

Re: [Qemu-devel] VCPU hotplug on KVM/ARM

2018-07-31 Thread David Hildenbrand
On 31.07.2018 12:27, Igor Mammedov wrote: > On Wed, 25 Jul 2018 14:07:12 +0100 > Marc Zyngier wrote: > >> On 25/07/18 13:28, Andrew Jones wrote: >>> On Wed, Jul 25, 2018 at 11:40:54AM +0100, Marc Zyngier wrote: On 24/07/18 19:35, Maran Wilson wrote: > It's been a few months since thi

Re: [Qemu-devel] [PATCH 2/2] s390x/kvm: add etoken facility

2018-07-31 Thread David Hildenbrand
On 31.07.2018 11:04, Christian Borntraeger wrote: > Provide the etoken facility. We need to handle cpu model, migration and > clear reset. > > Signed-off-by: Christian Borntraeger > Acked-by: Janosch Frank > --- > target/s390x/cpu.h | 3 +++ > target/s390x/cpu_features.c | 3

Re: [Qemu-devel] [PATCH] s390x: Enable KVM huge page backing support

2018-07-31 Thread David Hildenbrand
On 31.07.2018 10:42, Janosch Frank wrote: > From: Janosch Frank > > QEMU has had huge page support for a longer time already, but KVM > memory management under s390x needed some changes to work with huge > backings. > > Now that we have support, let's enable it if requested and > available. Othe

[Qemu-devel] [PATCH] sam460ex: Fix PCI interrupts with multiple devices

2018-07-31 Thread BALATON Zoltan
The four interrupts of the PCI bus are connected to the same UIC pin on the real Sam460ex. Evidence for this can be found in the UBoot source for the Sam460ex in the Sam460ex.c file where PCI_INTERRUPT_LINE is written. Change the ppc440_pcix model to behave more like this. This fixes the problem t

Re: [Qemu-devel] [Qemu-ppc] [PATCH] sam460ex: Fix PCI interrupt connections

2018-07-31 Thread BALATON Zoltan
On Tue, 31 Jul 2018, Sebastian Bauer wrote: Am 2018-07-31 11:50, schrieb BALATON Zoltan: On Tue, 31 Jul 2018, Sebastian Bauer wrote: There is also the possibility to make the special (num-irqs == 1) the common case, as the Sam460ex platform is the only user of this bus so far (and probably sta

Re: [Qemu-devel] [PATCH 2/3] migration: Add qmp command for migrate_set_max_cpu_throttle

2018-07-31 Thread Dr. David Alan Gilbert
* Li Qiang (liq...@gmail.com) wrote: > The default max cpu throttle is 99, this is too big that may > influence the guest loads. Add a qmp to config it can make it > more flexible. > > Signed-off-by: Li Qiang This should be done as a migration parameter rather than a new command. For example, fo

Re: [Qemu-devel] [PATCH 0/2] etoken patch for 3.1

2018-07-31 Thread Cornelia Huck
On Tue, 31 Jul 2018 11:04:46 +0200 Christian Borntraeger wrote: > this depends on the current kvms390/next kernel tree. > > Christian Borntraeger (2): > header sync > s390x/kvm: add etoken facility > > linux-headers/asm-s390/kvm.h| 5 - > target/s390x/cpu.h | 3 +++ >

Re: [Qemu-devel] [PATCH] monitor: accept input on resume

2018-07-31 Thread Markus Armbruster
Marc-André Lureau writes: > A chardev may stop trying to write if the associated can_read() > callback returned 0. This happens when the monitor is suspended. > The frontend is supposed to call qemu_chr_fe_accept_input() when it is > ready to accept data again. > > Signed-off-by: Marc-André Lurea

Re: [Qemu-devel] [PATCH 0/2] etoken patch for 3.1

2018-07-31 Thread Christian Borntraeger
On 07/31/2018 01:29 PM, Cornelia Huck wrote: > On Tue, 31 Jul 2018 11:04:46 +0200 > Christian Borntraeger wrote: > >> this depends on the current kvms390/next kernel tree. >> >> Christian Borntraeger (2): >> header sync >> s390x/kvm: add etoken facility >> >> linux-headers/asm-s390/kvm.h

Re: [Qemu-devel] [PATCH] qemu-img-cmds.hx: Add example usage for create command

2018-07-31 Thread Eric Blake
On 07/30/2018 09:52 PM, John Arbuckle wrote: Add an example on how to use the create command. I believe this will make qemu-img easier to use. Signed-off-by: John Arbuckle --- qemu-img-cmds.hx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-img-cmds.hx b/qemu-img-cm

[Qemu-devel] [PATCH v3 2/2] s390x: Enable KVM huge page backing support

2018-07-31 Thread Janosch Frank
QEMU has had huge page support for a longer time already, but KVM memory management under s390x needed some changes to work with huge backings. Now that we have support, let's enable it if requested and available. Otherwise we now properly tell the user if there is no support and back out instead

[Qemu-devel] [PATCH v3 1/2] kvm: sync linux headers

2018-07-31 Thread Janosch Frank
Import KVM_CAP_S390_HPAGE_1M Placeholder for proper sync. Signed-off-by: Janosch Frank --- linux-headers/linux/kvm.h | 1 + 1 file changed, 1 insertion(+) diff --git a/linux-headers/linux/kvm.h b/linux-headers/linux/kvm.h index 98f389a5a3..2aae948219 100644 --- a/linux-headers/linux/kvm.h +++ b

[Qemu-devel] [PATCH v3 0/2] s390x: Enable KVM huge page backing support

2018-07-31 Thread Janosch Frank
v3: * Fixed Cap name * Added mempath page size check and error reporting Janosch Frank (2): kvm: sync linux headers s390x: Enable KVM huge page backing support linux-headers/linux/kvm.h | 1 + target/s390x/kvm.c| 15 +++ 2 files changed, 16 insertions(+)

Re: [Qemu-devel] Any tutorial to read/write in qcow2 format by programming way?

2018-07-31 Thread Eric Blake
On 07/31/2018 04:44 AM, lampahome wrote: As titled I learn some info about qcow2 and tried to write some data and make it qualified for qcow2 format. I do it and mount through qemu-nbd successfully. But I don't know how taking snapshot and backing file works in programming way. Can someone te

Re: [Qemu-devel] [PATCH 2/3] migration: Add qmp command for migrate_set_max_cpu_throttle

2018-07-31 Thread Eric Blake
On 07/31/2018 06:29 AM, Dr. David Alan Gilbert wrote: * Li Qiang (liq...@gmail.com) wrote: The default max cpu throttle is 99, this is too big that may influence the guest loads. Add a qmp to config it can make it more flexible. Signed-off-by: Li Qiang This should be done as a migration para

Re: [Qemu-devel] [PATCH v2 0/4] Balloon inhibit enhancements, vfio restriction

2018-07-31 Thread Michael S. Tsirkin
On Mon, Jul 30, 2018 at 05:13:26PM -0600, Alex Williamson wrote: > v2: > - Use atomic ops for balloon inhibit counter (Peter) > - Allow endpoint driver opt-in for ballooning, vfio-ccw opt-in by >default, vfio-pci opt-in by device option, only allowed for mdev >devices, no support added fo

Re: [Qemu-devel] [PATCH] qemu-img-cmds.hx: Add example usage for create command

2018-07-31 Thread Kevin Wolf
Am 31.07.2018 um 13:57 hat Eric Blake geschrieben: > On 07/30/2018 09:52 PM, John Arbuckle wrote: > > Add an example on how to use the create command. I believe this will make > > qemu-img easier to use. > > > > Signed-off-by: John Arbuckle > > --- > > qemu-img-cmds.hx | 2 +- > > 1 file chan

Re: [Qemu-devel] [PULL 0/4] Misc patches for 2018-07-30

2018-07-31 Thread Peter Maydell
On 31 July 2018 at 09:02, Paolo Bonzini wrote: > The following changes since commit 6d9dd5fb9d0e9f4a174f53a0e20a39fbe809c71e: > > Merge remote-tracking branch > 'remotes/armbru/tags/pull-qobject-2018-07-27-v2' into staging (2018-07-30 > 09:55:47 +0100) > > are available in the git repository a

Re: [Qemu-devel] [PULL 0/3] Linux user for 3.0 patches

2018-07-31 Thread Laurent Vivier
Le 31/07/2018 à 14:24, no-re...@patchew.org a écrit : > Hi, > > This series seems to have some coding style problems. See output below for > more information: > > Type: series > Message-id: 20180731084203.29959-1-laur...@vivier.eu > Subject: [Qemu-devel] [PULL 0/3] Linux user for 3.0 patches > >

Re: [Qemu-devel] [PULL 0/3] Linux user for 3.0 patches

2018-07-31 Thread Laurent Vivier
Le 31/07/2018 à 14:40, Laurent Vivier a écrit : > Le 31/07/2018 à 14:24, no-re...@patchew.org a écrit : >> Hi, >> >> This series seems to have some coding style problems. See output below for >> more information: >> >> Type: series >> Message-id: 20180731084203.29959-1-laur...@vivier.eu >> Subject:

Re: [Qemu-devel] [PATCH] monitor: accept input on resume

2018-07-31 Thread Marc-André Lureau
Hi On Tue, Jul 31, 2018 at 1:30 PM, Markus Armbruster wrote: > Marc-André Lureau writes: > >> A chardev may stop trying to write if the associated can_read() >> callback returned 0. This happens when the monitor is suspended. >> The frontend is supposed to call qemu_chr_fe_accept_input() when it

Re: [Qemu-devel] [PATCH v3 2/2] s390x: Enable KVM huge page backing support

2018-07-31 Thread Cornelia Huck
On Tue, 31 Jul 2018 13:09:08 +0100 Janosch Frank wrote: > QEMU has had huge page support for a longer time already, but KVM > memory management under s390x needed some changes to work with huge > backings. > > Now that we have support, let's enable it if requested and > available. Otherwise we n

Re: [Qemu-devel] [PULL 0/3] Linux user for 3.0 patches

2018-07-31 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180731084203.29959-1-laur...@vivier.eu Subject: [Qemu-devel] [PULL 0/3] Linux user for 3.0 patches === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --on

Re: [Qemu-devel] [PATCH] qemu-img-cmds.hx: Add example usage for create command

2018-07-31 Thread Programmingkid
> On Jul 31, 2018, at 8:35 AM, Kevin Wolf wrote: > > Am 31.07.2018 um 13:57 hat Eric Blake geschrieben: >> On 07/30/2018 09:52 PM, John Arbuckle wrote: >>> Add an example on how to use the create command. I believe this will make >>> qemu-img easier to use. >>> >>> Signed-off-by: John Arbuckl

Re: [Qemu-devel] [PATCH] qemu-img-cmds.hx: Add example usage for create command

2018-07-31 Thread Programmingkid
> On Jul 31, 2018, at 7:57 AM, Eric Blake wrote: > > On 07/30/2018 09:52 PM, John Arbuckle wrote: >> Add an example on how to use the create command. I believe this will make >> qemu-img easier to use. >> Signed-off-by: John Arbuckle >> --- >> qemu-img-cmds.hx | 2 +- >> 1 file changed, 1 in

Re: [Qemu-devel] [PATCH v3 2/2] s390x: Enable KVM huge page backing support

2018-07-31 Thread Janosch Frank
On 31.07.2018 15:06, Cornelia Huck wrote: > On Tue, 31 Jul 2018 13:09:08 +0100 > Janosch Frank wrote: > >> QEMU has had huge page support for a longer time already, but KVM >> memory management under s390x needed some changes to work with huge >> backings. >> >> Now that we have support, let's en

Re: [Qemu-devel] [PATCH v5 24/76] target/mips: Add emulation of nanoMIPS 16-bit logic instructions

2018-07-31 Thread Richard Henderson
On 07/30/2018 12:11 PM, Aleksandar Markovic wrote: > From: Yongbok Kim > > Add emulation of NOT16, AND16, XOR16, OR16 instructions. > > Reviewed-by: Richard Henderson > Signed-off-by: Yongbok Kim > Signed-off-by: Aleksandar Markovic > Signed-off-by: Stefan Markovic > --- > target/mips/trans

Re: [Qemu-devel] [PULL 0/3] Linux user for 3.0 patches

2018-07-31 Thread Alex Bennée
Laurent Vivier writes: > Le 31/07/2018 à 14:24, no-re...@patchew.org a écrit: >> Hi, >> >> This series seems to have some coding style problems. See output below for >> more information: >> >> Type: series >> Message-id: 20180731084203.29959-1-laur...@vivier.eu >> Subject: [Qemu-devel] [PULL 0/

Re: [Qemu-devel] [PATCH v5 25/76] target/mips: Add emulation of nanoMIPS 16-bit save and restore instructions

2018-07-31 Thread Richard Henderson
On 07/30/2018 12:11 PM, Aleksandar Markovic wrote: > +static void gen_adjust_sp(DisasContext *ctx, int u) > +{ > +TCGv tsp = tcg_temp_new(); > +gen_base_offset_addr(ctx, tsp, 29, u); > +gen_store_gpr(tsp, 29); > +tcg_temp_free(tsp); > +} This could now be just gen_op_addr_addi(c

Re: [Qemu-devel] [PATCH] Add interactive mode to qemu-img command

2018-07-31 Thread no-reply
Hi, This series failed docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. Type: series Message-id: 20180730192955.14291-1-programmingk...@gmail.com Subject: [Qemu-devel] [PATCH] Add interac

Re: [Qemu-devel] [PATCH] throttle-groups: fix hang when group member leaves

2018-07-31 Thread Alberto Garcia
On Wed 04 Jul 2018 04:54:10 PM CEST, Stefan Hajnoczi wrote: > Throttle groups consist of members sharing one throttling state > (including bps/iops limits). Round-robin scheduling is used to ensure > fairness. If a group member already has a timer pending then other > groups members do not schedu

Re: [Qemu-devel] [PATCH v5 26/76] target/mips: Add emulation of some common nanoMIPS 32-bit instructions

2018-07-31 Thread Richard Henderson
On 07/30/2018 12:11 PM, Aleksandar Markovic wrote: > +case NM_ADDIUPC: > +if (rt != 0) { > +int32_t offset = sextract32(ctx->opcode, 0, 1) << 21 | > + extract32(ctx->opcode, 1, 20) << 1; > +target_long addr = addr_add(ctx, ctx->base.pc

[Qemu-devel] ARM: SVE while issue

2018-07-31 Thread Laurent Desnogues
Hello Richard, according to SVE specification, whilels/whilele instructions have a special case where if the second operand is the maximum (un)signed integer then the result is an all-true predicate. The current code in trans_WHILE doesn't seem to capture that requirement. I'm afraid the fix won

Re: [Qemu-devel] [PATCH v5 27/76] target/mips: Add emulation of nanoMIPS instructions MOVE.P and MOVE.PREV

2018-07-31 Thread Richard Henderson
On 07/30/2018 12:12 PM, Aleksandar Markovic wrote: > From: Yongbok Kim > > Add emulation of nanoMIPS instructions MOVE.P and MOVE.PREV. > > Signed-off-by: Yongbok Kim > Signed-off-by: Aleksandar Markovic > Signed-off-by: Stefan Markovic > --- > target/mips/translate.c | 33 ++

Re: [Qemu-devel] [PATCH v5 28/76] target/mips: Add emulation of nanoMIPS 48-bit instructions

2018-07-31 Thread Richard Henderson
On 07/30/2018 12:12 PM, Aleksandar Markovic wrote: > case NM_P48I: > -return 6; > +{ > +insn = cpu_lduw_code(env, ctx->base.pc_next + 4); > +uint32_t offset = extract32(ctx->opcode, 0, 16) | insn << 16; This value is supposed to be signed. r~

Re: [Qemu-devel] [PULL 0/3] Linux user for 3.0 patches

2018-07-31 Thread Peter Maydell
On 31 July 2018 at 09:42, Laurent Vivier wrote: > The following changes since commit 6d9dd5fb9d0e9f4a174f53a0e20a39fbe809c71e: > > Merge remote-tracking branch > 'remotes/armbru/tags/pull-qobject-2018-07-27-v2' into staging (2018-07-30 > 09:55:47 +0100) > > are available in the Git repository

Re: [Qemu-devel] [PATCH v5 30/76] target/mips: Add emulation of misc nanoMIPS instructions (pool32a0)

2018-07-31 Thread Richard Henderson
On 07/30/2018 12:12 PM, Aleksandar Markovic wrote: > +case NM_SOV: > +{ > +TCGv t0 = tcg_temp_local_new(); tcg_temp_new. Otherwise, Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/2] ppc: Allow clients of the 440 pcix bus to specify the number of interrupts

2018-07-31 Thread Cédric Le Goater
On 07/31/2018 06:36 AM, Sebastian Bauer wrote: > This can be done by using the newly introduced num_irqs property. In > particular, this change introduces a special case if num_irqs is 1 in which > case any interrupt pin will be connected to the single irq. The default > case is untouched (but note

Re: [Qemu-devel] [PATCH v9 1/3] migration: Create socket-address parameter

2018-07-31 Thread Juan Quintela
Eric Blake wrote: >> +++ b/qapi/migration.json >> @@ -6,6 +6,7 @@ >> ## >> { 'include': 'common.json' } >> +{ 'include': 'sockets.json' } >> ## >> # @MigrationStats: >> @@ -169,6 +170,7 @@ >> # only present when the postcopy-blocktime migration capability >> #

Re: [Qemu-devel] [PATCH v2] bitmap: fix BITMAP_LAST_WORD_MASK

2018-07-31 Thread Juan Quintela
Wei Wang wrote: > When "nbits = 0", which means no bits to mask, this macro is expected to > return 0, instead of 0x. This patch changes the macro to return > 0 when there is no bit needs to be masked. > > Signed-off-by: Wei Wang > CC: Juan Quintela > CC: Dr. David Alan Gilbert > CC: Pe

Re: [Qemu-devel] [PATCH v2 0/4] Balloon inhibit enhancements, vfio restriction

2018-07-31 Thread Alex Williamson
On Tue, 31 Jul 2018 15:29:17 +0300 "Michael S. Tsirkin" wrote: > On Mon, Jul 30, 2018 at 05:13:26PM -0600, Alex Williamson wrote: > > v2: > > - Use atomic ops for balloon inhibit counter (Peter) > > - Allow endpoint driver opt-in for ballooning, vfio-ccw opt-in by > >default, vfio-pci opt-i

Re: [Qemu-devel] [PATCH RFC] monitor: temporary fix for dead-lock on event recursion

2018-07-31 Thread Marc-André Lureau
Hi On Tue, Jul 31, 2018 at 9:05 AM, Markus Armbruster wrote: > Marc-André Lureau writes: > >> With a Spice port chardev, it is possible to reenter >> monitor_qapi_event_queue() (when the client disconnects for >> example). This will dead-lock on monitor_lock. >> >> Instead, use some TLS variable

Re: [Qemu-devel] [PATCH 2/3] migration: Add qmp command for migrate_set_max_cpu_throttle

2018-07-31 Thread Juan Quintela
"Dr. David Alan Gilbert" wrote: > * Li Qiang (liq...@gmail.com) wrote: >> The default max cpu throttle is 99, this is too big that may >> influence the guest loads. Add a qmp to config it can make it >> more flexible. >> >> Signed-off-by: Li Qiang > > This should be done as a migration parameter

[Qemu-devel] [PATCH v2] monitor: temporary fix for dead-lock on event recursion

2018-07-31 Thread Marc-André Lureau
With a Spice port chardev, it is possible to reenter monitor_qapi_event_queue() (when the client disconnects for example). This will dead-lock on monitor_lock. Instead, use some TLS variables to check for recursion and queue the events. Fixes: (gdb) bt #0 0x7fa69e7217fd in __lll_lock_wait

Re: [Qemu-devel] [PATCH for-3.0 v2] pc: acpi: fix memory hotplug regression by reducing stub SRAT entry size

2018-07-31 Thread Eduardo Habkost
On Tue, Jul 31, 2018 at 11:53:40AM +0200, Igor Mammedov wrote: > On Mon, 30 Jul 2018 17:26:24 -0300 > Eduardo Habkost wrote: > > > On Mon, Jul 30, 2018 at 11:41:41AM +0200, Igor Mammedov wrote: > > > Commit 848a1cc1e (hw/acpi-build: build SRAT memory affinity structures > > > for DIMM devices) >

Re: [Qemu-devel] [PATCH v2 0/4] Balloon inhibit enhancements, vfio restriction

2018-07-31 Thread Dr. David Alan Gilbert
* Alex Williamson (alex.william...@redhat.com) wrote: > On Tue, 31 Jul 2018 15:29:17 +0300 > "Michael S. Tsirkin" wrote: > > > On Mon, Jul 30, 2018 at 05:13:26PM -0600, Alex Williamson wrote: > > > v2: > > > - Use atomic ops for balloon inhibit counter (Peter) > > > - Allow endpoint driver opt-

Re: [Qemu-devel] [PATCH RFC] monitor: temporary fix for dead-lock on event recursion

2018-07-31 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > On Tue, Jul 31, 2018 at 9:05 AM, Markus Armbruster wrote: >> Marc-André Lureau writes: >> >>> With a Spice port chardev, it is possible to reenter >>> monitor_qapi_event_queue() (when the client disconnects for >>> example). This will dead-lock on monitor_lock

Re: [Qemu-devel] [PATCH v2] monitor: temporary fix for dead-lock on event recursion

2018-07-31 Thread Markus Armbruster
Marc-André Lureau writes: > With a Spice port chardev, it is possible to reenter > monitor_qapi_event_queue() (when the client disconnects for > example). This will dead-lock on monitor_lock. > > Instead, use some TLS variables to check for recursion and queue the > events. > > Fixes: > (gdb) bt

  1   2   >