On 07/23/2018 05:01 PM, Peter Xu wrote:
Yes, it's sufficient for current thread model, will drop it for now
and add it at the time when the lockless mutilthread model is applied. :)
Ah I think I see your point. Even if so I would think it better to do
any extra cleanup directly in compress
On 07/23/2018 05:15 PM, Peter Xu wrote:
On Mon, Jul 23, 2018 at 04:40:29PM +0800, Xiao Guangrong wrote:
On 07/23/2018 04:05 PM, Peter Xu wrote:
On Mon, Jul 23, 2018 at 03:39:18PM +0800, Xiao Guangrong wrote:
On 07/23/2018 12:36 PM, Peter Xu wrote:
On Thu, Jul 19, 2018 at 08:15:15PM +08
On 07/23/2018 05:40 PM, Peter Xu wrote:
On Mon, Jul 23, 2018 at 04:44:49PM +0800, Xiao Guangrong wrote:
[...]
However, it is not safe to do ram_release_pages in the thread as it's
not protected it multithreads. Fortunately, compression will be disabled
if it switches to post-copy, so i pre
On 07/24/2018 02:36 AM, Eric Blake wrote:
On 07/19/2018 07:15 AM, guangrong.x...@gmail.com wrote:
From: Xiao Guangrong
Instead of putting the main thread to sleep state to wait for
free compression thread, we can directly post it out as normal
page that reduces the latency and uses CPUs mor
Looking through old bug tickets... can you still reproduce this issue
with the latest version of QEMU? Or could we close this ticket nowadays?
** Changed in: qemu
Status: New => Incomplete
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribe
Looking through old bug tickets... can you still reproduce this issue
with the latest version of QEMU (currently v2.12)? Or could we close
this ticket nowadays?
** Changed in: qemu
Status: New => Incomplete
--
You received this bug notification because you are a member of qemu-
devel-ml,
Looking through old bug tickets... can you still reproduce this issue
with the latest version of QEMU? Or could we close this ticket nowadays?
** Changed in: qemu
Status: New => Incomplete
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribe
On Wed, Jul 18, 2018 at 4:03 AM Alex Bennée wrote:
>
> When a check fails we currently just report why we failed. This is not
> totally helpful to people who want to boot-strap a new image. Add a
> --hint option which we can pass down to give a bit more information.
>
> Signed-off-by: Alex Bennée
On Wed, Jul 18, 2018 at 4:02 AM Alex Bennée wrote:
>
> Setting up binfmt_misc is outside of the scope of the docker.py script
> but we can at least validate it with any given executable so we have a
> more useful error message than the sed line of deboostrap failing
> cryptically.
>
> Signed-off-b
On Mon, Jul 23, 2018 at 6:03 PM Alex Bennée wrote:
>
>
> Alex Bennée writes:
>
> > Hi,
> >
> > I've missed the boat for today's rc1 but I'd like to get this merged
> > before rc2. The new docker.py change is technically new functionality
> > but I'm counting it as a usability bug fix as it replac
Currently, every virtio-ccw device explicitely sets its unrealize
function to virtio_ccw_unrealize() in its class_init function.
We can simplify this by using a common unrealize function, just like
it is already done for the realize functions.
Signed-off-by: Thomas Huth
---
hw/s390x/virtio-ccw.c
Markus Armbruster writes:
> "liujunjie (A)" writes:
>
>> The stack backtrace is as follows:
>> (gdb) bt
>> #0 0x7f1dc3c7b091 in _g_log_abort () from /usr/lib64/libglib-2.0.so.0
>> #1 0x7f1dc3c7c0bd in g_log_default_handler () from
>> /usr/lib64/libglib-2.0.so.0
>> #2 0x7f1dc3c7c3
Something has locked /dev/null on my system (I still don't know what to do with
the annoying incapability of lslocks, or more precisely /proc/locks, on
inspecting OFD lock information), and as a result 226 cannot pass due to the
unexpected image locking error.
Fix the test case by disabling lockin
On my system (Fedora 28), this script reports a 'failed to get
"consistent read" lock' error. Following docs/devel/testing.rst, it's
better to add locking=off here.
Signed-off-by: Fam Zheng
---
tests/qemu-iotests/226 | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/q
Signed-off-by: Fam Zheng
---
docs/devel/testing.rst | 11 +++
1 file changed, 11 insertions(+)
diff --git a/docs/devel/testing.rst b/docs/devel/testing.rst
index 5e19cd50da..8e1fa3a66e 100644
--- a/docs/devel/testing.rst
+++ b/docs/devel/testing.rst
@@ -255,6 +255,17 @@ comparable librar
Fam Zheng writes:
> On Wed, Jul 18, 2018 at 4:03 AM Alex Bennée wrote:
>>
>> When a check fails we currently just report why we failed. This is not
>> totally helpful to people who want to boot-strap a new image. Add a
>> --hint option which we can pass down to give a bit more information.
>>
Fam Zheng writes:
> On Wed, Jul 18, 2018 at 4:02 AM Alex Bennée wrote:
>>
>> Setting up binfmt_misc is outside of the scope of the docker.py script
>> but we can at least validate it with any given executable so we have a
>> more useful error message than the sed line of deboostrap failing
>>
Fam Zheng writes:
> On Mon, Jul 23, 2018 at 6:03 PM Alex Bennée wrote:
>>
>>
>> Alex Bennée writes:
>>
>> > Hi,
>> >
>> > I've missed the boat for today's rc1 but I'd like to get this merged
>> > before rc2. The new docker.py change is technically new functionality
>> > but I'm counting it as
On Tue, Jul 24, 2018 at 4:56 PM Alex Bennée wrote:
>
>
> Fam Zheng writes:
>
> > On Mon, Jul 23, 2018 at 6:03 PM Alex Bennée wrote:
> >>
> >>
> >> Alex Bennée writes:
> >>
> >> > Hi,
> >> >
> >> > I've missed the boat for today's rc1 but I'd like to get this merged
> >> > before rc2. The new do
Even using gdb command: set print elements 0, is still too large to print the
whole string.
So I try to obtain the string in another way.
After several attempts(not easy in fact), I finally obtain the real length. The
way is as follows:
(gdb) p (int *)str
$1 = (int *) 0x7f13a2e67010
(gdb) p *(cha
Peter Xu wrote:
> We shouldn't update the received bitmap if we're the source VM. This
> fixes a breakage when release-ram is enabled on postcopy.
>
> Signed-off-by: Peter Xu
> ---
> migration/ram.c | 11 +--
> 1 file changed, 9 insertions(+), 2 deletions(-)
Reviewed-by: Juan Quintela
Peter Xu wrote:
> Postcopy recovery won't work well with release-ram capability since
> release-ram will drop the page buffer as long as the page is put into
> the send buffer. So if there is a network failure happened, any page
> buffers that have not yet reached the destination VM but have alre
Peter Xu wrote:
> The only possible change of last_byte is when it reaches the edge.
> Setting it every time might let last_byte contain an invalid data when
> memory corruption is detected, then the check of the next byte will be
> incorrect. For example, a single page corruption at address 0x14
This option has been deprecated for two releases; remove it.
Signed-off-by: Cornelia Huck
---
hw/s390x/3270-ccw.c| 2 +-
hw/s390x/css-bridge.c | 1 -
hw/s390x/css.c | 6 ++
hw/s390x/s390-ccw.c| 2 +-
hw/s390x/s390-virtio-cc
Peter Xu wrote:
> The release-ram capability will run some extra code for postcopy to
> release used ram right away, let's just turn that on for the postcopy
> unix test always to torture that code path too to make sure release-ram
> feature won't break again. The recovery test needs to turn that
On Mon, 23 Jul 2018 17:14:54 -0500
Michael Roth wrote:
> Quoting Michael Roth (2018-07-23 15:16:14)
> > From: Cornelia Huck
> >
> > We currently pass an integer as the subcode parameter. However,
> > the upper bits of the register containing the subcode need to
> > be 0, which is not guaranteed
On 17 July 2018 at 20:55, Alex Bennée wrote:
> The combination of being rather esoteric and needing to support mmap @
> 0 means this only ever worked under translation. It has now regressed
> even further and is no longer useful. Kill it.
>
> Signed-off-by: Alex Bennée
> ---
Reviewed-by: Peter Ma
On Tue, Jul 24, 2018 at 2:41 AM, Eric Blake wrote:
> On 07/22/2018 02:33 PM, Zhang Chen wrote:
>
>> From: zhanghailiang
>>
>> If some errors happen during VM's COLO FT stage, it's important to
>> notify the users of this event. Together with 'x-colo-lost-heartbeat',
>> Users can intervene in COL
On 23.07.2018 16:33, Kevin Wolf wrote:
> Am 18.07.2018 um 17:28 hat Thomas Huth geschrieben:
>> When using the vvfat driver with a directory that contains too many files,
>> QEMU currently crashes. We are trying to print the wrong path variable here.
>>
>> Signed-off-by: Thomas Huth
>> ---
>> blo
From: "Dr. David Alan Gilbert"
Fix outgoing migration which was crashing in
vmstate_hda_audio_stream_buf_needed, I think the problem
is that we have room for upto 4 streams in the array but only
use 2, when we come to try and save the state of the unused
streams we hit st->state == NULL.
Fixes:
On Tue, Jul 24, 2018 at 11:22:15AM +0100, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert"
>
> Fix outgoing migration which was crashing in
> vmstate_hda_audio_stream_buf_needed, I think the problem
> is that we have room for upto 4 streams in the array but only
> use 2, when
On 23 July 2018 at 20:45, Eduardo Habkost wrote:
> The following changes since commit 9ba7dd14355bb7957680d5ef764471ab102df099:
>
> Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2018-07-23'
> into staging (2018-07-23 15:15:46 +0100)
>
> are available in the Git repository at:
>
>
> From: Stefan Markovic
> Sent: Thursday, July 19, 2018 2:54 PM
> Subject: [PATCH v3 24/40] target/mips: Add updating BadInstr and BadInstrP
> registers for nanoMIPS
>
> From: Yongbok Kim
>
> Updating BadInstr and BadInstrP registers was addded for nanoMIPS.
> BadInstr and BadInstrP support for
Am 24.07.2018 um 11:56 hat Thomas Huth geschrieben:
> On 23.07.2018 16:33, Kevin Wolf wrote:
> > Am 18.07.2018 um 17:28 hat Thomas Huth geschrieben:
> >> When using the vvfat driver with a directory that contains too many files,
> >> QEMU currently crashes. We are trying to print the wrong path var
This image isn't going to build anything significant as it is just
intended for building test cases. In case it does end up getting
inadvertently included in a build lets aim for the minimal possible
product.
Signed-off-by: Alex Bennée
Reviewed-by: Philippe Mathieu-Daudé
diff --git a/tests/dock
Not all docker images can run the check step. Let's move everything
into a common helper so we don't need to replicate checks in the
future.
Signed-off-by: Alex Bennée
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Philippe Mathieu-Daudé
diff --git a/tests/docker/common.rc b/tests/docker/commo
This allows some tests that just want to configure QEMU's source tree
to do so.
Signed-off-by: Alex Bennée
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Philippe Mathieu-Daudé
diff --git a/tests/docker/common.rc b/tests/docker/common.rc
index 046f8a5921..ba1f942328 100755
--- a/tests/docker/c
The .gitignore was being a little over enthusiastic hiding files.
Signed-off-by: Alex Bennée
Reviewed-by: Philippe Mathieu-Daudé
diff --git a/tests/.gitignore b/tests/.gitignore
index 08e2df1ce1..72c18aaab0 100644
--- a/tests/.gitignore
+++ b/tests/.gitignore
@@ -9,6 +9,7 @@ qht-bench
rcutortu
Rename DOCKER_INTERMEDIATE_IMAGES to DOCKER_PARTIAL_IMAGES and add the
incomplete cross compiler images that can build tests but can't build
QEMU itself. We also add debian, debian-bootstrap and the tricode
images to the list.
Signed-off-by: Alex Bennée
Reviewed-by: Philippe Mathieu-Daudé
Tested
The following changes since commit 768cef2974fb1fa30dd188b043ea737e13fea477:
Merge remote-tracking branch 'remotes/ehabkost/tags/x86-next-pull-request'
into staging (2018-07-24 10:37:52 +0100)
are available in the Git repository at:
https://github.com/stsquad/qemu.git tags/pull-docker-fixes
We need both git and a working compiler to build the tools. Although
the qemu:debian9 image also has a bunch of extra dependencies it would
be fairly unusual for a user not to already have this layer available
for one of our many other docker images so lets not complicate things.
Signed-off-by: Al
The addition of QEMU_TARGET was intended to ensure we fall back to
checking for the existence of an image if the build system was not
currently configured to build it. However this breaks the direct use
of the rule for building custom binfmt_misc images. We already check
for EXECUTABLE so let us ju
When a check fails we currently just report why we failed. This is not
totally helpful to people who want to boot-strap a new image. Report a
hint as to why it failed.
Signed-off-by: Alex Bennée
Suggested-by: Fam Zheng
diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include
i
> From: Richard Henderson
> Sent: Thursday, July 19, 2018 6:39 PM
> On 07/19/2018 05:54 AM, Stefan Markovic wrote:
> > decode_opc(env, ctx);
> > } else if (ctx->insn_flags & ASE_MICROMIPS) {
> > -ctx->opcode = cpu_lduw_code(env, ctx->base.pc_next);
> > -insn_bytes = d
As this is called directly from the Makefile while determining
dependencies and it is possible the user was configured in one window
but not have credentials in the other. Let's catch the Exceptions and
deal with it quietly.
Signed-off-by: Alex Bennée
Reported-by: Peter Maydell
Reviewed-by: Phil
From: Philippe Mathieu-Daudé
This silents the following warning:
Cloning into './debootstrap.git'...
warning: redirecting to
https://salsa.debian.org/installer-team/debootstrap.git/
See https://lists.debian.org/debian-devel-announce/2018/01/msg4.html
Signed-off-by: Philippe Mathieu-Da
Not all our images are able to run the tests. Rather than use features
we can just check for the existence and run-ability of gtester. If the
image has been setup for binfmt_misc it will be able to run anyway.
Signed-off-by: Alex Bennée
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Philippe Mat
This test doesn't even build QEMU, it just builds and runs all the
unit tests. Intended to make checking unit tests on all docker images
easier.
Signed-off-by: Alex Bennée
Reviewed-by: Philippe Mathieu-Daudé
Tested-by: Philippe Mathieu-Daudé
diff --git a/tests/docker/test-unit b/tests/docker/t
The combination of being rather esoteric and needing to support mmap @
0 means this only ever worked under translation. It has now regressed
even further and is no longer useful. Kill it.
Signed-off-by: Alex Bennée
Reviewed-by: Peter Maydell
diff --git a/tests/tcg/i386/Makefile.target b/tests/t
This allows us to run a particular test on all docker images. For
example:
make docker-test-unit
Will run the unit tests on every supported image. At the same time
rename docker-test to docker-all-tests to be clearer.
Signed-off-by: Alex Bennée
Reviewed-by: Philippe Mathieu-Daudé
Tested-by:
We do a minimum version check for the debootstrap but if the distro
has added their own minor version tick it would fail and fall-back to
the SCM version. This is sub-optimal as the latest/greatest version
may be broken at any one particular time. We fix that with a little
sed magic on the version
> From: Richard Henderson
> Sent: Thursday, July 19, 2018 6:57 PM
>
> I think it's worth spending one line to document the pseudocode function from
> which each of these come. E.g.
>
> /* Implement nanoMIPS pseudocode decode_gpr(encoded_gpr, 'gpr4.zero'). */
>
> Which is certainly more accurate
Hello, I also am afraid thet in the image there is no sound driver,
maybe that's the problem.
And its so long ago that you can close it.
2018-07-24 9:27 GMT+02:00, Thomas Huth <1479...@bugs.launchpad.net>:
> Looking through old bug tickets... can you still reproduce this issue
> with the latest ve
This is just a note that later versions of debootstrap don't
technically need this hack.
Signed-off-by: Alex Bennée
Reviewed-by: Philippe Mathieu-Daudé
diff --git a/tests/docker/dockerfiles/debian-bootstrap.docker
b/tests/docker/dockerfiles/debian-bootstrap.docker
index 14212b9cf4..e13c26a7ed
Acked-by: Christian Borntraeger
On 07/24/2018 11:24 AM, Cornelia Huck wrote:
> This option has been deprecated for two releases; remove it.
>
> Signed-off-by: Cornelia Huck
> ---
> hw/s390x/3270-ccw.c| 2 +-
> hw/s390x/css-bridge.c | 1 -
> hw/s390x/css.c
since commit e8488edcb3768f08cda7c3cc00def6b1b2f6c615:
tcg/i386: Mark xmm registers call-clobbered (2018-07-23 14:24:17 -0500)
are available in the Git repository at:
git://github.com/cohuck/qemu tags/s390x-20180724-212-stable
for you to fetch changes up to c16427177a67bc86aa7560331
Setting up binfmt_misc is outside of the scope of the docker.py script
but we can at least validate it with any given executable so we have a
more useful error message than the sed line of deboostrap failing
cryptically.
Signed-off-by: Alex Bennée
Reported-by: Richard Henderson
diff --git a/tes
On Tue, Jul 24, 2018 at 11:24:13 +0200, Cornelia Huck wrote:
> This option has been deprecated for two releases; remove it.
>
> Signed-off-by: Cornelia Huck
> ---
> hw/s390x/3270-ccw.c| 2 +-
> hw/s390x/css-bridge.c | 1 -
> hw/s390x/css.c | 6
On Tue, 24 Jul 2018 13:15:50 +0200
Peter Krempa wrote:
> On Tue, Jul 24, 2018 at 11:24:13 +0200, Cornelia Huck wrote:
> > This option has been deprecated for two releases; remove it.
> >
> > Signed-off-by: Cornelia Huck
> > ---
> > hw/s390x/3270-ccw.c| 2 +-
> > hw/s390x/css-b
* Liran Alon (liran.a...@oracle.com) wrote:
> This MSR returns the number of #SMIs that occurred on
> CPU since boot.
>
> KVM commit 52797bf9a875 ("KVM: x86: Add emulation of MSR_SMI_COUNT")
> introduced support for emulating this MSR.
>
> This commit adds support for QEMU to save/load this
> MSR
On 23.07.2018 15:10, Cornelia Huck wrote:
> Signed-off-by: Cornelia Huck
> ---
> hw/s390x/s390-virtio-ccw.c | 17 -
> include/hw/compat.h| 3 +++
> 2 files changed, 19 insertions(+), 1 deletion(-)
>
> diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c
>
On Tue, Jul 24, 2018 at 11:25:24AM +0200, Juan Quintela wrote:
> Peter Xu wrote:
> > The release-ram capability will run some extra code for postcopy to
> > release used ram right away, let's just turn that on for the postcopy
> > unix test always to torture that code path too to make sure release
On 24.07.2018 12:49, Kevin Wolf wrote:
> Am 24.07.2018 um 11:56 hat Thomas Huth geschrieben:
>> On 23.07.2018 16:33, Kevin Wolf wrote:
>>> Am 18.07.2018 um 17:28 hat Thomas Huth geschrieben:
When using the vvfat driver with a directory that contains too many files,
QEMU currently crashes.
On Tue, Jul 24, 2018 at 11:21:47AM +0200, Juan Quintela wrote:
> Peter Xu wrote:
> > Postcopy recovery won't work well with release-ram capability since
> > release-ram will drop the page buffer as long as the page is put into
> > the send buffer. So if there is a network failure happened, any pa
On 3 July 2018 at 03:00, John Arbuckle wrote:
> When the user pushes Command-F in QEMU while the mouse is ungrabbed, QEMU
> goes into full screen mode. When the user finally releases the command key,
> it is sent to the guest as an event. The makes the guest operating system
> think the command ke
* Peter Xu (pet...@redhat.com) wrote:
> On Tue, Jul 24, 2018 at 11:25:24AM +0200, Juan Quintela wrote:
> > Peter Xu wrote:
> > > The release-ram capability will run some extra code for postcopy to
> > > release used ram right away, let's just turn that on for the postcopy
> > > unix test always to
On 24.07.2018 11:24, Cornelia Huck wrote:
> This option has been deprecated for two releases; remove it.
>
> Signed-off-by: Cornelia Huck
> ---
> hw/s390x/3270-ccw.c| 2 +-
> hw/s390x/css-bridge.c | 1 -
> hw/s390x/css.c | 6 ++
> hw/s390x/
When using the vvfat driver with a directory that contains too many files,
QEMU currently crashes. This can be triggered like this for example:
mkdir /tmp/vvfattest
cd /tmp/vvfattest
for ((x=0;x<=513;x++)); do mkdir $x; done
qemu-system-x86_64 -drive \
file.driver=vvfat,file.dir=.,read-only
On Tue, Jul 24, 2018 at 12:42:06PM +0100, Dr. David Alan Gilbert wrote:
> * Peter Xu (pet...@redhat.com) wrote:
> > On Tue, Jul 24, 2018 at 11:25:24AM +0200, Juan Quintela wrote:
> > > Peter Xu wrote:
> > > > The release-ram capability will run some extra code for postcopy to
> > > > release used
On Tue, Jul 24, 2018 at 01:55:01PM +0800, Peter Xu wrote:
> On Mon, Jul 23, 2018 at 04:13:18PM -0400, Jintack Lim wrote:
> > Hi,
> >
> > I'm running a Windows VM on top of KVM on x86, and one of virtio-net
> > device in the Windows VM doesn't seem to work. I provided virtual
> > IOMMU and two virt
In the Arm architecture the HCR_EL2.TGE bit allows software to
configure the CPU so that all exceptions that would target EL1
are instead delivered to EL2. This patchset adds support for
this to QEMU.
The required behaviour is described in the ARMv8 Arm ARM documentation
of the HCR_EL2.TGE bit (in
Some debug registers can be trapped via MDCR_EL2 bits TDRA, TDOSA,
and TDA, which we implement in the functions access_tdra(),
access_tdosa() and access_tda(). If MDCR_EL2.TDE or HCR_EL2.TGE
are 1, the TDRA, TDOSA and TDA bits should behave as if they were 1.
Implement this by having the access fun
One of the required effects of setting HCR_EL2.TGE is that when
SCR_EL3.NS is 1 then SCTLR_EL1.M must behave as if it is zero for
all purposes except direct reads. That is, it effectively disables
the MMU for the NS EL0/EL1 translation regime.
Signed-off-by: Peter Maydell
---
target/arm/helper.c
MSR_SMI_COUNT started being migrated in QEMU 2.12. Do not migrate it
on older machine types, or the subsection causes a load failure for
guests that use SMM.
Signed-off-by: Paolo Bonzini
---
include/hw/i386/pc.h | 4
target/i386/cpu.c | 2 ++
target/i386/cpu.h | 1 +
target/i386/m
If the "trap general exceptions" bit HCR_EL2.TGE is set, we
must mask all virtual interrupts (as per DDI0487C.a D1.14.3).
Implement this in arm_excp_unmasked().
Signed-off-by: Peter Maydell
---
target/arm/cpu.h | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/target/arm/
Whene we raise a synchronous exception, if HCR_EL2.TGE is set then
exceptions targeting NS EL1 must be redirected to EL2. Implement
this in raise_exception() -- all synchronous exceptions go through
this function.
(Asynchronous exceptions go via arm_cpu_exec_interrupt(), which
already honours HCR
On Mon, Jul 23, 2018 at 06:22:03PM -0400, John Snow wrote:
> This is an updated version of Vladimir's proposal for fixing the
> handling around migration and persistent dirty bitmaps.
>
> Patches 1, 4, 6, and 7 update the testing for this feature.
> Patch 2 touches up an error message.
> Patch 3 r
The IMO, FMO and AMO bits in HCR_EL2 are defined to "behave as
1 for all purposes other than direct reads" if HCR_EL2.TGE
is set and HCR_EL2.E2H is 0, and to "behave as 0 for all
purposes other than direct reads" if HCR_EL2.TGE is set
and HRC_EL2.E2H is 1.
To avoid having to check E2H and TGE ever
This is trivial, so just do it.
Signed-off-by: Paolo Bonzini
---
target/i386/misc_helper.c | 3 +++
target/i386/smm_helper.c | 1 +
2 files changed, 4 insertions(+)
diff --git a/target/i386/misc_helper.c b/target/i386/misc_helper.c
index 628f64aad5..78f2020ef2 100644
--- a/target/i386/misc_hel
"liujunjie (A)" writes:
> Even using gdb command: set print elements 0, is still too large to print the
> whole string.
> So I try to obtain the string in another way.
> After several attempts(not easy in fact), I finally obtain the real length.
> The way is as follows:
> (gdb) p (int *)str
> $
Hi Yuval,
On 07/16/2018 10:40 AM, Yuval Shaia wrote:
There are certain operations that are well considered as part of device
configuration while others are needed only when "start" command is
triggered by the guest driver. An example of device initialization step
is msix_init and example of "dev
On 07/16/2018 10:40 AM, Yuval Shaia wrote:
- Add line counter to ease navigation in log
- Print rdma instead of pvrdma
Signed-off-by: Yuval Shaia
---
hw/rdma/rdma_utils.c | 4
hw/rdma/rdma_utils.h | 16
hw/rdma/vmw/pvrdma_main.c | 2 ++
3 files changed,
After solving a corner case in bcdsub, this patch simplifies the logic
of both bcdadd/sub instructions by removing some unnecessary local flags.
Signed-off-by: Yasmin Beatriz
---
target/ppc/int_helper.c | 33 +
1 file changed, 9 insertions(+), 24 deletions(-)
dif
migrate_fd_connect duplicate initialize expected_downtime and cleanup_bh.
Signed-off-by: Lidong Chen
---
migration/migration.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/migration/migration.c b/migration/migration.c
index ff05422..b8c4fec 100644
--- a/migration/migration.c
+++ b/migrat
When cancelling migration, the state is MIGRATION_STATUS_CANCELLING.
The state change to MIGRATION_STATUS_CANCELLED when cleanup_bh is scheduled.
So when migration_iteration_finish is invoked, the state should be
MIGRATION_STATUS_CANCELLING.
Signed-off-by: Lidong Chen
---
migration/migration.c |
Hello,
>From the discussion on the XICS MSI object, I gather that exporting
icp_irq is fine.
Some more comments below, I have tried to answer the parts that were
not addressed yet.
[ ... ]
>> +/*
>> + * The CONFIG_DATA register expects little endian accesses, but as the
>> + * region is big
Hi Yuval,
On 07/16/2018 10:40 AM, Yuval Shaia wrote:
There is no use in the memory allocated for non-dma MR (one with
host_virt equals to NULL).
No need for the (one with...)
Delete the code that allocates it.
Signed-off-by: Yuval Shaia
---
hw/rdma/rdma_rm.c | 52 +++---
I'd like to request this commit for QEMU 2.12.1 stable backport:
commit e58d64a16abc "ccid-card-passthru: fix regression in realize()"
The patch fixes a VM start failure which I experience on 2.12.0.
Patch inlined below
Thanks,
Jason
>From e58d64a16abc2304c4dcb644411eb9580bf63b1e Mon Sep 17 00:
On 07/16/2018 10:40 AM, Yuval Shaia wrote:
RDMA applications can provide non-aligned buffers to be registered. In
such case the DMA address passed by driver is pointing to the beginning
of the physical address of the mapped page so we can't distinguish
between two addresses from the same page.
On 10 July 2018 at 17:00, Peter Maydell wrote:
> This series adds support to TCG for executing from MMIO regions
> and small MMU regions. The basic principle is that if get_page_addr_code()
> finds that the region is not backed by a full page of RAM then it
> returns -1, and tb_gen_code() then gen
On 15 July 2018 at 01:37, Richard Henderson wrote:
> On 07/13/2018 10:09 AM, Peter Maydell wrote:
>> @@ -939,29 +935,21 @@ tb_page_addr_t get_page_addr_code(CPUArchState *env,
>> target_ulong addr)
>> }
>> assert(tlb_hit(env->tlb_table[mmu_idx][index].addr_code, addr));
>>
On Mon, 23 Jul 2018 16:31:44 -0300
Eduardo Habkost wrote:
> acpi_send_event() requires an object that implements
> TYPE_ACPI_DEVICE_IF. Indicate that in the function prototype.
>
> Signed-off-by: Eduardo Habkost
It's not like acpi_send_event would ever need access to more
than AcpiDeviceIf, so
On Mon, 23 Jul 2018 16:31:45 -0300
Eduardo Habkost wrote:
> The ACPI hotplug callbacks get a HotplugHandler object as
> argument. This has two problems:
>
> 1) The functions require a TYPE_ACPI_DEVICE_IF object, but the
>function prototype doesn't indicate that. It's possible to
>pass
On 24 July 2018 at 01:01, Michael Roth wrote:
> The following changes since commit 4eecc2e212bae7308d8582d99f665dfc253c9dda:
>
> Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20180723' into
> staging (2018-07-23 19:24:05 +0100)
>
> are available in the Git repository at:
>
> git://g
** Changed in: qemu
Status: Incomplete => Won't Fix
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1479632
Title:
dos crashing no sound
Status in QEMU:
Won't Fix
Bug description:
I use
On Tue, Jul 24, 2018 at 02:29:49PM +0200, Igor Mammedov wrote:
> On Mon, 23 Jul 2018 16:31:45 -0300
> Eduardo Habkost wrote:
>
> > The ACPI hotplug callbacks get a HotplugHandler object as
> > argument. This has two problems:
> >
> > 1) The functions require a TYPE_ACPI_DEVICE_IF object, but th
On Tue, Jul 24, 2018 at 08:16:24PM +0800, Lidong Chen wrote:
> When cancelling migration, the state is MIGRATION_STATUS_CANCELLING.
> The state change to MIGRATION_STATUS_CANCELLED when cleanup_bh is scheduled.
> So when migration_iteration_finish is invoked, the state should be
> MIGRATION_STATUS_
On Tue, Jul 24, 2018 at 08:16:25PM +0800, Lidong Chen wrote:
> migrate_fd_connect duplicate initialize expected_downtime and cleanup_bh.
>
> Signed-off-by: Lidong Chen
This seems correct to me.
Reviewed-by: Peter Xu
> ---
> migration/migration.c | 2 --
> 1 file changed, 2 deletions(-)
>
>
On Tue, 24 Jul 2018 10:43:59 +0200
Thomas Huth wrote:
> Currently, every virtio-ccw device explicitely sets its unrealize
> function to virtio_ccw_unrealize() in its class_init function.
> We can simplify this by using a common unrealize function, just like
> it is already done for the realize fu
Thanks for your polish. I will update the patch as soon as possible.
I have tested the patch in my environment. What I use before is : virsh
qemu-monitor-command --hmp "info tlb"
With this patch, when I query tlb, after some time, the console only print:
"error: No complete monitor response
1 - 100 of 294 matches
Mail list logo
