Re: [Qemu-devel] [PATCH 06/12] migration: do not detect zero page for compression

2018-07-23 Thread Xiao Guangrong
On 07/23/2018 12:05 AM, Michael S. Tsirkin wrote: On Wed, Jul 18, 2018 at 04:46:21PM +0800, Xiao Guangrong wrote: On 07/17/2018 02:58 AM, Dr. David Alan Gilbert wrote: * Xiao Guangrong (guangrong.x...@gmail.com) wrote: On 06/29/2018 05:42 PM, Dr. David Alan Gilbert wrote: * Xiao Guangr

Re: [Qemu-devel] [PATCH v2 1/8] migration: do not wait for free thread

2018-07-23 Thread Xiao Guangrong
On 07/23/2018 11:25 AM, Peter Xu wrote: On Thu, Jul 19, 2018 at 08:15:13PM +0800, guangrong.x...@gmail.com wrote: @@ -3113,6 +3132,8 @@ static Property migration_properties[] = { DEFINE_PROP_UINT8("x-compress-threads", MigrationState, parameters.compress_threads,

Re: [Qemu-devel] [PATCH v2 3/8] migration: show the statistics of compression

2018-07-23 Thread Xiao Guangrong
On 07/23/2018 12:36 PM, Peter Xu wrote: On Thu, Jul 19, 2018 at 08:15:15PM +0800, guangrong.x...@gmail.com wrote: @@ -1597,6 +1608,24 @@ static void migration_update_rates(RAMState *rs, int64_t end_time) rs->xbzrle_cache_miss_prev) / iter_count; rs->xbzrle_cache_miss_

Re: [Qemu-devel] [PATCH v2 6/8] migration: move handle of zero page to the thread

2018-07-23 Thread Xiao Guangrong
On 07/23/2018 01:03 PM, Peter Xu wrote: On Thu, Jul 19, 2018 at 08:15:18PM +0800, guangrong.x...@gmail.com wrote: [...] @@ -1950,12 +1971,16 @@ retry: set_compress_params(&comp_param[idx], block, offset); qemu_cond_signal(&comp_param[idx].cond); qem

Re: [Qemu-devel] [PATCH v2 8/8] migration: do not flush_compressed_data at the end of each iteration

2018-07-23 Thread Xiao Guangrong
On 07/23/2018 01:49 PM, Peter Xu wrote: On Thu, Jul 19, 2018 at 08:15:20PM +0800, guangrong.x...@gmail.com wrote: From: Xiao Guangrong flush_compressed_data() needs to wait all compression threads to finish their work, after that all threads are free until the migration feeds new request to

Re: [Qemu-devel] [PATCH v2 3/8] migration: show the statistics of compression

2018-07-23 Thread Peter Xu
On Mon, Jul 23, 2018 at 03:39:18PM +0800, Xiao Guangrong wrote: > > > On 07/23/2018 12:36 PM, Peter Xu wrote: > > On Thu, Jul 19, 2018 at 08:15:15PM +0800, guangrong.x...@gmail.com wrote: > > > @@ -1597,6 +1608,24 @@ static void migration_update_rates(RAMState *rs, > > > int64_t end_time) > > >

Re: [Qemu-devel] [PATCH v2 13/18] json-parser: set an error if parsing returned NULL

2018-07-23 Thread Markus Armbruster
Marc-André Lureau writes: > Let's make json_parser_parse_err() suck less, and simplify caller > error handling. Let's state what's wrong with it first, like this: json_parser_parse_err() returns null on empty input and on parse error. In the latter case, it sometimes, but not always sets an

Re: [Qemu-devel] [PATCH v2 6/8] migration: move handle of zero page to the thread

2018-07-23 Thread Peter Xu
On Mon, Jul 23, 2018 at 03:56:33PM +0800, Xiao Guangrong wrote: [...] > > > @@ -2249,15 +2308,8 @@ static int ram_save_target_page(RAMState *rs, > > > PageSearchStatus *pss, > > > return res; > > > } > > > -/* > > > - * When starting the process of a new block, the first

Re: [Qemu-devel] [PATCH v2 8/8] migration: do not flush_compressed_data at the end of each iteration

2018-07-23 Thread Peter Xu
On Mon, Jul 23, 2018 at 04:05:21PM +0800, Xiao Guangrong wrote: > > > On 07/23/2018 01:49 PM, Peter Xu wrote: > > On Thu, Jul 19, 2018 at 08:15:20PM +0800, guangrong.x...@gmail.com wrote: > > > From: Xiao Guangrong > > > > > > flush_compressed_data() needs to wait all compression threads to > >

Re: [Qemu-devel] [PATCH v2 3/8] migration: show the statistics of compression

2018-07-23 Thread Xiao Guangrong
On 07/23/2018 04:05 PM, Peter Xu wrote: On Mon, Jul 23, 2018 at 03:39:18PM +0800, Xiao Guangrong wrote: On 07/23/2018 12:36 PM, Peter Xu wrote: On Thu, Jul 19, 2018 at 08:15:15PM +0800, guangrong.x...@gmail.com wrote: @@ -1597,6 +1608,24 @@ static void migration_update_rates(RAMState *rs,

Re: [Qemu-devel] [PATCH v2 6/8] migration: move handle of zero page to the thread

2018-07-23 Thread Xiao Guangrong
On 07/23/2018 04:28 PM, Peter Xu wrote: On Mon, Jul 23, 2018 at 03:56:33PM +0800, Xiao Guangrong wrote: [...] @@ -2249,15 +2308,8 @@ static int ram_save_target_page(RAMState *rs, PageSearchStatus *pss, return res; } -/* - * When starting the process of a new block

Re: [Qemu-devel] [PATCH v2 8/8] migration: do not flush_compressed_data at the end of each iteration

2018-07-23 Thread Xiao Guangrong
On 07/23/2018 04:35 PM, Peter Xu wrote: On Mon, Jul 23, 2018 at 04:05:21PM +0800, Xiao Guangrong wrote: On 07/23/2018 01:49 PM, Peter Xu wrote: On Thu, Jul 19, 2018 at 08:15:20PM +0800, guangrong.x...@gmail.com wrote: From: Xiao Guangrong flush_compressed_data() needs to wait all compre

Re: [Qemu-devel] [PATCH v2 8/8] migration: do not flush_compressed_data at the end of each iteration

2018-07-23 Thread Peter Xu
On Mon, Jul 23, 2018 at 04:53:11PM +0800, Xiao Guangrong wrote: > > > On 07/23/2018 04:35 PM, Peter Xu wrote: > > On Mon, Jul 23, 2018 at 04:05:21PM +0800, Xiao Guangrong wrote: > > > > > > > > > On 07/23/2018 01:49 PM, Peter Xu wrote: > > > > On Thu, Jul 19, 2018 at 08:15:20PM +0800, guangrong

Re: [Qemu-devel] [PATCH v2 for-3.0] po: Don't include comments with location

2018-07-23 Thread Thomas Huth
On 20.07.2018 23:25, Stefan Weil wrote: > Those comments change often when ui/gtk.c is changed and are not > really useful. > > Signed-off-by: Stefan Weil > --- > > CC'ing all translators because of the new string which still needs > translations. > > v2: Only automatically created content, no

Re: [Qemu-devel] [PATCH v2 3/8] migration: show the statistics of compression

2018-07-23 Thread Peter Xu
On Mon, Jul 23, 2018 at 04:40:29PM +0800, Xiao Guangrong wrote: > > > On 07/23/2018 04:05 PM, Peter Xu wrote: > > On Mon, Jul 23, 2018 at 03:39:18PM +0800, Xiao Guangrong wrote: > > > > > > > > > On 07/23/2018 12:36 PM, Peter Xu wrote: > > > > On Thu, Jul 19, 2018 at 08:15:15PM +0800, guangrong

Re: [Qemu-devel] [RFC 3/3] vhost-user: support programming VFIO group in master

2018-07-23 Thread Michael S. Tsirkin
On Mon, Jul 23, 2018 at 12:59:56PM +0800, Tiwei Bie wrote: > Introduce a slave message to allow slave to share its > VFIO group fd to master and do the IOMMU programming > based on virtio device's DMA address space for this > group in QEMU. > > For the vhost backends which support vDPA, they could

Re: [Qemu-devel] [RFC 3/3] vhost-user: support programming VFIO group in master

2018-07-23 Thread Michael S. Tsirkin
On Mon, Jul 23, 2018 at 12:59:56PM +0800, Tiwei Bie wrote: > Introduce a slave message to allow slave to share its > VFIO group fd to master and do the IOMMU programming > based on virtio device's DMA address space for this > group in QEMU. > > For the vhost backends which support vDPA, they could

[Qemu-devel] [PATCH] hw/intc/exynos4210_gic: Turn instance_init into realize function

2018-07-23 Thread Thomas Huth
The instance_init function of the "exynos4210.gic" device creates a new "arm_gic" device and immediately realizes it with qdev_init_nofail(). This will leave a lot of object in the QOM tree during introspection of the "exynos4210.gic" device, e.g. reproducible by starting QEMU like this: qemu-syst

Re: [Qemu-devel] [PATCH 2/2] RFC: seccomp: prefer SCMP_ACT_KILL_PROCESS if available

2018-07-23 Thread Daniel P . Berrangé
On Fri, Jul 20, 2018 at 05:44:25PM +0200, Marc-André Lureau wrote: > The upcoming libseccomp release should have SCMP_ACT_KILL_PROCESS > action (https://github.com/seccomp/libseccomp/issues/96). > > SCMP_ACT_KILL_PROCESS is preferable to immediately terminate the > offending process, rather than h

Re: [Qemu-devel] [PATCH v2 6/8] migration: move handle of zero page to the thread

2018-07-23 Thread Peter Xu
On Mon, Jul 23, 2018 at 04:44:49PM +0800, Xiao Guangrong wrote: [...] > > > > > > However, it is not safe to do ram_release_pages in the thread as it's > > > not protected it multithreads. Fortunately, compression will be disabled > > > if it switches to post-copy, so i preferred to keep current

Re: [Qemu-devel] [PATCH v2 for-3.0] po: Don't include comments with location

2018-07-23 Thread Peter Maydell
On 20 July 2018 at 22:25, Stefan Weil wrote: > Those comments change often when ui/gtk.c is changed and are not > really useful. > > Signed-off-by: Stefan Weil > --- > > CC'ing all translators because of the new string which still needs > translations. > > v2: Only automatically created content,

Re: [Qemu-devel] [PATCH v3 for 3.0 00/18] docker fixes (and one tcg test tweak)

2018-07-23 Thread Alex Bennée
Alex Bennée writes: > Hi, > > I've missed the boat for today's rc1 but I'd like to get this merged > before rc2. The new docker.py change is technically new functionality > but I'm counting it as a usability bug fix as it replaces a random > back trace failure with a preemptive failure and mess

[Qemu-devel] [PATCH] pci-pc: add NULL check for qpci_free_pc

2018-07-23 Thread Emanuele Giuseppe Esposito
The current layout of struct QPCIBusPC provides only one field, QPCIBus bus, so passing a NULL pointer to qpci_free_pc() makes container_of(NULL, QPCIBusPC, bus) returning 0 (NULL), that is correctly handled by g_free(). This is bad practice, allowing the caller to think that it's okay to always pa

Re: [Qemu-devel] [PATCH] target-i386: adds PV_SEND_IPI CPUID feature bit

2018-07-23 Thread Wanpeng Li
Ping, On Tue, 3 Jul 2018 at 05:43, Eduardo Habkost wrote: > > On Mon, Jul 02, 2018 at 06:22:51PM +0800, Wanpeng Li wrote: > > From: Wanpeng Li > > > > Adds PV_SEND_IPI CPUID feature bit. > > > > Thanks! > > Paolo, Radim: can I assume the bit is already reserved and queue > this patch, or should I

Re: [Qemu-devel] [PATCH for-3.0 ?] tests/libqtest: Improve kill_qemu() assert

2018-07-23 Thread Alex Bennée
Peter Maydell writes: > In kill_qemu() we have an assert that checks that the QEMU process > didn't dump core: > assert(!WCOREDUMP(wstatus)); > > Unfortunately the WCOREDUMP macro here means the resulting message > is not very easy to comprehend on at least some systems: > > ahci-te

Re: [Qemu-devel] [PATCH v8 5/5] PoC: tpm: add ACPI memory clear interface

2018-07-23 Thread Igor Mammedov
On Tue, 17 Jul 2018 17:39:12 +0200 Marc-André Lureau wrote: > Hi > > On Tue, Jul 17, 2018 at 9:57 AM, Igor Mammedov wrote: > > On Mon, 16 Jul 2018 14:59:48 +0200 > > Marc-André Lureau wrote: > > > >> This allows to pass the last failing test from the Windows HLK TPM 2.0 > >> TCG PPI 1.3 test

Re: [Qemu-devel] [PATCH v8 5/5] PoC: tpm: add ACPI memory clear interface

2018-07-23 Thread Marc-André Lureau
Hi On Mon, Jul 23, 2018 at 1:08 PM, Igor Mammedov wrote: > On Tue, 17 Jul 2018 17:39:12 +0200 > Marc-André Lureau wrote: > >> Hi >> >> On Tue, Jul 17, 2018 at 9:57 AM, Igor Mammedov wrote: >> > On Mon, 16 Jul 2018 14:59:48 +0200 >> > Marc-André Lureau wrote: >> > >> >> This allows to pass the

Re: [Qemu-devel] [PATCH] ppc/xics: fix ICP reset path

2018-07-23 Thread Cédric Le Goater
On 07/12/2018 12:01 PM, Greg Kurz wrote: > Recent cleanup in commit a028dd423ee6 dropped the ICPStateClass::reset > handler. It is now up to child ICP classes to call the DeviceClass::reset > handler of the parent class, thanks to device_class_set_parent_reset(). > This is a better object programmi

Re: [Qemu-devel] [RFC 3/3] vhost-user: support programming VFIO group in master

2018-07-23 Thread Tiwei Bie
On Mon, Jul 23, 2018 at 12:19:04PM +0300, Michael S. Tsirkin wrote: > On Mon, Jul 23, 2018 at 12:59:56PM +0800, Tiwei Bie wrote: [...] > > @@ -815,6 +816,21 @@ Slave message types > >This request should be sent only when > > VHOST_USER_PROTOCOL_F_HOST_NOTIFIER > >protocol feature h

Re: [Qemu-devel] [RFC 3/3] vhost-user: support programming VFIO group in master

2018-07-23 Thread Tiwei Bie
On Mon, Jul 23, 2018 at 12:20:12PM +0300, Michael S. Tsirkin wrote: > On Mon, Jul 23, 2018 at 12:59:56PM +0800, Tiwei Bie wrote: [...] > > > > +static int vhost_user_slave_handle_vfio_group(struct vhost_dev *dev, > > + int *fd) > > +{ > > +struct v

Re: [Qemu-devel] [PATCH for-3.0] tcg/i386: Mark xmm registers call-clobbered

2018-07-23 Thread Jason A. Donenfeld
Hi Richard, I can confirm this fixes the issue. https://www.wireguard.com/build-status/ is now all green again. Thanks, Jason

Re: [Qemu-devel] [Qemu-block] [PATCH v9 02/31] block: Use children list in bdrv_refresh_filename

2018-07-23 Thread Ari Sundholm
On 07/22/2018 12:14 AM, Max Reitz wrote: On 2018-07-19 14:47, Ari Sundholm wrote: Hi! On 06/28/2018 03:07 AM, Max Reitz wrote: bdrv_refresh_filename() should invoke itself recursively on all children, not just on file. With that change, we can remove the manual invocations in blkverify, quoru

Re: [Qemu-devel] [RFC PATCH 1/6] hw/arm/virt: Add virt-3.1 machine type

2018-07-23 Thread Igor Mammedov
On Wed, 4 Jul 2018 14:49:18 +0200 Andrew Jones wrote: > Signed-off-by: Andrew Jones Reviewed-by: Igor Mammedov > --- > hw/arm/virt.c | 21 - > 1 file changed, 16 insertions(+), 5 deletions(-) > > diff --git a/hw/arm/virt.c b/hw/arm/virt.c > index 281ddcdf6e26..880441275

[Qemu-devel] [PATCH for-3.0 2/4] migration: disallow recovery for release-ram

2018-07-23 Thread Peter Xu
Postcopy recovery won't work well with release-ram capability since release-ram will drop the page buffer as long as the page is put into the send buffer. So if there is a network failure happened, any page buffers that have not yet reached the destination VM but have already been sent from the so

[Qemu-devel] [PATCH for-3.0 4/4] tests: torture release-ram in postcopy test

2018-07-23 Thread Peter Xu
The release-ram capability will run some extra code for postcopy to release used ram right away, let's just turn that on for the postcopy unix test always to torture that code path too to make sure release-ram feature won't break again. The recovery test needs to turn that off since release-ram ca

[Qemu-devel] [PATCH for-3.0 0/4] migration: some fixes for release-ram

2018-07-23 Thread Peter Xu
The release-ram feature is broken. Fix it up. Meanwhile disable postcopy recovery when release-ram is enabled, since they cannot work together. Please see the comments for more information. This patchset is for 3.0. Please review, thanks. Peter Xu (4): migration: update recv bitmap only on

[Qemu-devel] [PATCH for-3.0 1/4] migration: update recv bitmap only on dest vm

2018-07-23 Thread Peter Xu
We shouldn't update the received bitmap if we're the source VM. This fixes a breakage when release-ram is enabled on postcopy. Signed-off-by: Peter Xu --- migration/ram.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 52dd

[Qemu-devel] [PATCH for-3.0 3/4] tests: only update last_byte when at the edge

2018-07-23 Thread Peter Xu
The only possible change of last_byte is when it reaches the edge. Setting it every time might let last_byte contain an invalid data when memory corruption is detected, then the check of the next byte will be incorrect. For example, a single page corruption at address 0x14ad000 will also lead to a

[Qemu-devel] [PATCH] target/arm: Escalate to correct HardFault when AIRCR.BFHFNMINS is set

2018-07-23 Thread Peter Maydell
When we escalate a v8M exception to HardFault, if AIRCR.BFHFNMINNS is set then we need to decide whether it should become a secure HardFault or a nonsecure HardFault. We should always escalate to the same target security state as the original exception. The current code tries to test this using the

Re: [Qemu-devel] [RFC PATCH 2/6] device_tree: add qemu_fdt_add_path

2018-07-23 Thread Igor Mammedov
On Wed, 4 Jul 2018 14:49:19 +0200 Andrew Jones wrote: > qemu_fdt_add_path works like qemu_fdt_add_subnode, except it > also recursively adds any missing parent nodes. Probably add here why new helper is need? > > Cc: Peter Crosthwaite > Cc: Alexander Graf > Signed-off-by: Andrew Jones > --

Re: [Qemu-devel] [PATCH] qstring: Fix integer overflow

2018-07-23 Thread Markus Armbruster
liujunjie writes: > From: l00425170 > > The incoming parameters "start" and "end" is int type in > qstring_from_substr(), but this function can be called by > qstring_from_str, which is size_t type in strlen(str). Yes, there's a conversion from size_t to int in return qstring_from_substr(s

[Qemu-devel] [PULL 1/2] linux-user: fix ELF load alignment error

2018-07-23 Thread Laurent Vivier
When we try to use some targets on ppc64, it can happen the target doesn't support the host page size to align ELF load sections and fails with: ELF load command alignment not page-aligned Since commit a70daba3771 ("linux-user: Tell guest about big host page sizes") the host page size is used t

[Qemu-devel] [PULL 0/2] Linux user for 3.0 patches

2018-07-23 Thread Laurent Vivier
The following changes since commit 5b3ecd3d941a0ae8a8cfbba5ab8139b2bf104822: Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20180719' into staging (2018-07-20 11:08:33 +0100) are available in the Git repository at: git://github.com/vivier/qemu.git tags/linux-user-for-3.0-pull-reque

[Qemu-devel] [PULL 2/2] linux-user/ppc: Implement swapcontext syscall

2018-07-23 Thread Laurent Vivier
From: Richard Henderson This allows the tests generated by debian-powerpc-user-cross to function properly, especially tests/test-coroutine. Technically this syscall is available to both ppc32 and ppc64, but only ppc32 glibc actually uses it. Thus the ppc64 path is untested. Signed-off-by: Rich

Re: [Qemu-devel] [RFC PATCH 3/6] hw/arm/virt: DT: add cpu-map

2018-07-23 Thread Igor Mammedov
On Wed, 4 Jul 2018 14:49:20 +0200 Andrew Jones wrote: > Support devicetree CPU topology descriptions. > > Signed-off-by: Andrew Jones > --- > hw/arm/virt.c | 35 +++ > include/hw/arm/virt.h | 1 + > 2 files changed, 36 insertions(+) > > diff --git a/h

[Qemu-devel] [PATCH for-3.1] s390x: introduce 3.1 compat machine

2018-07-23 Thread Cornelia Huck
Signed-off-by: Cornelia Huck --- hw/s390x/s390-virtio-ccw.c | 17 - include/hw/compat.h| 3 +++ 2 files changed, 19 insertions(+), 1 deletion(-) diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c index 7983185d04..d366909474 100644 --- a/hw/s390x/s390-v

[Qemu-devel] [PULL 1/2] qapi: Make 'allow-oob' optional in SchemaInfoCommand

2018-07-23 Thread Markus Armbruster
Making 'allow-oob' optional in SchemaInfoCommand permits omitting it in the common case. Shrinks query-qmp-schema's output from 122.1KiB to 118.6KiB for me. Note that out-of-band execution is still experimental (you have to configure the monitor with x-oob=on to use it). Signed-off-by: Markus Ar

[Qemu-devel] [PULL 2/2] monitor: Fix unsafe sharing of @cur_mon among threads

2018-07-23 Thread Markus Armbruster
From: Peter Xu @cur_mon is null unless the main thread is running monitor code, either HMP code within monitor_read(), or QMP code within monitor_qmp_dispatch(). Use of @cur_mon outside the main thread is therefore unsafe. Most of its uses are in monitor command handlers. These run in the main

[Qemu-devel] [PULL 0/2] QAPI and monitor patches for 2018-07-23 (3.0.0-rc2)

2018-07-23 Thread Markus Armbruster
The following changes since commit 6598f0cdad6acc6674c4f060fa46e537228c2c47: po: Don't include comments with location (2018-07-23 10:50:54 +0100) are available in the Git repository at: git://repo.or.cz/qemu/armbru.git tags/pull-qapi-2018-07-23 for you to fetch changes up to 62aa1d887ff9fc7

Re: [Qemu-devel] [PATCH v3] trace/simple: fix hang in child after fork(2)

2018-07-23 Thread Stefan Hajnoczi
On Tue, Jul 17, 2018 at 11:19:44AM +0100, Stefan Hajnoczi wrote: > The simple trace backend spawns a write-out thread which is used to > asynchronously flush the in-memory ring buffer to disk. > > fork(2) does not clone all threads, only the thread that invoked > fork(2). As a result there is no

Re: [Qemu-devel] [RFC PATCH 4/6] hw/arm/virt-acpi-build: distinguish possible and present cpus

2018-07-23 Thread Igor Mammedov
On Wed, 4 Jul 2018 14:49:21 +0200 Andrew Jones wrote: > When building ACPI tables regarding CPUs we should always build > them for the number of possible CPUs, not the number of present > CPUs. We then ensure only the present CPUs are enabled. > > Signed-off-by: Andrew Jones > --- > hw/arm/vi

Re: [Qemu-devel] [PATCH] block/file-posix: add bdrv_attach_aio_context callback for host dev and cdrom

2018-07-23 Thread Farhan Ali
On 07/20/2018 03:11 PM, Farhan Ali wrote: I am seeing another issue pop up, in a different test. Even though it's a different assertion, it might be related based on the call trace. Stack trace of thread 276199: #0  0x03ff8473e274 raise (libc.so.6) #1  0x03ff847239a8 abort (libc.so.6

Re: [Qemu-devel] [Qemu-stable] [PATCH v4] block: fix QEMU crash with scsi-hd and drive_del

2018-07-23 Thread Kevin Wolf
Am 18.07.2018 um 23:07 hat Michael Roth geschrieben: > Quoting Kevin Wolf (2018-05-29 15:19:17) > > Am 28.05.2018 um 14:03 hat Greg Kurz geschrieben: > > > Removing a drive with drive_del while it is being used to run an I/O > > > intensive workload can cause QEMU to crash. > > > > > > An AIO flus

Re: [Qemu-devel] [PATCH v2] iotests: remove LUKS support from test 226

2018-07-23 Thread Kevin Wolf
Am 13.07.2018 um 19:37 hat John Snow geschrieben: > This test doesn't actually care about the format anyway, it just > supports "all formats" as a convenience. LUKS however does not use a > simple image filename which confuses this iotest. > > We can simply skip the test for formats that use IMGOP

Re: [Qemu-devel] [PATCH] qemu-iotests: Use host_device instead of file in 149

2018-07-23 Thread Kevin Wolf
Am 13.07.2018 um 20:12 hat John Snow geschrieben: > > > On 07/13/2018 03:10 AM, Kevin Wolf wrote: > > The test case uses block devices with driver=file, which causes the test > > to fail after commit 230ff73904 added a deprecation warning for this. > > Fix the test case to use driver=host_device

Re: [Qemu-devel] [PATCH] qemu-iotests: Use host_device instead of file in 149

2018-07-23 Thread Daniel P . Berrangé
On Mon, Jul 23, 2018 at 03:53:45PM +0200, Kevin Wolf wrote: > Am 13.07.2018 um 20:12 hat John Snow geschrieben: > > > > > > On 07/13/2018 03:10 AM, Kevin Wolf wrote: > > > The test case uses block devices with driver=file, which causes the test > > > to fail after commit 230ff73904 added a deprec

Re: [Qemu-devel] [PATCH] iotest: Fix filtering order in 226

2018-07-23 Thread Kevin Wolf
Am 13.07.2018 um 22:14 hat John Snow geschrieben: > > > On 07/13/2018 03:41 PM, Max Reitz wrote: > > The test directory should be filtered before the image format, otherwise > > the test will fail if the image format is part of the test directory, > > like so: > > > > [...] > > -can't open: Coul

Re: [Qemu-devel] [PATCH] iotests: Disallow compat=0.10 in 223

2018-07-23 Thread Kevin Wolf
Am 13.07.2018 um 21:15 hat Max Reitz geschrieben: > 223 tests persistent dirty bitmaps which are not supported in > compat=0.10, so that option is unsupported for this test. > > Signed-off-by: Max Reitz Thanks, applied to the block branch. Kevin

Re: [Qemu-devel] [RFC PATCH 5/6] virt-acpi-build: add PPTT table

2018-07-23 Thread Igor Mammedov
On Wed, 4 Jul 2018 14:49:22 +0200 Andrew Jones wrote: > The ACPI PPTT table supports topology descriptions for ACPI > guests. Note, while a DT boot Linux guest with a non-flat CPU > topology will see socket and core IDs being sequential integers > starting from zero, e.g. with -smp 4,sockets=2,c

Re: [Qemu-devel] [PATCH] hw/intc/exynos4210_gic: Turn instance_init into realize function

2018-07-23 Thread Peter Maydell
On 23 July 2018 at 10:23, Thomas Huth wrote: > The instance_init function of the "exynos4210.gic" device creates a > new "arm_gic" device and immediately realizes it with qdev_init_nofail(). > This will leave a lot of object in the QOM tree during introspection of > the "exynos4210.gic" device, e.

Re: [Qemu-devel] [PATCH] block/vvfat: Disable debug message by default

2018-07-23 Thread Kevin Wolf
Am 18.07.2018 um 17:08 hat Thomas Huth geschrieben: > It's annoying to see this debug message every time you use vvfat. > Disable it with the DLOG() macro by default, as it is done with the > other debug messages in this file. > > Signed-off-by: Thomas Huth Thanks, applied to the block branch.

Re: [Qemu-devel] [PULL 0/2] Linux user for 3.0 patches

2018-07-23 Thread Peter Maydell
On 23 July 2018 at 13:56, Laurent Vivier wrote: > The following changes since commit 5b3ecd3d941a0ae8a8cfbba5ab8139b2bf104822: > > Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20180719' into > staging (2018-07-20 11:08:33 +0100) > > are available in the Git repository at: > > git:/

Re: [Qemu-devel] [PATCH v1 00/11] memory-device: complete refactoring

2018-07-23 Thread Igor Mammedov
On Thu, 5 Jul 2018 13:59:32 +0200 David Hildenbrand wrote: > This is another part of the original series > [PATCH v4 00/14] MemoryDevice: use multi stage hotplug handlers > And is based on > [PATCH v3 0/4] pc-dimm: pre_plug "slot" and "addr" assignment > > This series completes refactor

Re: [Qemu-devel] [PATCH] block/vvfat: Fix crash when reporting error about too many files in directory

2018-07-23 Thread Kevin Wolf
Am 18.07.2018 um 17:28 hat Thomas Huth geschrieben: > When using the vvfat driver with a directory that contains too many files, > QEMU currently crashes. We are trying to print the wrong path variable here. > > Signed-off-by: Thomas Huth > --- > block/vvfat.c | 3 +-- > 1 file changed, 1 insert

Re: [Qemu-devel] [PATCH] qstring: Fix integer overflow

2018-07-23 Thread liujunjie (A)
Thanks for your reply. > Really? How exactly can this happen? Please explain step by step. There exist a qemu core related to this. You have mention that "The conversion truncates when strlen(str) - 1 exceeds INT_MAX". Later in function qstring_from_substr, this truncated "end" will be assigned

Re: [Qemu-devel] [PATCH] block: Don't lock /dev/null and /dev/zero automatically

2018-07-23 Thread Max Reitz
On 2018-07-23 03:56, Fam Zheng wrote: > On Sun, Jul 22, 2018 at 10:06 PM Max Reitz wrote: >> >> On 2018-07-22 04:37, Fam Zheng wrote: >>> On Sun, Jul 22, 2018 at 5:08 AM Max Reitz wrote: On 2018-07-19 05:41, Fam Zheng wrote: > On my Fedora 28, /dev/null is locked by some other proce

[Qemu-devel] [PULL 0/5] target-arm queue

2018-07-23 Thread Peter Maydell
nce commit 55b1f14cefcb19ce6d5e28c4c83404230888aa7e: Merge remote-tracking branch 'remotes/vivier2/tags/linux-user-for-3.0-pull-request' into staging (2018-07-23 14:03:14 +0100) are available in the Git repository at: git://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-a

[Qemu-devel] [PULL 4/5] hw/arm/spitz: Move problematic nand_init() code to realize function

2018-07-23 Thread Peter Maydell
From: Thomas Huth nand_init() does not only create the NAND device, it also realizes the device with qdev_init_nofail() already. So we must not call nand_init() from an instance_init function like sl_nand_init(), otherwise we get superfluous NAND devices in the QOM tree after introspecting the 's

[Qemu-devel] [RFC PATCH] hw/s390x/virtio-ccw: Consolidate calls to virtio_ccw_unrealize()

2018-07-23 Thread Thomas Huth
Currently, every virtio-ccw device explicitely sets its unrealize function to virtio_ccw_unrealize() in its class_init function. We can simplify this by using this unrealize function in the common virtio_ccw_busdev_unrealize() function if no other device unrealize function has been set. Signed-off

[Qemu-devel] [PULL 3/5] target/arm: Correctly handle overlapping small MPU regions

2018-07-23 Thread Peter Maydell
To correctly handle small (less than TARGET_PAGE_SIZE) MPU regions, we must correctly handle the case where the address being looked up hits in an MPU region that is not small but the address is in the same page as a small region. For instance if MPU region 1 covers an entire page from 0x2000 to 0x

[Qemu-devel] [PULL 2/5] hw/sd/bcm2835_sdhost: Fix PIO mode writes

2018-07-23 Thread Peter Maydell
From: Guenter Roeck Writes in PIO mode have two requirements: - A data interrupt must be generated after a write command has been issued to indicate that the chip is ready to receive data. - A block interrupt must be generated after each block to indicate that the chip is ready to receive th

[Qemu-devel] [PULL 5/5] hw/intc/exynos4210_gic: Turn instance_init into realize function

2018-07-23 Thread Peter Maydell
From: Thomas Huth The instance_init function of the "exynos4210.gic" device creates a new "arm_gic" device and immediately realizes it with qdev_init_nofail(). This will leave a lot of object in the QOM tree during introspection of the "exynos4210.gic" device, e.g. reproducible by starting QEMU l

[Qemu-devel] [PULL 1/5] hw/microblaze/xlnx-zynqmp-pmu: Fix introspection problem in 'xlnx, zynqmp-pmu-soc'

2018-07-23 Thread Peter Maydell
From: Thomas Huth Valgrind complains: echo "{'execute':'qmp_capabilities'} {'execute':'device-list-properties'," \ "'arguments':{'typename':'xlnx,zynqmp-pmu-soc'}}" \ "{'execute': 'human-monitor-command', " \ "'arguments': {'command-line': 'info qtree'}}" | \ valgrind -q microblazeel-softmmu

Re: [Qemu-devel] [PATCH] qstring: Fix integer overflow

2018-07-23 Thread Eric Blake
On 07/20/2018 08:09 AM, liujunjie wrote: From: l00425170 The incoming parameters "start" and "end" is int type in qstring_from_substr(), but this function can be called by qstring_from_str, which is size_t type in strlen(str). It may result in coredump when called g_malloc later. One scene to t

Re: [Qemu-devel] [PATCH 0/6] accel/tcg: Support execution from MMIO and small MMU regions

2018-07-23 Thread Cédric Le Goater
On 07/10/2018 06:00 PM, Peter Maydell wrote: > This series adds support to TCG for executing from MMIO regions > and small MMU regions. The basic principle is that if get_page_addr_code() > finds that the region is not backed by a full page of RAM then it > returns -1, and tb_gen_code() then genera

Re: [Qemu-devel] [PATCH v3 for 3.0 09/18] docker: disable debian-powerpc-user-cross

2018-07-23 Thread Alex Bennée
Alex Bennée writes: > While we can build we can't run the unit tests due to a missing system > call (249 - swapcontext). This could be a code generation issue as > other architectures don't seem to have this system call. > > Signed-off-by: Alex Bennée > Tested-by: Philippe Mathieu-Daudé > Cc:

Re: [Qemu-devel] [PATCH 0/6] accel/tcg: Support execution from MMIO and small MMU regions

2018-07-23 Thread Cédric Le Goater
On 07/10/2018 06:00 PM, Peter Maydell wrote: > This series adds support to TCG for executing from MMIO regions > and small MMU regions. The basic principle is that if get_page_addr_code() > finds that the region is not backed by a full page of RAM then it > returns -1, and tb_gen_code() then genera

Re: [Qemu-devel] [RFC PATCH] hw/s390x/virtio-ccw: Consolidate calls to virtio_ccw_unrealize()

2018-07-23 Thread Cornelia Huck
On Mon, 23 Jul 2018 16:42:31 +0200 Thomas Huth wrote: > Currently, every virtio-ccw device explicitely sets its unrealize > function to virtio_ccw_unrealize() in its class_init function. > We can simplify this by using this unrealize function in the common > virtio_ccw_busdev_unrealize() function

Re: [Qemu-devel] [PATCH for-3.0] qapi: Make 'allow-oob' optional in SchemaInfoCommand

2018-07-23 Thread Eric Blake
On 07/18/2018 04:05 AM, Markus Armbruster wrote: Making 'allow-oob' optional in SchemaInfoCommand permits omitting it in the common case. Shrinks query-qmp-schema's output from 122.1KiB to 118.6KiB for me. Note that out-of-band execution is still experimental (you have to configure the monitor

Re: [Qemu-devel] [PULL 0/2] QAPI and monitor patches for 2018-07-23 (3.0.0-rc2)

2018-07-23 Thread Peter Maydell
On 23 July 2018 at 14:13, Markus Armbruster wrote: > The following changes since commit 6598f0cdad6acc6674c4f060fa46e537228c2c47: > > po: Don't include comments with location (2018-07-23 10:50:54 +0100) > > are available in the Git repository at: > > git://repo.or.cz/qemu/armbru.git tags/pull-

Re: [Qemu-devel] [PATCH 0/6] accel/tcg: Support execution from MMIO and small MMU regions

2018-07-23 Thread Peter Maydell
On 23 July 2018 at 15:57, Cédric Le Goater wrote: > On 07/10/2018 06:00 PM, Peter Maydell wrote: >> Note for the Xilinx folks: this patchset makes the mmio-exec >> testcase for running from the SPI flash pass. Cedric: you might >> like to test the aspeed image you had that relies on execution >> f

Re: [Qemu-devel] [PATCH v4 1/3] spapr: introduce a fixed IRQ number space

2018-07-23 Thread Cédric Le Goater
On 07/20/2018 04:38 AM, David Gibson wrote: > On Fri, Jul 06, 2018 at 03:36:24PM +0200, Greg Kurz wrote: >> On Fri, 6 Jul 2018 11:07:11 +0200 >> Cédric Le Goater wrote: > [snip] >>> +/* >>> + * The register property of a VIO device is defined in livirt using a >>> + * base number + 0x1000 increme

Re: [Qemu-devel] [PATCH] target/arm: Escalate to correct HardFault when AIRCR.BFHFNMINS is set

2018-07-23 Thread Richard Henderson
On 07/23/2018 05:34 AM, Peter Maydell wrote: > When we escalate a v8M exception to HardFault, if AIRCR.BFHFNMINNS is > set then we need to decide whether it should become a secure HardFault > or a nonsecure HardFault. We should always escalate to the same > target security state as the original exc

Re: [Qemu-devel] [PATCH v5 08/10] migration: create a dedicated thread to release rdma resource

2018-07-23 Thread Gal Shachaf
On Thu, Jul 5, 2018 at 10:26 PM, 858585 jemmy wrote: > On Thu, Jun 28, 2018 at 2:59 AM, Dr. David Alan Gilbert > wrote: >> * Lidong Chen (jemmy858...@gmail.com) wrote: >>> ibv_dereg_mr wait for a long time for big memory size virtual server. >>> >>> The test result is: >>> 10GB 326ms >>> 20

Re: [Qemu-devel] [PATCH] qstring: Fix integer overflow

2018-07-23 Thread Markus Armbruster
"liujunjie (A)" writes: > Thanks for your reply. >> Really? How exactly can this happen? Please explain step by step. > There exist a qemu core related to this. You have mention that "The > conversion truncates when strlen(str) - 1 exceeds INT_MAX". > Later in function qstring_from_substr, thi

Re: [Qemu-devel] [PATCH 0/6] accel/tcg: Support execution from MMIO and small MMU regions

2018-07-23 Thread Cédric Le Goater
On 07/23/2018 05:17 PM, Peter Maydell wrote: > On 23 July 2018 at 15:57, Cédric Le Goater wrote: >> On 07/10/2018 06:00 PM, Peter Maydell wrote: >>> Note for the Xilinx folks: this patchset makes the mmio-exec >>> testcase for running from the SPI flash pass. Cedric: you might >>> like to test the

Re: [Qemu-devel] [PATCH v4 1/3] spapr: introduce a fixed IRQ number space

2018-07-23 Thread Cédric Le Goater
On 07/20/2018 04:18 AM, David Gibson wrote: > On Fri, Jul 06, 2018 at 11:07:11AM +0200, Cédric Le Goater wrote: >> This proposal introduces a new IRQ number space layout using static >> numbers for all devices, depending on a device index, and a bitmap >> allocator for the MSI IRQ numbers which are

Re: [Qemu-devel] [PULL 0/5] target-arm queue

2018-07-23 Thread Peter Maydell
3:14 +0100) > > are available in the Git repository at: > > git://git.linaro.org/people/pmaydell/qemu-arm.git > tags/pull-target-arm-20180723 > > for you to fetch changes up to 1ddc9b98c3cb89fe23a55ba924000fd645253e87: > > hw

Re: [Qemu-devel] [PATCH] block/file-posix: add bdrv_attach_aio_context callback for host dev and cdrom

2018-07-23 Thread Stefan Hajnoczi
On Wed, Jul 18, 2018 at 02:12:56PM -0700, Nishanth Aravamudan wrote: > In ed6e2161 ("linux-aio: properly bubble up errors from initialzation"), > I only added a bdrv_attach_aio_context callback for the bdrv_file > driver. There are several other drivers that use the shared > aio_plug callback, thou

Re: [Qemu-devel] [PATCH] block/file-posix: add bdrv_attach_aio_context callback for host dev and cdrom

2018-07-23 Thread Stefan Hajnoczi
On Fri, Jul 20, 2018 at 03:11:14PM -0400, Farhan Ali wrote: > I am seeing another issue pop up, in a different test. Even though it's a > different assertion, it might be related based on the call trace. Which test case? > Stack trace of thread 276199: > #0 0x03ff8473e274 raise (libc.so.6) >

Re: [Qemu-devel] [PATCH v3 25/40] target/mips: Add updating CP0 BadInstrX register for nanoMIPs only

2018-07-23 Thread Richard Henderson
On 07/19/2018 05:54 AM, Stefan Markovic wrote: > From: Stefan Markovic > > Signed-off-by: Yongbok Kim > Signed-off-by: Aleksandar Markovic > Signed-off-by: Stefan Markovic > --- > target/mips/helper.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/target/mips/helper.c b/targe

Re: [Qemu-devel] [PATCH v3 24/40] target/mips: Add updating BadInstr and BadInstrP registers for nanoMIPS

2018-07-23 Thread Richard Henderson
On 07/19/2018 05:54 AM, Stefan Markovic wrote: > +if (!(env->insn_flags & ISA_NANOMIPS32)) { > +/* TODO: add BadInstr support for pre-nanoMIPS */ > + return; > +} > +if (env->CP0_Config3 & (1 << CP0C3_BI)) { > +instr = (cpu_lduw_code(env,

Re: [Qemu-devel] [PATCH] block/file-posix: add bdrv_attach_aio_context callback for host dev and cdrom

2018-07-23 Thread Farhan Ali
On 07/23/2018 12:30 PM, Stefan Hajnoczi wrote: On Fri, Jul 20, 2018 at 03:11:14PM -0400, Farhan Ali wrote: I am seeing another issue pop up, in a different test. Even though it's a different assertion, it might be related based on the call trace. Which test case? This test case involved o

[Qemu-devel] [PULL 3/7] qemu-img: avoid overflow of min_sparse parameter

2018-07-23 Thread Kevin Wolf
From: Peter Lieven the min_sparse convert parameter can overflow (e.g. -S 1024G) in the conversion from int64_t to int resulting in a negative min_sparse parameter. Avoid this by limiting the valid parameters to sane values. In fact anything exceeding the convert buffer size is also pointless. Wh

[Qemu-devel] [PULL 5/7] iotest: Fix filtering order in 226

2018-07-23 Thread Kevin Wolf
From: Max Reitz The test directory should be filtered before the image format, otherwise the test will fail if the image format is part of the test directory, like so: [...] -can't open: Could not open 'TEST_DIR/t.IMGFMT': Is a directory +can't open: Could not open '/tmp/test-IMGFMT/t.IMGFMT': I

[Qemu-devel] [PULL 7/7] block/vvfat: Disable debug message by default

2018-07-23 Thread Kevin Wolf
From: Thomas Huth It's annoying to see this debug message every time you use vvfat. Disable it with the DLOG() macro by default, as it is done with the other debug messages in this file. Signed-off-by: Thomas Huth Reviewed-by: John Snow Signed-off-by: Kevin Wolf --- block/vvfat.c | 4 ++-- 1

[Qemu-devel] [PULL 0/7] Block layer patches

2018-07-23 Thread Kevin Wolf
The following changes since commit 55b1f14cefcb19ce6d5e28c4c83404230888aa7e: Merge remote-tracking branch 'remotes/vivier2/tags/linux-user-for-3.0-pull-request' into staging (2018-07-23 14:03:14 +0100) are available in the git repository at: git://repo.or.cz/qemu/kevin.git tags/for-upstrea

[Qemu-devel] [PULL 4/7] iotests: remove LUKS support from test 226

2018-07-23 Thread Kevin Wolf
From: John Snow This test doesn't actually care about the format anyway, it just supports "all formats" as a convenience. LUKS however does not use a simple image filename which confuses this iotest. We can simply skip the test for formats that use IMGOPTSSYNTAX for their filenames without missi

[Qemu-devel] [PULL 2/7] block: Fix typos in comments (found by codespell)

2018-07-23 Thread Kevin Wolf
From: Stefan Weil Signed-off-by: Stefan Weil Reviewed-by: John Snow Reviewed-by: Jeff Cody Signed-off-by: Kevin Wolf --- block.c | 2 +- block/backup.c | 4 ++-- block/curl.c| 2 +- block/gluster.c | 2 +- block/vhdx.c| 2 +- 5 files changed, 6 insertions(+), 6 deletions(-)

[Qemu-devel] [PULL 1/7] qemu-iotests: Use host_device instead of file in 149

2018-07-23 Thread Kevin Wolf
The test case uses block devices with driver=file, which causes the test to fail after commit 230ff73904 added a deprecation warning for this. Fix the test case to use driver=host_device and update the reference output accordingly. Signed-off-by: Kevin Wolf --- tests/qemu-iotests/149 | 2 +

  1   2   3   >