[Qemu-devel] [PULL v2 37/57] tests/tcg: enable building for m68k

2018-06-21 Thread Alex Bennée
As before, using Debian SID compilers. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include index 65e3dee741..59dd8e314d 100644 --- a/tests/docker/Makefile.include +++ b/tests

[Qemu-devel] [PULL v2 26/57] tests/tcg: enable building for AArch64

2018-06-21 Thread Alex Bennée
We only have compilers for the (default) little endian variants. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé diff --git a/MAINTAINERS b/MAINTAINERS index a6d233a43a..de1ae8423e 100644 --- a/MAINTAINERS +++ b/M

[Qemu-devel] [PULL v2 31/57] tests/tcg/mips: include common mips hello-mips

2018-06-21 Thread Alex Bennée
Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé diff --git a/tests/tcg/mips/Makefile.target b/tests/tcg/mips/Makefile.target new file mode 100644 index 00..71f0c2dd53 --- /dev/null +++ b/tests/tcg/mips/Makefile.target @@ -0,0 +1,19 @@ +#

[Qemu-devel] [PULL v2 24/57] tests/tcg: enable building for ARM

2018-06-21 Thread Alex Bennée
This allows us to use the docker cross compiler image to build these tests. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé diff --git a/tests/tcg/arm/Makefile.include b/tests/tcg/arm/Makefile.include new file mode 100644 index 00..8e7ea

[Qemu-devel] [PULL v2 16/57] tests/tcg: enable building for i386

2018-06-21 Thread Alex Bennée
While you can construct a compile command that does work using the x86_64 host compiler that most people use this is flakey. Different distros handle this is different ways so we default to using a known good i386 compiler via docker. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé

[Qemu-devel] [PULL v2 56/57] tests/docker/Makefile.include: only force SID to NOCACHE if old

2018-06-21 Thread Alex Bennée
Now we can check the age of a docker image we can be a little more intelligent about re-building Sid images and only force NOCACHE if it is "old". Signed-off-by: Alex Bennée diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include index c0f09505bb..91d9665517 100644 --- a/tests

[Qemu-devel] [PULL v2 30/57] tests/docker/Makefile.include: fix mipsel-cross dependancy

2018-06-21 Thread Alex Bennée
This got broken in commit 4319db7 but generally only shows up when you try and do massive parallel builds on fresh machines. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.inclu

[Qemu-devel] [PULL v2 17/57] tests/tcg/i386: Build fix for hello-i386

2018-06-21 Thread Alex Bennée
From: Fam Zheng We have -Werror=missing-prototype, add a dummy prototype to avoid that warning. Signed-off-by: Fam Zheng Reviewed-by: Thomas Huth Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée diff --git a/tests/tcg/i386/hello-i386.c b/tests/tcg/i386/hello-i386.c index fa00380de2

[Qemu-devel] [PULL v2 11/57] tests/tcg/multiarch: Build fix for linux-test

2018-06-21 Thread Alex Bennée
From: Fam Zheng To keep the compiler happy, and to fit in our buildsys flags: - Make local functions "static" - #ifdef out unused functions - drop cutils/osdep dependencies Signed-off-by: Fam Zheng [AJB: drop cutils/osdep dependencies] Signed-off-by: Alex Bennée Reviewed-by: Thomas Huth Revi

[Qemu-devel] [PULL v2 25/57] tests/tcg/arm: fix up test-arm-iwmmxt test

2018-06-21 Thread Alex Bennée
We need to rename the source file to a .S so we can do a single-line assemble and link invocation. We also specify the additional CFLAGS for the compile as it's a non-standard ARM binary. Signed-off-by: Alex Bennée [rth: force fpu configuration] Signed-off-by: Richard Henderson Reviewed-by: Phil

[Qemu-devel] [PULL v2 29/57] tests/tcg: enable building for MIPS

2018-06-21 Thread Alex Bennée
This doesn't add any additional tests but enables building the multiarch tests for MIPS using docker cross compilers. We don't have a cross compiler for mips64 big endian though. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé diff --git a/tests

[Qemu-devel] [PULL v2 14/57] tests/tcg/multiarch: move most output to stdout

2018-06-21 Thread Alex Bennée
The default test run outputs to stdout so it can be re-directed. Errors are still reported to stderr. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Reviewed-by: Thomas Huth diff --git a/tests/tcg/multiarch/test

[Qemu-devel] [PULL v2 42/57] docker: move debian-powerpc-cross to sid based build

2018-06-21 Thread Alex Bennée
The original Jessie based cross builder hasn't worked for a while. The state of the libraries is still perilous for cross-building QEMU but we can use it for building TCG tests. The debian-apt-fake.sh script can also be dropped as it is no longer used. Signed-off-by: Alex Bennée Reviewed-by: Phi

[Qemu-devel] [PULL v2 18/57] tests/tcg/i386: fix test-i386

2018-06-21 Thread Alex Bennée
We don't include anything from qemu itself for the build. Signed-off-by: Alex Bennée Reviewed-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson diff --git a/tests/tcg/i386/test-i386.c b/tests/tcg/i386/test-i386.c index 959920

Re: [Qemu-devel] [PATCH v4 03/11] ppc4xx_i2c: Rewrite to model hardware more closely

2018-06-21 Thread BALATON Zoltan
On Wed, 20 Jun 2018, David Gibson wrote: On Tue, Jun 19, 2018 at 10:52:15AM +0200, BALATON Zoltan wrote: Rewrite to make it closer to how real device works so that guest OS drivers can access I2C devices. Previously this was only a hack to allow U-Boot to get past accessing SPD EEPROMs but to su

Re: [Qemu-devel] [PATCH v3 08/49] qapi: add #if/#endif helpers

2018-06-21 Thread Markus Armbruster
Marc-André Lureau writes: > Add helpers to wrap generated code with #if/#endif lines. > > Add QAPIGenCSnippet class to write C snippet code, make QAPIGenC > inherit from it, for full C files with copyright headers etc. > > Add a 'with' statement context manager that will be used to wrap > generat

[Qemu-devel] [PULL v2 23/57] tests/tcg: move ARM specific tests into subdir

2018-06-21 Thread Alex Bennée
These only need to be built for ARM guests. Signed-off-by: Alex Bennée Reviewed-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson diff --git a/MAINTAINERS b/MAINTAINERS index 096b5bbf61..a6d233a43a 100644 --- a/MAINTAINERS ++

Re: [Qemu-devel] [PATCH v4 00/11] Misc sam460ex improvements

2018-06-21 Thread BALATON Zoltan
Hello, On Wed, 20 Jun 2018, David Gibson wrote: On Tue, Jun 19, 2018 at 10:52:15AM +0200, BALATON Zoltan wrote: Next spin of sam460ex pathces with changes according to review and some new patches. So, the sm501 patches I don't really have the technical knowledge to review, and I'm a little un

[Qemu-devel] [PULL v2 34/57] tests/tcg: enable building for Alpha

2018-06-21 Thread Alex Bennée
We can't use our normal Debian based compilers as Alpha isn't an officially supported architecture. However it is available as a port and fortunately cross compilers for all these targets are included in Debian Sid, the perpetual rolling/unstable/testing version of Debian. Signed-off-by: Alex Benn

Re: [Qemu-devel] [PATCH 8/9] spapr: Limit available pagesizes to provide a consistent guest environment

2018-06-21 Thread Cédric Le Goater
On 06/18/2018 08:36 AM, David Gibson wrote: > KVM HV has some limitations (deriving from the hardware) that mean not all > host-cpu supported pagesizes may be usable in the guest. At present this > means that KVM guests and TCG guests may see different available page sizes > even if they notionall

Re: [Qemu-devel] [PATCH v4 02/11] ppc4xx_i2c: Implement directcntl register

2018-06-21 Thread BALATON Zoltan
On Wed, 20 Jun 2018, David Gibson wrote: On Tue, Jun 19, 2018 at 10:52:15AM +0200, BALATON Zoltan wrote: As well as being able to generate its own i2c transactions, the ppc4xx i2c controller has a DIRECTCNTL register which allows explicit control of the i2c lines. Using this register an OS can

[Qemu-devel] [PULL v2 36/57] tests/tcg: enable building for HPPA

2018-06-21 Thread Alex Bennée
Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include index 8c24f8807e..65e3dee741 100644 --- a/tests/docker/Makefile.include +++ b/tests/docker/Makefile.include @@ -71,6 +71,7

[Qemu-devel] [PULL v2 20/57] tests/tcg/x86_64: add Makefile.target

2018-06-21 Thread Alex Bennée
The sources for x86_64 are shared in the i386 directory which will be included thanks to TARGET_BASE_ARCH. However not all sources build so we need to filter out the ones we can't build in the 64 bit world and those that can't be built for 32 bit. Signed-off-by: Alex Bennée Reviewed-by: Philippe

[Qemu-devel] [PULL v2 50/57] tests: add top-level make dependency for docker builds

2018-06-21 Thread Alex Bennée
One problem with satisfying your docker dependencies in a sub-make it you might end up trying to satisfy the dependency multiple times. This is especially a problem with debian-sid based cross compilers and CI setups. We solve this by doing a docker build pass at the top level before any sub-makes

Re: [Qemu-devel] [PATCH RFC] hw/pc: set q35 as the default x86 machine

2018-06-21 Thread Daniel P . Berrangé
On Wed, Jun 20, 2018 at 06:33:51PM +0100, Peter Maydell wrote: > On 18 June 2018 at 18:18, Michael S. Tsirkin wrote: > > On Mon, Jun 18, 2018 at 02:14:31PM -0300, Eduardo Habkost wrote: > >> > Sure if someone does that, we'll have no choice, but as long as 'pc' is > >> > shipped we shouldn't gratu

Re: [Qemu-devel] [PATCH RFC] hw/pc: set q35 as the default x86 machine

2018-06-21 Thread Daniel P . Berrangé
On Wed, Jun 20, 2018 at 02:28:24PM -0300, Eduardo Habkost wrote: > On Mon, Jun 18, 2018 at 08:18:16PM +0300, Michael S. Tsirkin wrote: > > On Mon, Jun 18, 2018 at 02:14:31PM -0300, Eduardo Habkost wrote: > > > > Sure if someone does that, we'll have no choice, but as long as 'pc' is > > > > shipped

Re: [Qemu-devel] [PATCH v2 3/4] hw/arm/smmuv3: IOTLB emulation

2018-06-21 Thread Auger Eric
Hi Peter, On 06/20/2018 06:07 PM, Peter Maydell wrote: > On 12 June 2018 at 09:08, Eric Auger wrote: >> We emulate a TLB cache of size SMMU_IOTLB_MAX_SIZE=256. >> It is implemented as a hash table whose key is a combination >> of the 16b asid and 48b IOVA (Jenkins hash). >> >> Entries are invalid

Re: [Qemu-devel] [PATCH v2 2/4] hw/arm/smmuv3: Cache/invalidate config data

2018-06-21 Thread Auger Eric
Hi Peter, On 06/20/2018 05:56 PM, Peter Maydell wrote: > On 12 June 2018 at 09:08, Eric Auger wrote: >> Let's cache config data to avoid fetching and parsing STE/CD >> structures on each translation. We invalidate them on data structure >> invalidation commands. >> >> We put in place a per-smmu m

Re: [Qemu-devel] [PATCH 9/9] spapr: Don't rewrite mmu capabilities in KVM mode

2018-06-21 Thread Cédric Le Goater
On 06/18/2018 08:36 AM, David Gibson wrote: > Currently during KVM initialization on POWER, kvm_fixup_page_sizes() > rewrites a bunch of information in the cpu state to reflect the > capabilities of the host MMU and KVM. This overwrites the information > that's already there reflecting how the TCG

Re: [Qemu-devel] [PATCH v2 2/4] hw/arm/smmuv3: Cache/invalidate config data

2018-06-21 Thread Auger Eric
Hi Peter, On 06/20/2018 06:10 PM, Peter Maydell wrote: > On 20 June 2018 at 16:56, Peter Maydell wrote: >> On 12 June 2018 at 09:08, Eric Auger wrote: >>> +smmuv3_config_cache_hit(uint32_t sid, uint32_t hits, uint32_t misses, >>> float perc) "Config cache HIT for sid %d (hits=%d, misses=%d, hit

Re: [Qemu-devel] [PATCH v3 06/49] qapi: add 'ifcond' to visitor methods

2018-06-21 Thread Markus Armbruster
Marc-André Lureau writes: > Modify the test visitor to check correct passing of values. > > Signed-off-by: Marc-André Lureau > Reviewed-by: Markus Armbruster > --- [...] > diff --git a/tests/qapi-schema/test-qapi.py b/tests/qapi-schema/test-qapi.py > index 10e68b01d9..6d25a37dda 100644 > --- a/

[Qemu-devel] [PATCH 1/5] sm501: Implement i2c part for reading monitor EDID

2018-06-21 Thread BALATON Zoltan
Emulate the i2c part of SM501 which is used to access the EDID info from a monitor. The vmstate structure is changed and its version is increased but SM501 is only used on SH and PPC sam460ex machines that don't support cross-version migration. Signed-off-by: BALATON Zoltan --- default-configs/

[Qemu-devel] [PATCH 0/5] Misc sm501 improvements

2018-06-21 Thread BALATON Zoltan
These are fixes to sm501 emulation that were found while testing with AmigaOS 4.1FE (AmigaOS 4 is known to work on real hardware but we have no way to verify it against hardware). While this is mainly to improve sam460ex emulation this is now a separate series with the sm501 specific patches becaus

[Qemu-devel] [PATCH 2/5] sm501: Perform a full update after palette change

2018-06-21 Thread BALATON Zoltan
From: Sebastian Bauer Changing the palette of a color index has as an immediate effect on all pixels with the corresponding index on real hardware. Performing a full update after a palette change is a simple way to emulate this effect. Signed-off-by: Sebastian Bauer Signed-off-by: BALATON Zolta

[Qemu-devel] [PATCH 3/5] sm501: Use values from the pitch register for 2d operations

2018-06-21 Thread BALATON Zoltan
From: Sebastian Bauer Before, crt_h_total was used for src_width and dst_width. This is a property of the current display setting and not relevant for the 2d operation that also can be done off-screen. The pitch register's purpose is to describe line pitch relevant of the 2d operation. Signed-of

[Qemu-devel] [PATCH 5/5] sm501: Fix support for non-zero frame buffer start address

2018-06-21 Thread BALATON Zoltan
Display updates and drawing hardware cursor did not work when frame buffer address was non-zero. Fix this by taking the frame buffer address into account in these cases. This fixes screen dragging on AmigaOS. Based on patch by Sebastian Bauer. Signed-off-by: Sebastian Bauer Signed-off-by: BALATON

[Qemu-devel] [PATCH 4/5] sm501: Set updated region dirty after 2D operation

2018-06-21 Thread BALATON Zoltan
Set the changed memory region dirty after performed a 2D operation to ensure that the screen is updated properly. Signed-off-by: BALATON Zoltan --- hw/display/sm501.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/display/sm501.c b/hw/display/sm501.c index a6232ed..e426d2f 100644 --

Re: [Qemu-devel] [PATCH 00/113] Patch Round-up for stable 2.11.2, freeze on 2018-06-22

2018-06-21 Thread Cornelia Huck
ferable. We'd also want the corresponding > > patches for pc-bios/s390-ccw reflected in the 2.11.x tree. > > Er, sorry was a bit confused. I suppose that part is covered already if > there's no additional patches needed in the rebuild other than what's in > 2.11.

[Qemu-devel] [PATCH] qapi: Fix some pycodestyle-3 complaints

2018-06-21 Thread Markus Armbruster
Fix the following issues: common.py:873:13: E129 visually indented line with same indent as next logical line common.py:1766:5: E741 ambiguous variable name 'l' common.py:1784:1: E305 expected 2 blank lines after class or function definition, found 1 common.py:1833:1: E305 expect

Re: [Qemu-devel] [PATCH v5 1/7] hmp: Add flag for preconfig commands

2018-06-21 Thread Igor Mammedov
On Wed, 20 Jun 2018 16:39:41 +0100 "Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > Add a flag to command definitions to allow them to be used in preconfig > and check it. > If users try to use commands that aren't available, tell them to use > the exit_preconfig coman

Re: [Qemu-devel] [PULL v2 01/57] docker: docker.py wrap StringIO import for python3

2018-06-21 Thread Peter Maydell
On 21 June 2018 at 07:25, Alex Bennée wrote: > Although the docker.py is nominally python2 we actually invoke it with > the configured python from the configure script. > > Signed-off-by: Alex Bennée > > diff --git a/tests/docker/docker.py b/tests/docker/docker.py > index 306e14cf69..e4095270eb 1

Re: [Qemu-devel] [PATCH v5 5/7] hmp: Add commands for preconfig

2018-06-21 Thread Igor Mammedov
On Wed, 20 Jun 2018 16:39:45 +0100 "Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > Allow a bunch of the info commands to be used in preconfig. > > version, chardev, name, uuid,memdev, iothreads > Were enabled in QMP in the previous patch from Igor > > status, hotp

Re: [Qemu-devel] [PULL 0/7] bitmap export over NBD

2018-06-21 Thread Peter Maydell
On 21 June 2018 at 04:19, Eric Blake wrote: > The following changes since commit 46012db666990ff2eed1d3dc199ab8006439a93b: > > Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20180619' into > staging (2018-06-20 09:51:30 +0100) > > are available in the Git repository at: > > git://rep

Re: [Qemu-devel] [PULL v2 01/57] docker: docker.py wrap StringIO import for python3

2018-06-21 Thread Daniel P . Berrangé
On Thu, Jun 21, 2018 at 09:49:55AM +0100, Peter Maydell wrote: > On 21 June 2018 at 07:25, Alex Bennée wrote: > > Although the docker.py is nominally python2 we actually invoke it with > > the configured python from the configure script. > > > > Signed-off-by: Alex Bennée > > > > diff --git a/tes

Re: [Qemu-devel] [PATCH] qapi: Fix some pycodestyle-3 complaints

2018-06-21 Thread Daniel P . Berrangé
On Thu, Jun 21, 2018 at 10:35:51AM +0200, Markus Armbruster wrote: > Fix the following issues: > > common.py:873:13: E129 visually indented line with same indent as next > logical line > common.py:1766:5: E741 ambiguous variable name 'l' > common.py:1784:1: E305 expected 2 blank lines

[Qemu-devel] [GIT PULL for qemu-pseries] pseries: Update SLOF firmware image to qemu-slof-20180621

2018-06-21 Thread Alexey Kardashevskiy
The following changes since commit 840d3ddc259b70a7b4e1ba367945cc31a45c93c6: pseries: Update SLOF firmware image to qemu-slof-20180621 (2018-06-21 19:16:26 +1000) are available in the git repository at: g...@github.com:aik/qemu.git tags/qemu-slof-20180621 for you to fetch changes up to

Re: [Qemu-devel] [PATCH 5/9] spapr: Maximum (HPT) pagesize property

2018-06-21 Thread Greg Kurz
On Mon, 18 Jun 2018 16:36:02 +1000 David Gibson wrote: > The way the POWER Hash Page Table (HPT) MMU is virtualized by KVM HV means > that every page that the guest puts in the pagetables must be truly > physically contiguous, not just GPA-contiguous. In effect this means that > an HPT guest can

Re: [Qemu-devel] [PATCH] nbd/client: add x-block-status hack for testing server

2018-06-21 Thread no-reply
Hi, This series failed build test on s390x host. Please find the details below. Type: series Message-id: 20180621032539.134944-1-ebl...@redhat.com Subject: [Qemu-devel] [PATCH] nbd/client: add x-block-status hack for testing server === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be

Re: [Qemu-devel] [PATCH v3 1/4] tpm: implement virtual memory device for TPM PPI

2018-06-21 Thread Igor Mammedov
On Tue, 15 May 2018 14:14:30 +0200 Marc-André Lureau wrote: > From: Stefan Berger > > Implement a virtual memory device for the TPM Physical Presence interface. > The memory is located at 0xfffef000 and used by ACPI to send messages to the > firmware (BIOS) and by the firmware to provide parame

Re: [Qemu-devel] [PATCH v15 07/12] migration: Synchronize multifd threads with main thread

2018-06-21 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > We synchronize all threads each RAM_SAVE_FLAG_EOS. Bitmap > synchronizations don't happen inside a ram section, so we are safe > about two channels trying to overwrite the same memory. > > Signed-off-by: Juan Quintela Note the testing didn't like

Re: [Qemu-devel] [PATCH v3 2/4] acpi: add fw_cfg file for TPM and PPI virtual memory device

2018-06-21 Thread Igor Mammedov
On Tue, 15 May 2018 14:14:31 +0200 Marc-André Lureau wrote: > From: Stefan Berger > > To avoid having to hard code the base address of the PPI virtual > memory device we introduce a fw_cfg file etc/tpm/config that holds the > base address of the PPI device, the version of the PPI interface and

Re: [Qemu-devel] [PATCH v1 3/3] scsi-block: adding flag at realize to enable Block Limits emulation

2018-06-21 Thread Paolo Bonzini
On 08/06/2018 22:07, Daniel Henrique Barboza wrote: > The previous patches implemented a way to deliver an emulated > Block Limits (BL) response for the guest in case the underlying > hardware does not support this page. > > However, the approach used is crude. We're executing the logic for > all

Re: [Qemu-devel] [PATCH v1 1/3] scsi-block: emulate missing Block Limits response

2018-06-21 Thread Paolo Bonzini
On 08/06/2018 22:07, Daniel Henrique Barboza wrote: > +unsigned int unmap_sectors = s->conf.discard_granularity / s->blocksize; > +unsigned int min_io_size = s->conf.min_io_size / s->blocksize; > +unsigned int opt_io_size = s->conf.opt_io_size / s->blocksize; > +unsigned int max_unm

Re: [Qemu-devel] [PATCH] qemu-options: Add missing newline to -accel help text

2018-06-21 Thread Paolo Bonzini
On 11/06/2018 21:56, Eduardo Habkost wrote: > The newline was removed by commit c97d6d2c, and broke -help output: > > Before this patch: > > $ qemu-system-x86_64 -help | grep smp > thread=single|multi (enable multi-threaded TCG)-smp [...] > > After this patch: > > $ qemu-s

Re: [Qemu-devel] [RFC 5/6] hw/arm/virt: support kvm_type property

2018-06-21 Thread Auger Eric
Hi David, On 06/20/2018 07:15 PM, Dr. David Alan Gilbert wrote: > * Eric Auger (eric.au...@redhat.com) wrote: >> The kvm-type property currently is used to pass >> a user parameter to KVM_CREATE_VM. This matches >> the way KVM/ARM expects to pass the max_vm_phys_shift >> parameter. >> >> This patc

Re: [Qemu-devel] [PATCH v5 4/6] nbd/server: implement dirty bitmap export

2018-06-21 Thread Vladimir Sementsov-Ogievskiy
20.06.2018 21:09, Eric Blake wrote: On 06/20/2018 12:04 PM, Vladimir Sementsov-Ogievskiy wrote: 20.06.2018 19:27, Eric Blake wrote: On 06/09/2018 10:17 AM, Vladimir Sementsov-Ogievskiy wrote: Handle new NBD meta namespace: "qemu", and corresponding queries: "qemu:dirty-bitmap:". With new meta

Re: [Qemu-devel] [PATCH v3 2/4] acpi: add fw_cfg file for TPM and PPI virtual memory device

2018-06-21 Thread Marc-André Lureau
Hi On Thu, Jun 21, 2018 at 12:00 PM, Igor Mammedov wrote: > On Tue, 15 May 2018 14:14:31 +0200 > Marc-André Lureau wrote: > >> From: Stefan Berger >> >> To avoid having to hard code the base address of the PPI virtual >> memory device we introduce a fw_cfg file etc/tpm/config that holds the >>

Re: [Qemu-devel] [PATCH v5 5/6] qapi: new qmp command nbd-server-add-bitmap

2018-06-21 Thread Vladimir Sementsov-Ogievskiy
20.06.2018 21:14, Eric Blake wrote: On 06/20/2018 09:13 AM, Vladimir Sementsov-Ogievskiy wrote: 20.06.2018 14:26, Eric Blake wrote: On 06/09/2018 10:17 AM, Vladimir Sementsov-Ogievskiy wrote: Signed-off-by: Vladimir Sementsov-Ogievskiy ---   qapi/block.json | 23 +++   bloc

Re: [Qemu-devel] [PULL 5/7] nbd/server: implement dirty bitmap export

2018-06-21 Thread Vladimir Sementsov-Ogievskiy
21.06.2018 06:19, Eric Blake wrote: From: Vladimir Sementsov-Ogievskiy Handle a new NBD meta namespace: "qemu", and corresponding queries: "qemu:dirty-bitmap:". With the new metadata context negotiated, BLOCK_STATUS query will reply with dirty-bitmap data, converted to extents. The new public

[Qemu-devel] [PATCH v2 1/6] qga: refactoring qmp_guest_suspend_* functions

2018-06-21 Thread Daniel Henrique Barboza
To be able to add new suspend mechanisms we need to detach the existing QMP functions from the current implementation specifics. At this moment we have functions such as qmp_guest_suspend_ram calling bios_suspend_mode and guest_suspend passing the pmutils command and arguments as parameters. This

[Qemu-devel] [PATCH v2 2/6] qga: bios_supports_mode: decoupling pm-utils and sys logic

2018-06-21 Thread Daniel Henrique Barboza
In bios_supports_mode there is a verification to assert if the chosen suspend mode is supported by the pmutils tools and, if not, we see if the Linux sys state files supports it. This verification is done in the same function, one after the other, and it works for now. But, when adding a new suspe

[Qemu-devel] [PATCH v2 0/6] QGA: systemd hibernate/suspend/hybrid-sleep

2018-06-21 Thread Daniel Henrique Barboza
changes in v2 from Marc-Andre Lureau review: - use error_free() accordingly - use g_spawn_sync() instead of fork() in run_process_child() - previous version link: https://lists.gnu.org/archive/html/qemu-devel/2018-06/msg05499.html This series adds systemd suspend support for QGA. Some newer guest

Re: [Qemu-devel] [PATCH v5 5/6] qapi: new qmp command nbd-server-add-bitmap

2018-06-21 Thread Nikolay Shirokovskiy
On 20.06.2018 17:13, Vladimir Sementsov-Ogievskiy wrote: > 20.06.2018 14:26, Eric Blake wrote: >> On 06/09/2018 10:17 AM, Vladimir Sementsov-Ogievskiy wrote: >>> Signed-off-by: Vladimir Sementsov-Ogievskiy >>> --- >>>   qapi/block.json | 23 +++ >>>   blockdev-nbd.c  | 23 +++

[Qemu-devel] [PATCH v2 4/6] qga: removing switch statements, adding run_process_child

2018-06-21 Thread Daniel Henrique Barboza
This is a cleanup of the resulting code after detaching pmutils and Linux sys state file logic: - remove the SUSPEND_MODE_* macros and use an enumeration instead. At the same time, drop the switch statements at the start of each function and use the enumeration index to get the right binary/argume

[Qemu-devel] [PATCH v2 3/6] qga: guest_suspend: decoupling pm-utils and sys logic

2018-06-21 Thread Daniel Henrique Barboza
Following the same logic of the previous patch, let's also decouple the suspend logic from guest_suspend into specialized functions, one for each strategy we support at this moment. Signed-off-by: Daniel Henrique Barboza --- qga/commands-posix.c | 170 +++

[Qemu-devel] [PATCH v2 5/6] qga: systemd hibernate/suspend/hybrid-sleep support

2018-06-21 Thread Daniel Henrique Barboza
pmutils isn't being supported by newer OSes like Fedora 27 or Mint. This means that the only suspend option QGA offers for these guests are writing directly into the Linux sys state file. This also means that QGA also loses the ability to do hybrid suspend in those guests - this suspend mode is onl

Re: [Qemu-devel] [PATCH v2 03/10] qcow2/bitmap: cache bm_list

2018-06-21 Thread Vladimir Sementsov-Ogievskiy
21.06.2018 02:29, John Snow wrote: On 06/20/2018 09:04 AM, Vladimir Sementsov-Ogievskiy wrote: 13.06.2018 05:06, John Snow wrote: We don't need to re-read this list every time, exactly. We can keep it cached and delete our copy when we flush to disk. Because we don't try to flush bitmaps on c

[Qemu-devel] [PATCH v2 6/6] qga: removing bios_supports_mode

2018-06-21 Thread Daniel Henrique Barboza
bios_support_mode verifies if the guest has support for a certain suspend mode but it doesn't inform back which suspend tool provides it. The caller, guest_suspend, executes all suspend strategies in order again. After adding systemd suspend support, bios_support_mode now will verify for support f

Re: [Qemu-devel] [PATCH 6/9] spapr: Use maximum page size capability to simplify memory backend checking

2018-06-21 Thread Greg Kurz
On Mon, 18 Jun 2018 16:36:03 +1000 David Gibson wrote: > The way we used to handle KVM allowable guest pagesizes for PAPR guests > required some convoluted checking of memory attached to the guest. > > The allowable pagesizes advertised to the guest cpus depended on the memory > which was attach

Re: [Qemu-devel] [PATCH v2] postcopy: drop ram_pages parameter from postcopy_ram_incoming_init()

2018-06-21 Thread Dr. David Alan Gilbert
* David Hildenbrand (da...@redhat.com) wrote: > Not needed. Don't expose last_ram_page(). > > Signed-off-by: David Hildenbrand Ah nice find; that disappeared part way through the review of my postcopy series. Reviewed-by: Dr. David Alan Gilbert > --- > > v1 -> v2: > - Make "last_ram_page" s

Re: [Qemu-devel] [PATCH 0/9] spapr: Clean up pagesize handling

2018-06-21 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180618063606.2513-1-da...@gibson.dropbear.id.au Subject: [Qemu-devel] [PATCH 0/9] spapr: Clean up pagesize handling === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 tot

Re: [Qemu-devel] regression: sata cdrom boot broken

2018-06-21 Thread Paolo Bonzini
On 20/06/2018 22:28, John Snow wrote: > > ...Oh. So the PIO Setup FIS ... gets generated before the data is sent, > but we don't copy it to the HBA memory buffers and notify the client > until afterwards, but this is per-DRQ, I think, and not per-IDE command. No, the copy happens before: "When a

Re: [Qemu-devel] [PATCH v3 1/4] tpm: implement virtual memory device for TPM PPI

2018-06-21 Thread Marc-André Lureau
Hi On Thu, Jun 21, 2018 at 11:49 AM, Igor Mammedov wrote: > On Tue, 15 May 2018 14:14:30 +0200 > Marc-André Lureau wrote: > >> From: Stefan Berger >> >> Implement a virtual memory device for the TPM Physical Presence interface. >> The memory is located at 0xfffef000 and used by ACPI to send mes

Re: [Qemu-devel] [PATCH v2 00/22] target/openrisc improvements

2018-06-21 Thread Stafford Horne
On Mon, Jun 18, 2018 at 08:40:24AM -1000, Richard Henderson wrote: > This is almost a grab-bag of little improvements to the port. > > patches 1-3: > Fix singlestepping for gdbstub. This has apparently never > worked, as the first commit has the same bug of not advancing > the pc when stepp

[Qemu-devel] [Bug 1776478] Re: Getting qemu: uncaught target signal 6 when running lv2 plugin cross-compilation

2018-06-21 Thread guysoft
@pmaydell Is there anything I can do to help speed this up? I can run tests or make reproduction easier if that helps. But I need direction what actually helps you. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpa

Re: [Qemu-devel] [PATCH v5 5/7] hmp: Add commands for preconfig

2018-06-21 Thread Dr. David Alan Gilbert
* Igor Mammedov (imamm...@redhat.com) wrote: > On Wed, 20 Jun 2018 16:39:45 +0100 > "Dr. David Alan Gilbert (git)" wrote: > > > From: "Dr. David Alan Gilbert" > > > > Allow a bunch of the info commands to be used in preconfig. > > > > version, chardev, name, uuid,memdev, iothreads > > Were e

Re: [Qemu-devel] [PATCH v2 3/4] hw/arm/sysbus-fdt: Replace error_setg(&error_fatal) by error_report() + exit()

2018-06-21 Thread Philippe Mathieu-Daudé
Hi Markus, On 06/08/2018 03:27 AM, Markus Armbruster wrote: > Philippe Mathieu-Daudé writes: > >> Use error_report() + exit() instead of error_setg(&error_fatal), >> as suggested by the "qapi/error.h" documentation: >> >>Please don't error_setg(&error_fatal, ...), use error_report() and >>

Re: [Qemu-devel] [PATCH v2 1/7] s390x/tod: factor out TOD into separate device

2018-06-21 Thread Thomas Huth
On 20.06.2018 12:08, David Hildenbrand wrote: > Let's treat this like a separate device. TCG will have to store the > actual state/time later on. > > Include cpu-qom.h in kvm_s390x.h (due to S390CPU) to compile tod-kvm.c. > > Signed-off-by: David Hildenbrand > --- [...] > +static void s390_tod_c

[Qemu-devel] [PATCH v3 3/4] hw/arm/smmuv3: IOTLB emulation

2018-06-21 Thread Eric Auger
We emulate a TLB cache of size SMMU_IOTLB_MAX_SIZE=256. It is implemented as a hash table whose key is a combination of the 16b asid and 48b IOVA (Jenkins hash). Entries are invalidated on TLB invalidation commands, either globally, or per asid, or per asid/iova. Signed-off-by: Eric Auger --- v

[Qemu-devel] [PATCH v3 0/4] ARM SMMUv3: IOTLB Emulation and VHOST Support

2018-06-21 Thread Eric Auger
This series brings translation configuration caching and IOTLB emulation. The last patch implements VHOST integration and allows to run VSMMUv3 along with VHOST emulated end points. The first patch fixes the passthrough mode bug reported by Jia. It reworks the translate function and this series ne

[Qemu-devel] [PATCH v3 2/4] hw/arm/smmuv3: Cache/invalidate config data

2018-06-21 Thread Eric Auger
Let's cache config data to avoid fetching and parsing STE/CD structures on each translation. We invalidate them on data structure invalidation commands. We put in place a per-smmu mutex to protect the config cache. This will be useful too to protect the IOTLB cache. The caches can be accessed with

[Qemu-devel] [PATCH v3 1/4] hw/arm/smmuv3: Fix translate error handling

2018-06-21 Thread Eric Auger
From: Jia He In case the STE's config is "Bypass" we currently don't set the IOMMUTLBEntry perm flags and the access does not succeed. Also if the config is 0b0xx (Aborted/Reserved), decode_ste and smmuv3_decode_config currently returns -EINVAL and we don't enter the expected code path: we record

[Qemu-devel] [PATCH v3 4/4] hw/arm/smmuv3: Add notifications on invalidation

2018-06-21 Thread Eric Auger
On TLB invalidation commands, let's call registered IOMMU notifiers. Those can only be UNMAP notifiers. SMMUv3 does not support notification on MAP (VFIO). This patch allows vhost use case where IOTLB API is notified on each guest IOTLB invalidation. Signed-off-by: Eric Auger Reviewed-by: Peter

Re: [Qemu-devel] [PATCH v2] monitor: report entirety of hmp command on error

2018-06-21 Thread Dr. David Alan Gilbert
* Collin Walling (wall...@linux.ibm.com) wrote: > When a user incorrectly provides an hmp command, an error response will be > printed that prompts the user to try "help ". However, when > the command contains multiple parts e.g. "info uuid xyz", only the last > whitespace delimited string will be

Re: [Qemu-devel] [RFC 3/6] kvm: add kvm_get_max_vm_phys_shift

2018-06-21 Thread Auger Eric
Hi David, On 06/21/2018 02:37 AM, David Gibson wrote: > On Wed, Jun 20, 2018 at 03:07:30PM +0200, Eric Auger wrote: >> Add the kvm_get_max_vm_phys_shift() helper that returns the >> log of the maximum IPA size supported by KVM. This capability >> needs to be known to create the VM with a correct I

Re: [Qemu-devel] regression: sata cdrom boot broken

2018-06-21 Thread Paolo Bonzini
On 20/06/2018 20:15, Thomas Huth wrote: > On 20.06.2018 13:07, Gerd Hoffmann wrote: >> Hi, >> >> $subject says all. Noticed while testing the upcoming seabios update. >> Reproducer: >> >> qemu-system-x86_64 -M q35 -m 4G -cdrom >> Fedora-Workstation-Live-x86_64-28-1.1.iso > > Once this has be

Re: [Qemu-devel] [PATCH] qapi: Fix some pycodestyle-3 complaints

2018-06-21 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Thu, Jun 21, 2018 at 10:35:51AM +0200, Markus Armbruster wrote: >> Fix the following issues: >> >> common.py:873:13: E129 visually indented line with same indent as next >> logical line >> common.py:1766:5: E741 ambiguous variable name 'l' >> common.p

Re: [Qemu-devel] [PATCH v2 00/22] target/openrisc improvements

2018-06-21 Thread Richard Henderson
On 06/21/2018 01:00 AM, Stafford Horne wrote: > Thanks for these, I think there are a few white space issues throughout. Do > you > mind if I take these and clean them up (indent with space) and work on the DSX > and Interrupt issue I mentioned earlier? > > I can submit all during the next merge

Re: [Qemu-devel] [PATCH] qapi: Fix some pycodestyle-3 complaints

2018-06-21 Thread Markus Armbruster
Forgot tests/qapi-schema/test-qapi.py, as usual. To be squashed in: diff --git a/tests/qapi-schema/test-qapi.py b/tests/qapi-schema/test-qapi.py index 4512a41504..abbc9c7830 100644 --- a/tests/qapi-schema/test-qapi.py +++ b/tests/qapi-schema/test-qapi.py @@ -33,8 +33,8 @@ class QAPISchemaTestVisi

Re: [Qemu-devel] [PATCH 6/9] spapr: Use maximum page size capability to simplify memory backend checking

2018-06-21 Thread David Gibson
On Thu, Jun 21, 2018 at 08:29:36AM +0200, Cédric Le Goater wrote: > On 06/18/2018 08:36 AM, David Gibson wrote: > > The way we used to handle KVM allowable guest pagesizes for PAPR guests > > required some convoluted checking of memory attached to the guest. > > > > The allowable pagesizes adverti

Re: [Qemu-devel] [PATCH 5/9] spapr: Maximum (HPT) pagesize property

2018-06-21 Thread David Gibson
On Thu, Jun 21, 2018 at 08:22:15AM +0200, Cédric Le Goater wrote: > On 06/18/2018 08:36 AM, David Gibson wrote: > > The way the POWER Hash Page Table (HPT) MMU is virtualized by KVM HV means > > that every page that the guest puts in the pagetables must be truly > > physically contiguous, not just

Re: [Qemu-devel] [PATCH 6/9] spapr: Use maximum page size capability to simplify memory backend checking

2018-06-21 Thread David Gibson
On Thu, Jun 21, 2018 at 12:29:14PM +0200, Greg Kurz wrote: > On Mon, 18 Jun 2018 16:36:03 +1000 > David Gibson wrote: [snip] > > @@ -304,6 +305,23 @@ static void > > cap_safe_indirect_branch_apply(sPAPRMachineState *spapr, > > > > #define VALUE_DESC_TRISTATE " (broken, workaround, fixed)"

Re: [Qemu-devel] [PATCH 5/9] spapr: Maximum (HPT) pagesize property

2018-06-21 Thread David Gibson
On Thu, Jun 21, 2018 at 11:19:41AM +0200, Greg Kurz wrote: > On Mon, 18 Jun 2018 16:36:02 +1000 > David Gibson wrote: > > > The way the POWER Hash Page Table (HPT) MMU is virtualized by KVM HV means > > that every page that the guest puts in the pagetables must be truly > > physically contiguous,

Re: [Qemu-devel] [GIT PULL for qemu-pseries] pseries: Update SLOF firmware image to qemu-slof-20180621

2018-06-21 Thread David Gibson
On Thu, Jun 21, 2018 at 07:18:52PM +1000, Alexey Kardashevskiy wrote: > The following changes since commit 840d3ddc259b70a7b4e1ba367945cc31a45c93c6: > > pseries: Update SLOF firmware image to qemu-slof-20180621 (2018-06-21 > 19:16:26 +1000) > > are available in the git repos

Re: [Qemu-devel] [PATCH v2 2/7] s390x/tcg: drop tod_basetime

2018-06-21 Thread Thomas Huth
On 20.06.2018 12:08, David Hildenbrand wrote: > Never set to anything but 0. > > Signed-off-by: David Hildenbrand > --- > target/s390x/cpu.c | 1 - > target/s390x/cpu.h | 1 - > target/s390x/misc_helper.c | 4 ++-- > 3 files changed, 2 insertions(+), 4 deletions(-) Reviewed-by:

[Qemu-devel] [PATCH v3 1/3] hw/block/fdc: Replace error_setg(&error_abort) by assert()

2018-06-21 Thread Philippe Mathieu-Daudé
Use assert() instead of error_setg(&error_abort), as suggested by the "qapi/error.h" documentation: Please don't error_setg(&error_fatal, ...), use error_report() and exit(), because that's more obvious. Likewise, don't error_setg(&error_abort, ...), use assert(). Signed-off-by: Phili

[Qemu-devel] [PATCH v3 2/3] hw/arm/sysbus-fdt: Replace error_setg(&error_fatal) by error_report() + exit()

2018-06-21 Thread Philippe Mathieu-Daudé
Use error_report() + exit() instead of error_setg(&error_fatal), as suggested by the "qapi/error.h" documentation: Please don't error_setg(&error_fatal, ...), use error_report() and exit(), because that's more obvious. This fixes CID 1352173: "Passing null pointer dt_name to qemu_fdt_no

[Qemu-devel] [PATCH v3 0/3] qapi/error: converts error_setg(&error_fatal) to error_report() + exit()

2018-06-21 Thread Philippe Mathieu-Daudé
Hi, This series converts error_setg(&error_fatal) to error_report() + exit() as suggested by the "qapi/error.h" documentation. This reduce Coverity and Clang static analyzer positive falses. See http://lists.nongnu.org/archive/html/qemu-devel/2017-07/msg07585.html: On 07/24/2017 04:52 PM, E

[Qemu-devel] [PATCH v3 3/3] device_tree: Replace error_setg(&error_fatal) by error_report() + exit()

2018-06-21 Thread Philippe Mathieu-Daudé
Use error_report() + exit() instead of error_setg(&error_fatal), as suggested by the "qapi/error.h" documentation: Please don't error_setg(&error_fatal, ...), use error_report() and exit(), because that's more obvious. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Eric Auger Reviewed

Re: [Qemu-devel] [PATCH] qapi: Fix some pycodestyle-3 complaints

2018-06-21 Thread Philippe Mathieu-Daudé
On 06/21/2018 05:35 AM, Markus Armbruster wrote: > Fix the following issues: > > common.py:873:13: E129 visually indented line with same indent as next > logical line > common.py:1766:5: E741 ambiguous variable name 'l' > common.py:1784:1: E305 expected 2 blank lines after class or fu

  1   2   3   4   >