On Thu, Jun 21, 2018 at 10:35:51AM +0200, Markus Armbruster wrote: > Fix the following issues: > > common.py:873:13: E129 visually indented line with same indent as next > logical line > common.py:1766:5: E741 ambiguous variable name 'l' > common.py:1784:1: E305 expected 2 blank lines after class or function > definition, found 1 > common.py:1833:1: E305 expected 2 blank lines after class or function > definition, found 1 > common.py:1843:1: E305 expected 2 blank lines after class or function > definition, found 1 > visit.py:181:18: E127 continuation line over-indented for visual indent > > Signed-off-by: Markus Armbruster <arm...@redhat.com> > --- > scripts/qapi/common.py | 15 +++++++++------ > scripts/qapi/visit.py | 2 +- > 2 files changed, 10 insertions(+), 7 deletions(-)
Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> If we care about pycodestyle-3 compliance, it is probably worth adding that to 'make check' to avoid people introducing regressions. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
