Re: [Qemu-devel] [PATCH 06/12] migration: do not detect zero page for compression

2018-06-19 Thread Peter Xu
On Mon, Jun 04, 2018 at 05:55:14PM +0800, guangrong.x...@gmail.com wrote: > From: Xiao Guangrong > > Detecting zero page is not a light work, we can disable it > for compression that can handle all zero data very well Is there any number shows how the compression algo performs better than the ze

Re: [Qemu-devel] [PATCH 07/12] migration: hold the lock only if it is really needed

2018-06-19 Thread Peter Xu
On Mon, Jun 04, 2018 at 05:55:15PM +0800, guangrong.x...@gmail.com wrote: > From: Xiao Guangrong > > Try to hold src_page_req_mutex only if the queue is not > empty Pure question: how much this patch would help? Basically if you are running compression tests then I think it means you are with p

Re: [Qemu-devel] [RFC v2 2/8] virtio: memory cache for packed ring

2018-06-19 Thread Wei Xu
On Wed, Jun 06, 2018 at 10:53:07AM +0800, Jason Wang wrote: > > > On 2018年06月06日 03:07, w...@redhat.com wrote: > >From: Wei Xu > > > >Mostly reuse memory cache with 1.0 except for the offset calculation. > > > >Signed-off-by: Wei Xu > >--- > > hw/virtio/virtio.c | 29 --

Re: [Qemu-devel] [RFC v2 0/8] packed ring virtio-net userspace backend support

2018-06-19 Thread Wei Xu
On Wed, Jun 06, 2018 at 11:49:22AM +0800, Jason Wang wrote: > > > On 2018年06月06日 03:07, w...@redhat.com wrote: > >From: Wei Xu > > > >Todo: > >- address Rx slow performance > >- event index interrupt suppression test > > And there's something more need to test: > > - vIOMMU support > - migratio

Re: [Qemu-devel] [PATCH 00/113] Patch Round-up for stable 2.11.2, freeze on 2018-06-22

2018-06-19 Thread Cornelia Huck
On Mon, 18 Jun 2018 20:41:26 -0500 Michael Roth wrote: > Hi everyone, > > The following new patches are queued for QEMU stable v2.11.2: > > https://github.com/mdroth/qemu/commits/stable-2.11-staging > > The release is planned for 2018-06-22: > > https://wiki.qemu.org/Planning/2.11 > > Pl

Re: [Qemu-devel] [RFC v2 8/8] virtio: guest driver reload for vhost-net

2018-06-19 Thread Wei Xu
On Wed, Jun 06, 2018 at 11:48:19AM +0800, Jason Wang wrote: > > > On 2018年06月06日 03:08, w...@redhat.com wrote: > >From: Wei Xu > > > >last_avail, avail_wrap_count, used_idx and used_wrap_count are > >needed to support vhost-net backend, all these are either 16 or > >bool variables, since state.n

Re: [Qemu-devel] [RFC v2 5/8] virtio: queue pop for packed ring

2018-06-19 Thread Wei Xu
On Wed, Jun 06, 2018 at 11:41:18AM +0800, Jason Wang wrote: > > > On 2018年06月06日 11:38, Wei Xu wrote: > >>>+ > >>>+head = vq->last_avail_idx; > >>>+i = head; > >>>+ > >>>+caches = vring_get_region_caches(vq); > >>>+cache = &caches->desc; > >>>+vring_packed_desc_read(vdev, &des

Re: [Qemu-devel] [PATCH v3 03/49] qapi: add 'if' to top-level expressions

2018-06-19 Thread Markus Armbruster
Marc-André Lureau writes: > Accept 'if' key in top-level elements, accepted as string or list of > string type. The following patches will modify the test visitor to > check the value is correctly saved, and generate #if/#endif code (as a > single #if/endif line or a series for a list). > > Examp

[Qemu-devel] [PATCH] target-arm: fix a segmentation fault due to illegal memory access

2018-06-19 Thread Zheng Xiang
From: Zheng Xiang The elements of kvm_devices_head list are freed in kvm_arm_machine_init_done(), but we still access these illegal memory in kvm_arm_devlistener_del(). This will cause segment fault when booting guest with MALLOC_PERTURB_=1. Signed-off-by: Zheng Xiang --- target/arm/kvm.c | 1

Re: [Qemu-devel] valgrind problem in sun4u_load_kernel()

2018-06-19 Thread Artyom Tarasenko
On Sun, Jun 17, 2018 at 12:22 PM, Mark Cave-Ayland wrote: > On 15/06/18 11:37, Thomas Huth wrote: > >> Hi Mark, hi Artyom, >> >> while using valgrind to fix some issues with the rom_ptr() function >> today, I noticed that there is one more problem in sun4u_load_kernel(): >> The kernel_top variab

Re: [Qemu-devel] [PATCH v4 10/12] nvdimm: convert nvdimm_mr into a pointer

2018-06-19 Thread David Hildenbrand
On 19.06.2018 08:54, Igor Mammedov wrote: > On Mon, 18 Jun 2018 16:25:34 +0200 > David Hildenbrand wrote: > >> This way we can easily check if the region has already been inititalized >> without having to rely on the size of an uninitialized region being 0. >> >> Reviewed-by: David Gibson >> Rev

Re: [Qemu-devel] [PATCH v3 04/49] qapi: pass 'if' condition into QAPISchemaEntity objects

2018-06-19 Thread Markus Armbruster
Marc-André Lureau writes: > Built-in objects remain unconditional. Explicitly defined objects > use the condition specified in the schema. Implicitly defined > objects inherit their condition from their users. For most of them, > there is exactly one user, so the condition to use is obvious.

Re: [Qemu-devel] [PATCH v3 03/49] qapi: add 'if' to top-level expressions

2018-06-19 Thread Marc-André Lureau
On Tue, Jun 19, 2018 at 9:57 AM, Markus Armbruster wrote: > Marc-André Lureau writes: > >> Accept 'if' key in top-level elements, accepted as string or list of >> string type. The following patches will modify the test visitor to >> check the value is correctly saved, and generate #if/#endif code

Re: [Qemu-devel] [Qemu-block] [RFC 1/1] ide: bug #1777315: io_buffer_size and sg.size can represent partial sector sizes

2018-06-19 Thread Kevin Wolf
Am 19.06.2018 um 06:01 hat Amol Surati geschrieben: > On Mon, Jun 18, 2018 at 08:14:10PM -0400, John Snow wrote: > > > > > > On 06/18/2018 02:02 PM, Amol Surati wrote: > > > On Mon, Jun 18, 2018 at 12:05:15AM +0530, Amol Surati wrote: > > >> This patch fixes the assumption that io_buffer_size is

Re: [Qemu-devel] [PATCH 1/3] device-crash-test: No need for sys.path hack

2018-06-19 Thread Daniel P . Berrangé
On Mon, Jun 18, 2018 at 07:51:29PM -0300, Eduardo Habkost wrote: > The device-crash-test script is already inside the 'scripts' > directory, there's no need to add the directory manually to > sys.path. > > Signed-off-by: Eduardo Habkost > --- > scripts/device-crash-test | 1 - > 1 file changed,

Re: [Qemu-devel] [PATCH 2/3] Revert "docker.py: Python 2.6 argparse compatibility"

2018-06-19 Thread Daniel P . Berrangé
On Mon, Jun 18, 2018 at 07:51:30PM -0300, Eduardo Habkost wrote: > This reverts commit c2d3189667409561772e8c1e5615c5166cd8aa2c. > > scripts/argparse.py was removed from the tree, so we don't need > this hack anymore. > > Signed-off-by: Eduardo Habkost > --- > tests/docker/docker.py | 4 +--- >

Re: [Qemu-devel] [PATCH 3/3] Revert "tests: migration/guestperf Python 2.6 argparse compatibility"

2018-06-19 Thread Daniel P . Berrangé
On Mon, Jun 18, 2018 at 07:51:31PM -0300, Eduardo Habkost wrote: > This reverts commit 0ea47d0f36112f0f38661e2e430edf32737c7f43. > > scripts/argparse.py was removed from the tree, so we don't > need this hack anymore. > > Signed-off-by: Eduardo Habkost > --- > tests/migration/guestperf/shell.py

[Qemu-devel] [PATCH qemu] xics-kvm: Fix compile warning

2018-06-19 Thread Alexey Kardashevskiy
This fixes uninitialized variable warning: /home/aik/p/qemu/hw/intc/xics_kvm.c: In function ‘ics_set_kvm_state’: /home/aik/p/qemu/hw/intc/xics_kvm.c:281:20: warning: ‘ret’ may be used uninitialized in this function [-Wmaybe-uninitialized] return ret; ^~~ Discover

Re: [Qemu-devel] [PATCH v3 26/26] hw/display: add vhost-user-vga & gpu-pci

2018-06-19 Thread Marc-André Lureau
Hi On Tue, Jun 19, 2018 at 8:54 AM, Gerd Hoffmann wrote: > Hi, > >> +VHOST_USER_GPU_SCANOUT, >> +VHOST_USER_GPU_UPDATE, >> +VHOST_USER_GPU_DMABUF_SCANOUT, >> +VHOST_USER_GPU_DMABUF_UPDATE, > > Hmm, still two command versions. > > I still think there should be no separate 2d code

Re: [Qemu-devel] [PATCH v3 10/26] vhost-user: split vhost_user_read()

2018-06-19 Thread Marc-André Lureau
Hi On Tue, Jun 19, 2018 at 8:23 AM, Gerd Hoffmann wrote: >> @@ -237,7 +251,7 @@ static int vhost_user_read(struct vhost_dev *dev, >> VhostUserMsg *msg) >> error_report("Failed to read msg header." >> " Size %d exceeds the maximum %zu.", msg->hdr.size, >>

Re: [Qemu-devel] [PATCH v3 03/26] dmabuf: add y0_top, pass it to spice

2018-06-19 Thread Marc-André Lureau
Hi On Tue, Jun 19, 2018 at 8:21 AM, Gerd Hoffmann wrote: > On Mon, Jun 18, 2018 at 06:17:06PM +0200, Marc-André Lureau wrote: >> Some scanouts during boot are top-down without this. >> >> Signed-off-by: Marc-André Lureau >> --- >> include/ui/console.h | 1 + >> ui/spice-display.c | 3 ++- >>

Re: [Qemu-devel] [PATCH v3 05/49] qapi: leave the ifcond attribute undefined until check()

2018-06-19 Thread Markus Armbruster
Marc-André Lureau writes: > We commonly initialize attributes to None in .init(), then set their > real value in .check(). Accessing the attribute before .check() > yields None. If we're lucky, the code that accesses the attribute > prematurely chokes on None. > > It won't for .ifcond, because

Re: [Qemu-devel] [PATCH v3 09/26] HACK: vhost-user-backend: allow to specify binary to execute

2018-06-19 Thread Daniel P . Berrangé
On Tue, Jun 19, 2018 at 08:19:03AM +0200, Gerd Hoffmann wrote: > On Mon, Jun 18, 2018 at 06:17:12PM +0200, Marc-André Lureau wrote: > > An executable with its arguments may be given as 'cmd' property, ex: > > -object vhost-user-backend,id=vui,cmd="./vhost-user-input > > /dev/input..". The executabl

[Qemu-devel] [PATCH v4 06/11] target/ppc: Add missing opcode for icbt on PPC440

2018-06-19 Thread BALATON Zoltan
According to PPC440 User Manual PPC440 has multiple opcodes for icbt instruction: one for compatibility with older cores and two 440 specific opcodes one of which is defined in BookE. QEMU only implements two of these, add the missing one. Signed-off-by: BALATON Zoltan --- v4: Updated commit mess

[Qemu-devel] [PATCH v4 07/11] sm501: Implement i2c part for reading monitor EDID

2018-06-19 Thread BALATON Zoltan
Emulate the i2c part of SM501 which is used to access the EDID info from a monitor. The vmstate structure is changed and its version is increased but SM501 is only used on SH and PPC sam460ex machines that don't support cross-version migration. Signed-off-by: BALATON Zoltan --- v4: Updated commi

[Qemu-devel] [PATCH v4 01/11] ppc4xx_i2c: Remove unimplemented sdata and intr registers

2018-06-19 Thread BALATON Zoltan
We don't emulate slave mode so related registers are not needed. [lh]sadr are only retained to avoid too many warnings and simplify debugging but sdata is not even correct because device has a 4 byte FIFO instead so just remove this unimplemented register for now. The intr register is also not imp

[Qemu-devel] [PATCH v4 03/11] ppc4xx_i2c: Rewrite to model hardware more closely

2018-06-19 Thread BALATON Zoltan
Rewrite to make it closer to how real device works so that guest OS drivers can access I2C devices. Previously this was only a hack to allow U-Boot to get past accessing SPD EEPROMs but to support other I2C devices and allow guests to access them we need to model real device more properly. Signed-

Re: [Qemu-devel] [PATCH] Add gles support to egl-helpers, wire up in egl-headless and gtk.

2018-06-19 Thread Tomeu Vizoso
Hi, have been running this patch since yesterday and everything seems fine. Tested-by: Tomeu Vizoso Reviewed-by: Tomeu Vizoso Thanks! Tomeu On 06/18/2018 01:21 PM, Gerd Hoffmann wrote: Add support for OpenGL ES to egl-helpers. Wire up the new option for egl-headless and gtk UIs. egl-head

[Qemu-devel] [PATCH v4 11/11] sm501: Fix support for non-zero frame buffer start address

2018-06-19 Thread BALATON Zoltan
Display updates and drawing hardware cursor did not work when frame buffer address was non-zero. Fix this by taking the frame buffer address into account in these cases. This fixes screen dragging on AmigaOS. Based on patch by Sebastian Bauer. Signed-off-by: Sebastian Bauer Signed-off-by: BALATON

[Qemu-devel] [PATCH v4 00/11] Misc sam460ex improvements

2018-06-19 Thread BALATON Zoltan
Next spin of sam460ex pathces with changes according to review and some new patches. BALATON Zoltan (8): ppc4xx_i2c: Remove unimplemented sdata and intr registers ppc4xx_i2c: Implement directcntl register ppc4xx_i2c: Rewrite to model hardware more closely hw/timer: Add basic M41T80 emula

[Qemu-devel] [PATCH v4 10/11] sm501: Set updated region dirty after 2D operation

2018-06-19 Thread BALATON Zoltan
Set the changed memory region dirty after performed a 2D operation to ensure that the screen is updated properly. Signed-off-by: BALATON Zoltan --- hw/display/sm501.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/display/sm501.c b/hw/display/sm501.c index e126c15..ad518ce 100644 --

[Qemu-devel] [PATCH v4 04/11] hw/timer: Add basic M41T80 emulation

2018-06-19 Thread BALATON Zoltan
Basic emulation of the M41T80 serial (I2C) RTC chip. Only getting time of day is implemented. Setting time and RTC alarm are not supported. Signed-off-by: BALATON Zoltan --- v3: Fixed \n-s in log messages MAINTAINERS | 1 + default-configs/ppc-softmmu.mak | 1 + hw/timer

[Qemu-devel] [PATCH v4 05/11] sam460ex: Add RTC device

2018-06-19 Thread BALATON Zoltan
The Sam460ex has an M41T80 serial RTC chip on I2C bus 0 at address 0x68. Signed-off-by: BALATON Zoltan --- hw/ppc/sam460ex.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/ppc/sam460ex.c b/hw/ppc/sam460ex.c index bdc53d2..dc730cc 100644 --- a/hw/ppc/sam460ex.c +++ b/hw/ppc/sam460ex.c @@

[Qemu-devel] [PATCH v4 02/11] ppc4xx_i2c: Implement directcntl register

2018-06-19 Thread BALATON Zoltan
As well as being able to generate its own i2c transactions, the ppc4xx i2c controller has a DIRECTCNTL register which allows explicit control of the i2c lines. Using this register an OS can directly bitbang i2c operations. In order to let emulated i2c devices respond to this, we need to wire up th

[Qemu-devel] [PATCH v4 08/11] sm501: Perform a full update after palette change

2018-06-19 Thread BALATON Zoltan
From: Sebastian Bauer Changing the palette of a color index has as an immediate effect on all pixels with the corresponding index on real hardware. Performing a full update after a palette change is a simple way to emulate this effect. Signed-off-by: Sebastian Bauer Signed-off-by: BALATON Zolta

Re: [Qemu-devel] [PATCH 5/9] spapr: Maximum (HPT) pagesize property

2018-06-19 Thread Cédric Le Goater
On 06/18/2018 08:36 AM, David Gibson wrote: > The way the POWER Hash Page Table (HPT) MMU is virtualized by KVM HV means > that every page that the guest puts in the pagetables must be truly > physically contiguous, not just GPA-contiguous. In effect this means that > an HPT guest can't use any pa

[Qemu-devel] [PATCH v4 09/11] sm501: Use values from the pitch register for 2d operations.

2018-06-19 Thread BALATON Zoltan
From: Sebastian Bauer Before, crt_h_total was used for src_width and dst_width. This is a property of the current display setting and not relevant for the 2d operation that also can be done off-screen. The pitch register's purpose is to describe line pitch relevant of the 2d operation. Signed-of

Re: [Qemu-devel] [PATCH v2 3/8] ppc4xx_i2c: Implement directcntl register

2018-06-19 Thread BALATON Zoltan
On Mon, 18 Jun 2018, David Gibson wrote: On Wed, Jun 13, 2018 at 04:03:18PM +0200, BALATON Zoltan wrote: On Wed, 13 Jun 2018, David Gibson wrote: On Wed, Jun 13, 2018 at 10:54:22AM +0200, BALATON Zoltan wrote: On Wed, 13 Jun 2018, David Gibson wrote: On Wed, Jun 06, 2018 at 03:31:48PM +0200,

[Qemu-devel] [PATCH v2 6/7] intc/arm_gic: Improve traces

2018-06-19 Thread luc . michel
From: Luc MICHEL Add some traces to the ARM GIC to catch register accesses (distributor, (v)cpu interface and virtual interface), and to take into account virtualization extensions (print `vcpu` instead of `cpu` when needed). Also add some virtualization extensions specific traces: LR updating a

[Qemu-devel] [PATCH v2 3/7] vmstate.h: Provide VMSTATE_UINT16_SUB_ARRAY

2018-06-19 Thread luc . michel
From: Luc MICHEL Provide a VMSTATE_UINT16_SUB_ARRAY macro to save a uint16_t sub-array in a VMState. Signed-off-by: Luc MICHEL --- include/migration/vmstate.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h index 42b946ce90..2b50

[Qemu-devel] [PATCH v2 1/7] intc/arm_gic: Refactor operations on the distributor

2018-06-19 Thread luc . michel
From: Luc MICHEL In preparation for the virtualization extensions implementation, refactor the name of the functions and macros that act on the GIC distributor to make that fact explicit. It will be useful to differentiate them from the ones that will act on the virtual interfaces. Signed-off-by

[Qemu-devel] [PATCH v2 2/7] intc/arm_gic: Remove some dead code and put some functions static

2018-06-19 Thread luc . michel
From: Luc MICHEL Some functions are now only used in arm_gic.c, put them static. Some of them where only used by the NVIC implementation and are not used anymore, so remove them. Signed-off-by: Luc MICHEL Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell --- hw/intc/arm_gic.c

[Qemu-devel] [PATCH v2 0/7] arm_gic: add virtualization extensions support

2018-06-19 Thread luc . michel
From: Luc MICHEL This patch series add support for the virtualization extensions in the ARM GICv2 interrupt controller. The first two commits do some refactoring to prepare for the implementation. Commits 3 and 4 are the actual implementation. The last commit updates the ZynqMP implementation to

[Qemu-devel] [PATCH v2 7/7] xlnx-zynqmp: Improve GIC wiring and MMIO mapping

2018-06-19 Thread luc . michel
From: Luc MICHEL This commit improve the way the GIC is realized and connected in the ZynqMP SoC. The security extensions are enabled only if requested in the machine state. The same goes for the virtualization extensions. All the GIC to APU CPU(s) IRQ lines are now connected, including FIQ, vIR

[Qemu-devel] [PATCH v2 5/7] intc/arm_gic: Add virtualization extensions logic

2018-06-19 Thread luc . michel
From: Luc MICHEL This commit adds the actual implementation of the GICv2 virtualization extensions logic. For the vCPU interfaces, most of the existing CPU interface code is reused. Calls to macros or functions modifying the distributor state are replaced with equivalent generic inline functions

[Qemu-devel] [PATCH v2 4/7] intc/arm_gic: Add the virtualization extensions to the GIC state

2018-06-19 Thread luc . michel
From: Luc MICHEL Add the necessary parts of the virtualization extensions state to the GIC state. We choose to increase the size of the CPU interfaces state to add space for the vCPU interfaces (the GIC_NCPU_VCPU macro). This way, we'll be able to reuse most of the CPU interface code for the vCPU

[Qemu-devel] Assertion bus->irq_count[i] == 0 in Qemu 2.9.0

2018-06-19 Thread Peter Lieven
Hi, ich habe some hosts running rather old Qemu Versions which sometimes show the following behaviour: 1) Live Migration 2) One Network Interface (virtio-net) stops forwarding traffic. 3) If I reboot the server I hit the following assertion qemu-2.9.0: hw/pci/pci.c:311: pcibus_reset: Asser

[Qemu-devel] [Bug 1775555] Re: guest migration 100% cpu freeze bug

2018-06-19 Thread Dr. David Alan Gilbert
But you've not seen it in any migration between non-skylake CPUs? Now that you've figured out it's skylake related, can you more easily repeat it? e.g. what happens if you set your own VM up and make it migrate back and forth between two hosts constantly; can you get that to fail? -- You receiv

Re: [Qemu-devel] [PATCH] target/arm: Minor cleanup for ARMv6-M 32-bit instructions

2018-06-19 Thread Stefan Hajnoczi
On Mon, Jun 18, 2018 at 10:46 PM, Julia Suvorova wrote: > The arrays were made static, "if" was simplified because V7M and V8M > define V6 feature. > > Signed-off-by: Julia Suvorova > --- > target/arm/translate.c | 27 +-- > 1 file changed, 13 insertions(+), 14 deletions(

Re: [Qemu-devel] [PATCH v2 3/3] spapr: introduce a fixed IRQ number space

2018-06-19 Thread Cédric Le Goater
On 06/19/2018 03:02 AM, David Gibson wrote: > On Mon, Jun 18, 2018 at 07:34:02PM +0200, Cédric Le Goater wrote: >> This proposal introduces a new IRQ number space layout using static >> numbers for all devices and a bitmap allocator for the MSI numbers >> which are negotiated by the guest at runtim

Re: [Qemu-devel] [PULL 0/7] Python queue, 2018-06-15

2018-06-19 Thread Peter Maydell
On 15 June 2018 at 20:13, Eduardo Habkost wrote: > The following changes since commit 2ef2f16781af9dee6ba6517755e9073ba5799fa2: > > Merge remote-tracking branch > 'remotes/dgilbert/tags/pull-migration-20180615a' into staging (2018-06-15 > 18:13:35 +0100) > > are available in the Git repository

Re: [Qemu-devel] [PATCH v4 11/12] nvdimm: make get_memory_region() perform checks and initialization

2018-06-19 Thread David Hildenbrand
On 19.06.2018 02:12, David Gibson wrote: > On Mon, Jun 18, 2018 at 04:25:35PM +0200, David Hildenbrand wrote: >> We might get a call to get_memory_region() before the device has been >> realized. We should return a consistent value, as the return value >> will e.g. later on be used in the pre_plug

Re: [Qemu-devel] [PATCH v3 03/26] dmabuf: add y0_top, pass it to spice

2018-06-19 Thread Marc-André Lureau
Hi On Tue, Jun 19, 2018 at 8:21 AM, Gerd Hoffmann wrote: > On Mon, Jun 18, 2018 at 06:17:06PM +0200, Marc-André Lureau wrote: >> Some scanouts during boot are top-down without this. >> >> Signed-off-by: Marc-André Lureau >> --- >> include/ui/console.h | 1 + >> ui/spice-display.c | 3 ++- >>

Re: [Qemu-devel] [Qemu-ppc] [PATCH] ppc: Include vga cirrus card into the compiling process

2018-06-19 Thread BALATON Zoltan
On Tue, 19 Jun 2018, David Gibson wrote: On Tue, Jun 19, 2018 at 06:32:55AM +0200, Sebastian Bauer wrote: Am 2018-06-19 01:55, schrieb David Gibson: Have you checked the Cirrus VGA actually works on a ppc machine? Yes, it works for AmigaOS guests. Better than the sm501 for instance. Ok. Ho

Re: [Qemu-devel] [PATCH] target-arm: fix a segmentation fault due to illegal memory access

2018-06-19 Thread no-reply
Hi, This series failed build test on s390x host. Please find the details below. N/A. Internal error while reading log file --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@redhat.com

Re: [Qemu-devel] [PATCH] hmp-commands: use long for begin and length in dump-guest-memory

2018-06-19 Thread Dr. David Alan Gilbert
* Suraj Jitindar Singh (sjitindarsi...@gmail.com) wrote: > The dump-guest-memory command is used to dump an area of guest memory > to a file, the piece of memory is specified by a begin address and > a length. These parameters are specified as ints and thus have a maximum > value of 4GB. This means

Re: [Qemu-devel] [Qemu-ppc] [PATCH] ppc: Include vga cirrus card into the compiling process

2018-06-19 Thread Sebastian Bauer
Am 2018-06-19 12:23, schrieb BALATON Zoltan: On Tue, 19 Jun 2018, David Gibson wrote: Ok. However, your patch doesn't apply against the ppc-for-3.0 tree. It looks like you've made it against a tree including some of BALATON Zoltan's proposed but not yet merged patches. I've sent those patches

Re: [Qemu-devel] [PATCH v4 1/2] qapi: Open files with encoding='utf-8'

2018-06-19 Thread Eduardo Habkost
On Tue, Jun 19, 2018 at 08:28:08AM +0200, Markus Armbruster wrote: > Eduardo Habkost writes: > > > On Mon, Jun 18, 2018 at 07:59:57PM +0200, Markus Armbruster wrote: > >> Python 2 happily reads UTF-8 files in text mode, but Python 3 requires > >> either UTF-8 locale or an explicit encoding passed

[Qemu-devel] [RFC] Add NRF51 RNG peripheral

2018-06-19 Thread Steffen Görtz
Add a model of the NRF51 RNG peripheral. Signed-off-by: Steffen Görtz --- hw/misc/Makefile.objs | 1 + hw/misc/nrf51_rng.c | 241 include/hw/misc/nrf51_rng.h | 61 + 3 files changed, 303 insertions(+) create mode 100644 hw/misc/nrf51

Re: [Qemu-devel] [virtio-dev] Re: [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-19 Thread Cornelia Huck
On Fri, 15 Jun 2018 10:06:07 -0700 Siwei Liu wrote: > On Fri, Jun 15, 2018 at 4:48 AM, Cornelia Huck wrote: > > On Thu, 14 Jun 2018 18:57:11 -0700 > > Siwei Liu wrote: > > > >> Thank you for sharing your thoughts, Cornelia. With questions below, I > >> think you raised really good points, som

Re: [Qemu-devel] [Qemu-ppc] [PATCH] ppc: Include vga cirrus card into the compiling process

2018-06-19 Thread Thomas Huth
On 19.06.2018 12:46, Sebastian Bauer wrote: [...] > In my opinion, it should be added to pci.mak (and removed from all > present configs that include pci.mak). There is also CONFIG_VGA_PCI > there, a bunch of network cards and other stuff. The Cirrus VGA is just > another PCI card that one could pl

Re: [Qemu-devel] [Qemu-ppc] [PATCH] ppc: Include vga cirrus card into the compiling process

2018-06-19 Thread Thomas Huth
On 19.06.2018 12:23, BALATON Zoltan wrote: [...] > Also what about ppcemb-softmmu? It's deprecated but do we still want to > update it until it's removed or deprecated means no new features are > added to it? I've also updated ppcemb config in my other patches to keep > sam460ex working there the s

Re: [Qemu-devel] [PATCH v4 1/2] qapi: Open files with encoding='utf-8'

2018-06-19 Thread Eric Blake
On 06/18/2018 12:59 PM, Markus Armbruster wrote: Python 2 happily reads UTF-8 files in text mode, but Python 3 requires either UTF-8 locale or an explicit encoding passed to open(). Commit d4e5ec877ca fixed this by setting the en_US.UTF-8 locale. Falls apart when the locale isn't be available.

Re: [Qemu-devel] [PATCH v4 2/2] Revert commit d4e5ec877ca

2018-06-19 Thread Eric Blake
On 06/18/2018 12:59 PM, Markus Armbruster wrote: From: Matthias Maier This commit removes the PYTHON_UTF8 workaround. The problem with setting LC_ALL= LANG=C LC_CTYPE=en_US.UTF-8 is that the en_US.UTF-8 locale might not be available. In this case setting above locales results in build erro

Re: [Qemu-devel] [PATCH for-2.11.2] spapr: make pseries-2.11 the default machine type

2018-06-19 Thread Greg Kurz
On Mon, 18 Jun 2018 21:04:38 -0500 Michael Roth wrote: > Quoting Greg Kurz (2018-05-22 12:17:28) > > The spapr capability framework was introduced in QEMU 2.12. It allows > > to have an explicit control on how host features are exposed to the > > guest. This is especially needed to handle migrati

Re: [Qemu-devel] [PULL 00/13] Python queue, 2018-06-11

2018-06-19 Thread Peter Maydell
On 11 June 2018 at 18:42, Eduardo Habkost wrote: > The following changes since commit 0d2fa03dae4fbe185a082f361342b1e30aed4582: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20180608' into staging (2018-06-08 > 16:26:51 +0100) > > are available in the Git repository

Re: [Qemu-devel] [PATCH v3 10/26] vhost-user: split vhost_user_read()

2018-06-19 Thread Gerd Hoffmann
On Tue, Jun 19, 2018 at 11:01:00AM +0200, Marc-André Lureau wrote: > Hi > > On Tue, Jun 19, 2018 at 8:23 AM, Gerd Hoffmann wrote: > >> @@ -237,7 +251,7 @@ static int vhost_user_read(struct vhost_dev *dev, > >> VhostUserMsg *msg) > >> error_report("Failed to read msg header." > >>

Re: [Qemu-devel] [Qemu-block] [PATCH v4 10/10] block/blklogwrites: Use the block device logical sector size when logging writes

2018-06-19 Thread Alberto Garcia
On Mon 18 Jun 2018 05:53:50 PM CEST, Ari Sundholm wrote: > On 06/18/2018 06:36 PM, Alberto Garcia wrote: >> On Fri 08 Jun 2018 02:32:28 PM CEST, Ari Sundholm wrote: >>> The guest OS may perform writes which are aligned to the logical >>> sector size instead of the physical one, so logging at this g

Re: [Qemu-devel] [Qemu-ppc] [PATCH qemu] xics-kvm: Fix compile warning

2018-06-19 Thread Greg Kurz
On Tue, 19 Jun 2018 18:56:31 +1000 Alexey Kardashevskiy wrote: > This fixes uninitialized variable warning: > > /home/aik/p/qemu/hw/intc/xics_kvm.c: In function ‘ics_set_kvm_state’: > /home/aik/p/qemu/hw/intc/xics_kvm.c:281:20: warning: ‘ret’ may be used > uninitialized in this function [-Wmayb

Re: [Qemu-devel] [PATCH v3 03/49] qapi: add 'if' to top-level expressions

2018-06-19 Thread Markus Armbruster
Marc-André Lureau writes: > On Tue, Jun 19, 2018 at 9:57 AM, Markus Armbruster wrote: >> Marc-André Lureau writes: >> >>> Accept 'if' key in top-level elements, accepted as string or list of >>> string type. The following patches will modify the test visitor to >>> check the value is correctly

Re: [Qemu-devel] [PATCH] MAINTAINERS: update target-mips maintainers

2018-06-19 Thread Yongbok Kim
On 18/06/2018 19:29, Aleksandar Markovic wrote: From: Aleksandar Markovic Yongbok Kim transfers duties of QEMU for target MIPS maintainer to myself as he leaves MIPS. Many thanks to Yongbok for his substantial contributing to QEMU for MIPS over many years and taking care of its maintainance for

Re: [Qemu-devel] [PATCH qemu] xics-kvm: Fix compile warning

2018-06-19 Thread Markus Armbruster
Alexey Kardashevskiy writes: > This fixes uninitialized variable warning: > > /home/aik/p/qemu/hw/intc/xics_kvm.c: In function ‘ics_set_kvm_state’: > /home/aik/p/qemu/hw/intc/xics_kvm.c:281:20: warning: ‘ret’ may be used > uninitialized in this function [-Wmaybe-uninitialized] > ret

Re: [Qemu-devel] [PATCH v4 2/2] Revert commit d4e5ec877ca

2018-06-19 Thread Markus Armbruster
Eric Blake writes: > On 06/18/2018 12:59 PM, Markus Armbruster wrote: >> From: Matthias Maier >> >> This commit removes the PYTHON_UTF8 workaround. The problem with setting >> >>LC_ALL= LANG=C LC_CTYPE=en_US.UTF-8 >> >> is that the en_US.UTF-8 locale might not be available. In this case >> s

Re: [Qemu-devel] [PATCH v4 2/7] monitor: rename *_pop_one to *_pop_any

2018-06-19 Thread Eric Blake
On 06/19/2018 12:34 AM, Peter Xu wrote: The old names are confusing since both of the old functions are poping s/poping/popping/ an item from multiple queues rather than a single queue. In that sense, *_pop_any() suites better than *_pop_one(). Since at it, touch up the function monitor_qmp

Re: [Qemu-devel] [PATCH v4 1/2] qapi: Open files with encoding='utf-8'

2018-06-19 Thread Markus Armbruster
Eduardo Habkost writes: > On Tue, Jun 19, 2018 at 08:28:08AM +0200, Markus Armbruster wrote: >> Eduardo Habkost writes: >> >> > On Mon, Jun 18, 2018 at 07:59:57PM +0200, Markus Armbruster wrote: >> >> Python 2 happily reads UTF-8 files in text mode, but Python 3 requires >> >> either UTF-8 loca

Re: [Qemu-devel] [Qemu-stable] [PATCH 00/113] Patch Round-up for stable 2.11.2, freeze on 2018-06-22

2018-06-19 Thread Greg Kurz
On Mon, 18 Jun 2018 20:41:26 -0500 Michael Roth wrote: > Hi everyone, > > The following new patches are queued for QEMU stable v2.11.2: > > https://github.com/mdroth/qemu/commits/stable-2.11-staging > > The release is planned for 2018-06-22: > > https://wiki.qemu.org/Planning/2.11 > > Pl

Re: [Qemu-devel] [PULL 00/28] ppc-for-3.0 queue 20180618

2018-06-19 Thread Peter Maydell
On 18 June 2018 at 04:52, David Gibson wrote: > The following changes since commit 2ef2f16781af9dee6ba6517755e9073ba5799fa2: > > Merge remote-tracking branch > 'remotes/dgilbert/tags/pull-migration-20180615a' into staging (2018-06-15 > 18:13:35 +0100) > > are available in the Git repository at

Re: [Qemu-devel] [PATCH v4 2/2] Revert commit d4e5ec877ca

2018-06-19 Thread Markus Armbruster
Markus Armbruster writes: > From: Matthias Maier > > This commit removes the PYTHON_UTF8 workaround. The problem with setting > > LC_ALL= LANG=C LC_CTYPE=en_US.UTF-8 > > is that the en_US.UTF-8 locale might not be available. In this case > setting above locales results in build errors even tho

Re: [Qemu-devel] [PATCH v3 01/26] chardev: avoid crash if no associated address

2018-06-19 Thread Daniel P . Berrangé
On Mon, Jun 18, 2018 at 06:17:04PM +0200, Marc-André Lureau wrote: > A socket chardev may not have associated address (when adding client > fd manually for example). But on disconnect, updating socket filename > expects an address and may lead to this crash: > > Thread 1 "qemu-system-x86" receiv

[Qemu-devel] [PULL 03/12] vfio-ccw: remove orb.c64 (64 bit data addresses) check

2018-06-19 Thread Cornelia Huck
From: Halil Pasic The vfio-ccw module does the check too, and there is actually no technical obstacle for supporting fmt 1 idaws. Let us be ready for the beautiful day when fmt 1 idaws become supported by the vfio-ccw kernel module. QEMU does not have to do a thing for that, except not insisting

[Qemu-devel] [PULL 05/12] s390x/cpumodels: add z14 Model ZR1

2018-06-19 Thread Cornelia Huck
From: Christian Borntraeger Introduce the new z14 Model ZR1 cpu model. Mostly identical to z14, only the cpu type differs (3906 vs. 3907) Signed-off-by: Christian Borntraeger Message-Id: <20180613081819.147178-1-borntrae...@de.ibm.com> Reviewed-by: David Hildenbrand Signed-off-by: Cornelia Huc

[Qemu-devel] [PULL 01/12] virtio-ccw: clean up notify

2018-06-19 Thread Cornelia Huck
From: Halil Pasic Coverity recently started complaining about virtio_ccw_notify(). Turns out, there is a couple of things that can be cleaned up. Let's clean! Reported-by: Peter Maydell Fixes: CID 1390619 Signed-off-by: Halil Pasic Message-Id: <20180516132757.68558-1-pa...@linux.ibm.com> Sig

[Qemu-devel] [PULL 00/12] next round of s390x patches

2018-06-19 Thread Cornelia Huck
The following changes since commit 2ef2f16781af9dee6ba6517755e9073ba5799fa2: Merge remote-tracking branch 'remotes/dgilbert/tags/pull-migration-20180615a' into staging (2018-06-15 18:13:35 +0100) are available in the Git repository at: git://github.com/cohuck/qemu tags/s390x-201

[Qemu-devel] [PULL 02/12] vfio-ccw: add force unlimited prefetch property

2018-06-19 Thread Cornelia Huck
From: Halil Pasic There is at least one guest (OS) such that although it does not rely on the guarantees provided by ORB 1 word 9 bit (aka unlimited prefetch, aka P bit) not being set, it fails to tell this to the machine. Usually this ain't a big deal, as the original purpose of the P bit is to

[Qemu-devel] [PATCH] hw/pci-host/xilinx-pcie: don't make "io" region be RAM

2018-06-19 Thread Peter Maydell
Currently we use memory_region_init_rom_nomigrate() to create the "io" memory region to pass to pci_register_root_bus(). This is a dummy region, because this PCI controller doesn't support accesses to PCI IO space. There is no reason for the dummy region to be a RAM region; it is only used as a pl

[Qemu-devel] [PULL 09/12] pc-bios/s390-ccw/net: Add support for pxelinux-style config files

2018-06-19 Thread Cornelia Huck
From: Thomas Huth Since it is quite cumbersome to manually create a combined kernel with initrd image for network booting, we now support loading via pxelinux configuration files, too. In these files, the kernel, initrd and command line parameters can be specified seperately, and the firmware the

[Qemu-devel] [PULL 06/12] pc-bios/s390-ccw: define loadparm length

2018-06-19 Thread Cornelia Huck
From: Collin Walling Loadparm is defined by the s390 architecture to be 8 bytes in length. Let's define this size in the s390-ccw bios. Suggested-by: Laszlo Ersek Signed-off-by: Collin Walling Reviewed-by: Laszlo Ersek Reviewed-by: Thomas Huth Signed-off-by: Thomas Huth --- pc-bios/s390-cc

[Qemu-devel] [PULL 10/12] pc-bios/s390-ccw/net: Try to load pxelinux.cfg file accoring to the UUID

2018-06-19 Thread Cornelia Huck
From: Thomas Huth With the STSI instruction, we can get the UUID of the current VM instance, so we can support loading pxelinux config files via UUID in the file name, too. Acked-by: Christian Borntraeger Tested-by: Viktor Mihajlovski Signed-off-by: Thomas Huth --- pc-bios/s390-ccw/netmain.c

[Qemu-devel] [PULL 04/12] s390x/ipl: Try to detect Linux vs non Linux for initial IPL PSW

2018-06-19 Thread Cornelia Huck
From: Christian Borntraeger Right now the IPL device always starts from address 0x1 (the usual Linux entry point). To run other guests (e.g. test programs) it is useful to use the IPL PSW from address 0. We can use the Linux magic at 0x10008 to decide. Signed-off-by: Christian Borntraeger M

[Qemu-devel] [PULL 08/12] pc-bios/s390-ccw/net: Update code for the latest changes in SLOF

2018-06-19 Thread Cornelia Huck
From: Thomas Huth The ip_version information now has to be stored in the filename_ip_t structure, and there is now a common function called tftp_get_error_info() which can be used to get the error string for a TFTP error code. We can also get rid of some superfluous "(char *)" casts now. Acked-b

Re: [Qemu-devel] [PULL 00/13] Python queue, 2018-06-11

2018-06-19 Thread Peter Maydell
On 19 June 2018 at 13:05, Eduardo Habkost wrote: > On Tue, Jun 19, 2018 at 12:13:41PM +0100, Peter Maydell wrote: >> Hi; I noticed that running configure on my machine can now produce a >> python traceback from docker.py: >> >> make: Entering directory '/home/petmay01/linaro/qemu-for-merges/build/

[Qemu-devel] [PULL 07/12] roms: Update SLOF submodule to current status

2018-06-19 Thread Cornelia Huck
From: Thomas Huth We need the latest version of SLOF's libnet for adding pxelinux.cfg support in the s390-ccw bios, too. Signed-off-by: Thomas Huth --- roms/SLOF | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/roms/SLOF b/roms/SLOF index fa981320a1..2317427ce7 16 --- a/

[Qemu-devel] [PULL 11/12] pc-bios/s390-ccw: Optimize the s390-netboot.img for size

2018-06-19 Thread Cornelia Huck
From: Thomas Huth The -O2 optimization flag is passed via CFLAGS to the firmware Makefile, but in netbook.mak, we've got some rules that only use QEMU_CFLAGS for compiling the libc and libnet from SLOF, so these files get compiled without optimization so far. Use CFLAGS here, too, to create faste

Re: [Qemu-devel] [PATCH v4 1/2] qapi: Open files with encoding='utf-8'

2018-06-19 Thread Daniel P . Berrangé
On Tue, Jun 19, 2018 at 07:50:32AM -0300, Eduardo Habkost wrote: > On Tue, Jun 19, 2018 at 08:28:08AM +0200, Markus Armbruster wrote: > > Eduardo Habkost writes: > > > > > On Mon, Jun 18, 2018 at 07:59:57PM +0200, Markus Armbruster wrote: > > >> Python 2 happily reads UTF-8 files in text mode, bu

[Qemu-devel] [PULL 12/12] pc-bios/s390-ccw: Update the s390-netboot.img binary

2018-06-19 Thread Cornelia Huck
From: Thomas Huth This binary now contains the support for pxelinux.cfg-style network booting. Signed-off-by: Thomas Huth --- pc-bios/s390-netboot.img | Bin 87872 -> 54944 bytes 1 file changed, 0 insertions(+), 0 deletions(-) diff --git a/pc-bios/s390-netboot.img b/pc-bios/s390-netboot.img i

Re: [Qemu-devel] [PULL 00/13] Python queue, 2018-06-11

2018-06-19 Thread Eduardo Habkost
On Tue, Jun 19, 2018 at 12:13:41PM +0100, Peter Maydell wrote: > On 11 June 2018 at 18:42, Eduardo Habkost wrote: > > The following changes since commit 0d2fa03dae4fbe185a082f361342b1e30aed4582: > > > > Merge remote-tracking branch > > 'remotes/pmaydell/tags/pull-target-arm-20180608' into stagi

[Qemu-devel] [Bug 1775555] Re: guest migration 100% cpu freeze bug

2018-06-19 Thread Frank Schreuder
We have done over 30.000 migrations (of different VMs) between non- Skylake CPUs from qemu 2.6 to 2.11 and have never encountered the "100% freeze bug". That's why I'm sure it's related to Skylake (Intel(R) Xeon(R) Gold 6126) CPU. I'm testing migrations with my own VM between Skylake and non-Skyla

Re: [Qemu-devel] [RFC PATCH 06/10] block: Allow changing the backing file on reopen

2018-06-19 Thread Alberto Garcia
On Mon 18 Jun 2018 06:12:29 PM CEST, Kevin Wolf wrote: >> >> This patch allows the user to change the backing file of an image >> >> that is being reopened. Here's what it does: >> >> >> >> - In bdrv_reopen_queue_child(): if the 'backing' option points to an >> >>image different from the curr

Re: [Qemu-devel] [PATCH 2/2] WHPX: register for unrecognized MSR exits

2018-06-19 Thread Paolo Bonzini
On 19/06/2018 00:01, Justin Terry (VM) wrote: > The issue is that the Windows Hypervisor Platform will return #GP for > any rdmsr/wrmsr that is not a virtualized MSR in the hypervisor by > default. A virt stack (QEMU) can override this default behavior by > registering for MSR exits. In this config

Re: [Qemu-devel] [PATCH 6/6] monitor: deprecate acl_show, acl_reset, acl_policy, acl_add, acl_remove

2018-06-19 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > The various ACL related commands are obsolete now that the QAuthZ > framework for authorization is fully integrated throughout QEMU network > services. Mark it as deprecated with no replacement to be provided. > > Signed-off-by: Daniel P. Berrang

  1   2   3   4   >